Skip to main content
Topic: Alt+S (Read 2524 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Alt+S

Just wanted to express some love for the guy who had the idea to automatically detect whether you are quick editing or quick replying, and start the action correctly.
Example:
Elk: I type a quick reply and press alt+s - it gets posted
I edit my post with quick editor and press alt+s - it edits the message correctly

SMF:I type a quick reply and press alt+s - it gets posted
I edit my post with quick editor and press alt+s - throws an error about empty message body.

Dis iz giniuz!
~ SimplePortal Support Team ~

Re: Alt+S

Reply #1

I think it's a bug I fixed in 2.1 code... or maybe it was someone else. :P
Bugs creator.
Features destroyer.
Template killer.

Re: Alt+S

Reply #2

I got onto their GitHub and lost half an hour trying to look for the fix. If you remember something even vaguely please let me know before I start to yell at their unlabeled sh!t xD
~ SimplePortal Support Team ~

Re: Alt+S

Reply #3

The only thing I remember (well, it's more logic than remember) is that when the quick-edit is started the code must remove the shortcut from the "post" button of the quick-reply and attach it to the other button and when is saved it must add it back.
Bugs creator.
Features destroyer.
Template killer.

Re: Alt+S

Reply #4

I could get there on my own XD But code-wise it's another thing :P
~ SimplePortal Support Team ~

Re: Alt+S

Reply #5

i iz steal dat idea :D
LiveGallery - Simple gallery addon for ElkArte

Re: Alt+S

Reply #6

Wait, wasn't it already fixed for smf 2.1?
~ SimplePortal Support Team ~

Re: Alt+S

Reply #7

Yay for more bugs.
LiveGallery - Simple gallery addon for ElkArte

 

Re: Alt+S

Reply #8

Uuh I probably misunderstood ema.... When he said "It's a bug I fixed in 2.1" I got that he fixed it in 2.1 repo, but I start to think he was referring to it being fixed in Elkarte, and bugged in 2.1.
~ SimplePortal Support Team ~