ElkArte Community

Elk Development => Bug Reports => Topic started by: Ruth on February 27, 2023, 08:05:35 am

Title: Likes and Quickbuttons dont work
Post by: Ruth on February 27, 2023, 08:05:35 am
Hi!

Not sure, if it is a feature, a bug or just me.  :wink:

I cannot give likes in a fixed topic. Would have liked to give a like to Spuds here:

https://www.elkarte.net/community/index.php?topic=6215.0

But only Radu did like Spuds post so far. Maybe this is, because Radu is a Global Moderator?

In other topics the likes work for me.



Another thing is, that the quickbuttons dont work for me anymore,
"quote" and "quick edit" dont react anymore if i try to use this buttons.

I am on my laptop with windows 10 and use Firefox as browser.
Also made a try with Opera. It is the same with this browser for me
Title: Re: Likes and Quickbuttons dont work
Post by: DeadMan on February 27, 2023, 08:32:50 am
By fixed topic, do you mean locked?
Title: Re: Likes and Quickbuttons dont work
Post by: Ruth on February 27, 2023, 08:35:59 am
No, i meant "fixed", like this topic from Spuds with the announcement:

https://www.elkarte.net/community/index.php?topic=6215.0

It is not locked, just fixed.

Title: Re: Likes and Quickbuttons dont work
Post by: radu81 on February 27, 2023, 10:00:41 am
It is not a bug, the permission were set this way, don't know if @Spuds disabled the likes in that board by mistake or it was intended

@Burke_Knight  Fixed topic = Pinned topic :wink: 
Title: Re: Likes and Quickbuttons dont work
Post by: Spuds on February 27, 2023, 10:29:11 am
TBH I'm not sure what how/what permissions are setup on that board.
Quote from: Ruth – Another thing is, that the quickbuttons dont work for me anymore,
"quote" and "quick edit" dont react anymore if i try to use this buttons.
Is anyone else seeing this behavior?  Could be a bug or could be you need to clear your browser cache for the site (CTRL + Shift + R -or- F5) OH also which theme are you using.
Title: Re: Likes and Quickbuttons dont work
Post by: Ruth on February 27, 2023, 03:22:54 pm
I am using the default theme here, Spuds
Browser cache has been cleared a few times now....also cookies
This is done automatically every time, when I close browser,
but I also did it a few times more now.

Still the same: Those quick buttons are there, but i cannot use them

Title: Re: Likes and Quickbuttons dont work
Post by: Steeley on February 27, 2023, 04:53:41 pm
Quote from: Spuds – TBH I'm not sure what how/what permissions are setup on that board.
Quote from: Ruth – Another thing is, that the quickbuttons dont work for me anymore,
"quote" and "quick edit" dont react anymore if i try to use this buttons.
Is anyone else seeing this behavior?  Could be a bug or could be you need to clear your browser cache for the site (CTRL + R or F5) OH also which theme are you using.

That particular board has/had a number of issues - such as attachments give error messages (reported here (https://www.elkarte.net/community/index.php?topic=6217.msg44599#msg44599)). Maybe more that hasn't been tried by us "layfolk" yet.

Quote and Quick edit (of your own post) works, but yea, "Likes" have been turned off, unless maybe you're "special".. 😜  (which I'm not, either... 🤷‍♂️ )
Title: Re: Likes and Quickbuttons dont work
Post by: DeadMan on March 17, 2023, 12:38:30 pm
Been having to click the Like button several times, in multiple boards here to get it to actually work.
I did 2 likes today, and had a heck of a time doing so.
Title: Re: Likes and Quickbuttons dont work
Post by: Spuds on March 17, 2023, 02:57:26 pm
I've noticed that myself ..... but I've been unable to determine why its happening.  I think its a defer issue on loading but I'm honestly not sure, but is is darn annoying !
Title: Re: Likes and Quickbuttons dont work
Post by: Ruth on March 17, 2023, 11:16:11 pm
I also noticed, that I need to do a refresh after I read a new post, otherwise there will be still a "new"  in Info Center or in the boards.

This with the not reacting quick buttons is still the same for me. I cannot use them.
Title: Re: Likes and Quickbuttons dont work
Post by: Ruth on March 17, 2023, 11:58:37 pm
Quote from: Ruth – This with the not reacting quick buttons is still the same for me. I cannot use them.

At least the "quote" is working now again for me. I changed my layout settings in profile here.
Without displaying the quick reply, the quote button is working.
Title: Re: Likes and Quickbuttons dont work
Post by: Spuds on March 21, 2023, 02:52:39 pm
I did find an error in the like function in Elk2.0

I don't know if it was causing all of the errors, so let me know if you are still experiencing issues clicking the like button (anyone)  As always its a new JS so clear your browser site cache (CTRL+R or SHFT+CTRL+R)

As for quote or edit not working, that I have not been able to reproduce nor have I experienced any issues with those functions.  What OS and browser are you using ?  Has anyone else had a problem with those ? 
Title: Re: Likes and Quickbuttons dont work
Post by: DeadMan on March 21, 2023, 03:01:22 pm
Quote from: Spuds – I did find an error in the like function in Elk2.0

I don't know if it was causing all of the errors, so let me know if you are still experiencing issues clicking the like button (anyone)  As always its a new JS so clear your browser site cache (CTRL+R or SHFT+CTRL+R)

As for quote or edit not working, that I have not been able to reproduce nor have I experienced any issues with those functions.  What OS and browser are you using ?  Has anyone else had a problem with those ? 


Like and quote seem to work now without issue for me.
Title: Re: Likes and Quickbuttons dont work
Post by: radu81 on March 21, 2023, 04:07:59 pm
Quote from: Spuds – clear your browser site cache (CTRL+R or SHFT+CTRL+R)
Ctrl + F5 always worked for me
Title: Re: Likes and Quickbuttons dont work
Post by: Steeley on March 21, 2023, 04:51:21 pm
The topic originally squawked still has missing "Like" buttons in most (but not all) posts .. I presume that is not related to this particular fix.

FWIW, I've not personally observed the phenomenon of a "Like" button not working in any other board or topic. Might be purely happenstance, but for the record I'm using MS Edge [111.0.1661.44 (Official build) (64-bit) with a bunch of obnoxious 'defaults' disabled].  
Title: Re: Likes and Quickbuttons dont work
Post by: DeadMan on March 21, 2023, 05:59:04 pm
Quote from: Steeley – The topic originally squawked still has missing "Like" buttons in most (but not all) posts .. I presume that is not related to this particular fix.

For me, those that are visible can't be liked, so it's just showing because they have current likes.
No idea what is up with that. The topic is not locked, so likes should still be enabled for that topic.
Title: Re: Likes and Quickbuttons dont work
Post by: Steeley on March 21, 2023, 07:31:47 pm
Quote from: Burke_Knight – For me, those that are visible can't be liked, so it's just showing because they have current likes.
No idea what is up with that. The topic is not locked, so likes should still be enabled for that topic.

Ah - yes .. confirmed.  Not only do some posts not have a "Like" Button, but those that do don't work.. I suspect that has to do with the Topic Permissions being fiddled with (Initially "Likes" enabled, then set to disabled, later set to enabled again, later still disabled again..) Not sure who has admin privileges to do that.. dueling admins? Or maybe they just be messing with us, eh?  :shocked:
Title: Re: Likes and Quickbuttons dont work
Post by: Spuds on March 21, 2023, 08:31:53 pm
Just wait until the ElkArte files come out !!
Title: Re: Likes and Quickbuttons dont work
Post by: Steeley on March 21, 2023, 09:11:21 pm
I wonder if Section 230 (https://en.wikipedia.org/wiki/Section_230) covers any of this..  :tongue:  :rolleyes:
Title: Re: Likes and Quickbuttons dont work
Post by: DeadMan on March 21, 2023, 09:11:45 pm


Lack of sleep had me seeing this instead to begin with:

ElkArte flies

 :laugh:
Title: Re: Likes and Quickbuttons dont work
Post by: it is just me on March 22, 2023, 06:50:05 am
Hi!

This is me as well: Ruth

I fear, this is forbidden, what i did now, registering a second account. :embarrassed:  But i wanted to test it.
There are no problems at all with this new account. The quick edit button is working fine with my new name.

I really don't know, what is wrong with my first account here. I changed the settings in profile a few times now for testing, if something might change. Yesterday I also tried to change the themes here for testing, if maybe the quick buttons will work better in another theme. I hardly could change back to the default theme then. Needed to try this a few times.

Ruth is an "old account" registerd long ago before newer ElkArte Versions had been used. Maybe the problems I have now with this account are caused by "older settings" for normal users? No Idea.

Title: Re: Likes and Quickbuttons dont work
Post by: it is just me on March 22, 2023, 06:52:01 am
Quote from: it is just me – There are no problems at all with this new account. The quick edit button is working fine with my new name.

Quote button is working as well.
Title: Re: Likes and Quickbuttons dont work
Post by: DeadMan on March 22, 2023, 08:26:57 am
Quote from: it is just me – Ruth is an "old account" registerd long ago before newer ElkArte Versions had been used. Maybe the problems I have now with this account are caused by "older settings" for normal users? No Idea.

I'm trying to get access to my old account. If can, then I can check to see if have same issues with the old account as you are with the Ruth account.
Title: Re: Likes and Quickbuttons dont work
Post by: Steeley on March 22, 2023, 09:35:41 am
Quote from: it is just me –
Quote from: it is just me – There are no problems at all with this new account. The quick edit button is working fine with my new name.

Quote button is working as well.

I'd would assist, but I don't have an "old" account unless "old is anything more than, say,  one created in the last week (I tried to create an old account to test with but EA wouldn't let me... although I don't think that's a bug, @Spuds .. :zany_face:  ).

But I may be able to assist if:


If I can buy a clue, I'll see if I can help solve the puzzle.. Otherwise I'll just drop back to lurk, scratch my bald spot and finish my morning breve'.. 


Title: Re: Likes and Quickbuttons dont work
Post by: Ruth on March 22, 2023, 10:16:48 am
With my account "Ruth" it is the same in every board and topic here, no matter if I started the topic, or if I just replied to it.

Quoting with the quick buttons is working for me, since I changed the settings in my profile to "dont show quick reply" a few days ago.

But the quick edit does not work at all for "Ruth". I also tried it on very early posts of mine.

This account is 9 years old now, so i could at least imagine, that maybe older/newer settings for normal users could have caused this issue with the quick buttons for me. My browser is actuell, I also tried another one.
Title: Re: Likes and Quickbuttons dont work
Post by: Steeley on March 22, 2023, 11:03:03 am
@Ruth  - the only items I've got checked in my profile (direct copy/paste) are:

Additionally:

What isn't checked is:

My theme is the board default.

Pretty basic settings, methinks..

I wonder if you have different (legacy?) profile options..(maybe profile options you used to have, but were subsequently removed from selection, but still set in the database in conflict?) Hey, let me pluck that out of thin air..  :grimacing: 
Title: Re: Likes and Quickbuttons dont work
Post by: Ruth on March 22, 2023, 11:16:26 am
At the moment I have only 3 options enabled, before it was one more:

- Enable automatic saving of drafts
- Return to Topic after Posting
- Show quick-moderation checkboxes



Edit:

Now I have just this 2 enabled:

- Enable automatic saving of drafts
- Return to Topic after Posting


It is still the same: quick edit does not work for me.


Title: Re: Likes and Quickbuttons dont work
Post by: Steeley on March 22, 2023, 11:31:17 am
What happens if you set up the check boxes exactly like mine?  Quick Edit shows and works for me..

("Emanating into the penumbra" again, I wonder, if you are using the German translation files, if there's a an inadvertent "negation" of a setting meaning from English?)  
Title: Re: Likes and Quickbuttons dont work
Post by: Ruth on March 22, 2023, 11:39:18 am
Quote from: Steeley – What happens if you set up the check boxes exactly like mine? 

nothing :grin: I had it like this before.

Thank you for your help, Steeley. :smiley:


This with the quickbuttons is not really important to me. I can deal without quick edit...it is just a bit less comfortable.

But I think, there is something not okay with this behavior....for some reason.
Title: Re: Likes and Quickbuttons dont work
Post by: Steeley on March 22, 2023, 11:56:11 am
Well, something is different..
Only two things I can think of is either the OS/browser(s), or someone needs to open the database and compare your user profile fields to mine and see what, if anything, is different..

Of course, it could be almost anything and probably is..  :cry:

Edit: Scratch that, if you are using the same OS/Browser with the new account and it works, that's not it either..
Title: Re: Likes and Quickbuttons dont work
Post by: Spuds on March 22, 2023, 12:22:23 pm
I have figured this out ... Now I just need to come up with the fix :innocent:
Title: Re: Likes and Quickbuttons dont work
Post by: radu81 on March 22, 2023, 02:59:44 pm
Glad to hear you found the problem, I wasn't able to replicate this bug, but I admit I did not read all the topic.
Title: Re: Likes and Quickbuttons dont work
Post by: Spuds on March 22, 2023, 04:11:23 pm
The short of what I believe was occurring had to do with the quick reply area being minimized when "quote" was selected, causing a Javascript error.  This should be fixed now (refresh required)

When I updated the Quick Reply in 2.0, I neglected / improperly defined that minimize function.  In Ruth's case, she had minimized the Quick Reply section at some point  The system remembers that choice (it is not a profile option, it simply remembers your "hide/show" choice).  So hitting quote with the box minimized failed.

Now part B.  The original (inherited) behavior is, should the Quick Reply section be minimized then clicking "quote" would take you to the full page editor (the one where you can add attachments etc.).  Basically if QR was minimized it was "off" and if you wanted to use it, scroll down, expand, enter a response and maybe scroll back up to grab a quote.  I'm going to assume this was not a well know option/behavior.

As an experiment, I've changed that behavior to instead
- expand the Quick Reply area (assuming its minimized)
- insert the quote. 
- scroll it into view.

This is the same behavior you have when the Quick Reply is not minimized.  Note this does not change your hide/show preference, that will only change by you clicking on the expand/collapse icon.

Any thoughts on how the system should respond in the case where QR is minimized?  Auto expand and insert or bypass and jump to the full page post screen?
Title: Re: Likes and Quickbuttons dont work
Post by: Ruth on March 22, 2023, 05:32:20 pm
Quick edit and quote - both works again now for me, Spuds... great. :)

Quote from: Spuds – Any thoughts on how the system should respond in the case where QR is minimized?  Auto expand and insert or bypass and jump to the full page post screen?

I would prefer to have it in the full post screen.

But i dont like the quick reply very much anyway. I mostly have it minimized.
Title: Re: Likes and Quickbuttons dont work
Post by: Steeley on March 22, 2023, 06:07:04 pm
Ah, so I was correct. (I said it could be anything, and as it turned out, it was..)

I didn't even notice that QR could be minimized, the up/down chevron for that is pretty faint and, since I've used my eyes intensely all my life they're pretty worn out now, so apparently I just didn't notice it..

Very good, Spuds..
Title: Re: Likes and Quickbuttons dont work
Post by: DeadMan on March 22, 2023, 06:12:46 pm
Quote from: Spuds – Any thoughts on how the system should respond in the case where QR is minimized?  Auto expand and insert or bypass and jump to the full page post screen?

I'd just say have it auto-expand the QR.
If people want to multi-quote, going to full page post will make that difficult.
Title: Re: Likes and Quickbuttons dont work
Post by: Ruth on March 26, 2023, 11:51:44 pm
Yes, thats true....

The changings Spuds made now, had also another effect for me:

I can see again, who sent me private messages some years ago.  :smiley:
All user names had been gone before in my private messages, now they are there again.
Title: Re: Likes and Quickbuttons dont work
Post by: Jorin on March 27, 2023, 01:56:09 am
Can it be this bug is in 1.1.9 as well?

One of my members informed me he can't give likes in certain boards, while I still can. Can't figure out whats happening.  :embarrassed:
Title: Re: Likes and Quickbuttons dont work
Post by: radu81 on March 27, 2023, 02:30:43 am
Quote from: Jorin – he can't give likes in certain boards, while I still can. Can't figure out whats happening.
I'd say it's a permission thing, did you checked the permissions on that board?
Title: Re: Likes and Quickbuttons dont work
Post by: Jorin on March 27, 2023, 02:37:16 am
The board where he can't give likes (he actually don't see given likes there too) has standard permissions like most of my boards. The user profile is pretty standard too, nothing special.
Title: Re: Likes and Quickbuttons dont work
Post by: radu81 on March 27, 2023, 05:37:14 am
I don't think is the case, I had a user who reported that he cannot give likes, I checked 10 times all the permissions and in the end I discovered that he wanted to like his own post. :cheesy:
Like I said, I hope is not the case
Title: Re: Likes and Quickbuttons dont work
Post by: Ruth on March 27, 2023, 06:50:12 am
Yes, Radu....lol

But i think, if a user cannot see given likes as well in a topic, it has not to do with permissions/settings in this board. He would see the given likes then.

Jorin, you wrote "board", not "topics". You did not mean the like stats in the boards, you mean the likes in the topics?
Title: Re: Likes and Quickbuttons dont work
Post by: Spuds on March 27, 2023, 10:22:36 am
Quote from: Jorin – Can it be this bug is in 1.1.9 as well?
The likes issue was unique to 2.0 (due to the HTML markup changes).  Also the Quick Reply issue (when it was collapsed) was only a 2.0 issue, due to the new QR markup.

1.1.9 did make some changes to the likes markup, I outlined that here: https://www.elkarte.net/community/index.php?topic=6204.0  That change was to avoid ad blockers from disabling the like button.

Strange that your user is only seeing the issue on a specific board.  The like logic to allow using them is

0) the function is enabled
1) they have like permission
2) the topic is not locked
3) its not their post (if not allowed to like their own posts)
4) they are above the like post count to allow likes

They may see the counter if the post has like, even if they can't like the post for the above reasons.