ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Jorin on June 01, 2018, 03:01:32 am

Title: [1.1.3] inline images with full size
Post by: Jorin on June 01, 2018, 03:01:32 am
I attached an image and want it to be shown inline in my post. So I used the new function with size=full and alignment=none. Result: the image is shown in thumbnail size.

See: https://www.elkarte.net/community/index.php?topic=1450.msg37497#msg37497
Title: Re: [1.1.3] inline images with full size
Post by: Spuds on June 01, 2018, 08:57:24 am
This is another bug ... and maybe an inconsistency.

open ila.integrate.php (sources/subs) and comment out line 399 which says
Code: [Select]
$num .= !empty($modSettings['attachmentThumbnails']) ? ';thumb' : '';

I think the original ILA would show thumbnails for plain [attach]...[/attach] tags.  Now to get a thumbnail you have to specify [attach type=thumb]...[/attach] or maybe it was always that way, its been so long I can't remember  O:-)

The other bug/problem was that it was still showing the "normal" below the post thumbnail (when using just the plain attach tag), commenting out the above line fixes both issues.
Title: Re: [1.1.3] inline images with full size
Post by: Jorin on June 04, 2018, 02:47:44 am
I don't have this line in my file. And it ins not in my ILA.subs.php too.
Title: Re: [1.1.3] inline images with full size
Post by: Spuds on June 04, 2018, 08:26:17 am
LOL .. looks like @emanuele and I are fighting over the same chunk of code  O:-)  That was part of an 1.1.4 fix that I then changed another way.

Anyway, same line 399 ... you will find ;thumb towards the end, just remove that and give it a test.
Title: Re: [1.1.3] inline images with full size
Post by: Spuds on June 04, 2018, 08:32:31 am
Looking at the original bug report and this report they are related but I'm not sure what the correct ILA behavior is.

Currently in 1.1.4 [attach]some image[/attach] will always show a full size image inline.  To see a thumbnail you have to use type-thumb in the tag.   If this is a problem we need to discuss here and not at 1.1.5
Title: Re: [1.1.3] inline images with full size
Post by: emanuele on June 04, 2018, 12:54:10 pm
YAY! Fighting! :D
Title: Re: [1.1.3] inline images with full size
Post by: radu81 on June 04, 2018, 02:18:47 pm
Don't tell me you will make a convertor or a script to allow to use the old ila bbcodes on elkarte 1.1. I've edited about 500 messages manually  :)

Just kidding and sorry for the OT  :D
Title: Re: [1.1.3] inline images with full size
Post by: Jorin on June 04, 2018, 03:08:17 pm
I would love that and I would pay a little for it too.
Title: Re: [1.1.3] inline images with full size
Post by: Jorin on July 05, 2018, 03:59:59 am
Can you provide a fix here?

https://www.elkarte.net/community/index.php?topic=5331.0

Would be much better to show the pictures in full size...  O:-)
Title: Re: [1.1.3] inline images with full size
Post by: emanuele on July 05, 2018, 05:02:13 am
You mean in that specific topic?
Change:
Code: [Select]
[attach type=thumb]6057[/attach]
to:
Code: [Select]
[attach type=image]6057[/attach]
Title: Re: [1.1.3] inline images with full size
Post by: Jorin on July 05, 2018, 05:08:11 am
Yes, thank you!