Just happen to use " Forgot Password " option and I got a reset URL half broken. A decent part (at the end ) was not hyperlink at all. I had to copy paste it in browser and clicking would have not helped the cause. I see that similar URL issue is posted in Ultimate Menu discussion thread by
@Jorin . Please look into it.
What email client do you use? Do you have outlook or similar installed, or just by web?
If I remember well I had some problems in the past with SMF and links with a hotmail account via web
I used the web interface. Received it in the junk folder as well ( just in case that could be of any help).
What character did it break it on or was it just a very long link that wrapped around?
I've read that wrapping plain text links in "<" and ">" helps prevent some email clients from mangling them, no idea how effective that is.
Interesting ... so not a wrapping issue as it broke it as the 59th position ...
I've added the <> wrap to the link on the site, I've read mixed reviews if that helps or not, seems to vary. Anyway, if you are willing to reset your password again to give it a test that would be great !
My only other thought would be to replace those ';' with '&' and see if that would work. Obvisly the <> stuff did not work and I'm not surprised (that seems to help mac mailers). But both attempts broke the link at the ; ... so I wonder if using a & instead would prevent that.
I tried with one of my accounts and gmail works fine.
It may be one of those peculiar email services that likes to mess with stuff... :-\
What provider do you use meetdilip?
I noticed that on Hotmail :if an email (in my case a new registration) reaches the spam folder the link to view the profile is broken. If I mark the mail as safe it gets to inbox and the link is working fine.
Do you use Hotmail
@meetdilip?
For kicks I changed it to use & instead of ; for the separation ... so anyone willing to give it a try please do ... Just a curiosity why its breaking the line.
meh, I tried to create an account, but the provider asks for a mobile phone number, that's slightly more than I'm willing to provide in order to register online accounts. :-\
That's why I do not register new gmail accounts. :P
:P
http://www.elkarte.net/community/index.php?action=reminder;sa=setpassword;u=162;code=71dcc5e***
The url breaks r or reminder. . From ; onwards, there is not extension of hyperlink in the password retrieval url. Please check.
Emails are sent in markdown.
According to the email specification:
ftp://ftp.rfc-editor.org/in-notes/rfc3986.txt
long URLs should be delimited by preference with angle brackets:
<ftp://ftp.rfc-editor.org/in-notes/rfc3986.txt>
the issue could be that email clients do not really understand markdown, especially for joining back pieces of URLs.
I wonder if at some point we could start sending (at least some) emails in html (with an option to have those in plain text :P), just because it would be easier to deal with and, even though I find them annoying, nowadays it is probably kind of expected to have fancy emails.
I accessed my email using browser. I have seen some websites give password reset code and then the reset link below. People can either enter reset code or use reset link. In this case a reset code + password reset page link would be great ( in my opinion ).
hmm... Wait.
This kind of emails I think are not even processed in markdown, only body messages of the notification emails are.
This reminds me of some providers that "for fun" url_encode all the urls breaking them at will.
What provider are you using?
And, BTW,this is a duplicate of: http://www.elkarte.net/community/index.php?topic=2534.0
As I said in the other topic I get broken links on Hotmail ONLY if the email is marked as spam
And if you tell hotmail that is not spam, did the link get back together or does it remain broken?
Yes, once marked as clean the links are working
As we discussed before it is a local provider called Rediffmail. The point is, emails ( especially password recovery ) are having broken links with more than one email providers. And it needs to be addressed.
Hmm... can we check if using & instead of ; as the delimiter works?
As we discussed before, I can't test this provider because it asks a phone number, and I'm not going to put my phone on the internet (no, not even google has it), if you can point to an email provider with the same issue that doesn't ask for my phone number I can test, otherwise... thanks for volunteering in testing that one. ;D
Try with the following code, in Mail.subs.php, find:
foreach ($replacements as $f => $r)
{
$find[] = '{' . $f . '}';
$replace[] = $r;
}
and replace it with:
foreach ($replacements as $f => $r)
{
$find[] = '{' . $f . '}';
if (strpos($f, 'LINK') !== false || strpos($f, 'URL') !== false)
$r = str_replace(';', '&', $r);
$replace[] = $r;
}
Let me know if it breaks again. ;)
Most likely this would break the same way because the url would be:
http://www.elkarte.net/community/index.php?action=reminder;sa=setpassword;u=162
so (even though it should really be present) it would be useless.
I guess next time I should lock the duplicate topic, well, I'm going to merge the two now. :P
Will volunteer. A bit occupied with RL. :)