Nice job !
That was fast, thank you
@live627
And thank you
@radu81 for the donation. :)
You are welcome, I was looking for a similar addon since I joined Elkarte :)
http://www.elkarte.net/community/index.php?topic=2226.0
The addon is working fine, but I am getting a lot of erors in Elkarte error log:
Guest
Type of error: General
2: min(): Array must contain at least one element
File: /sources/subs/DoublePostStopper.php
Line: 98
I set 0 hours for guests, all errors are from guests, not from users
Does this file fix the issue? (It goes in ./sources/subs)
Yep, no more errors. Thanks again
Cool.
I have two things to report:
- I set 2 hours for all my membergroups, but if I don't set a time for guests the addon is not stopping double posting for members. I think is good to mention this since it took me some time to understand ;)
- I noticed that it also hides the "Quick Edit" button. I think this should be visible, since the Modify button is visible in "More..." options.
- Could be a third option, a little bit difficult, let's say I want to post 20 attachments, but my forum is set to max 10 attachments per post, so in this case I need to make 2 consecutve posts. Is there a quick way to add a condition, if the previous post has reached the maximum number of attachments then allow double post.
I can't reproduce that. Definitely a bug though.
@Spuds does disabling quick reply also disable quick edit?
Just one question:
what do I need to set at "max time to edit a post" in Posts & Topics settings?
Or is this irrelevant with this mod?
I don't think its relevant to this topic. I may move it to support later.
Anyway, you should set your preferred edit time or enter zero to disable editing a post. To modify a post without any time limit, we have another addon for that.
That setting does not affect this addon.
Why shouldn't this be relevant to this topic?
It's a question of this mod and how it should be set.
So I set edit time to 0 and in the mod 15 minutes, but they can double post within 5 seconds. So this mod isn't working.
I just tested on 1.1 RC2, it installs without errors, but when I try to save the settings of this addon I get an error:
str_split() expects parameter 1 to be string, array given
i want to report a problem.
when opening any topic as guest there will be an error:
min(): Array must contain at least one element
the content is not displayed.
using elkarte 1.1.0.
Hi
@live627 , do you have any plans to update this for elkarte 1.1?
You should open an issue on github and see if he has plans to update this :D
I did that
@Spuds but no answer from
@live627 :(
is there anyone interested on this add-on who can update it for elkarte 1.1?
https://github.com/live627/elk-dps
The add-on installs on elkarte 1.1, after install if I try to save the settings of this add-on I get an error:
str_split() expects parameter 1 to be string, array given
In elkarte error log i have:
Type of error: General
Warning: str_split() expects parameter 1 to be string, array given
/index.php?action=admin;area=addonsettings;save;sa=general
File: /sources/database/Db-mysql.class.php
Line: 299
If I try to add a consecutive post I get :
Type of error: Not specified
Exception: Call to undefined function fatal_lang_error()
/index.php?action=post;topic=948.75;last_msg=198652
File: /sources/subs/DoublePostStopper.php
Line: 122
I'm getting close ;D
the second error can be solved by replacing the line:
fatal_lang_error('double_post_attempt', false); // You naughty, naughty person!
with:
\Errors::instance()->fatal_lang_error('double_post_attempt', false);
I think I figured it out. The changes made to the settings form parser are to blame. It does not play nicely with mods that do things differently than expected. The hook for saving the settings does not pass any objects to integrations.
To remedy this, I need to create my own $settingsForm object to save the data that way.
Also, I'm going to merge changes made by
@radu81
Relevant changes in https://github.com/live627/elk-dps/commit/c45b467a686c013633920cf9122d941b99118d3c
Sorry for the delay amd thanks for keeping updated this add-on. It works fine now with Elkarte 1.1
Cheers :)