ElkArte Community

Elk Development => Bug Reports => Exterminated Bugs => Topic started by: Jorin on August 22, 2014, 10:11:40 am

Title: [RC2] texts not in a row
Post by: Jorin on August 22, 2014, 10:11:40 am
Is there any reason that these texts aren't in a row? Can this be fixed?  O:-)
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 22, 2014, 10:43:31 am
Stop looking too hard at the page! :P J/K

The second looks good from my browser.
Which one are you using?
Title: Re: [RC2] texts not in a row
Post by: Jorin on August 22, 2014, 10:47:45 am
Chrome Version 36.0.1985.143 m
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 22, 2014, 06:14:11 pm
Looks like an old MessageIndex.template.php (pre-February).
The file should have:
Code: [Select]
					', $topic['replies'], ' ', $txt['replies'], '<br />
', $topic['views'], ' ', $txt['views'];
(that anyway is bad for localization as far as I know, it should be an sprintf, but that's something for 1.1), while you probably have instead the old:
Code: [Select]
					', $topic['replies'], ' ', $txt['replies'], '
<br />
', $topic['views'], ' ', $txt['views'];
Title: Re: [RC2] texts not in a row
Post by: Jorin on August 23, 2014, 12:03:06 am
Okay, so in the final version this will be looking better. Thanks!  :)
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 23, 2014, 04:22:12 am
It was already in beta 2...
Could it be you restored an old file?
Title: Re: [RC2] texts not in a row
Post by: Jorin on August 24, 2014, 02:15:35 am
No, I'm using the RC2. Copied the MessageIndex.template.php from the RC2 source package I have downloaded from your homepage (which seems to be from july 20th) to the server right now. No difference.
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 24, 2014, 04:59:43 am
I don't know what to say, I can't see it doing that thing... :-\

Maybe someone else has an idea.
Title: Re: [RC2] texts not in a row
Post by: Jorin on August 24, 2014, 06:30:29 am
Oh, wait, I'll try something else. 
Title: Re: [RC2] texts not in a row
Post by: Jorin on August 24, 2014, 10:06:47 am
No. Thought maybe "my" theme has his own MessageIndex.template.php and I didn't overwrite it. But no, it only has the images and css files, no theme php files. They come from the default theme which is from RC2.
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 24, 2014, 10:52:38 am
Dunno, really.
The code generated is the old one:
Code: [Select]
						<p class="board_stats">
69 Beiträge
<br /> 12 Themen
</p>
where the br is on a new line and not at the same level of "replies", so somewhere that old file has to be as far as I can tell.
Title: Re: [RC2] texts not in a row
Post by: Jorin on August 25, 2014, 02:17:58 am
What do you think about this (http://hilfe.de/index.php/topic,41.msg199.html#msg199)? It seems the second problem can be fixed if I change this code in index.css from:

.board_stats {
text-align: right;
padding: 1px 0 1px 6px;
float: right;
min-width: 8.4em;
}

...to this:

Code: [Select]
.board_stats {
text-align: left;
padding: 1px 0 1px 6px;
float: right;
min-width: 8.4em;
}
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 26, 2014, 08:07:56 am
board_stats is not applied to the info center, it shouldn't affect it in any way.
Title: Re: [RC2] texts not in a row
Post by: Jorin on August 26, 2014, 08:19:01 am
Not the info center, but the board stats on the right side of the index. See line2.png in the first post please. Sorry, two problems in one thread again! :-[ ;)
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 26, 2014, 08:39:33 am
Wait a moment... oh sh**it I was looking at the wrong file. xD
Dammit. I was looking at be social in chrome and I didn't realise the two variants have a different order of the elements there.. .:-\
meh.

GenericBoards.template.php:
Code: (find) [Select]
							', comma_format($board['posts']), ' ', $board['is_redirect'] ? $txt['redirects'] : $txt['posts'], '
', $board['is_redirect'] ? '' : '<br /> ' . comma_format($board['topics']) . ' ' . $txt['board_topics'], '
Code: (replace with) [Select]
							', comma_format($board['posts']), ' ', $board['is_redirect'] ? $txt['redirects'] : $txt['posts'], $board['is_redirect'] ? '' : '<br /> ' . comma_format($board['topics']) . ' ' . $txt['board_topics'], '

Anyway Chrome is odd. >_<

Info center bug fixed here: https://github.com/emanuele45/Dialogo/commit/f6ce9ab5c2d3af1be180a7431448c0a1797c3f6d
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 26, 2014, 08:42:10 am
End fix for the board index alignment: https://github.com/emanuele45/Dialogo/commit/9a48e43962f8dba90b2509710a7ee1680b2ebb8f
Title: Re: [RC2] texts not in a row
Post by: Jorin on August 26, 2014, 08:44:20 am

Maybe, but it's the best browser to have all your Google personalisations, favorites and logins at any device you are using. Yes, I am using Google Now.  :D

Thanks for the fix! Does this sound weird?  :o
Title: Re: [RC2] texts not in a row
Post by: Jorin on August 27, 2014, 11:10:23 am
Ooops, here are some more (see the attachments):

http://support.elkarte-hilfe.de/index.php/topic,41.msg240.html#msg240
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 27, 2014, 11:12:33 am
1 bug, 1 topic. :P

BTW I'm not sure what the issue is in those pictures.
Title: Re: [RC2] texts not in a row
Post by: Jorin on August 27, 2014, 11:17:35 am
Sorry, thought it's the correct place here because all of these are small, optical missalignments.

The custom title of the member seems to be not centered, but a bit to the left. Blame @Ruth for this!  :P
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 27, 2014, 11:48:00 am
Try changing in index.css:
Code: [Select]
.poster .title {
white-space: normal;
word-wrap: break-word;
max-width: 14em;
}
to:
Code: [Select]
.poster .title {
white-space: normal;
word-wrap: break-word;
max-width: 100%;
}
I'm not sure of the effect on other browsers... O:-)
Title: Re: [RC2] texts not in a row
Post by: Ruth on August 28, 2014, 05:11:07 pm
Thank you very much, emanuele!

I have tried all this changes and now everything looks good... in my browser. ;)

Infocenter was still a little bit outside the row; but I have changed the inline padding in the index.css.php from 32px to 29px and now it's all straight on the line:

Code: [Select]
.inline {
padding: 0 29px;
font-size: 0.857em;
}


 ;)  Did I tell you to write everything in a single topic? No, I didn't.
I am completely innocent, @Jorin  :P  :P  :P
Title: Re: [RC2] texts not in a row
Post by: emanuele on August 28, 2014, 05:51:33 pm
https://github.com/emanuele45/Dialogo/commit/48e56b48c0a7455d1644bd166d3e035384913775
https://github.com/emanuele45/Dialogo/commit/ef1d1203282a4089b2faf7941708e960798f4ba1

lol
No big problem for the multiple issues. ;)