Skip to main content
Topic: [bug] - while you were typing no post shown (Read 5944 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

[bug] - while you were typing no post shown

start a reply
<someone post a message in the same topic>
* click preview
=> there is the warning, but the new message is not loaded.

Not yet sure though.
Last Edit: December 22, 2012, 06:59:23 pm by emanuele
Bugs creator.
Features destroyer.
Template killer.

Re: [bug] - while you were typing no post shown

Reply #1

I can confirm this on this site.

ETA: there are multiple issues I think:
1) obexit at line 1030 doesn't allow to run getTopic and so the new messages are not retrieved,
2) adding getTopic before obexit returns the messages to the XML, but they are not loaded into the template,
3) adding getTopic before obexit it doesn't update the messages viewed and so at every preview the warning is displayed.

ETA2: even commenting out the obexit it doesn't work... ???
Last Edit: December 22, 2012, 07:27:23 pm by emanuele
Bugs creator.
Features destroyer.
Template killer.

Re: [bug] - while you were typing no post shown

Reply #2

Quote from: emanuele – 2) adding getTopic before obexit returns the messages to the XML, but they are not loaded into the template,
This can be fixed changing:
Code: [Select]
var bPost = false;
to
Code: [Select]
bPost = false;
line 18 of Post.js

ETA:
Quote3) adding getTopic before obexit it doesn't update the messages viewed and so at every preview the warning is displayed.
with the above this is fixed too.
Last Edit: December 22, 2012, 07:36:28 pm by emanuele
Bugs creator.
Features destroyer.
Template killer.

Re: [bug] - while you were typing no post shown

Reply #3

Thanks for the debuging  :)  .. that obexit was just added (yesterday on the site) for testing to prevent loading all the other stuff on an xml response, no surprise that things need to be wiggled around a bit.    Yeah bPost was declared twice, good catch! I still intend to turn that in to more of a class object (well maybe)

ETA: Updated on the site so lets see if it works here as well
Last Edit: December 22, 2012, 07:59:25 pm by Spuds

 

Re: [bug] - while you were typing no post shown

Reply #4

:) :) :)
The best moment for testing your PR is right after you merge it. Can't miss with that one.