Text only | Text with Images

ElkArte Community

Title: Attempt to convert to MEDIUMTEXT fails
Post by: Keiro on June 26, 2015, 04:33:08 pm
These were some issues I encountered whilst trying to convert so that large post text sizes can be supported.

Unfortunately, they resulted in the following errors:

Warning: Illegal string offset 'name' in /home/admin/public_html/furryavalon.net/forums/sources/database/DbTable.class.php on line 209
Notice: Undefined index: variable in /home/admin/public_html/furryavalon.net/forums/sources/subs/Error.subs.php on line 72
Notice: Undefined index: value in /home/admin/public_html/furryavalon.net/forums/sources/subs/Error.subs.php on line 74

I don't know what the last two were for... I was doing something else, though.

This is for Elkarte 1.1.
Title: Re: Attempt to convert to MEDIUMTEXT fails
Post by: emanuele on June 26, 2015, 06:51:49 pm
Yup, indeed a bug in 1.1, I guess one of my overhaul where I missed a to fix a bit, or maybe an error during a rebase... :-[

Anyway, you can change in sources/database/DbTable.class.php:
Code: [Select]
		$columns = $this->db_list_columns($table_name, false);
to:
Code: [Select]
		$columns = $this->db_list_columns($table_name, true);
That should fix it.
Title: Re: Attempt to convert to MEDIUMTEXT fails
Post by: Keiro on June 30, 2015, 03:24:02 pm
Quote from: emanuele – Yup, indeed a bug in 1.1, I guess one of my overhaul where I missed a to fix a bit, or maybe an error during a rebase... :-[

Anyway, you can change in sources/database/DbTable.class.php:
Code: [Select]
		$columns = $this->db_list_columns($table_name, false);
to:
Code: [Select]
		$columns = $this->db_list_columns($table_name, true);
That should fix it.

Nice, glad to hear it's an easy fix. As for the other errors... I have yet to reproduce them... mostly because I haven't had a chance to get to play with the forums and attempt to break it and find bugs.
Title: Re: Attempt to convert to MEDIUMTEXT fails
Post by: emanuele on June 30, 2015, 03:28:41 pm
By the look of them, I think I fixed the others yesterday evening (the PR merged today by Spuds), it was a mistake during refactoring.
Title: Re: Attempt to convert to MEDIUMTEXT fails
Post by: emanuele on July 05, 2015, 04:35:39 pm
https://github.com/elkarte/Elkarte/commit/d512749f9fd75a219c4d427e42f8e6776c45d3ba

Thanks @Keiro and sorry for forgetting to thank you in the commit message... :(
Title: Re: Attempt to convert to MEDIUMTEXT fails
Post by: Keiro on July 15, 2015, 09:37:15 am
Quote from: emanuele – https://github.com/elkarte/Elkarte/commit/d512749f9fd75a219c4d427e42f8e6776c45d3ba

Thanks @Keiro and sorry for forgetting to thank you in the commit message... :(

It's ok! As long as I get thanked. ;)

/superlatereply
Text only | Text with Images