ElkArte Community

Title: Maillist Template Preview adjustments
Post by: Lou on February 29, 2016, 10:38:50 pm
Having thoroughly annoyed everyone with two previous threads this evening...I will make one last thread and run for the hills.  Been tinkering in the Maillist section for a few days now. Thought the display box for previewing the template looked a little bland.

Add this to where ever in admin.css. I put it about line 77 as I recall.


Code: [Select]
/* adds some flair to the email bounce template preview - Pastel */
#preview_section #template_preview.post {
    border: 2px solid #e4e4da;
    color: #3333ff;
    margin: 0;
    padding: 6px 12px;
}


Of course, one can make the text any colour they want, I just picked blue as a test.  This will provide a themer a option to style that box to their needs.

Nothing has been found broken yet on my localhost or server site. If you do find something icky, please let me know.  :)

Thanks
Title: Re: Maillist Template Preview adjustments
Post by: Antechinus on March 01, 2016, 03:30:05 pm
Yes, bad typography in that corner. It really needs some padding, which ideally should be done as a common class rather than as a specific custom declaration just for that box. Same for borders and text colours. It should already be taken care of.

The margin declaration appears to be superfluous. Also, there shouldn't be any need to use two ID's in descendant form. Just using the last one should be sufficient.
Title: Re: Maillist Template Preview adjustments
Post by: Lou on March 01, 2016, 05:30:39 pm
Quote from: Antechinus – Yes, bad typography in that corner. It really needs some padding, which ideally should be done as a common class rather than as a specific custom declaration just for that box. Same for borders and text colours. It should already be taken care of.

The margin declaration appears to be superfluous. Also, there shouldn't be any need to use two ID's in descendant form. Just using the last one should be sufficient.
I agree with all of that.  :)   I did the descendant ( as I recall ) to keep the template.post from being picked up and used unintentionally somewhere else. The margin, well that was just a catch all thing, like you said, it really is not needed.

Your mention of 'it should already be taken care of' ... are you saying this is already in the 1.0 dev? 

Thanks for your comments, it is appreciated. 
Title: Re: Maillist Template Preview adjustments
Post by: Antechinus on March 01, 2016, 06:40:53 pm
No, what I meant was that it's an oversight. Someone forgot to assign a standard class that would deal with it. These things happen. Ergo bug reports.
Title: Re: Maillist Template Preview adjustments
Post by: Spuds on March 01, 2016, 08:47:30 pm
probably just class="post" should be class="content" .. just a guess
Title: Re: Maillist Template Preview adjustments
Post by: Lou on March 01, 2016, 09:45:50 pm
Yep ... that tis correct. It is class = post. I tried 'content' and it does work quite well.
It did not dawn on me to try the 'content' class initially. <<head-slap>>

thanks  :)