ElkArte Community

Title: Error when removing all the members' options and use the defaults
Post by: kucing on November 28, 2013, 09:45:09 pm
Hi, I just converted my forum to Elk and when I tried to remove all member option there is an error:

Database error, given array of string values is empty (old_settings)

screenshot attached.
Title: Re: Error when removing all the members' options and use the defaults
Post by: TE on November 28, 2013, 11:00:59 pm
oh, I think that one is probably due to the import... I'll try to reproduce. Thanks again for reporting.
Title: Re: Error when removing all the members' options and use the defaults
Post by: TE on November 29, 2013, 01:13:55 am
Might be a missing parameter in one of those subs files, can you please check your error log and see, if there's a related log entry?
Title: Re: Error when removing all the members' options and use the defaults
Post by: emanuele on November 29, 2013, 07:44:38 am
It's a wrong default set for the last parameter of the removeThemeOptions function.

Fixed here:
https://github.com/emanuele45/Dialogo/commit/9a5c2d62466220bc4f8a71f0210e70e45265d5e4

If you want to fix it locally, you can open /sources/subs/Themes.subs.php anche change:
Code: [Select]
function removeThemeOptions($theme, $membergroups, $old_settings = array())
to
Code: [Select]
function removeThemeOptions($theme, $membergroups, $old_settings = '')

It seems my fault that one too.

/me is working hard to get another award! :P