ElkArte Community

Project Support => Announcements => Topic started by: emanuele on June 23, 2018, 11:55:24 pm

Title: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 23, 2018, 11:55:24 pm
Today, we are pleased to release ElkArte 1.1.4. This release addresses a minor security issue, the introduction of the acceptance of the agreement and privacy policy (related to the GDPR EU regulation) and several bugs identified after the release of ElkArte 1.1.3. As this is a maintenance release, the majority of the updates are focused on bug fixes and increased stability.

This is patch contains a security fix and we strongly encourage anyone running any previous version.

This release follows our semantic version (http://semver.org/) (MAJOR.MINOR.PATCH), meaning that third-point (x.x.X) releases should contain backwards-compatible bug fixes and enhancements, so for the most part you will not find new features in this release. Major new features will be reserved for second point versions (x.X.x).

Refer to the release notes (https://www.elkarte.net/community/index.php?topic=0.0) on the forum for a complete list of updates. (Release notes are not yet ready.)



Patching procedure:

For any question you may have, feel free to ask on the support forum (http://www.ElkArte.net/community/index.php).

Of course you are encouraged to update to this release since it contains a lot of fixes and improvements, thank you for your continued support!
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 23, 2018, 11:57:21 pm
Sorry for being somehow late, but I encountered quite a bit of problems here and there during the release.
Last Travis is gone crazy and was reporting a syntax error in a file that has no apparent syntax errors in any way I looked/tested/run it.

I really hope everything is fine, but to be honest I cannot guarantee 100%...
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: Spuds on June 24, 2018, 12:29:09 am
The syntax error caution is a bug in the test.  I've opened a github issue.
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: badmonkey on June 24, 2018, 04:40:10 am
Patch install on multiple 1.1 instances results in several errors.  The installs each have the 1.1.2 and 1.1.3 patches, if that matters.  

Quote
1.   Execute Modification   ./SSI.php   Test successful
Show   2.   Execute Modification   ./sources/BrowserDetector.class.php   Test successful
Show   3.   Execute Modification   ./sources/Load.php   Test successful
Show   4.   Execute Modification   ./sources/SiteCombiner.class.php   Test successful
Show   5.   Execute Modification   ./sources/Subs.php   Test successful
Show   6.   Execute Modification   ./sources/admin/Admin.controller.php   Test successful
Show   7.   Execute Modification   ./sources/admin/ManageAttachments.controller.php   Test successful
Show   8.   Execute Modification   ./sources/admin/ManageFeatures.controller.php   Test successful
Show   9.   Execute Modification   ./sources/admin/ManageLanguages.controller.php   Test successful
Show   10.   Execute Modification   ./sources/admin/ManageRegistration.controller.php   Test successful
Show   11.   Execute Modification   ./sources/admin/ManageSmileys.controller.php   Test successful
Show   12.   Execute Modification   ./sources/admin/ManageThemes.controller.php   Test successful
Show   13.   Execute Modification   ./sources/admin/PackageServers.controller.php   Test successful
Show   14.   Execute Modification   ./sources/admin/Packages.controller.php   Test successful
Show   15.   Execute Modification   ./sources/controllers/Jslocale.controller.php   Test successful
Show   16.   Execute Modification   ./sources/controllers/MessageIndex.controller.php   Test successful
Show   17.   Execute Modification   ./sources/controllers/Notify.controller.php   Test successful
Show   18.   Execute Modification   ./sources/controllers/PersonalMessage.controller.php   Test successful
Show   19.   Execute Modification   ./sources/controllers/ProfileOptions.controller.php   Test successful
Show   20.   Execute Modification   ./sources/controllers/Recent.controller.php   Test successful
Show   21.   Execute Modification   ./sources/controllers/Register.controller.php   Test successful
Show   22.   Execute Modification   ./sources/subs/Attachments.subs.php   Test successful
Show   23.   Execute Modification   ./sources/subs/Cache.class.php   Test successful
Show   24.   Execute Modification   ./sources/subs/EmailFormat.class.php   Test successful
Show   25.   Execute Modification   ./sources/subs/Exception/ElkException.class.php   Test successful
Show   26.   Execute Modification   ./sources/subs/Html2Md.class.php   Test successful
Show   27.   Execute Modification   ./sources/subs/Ila.integrate.php   Test successful
Show   28.   Execute Modification   ./sources/subs/Likes.subs.php   Test successful
Show   29.   Execute Modification   ./sources/subs/Mail.subs.php   Test successful
Show   30.   Execute Modification   ./sources/subs/Memberlist.subs.php   Test successful
Show   31.   Execute Modification   ./sources/subs/Members.subs.php   Test successful
Show   32.   Execute Modification   ./sources/subs/Mentioning.php   Test successful
Show   33.   Execute Modification   ./sources/subs/MessageIcons.subs.php   Test successful
Show   34.   Execute Modification   ./sources/subs/MessageTopicIcons.class.php   Test successful
Show   35.   Execute Modification   ./sources/subs/Notifications.class.php   Test successful
Show   36.   Execute Modification   ./sources/subs/Package.subs.php   Test successful
Show   37.   Execute Modification   ./sources/subs/PersonalMessage.subs.php   Test successful
Show   38.   Execute Modification   ./sources/subs/Priority.class.php   Test successful
Show   39.   Execute Modification   ./sources/subs/Profile.subs.php   Test successful
Show   40.   Execute Modification   ./sources/subs/ScheduledTask/Birthdayemails.php   Test successful
Show   41.   Execute Modification   ./sources/subs/SettingsFormAdapter/File.php   Test successful
Show   42.   Execute Modification   ./sources/subs/TopicUtil.class.php   Test successful
Show   43.   Execute Modification   ./sources/subs/Unread.class.php   Test successful
Show   44.   Execute Modification   ./subscriptions.php   Test successful
Show   45.   Execute Modification   ./themes/default/Admin.template.php   Test successful
Show   46.   Execute Modification   ./themes/default/BoardIndex.template.php   Test successful
Show   47.   Execute Modification   ./themes/default/Display.template.php   Test successful
Show   48.   Execute Modification   ./themes/default/GenericMessages.template.php   Test successful
Show   49.   Execute Modification   ./themes/default/ManageFeatures.template.php   Test successful
Show   50.   Execute Modification   ./themes/default/MessageIndex.template.php   Test successful
Show   51.   Execute Modification   ./themes/default/ProfileInfo.template.php   Test successful
Show   52.   Execute Modification   ./themes/default/Register.template.php   Test successful
Show   53.   Execute Modification   ./themes/default/Theme.php   Test successful
Show   54.   Execute Modification   ./themes/default/css/_besocial/index_besocial.css   Test successful
Show   55.   Execute Modification   ./themes/default/css/_light/index_light.css   Test successful
Show   56.   Execute Modification   ./themes/default/css/_light/rtl_light.css   Test successful
Show   57.   Execute Modification   ./themes/default/css/admin.css   Test successful
Show   58.   Execute Modification   ./themes/default/css/icons_svg.css   Test successful
Show   59.   Execute Modification   ./themes/default/css/index.css   Test successful
Show   60.   Execute Modification   ./themes/default/css/jquery.ui.tabs.css   Test successful
Show   61.   Execute Modification   ./themes/default/css/rtl.css   Test successful
*   62.   Execute Modification   ./themes/default/index.template.php   Test failed
    1.   Replace   ./themes/default/index.template.php   Test failed
    2.   Replace   ./themes/default/index.template.php   Test successful
    3.   Replace   ./themes/default/index.template.php   Test successful
    4.   Replace   ./themes/default/index.template.php   Test successful
Show   63.   Execute Modification   ./themes/default/languages/english/Admin.english.php   Test successful
*   64.   Execute Modification   ./themes/default/languages/english/Errors.english.php   Test failed
    1.   Replace   ./themes/default/languages/english/Errors.english.php   Test successful
    2.   Replace   ./themes/default/languages/english/Errors.english.php   Test failed
*   65.   Execute Modification   ./themes/default/languages/english/Help.english.php   Test failed
    1.   Replace   ./themes/default/languages/english/Help.english.php   Test successful
    2.   Replace   ./themes/default/languages/english/Help.english.php   Test failed
    3.   Replace   ./themes/default/languages/english/Help.english.php   Test failed
Show   66.   Execute Modification   ./themes/default/languages/english/Login.english.php   Test successful
Show   67.   Execute Modification   ./themes/default/languages/english/Profile.english.php   Test successful
Show   68.   Execute Modification   ./themes/default/languages/english/index.english.php   Test successful
Show   69.   Execute Modification   ./themes/default/scripts/admin.js   Test successful
Show   70.   Execute Modification   ./themes/default/scripts/jquery.sceditor.elkarte.js   Test successful
Show   71.   Execute Modification   ./themes/default/scripts/like_posts.js   Test successful
Show   72.   Execute Modification   ./themes/default/scripts/register.js   Test successful
Show   73.   Execute Modification   ./themes/default/scripts/script_elk.js   Test successful
Show   74.   Execute Modification   ./themes/default/scripts/topic.js   Test successful
75.   Extract File   ./bootstrap.php   
76.   Extract File   ./email_imap_cron.php   
77.   Extract File   ./emailpost.php   
78.   Extract File   ./emailtopic.php   
79.   Extract File   ./ssi_examples.php   
80.   Extract File   ./sources/subs/Errors/Errors.php   
81.   Extract File   ./themes/default/css/_besocial/icons_svg_besocial.css   
82.   Extract File   ./sources/subs/PrivacyPolicy.class.php   
83.   Extract File   ./sources/subs/Agreement.class.php   
84.   Extract File   ./sources/ext/serialize.php   
85.   Extract File   ./sources/ext/simple_html_dom.php   
86.   Extract Tree   ./sources/ext/bad-behavior   
87.   Extract Tree   ./sources/subs/CacheMethod   
88.   Extract Tree   ./sources/subs/MentionType   
89.   Extract Tree   ./packages/backups/agreements   
90.   Extract Tree   ./packages/backups/privacypolicies   
91.   Execute Code   code.php   

Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 24, 2018, 07:37:28 am
@badmonkey it's a bit difficult to spot the errors in that wall... (especially on the mobile I'm now)
I can see one in index.template.php that can be the version, and one in help.english.php, is there any other I missed?
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 24, 2018, 07:39:11 am
BTW, today I'm afk, so I'll not be abla to come back until this evening.
Later on, the list of addons installed may help as well. ;)
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: badmonkey on June 24, 2018, 07:41:46 am
There is one in index.template (it's nothing more than the version update), the second edit in /themes/default/languages/english/Errors.english.php, and the last two edits in ./themes/default/languages/english/Help.english.php.

Also, privacypolicy.txt was not created on the server.  That may or may not be an issue with the patch.  ??

Spuds::Edited to fix bbc font tag
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: tino on June 24, 2018, 10:25:25 am
I got no errors on my install, have previously patched from 1.1.0 -> 1.1.1 -> 1.1.2 -> 1.1.3.

privacypolicy.txt also wasn't created but was ok once I put something in it.
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 24, 2018, 11:33:11 am
Also, privacypolicy.txt was not created on the server.  That may or may not be an issue with the patch.  ??
I was not entirely sure to add it or not, at the end I didn't.
Maybe it is not the best choise, but anyway it is an empty file...
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: badmonkey on June 24, 2018, 03:09:04 pm
Sorry, let's clarify. The empty file was not created either. The file had to be created manually in all three instances. 

1.1.4 is now up and running! Keep up the great work!




Oh - where can users view the privacy policy at will?
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: b4pjoe on June 24, 2018, 05:49:07 pm
I want to force all users to accept the new registration agreement the next time they login. Checking this box and saving has no effect, ie...saving unchecks the box.

X
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: b4pjoe on June 24, 2018, 05:54:28 pm
Also If I try to register a new test account I get this:

X
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: tino on June 24, 2018, 06:11:39 pm
I want to force all users to accept the new registration agreement the next time they login. Checking this box and saving has no effect, ie...saving unchecks the box.

[attach type=image]6003[/attach]

Do you have any text in the privacypolicy section?
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: b4pjoe on June 24, 2018, 06:43:01 pm
The file is there but empty.
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: tino on June 24, 2018, 06:47:48 pm
The file is there but empty.

I’d guess it needs some content to become active? Otherwise there is nothing to display. Other than that do you have caching enabled?
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: b4pjoe on June 24, 2018, 06:58:58 pm
Once I put some text in there it seems everything is back to working as expected. I was hoping elkart was going to supply a Privacy Notice though.
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: badmonkey on June 24, 2018, 07:03:02 pm
The box fails to save on mine as well, even with text in the file. The workaround is checking a similar box in registration settings. 
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 25, 2018, 12:52:59 pm
I want to force all users to accept the new registration agreement the next time they login. Checking this box and saving has no effect, ie...saving unchecks the box.

[attach type=image]6003[/attach]
This is intended.
The idea is that when you do an edit that requires you to force your users to accept the agreement then you select it.
The reason behind the design is that if you for example want to fix a typo in the text it is not necessary to force all the users to accept the privacy policy again.
So, any time you make a change you are "asked" to select the option only if you really want the users to accept the new agreement.
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 25, 2018, 12:56:59 pm
Once I put some text in there it seems everything is back to working as expected. I was hoping elkart was going to supply a Privacy Notice though.
TBH I don't think we can write a privacy policy that suites all the needs, that's why I refrained from adding one.
What we can "easily" do is try to document how the data are used and stored, but the actual policy is something that is currently up to the owner of the site.
For example if you have backups, if you have addons, for how long you intend to keep the records, what you do with deleted accounts, if you have more people that can access the data, etc.
All of these should be likely taken in consideration, and since I'm not a lawyer and don't have enough money to consult one for writing a legal document, then I'm in your same boat.
If you have any suggestion, please open a topic and start drafting a generic policy for anybody to have a boilerplate to work on. ;D
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: ahrasis on June 25, 2018, 01:55:14 pm
I think we got some problems with this button as it did not stay selected after we as admin have chosen it in the settings.
[ ] Force all members to accept this new version of the privacy policy at the next visit to the forum.

When I select it again, I was taken to https://elkarte.sch.my/index.php?action=admin;area=regcenter at the browser url but the same page is still showing with the above button unselected.

Selecting it again will drive me back to https://elkarte.sch.my/index.php?action=register;sa=privacypol where I (as the admin) now have to accept the privacy policy.

I am all confused. Or is this intended? ;D
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: badmonkey on June 25, 2018, 02:14:11 pm
I think we got some problems with this button as it did not stay selected after we as admin have chosen it in the settings.
[ ] Force all members to accept this new version of the privacy policy at the next visit to the forum.

When I select it again, I was taken to https://elkarte.sch.my/index.php?action=admin;area=regcenter at the browser url but the same page is still showing with the above button unselected.

Selecting it again will drive me back to https://elkarte.sch.my/index.php?action=register;sa=privacypol where I (as the admin) now have to accept the privacy policy.

I am all confused. Or is this intended? ;D
 
 Same.  Shouldn't the box save if there is an edit?  If so, there was a hiccup here... ;)
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 25, 2018, 02:34:54 pm
Maybe read the messages posted in this topic? :P
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: b4pjoe on June 25, 2018, 02:57:23 pm
TBH I don't think we can write a privacy policy that suites all the needs, that's why I refrained from adding one.
What we can "easily" do is try to document how the data are used and stored, but the actual policy is something that is currently up to the owner of the site.
For example if you have backups, if you have addons, for how long you intend to keep the records, what you do with deleted accounts, if you have more people that can access the data, etc.
All of these should be likely taken in consideration, and since I'm not a lawyer and don't have enough money to consult one for writing a legal document, then I'm in your same boat.
If you have any suggestion, please open a topic and start drafting a generic policy for anybody to have a boilerplate to work on. ;D

OK, thanks. I do understand that. What I really don't understand is the whole GDPR thing. A few questions remain. Do we have to keep a visible link to the Privacy Policy on our website? Do we have to give users the ability to download their data that we have. Do we have to give users the ability to delete their account? I currently do not have any of those 3 things working.

And if you think this GDPR thing is bad wait until you see what they are up to next:

European Union prepares to wreck internet with new copyright law (https://www.zdnet.com/article/european-union-prepares-to-wreck-internet-with-new-copyright-law/?ftag=TRE-03-10aaa6b&bhid=20703142171098067451473055926429)
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: Jorin on June 25, 2018, 03:32:57 pm
May I ask where you are from, @b4pjoe? @Ruth and me worked for weeks on our privacy policy, maybe we can give you some answers. Here's a translated view (https://translate.google.de/translate?sl=de&tl=en&js=y&prev=_t&hl=de&ie=UTF-8&u=https%3A%2F%2Fforum-alternative-antriebe.de%2F%3Ftopic%3D7773.0&edit-text=&act=url) of my privacy policy. Please keep in mind that this privacy policy is not made or controlled by a lawyer, it may not be perfect, maybe not 100% legal.  ;)  But I did my very best.

Do we have to keep a visible link to the Privacy Policy on our website?

The privacy policy along with your registry agreement and your impressum must be always visible and easy to find! A single click to reach these documents is required. Links in your footer are perfect!

Do we have to give users the ability to download their data that we have.

Users may want to know what data you collected. You must give them an overview of the collected data in an electronic form, as an excel file for example. But you can wait till they ask you for it, and you still have a decent amount of time to provide this data.

Do we have to give users the ability to delete their account?

Sure. But they have already, or not? Users can delete their account in their profile. At least they can apply for it and you have to confirm it.
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: badmonkey on June 25, 2018, 03:50:25 pm
Maybe read the messages posted in this topic? :P
 
 Did that. Suffice it to say I'm easily amused, er, confused.  ;D
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: Mrs. Chaos on June 25, 2018, 06:43:52 pm
The update worked perfect with my test forum. :)

Just one question: Where can I find the privacypolicy.txt ?
I got the message that it's not writable and want to change it.
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: badmonkey on June 25, 2018, 07:59:52 pm
privacypolicy.txt should be in the forum root.  If not, create it manually and give it read/write permissions.   ;)
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: b4pjoe on June 25, 2018, 08:40:02 pm
May I ask where you are from, @b4pjoe? @Ruth and me worked for weeks on our privacy policy, maybe we can give you some answers. Here's a translated view (https://translate.google.de/translate?sl=de&tl=en&js=y&prev=_t&hl=de&ie=UTF-8&u=https%3A%2F%2Fforum-alternative-antriebe.de%2F%3Ftopic%3D7773.0&edit-text=&act=url) of my privacy policy. Please keep in mind that this privacy policy is not made or controlled by a lawyer, it may not be perfect, maybe not 100% legal.  ;)  But I did my very best.

Do we have to keep a visible link to the Privacy Policy on our website?

The privacy policy along with your registry agreement and your impressum must be always visible and easy to find! A single click to reach these documents is required. Links in your footer are perfect!

Do we have to give users the ability to download their data that we have.

Users may want to know what data you collected. You must give them an overview of the collected data in an electronic form, as an excel file for example. But you can wait till they ask you for it, and you still have a decent amount of time to provide this data.

Do we have to give users the ability to delete their account?

Sure. But they have already, or not? Users can delete their account in their profile. At least they can apply for it and you have to confirm it.

Thanks for the link. I had found a privacy policy online and modified it to fit what I think I need. Very similar to yours. Creating a link o it and registration agreement are easy enough to link but I have no idea how I would go about gathering the data if a user requests it.

I am in the USA but I do have members on my forum that are from the EU.
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: Mrs. Chaos on June 25, 2018, 08:50:39 pm
privacypolicy.txt should be in the forum root.  If not, create it manually and give it read/write permissions.   ;)

Thank you, the privacypolicy.txt is now in the forum root. :)
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: ahrasis on June 26, 2018, 12:40:44 am
I think what I mean was the behaviour of that button that causes the jump to another tab button and the change of displayed url, after selecting it again it displays the privacy policy page. That is really weird to me and other than what you tried to explain, the effects are more like bugs.
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 27, 2018, 08:35:07 am
There is one in index.template (it's nothing more than the version update), the second edit in /themes/default/languages/english/Errors.english.php, and the last two edits in ./themes/default/languages/english/Help.english.php.
Would you mind attaching these two files?
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: Jorin on June 27, 2018, 08:52:54 am
...I have no idea how I would go about gathering the data if a user requests it.

Welcome to the club! Me neither.  :D
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 27, 2018, 12:18:00 pm
You can start pointing him to the profile page. :P
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: badmonkey on June 27, 2018, 01:04:06 pm
There is one in index.template (it's nothing more than the version update), the second edit in /themes/default/languages/english/Errors.english.php, and the last two edits in ./themes/default/languages/english/Help.english.php.
  Would you mind attaching these two files?
 
 They've been edited manually. Do you still want them? Glad to do it but wanted to be clear.   8)
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on June 28, 2018, 01:29:39 pm
hmm... I guess not. :P
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: Mrs. Chaos on July 06, 2018, 07:28:46 pm
The news fader at the top of the forum still says: "ElkArte 1.1.3 Security and Bug fix patch has been released!"  ;)
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: emanuele on July 23, 2018, 01:00:23 am
Today I wanted to pack together the "quick" 1.1.5, but I faced an issue at github and couldn't do anything... :-\
Next week I'm on holiday so some free time do get it out. :)

@Mrs. Chaos I lost your message... :-[
Title: Re: ElkArte 1.1.4 - Release announcement
Post by: Mrs. Chaos on July 23, 2018, 11:31:55 am
@Mrs. Chaos I lost your message... :-[

That doesn't matter. :) In the meantime it has been changed.