Re: BBC Parsing
Reply #17 –
One thing I really don't like about the benchmark is that it can't actually tell me the memory loads because it is using the same process. I am thinking about getting rid of that altogether.
I am going to post this here because I don't have a real git repo setup (not on my computer yet) so I can't branch this. This is an in-situ example of parser. I don't see any difference between it and the previous version. In theory it should be using less RAM but I honestly don't know. Especially with PHP. I know in other language it wouldn't be making a copy and would use the reference.
Then again, there are a LOT of functions that create copies of the message. I don't think PHP has any in-situ string methods. I'm actually thinking about making a patch to add some. Would give me time working with C - something I haven't done in over 10 years. What we should do is make any internal functions Elkarte uses that makes changes to a string use references. I don't think it will save much time, but on long messages I think it will save memory.
Re: BBC Parsing
Reply #20 –
Feel free to upgrade to 5.4 in the admin panel if you want to. It's the maximum they currently have :/ But AFAIK there's quite a big difference between the two.
Re: BBC Parsing
Reply #22 –
Hmm, could I argue placing it 5.4 but keeping 5.3 compatible? Joshua still has a point there, 5.3 is old.
Re: BBC Parsing
Reply #24 –
That makes me feel a hell of a lot better. I was about to say screw using objects. An 84% increase in time isn't going to work. If you are still using 5.3, you deserve to have it take a little more time. Maybe it will push people to upgrade to >= 5.4. Especially since 5.3 EOL'd a year ago (last week).
Re: BBC Parsing
Reply #26 –
No idea how you are doing it, but I feel you are doing an amazing job, and I am glad my test site is being useful for such an important task!
Re: BBC Parsing
Reply #29 –
Yeah, I realized it was screwed up as soon as I wrote it but it served its purpose in helping me.
Can you upload your changes? I want to work them in.