Quick quote to Elkarte core

Quick quote to Elkarte core Started by radu81 · May 30, 2022, 02:50:58 am · Read 9384 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Re: Quick quote to Elkarte core

Reply #30 – June 27, 2022, 05:22:18 am

This seems to work fine for me, @ahrasis try to clean temporary files on your browser

The output I get is

Device:
@media orientation	portrait
window.orientation	0
@media resolution	288dpi
@media device-pixel-ratio	3
window.devicePixelRatio	3
Widths:
@media device-width	360px
screen.width	360px
screen.availWidth	360px
window.outerWidth	360px
window.innerWidth	360px
@media width	360px
doc.docElem.clientWidth	360px
doc.docElem.offsetWidth	360px
doc.docElem.scrollWidth	360px
doc.body.clientWidth	360px
doc.body.offsetWidth	360px
doc.body.scrollWidth	360px
Heights:
@media device-height	760px
screen.height	760px
screen.availHeight	760px
window.outerHeight	681px
window.innerHeight	625px
@media height	625px
doc.docElem.clientHeight	625px
doc.docElem.offsetHeight	1305px
doc.docElem.scrollHeight	1358px
doc.body.clientHeight	1356px
doc.body.offsetHeight	1409px
doc.body.scrollHeight	1463px

P. S in the meantime I tried Smf 2.1 (when it was online, now is offline) and had the same behavior, no quick quote button was visible with Firefox for android.

Thanks for this update

Re: Quick quote to Elkarte core

Reply #31 – June 27, 2022, 07:14:29 am

Ok. Now it is working but the box filled the whole screen width.

Re: Quick quote to Elkarte core

Reply #32 – June 27, 2022, 09:49:09 am

Quote from: ahrasis – June 27, 2022, 07:14:29 amOk. Now it is working but the box filled the whole screen width.

That was intended, but currently only works that way on mobile chrome.

With chrome it was easy to replace that default menu ribbon and IMO its a cleaner look. With Fx I'll need another approach to do the same as it fires those events differently. Not having the ribbon there lets me position the button outside of the text fence indicators so there is no overlap. Downside is you can't Cut the selected text (with the menu)

Quote from: radu81 – June 27, 2022, 05:22:18 am@media device-width360px

OK, the device is rendering out as a 360px wide screen, so that is narrow. Something to do with the
media resolution at 288dpi and the media device-pixel-ratio at 3 .... might have some control over that on with phone settings.

Re: Quick quote to Elkarte core

Reply #33 – June 27, 2022, 08:12:16 pm

Quote from: Spuds – June 26, 2022, 10:47:36 amI've updated the script on the site so please give it a test.

Seems to be working now on my OnePlus 8 5g, great work.

Re: Quick quote to Elkarte core

Reply #34 – June 29, 2022, 02:20:57 pm

I've made a few more updates, mostly to try and clean up a few area's as well as provide a common(ish) UI across the devices.

On mobile/touch devices, the button will always appear below the text. Only chrome allowed using the button in place of the default context menu (copy/paste/etc ribbon) The button is placed a little farther away from the text bottom to avoid interfering with the selection markers. Firefox has some problems, in that the contextMenu and selection markers are part of the "app" they do not appear in the DOM, nor does interfacing with them update the DOM or fire events (chrome does). So once that button is placed (Fx), that is where it is.

On desktop / Ipad and some touch, the button will generally appear where you "lift up" ... If you select left to right, the button will be on the right below the selection. If you select right to left, it will be on the left point, below the selection. This is more useful (and apparent) on desktop as it allows one to quickly access the button since its where you ended your selection.

Improved on keeping the button on screen with the exception of mobile/touch where it could be off the bottom of the screen if you select text at the bottom. This is because to move it, it has to move above the default contextMenu, the size of which is dependent on various items, none of which are (cross browser) accessible, and as I said its not part of the DOM so you can't z-index your way on top. So a minor annoyance.

Cleaned up the event listeners and some scroll jank

Re: Quick quote to Elkarte core

Reply #35 – June 30, 2022, 04:10:11 pm

Quote from: Spuds – June 29, 2022, 02:20:57 pmOn mobile/touch devices, the button will always appear below the text.

Enjoying this change on my mobile device.