[reminder] Working towards 1.0.2

Topic: [reminder] Working towards 1.0.2 (Read 13320 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.

Re: [reminder] Working towards 1.0.2

Reply #30 – December 01, 2014, 10:58:58 am

And one more post in my line here:

The left padding was added here: https://github.com/eurich/Elkarte/commit/5a8faa7a4ccaba50d64755e1a3679de4e4c8dea2

Although it seems to work without that, chrome does not change the cursor pointer when you are over the text. Could add that just for chrome browsers and I think removing that stops the broken layout (the control size can be reduced a bit, seems generously sized now as well. So maybe the following will work.

Code: [Select]

.drop_area_fileselect {
	cursor: pointer;
	margin-left: -160px;
	opacity: 0.0001;
	position: absolute;
	width: 160px;
}
#chrome .drop_area_fileselect, #safari .drop_area_fileselect {
	padding-left: 160px;
}
.drop_area_fileselect_text {
	white-space: nowrap;
}

You need the nowrap on the text, one phone I tested was 320 wide and that caused "selecting them" to be on two lines, but the control was on "them" so pressing "selecting" was the link not the control (I hope that makes sense).

Re: [reminder] Working towards 1.0.2

Reply #31 – December 01, 2014, 11:29:44 am

Quote from: Spuds – December 01, 2014, 10:21:18 amI still don't know if there is any use to the D&D area for a phone, so the easiest may be to simply due what we do with ie8 (and ie9) and thats not enable D&D which results in the old fallback of a standard file input.

+1 on that. nods

Re: [reminder] Working towards 1.0.2

Reply #32 – December 02, 2014, 12:27:50 am

updated the PR with some changes (hiding the D&D box for low-res devices) .. I doubt D&D will work on mobile devices at all (never tested myself)..

Re: [reminder] Working towards 1.0.2

Reply #33 – December 02, 2014, 02:25:24 am

Nope, doesn't work.

Re: [reminder] Working towards 1.0.2

Reply #34 – December 02, 2014, 08:49:14 am

I think the way to handle that is going to have to be with JS since that is what is showing / hiding those areas. Specifically JS will show the .drop_area and hide the .drop_attachments_no_js area based on capability not practicality.

So my thought is to add

Code: [Select]

		// Don't attach D&D on small screens
		if (!window.matchMedia || window.matchMedia('(max-width: 33.750em)').matches)
			return;

in the dropAttachments js, that will stop the DD function from ever attaching / activating when we are below 540 (or pick your number, that was just a random pick) screen width

Whats cool about matchMedia is we could even attach a listener to it so its screen size change aware

Re: [reminder] Working towards 1.0.2

Reply #35 – December 06, 2014, 07:39:07 am

Code-wise I think it's settled.
I started the tracking issue for the release:
https://github.com/elkarte/Elkarte/issues/1905

ETA: I started packing the stuff.
Attached to this message there is both an install and a patch, if you can, please give them a try, because I recently had some issues while creating zip files... $:-\$

ETA2: packages removed.

Re: [reminder] Working towards 1.0.2

Reply #36 – December 06, 2014, 12:11:07 pm

I tried the patch package and get this error:

./sources/CurlFetchWebdata.class.php

Search for:

Code: [Select]

* copyright: 2011 Simple Machines (http://www.simplemachines.org)
 * license: BSD, See included LICENSE.TXT for terms and conditions.
 *
 * @version 1.0
 *
 */

Replace with:

Code: [Select]

* copyright: 2011 Simple Machines (http://www.simplemachines.org)
 * license: BSD, See included LICENSE.TXT for terms and conditions.
 *
 * @version 1.0.2
 *
 */

./sources/subs/Action.class.php

Search for:

Code: [Select]

 * copyright:	2011 Simple Machines (http://www.simplemachines.org)
 * license:		BSD, See included LICENSE.TXT for terms and conditions.
 *
 * @version 1.0
 *
 */

Replace with:

Code: [Select]

 * copyright:	2011 Simple Machines (http://www.simplemachines.org)
 * license:		BSD, See included LICENSE.TXT for terms and conditions.
 *
 * @version 1.0.2
 *
 */

./themes/default/index.template.php

Search for:

Code: [Select]

 * copyright:	2011 Simple Machines (http://www.simplemachines.org)
 * license:		BSD, See included LICENSE.TXT for terms and conditions.
 *
 * @version 1.0.1
 *
 */

Replace with:

Code: [Select]

 * copyright:	2011 Simple Machines (http://www.simplemachines.org)
 * license:		BSD, See included LICENSE.TXT for terms and conditions.
 *
 * @version 1.0.2
 *
 */

Plus some more errors in my theme.

Oh, and in index_light.css you have this:

Code: [Select]

/* The active one */
.buttonlist li a.active {
	box-shadow: 1px 1px 2px #ccc;
	box-shadow: 1px 1px 2px #e5e5e5, 0 -1px 0 #3d6e32 inset;
}

Isn't this a duplicated row?

Re: [reminder] Working towards 1.0.2

Reply #37 – December 06, 2014, 12:31:13 pm

ARG!
Darn copy&paste as usual!

Thanks for testing!

https://github.com/elkarte/Elkarte/pull/1909

About the css, I don't know... it looks.

Re: [reminder] Working towards 1.0.2

Reply #38 – December 06, 2014, 10:57:58 pm

Found two other things and made the PR

looks like BoardIndex was still at 1.0 in the 1.0.1 patch, and one line needed to be space space tab and not tab tab ..... bleh!

Installed it on a "pure" 1.0.1 and it installed fine ... will test on a 1.0.1 that was a patched version in a bit.

ETA: seemed to go fine on an upgraded to 1.0.1 site as well

Re: [reminder] Working towards 1.0.2

Reply #39 – December 07, 2014, 04:52:42 am

I'll generate the new packages today.

Oh, I just noticed:
https://github.com/ichord/At.js/commit/e1f65668e311c06d845164c49f303fdb6093cca6
what do you think? Worth a "last-minute" sneak in?

Re: [reminder] Working towards 1.0.2

Reply #40 – December 07, 2014, 08:51:02 am

Looks like a safe change, you will have to back port it since we are not on the same rev at this point but I don't think that area has changed from our rev to the current one.

Re: [reminder] Working towards 1.0.2

Reply #41 – December 07, 2014, 09:10:26 am

Reading it again I think it's better wait on that one.

Re: [reminder] Working towards 1.0.2

Reply #42 – December 07, 2014, 02:59:33 pm

There are too many places where the darn version requires to be updated for a release.

Re: [reminder] Working towards 1.0.2

Reply #43 – December 11, 2014, 05:02:32 pm

Maybe Sunday is a good day for releasing?

emanuele hopes so.

Re: [reminder] Working towards 1.0.2

Reply #44 – December 13, 2014, 02:33:10 am

Why not release it on new years? New year, new version.