Skip to main content
Topic: Packages.controller.php (Read 1813 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.


I am just perusing the code. On line 733 in Packages.controller.php PhpStorm is telling me that isn't a valid use of foreach. It is expecting an array and it is a string. Going up, I see that it is set to a string a couple of times. So, there is something wrong there.

Re: Packages.controller.php

Reply #1

Humm, I'd like to say I'm surprised :P 

If you see what the problem is let me know (or make the PR).  As you know there was some sloppy use of the same variables from form stings to arrays or empty checks with returns before it gets to the other areas etc.  I know this flips out some of the scanner code, but often its right about what its complaining about.  I'd take a look but I'm busy tearing up some other controllers ATM.   Ok not really tearing them up, but more refactoring along the way.