The queries countdown October 08, 2013, 11:39:38 am One of the "goals" is to move all the queries out of the controllers, well let's see after one year of work where we are.I did a simple search of the code using $db->query, finding:/controllers/ => 137/admin/ => 96Well, to be honest I hoped/had the feeling we were in a "better shape", though it's not that bad and we can (and should) improve. To do a comparison with what we started in SMF I searched (excluding all the "Subs-*" and "db" files) $smcFunc['db_query, finding 1104 instances.
Re: The queries countdown Reply #1 – October 09, 2013, 12:08:22 pm Well 1104 down to 233 is a pretty darn good start ... plus we MAY have added a query or two along they way Agree we need to 'finish' the improvement job
Re: The queries countdown Reply #2 – October 09, 2013, 01:17:09 pm Quote from: Spuds – October 09, 2013, 12:08:22 pmWell 1104 down to 233 is a pretty darn good start ... plus we MAY have added a query or two along they way emanuele is innocent! Actually is +14 because I didn't notice the $db_search->search_query, so 247. Still a good reduction. Quote from: Spuds – October 09, 2013, 12:08:22 pmAgree we need to 'finish' the improvement job Yep!In the meantime, an update after merging a couple of branches:/controllers/ => 142/admin/ => 88And a bit of additional analysis.Regarding the /admin/ dir:RepairBoards.php is the one accounting for the relative majority of the queries: 39. That file is scary TBH...do we really need all this? Can it be reworked to use functions we already have? What do you think?The second file in terms of queries is ManageAttachments, this is as usual a bit tricky I think...Special case (I think) AdminDebug.controller.php: it has both queries and markup. I'm not sure if it is a special case, since I suppose it should just adhere to the standards of the rest of the code...or not?The /controllers/ dir, instead, is more "messy", there are still 5 files with more than 10 queries: PersonalMessage (20) Recent (17) RemoveTopic (16) ProfileHistory (15)* ProfileInfo (15)
Re: The queries countdown Reply #3 – October 20, 2013, 11:35:59 am Just made the pr for profile info, so knock 15 more off the list
Re: The queries countdown Reply #4 – October 21, 2013, 01:26:33 pm Groups controller should be free of queries, too: PR is https://github.com/elkarte/Elkarte/pull/919
Re: The queries countdown Reply #5 – October 21, 2013, 06:53:20 pm YAY!OK, this is extremely refreshing for the codebase, and incomparable by a great length with SMF. And unbelievable, how fast you folks went through it.@Trek,How about you grumble at us meanies to give you details on this reasons -> progress -> achievement -> consequences, then please, help shape up our mumbling into a decent form.For the mid-level development documentation (changes from SMF, Elk presentation, oriented dev-wise). We have similar github wiki pages already, they just want added to.
Re: The queries countdown Reply #6 – October 22, 2013, 09:10:25 am And update after the last merges:/controllers/ => 122 (110+12)/admin/ => 76 (74+2)Grand total: 198Under the 200! YAY!Next goal is 100!
Re: The queries countdown Reply #7 – November 01, 2013, 10:49:12 am Another week and:/controllers/ => 113 (101+12)/admin/ => 17 (17+0)Grand total: 130
Re: The queries countdown Reply #8 – December 16, 2013, 09:56:51 am If I did the same search(s) I think its nowControllers (75 / 12)Admin (3 / 0)Total of 90 !but we need the master counter to verify
Re: The queries countdown Reply #9 – December 17, 2013, 12:44:33 pm Spoiler (click to show/hide)This is for when it will reach 0: http://i76.photobucket.com/albums/j24/mambutu/official_seal_of_approval.jpg
Re: The queries countdown Reply #10 – December 17, 2013, 02:40:34 pm I look forward to the awesome sauce !
Re: The queries countdown Reply #11 – June 13, 2014, 04:51:52 pm Final count for 1.0 is:controllers: 68 / 12admin: 1 / 0Total: 81.Very good situation considering where we started! The development branch is already at:controllers: 47 / 0admin: 0 / 0So, just 47 queries in total!Thanks to @groundup for his contributions to the task! (Or maybe it was at bringing back to controllers things that were not supposed to stay in subs... either way thanks. )
Re: The queries countdown Reply #12 – June 14, 2014, 08:18:48 am Wow ... its all a blur now ... 1000+ knocked down to 81! Awesome job everyone!One other goal/objective in 1.1 would be to combine any duplicate/similar ones where it makes sense ... I know we have a few similar to one another in a few places,. Just getting them out of the controllers was monumental task to start with, and I must say being able to use them in addons is a delight
Modern, Free, Powerful