Skip to main content
Topic: 1.1 CSS Issues (Read 1753 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

1.1 CSS Issues

As I've been converting my theme variant to 1.1 I've noticed some ugly things in the new 1.1 base theme. 

1)  Why does this font-family line exist?  For linux you've left off all linux fonts you try elsewhere and actually end up with serif instead of at least sans-serif as the fallback like everywhere else.   Why are these particular headers even trying to pull from a different font family at all?

Code: [Select]
.codeheader, .quoteheader, .expand_pages, .table_head > th, .topic_sorting_row > h3, .topic_name h4 a, .poster .name, .keyinfo h5 a, .keyinfo h5 a strong, .ui-dialog .ui-dialog-titlebar, #creator dt strong, .settings label, .popup_heading {
    font-weight: 600;
    font-family: "Segoe UI Semibold","Segoe UI","Helvetica Neue Medium","Helvetica Neue",serif;
    -webkit-font-smoothing: antialiased;
    -moz-osx-font-smoothing: grayscale;

2) The topic icons on the editor page (where you select the icon) are the old quickbuttons graphics but then out in the topic index where they are displayed they're different svg based icons.  Odd to pick from one set then have the world see a different set.

3) <span class="topicicon" img_normal> has a line-height of 2em, but the :topicicon::before that puts the icon into the span has a fixed height of 16px.  So if the fonts get scaled they look bad.  They should be sized to 2em or at least something in em so that they will scale with the span.


Re: 1.1 CSS Issues

Reply #2
I don't believe that font stack changed from 1.0 :(

Those areas use a font that is between bold and normal, so semi bold for presentation.  The weight of 600 does not exist in the core font stack (mostly at least, I recall various issues) so this stack was put in place for use in those areas.  Anyway you are correct that a better fallback should be put in place, and maybe a *nix font added that may support 600 as well.   When I updated the core font stack (the 1.0 one was really dated) I should have updated this one as well ... if you have suggestions, please let us know.  I'll add it to the tracker as well.
Be safe, Be kind, Happy Programing

Re: 1.1 CSS Issues

Reply #3
I do not know which linux fonts support a weight of 600.  I put it to weight 700 which I've been using all along and set it to the default font stack which has linux fonts in it.

At the very least put the linux fonts from the default stack back in the line and end with sans-serif like the default so even if the weight 600 does nothing it doesn't do nothing and pull up a completely different font not used anywhere else.

Re: 1.1 CSS Issues

Reply #4
I started to fix #2 but @emanuele objected to me making everything into svg >_>

Re: 1.1 CSS Issues

Reply #5
Then turn them all back into images.  They need to match in both places.

Re: 1.1 CSS Issues

Reply #6
I started to fix #2 but @emanuele objected to me making everything into svg >_>
Not exactly, I said that we should support "images" either svg, png or jpeg and would prefer not to remove the upload. After you replying that adding svg icon was possible I didn't object.
The fact I moved it to 2.0 was because after a month you were not interested in working on it.
Sorry for the misunderstanding. :)

Then turn them all back into images.  They need to match in both places.
Well, we can just change the sprite and have them match. :P
Bugs creator.
Features destroyer.
Template killer.