Skip to main content
Topic: All teh javascript is borken. (Read 4934 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

All teh javascript is borken.

Just installed the latest GitHub build on local. None of the js seems to work. Hey ho. :P

What stage is all this refactoring at?
Last Edit: December 31, 2012, 02:53:22 am by Antechinus
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: All teh javascript is borken.

Reply #1

This site is running the current github repo ... javascript seems to be fine here (relatively speaking lol)

Re: All teh javascript is borken.

Reply #2

Quote from: Antechinus – What stage is all this refactoring at?

We have usually kept at all times compatibility with the rest of the code. PRs are batches of commits which try to completely (not partially) change some of the code while keeping the behavior, and in this sense compatibility with the rest of the code.
Obvious misses aside - those easy to fix once you stumble upon them.

By the way, that's the meaning of "refactoring": change some of the implementation while keeping the behavior identical.
Of course, since we don't have unit tests things are more likely to break. Which again, is why we use PRs, and code review, before we merge them in the master branch of the main repo.


Re: javascript. Try to switch to 'local' instead of cdn. Does it work?
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: All teh javascript is borken.

Reply #3

Ah. That seems to be it. Looks like it wont call the cdn to local host sites, which is a bit odd seeing as links to the web usually work. Anyway I set it to local source and it works now. Worth noting. :)
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: All teh javascript is borken.

Reply #4

I'm going to close this one. Having to use local source for jQ on a desktop local host is not really something that's worth bug-tracking for a production build.

ETA: Topic moving is borken. Can stay here then. :P

Hey cool. It makes the moved topic topic/redirect/whatever but doesn't move the actual topic.
Last Edit: January 27, 2013, 06:17:29 pm by Antechinus
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P