Skip to main content
Topic: Sort of bug - message index. (Read 7677 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: Sort of bug - message index.

Reply #15

Here is a two line same font as we currently have ... I know we had this layout at one point, don't know if it was disliked and we changed back to what we have now.

Re: Sort of bug - message index.

Reply #16

Code: [Select]
if (!isset($counter))
    $counter = 0;
$counter++;

if ($counter > 1)
    break;

IIRC we started with the two lines layout and I changed it to the three lines according to this discussion, see http://www.elkarte.net/community/index.php?topic=415.msg7429#msg7429

Last Edit: July 28, 2014, 06:13:31 pm by emanuele
Bugs creator.
Features destroyer.
Template killer.

Re: Sort of bug - message index.

Reply #17

Thats this thread ... now I'm stuck in a loop  :'(

Re: Sort of bug - message index.

Reply #18

I added a block to break out of the loop! 8)
Bugs creator.
Features destroyer.
Template killer.

Re: Sort of bug - message index.

Reply #19

Quote from: emanuele – ohhh... come on, where is the fun if you do things *properly*? :P j/k

Sorry. I have forgotten having fun since long ago.

Quote from: Spuds – Here is a two line same font as we currently have ... I know we had this layout at one point, don't know if it was disliked and we changed back to what we have now.

I think the spacing is just right in that two line version. However, having 3 items on 2 lines hurts my pedantic eyes. Still, I guess I prefer that to having excessive spacing in topic list.

Re: Sort of bug - message index.

Reply #20

Any updates regarding this?

Re: Sort of bug - message index.

Reply #21

I think (but I may be wrong) Spuds already reduced the height of the box... no?
Bugs creator.
Features destroyer.
Template killer.

Re: Sort of bug - message index.

Reply #22

Is this site supposed to include that change? I don't have a test install of the latest version, so I'm posting whatever I see here.

Re: Sort of bug - message index.

Reply #23

I'm not sure. As soon as I have some time and I feel a bit better I'll upload the latest repo. ;)
Bugs creator.
Features destroyer.
Template killer.

Re: Sort of bug - message index.

Reply #24

I don't think there are any changes in 1.0 vs whats here now WRT this discussion.

I seem to recall that we did remove some white space based on this discussion.  The only way I see to remove more would be the 2 line version or a smaller font size in the topic_stats class.  Maybe there are some other ideas that we could apply in 1.01 ?


Re: Sort of bug - message index.

Reply #25

Oh okay, I thought you reduced a bit the line height.
The two lines version to me looks too crowded. :-\
Bugs creator.
Features destroyer.
Template killer.

Re: Sort of bug - message index.

Reply #26

I just implemented an alternating stat view, based on the sort order, which worked well enough for my needs.

MessageIndex.template.php:
Code: (php) [Select]
switch ($context['sort_by'])
{
case 'views':
echo $topic['views'], ' ', $txt['views'];
break;
case 'likes':
if (!empty($modSettings['likes_enabled']))
{
echo $topic['likes'], ' ', $txt['likes'];
break;
}
// fall through
default:
echo $topic['replies'], ' ', $txt['replies'];
break;
}

Re: Sort of bug - message index.

Reply #27

Interesting!
Bugs creator.
Features destroyer.
Template killer.

Re: Sort of bug - message index.

Reply #28

actually a nice approach for the sorted views ...