Skip to main content
Topic: TinyPortal for Elkarte (Read 1403 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

TinyPortal for Elkarte

Hi All,

After quite some time I have eventually got TinyPortal to a stage where I can start to port it across to Elkarte relatively easily. It is available here; https://github.com/Tinyportal/ElkTP although I have currently tagged it as 1.0.0 please assume it is in Alpha stages and needs a lot of testing.

I have removed the Shoutbox, Menu and Downloads from it currently and will add them back in when I have got the existing code ported across in a nicer manor than I have currently. There isn't a controller as such it just hooks into the existing logic used for SMF which is what I will focus on. Most of the SQL was moved to the TinyPortal namespace before I started this in TinyPortal 2.0.0 and that's where eventually all the SQL will reside with the controller and views calling the appropriate functions.

The CSS styling on the blocks is one thing which I know doesn't work correctly and if I'm honest is not my forté. So if anyone can help with that I would appreciate it.

The latest tagged release download is here; https://tinoest.co.uk/forum/index.php?page=ElkTinyPortal

tino

Re: TinyPortal for Elkarte

Reply #1
Congratulations on getting that to work, it must have been a labor of love !!!

TP is a very cool portal I had wanted to port as well but the way it was written at the time required a level of dedication that I could not supply, you really had to "live" with that code to effectively make changes.

I've downloaded it and when I'm done playing with 1.1.7 I'm going to give it a run :D
Be safe, Be kind, Happy Programing

Re: TinyPortal for Elkarte

Reply #2
Great news. Congratulations!

Re: TinyPortal for Elkarte

Reply #3
Indeed congratz!
I think I tried once, but gave up halfway, I had more confidence (not that much for the matter) with SP.
Bugs creator.
Features destroyer.
Template killer.

Re: TinyPortal for Elkarte

Reply #4
Thanks.

I have moved things around a lot since my first post. So I would get the latest version from GitHub when you do try it as it's probably not going to be the same as yesterday let alone a week ago.  O:-)

Re: TinyPortal for Elkarte

Reply #5
I have to admit - the way TP coding was before Brad(Ichbin) and later tino, took over, was..."dedicated". :D I guess I wanted to put so much functionality in and really having less-than-ideal knowledge of finer PHP coding - I just used what I knew and duplicated. And duplicated again, possibly tweaked lol.So no wonder the code had to be "lived" to change it.

Seriously though, I think its great TinyPortal lives on, both as SMF and now also Elkarte mod. 

Re: TinyPortal for Elkarte

Reply #6
I have to admit - the way TP coding was before Brad(Ichbin) and later tino, took over, was..."dedicated". :D I guess I wanted to put so much functionality in and really having less-than-ideal knowledge of finer PHP coding - I just used what I knew and duplicated. And duplicated again, possibly tweaked lol.So no wonder the code had to be "lived" to change it.

Seriously though, I think its great TinyPortal lives on, both as SMF and now also Elkarte mod. 

Just a note that you're in good company Bloc.  God created the platypus first,...

X

.a beaked, web-footed hairy mammal that lays eggs (arguably putting too much functionality in, also) and then began to refine things from there..

And likewise, if you live with one long enough you find the platypus is kinda cool..
__________________________________________________________________________
// Deep inside every dilemma lies a solution that involves explosives //

Re: TinyPortal for Elkarte

Reply #7
I just tested this add-on on Elkarte 1.1.7 and after I click on "Promote to frontpage" I get an error:
Code: [Select]
    Tipo di errore: Generale
    Warning: require_once(/sources/subs/Exception/Controller/TinyPortal/ElkException.class.php): failed to open stream: No such file or directory
    /index.php?action=tportal;sa=publish;t=4
    File: /sources/Autoloader.class.php
    Line: 223
sorry for my bad english

Re: TinyPortal for Elkarte

Reply #8
I just tested this add-on on Elkarte 1.1.7 and after I click on "Promote to frontpage" I get an error:
Code: [Select]
    Tipo di errore: Generale
    Warning: require_once(/sources/subs/Exception/Controller/TinyPortal/ElkException.class.php): failed to open stream: No such file or directory
    /index.php?action=tportal;sa=publish;t=4
    File: /sources/Autoloader.class.php
    Line: 223


Thanks, looks like I need to escape the exception class. I’ll fix that in RC3, although that’s hiding another error.

Re: TinyPortal for Elkarte

Reply #9
Found another one, when you click to "show latest comments" index.php?action=tparticle;sa=showcomments
Code: [Select]
    Tipo di errore: Database
    Errore del Database: Unknown column 'var.type' in 'where clause'
    /index.php?action=tparticle;sa=showcomments
    File: /TinyPortal/Model/Database.php
    Line: 43
sorry for my bad english

Re: TinyPortal for Elkarte

Reply #10
Found another one, when you click to "show latest comments" index.php?action=tparticle;sa=showcomments
Code: [Select]
    Tipo di errore: Database
    Errore del Database: Unknown column 'var.type' in 'where clause'
    /index.php?action=tparticle;sa=showcomments
    File: /TinyPortal/Model/Database.php
    Line: 43


Thanks, I have fixed the first one.

It's in this commit, which is mixed with other changes I'm afraid.

https://github.com/tinoest/ElkTinyPortal/commit/361e08bcc45bba028a6a1f5191e63628135ed2ae

The bit you need is https://github.com/tinoest/ElkTinyPortal/blob/361e08bcc45bba028a6a1f5191e63628135ed2ae/TinyPortal/Controller/Portal.php#L80

How do you get to the showcomments link? I never actually found out where that was defined.

Edit:

That was fixed on the main TinyPortal in this commit, https://github.com/Tinyportal/TinyPortal/commit/a8519b8a8303af4e5a48c4e5e683e4b2e14b5392#diff-e527f1a1f68898c41b31e4c2aae658183c74f4979192b96c45599c9ceaf980c9 I either need to port it across or if it's not actually referenced remove it. (As I don't know where it's referenced I'm relying on you for that one I am afraid)


Re: TinyPortal for Elkarte

Reply #11
Found another one, when you click to "show latest comments" index.php?action=tparticle;sa=showcomments
Code: [Select]
    Tipo di errore: Database
    Errore del Database: Unknown column 'var.type' in 'where clause'
    /index.php?action=tparticle;sa=showcomments
    File: /TinyPortal/Model/Database.php
    Line: 43


That's also fixed in this PR and will be part of the RC3 release.

https://github.com/tinoest/ElkTinyPortal/commit/69d9e2382d8bfc9db4467da3147a31fc866d6de0

Thanks for the feedback and testing.

Re: TinyPortal for Elkarte

Reply #12
Killed a little time in home office.  :D

German formal language pack for TinyPortal for ElkArte V1.0.0 RC3. Installable via package manager.
▬|████|▬
This is a Nudelholz! Take it und hau it on the Kopp of a bekloppt Person .... to give you a better Gefühl than vorher.
ElkArte 1.1.x & TP on Apache2.4.48, PHP 8.0.8 FPM/FastCGI