Skip to main content ↑ ↓
Topic: messageicons (Read 14880 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

messageicons

I'm playing with messageicons and my mod:
http://custom.simplemachines.org/mods/index.php?mod=3216

With the current implementation it is possible to set the same file in as many boards as you want and each icon can have a different order position and have different description for each board (and potentially in the same board, even though in that can only one is shown...that makes some of the current things useless).

The changes I apply with my (broken) mod limit this to 1 messageicon per file name with 1 description and 1 "relative" position. Nothing more.

Is that enough?
I think so, though maybe someone wants moar...
Bugs creator.
Features destroyer.
Template killer.

Re: messageicons

Reply #1 –

Looks fine at first sight. At least for them message icons shinies fans. :)

 TestMonkey doesn't really use them message icons. Except to break them occasionally at an upgrade fix or som'thing.

Are you thinking to add it to D?
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: messageicons

Reply #2 –

Oh. Tis blue! :D

 TestMonkey thinks this is the color of /me for the day... never know what tomorrowz brings with SpudsMan messing around.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: messageicons

Reply #3 –

 emanuele likes blue! :D
Bugs creator.
Features destroyer.
Template killer.

Re: messageicons

Reply #5 –

It's nice! I was looking over the code. I almost had a very bad (tm) suggestion for the database changes, before I realized that it's an icon in an order on a board, mmk.  headscratch :-X

 TestMonkey doesn't always get message icons shiny thingies.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: messageicons

Reply #6 –

 emanuele doesn't like that table, but is not sure how to fix it... ::)
Bugs creator.
Features destroyer.
Template killer.

Re: messageicons

Reply #7 –

My thinking is that we should first know exactly what we want it to be for. :D I mean, what functionality should it support. (existing and new)
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: messageicons

Reply #8 –

Quote from: emanuele – With the current implementation it is possible to set the same file in as many boards as you want and each icon can have a different order position and have different description for each board (and potentially in the same board, even though in that can only one is shown...that makes some of the current things useless).

I don't understand, sorry... What would it mean, to set different descriptions for the same icon in the same board? Or do you mean something else?


For the rrest, it's my kind of featurre! A cool thing that nobody underhstands! :D

You know... what if we change the interface? Instead of users setting each message icon per board and with 'order', lets list the boards, and for each, allow them to mess with icons to set them in the order they want. (and to check/uncheck them, unchecked=not used in this board).

 Feature Cat thinks it might be yummy...
Last Edit: December 22, 2012, 04:22:16 am by Feature Cat

Re: messageicons

Reply #9 –

Quote from: Feature Cat – I don't understand, sorry... What would it mean, to set different descriptions for the same icon in the same board? Or do you mean something else?
Yep, not very well explained...
I used "icon" to describe what is in the database, while "file" is what is on the file system.
So you can have 1 file xx.gif with multiple descriptions in different positions for the same board.
That is theoretical, because the moment it is actually used to post a message only one of those replicates is used.

Quote from: Feature Cat – For the rrest, it's my kind of featurre! A cool thing that nobody underhstands! :D

You know... what if we change the interface? Instead of users setting each message icon per board and with 'order', lets list the boards, and for each, allow them to mess with icons to set them in the order they want. (and to check/uncheck them, unchecked=not used in this board).
Something like smiley?...
Bugs creator.
Features destroyer.
Template killer.

Re: messageicons

Reply #10 –

Quote from: emanuele –
Quote from: Feature – For the rrest, it's my kind of featurre! A cool thing that nobody underhstands! :D

You know... what if we change the interface? Instead of users setting each message icon per board and with 'order', lets list the boards, and for each, allow them to mess with icons to set them in the order they want. (and to check/uncheck them, unchecked=not used in this board).
Something like smiley?...

Oh. On the order, and 'disable', yes, sure... you're right, that makes sense.

On the boards (so first screen to choose...), I was thinking at: choose a board, modify,
http://www.spudsdesign.com/dialogo/index.php?action=admin;area=manageboards;sa=board;boardid=2
see the list of message icons enabled for it (and those disabled) and be able to move/disable them...
[smileys-like step]


 Feature Cat doesn't have a clue if it's a good or terrible idea.
 

Re: messageicons

Reply #11 –

Ahh...okay, change completely the place where the icons are set.

TBH, I'm not sure "how" MIs (== MessageIcons) are used...this would give a lot of possibilities, but then to change the order of one icon that you use on all the boards you'd have to edit all the boards one by one (or have another quite confusing interface)...

Definitions:
file => a file in the theme_dir/images/post/ directory
 image => the picture saved in a file (different files can have the same image)
* icon => all the entries in the {db_prefix}message_icons table with the same filename

My idea was: 1 file == 1 icon (i.e. in the current db implementation 1 common entry in the database that can be associated with multiple boards or only few, etc.).
Do you want to use the same image in a different position for some board? Copy the file with a new filename and create a new icon.

Unfortunately with so much flexibility I don't think there is a good way to present the interface...
Bugs creator.
Features destroyer.
Template killer.

Re: messageicons

Reply #12 –

Does anyone ever use all of this? Just wondering.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: messageicons

Reply #13 –

Of course not. Like most of the other features! :P
Bugs creator.
Features destroyer.
Template killer.

Re: messageicons

Reply #14 –

I updated to the Javascript for the quick edit which affected the message icons editing.

The way the theme is currently, it hides the default xx icon but shows the other message icons, I did not change that.

1) If you were in quick edit, on a message which was not using the default icon and tried to change that icon it, it would 1/2 fail, the new icon would not appear until you refreshed the page (it was failing on the ajax end of things). That's been fixed.

2) I changed it so that now if you quick edit a message, that had the icon hidden,  the icon will appear for you to edit, and only re-hide if its left (or changed to), the default

3) I did not change the quick icon edit itself so its not quite right ATM.  If you have a message which did not use the default, icon and change it back to the default, it will not hide that icon until the next page refresh. 

Just felt like messing around with the JS :P

(you may need to refresh the old cache to see the change)
Last Edit: December 22, 2012, 05:26:48 pm by Spuds