Skip to main content ↑ ↓
Profile Recent Posts in this forum Started by nwsw · · Read 4471 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Profile Recent Posts in this forum

The links to recent posts on this forum are broken. For example, on my profile, one of my posts is linked as:

https://www.elkarte.net/community/index.php?topic=6141.0;msg=44492;%23msg44492

but it should probably look like:

https://www.elkarte.net/community/index.php?topic=6141.msg44492#msg44492

I looked through the patch_1-1-10 branch. The relevant part of ProfileInfo.controller.php function _load_recent_posts has not changed in 11 years, so I am guessing that this forum is running the Development branch and uses the UrlGenerator code.

Re: Profile Recent Posts in this forum

Reply #1 –

Quote from: nwsw – so I am guessing that this forum is running the Development branch
This forum is running Elkarte 2.0 dev
sorry for my bad english

Re: Profile Recent Posts in this forum

Reply #2 –

Yeah, after I spent some current time here, that turns out to be obvious (see bottom of each post POWERED BY). Still, recent post links are totally broken:

(look at recent activity)
- https://www.elkarte.net/community/index.php?action=profile;u=122;name=radu81

Re: Profile Recent Posts in this forum

Reply #3 –

Given a little time, I could probably isolate the problem with the 2.0 UrlGenerator code.

Re: Profile Recent Posts in this forum

Reply #4 –

Quote from: nwsw – Yeah, after I spent some current time here, that turns out to be obvious (see bottom of each post POWERED BY). Still, recent post links are totally broken:

(look at recent activity)
- https://www.elkarte.net/community/index.php?action=profile;u=122;name=radu81

I go to Radu81's profile, and look at his messages, the links are fine. His Topic links are also fine.
I go to your profile and look at your messages, and the links there too are fine. Your Topic links are also fine.

If you have one that appears to not be working, copy the link title and the link URL to it, and then click it and copy the Link Title and Link you ended up at, and include it in a post in this thread.
Thanks..
// Deep inside every dilemma lies a solution that involves explosives //

Re: Profile Recent Posts in this forum

Reply #5 –

@Steeley
I thought the same, until I tested both the "bad" and the "good" links in the first post.
What's not working, is jumping to the correct post.
It does go to the correct topic, but does not go to the correct post.

Follow both in the original post to see.

Re: Profile Recent Posts in this forum

Reply #6 –

Yea .. now I see it.. that first link appears to be trying to go to the message - displays the right Topic and Section (#5) looking for msg 84 (the actual post), but then below that topic and section 'banner',  displays messages starting at #1.
And yes, Radu81's link to his posts in that thread does the same thing.

And, in fact, in my own profile I click on links to posts in long threads and it reverts to display message #1 in the topic. A stack overflow perhaps?


I wonder how nwsw broke it that hard? :thinking: :man_shrugging:

( @nwsw, I'm not saying this is your fault, just that I'm gonna blame you for it..)

..:stuck_out_tongue_winking_eye:
Last Edit: November 26, 2024, 12:00:50 pm by Steeley
// Deep inside every dilemma lies a solution that involves explosives //

Re: Profile Recent Posts in this forum

Reply #7 –

@Steeley

Here's the link given:

https://www.elkarte.net/community/index.php?topic=6357.0;msg=45753;%23msg45753
Instead of:
https://www.elkarte.net/community/index.php?topic=6357.0;msg45753#msg45753

Seems like the # is getting changed to %23
Seems like something is getting mixed up, but not too sure if it's in the generator, or something in just that page.
It's the only part of the forum that seems to have the issue. Never noticed before, due to lack of use of the page?
This is confirmed to be 2.0 Dev only issue.
 

Re: Profile Recent Posts in this forum

Reply #8 –

Yea,  and it happens at some point when the message count in a topic exceeds some value --that's something @Spuds is going to have to fix...
// Deep inside every dilemma lies a solution that involves explosives //