Re: Profile.english.php - No loading from variant theme language folder
Reply #3 – April 13, 2014, 12:17:13 pm
I have the *.english.php files uploaded to a test site. If you and Spuds would like an admin account to look at the changes let me know and I will create the users. You will likely need to do a side-by-side comparison between the new and old to see the differences. A lot of the changes are in the Admin panel as far as the language. The custom theme itself has a lot of visual changes that balance out the placement of buttons, etc. and works towards a consistant display behaviour. If you want to try the theme out here then let me know. The language string changes seem to work well on the default/custom theme.
Re: Profile.english.php - No loading from variant theme language folder
Reply #4 – April 13, 2014, 01:42:23 pm
Why would you ever need languages files by variant in practice (as opposed to just testing it for the hell of it)? The variant system was never intended to handle languages files.
Re: Profile.english.php - No loading from variant theme language folder
Reply #5 – April 13, 2014, 01:46:29 pm
Look at the path. I believe he's talking about a full theme other than the default. Not an actual variant in Elk terms.
Re: Profile.english.php - Not loading from theme language folder
Reply #7 – April 13, 2014, 06:08:51 pm
emanuele
Global Moderator
Yeah, it seems you changed several strings, probably a comparison of the files is necessary to get exactly where the changes were. Up to you, if you feel comfortable, feel free to send a pull request (maybe doing a commit for each file or something like that), otherwise you can attach the files here and someone can pick them and do the PR.