Skip to main content ↑ ↓
Topic: Quick edit fails to update text in 2.0 dev (Read 965 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Quick edit fails to update text in 2.0 dev

Steps:

1. Post something
2. Click quick edit
3. Make some changes, click save
4. Nothing changes until a page refresh

Expected: changes immediately

Re: Quick edit fails to update text in 2.0 dev

Reply #1 –

My suspect is this new quick reply as I remember my addon did have that problem.

Re: Quick edit fails to update text in 2.0 dev

Reply #2 –

Sounds to me like it lost the quick refresh that usually happens when you save a quick edit. Especially if it shows the changes after a refresh.

Re: Quick edit fails to update text in 2.0 dev

Reply #3 –

It's supposed to update the DOM/innerHTML of the message with the new content, yes.

Re: Quick edit fails to update text in 2.0 dev

Reply #4 –

Should be fixed now, be sure to flush your browser cache as I had to change a JavaScript file

I had added a header check, and under some circumstances, it was not being sent so the page refresh failed.

Re: Quick edit fails to update text in 2.0 dev

Reply #5 –

Alright, I'll test on this message.

Edit: and it works! :)

Edit 2: hm, by refreshing the whole page? No, it's just things moving about a bit… I feel like that didn't used to happen, or at least not noticeably.