Skip to main content
Topic: [ADDON] Fancybox  (Read 19765 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: [ADDON] Fancybox

Reply #60

Great, it works now as expected! Thank you!

Re: [ADDON] Fancybox

Reply #61

Support Elk 1.1?
Sorry for my English

Re: [ADDON] Fancybox

Reply #62

It will be updated :D and PR's are welcome !
Be safe, Be kind, Happy Programing

Re: [ADDON] Fancybox

Reply #63

Updated package to support ElkArte 1.1
Be safe, Be kind, Happy Programing

Re: [ADDON] Fancybox

Reply #64

I am using the latest version 1.0.6 of this addon on elkarte 1.0 and I was looking in my php error log and I found a lot of lines with this error:
[04-Mar-2018 21:17:06 Europe/Rome] PHP Notice:  Use of undefined constant FORUM_VERSION - assumed 'FORUM_VERSION' in .../public/sources/subs/fb4elk.subs.php on line 48
Code: [Select]
47.	// Disable the built in lightbox support in ElkArte 1.1
48. if (substr(FORUM_VERSION, 8, 3) === '1.1')
49. {
50. addInlineJavascript('$(document).ready(function() {$("[data-lightboximage]").off("click.elk_lb");});');
51. }

Seems that changing:
Code: [Select]
	if (substr(FORUM_VERSION, 8, 3) === '1.1')
with:
Code: [Select]
	if (substr('FORUM_VERSION', 8, 3) === '1.1')
solves the problem

This also broke image cache addon for elkarte 1.0.x
sorry for my bad english


Re: [ADDON] Fancybox

Reply #66

Bumped the release to v1.0.7

 o Update to FancyBox v3 library.  Removes old v2 options and replace with v3 options (simplify as well)
 o If you prefer FancyBox v2 features stay with v1.0.6 of the addon, it runs fine under 1.1.x
Be safe, Be kind, Happy Programing

Re: [ADDON] Fancybox

Reply #67

Hello,
I'm still using version 1.0.6 because it still works fine with my 1.1.8 EA forum.
Today I added the webp format to the allowed file types in the forum (in the settings for file attachments). When I tried to insert three webp photos into a post via Fancybox, it didn't quite work.
After uploading the photos and setting the widths and positions of the thumbnails in the post, the thumbnails do show up in the previews, but when I save everything afterwards, only the Lorem Ipsum placeholders show up in the post instead of the thumbnails.

Where can the error be? With jpg or png it still works.
Does something have to be changed somewhere on the Fancybox code pages or something else in the EA forum?

thumbs.png
ElkArte version: 1.1.8 / Theme: BeSocial / PHP 8.0

Re: [ADDON] Fancybox

Reply #68

There was a brief discussion about WebP ... https://www.elkarte.net/community/index.php?topic=6037.0

Its not well supported by PHP/GD, depends on what your host has done.  Plus ElkArte itself is not ready for them, so for now I would not play with them.

Be safe, Be kind, Happy Programing

 

Re: [ADDON] Fancybox

Reply #69

Oh, okay, no problem. I'll just wait and see how WEBP and ElkArte will go on. In any case, it would be great to be able to insert such images at some point.
In the last half year I found more and more WEBPs on the net and about two months ago I started to insert only this format on my own website. At least for images above a certain size.The quality of these images is usually much better than comparable images in JPG, and the file size is only about one third of the JPG size.
I believe, meanwhile even all large browsers support WEBP.
ElkArte version: 1.1.8 / Theme: BeSocial / PHP 8.0