Skip to main content ↑ ↓
Broken link redirects to 404 WSOD instead of board index Started by Flavio93Zena · · Read 13062 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Broken link redirects to 404 WSOD instead of board index

It's me again! I know I'm annoying ;D

Found a bug while randomly testing stuff on BurkeKnight's forum. Do note the forum has been converted from SMF to Elkarte.
Installed addons:
Code: [Select]
1	reCaptcha	1.0.0	[ Uninstall ] [ List Files ] [ Delete ]
2	Spoiler Modern	0.0.1	[ Uninstall ] [ List Files ] [ Delete ]
3	Ultimate Menu	1.0 Beta	[ Uninstall ] [ List Files ] [ Delete ]
4	Censored Words	1.0	[ Install Add-on ] [ List Files ] [ Delete ]
5	SimplePortal	1.0.0 Beta 1	[ Uninstall ] [ List Files ] [ Delete ]
6	Topic Solved	1.0	[ Uninstall ] [ List Files ] [ Delete ]
7	Users online today	0.2.1	[ Uninstall ] [ List Files ] [ Delete ]
8	Multi Badges	0.1.0	[ Uninstall ] [ List Files ] [ Delete ]
9	Hide User Names	1.0	[ Install Add-on ] [ List Files ] [ Delete ]
10	Inline Attachments	1.0	[ Uninstall ] [ List Files ] [ Delete ]
11	Remove Last Edit By	1.0.0	[ Uninstall ] [ List Files ] [ Delete ]
12	ElkArte 1.0.4 patch	1.0	[ Uninstall ] [ List Files ] [ Delete ]

So basically what goes wrong is that this link (http://www.webmastershaven.net/%7Bunread_all_url%7D) redirects to a 404 white page, saying "The requested URL /{unread_all_url} was not found on this server." (in case it wasn't clear it's the action=unread;all)
Apart from the fact that the link is broken for reasons that we still have to clarify... The issue is that the forum doesn't redirect to the board index as it should with non-available links, broken ones etc instead of a 404 page.
~ SimplePortal Support Team ~

Re: Broken link redirects to 404 WSOD instead of board index

Reply #1 –

This happens to 3 sites, all converted from SMF to ElkArte.
However, a 4th site, also converted, does not have this issue.

But, the 4th site, used install of Elk 1.0.4 where the other 3 were done with 1.0.3 then used the update patch to 1.0.4.


EDIT:

We had another 1.0.4 install that was a conversion of yet another SMF site. That also has no issue.
This should confirm that it is something missing in the 1.0.4 update package.

Re: Broken link redirects to 404 WSOD instead of board index

Reply #2 –

Quote from: Flavio93Zena – So basically what goes wrong is that this link (http://www.webmastershaven.net/%7Bunread_all_url%7D) redirects to a 404 white page, saying "The requested URL /{unread_all_url} was not found on this server." (in case it wasn't clear it's the action=unread;all)
Apart from the fact that the link is broken for reasons that we still have to clarify... The issue is that the forum doesn't redirect to the board index as it should with non-available links, broken ones etc instead of a 404 page.
Sorry, but it's still slightly unclear to me...
Are you talking about:
http://www.webmastershaven.net/index.php?action=unread;all ?
If so, it works just fine as a guest showing the login page.
And works fine here (do note it's the ".it" website):
http://www.elkarte.it/community/index.php?action=unread;all
that was updated to 1.0.4 via package manager.

Then, another little thing I'm not sure about: you are talking about 404, but action=unread doesn't need a 404 at all since it's a perfectly valid action, so it should just show the page it is supposed to serve and not a 404.

That said, @Burke Knight  could you check the server error logs to be sure what the actual error is?
Bugs creator.
Features destroyer.
Template killer.

Re: Broken link redirects to 404 WSOD instead of board index

Reply #3 –

If you go to either unread posts or replies, and it says there are none and has the button to look for all unread, the button is the issue.  The link's variable is messed up. Need to be logged in to see it.

EDIT:

Attached screenshot of what URL says, when hover over the button.
Last Edit: June 28, 2015, 06:58:37 am by Burke Knight

Re: Broken link redirects to 404 WSOD instead of board index

Reply #4 –

Okay, that's almost completely different from the OP, but now I have another point to look at. :P

On the same forum as above the situation is still correct: the url is right and doesn't contain the {unread_all_url} bit.
I upgraded also:
http://testing.elkarte.it/elk/index.php
straight from 1.0.1 up to 1.0.4 and as you can see from the attachments the url looks good.

Based on the elements I have at the moment, I'd say the problem is due to an addon that reloads the index language file after the string has been replaced... no idea which one.

I'd keep this here just because I'm quite sure replace strings like that is at least bad practice (and I'm guilty, because I used that trick in some places), so they should be phased out "at some point", probably in 1.1 we should start using $context and maybe keep the string replacement just to reduce impact on backward compatibility, but that is debatable at least.

Re: Broken link redirects to 404 WSOD instead of board index

Reply #5 –

Yet, all the forums have the same addons. LOL
I'll look when can, to see what may have done differently.

Re: Broken link redirects to 404 WSOD instead of board index

Reply #6 –

The latest version of the SimplePortal mod.
When set it to disabled, the link goes normal.
Also, if set to front page, get this:


An Error Has Occurred
Unable to load the 'main' template.

Re: Broken link redirects to 404 WSOD instead of board index

Reply #7 –

Always in the "unread" pages?
Bugs creator.
Features destroyer.
Template killer.

Re: Broken link redirects to 404 WSOD instead of board index

Reply #8 –

Yes, that's the only place that button is shown, that I'm aware of.
And this seems to only affect that.

Re: Broken link redirects to 404 WSOD instead of board index

Reply #9 –

Sorry, bad wording, I was thinking at the unable to load the main template. :)
Bugs creator.
Features destroyer.
Template killer.

Re: Broken link redirects to 404 WSOD instead of board index

Reply #10 –

The unable to load the main template is main page if set portal to front page mode.

Re: Broken link redirects to 404 WSOD instead of board index

Reply #11 –

Oh, okay!
Anyway... @Spuds that's your doing! :P
Bugs creator.
Features destroyer.
Template killer.

Re: Broken link redirects to 404 WSOD instead of board index

Reply #12 –

Still... It's a triple bug to me.
1) SP messing up the unread;all URL.
2) Front page unable to load main template.
3) Elkarte itself not redirecting to board index with that unread broken link.
~ SimplePortal Support Team ~

Re: Broken link redirects to 404 WSOD instead of board index

Reply #13 –

I'll try to look into this over the next couple of days,  I'm a bit over extended in what I have to get done over the next couple of weeks so it may take me a bit to get to this one, sorry !

Re: Broken link redirects to 404 WSOD instead of board index

Reply #14 –

@Spuds

Okay, the main template error, is visible on fresh install of 1.0.4 and sites updated to 10.04 from 1.0.3.

The button to "Click here to try all unread topics" issue, however, is only present on sites updated to 1.0.4 from 1.0.3. Sites that had been fresh install using 1.0.4 are not affected by this odd bug. Does this mean that something in the full install of 1.0.4 maybe inadvertently fixed whatever it is?