ElkArte 1.1.9

ElkArte 1.1.9 Started by Spuds · July 05, 2022, 09:14:52 pm · Read 54526 times 0 Members and 4 Guests are viewing this topic. previous topic - next topic

Re: ElkArte 1.1.9

Reply #60 – November 26, 2022, 01:07:55 am

after installing the patch, the attachments section began to look like this

and it was like this

is it really necessary to roll back

Re: ElkArte 1.1.9

Reply #61 – November 26, 2022, 07:52:39 am

It installs an updated dropAttachments.js file in themes/default/scripts ... check if the new file is there (its header will have 1.1.9)

IF you created a custom theme and copied that file to your custom theme dir, you will need to replace it with the update file (or simply remove it as the system will simply grab it from the default directory)

Be sure to flush your browser cache, even though it has a ?119 to force a refresh

Re: ElkArte 1.1.9

Reply #62 – November 26, 2022, 09:11:16 am

Quote from: Spuds – November 26, 2022, 07:52:39 amIt installs an updated dropAttachments.js file in themes/default/scripts ... check if the new file is there (its header will have 1.1.9)

IF you created a custom theme and copied that file to your custom theme dir, you will need to replace it with the update file (or simply remove it as the system will simply grab it from the default directory)

Be sure to flush your browser cache, even though it has a ?119 to force a refresh

version 1.1.9, resetting the cache didn't help

Re: ElkArte 1.1.9

Reply #63 – November 26, 2022, 09:45:33 am

From a quick look, you have this in your template quickQuote.txt = 'Quick Quote'; on the posting page. That is not valid so the rest of the javascirpt on that page does not run (including the drag/drop attachment area)

The above is not part of 1.1.9, so it should be removed.

Re: ElkArte 1.1.9

Reply #64 – November 26, 2022, 09:49:37 am

Quote from: Spuds – November 26, 2022, 09:45:33 amFrom a quick look, you have this in your template quickQuote.txt = 'Quick Quote'; on the posting page. That is not valid so the rest of the javascirpt on that page does not run (including the drag/drop attachment area)

The above is not part of 1.1.9, so it should be removed.

Yes, it helped, but it's a pity to part with that useful mod

Re: ElkArte 1.1.9

Reply #65 – November 26, 2022, 09:51:23 am

Another note, the site on version 1.1.9 has become longer to load

Re: ElkArte 1.1.9

Reply #66 – November 26, 2022, 10:15:03 am

Quote from: ksamochkin – November 26, 2022, 09:49:37 amYes, it helped, but it's a pity to part with that useful mod

Its still part of 1.1.9, but that looked to be a remnant from an early test version of 1.1.9 and its just that line was no longer needed.

Quote from: ksamochkin – November 26, 2022, 09:51:23 amAnother note, the site on version 1.1.9 has become longer to load

That could be the "combine css/js" hives being re-build due to the changes. When those are first created it can slow the page load, should only be a temporary issue. You can disable that function while you are working on your site, and when you are done setting everything up, then enable it.

The other possible slow down is often hostname lookups which are slow on some servers. You can disable that in you elkarte admin panel under servers.

Re: ElkArte 1.1.9

Reply #67 – November 27, 2022, 09:23:47 pm

Should 1.1.9 be released by now or there are something more needed to be fixed and/or added?

Re: ElkArte 1.1.9

Reply #68 – November 28, 2022, 05:47:41 pm

I've got it installed on my "robot friendly" site for abuse testing and several other sites. I did notice a small issue with bad behavior (results in error log spam) that I'll fix in the final patch.

I am also going to add a step to patch SP during the install since if you don't update SP before the patch you could end up with a defunct site. Its not normal to patch an addon, but in this case I think its prudent.

Going to final this weekend is my goal. I also want this to be done so I can get back to 2.0 !!

Re: ElkArte 1.1.9

Reply #69 – December 06, 2022, 09:06:33 pm

Quote from: Spuds – October 13, 2022, 10:21:14 amIf you have simple portal installed .... See https://www.elkarte.net/community/index.php?topic=6141.msg44129#msg44129

I have a SP 1.0.1 just about ready to release to fix that and some other issues reported over the months since 1.0.0

I do not have SP installed and reverting back to 1.1.8 seems to work. When I re-patched with 1.1.9 it happened again. I will test again later.

Re: ElkArte 1.1.9

Reply #70 – December 06, 2022, 10:02:25 pm

I restored 1.1.8 version from the zip file again making sure all files are the original 1.1.8 and no hooks. Install the 1.1.9 patch. And the hacking attempt comes again. Error log reported this:

Re: ElkArte 1.1.9

Reply #71 – December 08, 2022, 08:20:17 am

Ah thanks for those details.

I had seen bad behavior log errors on a test site, but not during the patch phase.

I've attached the fixed plugin which should resolve that error. Just replace the one in ...sources\ext\bad-behavior

Re: ElkArte 1.1.9

Reply #72 – December 08, 2022, 10:01:12 am

Thanks, this did the trick.

Re: ElkArte 1.1.9

Reply #73 – January 16, 2023, 03:27:10 pm

Once again, I think 1.1.9 is about ready^tm I'll post the latest patch package FOR TESTING after this note.

This update should address all of the items brought up in this thread, plus some reported on github, some pm reported, and some just found. The only open issue that is not addressed (that I am aware) is one @radu81 reported where the WEBP ILA in preview mode appears to be full resolution, seems like RL has consumed him for now so work on that will have to wait

Note its important to get 1.1.9 finalized as the 1.1.8 install package does not work on PHP 8.1 and PHP 7.4 is essentially EOL at this point (in terms of support and security patches). I may update the 1.1.8 install package.

I've updated and again broken down the changes into various top-level categories for easy viewing. For those interested, each item has a ref link that will take you to the specific code changes.

1.1.9 Changelog

Below are the key changes in 1.1.9, the full change listing is (here).

New Features
[New Feature] Quick Quote. This is where you select text and you can quote that when using quick reply (ref).
[New Feature] Quote Show More. Quote display limiting function. (ref).
[New Feature] Webp support to attachments and avatars. Includes the removal of save as PNG and dynamically set this based on alpha channel (ref).
[New Feature] Open graph meta data and schema.org micro data to help with SEO (ref) & (ref).

Feature Enhancements
[Enhancement] Quote Depth Instead of allowing, or not, nested quotes, this allows you to limit them to a depth. (ref).
[Enhancement] Save avatars as PNG and thumbs as PNG options have been removed. The system will simply detect if the image has transparency and save as appropriate (Webp or if not enable then PNG or JPG)
[Enhancement] Refactoring video embed code (from 2.0), also added tiktok support (ref).
[Enhancement] preview ILA was using a low quality image in some instaces (ref).
[Enhancement] Increase db size for password_hash (and needed for conversions) (ref).
[Enhancement] Allow for pass conversion from current forums (ref).
[Enhancement] Use low overhead thumb process for thumbnails (imagick) (ref).
[Enhancement] Resize large images before doing pixel inspection to save memory (ref).
[Enhancement] Don't do any rotation processing if not a jpg (imagick) (ref).

General Improvements
[improve] Fix admin registration form layout (ref).
[improve] 4byte efficiency improvement (ref).
[improve] Several improvements to HTML -> MD conversion function. (ref).
[improve] Several improvements to HTML -> BBC conversion function, used by email posting (ref).
[improve] Improvement to how unsubscribe token is created and shown (ref).
[improve] Minor CSS fixes (ref).
[improve] Use the alt value if its available for cid (inline image attachment) (ref).
[improve] Be a little less restrictive on email table structure swapping to plain text (ref).
[improve] Some multipart/mixed plain sections should be joined (ref).
[improve] Error box in login form was a mess (ref).
[improve] Search result enhancements, show the first matching message in a topic, preventing a very short message from gaining to much relevance (ref).
[improve] Improve the search highlight logic (ref).
[improve] New default Gravatar options (ref).
[improve] Improve the ILA button and CSS(ref).
[improve] Update markdown (ref).
[improve] Indicate the avatar preview with text and not just a red border (ref).
[improve] Allow upload avatar preview (2.0 backport) (ref).
[improve] Tweak smiley position in sentence to better work with font (ref).
[improve] Add 'att_reset' to BBC parser (used by ila) (ref).
[improve] Allow a way for only devs to see depreciation notices (ref).
[improve] Add topic approval to quick moderation action from message index (ref).
[improve] Cursor was left in quote when in wizzy mode (ref).
[improve] Scroll into view works better then older location hash (ref).
[improve] From OI, potential pw conversion (ref).

Bugs Fixed
[bugfix] Emptying the cookie name could leave the admin locked out (ref).
[bugfix] Collapsing legend in ACP was not (always) working (ref).
[bugfix] Mention pulldown (in wizzy) would collapse after positioning. Simplify / expand regex and fix time-gate (ref).
[bugfix] Some items were not being logged (ref).
[bugfix] Various post by email updates to better support multipart/related and multipart/mixed formats. (ref).
[bugfix] Profile Edits selection was still shown when core feature was off (ref).
[bugfix] PBE replies were not run through htmlspecialchars on save (ref).
[bugfix] Quick Quote needs to be wrapped in CDATA for safety, thanks Steeley for the report (ref).
[bugfix] Revert https://github.com/elkarte/Elkarte/pull/3664/commits/3ad77313c04d8af309ebf8c15156f389778e9454 and fix another way (ref).
[bugfix] Account for empty center tags as happens in email due to html stripping. (ref).
[bugfix] cleanXml escape missed a few characters (ref).
[bugfix] Strip tags can return nothing, need to catch that occurrence (ref).
[bugfix] Email parsers could clip the closing body tag (ref).
[bugfix] Adjust regex for --- to hr when processing email (ref).
[bugfix] Reset this hidden item when ACP is updated (ref).
[bugfix] Check for * disposition for attachment processing (PBE) and sanitize file names (ref).
[bugfix] Leave attachments alone in multipart/mixed (ref).
[bugfix] More multipart/mixed processing of any sections (ref).
[bugfix] iconv_mime_decode may fail or even partially decode, check for that (ref).
[bugfix] Handle multiple content-type or content-transfer-encoding they are not vaiid but do occur (ref).
[bugfix] fix #1878 package server controller missing tab data (ref).
[bugfix] Account for version level tags with v at the start like v1.1.7 (ref).
[bugfix] Fix a host of minor issues with drag and drop attachments (ref).
[bugfix] memoryReturnBytes function could be passed improper data and fail (ref).
[bugfix] Fix tests to run as actions, add 8.1 support, pack up old travis tests (ref).
[bugfix] I guess one could use webp as smileys (ref).
[bugfix] Update attachment download/view gobbledygook code (ref).
[bugfix] Post separator markup was messy and did not render properly in all browsers (ref).
[bugfix] Without an isset in the controller, those may not work as expected (ref).
[bugfix] The CSS quick mod checkbox style was somehow dropped in 1.1 (ref).
[bugfix] Action_no_attach exits, no need to return (ref).
[bugfix] backport a bunch of ILA edge case fixes from 2.0 (ref).
[bugfix] Return approved status to ILA so it can act accordingly (ref).
[bugfix] attachurl was not replacing the temp with the public id (ref).
[bugfix] Provide a way to show pending approval for ILA images (ref).
[bugfix] Function is not used, no need to load it (ref).
[bugfix] Specify load lazy value for avatar images (ref).
[bugfix] That function can return false, so best to exit from unzip (ref).
[bugfix] fix #3561 label it as posts or topics to avoid confusion (ref).
[bugfix] fix #3521 (ref).
[bugfix] don't set the level before the type (ref).
[bugfix] Proposed fix for #3518 4-byte chars in filename. Expose clean_4byte_chars for use in other places (ref).
[bugfix] Point to the correct wiki endpoints (ref).
[bugfix] a 2 second cache is not useful (ref).
[bugfix] Viewing a ban group would result in a blank screen error (ref).
[bugfix] A few mobile adjustments (ref).
[bugfix] Use the sanitized value (ref).
[bugfix] _ in url were escaped and need to be set back (ref).
[bugfix] Used by PBE but never set (unapproved topic/post) (ref).
[bugfix] Unapproved topic with oldTopicDays set would result in error (ref).
[bugfix] Prevent undefined error in custom fields (ref).
[bugfix] Consistent keyinfo layout helps with QQ addon (ref).
[bugfix] fix #3409 .icon_anchors should have transform (ref).
[bugfix] ILA "share" button was getting blocked by filters (ref).
[bugfix] Point to the right site for addons, not the cname (ref).
[bugfix] The return path should not be set for sendmail, smtp does its own. Also the syntax was not compliant. (ref).
[bugfix] Annoyance, after upload the install package was missing, for addons, from the upload completion page. (ref).
[bugfix] Single line code BBC was showing vertical scroll (ref).
[bugfix] fix #3407 clean up CSS for RTL buttons (ref).
[bugfix] PM's were not updating reply status (ref).
[bugfix] Toggling core features on/off could overflow log_mentions status (ref).
[bugfix] Gravatar avatar in account button would break with rating enabled (ref).
[bugfix] Signature chars remaining was not working as expected (ref).
[bugfix] fix #3536 html2md was breaking plain text Links plus more (ref).
[bugfix] Make sure only return is an accepted type (ref).
[bugfix] Changed like_button to react_button, likes_button to reacts_button, so that AdBlockPlus doesn't remove the likes button when Social Media Blocking is enabled (ref).
[bugfix] Email search for non moderator, in case sensitive DB, errors (ref).
[bugfix] Error filters were not honoring asc/desc flag. (ref).
[bugfix] That is a post value, not get (ref).
[bugfix] Converted missed functions in install files (ref).
[bugfix] Moved functions to Util as more sensible place for them, imo (ref).
[bugfix] Missed pg_version needing a connection to work (ref).
[bugfix] Big change of all strftime and gm_strftime to elk_strftime and elk_gmstrftime (ref).
[bugfix] The undo plugin caused an unexpeced page jump when preloaded (ref).
[bugfix] Draft last saved spinner was output twice in QR (ref).
[bugfix] Remove extra spaces from text so its bbc valid (ref).
[bugfix] Generating an error while logging an error is bad form\(ref).
[bugfix] Board descriptions that used html were not being converted to bbc (ref).
[bugfix] bb log entry was still causing a ' error even with db_escaping (ref).
[bugfix] SMTP fsock need to use suppress or it will not continue (ref).
[bugfix] Empty privacy policy box was still shown on checkbox registation (ref).
[bugfix] Indentation was being added to output as \n\t\t\t (ref).
[bugfix] Prevent potential 502 gateway failed error, purge buffer as a precaution (ref).
[bugfix] Write all frames if its a gif to avoid dropping animation (gif/imagick) (ref).
[bugfix] Set to first image in layers to avoid 1px thumb (gif/imagic) (ref).
[bugfix] The reduced upload size was not reflected back in the UI (ref).
[bugfix] The buffer should still be cleared before sending the image (ref).
[bugfix] Collasping permission legend in acp was not always working (ref).

PHP 8.1 updates
[8.1] Captcha was not working with PHP 8.1 Updated the ttf fonts to add ones with minor grunge built (ref).
[8.1] Prevent calling of functions that may be disabled by the host (ref).
[8.1] Can't use null in PHP 8.1 (ref).
[8.1] That may be null, and 8.1 will abend (ref).
[8.1] Do not send a float value to chr() (ref).
[8.1] 8.1 error due to curl option never existing (ref).
[8.1] seems recent GD (8.1) does no like the float where an int is needed. (ref).
[8.1] Depreciation notice in 8.1 (ref).
[8.1] More 8.1 tweaks (ref).
[8.1] PHP 8.1 will not like adding strings (ref).
[8.1] un used paramerter, will throw depreciation in 8.1 (ref).
[8.1] fix some 8.1 install errors (ref).
[8.1] 8.1 does not like nulls in these functions (ref).
[8.1] some 8.1 fixes for type hint on interfaces (ref).
[8.1] PHP 8.1 Compat version of strftime (ref).
[8.1] Updated Db-PostgreSQL to be PHP 8.1 compatible (ref).
[8.1] php8.0 can throw undefined error when using unset on an array key (ref).
[8.1] Another 8.1 undefined index (ref).
[8.1] Another issue with 8.1 and BB plugin (ref).

Misc updates
[misc] Get 1.1 tests working again as action vs Travis (ref).
[misc] Address recent memory issue in phpunit (ref).
[misc] Use pcov vs xdebug for test coverage (ref).
[misc] Prevent some already defined error notices in testbed (ref).

Re: ElkArte 1.1.9

Reply #74 – January 16, 2023, 03:48:12 pm

1.1.9 is a big update, mainly since its been over a year since 1.1.8. We were not planning on a 1.1.9 but since 2.0 is taking some extra time, it seemed like we should do a stop gap release and get PHP 8.1 addressed, a bunch of fixes (many edge cases) and toss in some new features (backported from 2.0) All of that is detailed in the above post.

IF <-- that is in bold to gather attention! ... you installed a previous 1.1.9 patch and are still using it and you enabled site metadata in the ACP (features -> general) then turn that off before you uninstall the old patch. When I went to uninstall the previous 1.1.9 patch on a couple of sites I got the ever fun 500 error

However in good diagnostic form I just kept hitting page refresh and it came back so I believe the cause was that integration was still being attempted. I've put a fix for that condition in the new package. All I can say is if you get that error, a page refresh or two will get past that so you can delete the old and install the new.