Skip to main content
Topic: How to do the Upgrade? (Read 6947 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: How to do the Upgrade?

Reply #15

What language files are you using with 1.1.1, Ruth? The german files are not tested with the new ElkArte version. Could be some text strings are missing and not translated.

Re: How to do the Upgrade?

Reply #16

I am still using the "old ones", Jorin. They are working without any error, as I have seen until now - there are just a few strings shown in english, as you said.

Don't matter in a testforum. ;)

Re: How to do the Upgrade?

Reply #17

Quote from: Ruth – It was this stupid browser cache, Radu! (or stupid me) ;)
hmm... that's odd, in theory the ?R111 at the end of the URL should invalidate the browser cache... O_o
Bugs creator.
Features destroyer.
Template killer.

Re: How to do the Upgrade?

Reply #18

I am using Opera, Emanuele...and this browser is always a little "strange" since a few months. ;)

 I had a lot of irritations by working in the files, because of the brower cache, doing things again and again...
And  in my resolution the layout/styling of many pages is somehow broken, also here on ElkArte.net and in my forums.




 

Re: How to do the Upgrade?

Reply #19

Not sure about it, but I think, there is something wrong here?

Every time, when I attach a picture, I will get an error in the log:
 
QuoteNotice: Undefined index: public_attachid
in sources/subs/Attachments.subs.php on line 619

And the attachment details are not centered, see the first screenshot.

It should be display: inline-block instead of display: block here in index.css on line 3127

Code: [Select]
.attachment_name, .attachment_details {
    display: block;
    width: 18em;
    white-space: nowrap;
    overflow: hidden;
    text-overflow: ellipsis;
    padding: 0 .5em;
}

Re: How to do the Upgrade?

Reply #20

Quote from: Ruth – Not sure about it, but I think, there is something wrong here?
Not unlikely. :P

Quote from: Ruth – Every time, when I attach a picture, I will get an error in the log:
 
QuoteNotice: Undefined index: public_attachid
in sources/subs/Attachments.subs.php on line 619
hmm... which one is it the URL associated to the error?

Quote from: Ruth – And the attachment details are not centered, see the first screenshot.
hmm... I thought this was fixed in 1.1.1... I guess I was wrong?
Bugs creator.
Features destroyer.
Template killer.

Re: How to do the Upgrade?

Reply #21

I have canged this about the attachment details in index.css.

Quotehmm... which one is it the URL associated to the error?

Not sure, what you mean, Emanuele? It is the URL of my testforum:

Quote   Notice: Undefined index: public_attachid
http://meinforum.de/ea_test/index.php?action=dlattach;sa=tmpattach;attach=post_tmp_1_6025cc6e537c3e713f739da3052680aa;topic=114
Datei: /var/www/vhosts/meinforum.de/httpdocs/ea_test/sources/subs/Attachments.subs.php
Zeile: 619

I got another error in the log last night, while I had installed a copy of the default theme to work in the css-files:

QuoteNotice: Undefined index: copy
http://meinforum.de/ea_test/index.php?action=admin;area=theme;sa=install
Datei: /var/www/vhosts/meinforum.de/httpdocs/ea_test/sources/admin/ManageThemes.controller.php
Zeile: 1358

And as I have noticed right now, I am not able to upload any attachments in posts if I use this theme, ::)
It is only possible in the default theme. But I will get an error in the log, if I attach pictures.

Last Edit: January 24, 2018, 07:21:57 pm by Ruth

Re: How to do the Upgrade?

Reply #22

Quote from: Ruth – Not sure, what you mean, Emanuele? It is the URL of my testforum:

Quote   Notice: Undefined index: public_attachid
http://meinforum.de/ea_test/index.php?action=dlattach;sa=tmpattach;attach=post_tmp_1_6025cc6e537c3e713f739da3052680aa;topic=114
Datei: /var/www/vhosts/meinforum.de/httpdocs/ea_test/sources/subs/Attachments.subs.php
Zeile: 619
That piece is all I need.
By chance, could it be you:
1) uploaded the attachment,
2) inserted inline
3) delete the attachment,
4) uploaded another one,
5) hit preview with the old attachment still in-line?
I'm trying to figure out the path that lead to this error.

Quote from: Ruth –
QuoteNotice: Undefined index: copy
http://meinforum.de/ea_test/index.php?action=admin;area=theme;sa=install
Datei: /var/www/vhosts/meinforum.de/httpdocs/ea_test/sources/admin/ManageThemes.controller.php
Zeile: 1358
Little bug.
Tracked.

Quote from: Ruth – And as I have noticed right now, I am not able to upload any attachments in posts if I use this theme, ::)
It is only possible in the default theme. But I will get an error in the log, if I attach pictures.
That's odd. :-\
I'm not sure why this would happen.
Will check.
Bugs creator.
Features destroyer.
Template killer.

Re: How to do the Upgrade?

Reply #23

Thank you, Emanuele

Quote from: emanuele – By chance, could it be you:
1) uploaded the attachment,
2) inserted inline
3) delete the attachment,
4) uploaded another one,
5) hit preview with the old attachment still in-line?
I'm trying to figure out the path that lead to this error.

No. I did nothing with inline. I just used the button to upload a picture from my pc and send my post. No preview, no deleting of an attachment.

In the copy of the default the button for uploading is not working, no reaction, if I try to use it. This theme includes a custom css file, so maybe this is the reason?

I made another copy of the default yesterday, in which I don't use a custom.css and in this theme the upload is possible, but with the same errors in the log as in the original default.
Last Edit: January 25, 2018, 08:16:41 am by Ruth

Re: How to do the Upgrade?

Reply #24

hmm... the attachments issue is weird.
I'll try a fresh install this evening, I do not exclude I broke something during the actual release, because I was sure I fixed this bug before releasing the patch.

For the theme, let me give a try first, I want to see how it works here.

BTW what version of PHP?
Bugs creator.
Features destroyer.
Template killer.

Re: How to do the Upgrade?

Reply #25

It is PHP-Version: 5.6.33, Emanuele


Re: How to do the Upgrade?

Reply #26

Darn I had to unisntall 5.6 a couple of days ago in order to install 7 because I was not able to let the two live together! xD
Well, let me see how it goes.
Bugs creator.
Features destroyer.
Template killer.

Re: How to do the Upgrade?

Reply #27

Okay, I could reproduce all the bugs except the attachments details.
Can you give me some more hints? What kind of settings do you have for the attachments? Thumbnails? Full size? What sizes?

These are the fixes:
https://github.com/elkarte/Elkarte/pull/3108/files
Bugs creator.
Features destroyer.
Template killer.

Re: How to do the Upgrade?

Reply #28

Thank you very much, Emanuele!

I never used something from github.  O:-) Therefore I better ask....

For example, now I have to edit the sources/Load.php , in this part:

Code: [Select]
}
else
{
$cache_staler = '';
$params['basename'] = $filename;
}
$this_id = empty($id) ? strtr(basename($filename), '?', '_') : $id;

and instead of this line:
Code: [Select]
$cache_staler = '';

I have to add this?
Code: [Select]
$cache_staler = $staler_string;


QuoteWhat kind of settings do you have for the attachments? Thumbnails? Full size? What sizes?

We don't use thumbnails, our pictures are always to see in full size: 780 x 700 Pixel, 150 KB, 3 attachments per post, see screenshot.

Inline attachments was not enabled yesterday, I made a first try with this today.
Last Edit: January 25, 2018, 05:43:30 pm by Ruth

Re: How to do the Upgrade?

Reply #29

I made those changes in the files from github, Emanuele.

Now there are no more errors in the log by attaching pictures or by making a copy of the default theme.

But it was still not possible to upload pictures, if I use my custom.css, until now. :D

The only problem was this part in my custom.css:

Code: [Select]
.drop_area {
    background-color: #fbecce;
    border: dashed 1px #6993bb;
}

The font and the button are quite big (and ugly) there, so I always had a font-size: 1.1em; in there.
But it seems, that it has to be  font-size: 1.643em; as in index.css now.

Because of this wrong font-size in my custom.css the upload-button did not work before.

Now everything is fine, the upload ist working without any error. ;)
Thank you for your help!