Skip to main content
Topic: Ajax mark all messages read bug (Read 4917 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Ajax mark all messages read bug

When marking all messages as read in action unread there's a bug with the ajax feedback somewhere...
The DIV with the text "No unread topics found since your last visit" is automatically added, howeder the unread messages stay visible. I believe the expected behaviour is:
- add the text "No unread topics found since your last visit"
- hide all messages from the list
Thorsten "TE" Eurich
------------------------

Re: Ajax mark all messages read bug

Reply #1

Probably due to changes in ids and classes.

The attached diff should fix it.

ETA: .txt otherwise I cannot attached it.

Darn, the un_preparse doesn't work on quick edit too now... ::)
Bugs creator.
Features destroyer.
Template killer.

Re: Ajax mark all messages read bug

Reply #2

 For the record, feel free to apply it, I would avoid any other "small fix" in my small_things branch... LOL
Bugs creator.
Features destroyer.
Template killer.

Re: Ajax mark all messages read bug

Reply #3

Quote from: emanuele – For the record, feel free to apply it, I would avoid any other "small fix" in my small_things branch... LOL
ROFL
Thorsten "TE" Eurich
------------------------

Re: Ajax mark all messages read bug

Reply #4

 If you apply that one, could you please add this too? O:-)
In themes/default/css/index.css
Code: (find) [Select]
.topic_sorting #sortby, #sortby,
.topic_sorting:hover #sortby, #sortby:hover {
Code: (replace with) [Select]
.topic_sorting #sortby {
width: 8.4em;
}
.topic_sorting:hover #sortby, #sortby:hover {

Sorry for the trouble... :-[

ETA: it's not perfect (because there is still a slight "jump"), though it's better than before...
Bugs creator.
Features destroyer.
Template killer.

Re: Ajax mark all messages read bug

Reply #5

yep, will fix it tomorrow ..
Thorsten "TE" Eurich
------------------------

Re: Ajax mark all messages read bug

Reply #6

 Never mind, I created another branch while I stopped working on "small_things"...

 emanuele whistles innocently
Bugs creator.
Features destroyer.
Template killer.

Re: Ajax mark all messages read bug

Reply #7

Also, when hit mark as read, the loading box at top stays, until close it.
However, it does mark as read.


Re: Ajax mark all messages read bug

Reply #9

Yeah... But not here on the site. ;)

Re: Ajax mark all messages read bug

Reply #10

Ahh..okay.
Yep, the site is not updated automagically (though it may be cool 8)), it requires teh Spuds upload the files and be ready to fix what is (usually) broken. O:-)
Bugs creator.
Features destroyer.
Template killer.

Re: Ajax mark all messages read bug

Reply #11

QuoteYep, the site is not updated automagically (though it may be cool 8)), it requires teh Spuds upload the files and be ready to fix what is (usually) broken. O:-)
Should be updated here now, as of this AM  :) and yes an auto script would be cool and possible with the API