Skip to main content
Topic: dieGif? It's been broken for some time it seems. (Read 2565 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: dieGif? It's been broken for some time it seems.

Reply #15
Yes, php-fpm.

Re: dieGif? It's been broken for some time it seems.

Reply #16
Then, from index.php try removing:
Code: [Select]
	// Don't make people wait on us if we can help it.
if (function_exists('fastcgi_finish_request'))
fastcgi_finish_request();
Bugs creator.
Features destroyer.
Template killer.

Re: dieGif? It's been broken for some time it seems.

Reply #17
That fixes it.  No errors in the log and the response has gif headers.

Re: dieGif? It's been broken for some time it seems.

Reply #18
So really since you know it's going to end in dieGif don't you want to send the gif right before you call fast_cgi_finish?  Then go process the scheduled tasks and simply return w/o any further data where you previously called dieGif?

Re: dieGif? It's been broken for some time it seems.

Reply #19
Honestly I didn't notice it because I don't use fastcgi.
It was added back in 2015.

I think we have two options here:
1) drop the fastcgi call,
2) drop the dying with a gif.

The gif was added back in 2011 with this commit message:
Quote
Chrome was displaying a warning when scheduled tasks were triggered via JavaScript. (ScheduledTasks.php) [Bug 4673]
and the bug should be:
http://dev.simplemachines.org/mantis/view.php?id=4673

I feel like chrome was whining because a gif header was sent without the gif.
I'd be tempted to say: let's remove the gif header and send an empty page instead. Problem solved.
Bugs creator.
Features destroyer.
Template killer.

Re: dieGif? It's been broken for some time it seems.

Reply #20
Effectively anyone running fastcgi has been sending an empty page.  I never notice anything browser wise to tip me off that it was sending an empty page in an img tag.  I agree the send a gif seems an odd choice over an empty page.

Re: dieGif? It's been broken for some time it seems.

Reply #21
I think the 1px gif is an heritage of the old days when browsers may complain about an empty responses.
Okay, let's take a look at dropping this stuff once and for all! xD
Bugs creator.
Features destroyer.
Template killer.