Skip to main content ↑ ↓
Arrrrggggggggghhhhhh! Max-width is actual 150em? Started by Antechinus · · Read 8705 times 0 Members and 3 Guests are viewing this topic. previous topic - next topic

Arrrrggggggggghhhhhh! Max-width is actual 150em?

Ahem. Why, pray tell, is the CSS declaring max-width not set at 100%?

If someone wants a width setting in admin that is not in percent, for the very obvious and sensible reason that it sets a maximum limit to overall content width regardless of device, then the way the code is at the moment their theme will stop being responsive ...

... because ...

... you have max-width set at 150em, which means that it will not adapt to device width.

Congratulations. You have built in a non-responsive behaviour. Welcome to 1990. :P
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Arrrrggggggggghhhhhh! Max-width is actual 150em?

Reply #1 –

Ummm ... I think that was your code from 1.0 :D
 

Re: Arrrrggggggggghhhhhh! Max-width is actual 150em?

Reply #2 –

Well it's stupid code anyway. :D
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Arrrrggggggggghhhhhh! Max-width is actual 150em?

Reply #3 –

LOL ... I'll change it, actually is it needed at all, would that not be the default behavior?

Re: Arrrrggggggggghhhhhh! Max-width is actual 150em?

Reply #4 –

No, it wouldn't be. If your width setting is actual width, that is a fixed amount. If you changed the forum width setting to be max-width instead, that would handle it automatically (it would just go straight to full width on a narrower device).

But there's something to be said for having the max-width in the CSS, because it allows you set to something like max-width: 98%; if you want to keep a narrow margin on tablet/portrait or whatever, then going to 100% on a phone.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Arrrrggggggggghhhhhh! Max-width is actual 150em?

Reply #5 –

Understood ... The old comment on that 150em (which was 100em at one point back in 1.0) is
   /* Next limits maximum width on wide screens.
      Sized in em, since some people require larger text.
      For ease of reading, content really should not be too wide. */

Just posting that for some historical context.