Re: Word censor: should be thoroughly tested, yes?
Reply #16 – March 29, 2014, 06:50:54 pm
Ok. So it's now set in permissons profiles then. I can see the logic of that, but I can also see that it's more likely to lead to confusion. Although it would be silly having it as a per theme option, it seems to me that requiring it to be set for each permission profile is more trouble than it's worth. I can see that leading to hiccups with multiple membergroups, especially if some are added later. If it's (the user option) just set globally on the censor page itself, it'll be easy for admins to deal with. Realistically I can't see that finer-grained control will ever be necessary.
Re: Word censor: should be thoroughly tested, yes?
Reply #18 – March 29, 2014, 07:11:29 pm
It seems like a poor idea to make word censor enabling a permissions option. Despite agreeing with Ant's OP, there are still going to be some people who freak out over profane words. Having the word censor off by default, and removing someone's ability to enable it, is going to cause more problems than it solves. My suggestion is for the word censor to be a special permission. Everyone should have the ability to turn it on, if it isn't on globally. Disabling, however, can still be a permissions-based option. So, for example, if I join a forum with the word censor turned on globally , and I do not have permission to disable it, I see nothing and posts are censored. If I join a forum with the word censor turned on globally , and I have permission to disable it, I see an option to disable the word censor and posts can be uncensored. If I join a forum with the word censor turned off globally , I see an option to turn on the word censor and posts can be censored.
Re: Word censor: should be thoroughly tested, yes?
Reply #19 – March 29, 2014, 07:13:48 pm
emanuele
Global Moderator
mmm.... I have no idea... lol Looking at git history, it was done when code was still in SVN, then not touched that much. If the option is still present in the themes settings page of the admin panel looks like a bug. I'd say (and I'm scared by myself) I tend to agree with Ant: theme setting is silly, permission (and any kind of combination and special case) seems overkill.
Re: Word censor: should be thoroughly tested, yes?
Reply #20 – March 29, 2014, 07:18:39 pm
@ET: That would be best, yes. SMF always had the first two, but not the third. Easiest way out of it: the censoring interface page sets all of this in one place. For best performance, censoring is disabled by default on installation. If censoring is set for the whole site, admin can also choose to allow anyone (regardless of membergroup or permissions) to disable censoring in their browser. The third option would be nice in theory, but frankly admins who don't care about censoring will probably not care about providing this option either. Keeping up with who is offended by what is a PITA, and there will always be new cases. At some point the answer is probably going to be along the lines of "gently caress off, princess". ETA: Third option is also a performance hit, which is another reason admins may not bother.
Re: Word censor: should be thoroughly tested, yes?
Reply #21 – March 29, 2014, 07:30:12 pm
Come to think of it, why is the admin option allowed to override the user's choice of censoring anyway? Presumably censoring is provided for people who don't want to see profanity. There's no obvious need for an admin to decide that people who want posts uncensored shouldn't be able to have it that way, and like I said before this is actually better for performance. So, having an admin option to disallow users choosing uncensored posts makes no sense whatsoever, either from the perspective of preventing conniption fits or from the perspective of performance. It's pure bonkers. It'd make far more sense to remove that setting entirely.
Re: Word censor: should be thoroughly tested, yes?
Reply #26 – March 29, 2014, 11:24:23 pm
It's ok the way it is for 1.0, but could be improved a bit for 1.1. ETA: Oh, apart from the bug with BBC tags content. That should probably be addressed for 1.0.
Re: Word censor: should be thoroughly tested, yes?
Reply #28 – March 30, 2014, 11:27:13 pm
I believe thats how its now (with pending PR), but that is one of those messy areas. If it needs further refining (assuming I did not break anything), it can wait for 1.1