Skip to main content
Topic: [RC2] texts not in a row (Read 4902 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

[RC2] texts not in a row

Is there any reason that these texts aren't in a row? Can this be fixed?  O:-)

Re: [RC2] texts not in a row

Reply #1

Stop looking too hard at the page! :P J/K

The second looks good from my browser.
Which one are you using?
Bugs creator.
Features destroyer.
Template killer.

Re: [RC2] texts not in a row

Reply #2

Chrome Version 36.0.1985.143 m

Re: [RC2] texts not in a row

Reply #3

Looks like an old MessageIndex.template.php (pre-February).
The file should have:
Code: [Select]
					', $topic['replies'], ' ', $txt['replies'], '<br />
', $topic['views'], ' ', $txt['views'];
(that anyway is bad for localization as far as I know, it should be an sprintf, but that's something for 1.1), while you probably have instead the old:
Code: [Select]
					', $topic['replies'], ' ', $txt['replies'], '
<br />
', $topic['views'], ' ', $txt['views'];
Bugs creator.
Features destroyer.
Template killer.

Re: [RC2] texts not in a row

Reply #4

Okay, so in the final version this will be looking better. Thanks!  :)

Re: [RC2] texts not in a row

Reply #5

It was already in beta 2...
Could it be you restored an old file?
Bugs creator.
Features destroyer.
Template killer.

Re: [RC2] texts not in a row

Reply #6

No, I'm using the RC2. Copied the MessageIndex.template.php from the RC2 source package I have downloaded from your homepage (which seems to be from july 20th) to the server right now. No difference.

Re: [RC2] texts not in a row

Reply #7

I don't know what to say, I can't see it doing that thing... :-\

Maybe someone else has an idea.
Bugs creator.
Features destroyer.
Template killer.

Re: [RC2] texts not in a row

Reply #8

Oh, wait, I'll try something else. 

Re: [RC2] texts not in a row

Reply #9

No. Thought maybe "my" theme has his own MessageIndex.template.php and I didn't overwrite it. But no, it only has the images and css files, no theme php files. They come from the default theme which is from RC2.

Re: [RC2] texts not in a row

Reply #10

Dunno, really.
The code generated is the old one:
Code: [Select]
						<p class="board_stats">
69 Beiträge
<br /> 12 Themen
</p>
where the br is on a new line and not at the same level of "replies", so somewhere that old file has to be as far as I can tell.
Bugs creator.
Features destroyer.
Template killer.

Re: [RC2] texts not in a row

Reply #11

What do you think about this? It seems the second problem can be fixed if I change this code in index.css from:

Code: [Select]
.board_stats {
text-align: right;
padding: 1px 0 1px 6px;
float: right;
min-width: 8.4em;
}

...to this:

Code: [Select]
.board_stats {
text-align: left;
padding: 1px 0 1px 6px;
float: right;
min-width: 8.4em;
}

Re: [RC2] texts not in a row

Reply #12

board_stats is not applied to the info center, it shouldn't affect it in any way.
Last Edit: August 26, 2014, 08:20:21 am by emanuele
Bugs creator.
Features destroyer.
Template killer.

Re: [RC2] texts not in a row

Reply #13

Not the info center, but the board stats on the right side of the index. See line2.png in the first post please. Sorry, two problems in one thread again! :-[ ;)

Re: [RC2] texts not in a row

Reply #14

Wait a moment... oh sh**it I was looking at the wrong file. xD
Dammit. I was looking at be social in chrome and I didn't realise the two variants have a different order of the elements there.. .:-\
meh.

GenericBoards.template.php:
Code: (find) [Select]
							', comma_format($board['posts']), ' ', $board['is_redirect'] ? $txt['redirects'] : $txt['posts'], '
', $board['is_redirect'] ? '' : '<br /> ' . comma_format($board['topics']) . ' ' . $txt['board_topics'], '
Code: (replace with) [Select]
							', comma_format($board['posts']), ' ', $board['is_redirect'] ? $txt['redirects'] : $txt['posts'], $board['is_redirect'] ? '' : '<br /> ' . comma_format($board['topics']) . ' ' . $txt['board_topics'], '

Anyway Chrome is odd. >_<

Info center bug fixed here: https://github.com/emanuele45/Dialogo/commit/f6ce9ab5c2d3af1be180a7431448c0a1797c3f6d
Bugs creator.
Features destroyer.
Template killer.