ElkArte Community

Title: Alt+S
Post by: Flavio93Zena on August 29, 2015, 02:12:34 am
Just wanted to express some love for the guy who had the idea to automatically detect whether you are quick editing or quick replying, and start the action correctly.
Example:
Elk: I type a quick reply and press alt+s - it gets posted
I edit my post with quick editor and press alt+s - it edits the message correctly

SMF:I type a quick reply and press alt+s - it gets posted
I edit my post with quick editor and press alt+s - throws an error about empty message body.

Dis iz giniuz!
Title: Re: Alt+S
Post by: emanuele on August 30, 2015, 04:32:03 am
I think it's a bug I fixed in 2.1 code... or maybe it was someone else. :P
Title: Re: Alt+S
Post by: Flavio93Zena on August 30, 2015, 05:26:37 am
I got onto their GitHub and lost half an hour trying to look for the fix. If you remember something even vaguely please let me know before I start to yell at their unlabeled sh!t xD
Title: Re: Alt+S
Post by: emanuele on August 30, 2015, 05:51:34 am
The only thing I remember (well, it's more logic than remember) is that when the quick-edit is started the code must remove the shortcut from the "post" button of the quick-reply and attach it to the other button and when is saved it must add it back.
Title: Re: Alt+S
Post by: Flavio93Zena on August 30, 2015, 06:40:10 am
I could get there on my own XD But code-wise it's another thing :P
Title: Re: Alt+S
Post by: live627 on August 30, 2015, 10:45:10 am
i iz steal dat idea :D
Title: Re: Alt+S
Post by: Flavio93Zena on August 30, 2015, 11:19:32 am
Wait, wasn't it already fixed for smf 2.1?
Title: Re: Alt+S
Post by: live627 on August 30, 2015, 05:43:36 pm
Yay for more bugs.
Title: Re: Alt+S
Post by: Flavio93Zena on August 30, 2015, 10:54:22 pm
Uuh I probably misunderstood ema.... When he said "It's a bug I fixed in 2.1" I got that he fixed it in 2.1 repo, but I start to think he was referring to it being fixed in Elkarte, and bugged in 2.1.