ElkArte Community

Elk Development => Theme development => Theme development archive => Topic started by: Antechinus on March 05, 2014, 04:36:46 am

Title: Sorting options stuff
Post by: Antechinus on March 05, 2014, 04:36:46 am
Not sure about the way the sorting options are handled at the moment. It's all a bit opaque and fiddly IMO. The asc/desc icon has nothing to indicate what it does, and is so umm, let's say "unpretentious", that it's likely to be overlooked. At the least, I think it should have a title attribute added.

Also, the language strings are a bit suss. "Sort by: Last post by" is not exactly brilliant use of English. "Sort by: last post author" would be far better. The same point applies to "Sort by: Started by".

If language strings are going to be changed to use reasonable grammar, it would make sense to update the old ones we inherited from SMF too. "Sort by: Last post" is ok, but "Sort by: last post time" would make it clearer.
Title: Re: Sorting options stuff
Post by: Spuds on March 05, 2014, 05:36:37 pm
I had not even notice the language when you combine the to ... kind of funny, but indeed those should be fixed.   Adding the title attribute to the sort icon should be easy, I'm surprised its not there.

It does seem like the sort selection area is a bit hidden, not obvious that you can sort or that there is a control up there, almost needs a background or a selection box arrow to show its a form control.
Title: Re: Sorting options stuff
Post by: Antechinus on March 05, 2014, 08:34:34 pm
Yup. It'll probably be fairly obvious to anyone who is already familiar with using SMF, but others may miss it entirely.
Title: Re: Sorting options stuff
Post by: Spuds on March 10, 2014, 05:04:42 pm
Maybe like a tab?
Title: Re: Sorting options stuff
Post by: emanuele on March 10, 2014, 07:16:30 pm
Sexy! :D

Would that work for the unread/unreadreplies too?
Title: Re: Sorting options stuff
Post by: Spuds on March 10, 2014, 08:34:20 pm
It works but those screens do need a margin adjustment to keep things lined up since the layout is different
Title: Re: Sorting options stuff
Post by: Antechinus on March 10, 2014, 09:25:26 pm
Since the message index and unread/replies page content is largely the same, it may make sense to change the layout so it matches. That should reduce the total amount of code required.
Title: Re: Sorting options stuff
Post by: emanuele on March 10, 2014, 10:11:31 pm
Yup, I started "merging" some pieces of template, but there is still a lot more to do. I stopped because doing more now may be tricky in terms of testing...
Title: Re: Sorting options stuff
Post by: Antechinus on March 10, 2014, 10:20:47 pm
But what about your sig? Surely you shouldn't let something as trivial as testing stop you.
Title: Re: Sorting options stuff
Post by: emanuele on March 10, 2014, 11:58:35 pm
Yeah, that's true, but Spuds is another story... :P