ElkArte Community

Project Support => General ElkArte discussions => Topic started by: TestMonkey on January 21, 2013, 10:11:05 pm

Title: IRC
Post by: TestMonkey on January 21, 2013, 10:11:05 pm
We have created and established the development channel on #elkarte, on freenode. Don't be shy, if you're interested, go ahead and join.

I'll add a few logs here, for everyone to keep easier tabs on things, to understand where we're heading, and be able to step up on your preferred functionality or area of your interest.
Title: Re: IRC
Post by: TestMonkey on January 21, 2013, 11:08:06 pm
(01:51:56 AM) Norv: do you have time to review Joker's mod?
(01:55:33 AM) emanuele: if me, not this weekend
(01:56:27 AM) Spuds: https://github.com/Spuds/Elkarte/tree/Validator ... this is a bit rough, and after I started not sure it works with Elkarte, but not sure it does not either :P ..... take a look when you have time
(01:56:59 AM) Spuds: We shoudl suggest to Joker that he do it as a core feature to replace the Karma core feature (for elkarte of course)

(01:58:51 AM) emanuele: I think Lab had a not bad idea: loadCSSfile and LoadJSfile could create the same ID (or at least a problematic one) if a mod would put its css/hs in a subdirectory
(02:08:59 AM) Spuds: you mean ID as in an xhmtl validaition thing
(02:09:37 AM) emanuele: I think so
(02:14:43 AM) Spuds: Its pretty easy to generate duplicate ID's TBH (with those functions) ...
(02:15:16 AM) Spuds: I'm not sure they are even required

(02:16:31 AM) Norv: ffs directory structure... *me is confuzzled and should have made those first*

(02:16:53 AM) emanuele: Another thing I was noting:
(02:16:55 AM) emanuele: https://github.com/emanuele45/Dialogo/blob/master/Sources/Post.php#L508
(02:16:56 AM) emanuele: https://github.com/emanuele45/Dialogo/blob/master/Sources/Post.php#L741
(02:17:11 AM) emanuele: the two queries and following lines are pretty similar...
(02:18:05 AM) emanuele: I was thinking to excide them and create a function, where should be put? A new Subs-Messages.php?
(02:19:04 AM) Norv: without looking at the code: yep
(02:19:26 AM) Norv: imho don't be shy on refactorings like this
(02:20:58 AM) emanuele: okay for the refactoring too
(02:21:27 AM) emanuele left the room (quit: Remote host closed the connection).
(02:21:48 AM) ***Norv has looked at the code too... but anyway :D
(02:22:09 AM) Norv: oh it must have been 1:00 am for Ema

(05:01:03 PM) emanuele: my biggest problem with refactoring is that I start from a point, then I find something else that should be re-organized and I start working on that second part...and that usually ends up in a loop...
(05:06:08 PM) Norv: it happens :) I got that with...err, something with boards, it ended up on disregard :D
(05:06:48 PM) ***Norv is restarting to be disciplined and gets ready the directory structure instead
(05:10:26 PM) emanuele: you want to change it again? O_O
(05:10:58 PM) emanuele: disregarding => reminds me something doesn't work...
(05:17:41 PM) Norv: I didn't change it yet in line with the topic I opened :)
(05:18:43 PM) Norv: we had decided to stick with option 6, something with *.subs and *.controller and *.class
(05:20:27 PM) emanuele: AHH...
(05:20:29 PM) emanuele: okay

(11:28:38 PM) Norv: https://github.com/elkarte/Elkarte/pull/81
(11:28:54 PM) emanuele: :'(
(11:28:59 PM) ***emanuele runs
(11:30:10 PM) Norv: don't run, merge! :D
(11:31:06 PM) Norv: err *review :D
(11:34:11 PM) Norv: though it isn't entirely finished...

(11:34:48 PM) Norv: question: if I introduce a loadLibrary() for /subs files, and a loadController() for /controllers, would it be fine?
(11:35:36 PM) emanuele: think so
(11:36:38 PM) Norv: the hardcoded subdirectories are kinda ugly
(11:51:44 PM) Norv: or $librarydir and $controllerdir
(11:52:37 PM) emanuele: go for the load, less to type... :P
(11:54:31 PM) Norv: it's an extra function call though
(11:54:49 PM) Norv: and this time for a lot of files

(12:27:57 AM) emanuele: OMG did you merge it already? ... tomorrow will be a sad day...
(12:28:29 AM) Norv: it was a decent merge with spuds' utf8only, though, ema
(12:28:54 AM) Norv: because it's really only moves around, and git recognizes the same file
(12:29:10 AM) Norv: well except for the former (rest in peace) Class-Package
(12:29:43 AM) emanuele: I hope so...probably mine was more destructive for the error_class branch (but that's just one file
(12:31:06 AM) emanuele: and the banEdit...I forgot (again) about it... :'(
(12:31:21 AM) Norv: ohyes I wanted to ask you about that...
Title: Re: IRC
Post by: TestMonkey on January 21, 2013, 11:10:40 pm
(12:34:07 AM) Trekkie101: Will elk support an SMF upgrade/convert?
(12:35:15 AM) Norv: Trekkie101: of course. Upgrade from SMF any version, including 1.0. And yabbse, though dunno if I will test that one.
(12:35:57 AM) Norv: Dis is one of my pets, I fixed the upgrade to still work, and want to keep it that way :)
(12:36:19 AM) ***Norv is afraid to test upgrade right now...
(12:36:19 AM) Trekkie101: :)

(12:36:33 AM) emanuele: Norv do you remember if I ported the upgrade fix for Themes outside of $boarddir?
(12:36:46 AM) Norv: nope...
(12:36:50 AM) emanuele: I feel I didn't...
(12:37:49 AM) emanuele: (incidentally) probably we will need to actually "fix" the issue with leftover files from the "upgrade"...

(12:37:00 AM) Trekkie101: Next question, and it's somewhat loaded, during refactoring, I don't suppose you ripped out the bbcode parser and made it a library ;)?
(12:38:48 AM) Norv: Spuds has worked on a bbcode parser, forked from an FOSS library, to integrate and adapt, for SMF 2.1. It was in one of his branches, when the corporation stuff blew up. We wou;d like to review it and try to add it but he's not sure if for 1.0. It seems that for the moment, it's too OOP, creates too many objects and works too slow. (performance tests made by Spuds were like 50% slower or something)

(12:54:03 AM) Norv: I think some people around SM are for some reason biased against mailing lists. But mailing lists predate them and tbh, they will last. They're just damn handy.
(01:18:12 AM) Norv: FYI, in case youre interested, a view on forum vs mailing lists: http://projects.opensource.org/pipermail/license-discuss/2013-January/000794.html

(01:16:52 AM) Trekkie101: Sticking with elkarte as the name?
(01:17:32 AM) emanuele: ìI'm sure Spuds want to cahnge it (again)! :P
(01:17:34 AM) emanuele: LOL
(01:18:19 AM) Trekkie101: JUST A FECKING FORUM  JAFF
(01:18:33 AM) Norv: LOL I love that! :D
(01:20:38 AM) Trekkie101: Oddly available

(09:43:36 PM) Spuds: What defines what files go in /lib ..... QbQ, why does badbehavior not go there?
(10:02:02 PM) emanuele: no idea, wasting time discussing evolution... :(
(10:02:04 PM) Norv: Ah. I believe it should go there.
(10:02:17 PM) Norv: I didn't do it yet, thats all
(10:05:45 PM) Spuds: OK ... just wanted to make sure I was not missing something wrt what goes as a lib ... working on porting over my PBE mod and its got its fair share of lib helpers ....
(10:06:24 PM) Norv: Oh thats so great to hear!
(10:06:47 PM) Norv: not sure if you noticed, I mentioned that on the comments on 1.0
(10:08:40 PM) Norv: It was because a convo we had yesterday here, reminded me of email-forum integration. FYI, here is an interesting (imho) view of mailing lists heavy users, on forums: http://projects.opensource.org/pipermail/license-discuss/2013-January/000794.html
(10:13:53 PM) Spuds: Yes ... well I'll get a branch with whats involved up so we can all take a look.  Email formats and dealing with them seem to carry every sin ever concieved by the web so there are some complexities involved, and more compromises than normal ... but it does work.
Title: Re: IRC
Post by: TestMonkey on January 21, 2013, 11:22:09 pm
(10:13:08 PM) Norv: Can anyone pretty please make a quick review on https://github.com/elkarte/Elkarte/pull/82 ?
(10:13:40 PM) Norv: I fixed a few issues for the former... (oops) and even though it's wip, it kinda sorta should also be in
(10:13:58 PM) ***Norv breaks them rulez.
(10:15:56 PM) emanuele: do we have rules? ?_?
(10:16:02 PM) Norv: lol
(10:16:15 PM) Norv: Nope. They're merely... guidelines!
(10:16:41 PM) emanuele: I thought the only rule was: break as much as possible and don't get caught with your hands dirty
(10:17:02 PM) Norv: [/captain Jack Sparrow]
(10:17:14 PM) Spuds: Did you see how dirty Ema's hands are?
(10:17:25 PM) emanuele: Norv is winning this round
(10:18:43 PM) Norv: True dat. The round is all mine. https://github.com/elkarte/Elkarte/commit/308dacfd94bd24a531abf142ae2cce097272fb5b#commitcomment-2466615

10:16:35 PM) Spuds: Speaking of rules ....
(10:16:35 PM) Spuds: class browser_detector
(10:16:35 PM) Spuds: class site_Combiner
(10:16:35 PM) Spuds: class standard_search
(10:16:35 PM) Spuds: class curl_fetch_web_data
(10:16:36 PM) Spuds: class custom_search
(10:16:36 PM) Spuds: class fulltext_search
(10:16:36 PM) Spuds: class sphinxql_search
(10:16:36 PM) Spuds: class sphinx_search
(10:16:37 PM) Spuds: class site_Dispatcher
(10:16:37 PM) Spuds: class xmlArray
(10:16:38 PM) Spuds: class ftp_connection
(10:16:38 PM) Spuds: what are the class naming rules and should the filename reflect the classname?
(10:19:19 PM) Norv: How does Camel_Underlined_Cases sound?
(10:20:09 PM) emanuele: less error-prone than plain_with_underscores
(10:20:43 PM) emanuele: (at least here where the underscore requires the shift)
(10:21:15 PM) Norv: The filename should contain both the classname and the 'class' or 'controller' or whatnot suffix
(10:21:42 PM) Norv: I'll make a pass through all of them now?
(10:21:42 PM) Spuds: Works for me .... (funny how we pick the one that was not used yet)
(10:22:01 PM) Norv: lol
(10:22:02 PM) Spuds: Sounds good, do it while yer hands are dirty
(10:22:02 PM) emanuele: LOL

(10:28:52 PM) emanuele: hey, when we will rename $smcFunc? :P
(10:29:04 PM) emanuele: $elkFunc? :P
(10:29:24 PM) Spuds: $funkyElk

(10:30:30 PM) Spuds: Holy crap on #82 ... yeah it look fine :P .... thats a merge and see whats broke commit !
(10:31:03 PM) emanuele: that's the best way to review this kind of "things" :P
(10:31:24 PM) Spuds: you did miss a require in the loadBadBehavior() function in security
(10:31:30 PM) Spuds: LOL ... yup
(10:31:37 PM) emanuele: http://www.geardownload.com/developers/funky-elk-games.html
(10:31:47 PM) emanuele: lol
(10:32:12 PM) Norv: lol, heh, only one miss? Kinda doubt it...
(11:14:35 PM) emanuele: it's time to do a pull I suppose...
Title: Re: IRC
Post by: TestMonkey on January 21, 2013, 11:26:44 pm
(11:47:39 PM) Spuds: How "improper" is it to use globals like $modSettings or $context in a class?
(11:47:59 PM) emanuele: tagging! :D
(11:52:17 PM) Spuds: I bet that made Norv passout
(11:54:39 PM) Norv: It's okay, IMO: we cannot avoid those, really, and IMHO it's a better use of our time to avoid others, not those.
(11:57:32 PM) Norv: "Those" = the very widely used globals in Elk: $modSettings, $sourcedir, $librarydir (*angel eyes*), $settings. As for $context, my care would be on where it's used: if it's possible, we should avoid using it in *.subs files, and/or in the same function with a query. They're just from very different levels of the architecture, $context for views (templating, pages), while queries are on the contrary, from the low-level "side".
(01/21/2013 12:00:20 AM) Norv: But $modSettings, $sourcedir, ah, $smcFunc too of course, are just impossible to avoid most of the time, and that's okay imo. At some point we will probably take each of them and design it differently (i.e. a class for $modSettings) and then we'll see how we use that class. (maybe global, maybe singleton, maybe grabbed from a container)
(12:02:00 AM) Norv: What I keep mumbling about, on $context, is of course not true for Ema's prepareContextXxx() stuff.
(12:03:01 AM) emanuele: lol
(12:03:06 AM) ***emanuele is always the exception :P
(12:03:26 AM) Spuds: Thanks ... I don't feel so bad now :D ....
(12:03:26 AM) Spuds:  I'll try and avoid $context, thats generally easier, but modsettings, smcfunc, txt, etc will its almost worse trying to avoid pulling those in with the way things are at the moment ...
(12:03:26 AM) Spuds: Ah yes, once those are in a class its a different story ... that will be nice
(12:03:29 AM) Norv: One thing that crossed my mind: I know we sometimes use $context to pass variables from a function that does some work to another function that does some work, and then, it's not used anymore (not sent to template). Those should be avoided imo: they're better off as parameters for the next function.
(12:03:31 AM) emanuele: even though I wrote two of them and they have two different behaviours... lol
(12:07:38 AM) Spuds: Really what prompted the question was the PBE stuff I have is part class helpers and part procederal stuff ... but some combining could be done, so I was looking at doing that.  You know its working fine now so I have to change it just to keep up with you two
(12:32:25 AM) ***Norv has messed up the profile completely, that will hopefully not interfere

(01:04:11 AM) Trekkie101: To bump in: Tagging in posts. BLOODY BRILLIANT
(01:05:10 AM) Norv: Yah gotta do that. *is busy breaking profile apart*

(03:03:09 AM) Norv: Spuds: I merged another small bit
(03:03:24 AM) Norv: I hope this time I am fixing thingz not breaking them, heh.
(03:43:49 AM) Spuds: LOL .... you can't move stuff around like this and not break a few things along the way ... don't worry, I'm noting going to push it to the Elkarte site right away :D
(06:07:39 AM) Spuds: FYI ... in upgrade-1.0.sql ('smileys_dir', '{$sboarddir}/smileys'),  shoudl be $boarddir
Title: Re: IRC
Post by: TestMonkey on January 21, 2013, 11:26:55 pm
08:32:34 PM) Norv: May I? https://github.com/elkarte/Elkarte/pull/86

(08:37:10 PM) Norv: emanuele, do we still want a portal integrated in elk?
(08:38:19 PM) Norv: If yes, we could do it. I can use blocks on the site, I'd like to pull github commits in one of them. Just a thought, the github api is easy to use
(08:39:34 PM) emanuele: I'm a bit lost, sorry: do you mean allow easy creation of portals for elk, or ship the thing with a portal already there?
(08:39:41 PM) emanuele: or something else completely?
(08:40:16 PM) Norv: I believe someone (Ant and Eliana for sure, Spuds maybe?) planned to integrate SP
(08:41:00 PM) emanuele: so ship the whole thing...
(08:41:04 PM) Norv: Indeed my take would be for the code to be separated (at the level of code design). Shipping or not shipping would be then just a matter of packaging
(08:41:45 PM) emanuele: okay, let's say have already a portal working for it then
(08:41:56 PM) emanuele: that would make sense
(08:42:38 PM) Norv: lets see what it would mean... I dont remember if SP was open licensed in the end... *goes search*
(08:42:51 PM) emanuele: not that I can see
(08:42:57 PM) emanuele: still the old SMF 1.1
(08:43:14 PM) emanuele: (and that's one of the reasons I didn't clone the repo :P)
Title: Re: IRC
Post by: TestMonkey on January 22, 2013, 03:28:09 am
(01/22/2013 12:16:35 AM) Norv: emanuele should I try to rebase your PRs (for the conflicts) ?
(12:17:16 AM) emanuele: no problem I'll do it tomorrow
(12:32:37 AM) ***Norv feels slightly guilty :)
(12:32:58 AM) emanuele: lol

(02:41:22 AM) Spuds: just made a quick pr to fix a couple of things I saw on the live site ...
(02:54:30 AM) Norv: thanks!

(03:32:01 AM) Norv: One more little round. I think I found a few missed calls too with the occasion
(03:32:27 AM) Norv: (missed from earlier ->action_xxx() refactoring)
(03:46:40 AM) Spuds: Ah ... well I'm sure there are a few more to be uncovered ... saw your PR, looks good to me
(03:52:39 AM) Norv: I merged it then, thanks
(03:53:26 AM) Norv: you never know what ugly silly bugsy you may uncover, if we review PRs
Title: Re: IRC
Post by: Trekkie101 on January 22, 2013, 06:40:33 pm
You enjoy IRC far too much!
Title: Re: IRC
Post by: TestMonkey on January 23, 2013, 12:41:52 am
8)

(08:01:53 PM) ***Norv asks for clearance on https://github.com/elkarte/Elkarte/pull/97 at least, to see it done.
(08:05:50 PM) Spuds: I know for certain that it will not break my windows installl
(08:15:40 PM) Norv: yep, it 'breaks' ours (emanuele is on a Linux too afaik)
(08:17:06 PM) Spuds: loosers :P
(08:18:17 PM) Spuds: I have no problems with the merge in ... but like dialogo => elkarte you can't change your mind or I will loose mine :D
(09:11:53 PM) ***emanuele feels something will break...again... :'(
(09:26:22 PM) Spuds: again ? :P
(09:31:55 PM) Norv: it does, of course it does break... I forgot again a hack I did in my files... normally upgrade should have updated the theme paths, and I forgot that

(09:32:35 PM) emanuele: I'm applying right now the upgrade fix for themes outside $boarddir
(11:24:23 PM) emanuele: Playing a bit with ?action=unread;all and splitting the query into 3 I went from a 2.6 seconds to 1.5 to generate the page...not much, but not bad I think (though it's a quite borderline case)

(12:22:48 AM) emanuele: ARGG!!!
(12:25:55 AM) emanuele: oook...merged this darn themes and upgrade issue, now back to admin_search...
(12:27:07 AM) emanuele: okay, now it should merge...

(12:55:24 AM) emanuele: Is there any other complete overhaul planned for the next weeks? :P
(01:04:04 AM) emanuele: fixed sm_to_elk too
(01:21:16 AM) Spuds: hummm complete overhaul you say ... smcFunc => class structure (/me runs)
(01:22:23 AM) emanuele: next century I hope...
(01:22:27 AM) emanuele: :P
Title: Re: IRC
Post by: TestMonkey on January 23, 2013, 02:58:24 pm
(02:38:03 AM) TimeVortex: I noticed you've been busy! :D
(02:38:39 AM) Norv: I broke everything... '(
(02:40:02 AM) Norv: have you seen how them looks of the source changed? :D
(02:40:14 AM) TimeVortex: Briefly!
(02:40:24 AM) TimeVortex: I like how things are getting more and more MVC'ish
(02:40:33 AM) ***Norv is very happy about it, even so rough (=on the surface) as it currently is

(02:40:45 AM) TimeVortex: The poll query changes caught my eye earlier.
(02:41:15 AM) Norv: That wasnt very useful I guess (since afaics it's only used there) but it made sense imho.
(02:41:28 AM) TimeVortex: Definitely.
(02:41:33 AM) TimeVortex: It's a leap in the right direction anyway.
(02:41:39 AM) Norv: Aesthetics of code design, heh. :)
(02:41:48 AM) TimeVortex: Will make it much easier to possibly adapt it into OOP in the future
(02:42:35 AM) Norv: I just restarted for the... nth time, a refactoring to OOP controllers for the admin area. Once I get it right, I hope it will show in which direction we're moving.
(02:43:03 AM) Norv: Yep that's the point, and has always been
(02:44:11 AM) TimeVortex: Indeed. It has been ever since Compuart coined the idea at CodeFest in Arizona, heh.
(02:44:52 AM) TimeVortex: Although you lot have plans of your own, of course.
(02:44:56 AM) Norv: I'm sorry, Aaron. Yes, I know. And I couldn't make it under that name.
(02:45:24 AM) TimeVortex: Oh, don't be, really.
(02:45:40 AM) TimeVortex: I may be a core dev of old, but I hold no grudge against anyone, really.
(02:46:14 AM) Norv: I know, don't worry.
(02:46:30 AM) TimeVortex: Good, good, so stop apologising! ;)
(02:46:37 AM) Norv: And I *think* I didn't break your charsets any longer.
(02:47:10 AM) TimeVortex: dun dun dunnn
Title: Re: IRC
Post by: TestMonkey on January 23, 2013, 02:58:47 pm
(02:47:21 AM) TimeVortex: I take it you lot will go full UTF-8, though?
(02:47:31 AM) Norv: Yes, we try
(02:47:39 AM) Norv: Any idea what we miss so far?
(02:48:09 AM) TimeVortex: Hmm, I haven't had a very thorough look to be honest. One thing I do miss (at least as a guest) is time stamps on posts!

(02:48:27 AM) TimeVortex: But that might be the case in 2.1 as well -- I haven't been in the loop.
(02:48:35 AM) TimeVortex: (By choice)
(02:49:49 AM) Norv: I think this was an experiment of Ant's ? I seem to remember having been surprised too, Spuds should know
(02:53:10 AM) TimeVortex: It might well be. Looks really clean, I'll give him that.
(02:53:27 AM) TimeVortex: I miss it greatly though.
(02:53:46 AM) TimeVortex: If it were entirely up to me, I'd drop the message subjects in favour of the time stamp, I think.
(02:54:11 AM) Norv: I think we've tried that too... but it's so strange not to see the subject :(
02:54:37 AM) Norv: you don't know where you are, down the page, and what you were looking at... dunno
(02:55:40 AM) Norv: you're welcome to PR an option, though! :D
(02:59:14 AM) TimeVortex: Heh, I'm just used to seeing both, I guess. Once upon a time I presented it to my users like this: http://izumo.aaronweb.net/baibai.png
Title: Re: IRC
Post by: TestMonkey on January 23, 2013, 03:03:04 pm
(03:21:42 AM) TimeVortex: Norv: looks like there are still timestamps when hovering a subject! Not the best solution, but at least it's something. :)
(03:22:02 AM) TimeVortex: trekkie101: no particular reason, really. I always have an IRC client open anyway, so I thought I'd drop by.
(03:22:33 AM) trekkie101: I like it when you drop by!
(03:23:07 AM) Norv: Liez. He wanted to grumble to make me touch theme stuff. Didn't work...
(03:24:57 AM) ***trekkie101 grumbles at Norv too, make a mobile theme cat lover :p or something to make my iPhone read it all better :(
(03:25:58 AM) ***Norv points at https://github.com/IchBin/Elkarte/tree/mobile
(03:26:23 AM) trekkie101: Ooooooh
(03:26:40 AM) trekkie101: Ich bin is on board too?
(03:26:44 AM) Norv: Of course
(03:26:47 AM) trekkie101: I'm excited-er
(03:26:49 AM) TimeVortex: Ich bin on board

(03:38:26 AM) trekkie101: Lol!! I found a new bug in the CSS I think
(03:38:47 AM) trekkie101: On mobile safari the child board text is bigger than all else on the page
(03:40:06 AM) Spuds: Yeah I've seen some strange text sizes on mobile ... going to clean that up at some point, but ultimetly we need IchBin to finish his mobile theme
(03:41:51 AM) trekkie101: I managed! :D and It's exciting to see ichb continue!!

(03:27:04 AM) trekkie101: Also we don't need a wiki?
(03:27:45 AM) Norv: trekkie101: pretty please, if you wish: https://github.com/elkarte/Elkarte/wiki I started it but it needs love!
(03:28:33 AM) trekkie101: On git :p is that not like odd or awkward to access?
(03:28:35 AM) Norv: https://github.com/elkarte/Elkarte/wiki/_pages
(03:28:53 AM) Norv: You can edit from the web interface as well
(03:29:22 AM) trekkie101: Web interface too you say? I may be sold
Title: Re: IRC
Post by: TestMonkey on January 23, 2013, 03:15:22 pm
(05:17:40 AM) Norv: umm... where did the credits page go
(05:47:55 AM) Spuds: ARGH ... such a waste of time when a page gets cached !!!!!
(05:49:24 AM) Spuds: don't know where the credits are ... looks like we may have moved some things around ;)
Title: Re: IRC
Post by: TestMonkey on January 23, 2013, 06:40:21 pm
(05:22:29 PM) emanuele: https://github.com/emanuele45/Dialogo/commit/3be28976ef5b3e7599f977c4aaac17c38a5583de
(05:22:36 PM) emanuele: That's what I was talking about yesterday related to unread and unreadreplies
(05:23:08 PM) emanuele: still experimental (I don't even know if it works... :P )
(05:32:10 PM) Norv: thanks Ema, fyi though I don't have time to check it out
(05:33:54 PM) emanuele: no problem, the code is there, I'll try to move things around a bit anyway
(05:33:56 PM) Norv: and dunno what the mean Spuds does lately (other than accuse me of dirty hands, well rightfully we have to admit but hey)

(05:37:14 PM) ***Norv stares at the upgrade code. I *know* I changed things, but I'm blind or my changes aren't here.......
(05:37:50 PM) ***emanuele is innocent...
(05:37:54 PM) emanuele: well...I hope so
(05:37:57 PM) emanuele: O:-)
Title: Re: IRC
Post by: TestMonkey on January 24, 2013, 08:06:58 pm
(12:54:02 AM) Spuds: Thoughts on PM attachments?
(12:58:32 AM) emanuele: I would give some strict control in terms of quotas etc.
(01:00:42 AM) Norv: Privacy issues. You can't have admins manage them, then again you can't not have them, so boo.
(01:00:53 AM) emanuele: I've to say I like Wedge's idea of the "gallery" (that in the end could simply some kind of list of files uploaded by a certain user), that avoids any kind of "privacy" concern and allows for better re-usability of things uploaded
(01:01:32 AM) emanuele: attachments have always been quite limited
(01:02:10 AM) Norv: some sort of upload/download system
(01:04:11 AM) emanuele: >  that avoids any kind of "privacy" concern <= because people *should* better understand the files are not "attached and visible only where attached", but are available and can be shared
(01:04:34 AM) Norv: I'm not sure what kind of permissions would be available ... such as per user? So you can share a file with a particular user
(01:04:34 AM) emanuele: (of course there is already the list of attached files)
(01:04:56 AM) Norv: yep it would
(01:05:03 AM) emanuele: yeah, that's the main problem... :(
(01:06:22 AM) Norv: per buddies would be obvious... but per membergroup is a little less obvious (since not everyone can see any membergroup but when you're in one of those you dont see and something has been shared with you, you probably will be able to realize with whom you're in)
(01:06:56 AM) Norv: anyway as a general idea I'd move out, if we can, of the idea of rigid membergroups...
(01:07:22 AM) Norv: I'd adventure to say: user-defined lists.
(01:08:49 AM) Norv: not buddies only (a single customization of their contacts available to the user), not membergroups (rigid groups defined by the admin and set in stone for everyone)
(01:14:06 AM) Spuds: Even just a simple attachment reuse otpion .. so when you are posting and want to attach something you can select from a file on your computer or from one of your own existing attachments ... that way they are still yours ... past that either  a simple private / public flag for who can attach them in other posts ... or  membergroup based attachment authority
(01:17:21 AM) Spuds: On the PM thing ... does anyone know what the other systems allow?  Not sure concern over the privacy is valid, not sure its not ... can't control how a forum is used to begin with .... Quotas are good, as are stricter filesize limits and maybe even expiration dates
(01:18:49 AM) Norv: I can't say I remember, I do think some have and some don't. Vague memory, though.
(01:20:15 AM) Norv: The problem is that the user will assume they're as private as PMs. (which are as they are). And that won't be true.
(01:23:04 AM) Spuds: You mean due to the way the attachment system currently works?
(01:24:19 AM) Norv: They will be visible in maintenance pages and all that. PMs are not, so well, you have a difference there which, imo, the user won't realize it exists
(01:24:29 AM) Norv: even admins.
(01:24:56 AM) Norv: It's way easier to check out your attachments than to decide to read someone's PMs from your database. IMHO.
(01:28:18 AM) emanuele: Spuds>   On the PM thing ... does anyone know what the other systems allow?
(01:28:32 AM) Spuds: But if you looks at Ema's neked pictures you may go blind :P
(01:28:34 AM) emanuele: just tried phpbb and it doesn't seem to have
(01:29:21 AM) emanuele: though I can't be sure
(01:29:28 AM) emanuele: maybe I missed some setting
(01:30:03 AM) emanuele: oh, yes I found it
(01:33:02 AM) Spuds: So they do allow it ?
(01:35:40 AM) Spuds: Seesm sometime in the 3.0 branch it started for them
(01:41:09 AM) Norv: If you have a list with your files... And you can add to it. Directly to a particular profile page for 'your files', or through a post attachment, or through a PM attachment. Will you realize they're all easily accessible to admins? I'm not sure about those you add as 'not visible yet to anyone' and 'attachment to a PM'.
(01:44:03 AM) emanuele: phpbb has pm attachments (enabled separately) and nobody can see the attachments except the poster and the PM receiver (AFAICS)
(01:45:25 AM) emanuele: I have a mixed feeling about it
(01:46:20 AM) emanuele: in the sense I don't care much about one way or the other
(01:46:40 AM) Norv: I think it might work if we can change the perspective about it... Such as by this 'mini-upload/download system' personalized but not entirely 'private'.
Title: Re: IRC
Post by: TestMonkey on January 24, 2013, 08:09:50 pm
(01:47:17 AM) emanuele: Spuds>   But if you looks at Ema's neked pictures you may go blind :P
(01:47:36 AM) emanuele: That's why I don't have any recent picture! :P
(01:48:24 AM) Norv: Heh. You send them through phpbb only, huh?
(01:49:04 AM) emanuele: I checked that because I still have my old site here... :P
(01:50:13 AM) ***Norv tries to change my own perspective about it, but I'm not convinced...
(01:51:38 AM) emanuele: So you Norv don't like "private" attachments?
(01:52:54 AM) emanuele: And Spuds?
(01:55:31 AM) ***Norv is not sure. It's like the IPs issue... of which I didn't tell you about. I wonder if we can/want to add an option for a 'private' login, for which no IPs are logged for the user. Similarly, perhaps we can exclude from maintainance screens some attachments.
(01:57:09 AM) Spuds: Just seems like something that I see asked for often enough ... we could also add some basic file crypt to pm attachments ... makes the admin open the db, get the key, etc etc if we wanted it more ummm agrivating to get at the file
(01:57:48 AM) Spuds: or even aggravating :D
(01:58:48 AM) Spuds: No IP logging .. now that is crazy talk
(02:06:28 AM) emanuele: time to go, bye!
(02:06:31 AM) Norv: Every now and then, I saw (very rarely) a request for disabling any IP logging, at least for members. The point being particular needs of private forums, whose admins wanted to assure their members they have privacy to the level of no IP tracking.
(02:06:46 AM) Norv: nighty
(02:10:28 AM) emanuele: I think you just need to change a couple of lines for that, should be a pretty simple mod
(02:10:38 AM) emanuele: I think SpiderCheck is in the wrong file...
(02:10:56 AM) emanuele: (or addon)
(02:11:43 AM) emanuele left the room (quit: Remote host closed the connection).
(02:15:51 AM) Norv: for members-only, you mean?
(02:47:56 AM) Norv: Bah. SpiderCheck() is out. :D
Title: Re: IRC
Post by: TestMonkey on January 24, 2013, 08:11:53 pm
(01:47:17 AM) emanuele: Spuds>   But if you looks at Ema's neked pictures you may go blind :P
(01:47:36 AM) emanuele: That's why I don't have any recent picture! :P
(01:48:24 AM) Norv: Heh. You send them through phpbb only, huh?
(01:49:04 AM) emanuele: I checked that because I still have my old site here... :P
(01:50:13 AM) ***Norv tries to change my own perspective about it, but I'm not convinced...
(01:51:38 AM) emanuele: So you Norv don't like "private" attachments?
(01:52:54 AM) emanuele: And Spuds?
(01:55:31 AM) ***Norv is not sure. It's like the IPs issue... of which I didn't tell you about. I wonder if we can/want to add an option for a 'private' login, for which no IPs are logged for the user. Similarly, perhaps we can exclude from maintainance screens some attachments.
(01:57:09 AM) Spuds: Just seems like something that I see asked for often enough ... we could also add some basic file crypt to pm attachments ... makes the admin open the db, get the key, etc etc if we wanted it more ummm agrivating to get at the file
(01:57:48 AM) Spuds: or even aggravating :D
(01:58:48 AM) Spuds: No IP logging .. now that is crazy talk
(02:06:28 AM) emanuele: time to go, bye!
(02:06:31 AM) Norv: Every now and then, I saw (very rarely) a request for disabling any IP logging, at least for members. The point being particular needs of private forums, whose admins wanted to assure their members they have privacy to the level of no IP tracking. I'm not joking. Even though this isn't the problem of the server software, it's up to the client to make that choice, but.
(02:06:46 AM) Norv: nighty
(02:10:28 AM) emanuele: I think you just need to change a couple of lines for that, should be a pretty simple mod
(02:10:38 AM) emanuele: I think SpiderCheck is in the wrong file...
(02:10:56 AM) emanuele: (or addon)
(02:11:43 AM) emanuele left the room (quit: Remote host closed the connection).
(02:15:51 AM) Norv: for members-only, you mean?
(02:47:56 AM) Norv: Bah. SpiderCheck() is out. :D
Title: Re: IRC
Post by: TestMonkey on January 24, 2013, 11:35:06 pm
(12:16:28 AM) emanuele: I meant that to me the functions SpiderCheck looks strange in ManageSearchEngines
(12:17:10 AM) emanuele: oh...it's written in the function documentation... lol
(12:17:18 AM) Norv: https://github.com/elkarte/Elkarte/pull/105
(12:17:42 AM) emanuele: ohhh
(12:18:08 AM) emanuele: cool
(12:18:36 AM) Norv: At your orders! :D
(12:18:53 AM) emanuele: lol

(12:19:08 AM) ***emanuele wonders if we can remove the help... :P
(12:19:35 AM) ***Norv sighs. Why?
(12:19:45 AM) emanuele: for fun!
(12:20:02 AM) emanuele: less to write :P
(12:20:05 AM) Norv: We have been seriously bashed for the choice to pull out the help contents from the software
(12:22:17 AM) Norv: And a point: that local installations (meant to be under corporate firewalls or something) won't have it. TBH I think it's a very rare case but who knows.
(12:23:08 AM) Norv: Ehh. TimeVortex hasn't been happy with it either. [/remembers the slap :D]
(12:23:16 AM) emanuele: the point is: the way it is now is almost useless
(12:23:33 AM) Norv: Probably true...
(12:23:40 AM) emanuele: yes, it brings you to a place where there is much more documentation, but...
(12:24:07 AM) emanuele: difficult to digest for a newbie
(12:24:33 AM) Norv: That should depend on the documentation pages it brings you to, right?
(12:25:41 AM) emanuele: and on where you (can) go from that pages
(12:25:49 AM) Norv: We could readd it as pages in /docs...
(12:26:18 AM) emanuele: I also agree on the fact that bringing the user to another site is not the best
(12:27:30 AM) emanuele: don't know...I never found manuals very useful, but that's probably because I like experimenting...
(12:28:29 AM) Norv: People complained a lot about the difficult maintenance of the former help pages, which had to follow the software changes through a syntax they found very time consuming to update
(12:34:55 AM) Norv: to keep up to date, I mean
Title: Re: IRC
Post by: TestMonkey on January 25, 2013, 12:00:22 am
(12:36:57 AM) emanuele: and the current system is not very well thought to stay in-synch
(12:37:47 AM) emanuele: the documentation will always be up-to-date, but old releases will point to the newer documentation
(12:38:01 AM) emanuele: (for any possible language of course)
(12:39:26 AM) Norv: True, but for user level (and newbie) documentation, I'm not sure it should change that much between major versions. It shouldn't (in theory).
(12:40:51 AM) Norv: Which pretty much cancels the previous point, heh. SMF 2.0 did change, but SMF 2.0 has been a major version and well worth that name.
(12:41:18 AM) Norv: Arguably.
(12:45:19 AM) emanuele: the documentation at that point doesn't make any distinction between minor and major versions, I'm just saying we should consider to separate the (user?) documentation for the different versions
(12:45:44 AM) emanuele: if there are things that are similar it should be pretty easy to clone the page and continue from there
(12:47:06 AM) emanuele: documentation is a pain... XD
(12:52:25 AM) Norv: fair enough
(12:53:22 AM) Norv: I still don't see what the best solution is, for 1.0 and beyond.
(12:55:58 AM) Norv: If we keep wiki links: you can't have a single link (can you?) to a wiki, it's still better to have the subjects broken down to redirect the user to the items more likely of interest...
(12:57:08 AM) Norv: If we (re)add packaged documentation: admin documentation can go in /docs, user documentation has to be a page(s)
(01:02:34 AM) Norv: I mean, in /docs we can add other separate files, if there's something more useful, simply available. (I'd think at a SSI/API introduction, for example; or how to use admin features, such as maintainance; or for a cli script if we add that clearly - i.e. upgrade is already, could have more).
(01:03:24 AM) emanuele: yeah, probably: (wiki|docs)/1.0/page
Title: Re: IRC
Post by: TestMonkey on January 25, 2013, 08:19:20 pm
(09:14:10 PM) Norv: https://github.com/elkarte/Elkarte/wiki/Architecture
(09:14:23 PM) Norv: Corrections and questions are welcome, please.
(09:14:55 PM) Norv: and good morning, IchBin (meh IRC should know to notify you of 'ugly brad')
Title: Re: IRC
Post by: TestMonkey on January 26, 2013, 01:03:00 am
(11:06:39 PM) Norv: How I hate queries in controllers... I can hardly read the code with boo-query in my way. :P
(11:06:58 PM) emanuele: change them! :P
(11:25:31 PM) TimeVortex: queries in controllers? D:
(11:25:39 PM) TimeVortex: http://i.imgur.com/ChwtZoK.jpg #relevant

(01/26/2013 12:12:09 AM) emanuele: Spuds, did you revert the code block to the 2.0 behaviour?
(12:41:58 AM) Spuds: Umm .. ummm .... no idea what you are asking, must have joined the channel to late
(12:42:53 AM) Spuds: you mean the the bbc code format thing?
(12:43:05 AM) emanuele: yep
(12:44:30 AM) Spuds: If its wrong now its either a) I never commited the change, b) commited it and then overwrote it from some dorked up branch, c) blame the cat lover

(12:45:48 AM) Spuds: I'll take a look and fix it ... me mind is blurry from working on the email thing
(12:49:12 AM) emanuele: I still don't know what are you doing with emails... :P
(12:49:34 AM) emanuele: (not sure I want to know xD)
(12:52:32 AM) Spuds: The post by email functionality
(12:52:58 AM) emanuele: I knew I didn't want to know! lol
(12:53:19 AM) Spuds: something to help keep the support team sharp :P ... oh wait thats us !
(12:53:45 AM) ***emanuele runs
(12:54:25 AM) Norv: Don't run, it'll be your turn to review it :D
(12:54:53 AM) Spuds: Its a big one to!

(12:58:01 AM) Norv: We no longer want repair_settings to support SMF, right? It supports 1.1 too atm
(12:59:21 AM) Spuds: @ema .... what prolem are you seeing with the code tag?
(12:59:30 AM) emanuele: well...[...]
(12:59:38 AM) Spuds: problem :/
(01:01:57 AM) emanuele: mmm...I can't extend them anymore
(01:03:34 AM) Norv: mmm... then if we do... I need to clean this code, can't add crap to it *headscratch*
(01:04:39 AM) Spuds: Humm ... seamonkey?
(01:05:10 AM) emanuele: firefox
(01:06:22 AM) Spuds: and you can't drag the code blocks large on the site ?
(01:06:52 AM) emanuele: nope... :(
(01:08:13 AM) Spuds: do you have a grip icon in the corner of the box ? ... I'm on ff and I can drag them fine, very strange

(01:10:53 AM) Norv: https://github.com/elkarte/Elkarte/pull/111

(01:11:42 AM) emanuele: Timestamp: 26/01/13 00:09:27
(01:11:43 AM) emanuele: Warning: Unknown property 'box-sizing'.  Declaration dropped.
(01:11:45 AM) emanuele: Source File: http://www.elkarte.net/cache/hive-f19d09939d3669dfb3d4fd49dfc0ba96836da744.css
(01:11:46 AM) emanuele: Line: 2
(01:11:56 AM) emanuele: what's the latest version of FF?
(01:12:26 AM) emanuele: 18...
(01:12:41 AM) Spuds: thats fine ... it should be using -moz-box-sizing ... css3 "standards" lol
(01:12:59 AM) emanuele: I should really take a bit of time and upgrade this machine... (I'm using 15)
(01:13:20 AM) Spuds: it works for me in FF, chrome, safari and looks like crap in ie9 ... so some fixining is needed
(01:13:32 AM) Spuds: ff 15, thats like 2 weeks old, get with it man
(01:14:20 AM) emanuele: LOL
(01:14:35 AM) emanuele: but I'm on a system that is...1 year old... :(
(01:15:19 AM) emanuele: no, actually 2 years old
(01:16:11 AM) emanuele: chrome doesn't even let me grab the handle...
(01:17:21 AM) emanuele: oook....also delete posts is broken...
(01:17:52 AM) Spuds: what version of chrome?
(01:18:11 AM) Spuds: do you have a mouse on that computer :D
(01:18:14 AM) emanuele: 22....
(01:18:35 AM) emanuele: yes, but is not exactly working... lol
(01:19:40 AM) Spuds: lol ... and chrome is like v24 now
(01:20:01 AM) emanuele: ohhh...I quit from the internet.
(01:20:13 AM) emanuele: :P
(01:21:21 AM) Spuds: The site is not up to date with the repo, I'll do an update later, should break some stuff for sure since thats the one with all them directory name changes

(01:24:33 AM) Norv: (sorry to keep barging in) So we want to support 3 versions atm, SMF 1.1, SMF 2.0 and Elk 1.0? Is there something of relevance to add to repair_settings in 2.1?
(01:25:05 AM) emanuele: no, I was joking. ;)
(01:25:12 AM) emanuele: just one is more than enough!
(01:25:33 AM) Norv: oh ok... You're sure? Spuds?
(01:25:52 AM) Norv: (I have no strong opinion)
(01:27:07 AM) Spuds: Sorry Norv ... whats the question

(01:27:42 AM) Spuds: Ema ... let me know if updating those browsers works for you ... we are using
(01:27:42 AM) Spuds: resize: vertical; css3 for that capability

(01:28:09 AM) Norv: repair_settings currently supports smf 1.1 and 2.0. I'm not sure we want to add Elk, or write it for Elk only
(01:28:51 AM) Norv: tbh it doesnt make sense to support smf... only the issues that the upgrade may introduce or leave over
(01:28:56 AM) Spuds: Oh ... my quick reaction is just do one for Elk ....
(01:29:26 AM) Spuds: if SMF repair is needed ... well use the smf repair I would think
(01:30:48 AM) emanuele: less code is always the best thing
(01:32:44 AM) Norv: lol
(01:40:56 AM) Norv: Then I'm also fully breaking compatibility of the code with your script emanuele - we probably won't be able to cherry stuff, only manually
(01:42:02 AM) emanuele: you are always breaking things... lol
(01:46:08 AM) Norv: I think February-March would be a good moment to acknowledge the next winner... so I'm really in a hurry
(01:46:33 AM) emanuele left the room (quit: Remote host closed the connection).
(01:48:09 AM) Spuds: Norv scared ema away :'(
(01:48:22 AM) Norv: I didn't mean to...
(01:48:29 AM) Spuds: LOL
Title: Re: IRC
Post by: emanuele on January 26, 2013, 01:38:58 pm
Quote
(11:34:48 PM) Norv: question: if I introduce a loadLibrary() for /subs files, and a loadController() for /controllers, would it be fine?
(11:35:36 PM) emanuele: think so
(11:36:38 PM) Norv: the hardcoded subdirectories are kinda ugly
(11:51:44 PM) Norv: or $librarydir and $controllerdir
(11:52:37 PM) emanuele: go for the load, less to type... :P
(11:54:31 PM) Norv: it's an extra function call though
(11:54:49 PM) Norv: and this time for a lot of files
Wondering: and a $dirs variable?
$dirs['libraries']
$dirs['controllers']
$dirs['board']
$dirs['sources']
Or a small class or whatever.
Just not to have to care about the globals.
Title: Re: IRC
Post by: TestMonkey on January 26, 2013, 07:46:09 pm
A few updates...

(02:58:40 AM) Spuds: code blocks .....
(02:59:33 AM) Spuds: we can set a height and use the resize: vertical; and overflow auto things so folks can zoom around as normal
(02:59:55 AM) Spuds: resize does not work in ie or opera, maybe others so its the standard scroll bars
(03:00:26 AM) Spuds: downside is all the whitespace around one liner code
(03:01:10 AM) Spuds: then there is the max height thing which removes the whitespace, and resize does not work, you have to use the scroll bars (thats todays thing)
(03:03:20 AM) Spuds: We could use height and resize, and then with jquery find the codeblocks, set height to auto, and then reset to specific heights for those blocks over a certain lenght ... this will remove the whitespace on one/two liners, and allow resize or scrollbars to work.   For non-js users its like normal

(03:12:14 AM) ***Spuds needs to add some more memory to this machine!
(03:17:23 AM) Spuds: I updated the site with my ramble on code blocks to see if we like that or no
(03:42:57 AM) Norv: Thanks! Sorry, I didn't really pay attention to these...
(03:59:42 AM) Spuds: lol ... me either but I think whats there now (hard refresh) will be the best solution, I don't think there is a pure css one
(04:01:49 AM) Spuds: so if we like it I'll make a pr for it, if not, the next site refresh will revert it :D
(04:05:58 AM) Norv: Sure, thanks! Eventually we can see tomorrow when Ema wakes up. :)

(04:07:16 AM) ***Norv mumbles that we could have installations with very messed up paths...

(04:11:31 AM) trekkie101: Norv did you just post a roadmap?
(04:12:26 AM) Norv: https://github.com/elkarte/Elkarte/issues/2 is the roadmap for 1.0 beta. I didn't post anything clearer or further
(04:12:51 AM) Norv: It's not good enough?
(04:12:58 AM) trekkie101: You misunderstand
(04:13:08 AM) trekkie101: I *love* that!
(04:14:31 AM) trekkie101: It literally could be the lyrics to Scooby doo but minus the internals SMF has always lacked
(04:16:38 AM) Norv: And the Relevant links topic should give a 'bigger' picture on what's what/where. I actually don't think it's enough (at all) but well. I'm not sure about the format (and wording will take some time) of a 'real', user-readable-easily, roadmap and project stuff.
(04:18:03 AM) trekkie101: The post and a little milestone graphic on GitHub will do fine for now

(04:31:09 AM) trekkie101: We'd need to establish a "team" and "positions" first lol or else it's gonna be a pile
(04:31:25 AM) trekkie101: Of us plebs looking at the awesome code work :p
(04:33:21 AM) Norv: Make teams if you want Trekkie One - but please talk to Spuds and Ema too before. I understand Ema is quite against badges lol.
(04:33:48 AM) trekkie101: I don't care for them either tbh
(04:35:35 AM) Norv: One thing we all should pay attention to: focus on areas. And the second thing: keep things open by rule, in the sense that you can talk everything in the earth and sky in private, but it becomes *real* only after it's publicly explained and done.
(04:38:03 AM) trekkie101: I like your lead there!

(05:50:11 AM) Norv: You folks keep working on (the current code on) bbc and stuff... I guess we might not make the switch yet (for 1.0), if I think of all else still to do
(05:58:34 AM) Norv: attachmentUploadDir - 201 matches in working set 'elk_standalone' umm...

(05:06:49 PM) Spuds: http://www.elkarte.net/index.php?topic=134.msg945;topicseen#new
(05:07:31 PM) Spuds: I must say I already find librarydir which points to subs and not lib already confusing :P
(05:07:50 PM) emanuele: mmm...kind of true :P
(05:07:58 PM) emanuele: but that's Norv's fault! :D
(05:08:19 PM) Spuds: so trueeeeee
(05:09:32 PM) Spuds: I kind of like the idea of a array for all those directory things, don't know if there are any pitfals though
(05:10:38 PM) emanuele: or a static class or something
(05:10:52 PM) Spuds: we have boarddir, sourcedir, librarydir, cachedir, controllerdir and I still need to move the hive files so we will have hivedir
(05:11:04 PM) emanuele: lol
(05:11:23 PM) emanuele: yep, quite a lot
(05:12:19 PM) Spuds: yep and everythime you extend it, you have to edit a bunch of files
Title: Re: IRC
Post by: TestMonkey on January 26, 2013, 07:47:01 pm
(05:15:59 PM) Spuds: emanuele ... did you see the change I did to the site code boxes?
(05:18:06 PM) emanuele: yep, now is working again! :D
(05:19:34 PM) Spuds: basically they are back to code boxes with a intial height with a resize css (for the browsers that support it) but then in JS I set the hieght to auto so small boxes collapse and then turn the height back on for boxes > ~20em ... for those you will either get the grip to resize or the scroll bar (or both)

(07:03:09 PM) emanuele: Spuds: require_once($sourcedir . '/sphinxapi.php');
(07:03:33 PM) emanuele: Can't find the file, is that something that should be added when using sphinx?
(07:26:08 PM) Spuds: Its something that comes with the sphinx software, so its distributed with it
(07:26:24 PM) Spuds: not sure if we can or can not include it with our distro
(07:28:00 PM) Spuds: // This program is free software; you can redistribute it and/or modify
(07:28:01 PM) Spuds: // it under the terms of the GNU General Public License. You should have
(07:28:01 PM) Spuds: // received a copy of the GPL license along with this program; if you
(07:28:01 PM) Spuds: // did not, you can find it at http://www.gnu.org/
(07:28:01 PM) Spuds: //
(07:29:13 PM) Spuds: not the lesser, at least this one I have
(07:30:59 PM) emanuele: it was just to be sure it was something that had to stay there and not something lost while renaming things. :D
(07:31:54 PM) Spuds: I think I have a check for that file when you enable that option in the acp, the sphinx search option
(07:33:42 PM) emanuele: yep
(07:36:11 PM) Spuds: good ... I don't have sphinx installed on this machine ATM ... I did when I was adding the feature, but that test setup went kablooie at some point
(07:47:20 PM) Spuds: Ok the truth is that I spilled my latte down my keyboard .... so the new computer is not set up with it yet :P
(07:48:04 PM) emanuele: the truth is that you are lazy! :P
(07:48:30 PM) Spuds: Yeah !

(08:07:17 PM) Norv: Morning lol
(08:08:47 PM) Norv: I don't think we can, need, nor should, distribute GPLed software
(08:09:28 PM) Spuds: Bonjour ....
(08:09:38 PM) Spuds: yup ... how about lgpl

(08:09:46 PM) Norv: I should have left /lib as internal library, huh?
(08:10:13 PM) Spuds: just confusing to my old brain
Title: Re: IRC
Post by: TestMonkey on January 26, 2013, 07:55:18 pm
(08:11:23 PM) Norv: them lawyers still have fun imagining what is the scope of LGPL in interpreted languages. But the established practice is simple: we're fine combining it and distributing it along with any licenses, unless we modify its own code (in which case the resulting modification is LGPL).
(08:12:10 PM) Spuds: OK ... of lgpl is ok as long as its untouched/unchanged ...
(08:14:03 PM) Norv: I've been looking at BB, we're using it how it was meant by its author to be used. As a library, accessed through compatible-licensed code. It's fine. We can (and I might) go into dirty details here, but not something to be worried about.
(08:15:19 PM) Norv: well if you change it, you have to license as LGPL - that's also "okay" after all. The established practice (and it's not necessarily them ugly lawyers yapping lol) is that it's a sort of a MPL. :D
(08:16:30 PM) Spuds: Good deal ... yeah I just used that interface file that BB calls, so some of it is a bit odd but that was to avoid any changes to the BB lib itself.
(08:17:09 PM) Norv: Yes, the author wasn't very happy to see it forked and not renamed, I remember
(08:17:13 PM) Spuds: Interesting ... so in theory you could fork an lgpl lib, change it under lgpl of course, then use the modified lgpl in your distro
(08:17:21 PM) Norv: yes
(08:17:49 PM) Spuds: :D
(08:21:23 PM) Norv: the difficult question (sometimes, depending on the code, language, and who you ask lol), is what is the scope that LGPL should extend to. How much of the "other" interacting code it touches. The *practical* answer is: almost nothing else than its code itself, considering also the author's position on the intention of his license. The "lawful" answer is: everything that is a derivative under copyright law. The problem with the latter is nobody knows for sure which that is for all cases, languages, interactions, in software. lol.
(08:21:44 PM) Norv: There
(08:21:58 PM) Norv: :D

(08:24:12 PM) Trekkie101: Busy in here tonight :P
(08:24:26 PM) Norv: And Norv yapping about licenses. lol.
(08:24:36 PM) emanuele: It's just Norv writing about legal things
(08:24:40 PM) emanuele: lol
(08:25:54 PM) Trekkie101: Anything interesting in it all :P
(08:26:25 PM) Norv: Lemme grab some coffee and post quickly them log.
(08:26:45 PM) emanuele: have you ever found anything interesting in legal mumbo-jumbo? :P
(08:26:55 PM) Norv: Me? Yes. :D
(08:27:25 PM) Trekkie101: Me? Occasionally :P
(08:27:44 PM) emanuele: weird people...
Title: Re: IRC
Post by: TestMonkey on January 26, 2013, 08:05:41 pm
(08:29:57 PM) ***Norv snickers seeing the github simultaneous PRs on directories
(08:32:47 PM) Norv: I don't see a downside to using constants?
(08:33:13 PM) Norv: Well other than they're also 5-6, like these globals.
(08:40:24 PM) emanuele: so another round of changes? :P
(08:41:05 PM) Norv: Your PR doesn't merge, TE's was merge-able... Not sure what happens :D
(08:42:44 PM) emanuele: nothing new... xD
(08:43:30 PM) emanuele: because I removed the global $sourcedir; from the dispatcher
(08:44:02 PM) emanuele: what's best keep all the globals (dir) even if not used or better to cleanup everything?
(08:44:16 PM) emanuele: or wait if we move to constants
(08:45:26 PM) emanuele: now it should merge
(08:47:38 PM) emanuele: wait Norv don't merge it
(08:48:14 PM) Norv: LOL
(08:48:50 PM) Norv: Don't worry, I'll wait to see what TE wants to do. You're not the only one y'know!
(08:48:50 PM) emanuele: no, okay it's fine
(08:49:16 PM) Spuds: So CONSTANTS or a static so we could use an array perhpas?
(08:50:32 PM) Norv: What does an array help with, other than using more resources when you put it all in scope, and you only need one or two?
(08:52:10 PM) Norv: I'd favor constants. No more globals to remember to add, and they don't change anyway. Same names (well uppercased of course).
(08:52:12 PM) Spuds: Humm .. I don't think what you are describing would be a help ... oh wait was that sarcasm from Norv :P
(08:53:01 PM) Norv: Any downsides I may miss?
(08:53:04 PM) Norv: :D
(08:53:33 PM) emanuele: no, nothing different from now I think (except uppercase :P )
(08:53:41 PM) Spuds: constants are fine by me, was just asking questions to make sure we only do this twice :D
(09:01:46 PM) Norv: Will have to discipline myself... make complete PRs... Grumblers. :D
Title: Re: IRC
Post by: TestMonkey on January 26, 2013, 08:46:37 pm
(09:08:08 PM) emanuele: Hey Spuds: when you have finished with emails, next one is post-from-IRC! :P
(09:10:35 PM) Norv: LOL! That's not difficult... we could have a bot here to log stuff. I ain't gonna do this forever y'know. :P
(09:10:44 PM) ***Norv feels like a bot. :P
(09:14:13 PM) ***emanuele goes

(09:17:06 PM) Trekkie101: FeAtUrE ReQuEsT: Make the breadcrumbs navigation at the bottom of the page less fiddly on a mobile browser
(09:18:25 PM) Trekkie101: Question: What does disregard do?
(09:18:35 PM) ***Norv would like to point Trekkie101 to https://github.com/elkarte/Elkarte/issues
(09:19:04 PM) Trekkie101: Your right Norv-iliious Ill fix the code
(09:19:24 PM) Norv: Although mean SpudsMan has only created the 'enhancement' tag, not 'feature request'. I suspect he had dark intentions yesyes doing so...
(09:21:32 PM) Trekkie101: I dont think I can tag it anyway
(09:22:36 PM) Trekkie101: Also meant to ask, does github/git have a way of making a little changelog.txt or is it all in the magic of the commits page?
(09:26:28 PM) Spuds: Just to show I'm not so mean .... I add the feature request tag
(09:27:05 PM) Trekkie101: Aww you copied the appropriate style :P
(09:27:16 PM) Spuds: Just for you ;)
(09:27:35 PM) Trekkie101: It helps sarcastically suggest, NFW.
(09:30:51 PM) Norv: With git, you can do: > git log, and it shows you the log. Save it in a file etc.

(09:38:30 PM) Spuds: > Question: What does disregard do?
(09:38:30 PM) Spuds: Thats for topics you no longer wish to be notified of new posts in ..... like when you post in a mod thread that you no longer use and don't want to be notified that someone new posted a question that was answered 50 times before in that thread.
(09:39:57 PM) Trekkie101: Ah
(09:39:59 PM) Trekkie101: Ignore!

(09:42:04 PM) Norv: Trekkie101: if you add to your git config file extra-aliases or options, you can have any view of the log you want. For example, I use the 'lp' alias you see here: https://gist.github.com/3342247
(09:42:34 PM) Norv: it's a compact, colorful (lol), view of the log
Title: Re: IRC
Post by: TestMonkey on January 27, 2013, 12:06:00 am
(10:59:44 PM) emanuele: question: integrate_*_include could be considered deprecated? (and/or removed?)
(11:22:28 PM) Norv: why, because of the file parameter?
(11:22:49 PM) Spuds: integrate_pre_include, integrate_admin_include, integrate_theme_include, integrate_autotask_include .... opps Norv beat me to the question

(11:37:39 PM) emanuele: I sent  PR using some of the new features like include files with hooks instead of integrate_*_include
(11:37:50 PM) emanuele: Norv>   why, because of the file parameter?
(11:37:58 PM) emanuele: yep, that's what I was wondering

(11:47:29 PM) Norv: Agree... not sure if theme_include too...?
(11:48:23 PM) emanuele: you mean keep theme_include?
(11:49:13 PM) Norv: just wondering, I haven't used it so I simply dunno.
(11:50:01 PM) emanuele: I think I tried to use it once but it was in a terrible position for what I wanted to do if I remember correctly...
(11:53:00 PM) emanuele: and apart from that I'm still not sure what the difference between pre_include and theme_include are... :(
(11:56:28 PM) Norv: I guess you're right and we could pull them out now... Unless we want a level of compatibility with mods here?
Title: Re: IRC
Post by: TestMonkey on January 27, 2013, 01:05:48 am
(01:49:38 AM) Spuds: https://github.com/elkarte/Elkarte/wiki/Coding-Standards  ... as a start ... would like to add more to naming conventions perhaps ...
(01:59:25 AM) Norv: Wonderful work, thank you! It must have taken you a lot of time... /me wasn't able to do it.

(02:02:18 AM) Norv: May I? https://github.com/elkarte/Elkarte/pull/111 For some reason I'd like this in because dunno, it seems to clear up things better... well it tries to.
(02:05:27 AM) Spuds: Absolutly .... on 111

(02:06:13 AM) Spuds: Nah that did not take to long ... did some lifting from the coding guidlines, just tried to make it a bit more simple
Title: Re: IRC
Post by: TestMonkey on January 27, 2013, 03:30:56 am
(04:07:16 AM) Trekkie101: Are we elkarte, Elkarte or ElkArte though :P
(04:07:28 AM) Norv: lol
(04:08:02 AM) Norv: I'd propose ElkArte
(04:08:25 AM) Trekkie101: Nice to see TE around!
(04:10:59 AM) Norv: For no good explanation, except spelling and abbreviation to Elk. Which is what we do anyway. We could, if someone has some design inspiration, make something like a mascot with an Elk  /just shooting an idea.
(04:13:46 AM) Trekkie101: Im graphically untalented
(04:13:55 AM) Trekkie101: But we should choose something simple
(04:13:59 AM) Trekkie101: Like a bear but not a bear
(04:14:12 AM) Trekkie101: Something we can actually buy :P
(04:14:18 AM) Trekkie101: Like a giraffe or something
(04:14:44 AM) Trekkie101: Not a real giraffe, but a teddy one
Title: Re: IRC
Post by: TE on January 27, 2013, 08:39:27 am
(08:48:50 PM) Norv: Don't worry, I'll wait to see what TE wants to do. You're not the only one y'know!
ok, here we go :) Just an idea, maybe there's a better solution....
You'd have an array which is easily extendable (related to mod authors) in Settings.php
Code: (Settings.php) [Select]
$dirs['boarddir'] = '/var/www/htdocs/forum';
$dirs['cachedir'] = $dirs['boarddir'] . '/cache';
$dirs['sourcesdir'] = $dirs['boarddir'] . '/sources';
$dirs['controllersdir'] = $dirs['boarddir'] . '/sources/controllers';
...

In index.php it could be converted to constants.
Code: [Select]
// Load the settings...
require_once(dirname(__FILE__) . '/Settings.php');
foreach($dirs as $key => $value)
{
$key = strtoupper($key);
define($key, $value);
}
Title: Re: IRC
Post by: TestMonkey on January 27, 2013, 06:42:33 pm

(08:48:50 PM) Norv: Don't worry, I'll wait to see what TE wants to do. You're not the only one y'know!
ok, here we go :) Just an idea, maybe there's a better solution....
You'd have an array which is easily extendable (related to mod authors) in Settings.php
Code: (Settings.php) [Select]
$dirs['boarddir'] = '/var/www/htdocs/forum';
$dirs['cachedir'] = $dirs['boarddir'] . '/cache';
$dirs['sourcesdir'] = $dirs['boarddir'] . '/sources';
$dirs['controllersdir'] = $dirs['boarddir'] . '/sources/controllers';
...

In index.php it could be converted to constants.
Code: [Select]
// Load the settings...
require_once(dirname(__FILE__) . '/Settings.php');
foreach($dirs as $key => $value)
{
$key = strtoupper($key);
define($key, $value);
}
So we want extensibility for mods/addons? (not sure) But here the thing is, we cannot have them edit Settings.php, and/or recommend to rely on Settings.php additions - people keep it readonly and that should be the recommended way even for mods/addons installation time... And it's too early in the flow for a hook. (database isn't loaded)

TBH I'm not sure we need extensibility for mods/addons: extensions will do as the core does (well, ideally), and that's a single line of code they need to do: a define. The only advantage I can think of, if they register their path through some mechanism (i.e. install-time updateSettings() or add_integration_hook('path', 'some_path')), is that we can compare it for duplicates... which is unlikely?

Not sure I'm missing something here, coffee timez. :)

IMHO the solution is the way to go, I'm just not sure $dirs is of any use for mods/addons, so might as well define paths directly in Settings.php.
Title: Re: IRC
Post by: TestMonkey on January 27, 2013, 08:29:58 pm
Someone broke [code] within quotes... O:-)

ETA: ohwait. Rather: right after quick edit, looks like js doesn't run to fix [code]. After refreshing the page it's okay.
Title: Re: IRC
Post by: Spuds on January 27, 2013, 10:14:01 pm

Someone broke [code] within quotes... O:-)

ETA: ohwait. Rather: right after quick edit, looks like js doesn't run to fix [code]. After refreshing the page it's okay.

Yeah the code format thing only runs on page load ... could look to run it after an ajax event as well
Title: Re: IRC
Post by: TestMonkey on January 27, 2013, 11:14:03 pm
(07:26:28 PM) Norv: :coffee:
(07:27:06 PM) TimeVortex: 0xC0FFEE
(07:27:29 PM) TimeVortex: or 0x7EA

(09:32:35 PM) ***Norv blinks
(09:33:02 PM) Norv: emanuele am I blind or TE's post has disappeared from the IRC thread?
(09:49:18 PM) emanuele: seems so...
(09:49:20 PM) Norv: I need the db...
(09:49:35 PM) emanuele: nothing logged into the moderation log...
(09:49:57 PM) Norv: nor error log
(09:49:59 PM) Norv: http://www.elkarte.net/index.php?topic=151.msg969#msg969
(09:50:32 PM) emanuele: Maybe enable the recycle bin (just in case)
(09:51:16 PM) emanuele: repair errors...
(10:00:37 PM) Norv: yes, repair fix it...
(10:11:54 PM) emanuele: now the funny part! :D

(11:21:28 PM) Norv: what's this? https://github.com/SimpleMachines/SMF2.1/pull/280
(11:22:03 PM) ***emanuele haz no idea...

(11:34:10 PM) emanuele: When declaring a function, the function name should have a space after it.
(11:34:12 PM) emanuele: ???
(11:34:57 PM) emanuele: Use ',' concatenation for language constucts
(11:36:12 PM) emanuele: try to avoid concatenation of language strings as much as possible
(11:42:26 PM) Norv: lol... I think the first refers to: function func_name [space] ($params). Though I believe this isn't what we do... lol
(11:42:44 PM) emanuele: nope... :P
(11:43:13 PM) emanuele: well... I started doing it in my mods and from time to time I *may* write something like that in elkarte too... O:)
(11:45:49 PM) Norv: As for the second, I take it as: use sprintf(), avoid 'part' . $var . 'part2'
(11:46:27 PM) emanuele: yep
(11:47:08 PM) Norv: wait, is that a comma?
(11:47:20 PM) emanuele: I was not sure because of the example
(11:47:26 PM) emanuele: what?
(11:47:33 PM) Norv: (11:34:57 PM) emanuele: Use ',' concatenation for language constucts
(11:47:51 PM) emanuele: yes, it looks like a comma

(11:59:00 PM) Spuds: Thats the one where you could get duplicate ids on the script or css files .....
(11:59:21 PM) Spuds: (sorry if that was already answerd)

(01/28/2013 12:02:29 AM) Norv: I can only find num_replies being incorrect... that's not a big deal
Title: Re: IRC
Post by: TestMonkey on January 28, 2013, 12:47:50 am
(12:51:27 AM) groundup entered the room.
(12:51:46 AM) Spuds: Run !

(12:59:28 AM) groundup: I need to setup my dev environment for SMF again.
(01:00:20 AM) groundup: I think I might make a VirtualBox image for others to use.
(01:20:21 AM) groundup: Hey, so I am creating this image to share (because I think it would be cool). If you guys were to pick a distro, which would it be? I just went with CentOS because RHEL is pretty standard.
(01:21:07 AM) TimeVortex: Depends, really.
(01:21:20 AM) TimeVortex: Arch on my desktop, but Debian for servers, all the way.
(01:22:31 AM) emanuele: I usually like (open)suse...any real reason, probably because of the green
(01:22:50 AM) groundup: Do you think I should use a GUI version?
(01:23:19 AM) Norv: Debian for desktop and servers.
(01:28:21 AM) TimeVortex: Norv: testing for desktops, at the very least, then :P
(01:30:05 AM) TimeVortex: groundup: for a server? Nope.
(01:30:55 AM) groundup: It is for a development environment. I've come to the realization that dev'ing locally sucks when you're dealing with multiple environments.
(01:31:55 AM) groundup: What I've done for my chat app is setup Netbeans to upload to a local VM on save and then on "play" it opens it in my browser.
(01:32:42 AM) Spuds: You have it all wrong ... ubuntu
(01:33:33 AM) groundup: I think that's what I'll wind up doing, Spuds.
(01:34:31 AM) groundup: Now to download Ubuntu LiveCD (ugh, my internet connection sucks). Luckily I am going to my parents for dinner in a few so I won't have to deal with it
(01:35:34 AM) Norv: Spuds: http://identi.ca/attachment/74637058
(01:35:59 AM) groundup: Ubuntu Server or Desktop? I am thinking server for this application - no need to have a GUI.
(01:36:30 AM) groundup: lol @ Norv.
(01:37:10 AM) Norv: Testing, of course. With some unstable on top.
(01:37:16 AM) Spuds: Only *nix could have nerd levels :D
(01:37:44 AM) groundup: lol
(01:38:45 AM) groundup: Downloading Ubuntu Server. Been a while since I used Debian-style.
Title: Re: IRC
Post by: Antechinus on January 28, 2013, 02:42:56 am
(01:55:31 AM) ***Norv is not sure. It's like the IPs issue... of which I didn't tell you about. I wonder if we can/want to add an option for a 'private' login, for which no IPs are logged for the user. Similarly, perhaps we can exclude from maintainance screens some attachments.
(01:57:09 AM) Spuds: Just seems like something that I see asked for often enough ... we could also add some basic file crypt to pm attachments ... makes the admin open the db, get the key, etc etc if we wanted it more ummm agrivating to get at the file
(01:57:48 AM) Spuds: or even aggravating :D
(01:58:48 AM) Spuds: No IP logging .. now that is crazy talk
(02:06:28 AM) emanuele: time to go, bye!
(02:06:31 AM) Norv: Every now and then, I saw (very rarely) a request for disabling any IP logging, at least for members. The point being particular needs of private forums, whose admins wanted to assure their members they have privacy to the level of no IP tracking.

Should be admin-selectable, not purely user-selectable. Having it pure user-selectable would be asking to be trolled and generally gently caress around with.

Re PM attachments: given the possible legal ramifications, depending on content, I think making admin access to them more difficult is plumbers crack about. IMHO admin access to them should not be crippled in any way.
Title: Re: IRC
Post by: TestMonkey on January 28, 2013, 02:51:59 am
Re: PM attachments "legal".
Been thinking about that in the past. I don't think the feature itself is problematic for "legal ramifications". There are no "legal ramifications", really, no more than any site you put at the disposal of people to add personal content to. No more than PMs themselves. The same difficulty of access means the same thing.

Either copyrighted (and not shareable) or illegal/borderline content can be sent through PMs just as well. You only add more formats (i.e. any file, image files).
Title: Re: IRC
Post by: Antechinus on January 28, 2013, 03:04:16 am
True, but in that case you're not actually hosting it on your site. :)

Also, it's generally a bit problematic if you want to prune attachments. If doing any pruning of anything, I'd expect to be able to see the content. Not that this is insurmountable. Just thinking.
Title: Re: IRC
Post by: TestMonkey on January 28, 2013, 11:39:30 pm
(11:15:28 PM) emanuele: So calm today here around...
(11:15:36 PM) emanuele: :P
(11:21:53 PM) Spuds: Yeah quiet day ...

(11:25:26 PM) Spuds left the room (quit: Quit: Leaving.).
(11:26:00 PM) ***emanuele scared Spuds...
(11:26:22 PM) Norv: It was the Italians part...
(11:26:53 PM) emanuele: yeah, I know we are terrible :P
(11:29:19 PM) Norv: Don't forget he's American. Them just don't get the awesomeness of Europeans. Neither where we are on the map for that matter...
(11:29:32 PM) emanuele: LOL

(11:37:46 PM) Norv: Have you seen https://github.com/elkarte/Elkarte/pull/122 ?
(11:38:10 PM) emanuele: I have seen the PR
(11:38:24 PM) emanuele: not looked into the commits (apart from noting SCEditor 1.4.1)

(11:45:21 PM) emanuele: Yesterday, while working on banEdit, I was thinking that one useful thing to do "at some point" is to check all the hooks we have are actually "useful"
(11:47:20 PM) emanuele: I mean: have a hook is fine, but if to "use" the output of that hook you need to edit something else, then the hook is useless
(11:48:14 PM) Norv: yes. Maybe with the occasion of a new API for them. On the other hand, on this, methinks we will get useful information from actual use in practice, after beta/RC.
(11:49:09 PM) emanuele: after RC seems a bit late! :P
(11:49:24 PM) Norv: Heh :D

(11:46:43 PM) Norv: https://github.com/Spuds/Elkarte/commit/0018ad2a0da12bd44638da445595d2db98a06cb6  why did we have an index.css.new anyway?
(11:48:03 PM) emanuele: I see many "-", it has been removed
(11:49:18 PM) Norv: Dunno why it was there in the first place... :D (index.css.new)
(11:49:28 PM) emanuele: the css.new was added in 142c5325c9fd34eef5da21a59692770e1f267be7
(11:49:59 PM) emanuele: Spuds is trying to fight with us! :D
(11:50:24 PM) emanuele: but a css.new doesn't break anything! :P
(11:51:34 PM) Norv: Yeah, he has no chance.
(11:55:25 PM) Norv: https://github.com/Spuds/Elkarte/commit/928ce8039604284c70092ead78c5b9f9dd11ac09 duplicate?
(11:56:40 PM) Norv: There's only one search bar, presumably not necessary on core features page... I probably misunderstand what was meant by 'duplicate'?
(11:58:25 PM) emanuele: no it's fine
(11:58:33 PM) emanuele: look at the profile page
(11:58:46 PM) emanuele: I'm working on it
(11:59:01 PM) emanuele: (at least if what he found is waht I think)
(01/29/2013 12:00:55 AM) emanuele: yes, it's that
(12:01:56 AM) emanuele: when I added admin_search I was supposed to remove the "custom" title bar of many pages not relying on the "common" template, but I noticed only few of them...
(12:03:29 AM) emanuele: that's a good shot in our competition! :P
(12:17:16 AM) Norv: Ahh
(12:19:03 AM) Norv: Can I merge the PR though? I can't replicate https://github.com/elkarte/Elkarte/issues/121 (apart from the bar) but it looks like it addresses some of it
(12:21:46 AM) emanuele: me neither...seems to work here
(12:21:51 AM) emanuele: yes, feel free to merge

(12:27:08 AM) emanuele: Oh, question: call_integration_hook should take car of all the $somethingdir we have now? ($boarddir, $librarydir, $sourcedir, $controllerdir, maybe others)
(12:28:23 AM) Norv: It makes sense that it does, even though I think we should recommend to use an addons directory
(12:28:41 AM) emanuele: that was another thing I was considering...
(12:29:19 AM) emanuele: using a directory we could even just ignore any $somethingdir and just append the directory
(12:29:27 AM) emanuele: I mean the path
(12:32:51 AM) Norv: like /addons here? https://github.com/norv/elkarte/tree/dirs_test6
(12:33:47 AM) emanuele: I think so
(12:33:50 AM) emanuele: :D
(12:38:15 AM) Norv: I was thinking to add it to /sources, but people keep it readonly
Title: Re: IRC
Post by: TestMonkey on January 28, 2013, 11:48:44 pm
(12:41:10 AM) emanuele: well...the way it is now it cannot be readonly anyway (if you want to install something from the admin panle of course)
(12:43:39 AM) emanuele: I wonder: why template_info_center is a function call and not a layer?
(12:43:40 AM) Norv: if you install a hooks-only addon, in a $boarddir subdirectory, /sources can be readonly
(12:43:53 AM) Norv: no clue
(12:44:16 AM) emanuele: but it makes sense to have a layer there, no?
(12:44:32 AM) emanuele: yes, if you create the directory of course it can
(12:44:34 AM) emanuele: :)
(12:45:54 AM) Norv: it makes sense to me
Title: Re: IRC
Post by: TestMonkey on January 29, 2013, 12:40:10 am
(01:24:01 AM) emanuele: I'll fix the header issues and send the commit to elkarte too (my master is a bit messed up), otherwise if you want to cherry-pick it feel free! ;D

(01:25:53 AM) Norv: TimeVortex should know what's with template_info_center(), but he's not telling. He's lost in reddit thingies, meknows.
(01:27:02 AM) TimeVortex: Well, originally it wasn't even a separate function.
(01:27:06 AM) TimeVortex: That's a 2.0 thingy
(01:28:10 AM) TimeVortex: I don't think we ever considered making it a separate layer yet, as that'd require both an _above and _above IIRC.
(01:28:57 AM) emanuele: https://github.com/emanuele45/playpen/commit/c35408a0ad0e3671a3e48d7f6060526c1da4fa1b
(01:29:15 AM) emanuele: I made the stats and newsfader the above
(01:29:23 AM) emanuele: and info center the below
(01:29:27 AM) TimeVortex: Hmm
(01:29:36 AM) TimeVortex: What if you want to reuse the info center on, say, a website?
(01:29:50 AM) emanuele: just call the function :P
(01:30:22 AM) TimeVortex: In SMF you had a function in Subs-BoardIndex.php to init it and template_info_center to show it. Makes more sense, name-wise, imo
(01:30:39 AM) TimeVortex: Calling it boardindex_outer_below invites all sort of other stuff from theme designers.
(01:31:10 AM) emanuele: then two functions? (the layer and the info center?
(01:31:38 AM) TimeVortex: That'd be three, wouldn't it?
(01:31:54 AM) TimeVortex: Unless you fancy putting the news fader in its own function, too.
(01:32:17 AM) TimeVortex: (Personally I'd split it off the news fader into a plugin at some point, anyway.)

(01:32:20 AM) emanuele: we can do almost everything :P
(01:32:39 AM) TimeVortex: Sorry, is this ZomboCom?
(01:32:58 AM) TimeVortex: http://html5zombo.com/ for those unaware
(01:41:30 AM) Norv: lol @ Zombo
(01:41:38 AM) Norv: Quite true.

(01:33:29 AM) emanuele: http://www.simplemachines.org/community/index.php?topic=486220.msg3412609#msg3412609
(01:33:36 AM) emanuele: I thought I pushed it to git hub
(01:34:12 AM) TimeVortex: I've been out of the loop, I'm afraid.
(01:34:42 AM) emanuele: that's just the news fader into a layer that appears on any page instead of only boardindex
(01:34:54 AM) emanuele: a mod I wrote a while ago
(01:39:08 AM) emanuele: https://github.com/emanuele45/playpen/commit/217a97bc10f4cafcac446e30f59c896e663da390
(01:40:42 AM) TimeVortex: hurray! :P
Title: Re: IRC
Post by: TestMonkey on February 10, 2013, 03:59:51 pm
(09:57:46 PM) Norv: Morning :coffee:
(10:45:33 PM) Norv: http://xkcd.com/838/
(10:47:57 PM) emanuele: lol

(04:49:34 AM) Norv: Handy stuff. I haven't used it though. http://defunkt.io/hub/
(05:12:49 AM) Spuds: I just tend to use tortoisegit for a lot of stuff ... don't use the cli unless I need to do something fancy .... lazy at heart I am

(05:27:09 AM) groundup: Installing packages
(05:42:42 AM) Spuds: you should be done now :D
(05:50:09 AM) groundup: It is taking a while to restart php-fpm process. Not sure why
(05:50:58 AM) Spuds: should take about zero really
(05:52:14 AM) groundup: Yeah, which is weird that it is now taking like 5 minutes
(05:52:20 AM) Spuds: nginx?
(05:52:38 AM) groundup: I installed nginx if that's what you're asking

(09:30:56 PM) ***emanuele is back
(09:31:08 PM) ***emanuele dros support for postgreSQL :P
(09:31:12 PM) emanuele: *drops
(09:45:17 PM) Spuds: lol ... off to the compliance officer with you!
(10:01:47 PM) emanuele: can we ban joins too?
(10:01:49 PM) emanuele: lol

(01:05:45 AM) emanuele left the room (quit: Quit: ChatZilla 0.9.87 [SeaMonkey 2.0.14/2011042000]).
(01:13:44 AM) ***Spuds snickers ... emanuele uses SeaMonkey 2.0.14/2011042000 :P

(01:16:45 AM) TimeVortex: dun DUN DUNNNN http://i.imgur.com/ChwtZoK.jpg
(01:23:36 AM) Spuds: LOL ... don't tell :D
Title: Re: IRC
Post by: TestMonkey on February 10, 2013, 04:01:29 pm
(01:50:56 AM) groundup: Yo ho ho.
(01:52:34 AM) groundup: So, I am working on this project at work where I have to build a member based site. I wanted to get it up and running quickly and easily with some basic concepts - members, ACL, standard routing, templates. So, I try Symfony. Damn that framework annoyed the *** out of me today. Tried using it with Nginx in a subdirectory good luck trying to figure that out
(01:53:16 AM) groundup: My next step is to either try another framework (Cake or Zend) or try Symfony Components
(02:15:28 AM) TimeVortex: If Symfony is a bit too much for your liking, try Silex.
(02:15:42 AM) TimeVortex: Uses Symfony components, without the --shall we say-- overhead.
(02:27:44 AM) groundup: TimeVortex: know of any generators for it?
(02:28:23 AM) TimeVortex: Generators? In what way?
(02:30:06 AM) groundup: Eh, I guess an example site/code would be the best way to put it. Bundles are pretty similar in Symfony. ZF has generators. It is more than just a bootstrap but it is a bootstrap
(02:34:20 AM) TimeVortex: Hmm, no, none come to mind.
(02:34:35 AM) TimeVortex: It being 1:34am doesn't really help in that respect
(02:34:45 AM) TimeVortex: For me, anyway
(02:36:02 AM) groundup: I hear ya
(02:41:58 AM) groundup: Well... that's for work tomorrow. Don't feel like working on work when I want to be working on other stuff

(04:40:31 AM) groundup: http://www.simplemachines.org/community/index.php?topic=496251.0
(05:00:40 AM) Norv: I don't understand the question. The development process is documented in the repo, see contributing
(05:35:33 AM) groundup: Norv, when I work on a project, I don't want to have to keep it in two formats. When I click save, I want to open it in the browser and be able to check my changes.
(05:35:40 AM) groundup: So, the question is, how do you do that?
(05:36:34 AM) groundup: The way I've done it in the past for SMF has been copying my files over my previous ones on a test site.
(05:38:24 AM) Norv: Copying manually? Just install your git repo locally instead.

(05:41:47 AM) Norv: And if you want to install it remotely, editors/IDEs can help with keeping files in sync. But there's no reason for a software like a web forum to be developed/tested only remote. Just install directly your git clone - locally. I might misunderstand you - I'm surprised this is even a question :)
(06:26:34 AM) groundup: Norv, I have no idea why I asked that question in the first place and then re-asked it. I knew exactly what I wanted to do but for some reason it was slipping my mind.

(05:13:08 AM) Norv: FOSDEM weekend, fun coming out from it. :) https://fosdem.org/2013/schedule/
(05:40:32 AM) Spuds: > Friday beer event
(05:40:33 AM) Spuds: I'll be participating :P
(05:46:45 AM) Spuds: > After about ten years of incremental improvements to our notorious Beer   Distribution Algorithm, we appear to have reached a stable version with the   algorithm used: v3.2.   We have no changes to the algorithm to announce this year, at least up to   now—if we change our mind, we will let you know you in time.
(05:46:45 AM) Spuds: Only ten years of testing ... amateurs !
(05:48:05 AM) Norv: LOL

(11:36:36 PM) emanuele: OMG make an SMF release is exhausting...
(12:16:00 AM) Spuds: Congrats on 2.04 :)
(12:16:43 AM) ***emanuele wants to see Elkarte 1.0.4

(12:19:04 AM) emanuele: still fighting with the cust site
(12:19:12 AM) emanuele: that doesn't want to show the patches...
(12:24:32 AM) Spuds: Say is the SMF 2.0 RC1 to SMF 2.0 RC1-1 the right package to download :D
(12:25:53 AM) IchBin left the room.
(12:28:48 AM) emanuele: we scared IchBin...
(12:42:01 AM) Spuds: He was probalby embarassed that he was still running RC1
(12:44:10 AM) emanuele: lol
(12:50:40 AM) Spuds: updated 3 sites, no problems :)
(12:51:00 AM) emanuele: you are very lucky! :P
(12:51:14 AM) emanuele: language packs are still broken... LOL
(12:55:38 AM) emanuele: spuds did you install the 2.0.x patch?
(01:01:22 AM) Spuds: Yes, just the patch file from the package manager
(01:01:47 AM) emanuele: dunno...got a PM from Illori saying it was wrong...
(01:01:59 AM) emanuele: but I tried it now on a forum and it worked fine...
(01:04:01 AM) Spuds: Thats what I did on 3 forums ... all were at 2.03, all with lots of mods
(01:06:47 AM) Spuds: what error did she see ? install or did it not modify the files right?
(01:08:02 AM) emanuele: No idea exactly...
(01:08:44 AM) Spuds: upgrade package as in small upgrade vs patch?
(01:09:55 AM) emanuele: as far as I understand she is talking about the patch, though the "upgrade package" is a bit odd...
(01:12:08 AM) Spuds: was just a thought, in case we were not talking about the same thing
(01:12:34 AM) emanuele: yeah, you are right
(01:12:37 AM) emanuele: I'll ask

(01:50:44 AM) Spuds: Ah well ... maybe something to do with getting it via Packman vs downloading it as a package
(01:54:11 AM) emanuele: dunno
(01:54:24 AM) emanuele: maybe just some strange sever
(01:54:36 AM) emanuele: I got an error on a free host...
(01:55:26 AM) emanuele: but since the error skip at file level didn't work I had to change the package adding error=ignore at operation level
(01:55:29 AM) emanuele: so...changing!
(01:55:40 AM) emanuele: I re-packaged the patch 5 times this evening...
(01:55:42 AM) emanuele: >_<
(01:56:31 AM) Spuds: Fun times .... Not !

(06:15:11 PM) Norv: fyi, I'm a bit busy this weekend - as these couple of days. :)
(06:21:51 PM) Spuds: no worries .... once I get a version of PBE in a branch you are going to be even busier :D
(06:22:20 PM) Spuds: and you thought SMF needed some refactoring
(06:30:03 PM) Norv: hah :D
(06:31:51 PM) Norv: so you're rewriting the mail and post subsystems :D
(06:32:20 PM) Norv: it *is* great :) - hey they needed it anyway.
(06:33:03 PM) Norv: if you're curious. https://blog.mozilla.org/it/2012/10/24/future-of-discussion-forums/
(06:33:18 PM) Norv: https://wiki.mozilla.org/Discussion_Forums/Request_For_Comment
(06:55:13 PM) Spuds: lol ... I'll leave that to you :P .... although there will be some updates to the mail and digest areas.  One of the complications (other than just dealing with email and all of its baggage) is that I seem to have to "duplicate"  some Elk queries as the PBE system is running under say the admin (for a failed or moderated email) or as the system, etc so its in a way posting on behalf of ....
(06:55:13 PM) Spuds: So I can't use some functions which simply load user_info since that would be the user_info of the emailer and not the user_info of the person or program running PBE at that time ... really a complication of the failure/moderation of them
(06:55:13 PM) Spuds: don't know if that makes sense or not ... its really that permissions / user_info dont load like loadMemberData
(06:55:13 PM) Spuds: There are ways around that but that leads to other duplicate code inside of PBE so thats messy as well ... so I picked one and we can change it around if we think another approach is better
(07:16:56 PM) Norv: Ah. If I understand correctly, duplicating the functions seems the way to go. Even if we don't like it (but considering what is here, we might), clean side by side implementation of those helps
(07:19:55 PM) Norv: Helps us see what to change them to, in worst case! :)

(07:30:02 PM) Norv: >> (12:16:43 AM) ***emanuele wants to see Elkarte 1.0.4
(07:30:02 PM) Norv: http://dent.gomertronic.com/conversation/243718#notice-380857 :-D #relevant

(11:06:05 PM) Norv: Thank you for the work on the patch emanuele
(11:07:09 PM) Norv: fyi, I've been a bit busy these days
(11:10:10 PM) emanuele: No problem
(11:10:27 PM) emanuele: I'm posting right now [...]
(11:10:58 PM) emanuele: oh: The message exceeds the maximum allowed length (%1$d characters).
(11:11:05 PM) emanuele: not sprintf'ed! :P

(06:22:02 PM) emanuele: Question of the day: what could be the reason *certain* (without any apparent correlation) things are not cached using Memcached?
(06:22:16 PM) emanuele: for example modSettings

(08:38:27 PM) Spuds: Feelings on where to place the mail functions in the admin menu
(08:38:59 PM) Spuds: today its under Maintenance, which always seemed odd to me, but it had to go somewhere
(08:39:35 PM) Spuds: as I add in the PBE stuffz there are more mail options so I was going to place them together
(08:40:10 PM) Spuds: so ? is ... shoudl I add those to the mail functions and move it to a place other than maintenace
(08:40:25 PM) Spuds: add it and leave it all in Maintain
(08:40:40 PM) Spuds: Not add it and stuff those new functions elsewere?
(08:42:01 PM) Spuds: Given the layout of the admin panel there is no wrong answer :P
(08:42:52 PM) Spuds: Maybe uner Main as Mailing List Manager
(09:39:16 PM) emanuele: There is always the search! :P
(09:40:57 PM) emanuele: if you want to re-use an existing menu...maybe feature and options or server settings (a bit odd the latter)
(09:41:52 PM) emanuele: otherwise you can just create a new menu under forum with all the email options

(09:46:31 PM) emanuele: Hey Spuds, you know something about cache didn't you? O:)

(09:49:30 PM) Spuds: Yea ... still deciding what to do ... I'll just plop in in somewhere and once I get it working decide where it fits best

(09:49:39 PM) Spuds: Whats the cache question?
(09:54:02 PM) emanuele: is there any reason why 2.0 doesn't cache modSettings? (memcached)
(09:55:58 PM) emanuele: the cache seems to work. At least most of the things are cached properly, but some not and modSettings always returns 0 bytes
(09:56:41 PM) Spuds: funny enough, thats the once cache mechanism I never tested
(09:56:54 PM) emanuele: LOL
(09:57:11 PM) emanuele: well, not a big issue
(09:57:28 PM) Spuds: does 2.1 work OK in that regard?
(09:57:32 PM) emanuele: it may even be it is killed somewhere at some point by some fancy code...
(09:57:42 PM) emanuele: no idea...can't do the conversion
(09:58:31 PM) Spuds: 2.0 has some odd things with modsettings cache, because the cache setting itself is a modsetting ... you can see the logic there yes :P
(09:59:13 PM) emanuele: mmm....
(09:59:17 PM) emanuele: have to check
(10:00:43 PM) Spuds: in 2.1 I had moved that to its own settings thing, along with which cache mechanisum was in use, so it did not need to do some convuluted logic to see if the cache was enabled  (the value of which may be cached)
(10:02:15 PM) Spuds: I really should test memcached at some point, and there are some @todo interface items needed with xcache as well (should we keep the clear cache functions as being generic vs the 2.0 file only version)
Title: Re: IRC
Post by: TestMonkey on February 10, 2013, 04:04:40 pm
(10:57:38 PM) emanuele: Spuds, about email things: http://www.simplemachines.org/community/index.php?topic=332457.0
(11:00:05 PM) emanuele: and also that may be interesting: http://www.simplemachines.org/community/index.php?topic=496641.msg3484453#msg3484453
(11:00:09 PM) emanuele: not very common...
(11:11:45 PM) Spuds: I think the mail queue could use some updates, its settings are a bit confusing, and it probalby even needs one additonal one.
(11:12:49 PM) Spuds: need to understand what limits are placed on sites and set some options for that
(11:13:20 PM) Spuds: its typical to have an hourly quota, not sure if daily quotas are set as well
(11:14:48 PM) Spuds: but a big site like that you need to not send to many at once (hard on the server),  and not send that often to avoid any quotas
(11:15:15 PM) Spuds: but the settings we have are misleading ... max per min and max per page load .....
(11:16:17 PM) Spuds: if you set that to 1 per min and 10 per page load ... thats translated to 10 per min
(11:17:45 PM) Spuds: that other issue is pretty interesting ... did that query fix things?
(12:03:43 AM) emanuele: No idea, I just posted it and I'm hoping it will fix it... :P

(11:43:35 PM) Norv: http://www.discourse.org/about/
(12:04:04 AM) Spuds: Looks interesting (discourse)
(12:19:53 AM) Norv: Yeah. I remember having read long ago a rant of the current lead dev on forums being outdated for 10 years. :D
(12:20:56 AM) Norv: Ruby and js. Interesting.
(12:24:33 AM) Norv: Almost everything http://www.discourse.org/ is right to the point
(12:44:04 AM) emanuele: https://github.com/emanuele45/Quote-to-new-topic
(12:44:20 AM) emanuele: > Reply as a linked topic
(12:45:56 AM) emanuele: TBH is not that different from a forum... :P
(12:46:10 AM) emanuele: (with AJAX (quick-)reply)
(12:46:24 AM) Norv: Nice!
(12:47:38 AM) emanuele: I know, I did it! :P
(12:48:00 AM) ***emanuele is *so* humble... O:-)
(12:49:15 AM) emanuele: oh...and do you want to revive maybe the "quick-reply" I was working on a (long) while ago?
(12:49:38 AM) emanuele: that would be nice I think... O:-)
(12:50:47 AM) emanuele: A question: action?viewquery shows the queries from the "last" page load, exactly? If I always see the queries from BoardIndex at every page load means that something else is loading the board index "in background", right?
(12:51:18 AM) Norv: last page load, yes
(12:52:36 AM) Norv: and sure, if you wish - them reply thingies are cool! :)
(12:52:49 AM) emanuele: then something weird is going on...now I have to discover what...

(12:58:12 AM) Spuds: Couple of quick thoughts as I think of possibly doing some work on the email thing again :P
(12:58:12 AM) Spuds:  -  basic lightbox for attachment images or keep the expand in place thing we have
(12:58:12 AM) Spuds:  -  infinite scroll thingy mentioned on the elk site and interestly part of discourse
(01:00:34 AM) Norv: I have mostly no opinion tbh, on infinite scroll.

(01:03:50 AM) Norv: [rant] https://github.com/discourse/core-cla/blob/master/cla.txt - the codebase is GPL v2, and they use a CLA "for your protection" :P, which explicitly gives them all rights to make proprietary and commercial licensed versions. GPL - the license that doesn't allow anyone else to make proprietary versions. #dishonesty [/rant]

(01:22:06 AM) Norv: thing is, they have something on the site, on a business model on hosting instances of Discourse for businesses. That doesn't have anything to do with the code. And, they claim something about 'Discourse will be free'. In the same time, on the other hand, grab rights to make commercial/proprietary versions from github community code.
Title: Re: IRC
Post by: TestMonkey on February 10, 2013, 04:05:50 pm
(09:13:34 PM) Norv: Sorry for the slight not-actually-here status the past week
(09:13:53 PM) Norv: how is you, and how it Elk with you? :)
(09:29:32 PM) emanuele: lol
(09:29:44 PM) emanuele: I've been somehow busy too
(09:30:40 PM) emanuele: working on upgrading warriorcats from RC3-like to 2.0.4 and try to find ways to optimize things
(09:31:37 PM) emanuele: And you? Everything fine?
(09:35:53 PM) Norv: Everything fine and wandering around a bit.
(09:53:19 PM) Norv: We should get stuff together though, for beta, asap.
(10:02:02 PM) emanuele: of course
(10:02:16 PM) emanuele: is the error class a 1.0 target?
(10:04:23 PM) Norv: I think it would be much better to have it
(10:05:14 PM) emanuele: I stopped on that because of the not being sure how to deal with attachments
(10:05:53 PM) Norv: we need *improved code* at any level, methinks. It makes sense to add our wanted features and some changes to the looks, but it's important for further work, fixes, contributions, to work towards better code
(10:06:15 PM) Norv: the second class didn't deal with it enough?
(10:07:19 PM) emanuele: yep, though there was the comment about the sub-class and I was not sure if go on with that or wait and see... O:)
(10:07:36 PM) Norv: ah, don't worry
(10:08:06 PM) Norv: for the subclass we need to see how to init in context() and I'm not sure without playing with it
(10:22:43 PM) emanuele: I think I'm trying to do too many things...even though are not so many... :(
(10:32:11 PM) Norv: choose then :D

(10:35:01 PM) Norv: fyi. I've been also looking more into future options for Elk's financial/legal options. Not that it's urgent (it isn't really), just a question sooner or later we will get to. I intend to present the options publicly.

(10:48:01 PM) Norv: afk. damn bugz.
(12:54:27 AM) emanuele: time to go bed
(12:54:30 AM) emanuele: bye!

(02:10:05 AM) Trekkie101: Norv Aaron I made codez
(02:10:40 AM) TimeVortex: Hide the children!
(02:15:10 AM) Trekkie101: I show you
(02:15:25 AM) Trekkie101: https://github.com/Trekkie101/smfdates
Title: Re: IRC
Post by: TestMonkey on February 10, 2013, 10:03:12 pm
(10:36:41 PM) Norv: you killed the template.
(10:38:00 PM) ***emanuele is innocent...
(10:38:08 PM) emanuele: what template? ???
(10:38:42 PM) ***Norv thinks emanuele is never innocent
(10:38:52 PM) Norv: unapproved_attachments :D
(10:39:07 PM) emanuele: isn't it nice? O:-)
(10:40:45 PM) ***emanuele has changed his personal text to "template killer"
(10:41:11 PM) Norv: lol

(10:42:13 PM) Norv: emanuele: do you still bring stuff from 2.1? I seem to have seen some fixes, not sure if we need them
(10:42:51 PM) Norv: I can look into them, I'm just asking if you still do that since I know you had
(10:43:44 PM) emanuele: lately I've been working on too many (too similar) codebasis and I may have forgot some...
(10:43:46 PM) emanuele: I try to
(10:44:11 PM) emanuele: but I'm not sure I cross-committed everything in the last month
(10:47:22 PM) Norv: okay, just something I need to remember to cross-check before beta

(10:48:03 PM) emanuele: About the templates, would you prefer to have more "specialized" templates by default using template_show_list and let the themers decide if they want to design a completely different template?
(10:48:29 PM) emanuele: like it was template_unapproved_attachments?
(10:48:41 PM) Norv: if it makes sense to have a differently designed template
(10:49:25 PM) emanuele: that's not something I can answer...
(10:49:37 PM) emanuele: for me 1 template is more than enough! :P
(10:50:28 PM) Norv: my preference would go for more templates indeed, when I'm not sure: but that's probably because I'm not a designer. (and you should be grateful for that!)
(10:50:39 PM) emanuele: maybe just a if (function_exists('template_' . $sub_template)) {custom} else {default}
(10:51:00 PM) Norv: I'll post the log anyway, to have those silent designers speak up, or remain without templates :D
(10:51:18 PM) Norv: and ping TimeVortex for good measure.

(10:52:12 PM) emanuele: we could just add a parameter to createList
(10:52:31 PM) emanuele: with a "custom template" and load it if exists otherwise go with the default one
(10:54:17 PM) emanuele: I know that sort of hide the template itself because people are lazy and just use what they have in front of their noses, but could be an interesting option. :P
(10:54:27 PM) Norv: that makes sense. Poor createList() takes the brunt.
(10:55:11 PM) emanuele: We will have also to document all that crap!!! LOL
(10:55:18 PM) Norv: it seems the same kind of extra option that we'd have with eventual named sections to add stuff to
(10:56:11 PM) Norv: Of course lol. Nice and 'how to' style, and per ways to, as well as what
(10:56:53 PM) emanuele: ...mmm...why not just use the list id?
(10:58:14 PM) Norv: use it how?
(10:58:28 PM) emanuele: as (sub-)template name
(10:58:33 PM) emanuele: I think I didn't cross-commit the reworking of boardindex in layers
(10:59:36 PM) emanuele: if (function_exists('template_' . $listOptions['id'])) { $context['sub_template'] = $listOptions['id']; }
(11:00:25 PM) Norv: ah. Maybe... It'll be only one. Oh and in that case you want me to check the list names too for the naming patterns! :P
(11:00:39 PM) emanuele: lol
(11:00:40 PM) ***Norv likes consistency
(11:01:02 PM) emanuele: that would be nice too, and if you do it, I wouldn't complain. :P
(11:01:53 PM) Norv: yessir. I also promise some misses to be sure :D
Title: Re: IRC
Post by: TestMonkey on February 12, 2013, 12:24:27 am
(11:25:01 PM) emanuele: my only opinion about MPL is that is too long to read...
(11:33:08 PM) Norv: lol... It's a known issue, that we need CC licenses for software :D
(11:33:41 PM) Norv: with all the package, human readable version included of course.

(11:37:11 PM) emanuele: do you keep an eye on the bug reports board?
(11:37:17 PM) Norv: no
(11:37:58 PM) emanuele: http://www.simplemachines.org/community/index.php?topic=497147.0 (http://www.simplemachines.org/community/index.php?topic=497147.0)
(11:38:03 PM) emanuele: http://www.simplemachines.org/community/index.php?topic=497137.0 (http://www.simplemachines.org/community/index.php?topic=497137.0)
(11:38:09 PM) emanuele: http://www.simplemachines.org/community/index.php?topic=497135.0 (http://www.simplemachines.org/community/index.php?topic=497135.0)
(11:38:24 PM) emanuele: that may (or may not) be of interest
(11:46:00 PM) Norv: Thanks! The first - did Spuds see it? I think it's correct (strange), I'd need to check
(11:46:22 PM) Norv: mail headers
(11:48:12 PM) emanuele: don't know, I didn't see him in a few days


(11:52:12 PM) Norv: https://github.com/Spuds/Elkarte/commit/17f3574b8f72e033999bec75f9b731bf7bc97801 (https://github.com/Spuds/Elkarte/commit/17f3574b8f72e033999bec75f9b731bf7bc97801)
(11:57:11 PM) emanuele: O_O
(11:57:55 PM) Norv: ^^ That!!


(11:19:53 PM) Norv: http://www.rants.org/2008/03/06/thread_theory/ (http://www.rants.org/2008/03/06/thread_theory/) btw, for fun and interest - and for chat log.
(11:27:01 PM) Norv: that's from 2008, and there is *still* no real forum-email interoperability. Spuds will make Elk do the awesome thing.

(11:27:28 PM) Norv: have you tried the branch, emanuele?
(11:28:16 PM) emanuele: nope...
(11:29:26 PM) emanuele: Am I dumb or the Profile code looks flexible but is a rather monolithic piece of marble?
(11:33:49 PM) emanuele: github UI is quite crappy...
(11:34:07 PM) ***emanuele is in complain mode
(11:35:15 PM) emanuele: what do you think about having a field somewhere to store the email-id? O:-)
(11:35:38 PM) Norv: yes the Profile code is not cool
(11:38:55 PM) Norv: I don't know about email-id... is this how we relate email and post?
(11:40:13 PM) Norv: you know, the convo mode in PMs, is yet another piece which does the kind of job described in the blog: figure out and build the convo from messages. it's probably one of the most terrible areas code-style-wise
(11:41:08 PM) Norv: it's a similar algorythm with what a web interface to a mailing list does
(11:42:38 PM) Norv: if you have suggestions as alternative to some of the services (or all, for that matter) to github, say so :)
(11:45:25 PM) Norv: initially I wanted gitorious, but tbh it's more (much more) terrible and limited than github; for less experienced coders it matters imo. And SMF didn't (well, doesn't) have a development community, so funnily enough, user-friendly was a criterium high in the list *pro* github. *headscratch*
(11:55:10 PM) emanuele: email-id: sorry, I wanted to say Message-ID, that way it could send emails back with a proper In-Reply-To and clients would be able to thread them properly
(02/12/2013 12:01:19 AM) emanuele: GUI: never mind, I just don't like most of the GUIs out there...(and I'm not good at design them)
Title: Re: IRC
Post by: TestMonkey on February 12, 2013, 06:46:13 am
(01:36:40 AM) emanuele: I did my part a long while ago updating simpledesk to "barely work" with 2.1 (it installs and works, just the editor is not nice to see)
(01:41:41 AM) emanuele: barely related: do we like SD at Elk?
(01:42:16 AM) emanuele: ...anyway for after beta
(01:43:11 AM) emanuele: [bugz] Another topic that may be of interest about legacy code that can be removed: http://www.simplemachines.org/community/index.php?topic=493558.0 (http://www.simplemachines.org/community/index.php?topic=493558.0)
(01:48:40 AM) Norv: ah, yes, I remember that
(01:51:58 AM) Norv: not necessary
(01:52:44 AM) Norv: On SD: I don't think so, not that I see.
Title: Re: IRC
Post by: Antechinus on February 12, 2013, 07:24:40 am
I kinda like the idea of condensing the menu, but we don't need the legacy code.
Title: Re: IRC
Post by: TestMonkey on February 13, 2013, 05:11:38 pm
(10:51:59 PM) ***emanuele is killing some other templates! :D
(11:05:30 PM) emanuele: I think sooner or later I will try to create a forum around createList...
(11:05:32 PM) emanuele: lol
(11:05:37 PM) emanuele: https://github.com/emanuele45/Dialogo/commits/crazy_thing
(11:05:54 PM) emanuele: (branch name is just BS)

(12:26:16 AM) Norv: ...I was fighting octopress, under certain umm, beer-driven circumstances. Beer - octopress 0 - 1.
(12:30:29 AM) emanuele: LOL
(12:30:37 AM) emanuele: interesting this octopress...
(12:34:31 AM) Norv: it's cool lol

(12:37:33 AM) Norv: >> (11:05:30 PM) emanuele: I think sooner or later I will try to create a forum around createList...
(12:37:33 AM) Norv: hah, you still don't know this is what we do here? :D
(01:03:28 AM) emanuele: lol

(01:31:50 AM) Norv: http://xkcd.com/963/

(02:00:47 AM) trekkie101: Did you see my terrible code earlier this week?
(02:07:41 AM) Norv: I took a look :D
(02:09:44 AM) Norv: I just looked quickly. But, you made more?
(02:12:19 AM) Norv: LOL! http://xkcd.com/612/
(02:12:53 AM) Norv: I had forgotten that dialog haha
(02:15:26 AM) trekkie101: Lmfao that's good and no :( I had a free afternoon and a long time ambition had been to try some code :p might aswel try sometime
(02:27:04 AM) Norv: sure thing, and cool :D
(02:27:18 AM) Norv: Ema needs more competition.
Title: Re: IRC
Post by: TestMonkey on February 16, 2013, 08:53:28 pm
(06:40:20 PM) Norv: morning Spuds
(07:10:51 PM) Spuds: See I made it :D
(07:55:49 PM) Norv: Found your way, huh? :P
(08:27:53 PM) Spuds: I took a moment and pushed the latest updates to the site

(08:28:44 PM) ***emanuele goes try move topics
(08:28:44 PM) emanuele: :D
(08:29:54 PM) Spuds: LOL
(08:30:02 PM) ***emanuele failed... :(
(08:30:08 PM) Spuds: blame Norv
(08:30:17 PM) emanuele: As usual :P
(08:30:27 PM) Norv: Oops? I thought there was something with split topics
(08:30:59 PM) Spuds: We could change all of our Die, hacking attempt to ... Blame Norv :P
(08:31:23 PM) Norv: Yay! :D
(08:31:39 PM) emanuele: LOL
(08:31:46 PM) emanuele: +1
(08:32:13 PM) ***Norv feels like a celebrity :P
(08:33:37 PM) Spuds: The error log says .... .    The database value you're trying to insert does not exist: disregarded
(08:33:38 PM) Spuds: Function: markTopicsRead
(08:33:47 PM) Norv: Haha.
(08:34:19 PM) Spuds: but since there is no query in the log ... that means its failing to cast ...
(08:34:44 PM) Norv: I'll take a look in the debugger. Because actually - yes it seems so
(08:35:01 PM) Spuds: so we have a null value we are trying to stuff in the disregared value
(08:35:53 PM) emanuele: Ahhhh...I think I got it
(08:36:30 PM) emanuele: SELECT lmr.id_member, lmr.id_msg, t.id_topic, lt.disregarded
(08:36:33 PM) emanuele: should be
(08:36:35 PM) emanuele: SELECT lmr.id_member, lmr.id_msg, t.id_topic, IFNULL(lt.disregarded, 0)
(08:36:59 PM) emanuele: Topics.subs.php
(08:37:11 PM) Norv: Anyone interested to add NULL handling to $smcFunc ?
(08:40:06 PM) Spuds: How would we do it ... just by default? ... That insert is failing on the isset check since its null value .
(08:40:14 PM) Spuds: Seems like Ema has the fix there
(08:44:56 PM) Norv: perhaps somewhere before preg_replace_callback() in smf_db_query()
(08:46:36 PM) Norv: No... smf_db_insert() with the checks
(08:46:55 PM) Spuds: just assume nulls should be 0 (in the insert)
(08:51:13 PM) Norv: it depends on the data type though
(08:52:03 PM) Norv: i.e. empty string '' , empty array of ints, strings
(08:52:58 PM) Spuds: true ....
(08:56:26 PM) Norv: only the assumption '0' would make some cases better I suppose, but it could also create some subtle bug when the type is accepted but value '0' inappropriate
(08:58:41 PM) Spuds: Maybe just a better error message
(09:39:44 PM) ***emanuele says something heretic: why not drop the entry if null and rely on the default?
(09:39:47 PM) ***emanuele runs
(09:58:20 PM) Spuds: I thought about that to .... but thought its probaly nicer to catch the error before it goes to the db .... but maybe just let the db deal with it
Title: Re: IRC
Post by: TestMonkey on February 16, 2013, 09:51:31 pm
(10:11:58 PM) emanuele: what about remove "Manage" from all the files in /admin/?
(10:13:34 PM) Norv: I thought about it... not sure. Add Languages.controller.php, or, replace Manage with: Languages.admin.php ?
(10:15:34 PM) emanuele: no preferences...just seems a bit dumb have all the "Manage*.php" when everything else has been moved to *.something.php

(10:16:44 PM) emanuele: found another missing global! :P

(10:16:58 PM) emanuele: We really need to move to constants or something. O:)
(10:17:12 PM) emanuele: is it constants good?
(10:17:53 PM) Norv: yes
(10:17:56 PM) emanuele: A while ago Spuds was pointing out that $librarydir can be a bit weird because there is also a dir called /lib/
(10:18:55 PM) emanuele: $sourcedir => SOURCE?
(10:19:05 PM) emanuele: $sourcedir => SOURCEDIR?
(10:19:05 PM) Norv: SOURCES ?
(10:19:23 PM) Norv: I'd kinda incline to SOURCEDIR :D
(10:20:11 PM) emanuele: at least it's one less to type... :P
(10:20:53 PM) Norv: as for lib: so, LIBRARYDIR for /lib (formerly /subs, for subs and class files) and have external libraries in EXT /ext
(10:21:27 PM) Norv: SUBSDIR would be odd, huh?
(10:21:44 PM) emanuele: ahh...didn't noce
(10:21:48 PM) emanuele: well, it's the same
(10:22:13 PM) Spuds: +1 Constants +1 names with DIR since thats what they are
(10:24:23 PM) Norv: Just enough to cut off the inconsistencies, would be SUBSDIR. Preferable?

(10:26:10 PM) Norv: emanuele: editors/IDEs recognize constants (well many of them editors), so there :D
(10:26:36 PM) Spuds: real programers use vi :P
(10:26:55 PM) ***Spuds is not a real programmer
(10:27:28 PM) ***emanuele uses kate...
(10:27:30 PM) emanuele: :P
(10:27:37 PM) Spuds: emacs
(10:28:30 PM) Spuds: norv uses neural interface
(10:28:39 PM) emanuele: lol

(10:29:32 PM) Spuds: SUBSDIR seems fine to me
(10:30:44 PM) emanuele: now I have just to figure out how to make Elk write a proper Settings.php with the define :P
(10:33:08 PM) Norv: upgrade will grumble too
(10:35:54 PM) emanuele: yep
(10:38:07 PM) emanuele: wondering, what about hooks?
(10:39:11 PM) emanuele: I'm still not sure what will be the final state of add-ons, if "confined" in a directory?
(10:39:15 PM) Norv: what issue in particular about hooks?
(10:42:00 PM) emanuele: replace the dir
(10:42:04 PM) emanuele: in the string
(10:42:34 PM) emanuele: is it fine to have 'BOARDDIR/myfile.php'?
(10:42:48 PM) emanuele: yeah, should be enough...
(10:43:10 PM) Norv: Ahh. Yes that too
(10:44:55 PM) Norv: I was thinking to add auto loading of files with certain name patterns from addondir but that shouldn't influence the rest
Title: Re: IRC
Post by: emanuele on February 17, 2013, 01:00:41 am
IMHO the solution is the way to go, I'm just not sure $dirs is of any use for mods/addons, so might as well define paths directly in Settings.php.
https://github.com/elkarte/Elkarte/pull/137

Too late to think about it again... :o
Title: Re: IRC
Post by: TestMonkey on February 17, 2013, 01:13:17 am
IMHO the solution is the way to go, I'm just not sure $dirs is of any use for mods/addons, so might as well define paths directly in Settings.php.
https://github.com/elkarte/Elkarte/pull/137
Too late to think about it again... :o
Yes, TE's choice of index.php is better since the effect is the same and it's not complicating Settings.php. :)

(12:30:59 AM) emanuele: will we allow to change also controllerdir, subsdir, etc. or just sourcedir?
(12:31:09 AM) emanuele: (I think only sourcedir, but better ask)
(12:43:52 AM) Norv: good question
(12:44:24 AM) emanuele: well, right...constants are constant and we, just at the end of settings.php are trying to change them...
(12:44:43 AM) emanuele: so maybe handle them as variables in Settings.php and define them at the end?
(12:48:30 AM) Norv: I can't see a very good use case for separate locations of subs, controllers, etc, those in sourcedir, perhaps except lib (the external lib)
(12:50:46 AM) Norv: correction: surely except /lib: I think this should be easy to change. Thinking that for linux packaging we might need different locations and/or changes
(12:50:56 AM) emanuele: yep, that was my reasoning too
(12:51:08 AM) emanuele: I think I'm going to define the constants in index.php
(12:52:44 AM) Norv: should work and avoid too fluffy Settings
(12:54:32 AM) emanuele: should we unset the variables or just ignore them?
(12:55:58 AM) Norv: unset
(12:56:23 AM) ***Norv doesn't like lazy globals around

(12:56:59 AM) Norv: thinking to change languagedir too ?
(12:57:12 AM) Norv: this was the last remaining
(12:57:57 AM) Norv: at least, I'd add languagedir to the list, even unused yet
Title: Re: IRC
Post by: TestMonkey on February 17, 2013, 01:14:11 am
(01:42:21 AM) emanuele: https://github.com/emanuele45/Dialogo/tree/dir_to_const
(01:43:01 AM) emanuele: at least now Norv will not miss any global! :P (dir related O:))
(01:47:01 AM) Spuds: LOL ... you know thats just so much cleaner looking and robust
(01:47:34 AM) ***emanuele can't find the discussion...
(01:47:46 AM) Norv: you're trying to win through such low means
(01:48:09 AM) emanuele: >:-D

(01:48:19 AM) Norv: mind if I merge this one without testing? You tested it after all :D
(01:48:27 AM) emanuele: ...
(01:48:32 AM) emanuele: are you sure I tested it?  O:-)
(01:48:45 AM) Norv: ohwell, fine!
/me checks out the PR.
(01:49:20 AM) emanuele: well...up to you :P
(01:56:29 AM) Spuds: Norv just wants to cover up any more missed Globals .... die('Blame Ema');
(01:58:11 AM) Norv: psst. Why did you tell?
(01:58:37 AM) Norv: ok... it seems to be working

(02:01:51 AM) emanuele: now I have to remember what I was working on before... lol
(02:02:04 AM) Norv: ban edit O:-)
(02:02:58 AM) emanuele: uhhh....
(02:03:05 AM) emanuele: I forgot about that one...
(02:03:18 AM) emanuele: nope, I was playing with the post page
(02:04:05 AM) emanuele: to allow adding new things above and below the post area (there is already around a branch)
(02:04:05 AM) Norv: ah nice :)
(02:05:24 AM) emanuele: I was just trying to find a balance between support thousands of possible alternatives and the bare minimum
(02:05:55 AM) emanuele: you know when I start adding bits I continue until is basically impossible to read the code...
Title: Re: IRC
Post by: TestMonkey on February 18, 2013, 02:49:58 pm
(06:19:27 AM) Spuds: Before I forget this ....
(06:21:16 AM) Spuds: function attachmentChecks  ...... has some checks up front that set errror = ..... looks like an extra rrrrrrrrrrrr in that errrrrrror ...
(06:22:34 AM) Spuds: trying to use that function for some attachment checks so stumboled accross it
(06:28:18 AM) Spuds: stumboled .... say I like making up words,, thats a keeper
Title: Re: IRC
Post by: emanuele on February 18, 2013, 04:48:19 pm
Where is feature cat? :P
Title: Re: IRC
Post by: TestMonkey on February 18, 2013, 04:53:10 pm
/me takes a look around.
It's sleeping in the attic, hah.
Title: Re: IRC
Post by: TestMonkey on February 19, 2013, 05:51:24 pm
(07:16:04 PM) Trekkie101: OMG the elkarte logo is up
(07:16:12 PM) Trekkie101: There be a moose in the hoose!
(07:18:59 PM) emanuele: I don't like it *so* much, though I don't have anything better...
(07:22:37 PM) Trekkie101: At least you get little teddy versions
(07:22:45 PM) Trekkie101: Possibly with tshirts!
(07:27:57 PM) ***emanuele wants two!

(07:34:18 PM) Spuds: Norv ... another attachment thing before I forget
(07:35:08 PM) Spuds: $txt['attach_check_nag'] is in Post.english and needs to be in Errors.english since its only used with a fatal_lang_error
(07:37:34 PM) Norv: Yessir. /tries to pay attention :D
(07:39:25 PM) ***Norv will re-read this log, to see if there's something to address. Right now, focused on governance/licensing/elk/smf stuff.
(07:42:34 PM) Spuds: Just making a note, still working on PBE so have a lot going on in my head ....
(07:42:34 PM) Spuds: glad Elk was ahead of SMF in your comment ;)
(07:43:58 PM) Trekkie101: haha good catch

(07:59:30 PM) emanuele: Spuds, let me know when you update the site code so I'll try again the move function! O:-)
/me gets a blank page on Elk site.
(08:07:24 PM) Norv: looks like somebody updated the site...
(08:07:31 PM) Norv: but not Settings.php ?

(08:11:02 PM) Spuds: > emanuele: Spuds, let me know when you update the site code so I'll try again the move function! O:-)
(08:11:02 PM) Spuds: Just did it
(08:11:44 PM) emanuele: YAY!
(08:11:46 PM) emanuele: Works!
(08:12:44 PM) ***emanuele wonders if the settings for the redirection topic should be saved in session just like the destination board

(08:24:22 PM) Spuds: Cool that move worked ... no errors in the log due to that (just a few for when I pulled the rug out during the change O:-), fun with test sites!)

(09:28:58 PM) Norv: Haha @ all the moves
(09:31:33 PM) ***emanuele has moved just some, not all... O:-)

(12:25:54 AM) ***Norv is old and slow.
(12:28:09 AM) emanuele: if you are old what should Spuds say? :P
(01:42:13 AM) Spuds: At least have the decency to type in all CAPS so I can hear you :P

Title: Re: IRC
Post by: TestMonkey on February 19, 2013, 05:52:40 pm
(01:54:55 AM) Spuds: @norv ... Forgot your password reminder function seems to be broke
(02:23:03 AM) Spuds: not sure if it was just some testing on your part or other ... since its not in the array, its looking for 'Reminder_Controller' 
(02:42:30 AM) Norv: ohh. ok, fixing

(03:55:57 PM) ***emanuele is stuck deciding if it is better to use a callback or use just a standard function style everything consistently...
(03:56:23 PM) Trekkie101: Flip a coin :P
(03:57:49 PM) emanuele: Norv, a question: does it still make sense to keep the poll template in its own file? (now that I changed it to a sub_template)
(04:02:13 PM) emanuele: Trekkie101> Flip a coin :P
(04:02:19 PM) emanuele: I think I'll do both :P
(04:02:41 PM) Trekkie101: Tough decisions can usually be made by a coin flip :P
Title: Re: IRC
Post by: TestMonkey on February 19, 2013, 05:53:13 pm
(04:32:23 PM) Spuds entered the room.
(04:34:58 PM) Trekkie101 left the room.
(04:59:20 PM) emanuele:  Spuds you scared Trekkie... :(
(05:04:16 PM) Spuds: He's just frightened of old people :P

(05:08:47 PM) emanuele: What do you think about remove the "new poll" button and instead have it inside the post page link an option?
(05:34:29 PM) Norv: emanuele: makes some sense, but I think people won't find it :D - we're too used to make a poll; usually you come to the board with the intention to make a poll, not to write a post and add later...
(05:35:24 PM) Norv: "I want to make a poll" vs. "I want to write about x topic, and I think I'll add a poll to it"
(05:38:53 PM) Trekkie101: Polls could also do with better integration, like be part of a post par example
(05:38:59 PM) Trekkie101: Topic: Cycling
(05:39:29 PM) Trekkie101: Been thinking of cycling along the northwest pass this weekend, anyone want to come along?
(05:39:40 PM) Trekkie101: Yes [XXXXXXX ]
(05:39:53 PM) Trekkie101: No [XX ]
(05:41:07 PM) emanuele: Though if you start with a topic and while writing it you realize you want to add a poll you have to post it and then add the poll...
(05:41:31 PM) emanuele: maybe both options? O:-)
(05:41:59 PM) emanuele: (and the "new poll" just a parameter in the url that shows the same post page with the box expanded?
(05:58:16 PM) Norv: if it tempts ya. :)

(05:59:47 PM) Norv: >> (03:57:49 PM) emanuele: Norv, a question: does it still make sense to keep the poll template in its own file? (now that I changed it to a sub_template)
(05:59:47 PM) Norv: IMHO, yes. Definitely, I'd prefer we keep things separated in implementation/files/structure, for a feature like polls.
(06:00:23 PM) Norv: (and separate some of the implementation, more, from action_post() code)
(06:01:38 PM) Norv: (same for subs dedicated more to polls and everything about them; give or take some inter-relations)
(06:03:56 PM) Norv: These options on polls seem nice to have; if you feel they don't clutter the interface, it'd be handy I suppose
Title: Re: IRC
Post by: TestMonkey on February 19, 2013, 06:35:15 pm
(06:35:29 PM) emanuele: https://github.com/emanuele45/Dialogo/compare/extend_post
(06:35:37 PM) emanuele: ugly in several ways
(06:37:21 PM) emanuele: though it should be a bit more flexible than now

Anyone has some time to make a code review?
Title: Re: IRC
Post by: emanuele on February 19, 2013, 07:02:39 pm
Just a small warning: it's not yet finished: drafts will go into it either and the PMs page should be changed the same (or similar) way. O:-)
Title: Re: IRC
Post by: TestMonkey on February 21, 2013, 06:31:55 am
(06:20:24 PM) emanuele: How important is to have queries not sliced in pieces and passed as arguments of functions? (I'm currently thinking at things like sort in createList)
(06:21:30 PM) emanuele: for example: https://github.com/emanuele45/Dialogo/blob/banEdit/sources/admin/ManageBans.php#L167
(06:52:44 PM) Spuds: I'd ask as opposed to what?
(06:55:11 PM) Norv: that is problematic
(06:55:42 PM) Norv: would it be possible to have that sort in the functions list_xxx() ?
(06:56:33 PM) Norv: as opposed to 'no sql in random params, and/or no sql in controllers functions', Spuds, I believe
(07:00:44 PM) emanuele: since we are talking about controllers/subs and this kind of things and was thinking if it isn't better to have queries "in one block" and not potentially spread all over the places
(07:01:31 PM) emanuele: well...all over the places is maybe a bit exaggerate... O:-)
(07:01:32 PM) Norv: yes... but what is a reasonable option for that sort?
(07:02:10 PM) Norv: because it's different for any columns
(07:02:20 PM) emanuele: a small array in list_getXxx?
(07:02:51 PM) Norv: yes, but then, the way you use it (the resulting code in controller, where you create the options for the list), is it still readable?
(07:03:01 PM) Norv: when all sorts are separated? I'm not sure.
(07:04:15 PM) emanuele: I'm not really sure the way to sort things is a problem of the array that you send to createList...
(07:05:09 PM) emanuele: I mean: createList has to know what column you want to sort, but then it's list_get that has to know how to sort the query
(07:05:31 PM) Norv: Right.
(07:09:41 PM) Norv: it may result in less reusability for list_get() but that is not a problem, it's a good thing: list_xxx() are supposed to be 'attached' to the controller anyway. They're more the design of the code than anything else.
(07:27:35 PM) Spuds: My comment was in line with whats the proposal thats better, thats all ... those may not be ideal but not clear to me what the better mousetrap is ... I can barely remember all the nuances of createlist as it is now.
(07:29:03 PM) emanuele: oh, now I got it. Well...when it comes to "good code design/practices" you should not ask me... O:-)
(07:31:44 PM) Spuds: Well I figured since you are Mr. CreateList you were going to make a proposal, did not realize it was just a question O:-)
Title: Re: IRC
Post by: TestMonkey on February 21, 2013, 06:33:21 am
(07:32:30 PM) Spuds: Now a question .... are we supposed to use loadAdminClass and loadController ?
(07:34:27 PM) Spuds: loadAdminClass is used quite often, maybe made more sense before we went to constants ... can't see loadController in use at all (yet) ...
(07:35:13 PM) Spuds: or loadLibrary() ?
(07:35:33 PM) Spuds: even though its not longer the library
(07:38:33 PM) Norv: it's better for the core software to use directly constant + file
(07:39:03 PM) Norv: for performance, and it isn't problematic
(07:41:12 PM) Norv: my thought was mainly to keep them available for addons, integrations; and, perhaps, we would at some future version update them to look for a library (for example) in more locations, e.g. in /subs and in /addonsdir. But not for us
(07:43:40 PM) Spuds: So in general just use require_once(CONSTANT . 'bla/de/bla') ? (sorry brain working slow this AM)
(07:43:57 PM) Norv: That's what I'd do.
(07:44:24 PM) Spuds: Good ... that means I don't have to change anything :D

(07:44:52 PM) Spuds: do we want to change the loadAdminClass calls back as well ?
(07:56:47 PM) Norv: do we have a constant for admin dir?
(08:18:34 PM) emanuele: nope
(08:18:41 PM) emanuele: or yes?...
(08:22:00 PM) emanuele: nope
(08:22:10 PM) emanuele: only cache, board, source, subs and controller
Title: Re: IRC
Post by: TestMonkey on February 21, 2013, 06:39:40 am
(10:49:12 PM) emanuele: Norv, Spuds: https://github.com/eurich/Elkarte/commit/73963f59ada51f3e493e9ea815fe8291fcdae9f5
(10:49:51 PM) Norv: emanuele: https://github.com/eurich/Elkarte/commit/5e72ee3a7c1757c7de9c600458614bfd212add3d
(10:50:49 PM) emanuele: lol
(10:51:10 PM) emanuele: did you comment on the old PR?
(10:51:14 PM) Norv: yes :)
(10:51:17 PM) emanuele: I didn't get the notifications...
(10:51:27 PM) emanuele: stupid github...
(10:52:01 PM) emanuele: well...then let's define also ADMINDIR and get rid of that function too... O:-)
(10:52:03 PM) emanuele: no?
(10:52:11 PM) Norv: Go ahead. Minimalists. :P
(10:54:05 PM) emanuele: the less is there, the less I can break. :P

(11:52:28 PM) emanuele: the install logo is still the "old" one
(11:52:49 PM) Norv: ah sorry. Blame Norv. :P
(11:53:19 PM) emanuele: No need to tell, I always blame you. :P
(11:53:28 PM) emanuele: (or Spuds)
(11:56:24 PM) emanuele: don't merge it yet, I'll throw in some fixes for the installer and upgrade
(11:59:17 PM) Norv: how about TE's?
(11:59:50 PM) emanuele: there are just three missing, though everything else seems fine
(11:59:59 PM) emanuele: I mean he missed to remove them

(02/21/2013 12:01:59 AM) ***Norv thinks emanuele should set himself up a gravatar, like them fancy people do. :P
(12:02:37 AM) emanuele: the installer is quite broken... lol
(12:02:44 AM) emanuele: (with constants I mean)

(12:19:52 AM) emanuele: and what about languagedir?
(12:20:08 AM) emanuele: you mentioned it few days ago but don't remember
(12:20:12 AM) emanuele: the details
(12:22:09 AM) Norv: I was proposing to define languagedir. Even if we're not using it yet, because I think this is yet one of those that should be customizable (i.e. on linux distribs)
(12:22:57 AM) Norv: I didn't move /languages in /sources, as I've threatened Ant a while ago, still if we work to make it customizable it will still be, imho, better

(12:39:37 AM) Norv: speaking of this, emanuele: sources, ext, board, lang, should be in settings
(12:40:20 AM) Norv: thinking that an installer should be able to change them there. the rest can be in index
(12:50:46 AM) emanuele: at the moment there is board, sources, subs, controller, admin
(12:51:02 AM) emanuele: subs, controllers, admin make not much sense I think
Title: Re: IRC
Post by: TestMonkey on February 21, 2013, 10:32:36 pm
(07:39:49 PM) emanuele: Norv: https://github.com/SimpleMachines/SMF2.1/pull/298/files#L0R1269
(07:39:52 PM) emanuele: any opinion?
** Norv takes a look.
(07:40:11 PM) ***emanuele takes a break
(07:40:32 PM) Trekkie101: NO BREAKS POLICY in this company
(07:41:03 PM) emanuele: really? How can I be there then? I always break everything! :P

(08:24:36 PM) Norv: emanuele: to me, those extra-php checks look like ugly code. If it really is so insignificant, I wouldn't continue making them.
(08:24:48 PM) ***Norv is not a performance freak.
(09:18:38 PM) ***emanuele neither...
(09:19:05 PM) emanuele: I'll remove them since all those checks are very ugly. :P

(09:19:26 PM) ***emanuele is also going to fetch MAS commit. :P
(10:16:10 PM) Norv: hacking attempt stuff?
(10:17:57 PM) emanuele: nope, I wanted to fetch the PR she closed...
(10:19:19 PM) Norv: Ah. Well you still can I think. But those casts should be removed
(10:19:47 PM) emanuele: yep, I was already planning to remove them O:-)

(10:21:46 PM) Norv: https://gist.github.com/piscisaureus/3342247
(10:22:54 PM) emanuele: cool stuff!!
(10:23:10 PM) ***emanuele copies it to his bookmark topic
(10:24:06 PM) ***Norv wonders how will emanuele bookmark his bookmark topic
(10:24:42 PM) ***emanuele knows it is there and hope the forum will not go down for any reason!

(10:40:02 PM) emanuele: did you ask because you want the hacking attempt stuff?
(11:20:56 PM) Norv: yes, actually
Title: Re: IRC
Post by: TestMonkey on February 21, 2013, 11:06:01 pm
(11:33:01 PM) emanuele: there are also some errors that use the same "hacker attempt", should that be changed too?
(11:44:45 PM) Norv: I thought you removed unapproved_attachments subtemplate...
(11:45:26 PM) Norv: imho, no: from case to case, maybe some are closer to a real warning trigger
(11:46:07 PM) emanuele: I don't have it...why?
(11:46:27 PM) Norv: https://github.com/Spuds/Elkarte/commit/a35bad121ee8532f6750072dbf375acb7999c8c2#L2R499
(11:47:27 PM) emanuele: I can't find it my repo
(11:48:15 PM) Norv: Template killer. Spuds doesn't suspect you.
(11:48:36 PM) ***emanuele whistles innocently
(11:48:46 PM) emanuele: I think it's gone *a long* time ago
(11:49:58 PM) emanuele: oh...no, just 10 days...
(11:50:09 PM) ***emanuele 's memory is terrible...
(11:52:20 PM) Norv: hah
Title: Re: IRC
Post by: TestMonkey on February 23, 2013, 05:45:44 pm
(04:42:51 PM) Norv: lol... http://svenpet.com/2013/02/21/dont-use-git/

(05:13:19 PM) ***emanuele is trying to understand how joomla login works...
(05:13:27 PM) emanuele: not funny. I think I got how registration works
(05:31:13 PM) emanuele: why any login function calls parent::login!! :'(
(05:33:21 PM) emanuele: ! :P Found what I was looking for

(06:16:02 PM) Norv: I broke github.
(06:16:09 PM) ***Norv is happy with the achievement.
(06:16:31 PM) Norv: https://github.com/norv/elkarte :D
** the Github response: 500 Internal Oops. **
(06:17:15 PM) Spuds: You need to learn to use github for windows :P
(06:19:26 PM) Norv: Not my fault! Github broke when I tried to access the repo from svn
(06:20:13 PM) Norv: It messed up the repo on *their side*, not mine, hah

(04:57:05 PM) emanuele: Norv http://www.simplemachines.org/community/index.php?topic=498146.0
(05:01:01 PM) Norv: Cool!
(05:09:06 PM) Norv: Hmm. I've never grasped this flat file idea.
(05:10:59 PM) Norv: You query the database anyway, at each page load. So might as well retrieve the buttons. And, as emanuele pointed out on hooks, the always-over-used $modSettings can act like a cache (to save an extra query for them).

(06:49:09 PM) Norv:    'menu_enable_icons' => 1=0,
(06:49:23 PM) Norv: install_db.php in Kays mod
(06:49:32 PM) Norv: this ain't right
(06:51:34 PM) emanuele: it's because of a discussion we were having about updateSettings that don't set empty variables if they don't exist
(06:52:00 PM) emanuele: Kays doesn't like to have them unset, so he is using this workaround
(06:59:31 PM) ***Norv doesn't understand
(07:00:06 PM) emanuele: updateSettings(array('my_setting' => 0));
(07:00:18 PM) emanuele: if my_setting doesn't exist it is not created
(07:01:15 PM) Norv: this is then intended to be 1==0 ?
(07:01:34 PM) emanuele: ahhh... maybe a typo
(07:05:14 PM) Norv: hmm, and you're right, but then it doesn't set the setting for false either
(07:05:46 PM) emanuele: yep
(07:06:30 PM) Norv: so what is the workaround? I don't see any, apart from updating twice
Title: Re: IRC
Post by: TestMonkey on February 23, 2013, 05:46:22 pm
(07:18:59 PM) ***emanuele would love to have a "loadElkBasic" that does all the require and loadSomething necessary to have Elk functions and db connection available...
(07:55:50 PM) Norv: Write it. :) It's kinda SSI.php initialization. But yes, it's slightly more

(08:06:27 PM) emanuele: Joomla plugin for SMF and Elk :P auth works! :D
(08:08:46 PM) Norv: yay? where is it?
(08:08:59 PM) emanuele: on my pc right now
(08:09:00 PM) Norv: license?
(08:09:12 PM) emanuele: duuuuno...
(08:09:19 PM) Norv: to be inline with joomla, if it uses its API, I think it should be GPL.
(08:09:27 PM) emanuele: I used the basic joomla code as template...does that matter?
(08:10:09 PM) Norv: reusing the code matters only if you reuse enough to be a derivative of the code... But I thought it interacts with joomla API too?
(08:10:24 PM) Norv: or does it use the database directly for auth
(08:10:56 PM) emanuele: it extends the jPlugin class
(08:11:03 PM) emanuele: so API I'd say
(08:11:22 PM) emanuele: but then "inside" it uses $smcFunc to query the db
(08:12:30 PM) Norv: GPL.
(08:13:20 PM) Norv: (according to Joomla and SFLC, afaik. No one really knows the extent of GPL, but that's why the project expresses their official stance.)
(08:13:29 PM) emanuele: now I have to make it work from SMF too
(08:15:05 PM) Norv: (in my personal opinion, external stuff, i.e. plugins, should be GPLish just fine if they're only GPL-compatible licensed. But this isn't the case of Joomla, nor some of the interpretations of GPL.)
(08:15:40 PM) emanuele: anyway joomla is ugly.
Title: Re: IRC
Post by: TestMonkey on February 23, 2013, 05:47:17 pm
(09:37:25 PM) Spuds: https://github.com/Spuds/Elkarte/pull/new/PbE
(09:37:26 PM) Spuds: Have fun, should be rich with errors and mistakes
(09:37:53 PM) Norv: wow!
(09:38:46 PM) Norv: what are the problems?
(09:38:49 PM) Trekkie101: PBE is going to be pretty cool
(09:39:30 PM) Norv: Teh coolness. We need all testing we can get, to make it work as best as possible
(09:40:58 PM) Spuds: Its the testing and email (in general) that are the problems .... And I added some complexity since I decided to support markdown in/out for the plain text version.
(09:41:35 PM) Trekkie101: Whats the requirements, profile with email address in it to post?
(09:41:39 PM) Spuds: I did not add in html output since thats just another black hole of email of sorts
(09:42:38 PM) Spuds: I still have to add in the install and upgrade tables and changes

(09:43:36 PM) Spuds: This explains some of it https://github.com/elkarte/Elkarte/wiki/Maillist-Feature
(09:44:29 PM) Spuds: But to use it (user and board permissions aside), you can simply reply to an notification email (topic/post/pm) and it will post it just like you did it from the forum
(09:45:15 PM) Spuds: each email that it sends has a security key tied to the notificaition, so the reply must have that key, they key must have been sent to that email, etc
(09:45:36 PM) Spuds: this makes it very hard to spoof / spam with a reply
(09:46:05 PM) Spuds: New topics are a bit more of a problem, but there is an option to moderate all new topics by email
(09:46:25 PM) Spuds: This is because there is no security key, so its vunerable to spoofing
(09:47:21 PM) Trekkie101: Impressive documentation
(09:47:22 PM) Trekkie101: Kudos
(09:47:57 PM) Spuds: But you can start a new topic with a reply but changing the subject (also an option) that is secure but the new topic will go in the same board, you don't get a choice in that .. (you do get that choice doing it the pure new topic route)
(09:49:08 PM) Spuds: Glad you liked the docs :) .... I'll add some more, like filter and parser examples that people can use
(09:49:23 PM) Trekkie101: They are very extensive actually!
(09:49:29 PM) Trekkie101: Im reading through them now
(10:01:27 PM) Norv: I'm at loss of words. Spuds would please make it a PR (more visible) or topic in the boards on the branch
(10:05:56 PM) Spuds: Let me get the install/upgrade stuff in place and I'll make a PR ... do note I have a debug function in there ATM which writes the emails to a file, obvisly that will need to be completly removed at beta
Title: Re: IRC
Post by: TestMonkey on February 23, 2013, 05:48:28 pm
(09:50:18 PM) Trekkie101: The other day, were you guys talking about proper notifications in Elk?
(10:01:49 PM) Norv: Trekkie101: what is more proper? :)
(10:02:43 PM) Trekkie101: Like I post, you reply, I see a notification of it?
(10:02:52 PM) Trekkie101: Like next page refresh sorta thing
(10:09:37 PM) Norv: Trekkie101:  I don't think so. (not sure where in the UI, either) Propose exactly the behavior in an issue to file?
(10:10:17 PM) Trekkie101: You want me to file it as an issue? Also Facebook-esque
(10:21:00 PM) Norv: Yes, please lets use the issue tracking, for features of relevance discussed in convos. (apart from irc or forum). So a notification somewhere, on any page, that a reply was posted?

(10:58:11 PM) emanuele: http://www.simplemachines.org/community/index.php?topic=498122.msg3496216#msg3496216
(11:12:49 PM) Norv: nice! thanks
(11:14:40 PM) emanuele: Probably the WP bridge is a better starting point...
(11:17:38 PM) emanuele: http://custom.simplemachines.org/mods/index.php?mod=3008
(11:18:16 PM) Norv: https://github.com/norv/Wordpress-SMF

(05:47:04 PM) Norv: emanuele: http://custom.simplemachines.org/mods/index.php?mod=2800 is CC-BY-ND-NC. That's a non-open/free license (and extremely so). Also, CC licenses are not OSI approved, anyway, even the free licenses subset of them (CC-BY and CC-BY-SA), because they're not for software.
(05:47:30 PM) Norv: Just noting. Saw a topic by Bugo I believe.
(05:49:59 PM) emanuele: the js library is under a "MIT-style" license apparently
(05:50:03 PM) emanuele: http://codemirror.net/LICENSE
(05:50:38 PM) emanuele: Bugo is the one that created the mod, so if *he* is committing it it should be fine
(05:51:17 PM) emanuele: and I suppose the mod is just include the library into the header, so nothing *so* copyrightable anyway...
(06:01:22 PM) Norv: I looked a bit but wasn't sure
(06:01:57 PM) Norv: if he commits on github, under the policy, though, yes.
Title: Re: IRC
Post by: TestMonkey on February 25, 2013, 01:26:17 am
(10:38:18 PM) emanuele: http://www.mnhockeyhub.com/page/show/52394 :P

(10:30:17 PM) Norv: emanuele: opinions? https://github.com/elkarte/Elkarte/pull/152
(10:39:58 PM) emanuele: No strong opinions, the avatar is a bit boring, that's all
(10:50:52 PM) Norv: Hmm... we could pick another, from a set of avatars... what was that one you folks chose
(11:12:43 PM) emanuele: It can be changed at any time, it doesn't break anything. :P

(11:21:49 PM) emanuele: So, in the end the "good" form is:
(11:21:51 PM) emanuele: call_integration_hook('integrate_messageindex_buttons', array(&$context['normal_buttons']));
(11:22:11 PM) emanuele: with the & and within an array
(11:22:16 PM) emanuele: good to know
(11:24:28 PM) emanuele: and setting the pass-by-ref on the function without it set on hook generates another error
Title: Re: IRC
Post by: TestMonkey on February 25, 2013, 01:28:41 am
(01:25:04 AM) groundup: You're eventually going to move from $context, right? https://github.com/elkarte/Elkarte/wiki/Architecture
(01:36:39 AM) emanuele: Are we? Dunno...Norv knows these things...or Spuds.
(01:38:58 AM) Norv: No, I don't foresee it, nor real advantages. I am not a fan of $context, but for the necessary in templates it fits the purpose and is expected. And more importantly, we're not making an object oriented model.
(01:39:40 AM) groundup: Oh
(01:43:19 AM) Norv: I follow in a way (well, a way of) an architecture path which leads to a specific combination of object orientation with procedural parts. OOP model is not among them. :) Our in-progress .subs files do much of that job, and most will probably remain procedural.

(05:14:36 PM) Spuds entered the room.
(05:18:57 PM) emanuele: Hey Spuds-mail! :P
(05:19:47 PM) Spuds: lol
(05:20:15 PM) Trekkie101 entered the room.
(05:22:02 PM) Spuds: Hey trekkie, saw your issue report, thanks for putting it on github, its been discussed a few times on the site
(05:22:50 PM) Spuds: I'll take some time today and put in an update to see what we like ...
(05:28:02 PM) Trekkie101: I tried searching Spuds but everything has daft topic names :P
Title: Re: IRC
Post by: Trekkie101 on February 25, 2013, 01:29:54 am
(10:30:17 PM) Norv: emanuele: opinions? https://github.com/elkarte/Elkarte/pull/152
(10:39:58 PM) emanuele: No strong opinions, the avatar is a bit boring, that's all
(10:50:52 PM) Norv: Hmm... we could pick another, from a set of avatars... what was that one you folks chose
(11:12:43 PM) emanuele: It can be changed at any time, it doesn't break anything. :P
Default avatars! :D
Title: Re: IRC
Post by: TestMonkey on February 25, 2013, 01:33:29 am
(02:30:50 PM) Trekkie101: I miss timestamps on posts :(
(02:34:12 PM) Trekkie101: OH they exist as a hover message
(02:34:17 PM) Trekkie101: But not on iPad
(02:53:13 PM) TimeVortex: Yeah, I miss them too.
(02:53:37 PM) TimeVortex: I like how the 'last edited' timestamps appear the top, though.
(02:53:54 PM) TimeVortex: Would like to see the regular timestamps in that spot, too.
(02:57:20 PM) Trekkie101: Seems odd not having them, even a shrunken version to reduce clutter
(02:57:38 PM) Trekkie101: 24/2/13 @ 12:57pm
(02:58:48 PM) TimeVortex: "Two days ago at 12:57pm"
(02:58:51 PM) TimeVortex: "Seven hours ago"
(02:59:06 PM) TimeVortex: Having a full date('r') on hover
(02:59:44 PM) Trekkie101: Something though :P
(02:59:57 PM) Trekkie101: I may go try and commit it back in somehow :P

(07:15:31 PM) emanuele: YAY!
(07:15:56 PM) emanuele: It's a bit of a PITA create users from an external application into SMF/Elk using the "correct" functions...

(08:15:52 PM) Trekkie101 entered the room.
(08:49:46 PM) Norv: a Trekkie101! *runs with some stolen artefact of sorts :P*
(09:15:32 PM) Trekkie101: lol?
(09:15:36 PM) Trekkie101: Bring it back!
(09:28:14 PM) ***Norv has ran away and doesn't hear :P

(09:38:09 PM) emanuele: http://www.simplemachines.org/community/index.php?topic=498122.msg3497137#msg3497137
(09:38:29 PM) emanuele: users created/deleted in Joomla are copied over at SMF
(09:38:59 PM) emanuele: now the other: users created/registered in SMF moved to joomla.
(09:39:19 PM) emanuele: and finally everything to Elkarte! :P
Title: Re: IRC
Post by: TestMonkey on February 25, 2013, 01:43:39 am
(10:27:10 PM) Trekkie101: anyway im heading out then early bed for early work tomorrow, updated some of the wiki earlier
(10:27:20 PM) Norv: great, thanks
(10:27:31 PM) Trekkie101: :) see the about page

(09:40:42 PM) emanuele: BTW: can we get rid of any isAllowedTo, allowedTo, fatal_lang_error and fatal_error in subs? :P
(09:41:14 PM) emanuele: or at least give a way to override them without having to rely on tricks like set $user_info['is_admin']
(09:41:30 PM) emanuele: (or are these tricks valid?)
(09:47:57 PM) Norv: emanuele: I thought they're essential functions, and I don't know the problem with tricks?
(10:26:15 PM) Norv: emanuele: for an old and slow brainz (i.e. mine) could you point out some code with the problem/trick?
(10:31:12 PM) emanuele: https://github.com/emanuele45/joomla_bridge/blob/master/smf2.php#L42
(10:34:42 PM) emanuele: the problem there is that the groups are not in-synch
(10:35:07 PM) emanuele: I'm not completely sure if this is good TBH
(10:35:18 PM) emanuele: though it's where I am at the moment
(10:36:01 PM) emanuele: (and I'm not even sure the joomla user is logged in into SMF, that's why I don't loadUserSettings etc.
(10:47:41 PM) Norv: Ahh... I remember, err. No, I don't remember - have you seen how the mediawiki bridge plays around with the issues on SMF auth?
(10:47:59 PM) emanuele: lol
(10:48:20 PM) emanuele: I think it doesn't...
(10:48:49 PM) emanuele: WM simply takes the user from the SMF db and brings it to MW
(10:49:09 PM) emanuele: sort of what I did with the joomla auth plugin (not yet at github)
(10:51:32 PM) Norv: Okay... As a general idea, I think you're on a great track here, and we *should* simplify auth, integrations/bridges are your great way to find what you need it to do
(10:51:49 PM) Norv: but I'm not sure about how you set over there, $user_info admin...
(10:52:14 PM) Norv: that doesn't seem right at all. Why exactly is it necessary, what doesn't work?
(10:52:54 PM) emanuele: isAllowedTo in deleteMembers
(10:53:50 PM) emanuele: https://github.com/emanuele45/Dialogo/blob/master/sources/subs/Members.subs.php#L60
(10:53:55 PM) Norv: Oh. So you need a .subs function which doesn't do permission checks.
(10:55:10 PM) Norv: This is true (but I didn't always see how to rewrite some of the existing functions): we should have .subs functions without permission checks or at most some parameter to set, to say "buzz off, don't"
(10:54:23 PM) emanuele: or a way to overrided permission checks
(10:54:53 PM) emanuele: allowedTo would be fine
(10:55:15 PM) emanuele: because it returns true/false but doesn't try to log you in
(10:55:45 PM) emanuele: no, I'm stupid, there problem is always there.. lol

(10:56:38 PM) Norv: deleteMembers() has $check_not_admin, can't you use it?
(10:56:58 PM) emanuele: that is used to check if the user you are deleting is an admin or not
(10:57:26 PM) Norv: ah, spoke too soon. I thought it was that... okay.
(10:57:42 PM) emanuele: me too... lol
(10:58:00 PM) emanuele: (I mean I thought it was that, but when I used it I discoverd it was something else)

(10:58:41 PM) Norv: the way would be, to write .subs utility functions, more granular maybe, which do the job without asking who'z you.
(10:59:03 PM) Norv: and separate them carefully by name (and/or params) from the others, those with checks

(10:59:41 PM) Norv: IMO. I don't see how we can otherwise overwrite isAllowedTo()... well I do see, but I'm not sure it isn't too odd
(10:59:56 PM) emanuele: lol
(11:06:56 PM) Norv: Well in theory, if you really want, we can play games with OOP: have a Permissions class for isAllowed() and friends, and a subclass of it, for use in such cases (and which doesn't do the job). But the switch back and forth (the 'real' permissions checks and the 'fake' ones) doesn't smell right, nor safe... Or a similar trick, a variable to set, to know that isAllowed() will bypass the 'real' check. But again, trickish. I feel I'm listing them only to see how bad they smell... IMO.

(11:08:46 PM) Norv: If I see this right (looking quickly at the code), the isAllowed() calls in deleteMembers() are only at the beginning of the function. So we can rewrite this quickly
(11:11:09 PM) emanuele: the funny thing is that in registerMember I just had to use an "interface" SMF doesn't know to skip the checks
(11:11:41 PM) emanuele: the only thing left is just the IP registration that is taken from $user_info if the interface is not admin
(11:14:50 PM) Norv: we should be able to put at your disposal simple utility functions, which do exactly the main operations on user auth/manage: register, delete, login this guy and log him out, stuff. As backend functions (=without permissions checks)
(11:16:45 PM) Norv: At most, with a param (when it's a bit too much to refactor otherwise for now)

(11:46:14 PM) Norv: thanks for grumbling about deleteMembers() emanuele. There's a serious issue here...[...]
(11:55:53 PM) ***Norv broke deleteMembers() happily, and will submit a PR :)
Title: Re: IRC
Post by: TestMonkey on February 25, 2013, 01:47:09 am
(11:52:54 PM) ***emanuele is changing Elkarte's color scheme for his own forum O:-)
(11:59:12 PM) Norv: Elk forum wants an experimental color scheme too, selfish.
(02/25/2013 12:31:10 AM) TimeVortex: I suggest mauve.
(12:34:14 AM) ***emanuele needs a lot of yellow...
(12:44:47 AM) Norv: Mauve?? *shoots TimeVortex with fire*
(12:44:57 AM) TimeVortex: >:)

(12:45:30 AM) TimeVortex: On a serious note, I liked the grey site theme that SimpleMachines.org sported in the very beginning.
(12:45:40 AM) TimeVortex: I probably have it somewhere, still.
(12:45:55 AM) TimeVortex: Looks a bit daft these days though, probably. ;)
(12:45:58 AM) Norv: Ahh I remember something...
(12:46:35 AM) Norv: There was something very easy and pleasant about it. I don't think I have it though, just for fun even.
(12:46:49 AM) TimeVortex: http://web.archive.org/web/20050929112304/http://www.simplemachines.org/community/index.php hnnng not quite there

(01:12:11 AM) emanuele: do you have any plan for the useless seo thing?
(01:13:37 AM) Norv: If you're asking me (which you shouldn't), nope. Trekkie, who's been hiding, maybe.

[...]
(01:19:24 AM) ***Norv bumps ema on the head. Take that! :D
(01:25:47 AM) ***emanuele takes the beer out of Norv's hand. Enough for today.
(01:30:33 AM) Norv: Pfft. Mean.

(01:40:37 AM) Norv: Say, what if Elk would look kinda like this: http://gnome-look.org/content/show.php/Milke?content=23687
(01:41:49 AM) ***Norv hopes you won't all do what Ema just did. *MY* beer!
(01:42:29 AM) emanuele: gnome is ugly... :P
(01:44:13 AM) Norv: Can't argue with that

(01:44:00 AM) emanuele: Spuds! use_click_menu O:-)
(02:26:00 AM) Spuds: You tested what is on the site or is this some other menu?
Title: Re: IRC
Post by: TestMonkey on February 25, 2013, 03:27:38 am
(03:00:16 AM) Trekkie101: bug on install
(03:04:54 AM) Trekkie101: SUBSDIR is never initialised
(03:55:07 AM) Trekkie101: Sent a pull request
(03:55:18 AM) Trekkie101: But it looks like its being removed purposefully?
(03:55:22 AM) Trekkie101: extdir instead?
(03:57:17 AM) Norv: Both: SUBSDIR is for our subs files, and EXTDIR for the external libraries we include
(03:58:22 AM) Norv: Thanks for the PR! I'm pulling it locally to see, I wonder if perhaps it should be initialized sooner (not sure)
(03:58:57 AM) Trekkie101: Ill commit the Settings.php one too then
(04:02:04 AM) Trekkie101: Those were the two that gave me trouble
(04:02:23 AM) Norv: It looks like you're right: it's a good place in install (well it could be sooner but doesn't seem relevant)
(04:03:43 AM) Trekkie101: Nothing seems to call it before then anyway.
(04:04:06 AM) Trekkie101: In Settings.php, its possibly in the wrong place, should prob be above languages
(04:04:11 AM) Norv: Trekkie101: I think you were right the first time, sorry about that! My fault.
(04:04:18 AM) Norv: Yes
(04:06:21 AM) Norv: We didn't want too many in Settings.php, to keep it to the minimum (only the strictly necessary). Because you don't want (I assume) to change SUBSDIR on your installation, and only those you will want to change, or it makes sense to change for your installation, are in Settings
(04:07:29 AM) Trekkie101: Makes sense then :)
(04:10:49 AM) Norv: So, install will have to deal with it, like you did initially. Sorry for the hesitation I had (I'm not yet familiar myself with what we did lol!)
(04:11:16 AM) Trekkie101: Thats ok :P both PR's are there, just smack back the settings one and keep the install
(04:13:54 AM) Trekkie101: This time im really off to bed!
(04:15:47 AM) Norv: Nighty! :D And thanks!
(04:17:20 AM) Trekkie101: welcome :) it was stopping my install
Title: Re: IRC
Post by: TestMonkey on February 26, 2013, 12:45:23 am
(11:31:52 PM) emanuele: http://img10.imageshack.us/img10/514/screen91b.png
(11:32:02 PM) ***emanuele should not do this kind of things... lol
(11:33:10 PM) Norv: oh hah nice site :D
(11:34:09 PM) emanuele: just removing everything... O:-)
(11:34:50 PM) emanuele: it's a bit too bright probably
(11:35:04 PM) Norv: some greyish and fadeouts would do so nicely
(11:35:22 PM) ***Norv shares opinions on design. Time to run.
(11:36:30 PM) emanuele: at the moment the base is #fefefe, I'll try something a bit more grey

(11:39:31 PM) ***Norv says something about the review of error classes going so slowly. So tired, trying to keep attention up (where's the coffee)
(02/26/2013 12:12:24 AM) Norv: this is great Ema
(12:12:36 AM) Norv: we'll have some fun with them
(12:14:44 AM) emanuele: I'm not sure I fixed CurveClassic...
(12:16:25 AM) emanuele: oh...and I forgot I created a js "something" to handle the errors "live"... lol
(12:16:33 AM) emanuele: I have to remember how it works
(12:26:12 AM) Norv: As you see fit. If the PR addresses the issues noticed however, I think it's ok for this part. (...though admittedly there can be many I missed since I reviewed only live)
(12:34:38 AM) Norv: It might be a good idea to document for developers the error classes and intended js O:-)
(12:37:10 AM) emanuele: yeah...well...I'm changing it right now because it wouldn't work with the editor... O:-)
(12:39:00 AM) emanuele: and also I think it's a bit dumb at the moment because I have to re-declare the class for each "box" I want to check...
(12:39:05 AM) emanuele: not sure it makes sense

(01:22:37 AM) Trekkie101: Where did the site go :?
(01:31:44 AM) Norv: did you say site? what site? :D
(01:32:07 AM) ***Norv thinks that Spuds applies emanuele's fixes on the site...
(01:41:37 AM) emanuele left the room (quit.).
(01:42:38 AM) Norv: :( I didn't mean it...
Title: Re: IRC
Post by: TestMonkey on February 26, 2013, 08:12:32 pm
(03:54:02 PM) Trekkie101: Norv sent you some comments on GitHub, hopefully they'll show up in your notifications
(05:11:58 PM) emanuele entered the room.
(05:41:40 PM) Trekkie101: emanuele I have evidence of Norv making bugz
(05:47:29 PM) emanuele: HIDE IT!!
(05:47:34 PM) emanuele: I have to win! :P
(05:47:42 PM) Trekkie101: I commented on it to point it out :P

(09:03:50 PM) Norv: Trekkie101: thanks for the review! I fixed your issues, is it better now?
(09:04:16 PM) Trekkie101: Yup!
(09:04:36 PM) Norv: :D I am catching up!
(09:04:43 PM) Trekkie101: I've been spending a lot of time trying to learn a fair bit more about the code, an easy way I've found is watch some of the commits
(09:04:59 PM) Trekkie101: Sometimes I see tiny little things :P
(09:05:19 PM) Trekkie101: Also if I see an error/syntax error from a dev build, I try and fix it before calling wolf :P
(09:08:55 PM) Norv: Yup! There's a great thing about code reviews, and more eyes on the code. There's always an extra chance small or big issues will be noticed by a different pair of eyes :)
(09:09:42 PM) Trekkie101: heading home, cya soon!
(09:09:46 PM) Norv: and to be fair, github does a pretty good job with the diff
(09:09:55 PM) Norv: take care! and thanks again! :D
Title: Re: IRC
Post by: TestMonkey on February 27, 2013, 10:02:08 pm
(07:22:58 PM) Spuds: https://github.com/SimpleMachines/SMF2.1/pull/296
(07:22:58 PM) Spuds: https://github.com/SimpleMachines/SMF2.1/pull/230
(07:22:58 PM) Spuds: Both are around improving membergroup icon stuff ... the first is just a basic pulldown, the second maybe a bit to much ...
(07:22:58 PM) Spuds: Any interest in doing things along those lines for Elk?
(07:26:55 PM) emanuele: the first one looks interesting, I think it would make sense to have
(07:29:13 PM) emanuele: 2nd one...dunno...it would probably be nice to be able to upload several things
(07:31:21 PM) emanuele: I would throw in everything. :P (and MOAR! But maybe that's more for Feature Cat! :P )
(07:31:51 PM) Spuds: That feature cat is crazy !
(07:31:58 PM) Spuds: must be from all the carbs
(07:32:08 PM) emanuele: cats are crazy
(07:32:21 PM) Spuds: :D
(07:33:18 PM) Spuds: I like the upload and presentation view of the second ... not sure about all the drag/drop stuff, tis nice but not sure how may gotchas there may be
(07:37:26 PM) emanuele: autolinking of reply would be nice too...
(07:37:47 PM) emanuele: #5 => link to reply number 5
(07:44:06 PM) Spuds: good idea
Title: Re: IRC
Post by: TestMonkey on February 27, 2013, 11:08:17 pm
(11:07:45 PM) emanuele: Norv are you around?
(11:08:07 PM) Norv: yes
(11:08:11 PM) Norv: or I claim to :)
(11:09:05 PM) emanuele: https://github.com/emanuele45/Dialogo/blob/master/sources/admin/ManageMembergroups.php#L586
(11:09:12 PM) emanuele: $temp_boards
(11:09:32 PM) emanuele: am I dumb...well I am so it's not really a good question, but let's pretend I'm not
(11:09:40 PM) emanuele: am I dumb or is completely useless?
(11:10:45 PM) emanuele: it's just initialized, assigned, rounded around and ignored completely...
(11:11:31 PM) Norv: Err... yes
(11:11:45 PM) emanuele: ohhh...now I see, it was used just in one other case in search.controller pretending it was useful for themes...
(11:13:14 PM) Norv: and there's a usage in profile too
(11:13:38 PM) emanuele: yep, but for the same reason
(11:13:52 PM) emanuele: and is not used in any template apparently
(11:14:11 PM) Norv: and the code was just copied to managemembergroups
(11:14:17 PM) emanuele: so it should be just another compatibility thing...
(11:14:33 PM) ***emanuele goes drop everything

(11:16:20 PM) Norv: it's board_columns which is supposed to be useful *tries to read the code* :D
(11:16:48 PM) emanuele: yep
(11:16:58 PM) Norv: alternate board columns...
(11:17:38 PM) Norv: my first reflex would be to take all common code, make a utility function, which can be used to send to the template this info
(11:19:08 PM) emanuele: that's what I was doing O:-)
(11:19:22 PM) emanuele: but I was trying to return the result
(11:19:42 PM) emanuele: and have board_columns too seems a bit useless...
(11:21:38 PM) Norv: the end result is supposed to be board_columns, though, right?
(11:22:07 PM) emanuele: nope
(11:22:21 PM) emanuele: only 'categories' is used
(11:23:15 PM) Norv: the end result of temp_stuff-processing, for the template, I mean
(11:23:42 PM) Norv: (yes, not used in current templates, and supposed to be available for other themes)
(11:23:57 PM) emanuele: ahhh...okay, yes
Title: Re: IRC
Post by: TestMonkey on February 27, 2013, 11:08:46 pm
(11:25:15 PM) Norv: let me put it this way: do you think it would be worthwhile to: make a file (or more) with helper functions for templates. Which are *only* extra-processing of the data which is sent anyway to templates. But 'helpers', available so that the template doesn't have to write it itself
(11:25:56 PM) emanuele: eheheh that may look nice, I think
(11:26:30 PM) Norv: this is the case here, for what I can see (and it's by far not the first): apart from the contextual data itself, the core controllers/subs make extra-processing to the data and add to context extra-results, only so that themes don't have to repeat common operations on that data
(11:26:32 PM) emanuele: but I'm probably not the best person to ask... O:-)
(11:30:13 PM) Norv: sounds like 'template helper' functions to me... not sure about the rest (i.e. where to add them, how to "expect" templates to use them... i.e. should we call them or let interested theme call them for extra-context initializations; but you were doing that so O:-))
(11:33:03 PM) emanuele: well...I was not doing the helper thing... :P
(11:34:44 PM) emanuele: https://github.com/emanuele45/Dialogo/commit/ae389acf2ca261d16be877670e110000b0ec2e78
(11:33:57 PM) Norv: what would you expect: if you theme, and you remember that documentation of Elk told you that you can haz boards sorted in alternate columns (or something). Would you find it 'natural' to call a function which returns you those boards columns in arrays; or, call a function which adds to $context for you some ['board_columns']; or, expect there are 'board_columns' already processed even if you weren't using them
(11:36:08 PM) emanuele: well, that depends on the documentation
(11:36:20 PM) emanuele: and how it is written. :P
(11:36:25 PM) Norv: haha
(11:36:39 PM) Norv: I thought the documentation depends on the code to document :D
(11:37:44 PM) emanuele: unless it's outdated or badly written ;D
(11:37:54 PM) emanuele: lol
(11:39:42 PM) Norv: yup. There's very little developer/designer documentation for this codebase. OK, well, I think personally I prefer the first two (no extra processing until you want and call it in some way). I wonder if that means it would be better to have such helpers in... well not in theme... but in some place
(11:40:19 PM) emanuele: LOL
(11:40:32 PM) Norv: O:-)
Title: Re: IRC
Post by: TestMonkey on February 27, 2013, 11:10:46 pm
(11:41:48 PM) emanuele: Is it okay Board.subs.php for that function?
(11:42:08 PM) Norv: well........ not really...
(11:42:14 PM) emanuele: lol
(11:42:35 PM) emanuele: wait you mean the helper or the function I put there now?
(11:43:39 PM) Norv: I mean the helper. It's not backend, it's one of those cases which go beyond even your prepareXxxContext() stuff - very close to prepare but even more tied to the view than that...
(11:43:59 PM) Norv: Your function is fine!

(11:44:26 PM) Norv: (except that it uses $context O:-))
(11:46:28 PM) Norv: Correction: it didn't intend to use context sorry! I just glanced at a use, that's all (https://github.com/emanuele45/Dialogo/commit/ae389acf2ca261d16be877670e110000b0ec2e78#L3R1080)
(11:55:36 PM) emanuele: it's broken anyway...
(11:55:38 PM) emanuele: lol
(11:55:44 PM) emanuele: I'm fixing it now
(02/28/2013 12:00:11 AM) Norv: thanks for that! hey please note that you is currently on your master branch. You know you'll hate me when I might cherry pick, and you end up with a needless messy merge. O:-)
(12:04:28 AM) emanuele: I know, I was about to branch for another thing, but got caught by all these repetitions... O:-)
(12:04:42 AM) emanuele: now should work a bit better
(12:05:42 AM) Norv: just to be clear: I think you're right that function doesn't need board_columns stuff. Only categories. We're just talking two different things here. :) The allboards() is great, and will have a very nice readability/code design result. If and what we can do with the extra-board columns stuff, is another thing
Title: Re: IRC
Post by: TestMonkey on February 27, 2013, 11:45:59 pm
(12:16:21 AM) emanuele: action_ignoreboards now is very nice! :D
(12:19:01 AM) TimeVortex: http://www.elkarte.net/index.php?action=profile;area=ignoreboards
(12:19:04 AM) TimeVortex: Unable to load the 'action_ignoreboards' template.
(12:19:07 AM) ***TimeVortex smirks
(12:19:16 AM) TimeVortex: I suppose I should test locally.
(12:23:59 AM) Norv: Err... I must have missed a subtemplate loading
(12:27:05 AM) emanuele: fixed the template and another bug too

(12:30:59 AM) TimeVortex: By the by
(12:31:04 AM) TimeVortex: THANKS for adding the dates back in
(12:31:39 AM) TimeVortex: I have some minor issue with it in terms of semantics now, though:
(12:32:02 AM) TimeVortex: Currently (shortened obv.): "<a>Reply #71 - on:[/url] February 23, 2013, 10:47:17 am"
(12:32:04 AM) Norv: thank you emanuele! /me is slow
(12:32:48 AM) TimeVortex: My wish (shortened again): "<a>Reply #71[/url] on February 23, 2013, 10:47:17 am" OR "<a>Reply #71[/url] &emdash; February 23, 2013, 10:47:17 am"
(12:32:57 AM) TimeVortex: &emdash; being —
(12:33:21 AM) TimeVortex: But you lot are probably all using a monospace font, so it will appear less wide than it actually is.
(12:34:15 AM) ***emanuele likes 2nd version
(12:34:24 AM) emanuele: &emdash;
(12:35:07 AM) Norv: Ah I see. Cool, thanks!
(12:35:09 AM) emanuele: just to avoid Ant's rants about "on today/yesterday"  :P
(12:35:15 AM) TimeVortex: The only gripe I have with it, is that you can't read it aloud.
(12:35:22 AM) TimeVortex: Oh, yes, that is actually a great advantage.
(12:35:25 AM) Norv: :D
(12:35:46 AM) TimeVortex: Chances are you'll be getting feature requests for timestamps like "two days ago" and the likes, though. :P
(12:36:06 AM) Norv: pretty sure
(12:38:12 AM) TimeVortex: ;)

(12:38:26 AM) ***TimeVortex kind of misses some sort of build ID in the version number.
(12:38:40 AM) TimeVortex: Now I can't see when the site was last updated. :P
(12:39:32 AM) ***TimeVortex notices he still has 0 posts on Elkarte.net
(12:40:55 AM) emanuele: I think a couple of days ago...
(12:41:10 AM) Norv: ah okay, I will do something like that - build versioning
(12:41:54 AM) Norv: Spuds keeps it very often updated
Title: Re: IRC
Post by: TestMonkey on February 27, 2013, 11:46:54 pm
(12:12:07 AM) Norv: http://www.elkarte.net/index.php?topic=215 the best solution?
(12:13:50 AM) emanuele: +1 for css I think

(12:25:11 AM) Norv: hey TimeVortex: opinion on tradeoffs here? http://www.elkarte.net/index.php?topic=215
(12:26:12 AM) TimeVortex: Norv: all for the CSS-based solution.
(12:26:45 AM) TimeVortex: At the time it was left like this because of the copy-paste argument; a CSS-based solution won't cripple copy-pasting and will work without JS.
(12:27:04 AM) TimeVortex: (Of course, older browsers will bork on it, but I'm guessing you're not supporting those anyway.)
(12:28:24 AM) ***Norv says something hardly intelligible about how good it is to be around them performance freaks. :)
(12:28:38 AM) Norv: Ah I see. Thanks :D
Title: Re: IRC
Post by: TestMonkey on February 28, 2013, 03:08:56 am
(01:12:48 AM) TimeVortex: Norv: heh, looks like my </a>'s were replaced with [/url]'s http://www.elkarte.net/index.php?topic=134.msg1495#msg1495
(01:12:54 AM) TimeVortex: Possibly an editor bug?
(01:13:51 AM) emanuele: nope
(01:13:54 AM) emanuele: that's parse_bbc
(01:14:04 AM) emanuele: (preview without js enabled)
(01:14:51 AM) TimeVortex: A known one, I gather?
(01:16:32 AM) emanuele: mmm...locally works fine
(01:16:45 AM) emanuele: ???
(01:24:13 AM) Norv: it works as <a> in my browser

(01:35:41 AM) Spuds entered the room.
(01:44:58 AM) Norv: A Spuds! Right after I posted som'thing unorthodox about parse_bbc()...
(01:45:09 AM) Norv:  I always knew he was using custom scripts to monitor the site :P
(01:50:00 AM) Spuds: What did I do now :P
(01:50:33 AM) Spuds: Anyone else getting the Sorry, this tree took too long to generate.   On the github site when using the files tab?
(01:51:03 AM) Norv: Yep
(01:51:35 AM) Norv: you broke github. After markdown libs sometime it happened :D
(01:51:48 AM) Spuds: Strange ... also I just updated that menu PR that had ghost conflicts .....
(01:51:56 AM) Spuds: LOL ... maybe that is it !
(01:52:39 AM) Norv: I should write to github if it doesn't get solved. Probably too lazy tonight but I might do so later.
(01:53:41 AM) Spuds: I'm still probably going to re-write a simplier / limited func version of markdownify anyway .... its a bit heavy for what we need ....
Title: Re: IRC
Post by: TestMonkey on February 28, 2013, 03:09:42 am
(01:58:03 AM) Norv: On a different note... What if we consider markdown support for 2.0-3.0+, in the editor?
(02:00:41 AM) TimeVortex: Dropping bbc altogether? ;)
(02:03:36 AM) Norv: would that be desirable, TimeVortex? 'Tis a serious question!
(02:08:12 AM) TimeVortex: It would make upgrading a nightmare, methinks.
(02:08:35 AM) TimeVortex: Many people use bbcode with no markdown equivalent
(02:08:52 AM) TimeVortex: (custom bbcode, if nothing else)
(02:12:12 AM) Norv: there isn't much other option than to support those without equivalent... Dunno, I can't imagine just dropping support
(02:14:06 AM) Norv: but on the other hand, I think bbc poses more problems for interoperability, for any federation of content with other applications
(02:14:18 AM) Trekkie101: Over time though, WYSI will replace it though
(02:15:05 AM) Trekkie101: So your backend could really be anything :P
(02:15:47 AM) Norv: front/middleware of sorts, rather :)
(02:32:47 AM) Norv: TBH Trekkie101 I don't think wysiwyg will replace a good ole' lightweight language
Title: Re: IRC
Post by: TestMonkey on February 28, 2013, 03:14:02 am
(01:12:48 AM) TimeVortex: Norv: heh, looks like my </a>'s were replaced with [/url]'s http://www.elkarte.net/index.php?topic=134.msg1495#msg1495

Ohwait, now I see it.

test [/url] yup
Title: Re: IRC
Post by: TestMonkey on February 28, 2013, 09:05:21 pm
(05:25:46 AM) Norv: Spuds: markdown and markdown.class are two versions of the same library
(05:27:16 AM) Norv: I'm not sure why: it looks like you may have upgraded in the meantime, and actually use one of them, right?
(05:52:26 AM) Spuds: who knows what I did there :P ... markdown.php should be deleted and markdown.class renamed to markdown (its the 1.0.1p version, the latest from github)
(05:53:56 AM) Norv: okay :D
(05:56:37 AM) Spuds: I think at one point I was renaming to our .class.php things, but then backed away from that with the ext files ... and what you see is the result !
(05:56:45 AM) Spuds: I'll make a quick PR to fix that
(05:59:31 AM) Norv: No need, I did it
(05:59:51 AM) Norv: it didn't help github love our repo again...
(06:04:33 AM) Spuds: cool ... I'm going to do some testing on that p version since I must have been on the o version and did not even know it DOH!
(06:05:34 AM) Norv: haha

(09:51:15 PM) Norv: I talked to github folks to fix the main page of the repo. They acted in a matter of minutes.
(09:52:16 PM) emanuele: cool!
(09:52:22 PM) emanuele: so it was broken?
(09:52:45 PM) emanuele: We broke even github!! Not only code!!
(09:52:55 PM) emanuele: YAY!
(09:57:44 PM) Norv: Yes, yes, we did. Twas on their side. :D
Title: Re: IRC
Post by: TestMonkey on March 04, 2013, 07:06:40 pm
(09:56:34 PM) emanuele: Norv? Question if you are around: https://github.com/emanuele45/Dialogo/blob/master/sources/subs/Post.subs.php#L541
(09:56:48 PM) emanuele: Why?
(09:57:04 PM) emanuele: Since the query is then LIMIT 1?

(04:12:42 PM) emanuele: Hey Norv, what do you think of the "updateAnything"? lol
(04:12:49 PM) emanuele: I was so bored yesterday... LOL
(04:14:01 PM) emanuele: https://github.com/emanuele45/Dialogo/commits/updateAnything
(04:18:08 PM) Norv: I like it! It looks like you feel the db related code should turn towards a more forum specific layer
(04:19:15 PM) emanuele: not sure what you are talking about... lol
(04:21:08 PM) Norv: you make a part of a database abstraction layer there
(04:21:27 PM) emanuele: Really? Cool! :D
(04:24:56 PM) Norv: If you continue, we might want to move updateTable() in /database files
(04:56:39 PM) emanuele: well...while writing it I was thinking that it's place was there...
(06:29:39 PM) emanuele: pushed something more on the branch :P

(04:50:33 PM) ***Norv mumbles something unintelligible about warning settings
(05:13:04 PM) emanuele: warning settings?...
(05:13:06 PM) emanuele: not sure
Title: Re: IRC
Post by: TestMonkey on March 04, 2013, 07:06:55 pm
(06:33:44 PM) Norv: wow mergetopics is still a mess. I can't see signs that I (thought I) cleaned some bit :|
(06:37:05 PM) Spuds: lots of functions like that ... ya clean em, only to uncover the next level of dirt :P

(07:23:13 PM) Norv: action_stats() ... this thing queries everything and their gran'pa
(07:24:54 PM) Spuds: I still need to add something to that too !
(07:25:29 PM) Norv: I could make a Stats subs... to avoid including every file on earth, when moving/refactoring queries. Though I'm not sure how many exactly would be... hmm.
(07:25:35 PM) Spuds: no joke ... i really do !
(07:25:38 PM) Norv: lol
(07:25:55 PM) Spuds: moar stats bwahhhh ha ha
(07:30:45 PM) Spuds: a subs might be nice for adds ... they could grab  just some stat info if they wanted, not sure if thats needed though, seems like some of that information could be useful on its own, but my eyes are bleeding from just glancing at it
(07:32:46 PM) Norv: ah... right... might help with ssi functions, perhaps? (I didn't check, but it seems a similar idea in some way)
(07:36:26 PM) Norv: of course, it will mean some (perhaps even all) will be duplicate database-work functions... The only reason would be to not include everything. TBH it might be an insufficient reason, but I'm starting it off atm

(07:38:15 PM) emanuele: Hey Spuds!
(07:45:12 PM) Norv: It's not Spuds. Don't trust every name on the interwebz.
(07:50:44 PM) emanuele: ohh...A SPY!! :P
(07:51:02 PM) Spuds: Thats me .... :P
(07:52:09 PM) Spuds: of course I have to run now .... but be back later in da day ... or evening depending on your global view of things
(07:52:55 PM) Spuds left the room (quit: Quit: Leaving.).
Title: Re: IRC
Post by: TestMonkey on March 04, 2013, 08:26:20 pm
(08:12:36 PM) emanuele: Hey Norv, what do you think about remove the limitation of viewquery available only to admins?
(08:13:34 PM) Norv: I wouldn't do that - it might show data you don't want everyone to see; including custom stuff on site etc
(08:14:08 PM) emanuele: fact is, it's annoying... :P
(08:14:18 PM) Norv: Why would members/guests need to see it?
(08:14:55 PM) Norv: why annoying? Hah
(08:15:27 PM) emanuele: queries for admin and members are different and while developing (since that is a development/debug feature) is from time to time helpful to see the queries from a "normal user" point of view
(08:15:40 PM) emanuele: ...yeah I know I can simply hack it since I'm already working... :P
(08:16:36 PM) emanuele: anyway it doesn't reveal much more than already shown...
(08:16:59 PM) emanuele: the only difference is the line the query is executed and the query itself...
(08:21:33 PM) Norv: ah right, right. ...You haz other stuff you do during debug. How about. An addon which does this 'debug mode' edits and undoes them for ya. Or, an extra setting (undocumented :P), debug mode, which only works for localhost.

(08:31:00 PM) Norv: we logout users everywhere...
Title: Re: IRC
Post by: TestMonkey on March 04, 2013, 11:48:42 pm
(09:47:44 PM) ***emanuele goes fix the updateAnything branch since it doesn't even show the board index... lol
(09:55:07 PM) Norv: haha
(09:58:29 PM) emanuele: $members = is_array($members) ? $members : is_array($members);
(09:58:35 PM) emanuele: ROFL
(09:59:26 PM) emanuele: Power of copy&paste! :P
(10:01:24 PM) Norv: It doesn't count. It was before PR.
(10:01:39 PM) emanuele: In fact, apart from that small error, it's working pretty well I think... :P
(10:01:43 PM) emanuele: what?
(10:06:28 PM) Norv: It doesn't count for the award, sorry.
(10:06:46 PM) emanuele: :(
(10:07:02 PM) emanuele: so I should stop testing... :P
(10:07:18 PM) Norv: Ohwait, maybe it counts :P
(10:07:53 PM) emanuele: you are scared by my code eh? :P
(10:09:22 PM) Norv: O:-)

(09:59:40 PM) ***Norv tries to remember where and why I started this little batch of refactorings...

(10:10:51 PM) emanuele: https://github.com/SimpleMachines/SMF2.1/pull/289#issuecomment-14391306
(10:25:03 PM) Norv: Sounds like a bug over there (this behavior of the panel is not really friendly... cleaner interface maybe, but I'd rather have them buttons 'remove' 'add' 'insert here' stuff)
(10:26:42 PM) emanuele: Today I did a commit that should be ported to Elk (quick moderation in topics (badly) broken), if I forget feel free to cherry-pick it! ;D
(10:27:11 PM) emanuele: and also another one regarding strings
(10:31:12 PM) Norv: ok

(12:39:07 AM) ***Norv laughs at the very technically sound and to the point presentation of a PR: "Take that too, and if you don't like, close it."
Title: Re: IRC
Post by: TestMonkey on March 05, 2013, 11:06:12 am
(12:39:07 AM) ***Norv laughs at the very technically sound and to the point presentation of a PR: "Take that too, and if you don't like, close it."
(12:47:29 AM) ***Spuds runs to look
(12:49:17 AM) emanuele: lol, there are already the commits that explain (sort of) what the branch is about. :P
(12:50:50 AM) Norv: ;D
(12:51:05 AM) Norv: Don't worry, we forgive you. :P
(12:51:54 AM) emanuele: I know, I write such nice code that you cannot not forgive me. :P
(12:52:13 AM) emanuele: (at least you have something to laugh about :P )
(12:52:43 AM) Spuds: only because he's Italian and we don't want him to cause a ruckus ... like clap everytime one of his PR's is merged :P

(12:59:23 AM) Norv: tbh emanuele, I don't know if it's a good idea to create an attachments dir at forum directory level...
(01:00:40 AM) emanuele: Since we are being honest ( :P ), I never liked my mod... lol
(01:02:02 AM) emanuele: the idea (I think) was: since attachments in in BOARDDIR, then it's "normal" to create a 2nd directory at the same level
(01:02:36 AM) emanuele: (that is something I'm pretty sure most of the admins do: attachments2 and alike)
(01:04:12 AM) emanuele: of course in a certain way in my mod this was a "last resort" if nothing else was specified (i.e. not a full path, neither a "base" directory)
(01:05:04 AM) Norv: I think that is pretty much what I have in mind: perhaps possible, but not the most used and proeminent option
(01:09:06 AM) Norv: thinking it may end up cluttered; it may be unwritable more easily; also when things go wrong, people (and tools alike) may or may not safeguard extra directories from /forum. I find it more likely you'll remember when you store attachments in a completely different place. But I might be wrong.

(03:20:20 AM) Spuds: The Errors.class really needs to be documented
(03:22:22 AM) Spuds: even the params in the docblocks are not whats in the function calls
(03:32:21 AM) Spuds: assuming there are docblocks at all that is
(03:37:39 AM) Spuds: opened an issue on this
Title: Re: IRC
Post by: emanuele on March 05, 2013, 01:43:17 pm
/me is innocent, the branch has been merged way too early!

/me runs :P
Title: Re: IRC
Post by: TestMonkey on March 05, 2013, 02:59:02 pm
/me is innocent, the branch has been merged way too early!

/me runs :P

/me haz no clue who merged it "too early".  O:-)

If it's merged, it means that either: 1) it wasn't early, or, 2) it wasn't me. /settled.
Title: Re: IRC
Post by: emanuele on March 05, 2013, 03:56:56 pm
Hey, who are you?
Where did you hide TestMonkey? ???
Title: Re: IRC
Post by: Spuds on March 05, 2013, 09:09:59 pm
Sure the kitten may look all kinds of cute, but I think it chased feature cat from the room !
Title: Re: IRC
Post by: TestMonkey on March 06, 2013, 06:31:04 am
(11:13:15 PM) emanuele: Split is broken!! :D
(11:13:25 PM) emanuele: "select posts"
(11:30:46 PM) Spuds: Yes you and Norv are taking the competition serioulsy
(11:33:11 PM) emanuele: Indeed
(11:33:32 PM) emanuele: debugging it right now, there is something wrong in the query I think
(11:40:15 PM) emanuele: for ($counter = 0; $row = $smcFunc['db_fetch_assoc']($request); $counter ++)
(11:40:24 PM) emanuele: should be that one :P
(11:40:54 PM) emanuele: ahh...no
(11:42:20 PM) Spuds: Thats still an unusaul way to loop on the results .... compared to how its done everywhere else
(11:43:21 PM) Spuds: so feel free to update that if you want :D
(11:44:21 PM) Spuds: and you can remove modSettings from the global
(11:45:23 PM) Spuds: and this  !empty($excluded_messages) ? $excluded_messages : array(), is unneccesay since its in the function params already
(11:47:41 PM) emanuele: yep, I was thinking the same
(11:51:26 PM) emanuele: AND id_msg NOT IN ({array_int:no_split_msgs})
(11:51:28 PM) emanuele: AND m.id_msg IN ({array_int:split_msgs})
(11:51:33 PM) emanuele: aha!
(03/06/2013 12:05:12 AM) Spuds: yeah that may make a difference
(12:05:18 AM) Spuds: :D

(01:00:51 AM) emanuele: Fix sent...not very nice, though it seems to work
(01:03:54 AM) Spuds: What don't you like about it?
(01:05:15 AM) emanuele: dunno, the arrays?
(01:05:40 AM) emanuele: are also a bit boring...
(01:05:51 AM) emanuele: though I didn't want to add another param as well...
Title: Re: IRC
Post by: TestMonkey on March 06, 2013, 08:16:33 am
Hey, who are you?
Where did you hide TestMonkey? ???

Sure the kitten may look all kinds of cute, but I think it chased feature cat from the room !

 :o 

Over-testing Gravatars PEBKAC!
Title: Re: IRC
Post by: TestMonkey on March 06, 2013, 11:31:10 pm
(07:42:10 PM) emanuele: Norv, have you considered 1 directory == 1 language?
(07:44:54 PM) Norv: for language files in installation?
(07:46:06 PM) Norv: I don't remember thinking of it, tbh. Would it help? Many forums would have a +1 deeper structure, with English alone or with 2 languages I guess.
(08:10:15 PM) Norv: but I see no problem

(09:20:44 PM) Norv: looks like we didn't fix that disregard bug... which I don't remember well :P
(09:22:13 PM) emanuele: which one? The move topics?
(09:27:11 PM) Norv:  all unread > mark selected as read
(09:27:18 PM) Norv: http://www.elkarte.net/index.php?action=admin;area=logs;sa=errorlog;desc=
(09:27:29 PM) emanuele: ohh...I also know another bug... :P
(09:29:29 PM) Norv: I thought it's the same... no time atm though
(09:38:30 PM) emanuele: yeah, it may be
Title: Re: IRC
Post by: TestMonkey on March 06, 2013, 11:32:42 pm
(11:32:46 PM) emanuele: Norv, I was looking at moveTopics
(11:33:18 PM) emanuele: any reason why all the things related to update user statistics are still in the controller and not in moveTopics itself?
(11:34:40 PM) ***Norv haz no clue. Because we didn't get to them?
(11:35:04 PM) emanuele: dunno...don't even remember if moveTopics exists in SMF or not...lol
(11:39:59 PM) emanuele: darn, I working on the split-and-move-to-another-board (and post a message to inform) and every two steps I have to stop and do some refactoring! :P
(11:42:12 PM) emanuele: (and after that I hope to be able to push the "follow-up here" and stop for now)
(11:42:44 PM) emanuele: TBH I thought the two were related, but I don't remember why I thought so... lol
(11:44:13 PM) Norv: ROFL!

(11:45:37 PM) emanuele: BTW, do you think the two fit Elk 1.0? (or Elk at all)
(11:47:23 PM) Norv: split-and-move sure; follow-up here is the link to a split-off, right?
(11:47:50 PM) Norv: they are related
(11:48:05 PM) emanuele: not really...
(11:49:00 PM) Norv: lol
(11:49:28 PM) emanuele: would be the link to a side conversation originated from a post in a certain discussion: the (diligent) user instead of derails a discussion decides to start a new one quoting (or not) a post and starting a new topic
(11:50:25 PM) emanuele: it's a bit more complex and has more to do with user experience than with moderation
(11:53:48 PM) Norv: fair enough. To me, I think it's conceptually the flexibility of posts and "loosen" their strict dependency on topic and board
(11:54:25 PM) emanuele: Okay, I'll do (since I like them anyway :P ), then you will see how they work and decide. ;)
(11:59:27 PM) Norv: as you want. I think it is appropriate to loosen this dependency (and looking forward to somewhat more, loosen the dependency between boards and visibility is even teh cool O:-))
(03/07/2013 12:01:01 AM) emanuele: don't lead me into things I don't want to enter...heck I need to! :P
Title: Re: IRC
Post by: TestMonkey on March 06, 2013, 11:39:01 pm
(12:16:33 AM) Spuds entered the room.
(12:16:47 AM) emanuele: Here it comes tah Spuds! :D
(12:16:48 AM) Norv: Spuds is playing with your js friend https://github.com/elkarte/Elkarte/pull/232
(12:16:53 AM) Norv: LOL! I thought we not haz monitoring bots here!
(12:17:38 AM) emanuele: Sorry!! I have been absorbed by other things and kept that for later... :(
(12:18:04 AM) Spuds: Don't worry ... I left stuff for you ;)
(12:18:20 AM) emanuele: :P

(12:18:59 AM) Spuds: That was a least a two glasses of wine fix ... but I have none so you got the beer fix
(12:20:21 AM) ***emanuele wonders what Spuds is talking about...
(12:21:04 AM) emanuele: I breaking some other things, when I'm done, I'll add some (crappy) documentation to the Error class unless someone else beats me :P )
(12:21:55 AM) Spuds: I mean to fix everything would have taken me two glasses of wine  .... but since I have no wine in the house, only beer, you got the poor boys beer fix for your js function
(12:22:41 AM) Spuds: You know I must say for a guy who came out of the documentation team, well ... lets just say it ... your code documentation sucks ! :D
(12:22:51 AM) emanuele: send me your address I'll try to ship a couple of bottles of barbera :P
(12:22:56 AM) emanuele: LOL
(12:23:52 AM) emanuele: that matches the fact that even if I'm on the dev "team" my code sucks! :D
(12:24:53 AM) Spuds: LOL ... well TBH I can't say your documentation is that bad, simply because there has not been enough of it to evaluate :P
(12:25:10 AM) emanuele: AHAHAH!!
(12:25:21 AM) emanuele: very good point!
(12:27:32 AM) Spuds: The only reason I add in so many (generally worthless) is that my mind is so weak that I can't remember what I typed in 10 lines above :D
(12:30:41 AM) emanuele: And the reason I don't usually write any is that my level of attention is so low that I can't read 5 lines of documentation without skip the reast and go look for an example... :(
Title: Re: IRC
Post by: TestMonkey on March 19, 2013, 02:03:59 pm
(12:40:00 AM) emanuele: Hey Spuds, want to read something funny?
(12:40:53 AM) Spuds: Always !
(12:43:04 AM) ***emanuele is lost with permissions...
(12:44:22 AM) emanuele: if I'm moving a split topic to another board, what permissions should I check?
(12:44:33 AM) emanuele: move_any would be easy
(12:45:13 AM) emanuele: move_own should I check then the ID of the first split message?
(12:45:27 AM) emanuele: but...does it make sense?
(12:47:22 AM) emanuele: Is move_own actually useful?
(12:49:37 AM) Spuds: after its split someone owns it ... so its move_own || move_any  I would think
(12:55:07 AM) emanuele: yeah...that makes sense. Though I'm not yet sure that have the permission to move only own topics is actually useful...
(12:55:25 AM) emanuele: ...oh well, that's not so important now
Title: Re: IRC
Post by: TestMonkey on March 19, 2013, 02:04:29 pm
(01:08:19 AM) Spuds: Does anyone know of a collection of email testcases? ... I wanted to do some more testing on the email stuff .......... I found a nice collection of markdown testcases to play with so that help .... well helps enough to know that writting converter kind of stinks
(01:14:39 AM) emanuele: mmm...what kind of emails?
(01:14:52 AM) emanuele: you may take some mailing lists maybe
(01:26:22 AM) Spuds: yeah I guess I can grab some mbox file and use that .... just want to throw some "suff" and the parser and filters
(01:26:28 AM) Spuds: "stuff"

(01:40:05 AM) ***emanuele was debugging why the topic was not moved...
(01:40:15 AM) emanuele: there was no moveTopics call...
(01:41:15 AM) Spuds: Hummm ... that Norv is tough competition to be sure !
(02:03:22 AM) emanuele: https://github.com/emanuele45/Dialogo/commit/303bebaa622a53210f54f13e6e426e749cd0a3f9
(02:03:26 AM) emanuele: here it is
(02:03:50 AM) emanuele: "unfortunately" this branch uses most of the branches with refactoring I recently pushed...
(02:04:31 AM) emanuele: the commit message is not exactly... clear...
(02:06:59 AM) Spuds: Someone has been busy :D
(02:07:45 AM) emanuele: You may notice there is no documentation at all! :D
(02:08:52 AM) Spuds: Yup ... not a drop ... no comments, no function headers, no params definitions :P
(02:09:09 AM) emanuele: O:-)
(02:10:25 AM) ***emanuele is tired...1 o'clock...
Title: Re: IRC
Post by: TestMonkey on March 19, 2013, 02:05:25 pm
(03:01:47 PM) emanuele: Norv, if you are around, I think we have our first spammer at elkarte
(03:06:33 PM) Norv: yep, he surely is :D
(03:13:36 PM) ***Norv found a hammer and is using it. O:-)
(03:21:35 PM) emanuele: Thankz! :D

(03:28:25 PM) ***emanuele hates tables!! >:(

(03:31:15 PM) ***Norv thinks that actualy, I shouldn't hurry to bans, emanuele iz the ban-master and might like to use them bans in our little live context.
(03:32:09 PM) ***emanuele is too kind to ban...
(03:32:51 PM) Norv: hahaha emanuele just makes tools for them non-kind ones :D
(03:33:28 PM) emanuele: O:-)
(03:34:26 PM) Norv: ban edit is not merged yet (cuz I got stuck on them logs ouch sorry), but me thought it will be fun to *use thy own toolz* :D :D :D
Title: Re: IRC
Post by: TestMonkey on March 19, 2013, 02:14:44 pm
(10:48:51 AM) The topic for #elkarte is: Welcome in #DontPanic
(10:49:11 AM) Norv: Morning!
(10:49:31 AM) Norv: DontPanic? Hah, why this Trekkie101
(01:14:13 PM) TimeVort1x: Norv: I set it on Douglas Adams's birthday.
(01:24:22 PM) Norv: Oh. :) It had to happen. *sagenods*
(01:32:10 PM) ***Norv would have probably chosen >> If you try and take a cat apart to see how it works, the first thing you have on your hands is a non-working cat.
(01:43:07 PM) TimeVort1x has changed the topic to: If you try and take a cat apart to see how it works, the first thing you have on your hands is a non-working cat.

Spuds [~Spuds] entered the room.
(03:52:42 PM) Spuds: There is a Norv in the room :P
(03:57:16 PM) Spuds: Who took the cat apart?

emanuele [~chatzilla] entered the room.
(04:56:05 PM) ***emanuele feels smell of spammer: http://www.elkarte.net/index.php?action=profile;u=49

(04:56:30 PM) emanuele: ohh...Norv is back...
(04:56:35 PM) emanuele: the fun is over... :(
(04:56:37 PM) emanuele: :P

(04:59:43 PM) Spuds: Same as this one http://www.elkarte.net/index.php?action=profile;u=48
(05:01:44 PM) emanuele: We are having spammerz! We are becoming famous!
(05:02:24 PM) Spuds: The funny thing is the verification question still say Dialogo :P
(05:02:36 PM) emanuele: LOL
Title: Re: IRC
Post by: TestMonkey on March 19, 2013, 02:15:49 pm
(10:01:03 PM) Trekkie101: Norvo
(11:40:50 PM) Norv: quite afk, sorry, Trekkie101 - but please, do say. I can come back on it
(11:41:22 PM) Trekkie101: Re: User tagging, wasn't sure if you ever revisited the topic, it kind of ended :P
(11:44:06 PM) Norv: I think there's an issue filed on github. I didn't get to it yet

(08:32:28 PM) emanuele: Spuds and Norv, what do you think? Does make sense? https://github.com/emanuele45/playpen/commit/660a83fa3345da01358693b0034c50e90b74926c
(09:16:48 PM) Spuds: How do you use that in the config var array?
(09:42:15 PM) emanuele: if you have a setting that is "select"
(09:42:27 PM) emanuele: you can define it "multiple" and allow for multiple selection
(09:42:46 PM) emanuele: I don't have examples at hand...
(09:43:42 PM) emanuele: but in fact you can take any select, copy it (changing the name) and set it to multiple
(09:44:35 PM) emanuele: if the setting doesn't exists in $modSettings (or better if it is not a serialized array in $modSettings) the code will throw an error when unserialize is run
(09:46:43 PM) Spuds: I'll have to try it ... it was the $config_var['multiple'] that had me confused as compated to $config_var[0] == 'multiple'
(09:50:20 PM) emanuele: ahh okay
(09:50:33 PM) emanuele: it's $config_var[0] = 'select'
(09:50:41 PM) emanuele: $config_var['multiple'] = true
(09:54:38 PM) Spuds: gotcha ya ...
(09:54:56 PM) Spuds: well it makes sense to have something like that ....
(10:43:49 PM) Spuds left the room (quit: Quit: Leaving.).
(01:01:46 AM) Spuds [~Spuds] entered the room.
(01:40:09 AM) emanuele: Thanks spuds, I'll bring it (and the other) to Elk tomorrow
(01:57:35 AM) Spuds: :)

(02:04:55 AM) ***emanuele needs a sort of CMS...
Title: Re: IRC
Post by: TestMonkey on March 19, 2013, 02:18:20 pm
(08:31:39 PM) emanuele: http://wedge.org/pub/smf/7996/my-review-of-customer-service-on-smf/
(09:22:10 PM) Norv: emanuele: ah well, it's not a public topic. Too bad, it sorta haz an interesting title.
(09:43:35 PM) emanuele: arg...well, it's mostly about that: http://www.simplemachines.org/community/index.php?topic=499748.msg3507942#msg3507942
(10:35:42 PM) Norv: Ah. That was also proposed on Elk. Well if you feel it's nicer to combine them

(10:37:15 PM) Norv: As for that answer. Meh.

(10:39:05 PM) emanuele: ROFL
(10:40:43 PM) emanuele: Yep, I think I proposed it
(10:40:57 PM) emanuele: yes, yes, now I remember
(10:41:35 PM) emanuele: BTW, it could be interesting consider to put the "new poll" in a dropdown maybe...
(10:41:47 PM) emanuele: I think there are way too many buttons around
(11:19:59 PM) Norv: yup
(11:20:45 PM) Norv: that's the thing, too many buttons is somewhat an overloaded interface
(11:22:44 PM) emanuele: Went back to check how it is handled in phpBB and they use a <select> and a "go" button
(11:23:05 PM) emanuele: I don't like it that much, though the idea of put everything together is not that bad...
(11:23:29 PM) Norv: you mean a visible set of radio buttons?
(11:23:42 PM) emanuele: ooops, I forgot to mention I was looking at "moderation" buttons
(11:23:46 PM) Norv: I don't remember their (ugly :P) interface
(11:24:48 PM) emanuele: no, I mean a <select><option>lock</option><option>delete</option>...</select> <input name="go" />
(11:27:51 PM) emanuele: but that's not what I would like to see either
(11:29:09 PM) emanuele: but...a nice single button with a nice dropdown showing all the other options... O:-)
(11:29:24 PM) emanuele: (sort of "more...")

(11:30:19 PM) emanuele: like what I was playing with a while ago: http://img10.imageshack.us/img10/514/screen91b.png
(11:30:47 PM) emanuele: hovering the "reply" all the other buttons appear on the left
(11:31:34 PM) emanuele: yes, lots of hovering may result ugly too...
(11:32:31 PM) Norv: wow this thing is very clean
(11:33:25 PM) emanuele: not enough... :P
(11:33:25 PM) Norv: hovering or pushing some "more" sounds understandable, hovering the 'reply' not really :)
(11:33:45 PM) emanuele: lol
(11:33:47 PM) emanuele: yes
(11:34:06 PM) emanuele: I was really playing the "remove each bit that is not absolutely necessary"
(11:34:17 PM) Norv: :D
(11:34:43 PM) emanuele: also the "quote | quick edit | more" are hidden until you hover the message

(11:37:06 PM) Norv: love to see the playing around! Though methinks the extreme won't be user-friendly. Because for example, I imagine there'd be many hide-n-show 'quote'
(11:37:23 PM) Norv: while you hover from up to down the page or the other way around
(11:38:06 PM) ***Norv snickers.
(11:43:28 PM) ***emanuele has not yet changed the timeouts... O:-)
(12:25:57 AM) Norv: :)
Title: Re: IRC
Post by: TestMonkey on March 20, 2013, 06:50:26 pm
(02:19:39 PM) emanuele: Norv, when you have a minute could you kick some of the spammers?

(05:49:02 PM) Norv: Ban groups would be handy

(05:56:20 PM) Norv: http://www.elkarte.net/index.php?action=memberlist;sort=registered;start=0;desc
(05:57:00 PM) ***TehCraw registers so he can see that.
(05:57:14 PM) Norv: I see in the list, two accounts, InvofMokbeevebdsc and something like it, and they're both banned
(05:58:00 PM) ***Norv thinks this is a bug, but really needz coffee to even express it
(05:58:30 PM) ***TehCraw passes Norv a full mug of coffee to get the morning started off right.
(05:58:40 PM) Norv: you see those two, TehCraw?
(05:58:49 PM) Norv: oh thank you! :D

(07:15:50 PM) ***emanuele feels he broke something with bans...? O:-)
(07:16:28 PM) Norv: emanuele: I think memberlist is now showing the accounts that got banned indirectly (IP address from another ban)
(07:17:53 PM) Norv: afaik Elk shouldn't display any banned user in "normal" memberlist, nor their profiles for non-admins
(07:18:21 PM) emanuele: yep, that should be the expected behaviour...
Title: Re: IRC
Post by: TestMonkey on March 21, 2013, 05:37:49 pm
(06:25:02 PM) Norv: https://github.com/SimpleMachines/SMF2.1/pull/318
(06:27:52 PM) TehCraw: He's been working pretty hard on that for the last few days. IMO, it's a nice idea.
(06:34:13 PM) Norv: Have you checked or tested the branch, TehCraw?
(06:35:23 PM) TehCraw: Not yet. I told him I would though, so it'll have to happen sooner or later.
(06:35:39 PM) TehCraw: Right now I'm trying to finish this dang auto loader class.
(06:38:03 PM) Norv: It is a handy feature (and it's been requested every once in a while), it's just that afaik we haven't got to adding stuff to moderation, and personally I am somewhat wary of continued additions to this code
(06:39:01 PM) Norv: at a quick look, two joins added to loadBoard(), a join added to isAllowedTo() and boardsAllowedTo()
(06:40:21 PM) TehCraw: So you're kinda wondering if the feature is worth the added performance hit?
(06:41:24 PM) Norv: Yes, and what exactly are the results of doing these
(06:43:01 PM) TehCraw: I dunno exactly. I'll have to look at it later. :P
Title: Re: IRC
Post by: TestMonkey on March 21, 2013, 05:40:09 pm
(12:29:24 AM) emanuele: This evening I discovered that admins can be warned...
(12:29:27 AM) emanuele: isn't it silly?
(12:29:42 AM) TehCraw: That is weird. :|
(12:30:07 AM) TehCraw: You'd think that admins would be immune to that kinda thing.
(12:30:31 AM) emanuele: it's nice, because you see the "muted" next to your name, but you can still post as usual.
(12:30:33 AM) emanuele: lol
(12:31:30 AM) ***emanuele thinks it's a bug
(12:31:37 AM) TehCraw: Happy unicorns in the background give admins special magic powers.
(12:32:04 AM) ***emanuele uses his special powerz to kill all the unicorns
(12:32:36 AM) TehCraw: They're just like really big bugs anyway.
(12:32:51 AM) emanuele: only more annoying...
(12:33:34 AM) TehCraw: Code gremlins, as I believe they're more commonly known.

(12:33:53 AM) TehCraw: How did you manage to discover that anyway? Trying to warn yourself? :P
(12:34:36 AM) emanuele: ...I didn't try that, let me see!
(12:35:00 AM) emanuele: mmm...weird error...
(12:36:49 AM) TehCraw: While you're at it, you should see if you can add yourself to the ignore list. :P
(12:37:12 AM) emanuele: LOL
(12:37:33 AM) emanuele: Apparently if I don't have warnings I cannot access the page
(12:37:51 AM) emanuele: *but* if I've been warned, I can change my warning level and it's not even logged!
(12:37:53 AM) emanuele: LOL
(12:38:16 AM) emanuele: I hope *again* my test forum is broken, otherwise I'd call that one a bug too. :P
(12:38:54 AM) TehCraw: :S Strange....
(12:40:32 AM) emanuele: well...not so much :P
(12:40:56 AM) emanuele: it's strange the fact that *I* didn't code it that way! O:-)
(12:41:25 AM) ***TehCraw tries to add himself to the ban list.
(12:42:52 AM) emanuele: bans should work well...
(12:43:08 AM) emanuele: except I changed the code, so they may be broken, but that's another point :P
Title: Re: IRC
Post by: TestMonkey on March 21, 2013, 05:44:13 pm
Quote
(12:29:24 AM) emanuele: This evening I discovered that admins can be warned...
(12:29:27 AM) emanuele: isn't it silly?
(12:29:42 AM) TehCraw: That is weird. :|
(12:30:07 AM) TehCraw: You'd think that admins would be immune to that kinda thing.
(12:30:31 AM) emanuele: it's nice, because you see the "muted" next to your name, but you can still post as usual.

I warned admins, and I didn't think of it as a bug... But I didn't consider the rest of the behavior tbh, only the warning itself, sent and received. You're right it becomes strange, but what is the right behavior? An admin (I think) should expect to still have the option to "warn" another admin.
How should it go from there? A notice that "hey, you want to mute this guy but he's admin so this won't have any effect"?
Title: Re: IRC
Post by: TestMonkey on March 21, 2013, 05:51:51 pm
(12:43:49 AM) TehCraw: What are some of the main things you guys are going to change in Elkarte?
(12:44:37 AM) emanuele: That's a question for Norv I think
(12:44:58 AM) ***emanuele is not good with technical (informatics-related) explanations
(12:45:47 AM) TehCraw: That's okay.
(12:46:43 AM) ***TehCraw goes back to his autoloader class.
(12:47:39 AM) Norv: TehCraw: https://github.com/elkarte/Elkarte/issues/2
(12:53:20 AM) TehCraw: Very nice.
(12:53:29 AM) ***TehCraw approves of roadmap

(12:54:19 AM) TehCraw: Any plans to make smcFunc PDO powered? ;)
(12:55:24 AM) TimeVortex: $smcFunc must die a quick death.
(12:55:41 AM) TimeVortex: Pretty please with sugar on top
(12:56:06 AM) TimeVortex: $smcFunc['db_query'] ? Please, let's make it $db->query
(12:56:08 AM) ***emanuele prefers cream & chocolate
(12:57:42 AM) TehCraw: Now you're talking.

(12:57:45 AM) emanuele: that shouldn't be that difficult, though it still handles some strings too
(12:58:10 AM) TehCraw: However it would be a major pain in the butt to remove every instance of $smcFunc across the entire system.
(12:58:30 AM) emanuele: sed?
(12:59:08 AM) TehCraw: what is this "sed" you speak of?
(12:59:28 AM) Norv: TehCraw: yes, that'd be good to do. Personally I don't think PDO makes a lot of difference atm, but it's an improvement. PRs are gratefully accepted. :)
(01:00:03 AM) emanuele: http://en.wikipedia.org/wiki/Sed
(01:00:26 AM) emanuele: or perl if you want...or even php. :P
(01:00:35 AM) Norv: Any smartie find/replace would do. But are you sure you'd remove backwards compatible accessibility?
(01:01:07 AM) TimeVortex: Hey, if Elkarte 1.0 does it the $db->query way...
(01:01:12 AM) ***emanuele doesn't like backward compatibility. :P
(01:01:33 AM) emanuele: neither against neither in favour TBH. ;)
(01:01:36 AM) TimeVortex: You're already refactoring loads of functions.
(01:03:16 AM) Norv: True. My point is that mods/addons will also need to update, vs you can fill the same expected array too, only forward to the method.
(01:04:30 AM) ***TehCraw thinks all mods should be object oriented libraries forced to follow interface classes.
(01:04:58 AM) Norv: Or the other way around. Add db classes, initialize stuff, and forward to the old implementation... Well.

(01:08:10 AM) Norv: Ok. The question is to get from here to there.
(01:09:45 AM) Norv: Everyone wantz database classes with no backwards compatibility?
(01:10:02 AM) ***emanuele looks at all his branches and cries... :'(
(01:10:10 AM) Norv: :D
(01:12:16 AM) ***Norv will have to point out to emanuele that I'm too busy, caught up with things, to (probably) get to it very soon. And also, I've done this in some other project/branch/heck-knows-where, but I can't reuse it, so I'm a little weary to do it again... Heh.
(01:14:52 AM) TehCraw: mysql_*() is going deprecated soon anyway IIRC

(01:15:33 AM) ***emanuele did the theme things for fun and he is still suffering
(01:22:53 AM) emanuele: and anyway we should keep something for 2.0... :P
(01:24:18 AM) emanuele: on one hand it would probably be nice to stay consistent at least on some basic thing even across major version
(01:24:39 AM) emanuele: on the other...dunno
Title: Re: IRC
Post by: TestMonkey on March 22, 2013, 04:00:05 am
(06:27:48 PM) The topic for #elkarte is: If you try and take a cat apart to see how it works, the first thing you have on your hands is a non-working cat.

(08:20:59 PM) TehCraw: "The server at elkarte.net can't be found, because the DNS lookup failed."
(08:29:33 PM) TehCraw: Am I spelling that dang thing wrong or something?! I can't even get in through a proxy.
(08:34:27 PM) Norv: No, it's spelled right. In Chrome, I'd check and deselect "Use DNS pre-fetching to improve page load performance."
(08:35:31 PM) Norv: This has to be related to something in your configuration on DNS lookup
(08:38:12 PM) Norv: Does it happen only with Chrome though?
(08:39:26 PM) Norv: http://productforums.google.com/forum/#!topic/chrome/B4k68v6IHxs
(08:48:16 PM) TehCraw: It happens in Midori as well, and I did uncheck that setting already. :/
(08:49:24 PM) TehCraw: Good topic. I'll try that.
(08:53:28 PM) TehCraw: Hey, that worked! Thanks for the link.

(08:52:10 PM) Norv: Nice work on PureChat! :)
(08:53:59 PM) TehCraw: And thank you. :) I'm not too proud of the code anymore though
(08:56:15 PM) Norv: You can always refactor code you don't see fit. Just, remember KISS and YAGNI. :D
(08:56:50 PM) TehCraw: True true.
(08:57:36 PM) TehCraw: Needs quite a bit of refactoring.

(09:50:37 PM) Norv: what do you think of the moderator groups, Spuds?
(09:52:22 PM) Spuds: I'm a little leary about those querys ... have not benchmarked them or anything but on the surface thats quite a bit of extra overhead ...
(09:52:36 PM) Spuds: the joins are on primary etc but still ...
(09:53:03 PM) Spuds: just not sure how much thats needed vs potential overhead for everyone
(10:01:34 PM) Norv: I don't know. If I remember correctly, IPB has moderator groups and there are a few fans of them around SMF.
(10:10:42 PM) Spuds: Not sure what other forums have it or not ... and I do like concept of what it provides ...  really just need to see the db impact on load and security but need the right test case as well :P
Title: Re: IRC
Post by: TestMonkey on March 22, 2013, 04:01:25 am
(10:18:27 PM) Spuds:  I should update the site again ... been a couple of weeks .... any of the pending commits ready to be merged?
(10:24:16 PM) Norv: https://github.com/elkarte/Elkarte/pull/246 ?
(10:25:30 PM) Norv: I'd take also the createList() improvements, although tbh I didn't actually check carefully
(10:26:32 PM) Norv: but that is Ema's pet, and I'm thinking we can try it out anytime - now or after we mess something up. :)
(10:27:11 PM) Norv: I'm soooo behind with commits. :'(
(10:29:04 PM) Spuds: Any issues with Call pass? https://github.com/elkarte/Elkarte/pull/235
(10:31:32 PM) Norv: no
(10:34:09 PM) Norv: all boards2 does the right thing (tm). Mind if we take it for live?
(10:34:57 PM) Spuds: We should ...

(10:36:37 PM) Norv: Oh btw. SpudsMan. I intended to branch off the site. (i.e. make a separate repo actually). I think that we will/should work on other pages, we also have those scripts for admin, etc. So it makes sense to start the site repo: with a remote to the main Elk repo, or with a submodule for the main Elk repo
(10:39:03 PM) Spuds: makes sense ... I have not done much with those site js files, just some tweaks to current and detailed ....
(10:39:45 PM) Spuds: the rest of them were generally smf site specific in how they gathered the info etc ....
(10:41:11 PM) Norv: Also, something that may help, is to make a board or a block, on site, with git commits feed
(10:41:49 PM) Norv: (we don't want dat in the core software repo :) )
(10:43:01 PM) Spuds: You mean an admin block like news but with git commits?
(10:43:47 PM) Norv: yes. Or as a side block, like them portals blocks.
(10:43:59 PM) Norv: Sounds bad?
(10:44:49 PM) Spuds: No sounds good :)
(10:46:07 PM) Spuds: first I need to get some other trivial commits off my system ... and maybe stop playing around with PBE !
(10:54:41 PM) Norv: :'(
(10:55:00 PM) Spuds: why the frown?
(10:58:55 PM) Norv: cuz you said you not plays with PBE
(11:00:55 PM) Spuds: more from a point that I think I can stop playing around with it since I think I have more of the bugs removed now :)
(11:01:27 PM) Spuds: my first PR had some major doh's in it
(11:05:59 PM) Spuds: but I still need to add a line wrap function to the html2Md class
(11:07:30 PM) Norv: Ah cool

(11:07:35 PM) Norv: https://github.com/norv/elkarte.net
(11:08:20 PM) Norv: If we don't make changes to the core elk, on site, then this way to include the core repo (as a module) should be fine
(11:10:35 PM) Norv: If we do change elk on site for the site need itself (testing and playing around don't count for this methinks - unless you want them public), then probably another option would be better. I thought to propose the first and simplest imo.
Title: Re: IRC
Post by: TestMonkey on March 22, 2013, 04:04:58 am
(03/22/2013 12:03:48 AM) Spuds: https://github.com/elkarte/Elkarte/pull/249 O:-)
(12:23:55 AM) Norv: thank you!
(12:24:13 AM) ***Norv has trolled Spuds for good measure too.

(01:21:20 AM) Norv: https://github.com/elkarte/Elkarte/pull/244#issuecomment-15272341 *snickers*

(01:30:49 AM) Norv: https://github.com/engelnyst/Elkarte/commit/159640c4e2705c1761d31f9b6a310447507fd843 oops

(01:40:17 AM) Norv: Spuds: do we have package xml namespace on elk.net?
(01:40:39 AM) Norv: actually I could check... /lazy
(01:51:03 AM) Spuds: @norv ... I don't think I added that no

(03:13:36 AM) ichbin: sup people!!!
(03:14:30 AM) Norv: Oy, an ichbin! /hides.

(03:20:08 AM) ichbin: For the record, I just read the $smcFunc to db=>query() discussion. I would say push that out to the next version if it were up to me.
(03:21:26 AM) TehCraw: :D I like your attitude.
(03:27:32 AM) Norv: well I haz been lazy, err-busy lately, but don't tell anyone, specially when SpudsMan is here.
(03:30:08 AM) ichbin: That's good. It means you haven't done it yet then. :)

(03:30:09 AM) TehCraw: BTW, thanks for the PRs today, Norv.
(03:37:08 AM) Norv: Oh, I like doing that :D

(04:41:02 AM) Norv: this is correct, right? https://github.com/elkarte/Elkarte/pull/253 I think it is, with the constants changes. /methinks we need addons
(04:42:04 AM) Trekkie101: Norv, is languages not under themes?
(04:42:13 AM) Trekkie101: scratch that, its there
(04:44:03 AM) Norv: yes (funny I actually wanted to change that, but I've bypassed it.)
Title: Re: IRC
Post by: TestMonkey on March 23, 2013, 05:20:37 am
(05:59:03 PM) Spuds: I updated the site to the latest Git today
(05:59:18 PM) Spuds: I have no idea whats going on with the DNS issues
(05:59:46 PM) TehCraw: Thanks for updating the site. :)
(06:00:22 PM) Spuds: be sure and do a hard refresh when you go there
(06:00:57 PM) TehCraw: Umkay
(06:01:08 PM) TehCraw: Anything major changed between versions?
(06:01:36 PM) emanuele: they merged a couple of my branches, so most likely something is broken. :P
(06:04:25 PM) TehCraw: Cool. Experimental forums are the most fun.
(06:05:33 PM) Spuds: The last update to the site was a couple of weeks ago ... so lots of changes as usual ...
(06:06:18 PM) ***TehCraw goes to see some of the recent github updates.

(06:06:04 PM) emanuele: darn, the header upshrink doesn't have a "tab stop"...
(06:07:49 PM) Spuds: whats a tab stop?
(06:08:12 PM) Spuds: you mean a tabindex
(06:08:21 PM) Spuds: learn to use a mouse !
(06:08:41 PM) emanuele: batteries are dead...it's not my fault... :'8
(06:08:43 PM) emanuele: :'(
(06:08:53 PM) emanuele: well...sort of... O:-)

(06:09:19 PM) Spuds: You kids and your toys .... get a real mouse, one with a cord :P
(06:09:35 PM) ***TehCraw sends emanuele some fresh batteries.
(06:09:58 PM) TehCraw: Meh, nobody uses corded mice anymore. :/
(06:10:18 PM) Spuds: And a big ball under it, that collects junk on the rolllers ... now thats a mouse !
(06:10:25 PM) emanuele: I should have one...somewhere...
(06:10:38 PM) emanuele: and only 2 buttons of course!
(06:10:58 PM) TehCraw: Gotta love those ones with the rubber balls under 'em.
(06:11:02 PM) Spuds: Yes yes two buttons ... no wheel, you can't drive a mouse
(06:11:09 PM) emanuele: LOL
(06:11:48 PM) emanuele: I couldn't use a mouse without a wheel...
(06:12:05 PM) TehCraw: This conversation needs to get put into the IRC log as a reminder to everyone to always have a corded mouse in the house. ;)

(06:12:20 PM) emanuele: and it was rather difficult to even use apple mouses with the "inverted" "wheel"
(06:12:51 PM) Spuds: I could not use my trackpad without inertial scrolling either
(06:13:14 PM) emanuele: I should just not ignore the battery-level indicator...
(06:15:12 PM) Spuds: But yes the lesson here is always keep a real mouse in the house ... one with a tail
(06:16:13 PM) emanuele: but then I'd have to feed them... :P
(06:16:26 PM) Spuds: in putty white ... with a ps2 to usb adapter ...
(06:16:37 PM) Spuds: Just like Norvs avatar :D

(06:50:23 PM) Norv: header upshrink? I guess it's better to add it?
(06:50:54 PM) ***Norv thinks it's a fortunate occurrence for testing reasons, that emanuele's mouse got starved.
Title: Re: IRC
Post by: TestMonkey on March 23, 2013, 05:26:17 am
(07:20:52 PM) emanuele: mmm...you know, I'm starting wonder if this could be of interest: https://github.com/emanuele45/Limit-Topic-Length
(07:54:51 PM) Norv: Not sure

(11:35:17 PM) emanuele: meh...plasma just crashed...
(11:35:35 PM) emanuele: conspiracy!!!
(11:36:01 PM) TehCraw: Plasma.... As in KDE?
(11:36:25 PM) emanuele: yep
(11:37:42 PM) TehCraw: KDE is evil. :P Gnome 2 FTW.
(11:37:58 PM) emanuele: gnome is ugly...
(11:38:16 PM) TehCraw: Noes, KDE is ugly. ;)

(11:39:02 PM) emanuele: kde is just very unstable... lol
(11:39:26 PM) emanuele: (or at least it was the version I'm using, don't know about more recent ones)
(11:39:32 PM) TehCraw: Heh. I know it. Kept crashing for me when I tried it.

(11:44:47 PM) emanuele: okay, I think it's time to drop my love for old browsers and actually do an upgrade...
(11:47:54 PM) TehCraw: chromium
(11:53:04 PM) emanuele: seamonkey
(11:53:30 PM) TehCraw: That's a Mozilla based browser, isn't it?
(11:54:08 PM) emanuele: yep
(11:54:26 PM) emanuele: well, sort of :P
(11:57:18 PM) TehCraw: I hear Opera is switching to WebKit. Might be worth watching.

(12:16:25 AM) Norv: lxde ftw. No goodies, no problems. :P
(12:18:13 AM) emanuele: it seems similar to gnome
(12:19:25 AM) Norv: much simpler, cleaner, and fast
(12:23:41 AM) TehCraw: It is super fast. Takes almost no RAM to run, which I like.
(12:23:57 AM) TehCraw: Although I like XFCE a little better, cause they do panels really well.
(12:24:28 AM) TehCraw: Gnome 3 is just a pain.

(12:26:31 AM) emanuele: No problem with ram, I have plenty! :P
(12:27:45 AM) TehCraw: Lucky. LOL
(12:28:09 AM) emanuele: Nope, I just bought it. lol
(12:28:36 AM) TehCraw: Heh. I upgraded mine to 1.5 gb.
(12:28:39 AM) emanuele: 16 GB with...2.8 used at the moment
(12:28:45 AM) TehCraw: Holy smoke!
(12:29:01 AM) Norv: Haha nice! And no mouse.
(12:29:16 AM) emanuele: but I have the keyboard!
(12:29:21 AM) Norv: ROFL
(12:29:28 AM) emanuele: until it finishes the batteries that too...

(12:29:42 AM) TehCraw: good time to know a lot of keyboard shortcuts. :P
(12:29:43 AM) Norv: :D
(12:30:47 AM) emanuele: I know some, not all...for example I still have to discover which one is to open the kde menu
(12:30:50 AM) emanuele: lol

(12:30:56 AM) ***Norv is thinking that ema could attach some of his scripts to elk.net, and/or close moderation reports, and/or everything :D
(12:31:25 AM) emanuele: ???
(12:31:36 AM) emanuele: do you want me to break everything?...
(12:31:38 AM) ***Norv shamelessly thinks it's a good opportunity to see how keyboard navigation works.

(12:32:17 AM) TehCraw: If you can get the Terminal open, you should be pretty much good to go.
(12:32:40 AM) Norv: right :)

(12:32:53 AM) TehCraw: what OS do you run, Norv?
(12:32:59 AM) Norv: Debian
(12:33:14 AM) TehCraw: Awesomeness!
Title: Re: IRC
Post by: TestMonkey on March 23, 2013, 05:28:05 am
(11:16:30 PM) TehCraw: The DNS issue strikes again.
(11:16:44 PM) ***TehCraw goes to change his lookup servers again.
(11:30:03 PM) Spuds: yeah I know .... I think its the name servers on the hosting site ... bugging them now

(03/23/2013 12:01:39 AM) Spuds: the site *should* be back now
(12:02:31 AM) TehCraw: Seems to be up for me.
(12:02:50 AM) emanuele: up here too

(12:33:25 AM) emanuele: oh...found inconsistency in browsing with keyboard: in boardindex the dropdown menus are pushed faaaaaaaaaaaaaar on the left, while in moderation they stay in place
(12:34:02 AM) Norv: they are?
(12:34:23 AM) emanuele: it probably depends on the browser
(12:34:41 AM) TehCraw: Happens for me too.
(12:34:47 AM) emanuele: FF yes
(12:34:56 AM) TehCraw: Chromium too
(12:35:06 AM) TehCraw: Interesting...
(12:35:10 AM) emanuele: opera too
(12:35:34 AM) emanuele: while when you are in the moderation panel everything is fine
(12:36:28 AM) TehCraw: Happens in the profile area as well.
(12:36:58 AM) emanuele: curious, locally it happens in the moderation center too
(12:37:56 AM) Norv: PR to fix this stuff is welcome :)
(12:38:17 AM) ***emanuele has no clues on how to fix these kind of things...

(12:39:19 AM) emanuele: BTW browse phpmyadmin with the keyboard is a pain...
(12:40:56 AM) TehCraw: This is why
(12:40:57 AM) TehCraw: .dropmenu ul a:focus,.dropmenu ul ul a:focus{margin-left:9990px;
(12:41:10 AM) TehCraw: Seriously, what the heck?
(12:42:05 AM) emanuele: because if you use display:none screen-readers don't show them at all (as far as I remember/understood) or something like that
(12:42:24 AM) emanuele: so the accessibility trick is to move them far on the right
(12:43:03 AM) emanuele: ask Ant for details
(12:44:21 AM) TehCraw: is it important for screen readers to use dropdowns?
(12:47:10 AM) emanuele: you should ask Ant, he is the expert in the field...
(12:50:12 AM) TehCraw: Okay.
Title: Re: IRC
Post by: TestMonkey on March 23, 2013, 05:29:10 am
(02:06:13 AM) TehCraw: Spam alert
(02:45:50 AM) Norv: Buggy ban!
(02:47:17 AM) TehCraw: Could just delete the link and pretend it never happened.
(02:47:23 AM) TehCraw: Welcome, spammer!
(02:47:38 AM) Norv: :D
(02:48:10 AM) Norv: Ema went to bed at the proper time. :)

(02:52:16 AM) Norv: also, Arantor reports it's not clear where is "report to moderator". Okay, I have no clue where it is!
(02:54:52 AM) TehCraw: It's under the username dropdown, oddly.
(02:57:13 AM) Norv: Found it. It's strange, because, do you report the user, or the post? Since it's in the post display, I think you report the *post*
(02:58:07 AM) TehCraw: that's what I thought too.
(02:58:22 AM) TehCraw: IMO, the report button should be where it is in 2.0
(03:10:15 AM) Norv: Not sure where exactly, but most likely you want it visible on the post somewhere
(03:10:43 AM) TehCraw: Yeah.
Title: Re: IRC
Post by: Antechinus on March 24, 2013, 09:42:41 pm
Radical notion: you could always prune the IRC logs to eliminate content like discussion of mouses/when I were a lad mouses were different. If they were pruned, people might read them.
Title: Re: IRC
Post by: TestMonkey on March 24, 2013, 10:10:55 pm
Bitching style will not get more attention to your ideas, Antechinus. Not here. That said, I agree the latest chat added more banter than usual, and I agree it's better to keep the level lower. No problem, since I'm doing it manually still, in exactly this intention: pruning occasionally.

I don't think banter is neither of interest, or of no interest. It's just what it is, and I usually log *some* of it.

Speaking of logs, I think I'll keep a practice I've started recently: each post separates per topic of discussion, whenever possible. That is, if it is possible, a post concerns the part of the chat focused on one thing, this should make following them easier.
Title: Re: IRC
Post by: Arantor on March 24, 2013, 11:14:34 pm
Sounds like your IRC is more fun that our off topic board :/
Title: Re: IRC
Post by: TestMonkey on March 25, 2013, 04:07:52 am
(05:56:36 PM) emanuele: Memo: we need some of these https://github.com/emanuele45/playpen/commit/69ad5fd5042179649e2dcedae51a76cb541f9753
(05:58:56 PM) emanuele: and I think that one too: https://github.com/SimpleMachines/SMF2.1/commit/1ca74d5fe567840809da593794f93fec388327eb


Quote
(05:56:36 PM) emanuele: Memo: we need some of these https://github.com/emanuele45/playpen/commit/69ad5fd5042179649e2dcedae51a76cb541f9753
I took these (and a few more cleaning stuffs like them).
Title: Re: IRC
Post by: TestMonkey on March 26, 2013, 12:06:12 am
I took these (and a few more cleaning stuffs like them).
Please note, I didn't mean anything else than simply to let you know. Specifically, I didn't mean the little bug in news stuff shouldn't be looked at (I didn't check if we have it).
Title: Re: IRC
Post by: TestMonkey on March 26, 2013, 12:11:41 am
(10:26:50 PM) emanuele: Can we at least rename that darn $smcFunc to something easier to type? :P
(10:27:07 PM) emanuele: my last variation is smcDunk
(10:27:49 PM) emanuele: that may be the result of me being drunk of me having the typing abilities of a duck, don't know.
(10:28:06 PM) TimeVortex: Or at least something that doesn't have 'smc' in it? ;)
(10:29:49 PM) ***emanuele nods
(10:30:18 PM) ***TimeVortex proposes to make a few static classes
(10:30:53 PM) TimeVortex: Something like Utils for things like $smcFunc['substr'] and whatnot => Utils::substr
(10:31:21 PM) TimeVortex: ... if that's still relevant in an UTF-8 only environment.
(10:32:09 PM) TimeVortex: I'm still a big proponent of making a proper DBA, but I suppose static functions won't hurt in the transition.
(10:36:14 PM) Norv: Oh. Sure. /has just gone back to theme edition which is totally broken.
(10:47:58 PM) ***Norv sighs. Yep, I have somewhere precisely a Util:former_smcFunc_nondb() ... question is where.
Title: Re: IRC
Post by: TestMonkey on March 26, 2013, 12:12:11 am
(10:36:37 PM) ***emanuele would drop it completely... O:-)
(10:37:03 PM) emanuele: themes editing I mean
(10:41:36 PM) Norv: emanuele: I'm not really against it, but can we make it into a proper addon? It's all a matter of a couple of admin files and actions, and the backend for them
(10:44:52 PM) Norv: Related: I might still get, as I mess with this, to use LANGUAGEDIR. Which is to say I might also get to move it... which will 'remove' language files from theme edition, but it can be better in languages area, and not in themes area

(10:49:26 PM) Norv: Seriously, I wasn't (at all) going to remove theme edition, of course. But, I was going to ask: who the heck used it, when it doesn't work and I'm not aware of reports? Is it just me, or I may be missing something but.
(10:53:31 PM) emanuele: it doesn't work in 2.0 or in Elk?
(10:53:50 PM) emanuele: if in Elk is rather normal I think we didn't get any report. :P
(10:57:43 PM) Norv: As far as I remember about a month ago I checked the smf code for the bugs I dropped upon, and it was all there. (that's why I rant above.)
(10:57:55 PM) emanuele: lol
(10:58:18 PM) emanuele: due to my setup I cannot test this kind of things :P
Title: Re: IRC
Post by: TestMonkey on March 26, 2013, 12:14:06 am
(10:39:42 PM) TimeVortex: Meanwhile, in Arch Linux: https://www.archlinux.org/news/mariadb-replaces-mysql-in-repositories/
(10:40:10 PM) Norv: Oh!
(10:41:10 PM) TimeVortex: That'll be interesting.
(10:45:25 PM) Norv: TimeVortex: last I know, Mariadb was fully compatible with mysql
(10:46:12 PM) TimeVortex: Norv: it is indeed.


(10:55:05 PM) ***emanuele wonders if it would be nice to have a "MERGED" notice too similar to the "MOVED"
(10:56:02 PM) emanuele: and similar to the "SPLIT" (that it sill says "MOVED, but tat's another problem).
(11:00:32 PM) Norv: On merged: Probably, it is a bit annoying when you first go to a merged topic and it tells you something incorrect, heh.
(11:02:10 PM) emanuele: I was more thinking about when you go to a topic that "used" to exists but has been merged
(11:02:31 PM) Norv: yes, that's what I meant, it mumbles something about inaccessible
(11:03:05 PM) emanuele: cool, then another feature! (or is it a bug fix? :P )
(11:03:51 PM) Norv: [feature cat mode] Featurres arh a good thing, not a bad thing.
(11:04:39 PM) Norv: Hey, feature cat still has the right to exist for a bit. O:-)
(11:05:02 PM) emanuele: without feature cat we would be lost!
(11:05:26 PM) emanuele: we need badly, even after the beta, or you want to stop working on anything? :P
(11:06:10 PM) Norv: Nah, I was kinda joking. I think we can afford to continue accepting small features and functionality improvements for long.
(11:08:02 PM) Norv: We can, as long as we keep the bar high on the kind of code we accept, and continue with refactoring. These have the habit to bring to light many bugs, small or not, and make them quite quick to fix.

(11:09:09 PM) Norv: (disclaimer: ban edit iz a throughout refactoring, not a small feature O:-))
(11:10:50 PM) emanuele: ohhh...it's just one file...
(11:11:09 PM) Norv: lol
Title: Re: IRC
Post by: TestMonkey on March 26, 2013, 12:16:48 am
(12:07:07 AM) emanuele: Any idea why in ScheduledTasks the variable $is_weekly is globalized instead of passed as argument from scheduled_weekly_digest to scheduled_daily_digest?
(12:10:33 AM) Norv: emanuele: none of them have parameters, as they are called by a call_user_func()
(12:13:58 AM) emanuele: https://gist.github.com/emanuele45/73b40cc1785fb5d5d2ef
(12:14:02 AM) emanuele: wouldn't be the same?
(12:14:30 AM) emanuele: (1st pair is what we have now)
(12:16:23 AM) Norv: ema, sure.

(12:20:48 AM) Norv: https://github.com/elkarte/Elkarte/pull/205 didn't we finish actually with this?
(12:21:34 AM) emanuele: good question...
(12:21:38 AM) emanuele: I think so
(12:22:00 AM) emanuele: Ohhh...no
(12:22:06 AM) emanuele: that's the *other* one!
(12:22:16 AM) emanuele: getTopic*s*Info
(12:22:32 AM) Norv: *headscratch* :)

(12:23:46 AM) emanuele: https://github.com/emanuele45/Dialogo/commit/a63aaf341aa00b9259652edccddad968146f1f8b
(12:24:22 AM) emanuele: in fact id does an almost completely different thing lol
(12:24:55 AM) emanuele: it grabs more or less the same "basic" stuff, but then the additional options are more focused on first and last message
(12:48:58 AM) Norv: I don't know if it's only me, something is slightly strange. But there are not many ways to get topics data without, heh, getting all kinds of topics data.
(12:49:33 AM) emanuele: TBH I'm not completely sure myself about that one
(12:50:11 AM) emanuele: I added it just because I thought I needed it somewhere else, but I don't, so I'm simply ignoring it... :P
(12:54:07 AM) emanuele: if you don't see it useful or well designed feel free to close it. ;)
(12:55:28 AM) Norv: It's possible that I'm just tired and not see clearly through all these params and that. Checking the code in particular it seems ok, but the whole... not sure. I'll just let it for a while longer, in the idea that maybe next time when we mess with those queries we can review with a different better perspective.
Title: Re: IRC
Post by: Antechinus on March 26, 2013, 12:23:41 am
(10:36:37 PM) ***emanuele would drop it completely... O:-)
(10:37:03 PM) emanuele: themes editing I mean
(10:41:36 PM) Norv: emanuele: I'm not really against it, but can we make it into a proper addon? It's all a matter of a couple of admin files and actions, and the backend for them
(10:44:52 PM) Norv: Related: I might still get, as I mess with this, to use LANGUAGEDIR. Which is to say I might also get to move it... which will 'remove' language files from theme edition, but it can be better in languages area, and not in themes area

(10:49:26 PM) Norv: Seriously, I wasn't (at all) going to remove theme edition, of course. But, I was going to ask: who the heck used it, when it doesn't work and I'm not aware of reports? Is it just me, or I may be missing something but.
(10:53:31 PM) emanuele: it doesn't work in 2.0 or in Elk?
(10:53:50 PM) emanuele: if in Elk is rather normal I think we didn't get any report. :P
(10:57:43 PM) Norv: As far as I remember about a month ago I checked the smf code for the bugs I dropped upon, and it was all there. (that's why I rant above.)
(10:57:55 PM) emanuele: lol
(10:58:18 PM) emanuele: due to my setup I cannot test this kind of things :P
I wouldn't miss it. I think the languages file editing is probably fairly useful to a lot of people. I can see the point of maybe keeping css editing for themes in admin, but if php files (apart from languages) were not able to be edited in admin I think it would save a lot of n00bz getting themselves into trouble.
Title: Re: IRC
Post by: TestMonkey on March 26, 2013, 12:33:18 am
I wouldn't miss it. I think the languages file editing is probably fairly useful to a lot of people. I can see the point of maybe keeping css editing for themes in admin, but if php files (apart from languages) were not able to be edited in admin I think it would save a lot of n00bz getting themselves into trouble.
Noted. The thing is, the template edition feature provides a basic sandbox for PHP code. At least one shouldn't be able to save files with syntax errors in them. This bit is useful methinks (and that's mostly unrelated to "core or not core", it's simply a small useful bit, even if one has (or not) to first drop a package in their installation).
Title: Re: IRC
Post by: Antechinus on March 26, 2013, 01:33:45 am
Yeah but there's an option to turn off parsing of php files. Admittedly most n00bz wouldn't have that turned off, but since it's some (not sure how much) more code to run I run the site with it disabled. I suppose as long as it's on by default it'll be pretty safe for most, but the presentation in the editor is not really conducive to tracking errors anyway. There's no syntax highlighting, and formatting gets lost, and the template gets split into segments, so the whole thing is generally a bit of a schemozzle. Even with CSS files, it's really a lot easier to just download the flipping thing and edit in on your desktop.

ETA: Just had an idea. Might work, might not. How about if there was a built-in thingy to download and upload selected files? Sort of like attachment handling but for core files. Could replace the editor.
Title: Re: IRC
Post by: Arantor on March 26, 2013, 02:12:55 am
Quote
Just had an idea. Might work, might not. How about if there was a built-in thingy to download and upload selected files? Sort of like attachment handling but for core files. Could replace the editor.

I got one of those, it's called FileZilla ;)
Title: Re: IRC
Post by: Antechinus on March 26, 2013, 03:58:57 am
Yeah I know, but it's not a built-in thingy. N00bz like built-in thingys.
Title: Re: IRC
Post by: Arantor on March 26, 2013, 04:06:16 am
There are some things that shouldn't really be built in thingies. They cause a *lot* of trouble.
Title: Re: IRC
Post by: TestMonkey on March 28, 2013, 01:01:44 pm
Yeah but there's an option to turn off parsing of php files. Admittedly most n00bz wouldn't have that turned off
No, there isn't any option to turn off the check. I think you're thinking at the "standard" template eval.

The check I'm talking about prevents you from *saving* the template you're editing at all, in the admin panel, if it has syntax errors. So you just don't get a broken template. (well, not as broken as syntax errors, the rest is free game).
At least, that's how it was supposed to work. I fixed several issues with it and around it, and it's still not ok.

There are some things that shouldn't really be built in thingies. They cause a *lot* of trouble.
Yes, and a full FTP client is a different software. :) Really I think our time is better used to continue to make Elk, not to make Elk into a FTP client. I appreciate sharing your stance, Arantor, afaik you have done more than anyone on precisely this and around it.
But anyway, if anyone is willing to have such a gadget, they can make a FTP client in PHP, and embed in it Elk-specific knowledge (directories, what means each, read the theme info, the subdirectories, help, etc). Some base of working with the filesystem and a FTP client implementation exists.
Title: Re: IRC
Post by: TestMonkey on March 28, 2013, 01:06:18 pm
(05:29:49 PM) elkarte_git entered the room.
(05:29:49 PM) elkarte_git: [elkarte] none pushed 10 new commits to master: http://git.io/GnLTuQ
(05:29:49 PM) elkarte_git: elkarte/master 46d6a1b Spuds: ! More things that html5 would not like, mostly width/height on images for this batch...
(05:29:49 PM) elkarte_git: elkarte/master edd68c5 Spuds: ! similar html5 prep updates to install and upgrad...
(05:29:49 PM) elkarte_git: elkarte/master ad9a485 Spuds: ! missed the attribute...
(05:29:49 PM) elkarte_git left the room.
(05:30:53 PM) Norv: Testing github bot.

(11:56:00 PM) ***emanuele haz discovered oembed! :D

(02:22:14 AM) ElkArte_Gitbot: [Elkarte] Spuds opened pull request #276: Various fixes for several niggly things ... descriptive eh? (master...bumpsalongtheway)  http://git.io/quvT2A

(02:22:58 AM) Spuds: Well that notifcation was pretty much real time ....

(12:01:39 PM) ElkArte_Gitbot: [Elkarte] emanuele45 opened pull request #278: Fix for #277 (master...master)  http://git.io/8d39yg
Title: Re: IRC
Post by: TestMonkey on March 28, 2013, 02:27:43 pm
(03:08:58 PM) ElkArte_Gitbot: [Elkarte] norv pushed 2 new commits to master: http://git.io/IRsMrQ
(03:08:58 PM) ElkArte_Gitbot: Elkarte/master 19b6e4a emanuele: Remove of ban triggers works again... Fixes #277...
(03:08:58 PM) ElkArte_Gitbot: Elkarte/master ab8dc8d Norv: Merge pull request #278 from emanuele45/master...


(03:19:08 PM) ElkArte_Gitbot: [Elkarte] norv pushed 9 new commits to master: http://git.io/rZwV8w
(03:19:08 PM) ElkArte_Gitbot: Elkarte/master 1f15a73 Spuds: ! make sure the default avatar is served from avatars (with one / as well)...
(03:19:08 PM) ElkArte_Gitbot: Elkarte/master 2ffd03a Spuds: ! zero is a valid post group, use isset not empty for check...


(03:24:03 PM) ElkArte_Gitbot: [Elkarte] norv pushed 8 new commits to master: http://git.io/7MRDSw
(03:24:03 PM) ElkArte_Gitbot: Elkarte/master b2fe224 emanuele: When  splitting a topic is possible to move the new topic to a different board, plus it is possible to leave a message where the posts have been moved...
(03:24:03 PM) ElkArte_Gitbot: Elkarte/master 29b0557 emanuele: A small parameter to decide the behaviour of the "current board" in the dropdown: disabled or selected...
(03:24:03 PM) ElkArte_Gitbot: Elkarte/master 947146d emanuele: These are followups or whatever they would be called...
Title: Re: IRC
Post by: TestMonkey on March 28, 2013, 02:35:28 pm
The git commits notifications are better off in their own space, aren't they? I hope it's okay on the channel, but better logged separately on the site.
Title: Re: IRC
Post by: TestMonkey on March 28, 2013, 02:38:53 pm
(02:52:19 AM) Norv: seeing the spammers, I wonder if BB is working
(02:55:55 AM) Norv: Ah. It does.
(03:10:19 AM) Spuds: Yeah BB is doing what it can .... I changed the reg question to see if that helps ... removed SMF from the question, maybe you can come up with a better one.
(03:35:21 AM) Spuds: I also have not enabled the honey pot check option, so may do that to see what extra protection it provides
Title: Re: IRC
Post by: TestMonkey on March 28, 2013, 10:06:14 pm
(10:31:16 PM) emanuele: Do you plan to have multiple themes at elk.net?
(10:46:02 PM) emanuele left the room (quit: Remote host closed the connection).
(11:04:25 PM) Norv: Ah well, sorry, I wasn't paying attention to the channel. Yes of course, would have been the answer. I'd like to make the site into more of a staging/testing place, for themes as well as core code and others.
Title: Re: IRC
Post by: TestMonkey on March 31, 2013, 03:30:26 pm
(11:11:45 AM) elk_core: [Elkarte] norv opened pull request #280: Admin controllers (master...admin)  http://git.io/1lB4oA

(05:41:12 PM) Spuds: I enabled the http:bl function of BB so we can see how it deals with them spammers ... tirggerd 45 times or so last night.

(11:26:40 PM) emanuele: Norv, does it make sense? https://github.com/emanuele45/Dialogo/commit/80ed0e7ccb6bef1a13c26823c3fa8b8d1b904df0
(04:43:01 PM) Norv: emanuele: that looks fine
(04:46:41 PM) emanuele: Cool! :D
(04:50:35 PM) emanuele: I was adding few minutes ago a couple of functions: addBefore and addAfter
(04:50:37 PM) emanuele: that could be useful I think
(04:51:12 PM) emanuele: I don't like 100% the result, I'll see again after a bottle of wine. :P

(09:03:43 AM) Norv: Good morning.
(09:12:34 AM) ***Norv is amazed I still remember what I did last night and why. TimeVortex: opinions so far, on admin controllers and "settings forms": https://github.com/norv/elkarte/blob/admin/sources/admin/ManageServer.php#L113
(11:49:52 AM) TimeVortex: Don't have much time, but on first glance it looks like an OO-ified version of the ManageServer.php of old, which is a good thing. Part of me would love to see the Class-Form.php used, though. Perhaps you're already using it in a different file/level?
(12:29:25 PM) Norv: Not yet. I didn't use it yet because the refactoring to it is not working too directly (or I didn't manage to do it nicely). Perhaps with this branch (OOP versions of controllers and a "Settings_Form" which is basically very silly - but separated), I can look into using it for admin forms.

(03:58:28 PM) elk_core: [Elkarte] norv pushed 78 new commits to master: http://git.io/kfyD9w
(03:58:28 PM) elk_core: Elkarte/master 2dcf6ec Norv: Add controller class to the menu, as another index in the menu array....
(03:58:28 PM) elk_core: Elkarte/master 92cf31a Norv: Move viewadminfile action to ViewQuery....
(03:58:28 PM) elk_core: Elkarte/master 93c445b Norv: Rename the admin debugging file as AdminDebug.php....
Title: Re: IRC
Post by: TestMonkey on April 01, 2013, 01:18:12 am
(07:03:26 PM) elk_core: [Elkarte] norv opened pull request #281: Admin controllers, updates (master...admin)  http://git.io/O4YHKw
(07:10:12 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/VxRbOA
(07:10:12 PM) elk_core: Elkarte/master 582ba4a Norv: Security settings administration: rework the settings pages as 'settings forms'....
(07:10:12 PM) elk_core: Elkarte/master 5eb781f Norv: Fix core features bug. Rename the last admin area to what it currently is: features and options screens....
(07:10:12 PM) elk_core: Elkarte/master 094ffa2 Norv: Rework Features and Options pages, to use 'settings forms' and for naming patterns....

(07:04:51 PM) Norv: emanuele: the "new look" of admin area is in. /hides
(07:21:53 PM) ***emanuele goes run git pull elk master

(10:28:22 PM) ***emanuele was thinking to add sort of layers to createList too... O:-)
(10:33:11 PM) emanuele: I found again what I was playing with to extend the post area and other things, it was hidden in a branch! :D
(10:33:31 PM) emanuele: problem is I don't like it so much...
(10:40:38 PM) emanuele: I mean I don't like what I came up with, because I started make things very complex, but yet not enough flexible as I would like
(10:49:43 PM) Norv: whitish theme
(10:49:48 PM) Norv: :)
(10:50:02 PM) Norv: ah, good to hear
(10:50:17 PM) Norv: (you scared me with that loss issue :( )
(10:50:27 PM) emanuele: me too... lol
(10:55:24 PM) Norv: layers to List? No idea. /me think I should make List and Menu classes too.
(10:59:21 PM) emanuele: everything sort of started when I was plying with messageindex to make it use createList
(11:01:04 PM) emanuele: in that branch I separated the "main" part of template_show_list (the one that actually creates the list) from the part above and below (where there are the pages, and alike)
(11:02:30 PM) emanuele: this because the main body of my messageindex was rather different from the usual template_show_list (or whatever it is, I don't remember), but the rest was nice to have in place anyway without having to rewrite it
(11:03:41 PM) emanuele: so, from that to layers the step is very small
(11:43:03 PM) Norv: :)
Title: Re: IRC
Post by: TestMonkey on April 01, 2013, 01:19:27 am
(11:49:08 PM) elk_core: [Elkarte] Spuds opened pull request #282: ! Typo, should be DELETE (master...bumpsalongtheway)  http://git.io/EemT1Q

(11:49:23 PM) elk_core: [Elkarte] Spuds opened pull request #283: ! Update the old editor to 1.4.2, other changes to support were done already... (master...editor)  http://git.io/jekqig

(11:58:12 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/hKaOsA
(11:58:12 PM) elk_core: Elkarte/master 0597d73 Spuds: ! Update the old editor to 1.4.2, other changes to support were done already...
(11:58:12 PM) elk_core: Elkarte/master 9db9e5c Norv: Merge pull request #283 from Spuds/editor...

(12:01:38 AM) Norv: wow Spuds is on a roll with html5

(12:06:28 AM) elk_core: [Elkarte] norv pushed 7 new commits to master: http://git.io/du8CDA
(12:06:28 AM) elk_core: Elkarte/master ea493ee Spuds: ! remove type="text/javascript" and  type="text/css" from the default theme template files only...
(12:06:28 AM) elk_core: Elkarte/master 7e4fe10 Spuds: ! align=center to class=centertext for bbc and html5...
(12:06:28 AM) elk_core: Elkarte/master 4433186 Spuds: ! move border=0 to css for html5...
Title: Re: IRC
Post by: TestMonkey on April 01, 2013, 01:20:52 am
(12:22:23 AM) emanuele: Norv: https://github.com/emanuele45/Dialogo/commits/extend_post
(12:22:59 AM) emanuele: though, probably it would look nicer in a class like for template layers or similar?
(12:42:48 AM) Norv: Oh. Cool!
(12:43:09 AM) Norv: (sorry for the afk emanuele)
(12:43:48 AM) emanuele: don't worry, I found another template I could kill... O:-)
(12:44:03 AM) Norv: Likes.
(12:44:26 AM) Norv: if you're in the mood for a class for them layers or something, have fun
(12:44:49 AM) Norv: You're still in the business of killing templates, huh?
(12:45:01 AM) Norv: I should give you much more to kill...
(12:45:26 AM) Norv: As a gift, of course. O:-)
(12:46:17 AM) emanuele: well, it's a duplicate in that branch
(12:46:54 AM) Norv: Excuses!
(12:46:56 AM) emanuele: because I split the "make event" piece from the post page and now the two functions (the one in post and the one in calendar are almost the same, so....

(01:06:12 AM) elk_core: [Elkarte] norv opened pull request #285: Admin templates (master...admin_templates)  http://git.io/1BC_4Q

(01:29:21 AM) Norv: Is this way better or worse?
(01:29:23 AM) Norv: https://github.com/elkarte/Elkarte/pull/285
(01:38:11 AM) emanuele: core features seems a bit overkill alone in the file, though it's not a big issue
(01:52:04 AM) Norv: yes, well
Title: Re: IRC
Post by: TestMonkey on April 01, 2013, 05:55:28 am
(03:28:24 AM) elk_core: [Elkarte] Spuds pushed 3 new commits to master: http://git.io/VWvBxQ
(03:28:24 AM) elk_core: Elkarte/master 6d3a3d3 Norv: Split templates in admin area in their own files....
(03:28:24 AM) elk_core: Elkarte/master 012728f Norv: Admin template update...
(03:28:25 AM) elk_core: Elkarte/master b079fec Spuds: Merge pull request #285 from norv/admin_templates...

(03:53:34 AM) elk_core: [Elkarte] norv opened pull request #286: Playing with errors. (master...errors)  http://git.io/w2DeIA
Title: Re: IRC
Post by: TestMonkey on April 01, 2013, 10:32:46 pm
(04:10:49 PM) ***emanuele is working on too many incompatible things at the same time...meh

(07:20:01 PM) emanuele: Norv: https://github.com/emanuele45/Dialogo/commit/b4fc97c2fc47fb0d05e9f5bb1253dd93f5c2bdb9 overkill?
(07:30:46 PM) Norv: The first classes seem collection classes. We might use an utility collection class, available as a .subs?
(07:32:40 PM) Norv: Re: hidden fields. I'd like to propose something else: to use a generic form to handle any display of forms and process user input.
(07:38:18 PM) emanuele: ohh, that would probably help for issue #227 quite a bit

(07:40:43 PM) emanuele: at the moment create it would mean re-write most of the forms, but if you plan to add something like that then we (you :P ) have to rewrite them (or at least most of them anyway...
(07:40:46 PM) emanuele: am I wrong?
(07:46:16 PM) Norv: Yes, it means rewrite most (all we want) of the forms. I didn't exactly plan to add it to Elk right now, but that TimeVortex over there bugged me about it, and the rework of controllers went in the same direction: we can now replace the so-called "Settings_Form" basic class with a generic Form, based on the Compuart's Class-Form [...]
(07:47:12 PM) emanuele: lol
(07:47:26 PM) emanuele: it's always someone else's fault, I know. :P
(07:50:27 PM) Norv: Rewriting user-data gathering pages to use a generic form is quite easy, but yes, a lot of work. What makes sense to me (and if I can find time, I'll propose it as soon as possible) is to rewrite the same settings forms we've been dealing with lately. Because they're already quite "ready" and separated, with handling in one place (ok, two places) atm, and very similar
(07:52:15 PM) Norv: And, of course! But that's not important.
(07:53:16 PM) Norv: It's like your lists. We rewrite whatever we like, and remove a template in the process. O:-)
(07:53:27 PM) Norv: *tempts*
(08:00:22 PM) emanuele: yep, yep, I was just wondering if it is worth rewrite them now (at least buggy since it is code I write :P) and then rewrite them again later for the final version...
(08:03:43 PM) Norv: Hey. It's not that, but what you mean, is that I should try to focus on this and propose a workable version as soon as possible, see if you like it.

(08:11:50 PM) Norv: emanuele: so far, is admin generally understandable? How do you feel about the direction it's taking?
(08:14:42 PM) Norv: I don't "plan" to do the same with the other controllers soon. (though who knows). I mean, it is, at the limit, acceptable to me, for us to ship 1.0 with a quite different admin core internal design and implementation, than the rest. Hopefully admin playing around will be the direction that big addons can and will take. Then we can rewrite the rest in time for Elk core.

(08:33:41 PM) elk_core: [Elkarte] norv pushed 1 new commit to master: http://git.io/bLI3xg
(08:33:41 PM) elk_core: Elkarte/master fd594e8 Norv: Tweak index.php doc....
Title: Re: IRC
Post by: TestMonkey on April 01, 2013, 10:35:32 pm
(09:22:51 PM) elk_core: [Elkarte] eurich opened pull request #287: refactoring manage mails. (master...refactor_managemail)  http://git.io/yFYKow

(09:28:31 PM) emanuele: Norv, TBH I haven't looked at admin code...

(10:14:53 PM) Norv: oh, TE is working on refactoring on the admin classes, better encapsulation and separation of low-level code
(10:16:02 PM) Dragooon: Interestin!
(10:44:43 PM) Norv: I had committed a quite basic reworking of admin code. He makes it more as it *should* be

(11:04:02 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/lRVWSQ
(11:04:02 PM) elk_core: Elkarte/master 18b94d3 Thorsten Eurich: refactoring manage mails....
(11:04:02 PM) elk_core: Elkarte/master 7444758 Thorsten Eurich: typo ... thanks Norv :)...
(11:04:02 PM) elk_core: Elkarte/master e8b0964 Thorsten Eurich: remove unused parameter from list_getMailQueueSize .. Thanks Norv :)...
Title: Re: IRC
Post by: TestMonkey on April 01, 2013, 10:39:16 pm
(08:04:51 PM) Norv: On another note, may I ask (I know I'm annoying you), is it possible to try over on elk.net your white-ish theme?
(08:05:23 PM) emanuele: well...yes, but is still pretty broken... O:-)
(08:05:57 PM) Norv: That thing sits on my brainz pretty badly. I might do it myself (but you don't want that!!), because I feel we need to experiment with the new look
(08:06:43 PM) Norv: I like the white-ish (always did, well for a long time anyway)

(09:30:41 PM) emanuele: white-theme: if you want just the css I think I can try to take it out from the commits, it shouldn't be too difficult (also because I tried to do all the "structural" changes using js and jquery)

(09:50:39 PM) Norv: emanuele: Re: white-theme: I didn't mean only css. What commits? I am totally willing (and excited) to try it anyway, up to you to say/choose whatever you like from it
(09:52:40 PM) ***emanuele is killing a 1px jomp in the dropdown menu area
(09:54:46 PM) Norv: Think of it this way: if we use it we'll grumble and fix it :). You don't need it to be "omg perfectly working" before O:-)
(10:52:02 PM) Norv: what better way is there, to fix it, than to use it?
Title: Re: IRC
Post by: TestMonkey on April 01, 2013, 10:40:46 pm
(11:14:40 PM) emanuele: mmm...is there any simple way to "share" the branch between the two repos?
(11:16:30 PM) Norv: Add the repos as remotes, and push the branch to both remotes?
(11:16:54 PM) emanuele: but they have different structure
(11:17:06 PM) Norv: what repos are they?
(11:17:14 PM) emanuele: elk and elk.net
(11:17:53 PM) Norv: Ah. The subfolder is the problem
(11:18:26 PM) emanuele: I suppose I just have to keep the history in my repo and push to elk.net just once in a while...
(11:19:06 PM) Norv: Mmm. We have more options... Lets see..we can pick whatever we want for elk.net, so make it easier
(11:19:38 PM) Norv: 1. you can initialize a repo in /elk, with elk remote. And pull from the remote
(11:19:49 PM) Norv: then commit to elk.net
(11:21:31 PM) Norv: 2. /elk can be a submodule (I actually made it first that way) which means 1) is straightforward, it's just the way it works.
(11:23:59 PM) emanuele: ...I just have to re-do everything after Spuds updates... index.css is just one big conflict... lol
(11:25:02 PM) Norv: btw, what do you use for conflicts diff/merge? I just love the combination Cola Git plus Meld
(11:26:01 PM) Norv: it's a breeze, because Cola opens a three-way merge in Meld
(11:26:33 PM) emanuele: mmm...no, that's again one of my commits that it always give me problems during rebase...
Title: Re: IRC
Post by: TestMonkey on April 01, 2013, 10:45:44 pm
(11:41:25 PM) emanuele: take it. :P

(11:41:26 PM) elk_net [~elk_net@router1-ext.rs.github.com] entered the room.
(11:41:26 PM) elk_net: [elkarte.net] emanuele45 opened pull request #1: You wanted it :P (master...minimalist_white)  http://git.io/z22nfA
(11:41:26 PM) elk_net left the room.

(11:41:45 PM) emanuele: darn fast this bot! :P
(11:44:28 PM) Norv: :D
(11:44:42 PM) Norv: Oh so fast! Thank you!

(11:47:06 PM) elk_net: [elkarte.net] norv pushed 2 new commits to master: http://git.io/TITgBw
(11:47:07 PM) elk_net: elkarte.net/master f75bc33 emanuele: Minimalist white theme - first draft...
(11:47:07 PM) elk_net: elkarte.net/master 4a01617 Norv: Merge pull request #1 from emanuele45/minimalist_white...
Title: Re: IRC
Post by: TestMonkey on April 02, 2013, 12:09:03 am
(12:05:50 AM) Trekkie101: Whats this minimalist white stuff :P?
(12:05:55 AM) Trekkie101: Do share, do share :P
(12:06:34 AM) Norv: New theme for elk
(12:06:52 AM) Norv: Take a look at the link if you want
(12:07:14 AM) Trekkie101: What link?
(12:07:17 AM) Trekkie101: The git one?
(12:07:20 AM) Norv: yes
(12:07:42 AM) Trekkie101: It doesnt have screenshots :P
(12:08:06 AM) Trekkie101: and unlike you neonorv I can't read the matrix
(12:08:58 AM) Norv: Ah lol!! Well, if you wish you can grab it from the elk.net repo https://github.com/elkarte/elkarte.net
(12:09:36 AM) Norv: and we install it on the site
(12:09:54 AM) Trekkie101: Is it on the site though?
(12:10:02 AM) Trekkie101: Also any way do download the zip of just the theme :P?
(12:10:12 AM) Norv: please note that it's wip, not supposed to be finished
(12:10:24 AM) Norv: Mmm. Give me a moment.
(12:10:31 AM) emanuele: http://img10.imageshack.us/img10/514/screen91b.png
(12:10:54 AM) emanuele: arg I forgot to add back the go up/down... lol
(12:11:41 AM) Trekkie101: Oh thats nice :)
(12:12:06 AM) Trekkie101: Delicate :)
(12:13:00 AM) emanuele: it's basically the first time I try to modify a theme...well, the second, the first was on 1.1... lol
(12:13:53 AM) Trekkie101: Well it looks good :P
(12:15:13 AM) emanuele: :D
(12:15:45 AM) emanuele: It's not yet as clean as I would like (i.e. I have to remove several other things... O:-))
(12:16:37 AM) Trekkie101: Im interested :P
Title: Re: IRC
Post by: TestMonkey on April 02, 2013, 12:14:37 am
(12:20:08 AM) emanuele: mmm...Norv, should we add a "quote to PM" too? O:-)
(12:20:44 AM) Norv: if you want
(12:27:53 AM) emanuele: not in particular, my mind was just running wild...
(12:28:39 AM) emanuele: I just started the merged_notice branch, I remember I already did in the past and it was not so straightforward...

(12:32:33 AM) Norv: Serious question: does anyone actually use 'previous/next topic' links?
(12:32:49 AM) Trekkie101: Nope
(12:32:55 AM) Trekkie101: But I'd use a NEXT PAGE link
(12:33:11 AM) Trekkie101: Top/NEXT
(12:33:24 AM) Norv: Next page of the current topic, right?
(12:33:34 AM) Trekkie101: yup
(12:33:42 AM) Trekkie101: Its very odd that it doesn't do this
(12:34:13 AM) Norv: Makes sense. It has the '1 2 3' thingie, but those are harder to find and click

(12:33:59 AM) Trekkie101: Also just before I run out the door but on this topic
(12:34:11 AM) Trekkie101: No-one actually changes their preferences in profile
(12:34:22 AM) Trekkie101: Like posts per page etc

(12:34:31 AM) emanuele: I think some use them, not by clicking, but through the browser's internal handling
(12:35:03 AM) emanuele: but I have no figures to support that feeling
(12:35:04 AM) Trekkie101: We could expose that functionality somehow, like a tip bubble that pops up
(12:35:08 AM) Norv: the 1, 2, 3, Ema, or the prev/next ?
(12:35:14 AM) emanuele: prev/next

(12:35:28 AM) Trekkie101: "Hey are there enough messages for you here, or would you prefer to see more or less per page"
(12:35:36 AM) ***Trekkie101 runs to go get the girlfriend from work

(12:35:37 AM) emanuele: the <link rel="next" href I think
(12:35:43 AM) Norv: Trekkie101: roger, not sure how, but yes
(12:36:02 AM) Norv: Ah ok. That's probably right, ema
(12:37:13 AM) Norv: but the thing is, I don't see a discussion forum users using too much *random* topics
(12:37:30 AM) Norv: I mean, navigation to 'prev/next' is blind navigation
(12:37:36 AM) Norv: you don't even see the title
(12:37:39 AM) Norv: it's odd
(12:38:04 AM) Norv: I think people want to read *something*, a particular subject they want to know about
(12:38:33 AM) Norv: if it's prev or next, is not relevant info for choosing what to read

(12:38:35 AM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(12:38:36 AM) elk_core: [Elkarte] Spuds opened pull request #288: Minor template / theme / html5 fixes (master...bumpsalongtheway)  http://git.io/PAjFEg
(12:38:36 AM) elk_core left the room.

(12:39:10 AM) emanuele: yes, that for sure
(12:39:22 AM) Norv: Not sure if I express my feeling clearly here. (of course, we could display the subject, but it's still chosen by prev/next criterion)
Title: Re: IRC
Post by: TestMonkey on April 02, 2013, 12:15:02 am
(12:40:25 AM) emanuele: and also it would require some more db work, since the prev/next at the moment are special actions that don't even know the topic id
(12:42:05 AM) Norv: I think that's a bit unfortunate, because hey, it's the display page, the most used :)
(12:44:48 AM) Norv: though I guess it could be in a measure cached. But dunno if it's worth doing it at all. I'd rather support giving it up, or make sure it's optional and disabled by default - I think what I'm trying to say is that it's more for a "blog"-type of reading, than a forum-type of reading... If topic first posts would be tagged by semantic category, and prev/next would give you the next by meaning, well maybe

(12:46:11 AM) emanuele: you may see it in action a wedge
(12:47:08 AM) emanuele: I've never used it (not that I browsed it extensively), though from time to time I'm confused by the fact that there are three titles in a row
(01:05:25 AM) Norv: Right, it's interesting as done on wedge. At least you know if the 'next' might interest you, in case it does you're saved a trip to message index. OTOH, it's still random chance: since it's chosen chronologically, it seems fit for blog-type or annoucement-type boards, less other general discussions.

(12:48:41 AM) emanuele: darn, with that the redirect is becoming a pretty used (sub)template...

(01:02:15 AM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(01:02:15 AM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/5xmqeg
(01:02:15 AM) elk_core: Elkarte/master 62d8e8f Spuds: ! missing " :'(...
(01:02:15 AM) elk_core: Elkarte/master c779c8b Spuds: ! classic update for avatars...
(01:02:15 AM) elk_core: Elkarte/master 3963e4a Spuds: ! tweak the followups button placement...
(01:02:15 AM) elk_core left the room.

(01:03:25 AM) TehCraw: Cool github notifications.
(01:06:08 AM) Norv: Yup, we haz a spammer in the channel :D
(01:11:18 AM) Norv: (as if Ema wasn't bugged enough by only me)
Title: Re: IRC
Post by: TestMonkey on April 02, 2013, 02:57:49 pm
(05:56:17 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/D_m3ng
(05:56:17 AM) elk_core: Elkarte/master 94d9b92 Norv: Playing with errors. With error strings, I mean....
(05:56:17 AM) elk_core: Elkarte/master 0b13a21 Norv: Tweak documentation....
(05:56:17 AM) elk_core: Elkarte/master daa6bb9 Norv: Merge pull request #286 from norv/errors...

(06:17:24 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/fyFQXg
(06:17:24 AM) elk_core: Elkarte/master 03c9455 Spuds: ! I think this puts these templates back to what they were before the last merge undid a bunch of work ... tl;dr github sucks...
(06:17:24 AM) elk_core: Elkarte/master bfe52e1 Spuds: ! fat fingered that one ... at least it worked :P...
(06:17:24 AM) elk_core: Elkarte/master cae4d0a Norv: Merge pull request #290 from Spuds/bumpsalongtheway...

(08:23:12 AM) elk_core: [Elkarte] eurich opened pull request #292: Refactor AdminDebug & AdminLog (master...refactor_admin_debug)  http://git.io/_LGc6Q
(08:27:07 AM) elk_core: [Elkarte] norv pushed 12 new commits to master: http://git.io/zwwQNQ
(08:27:07 AM) elk_core: Elkarte/master 52a247f Thorsten Eurich: unused globals...
(08:27:07 AM) elk_core: Elkarte/master dae97dd Thorsten Eurich: methods visibility...
(08:27:07 AM) elk_core: Elkarte/master 5deb37a Thorsten Eurich: cleanup...
(08:43:09 AM) elk_core: [Elkarte] norv opened pull request #293: Fix copyright notice. (master...admindebug_copyright)  http://git.io/aW-ZnA

(08:50:28 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/3q8USw
(08:50:28 AM) elk_core: Elkarte/master 8565737 Norv: Fix copyright notice. New file with nothing copyrightable yet. There is nothing copyrightable in a select query with two params....
(08:50:28 AM) elk_core: Elkarte/master f501bb1 Norv: Merge pull request #293 from norv/admindebug_copyright...
Title: Re: IRC
Post by: TestMonkey on April 02, 2013, 02:59:06 pm
(08:44:46 AM) groundup: What software runs elk_core?
(08:58:41 AM) Norv: groundup: it's a github hook. This is the code: https://github.com/github/github-services/blob/master/lib/services/irc.rb. It is deployed on github.com, you can enable it from the repo admin settings.

(01:46:42 PM) elk_themes: [themes] norv pushed 25 new commits to master: http://git.io/ICo2_g
(01:46:43 PM) elk_themes: themes/master 3eaf1c4 enyst: Alien theme files....
(01:46:43 PM) elk_themes: themes/master b29470b enyst: Add readme....
(01:46:43 PM) elk_themes: themes/master 51b53d7 enyst: Forgotten admin.css...

(01:50:28 PM) Trekkie101: Elk just went green
(01:50:33 PM) Trekkie101: Like NOW
(01:50:50 PM) Trekkie101: It doesn't surely update from git *that* fast?
(02:04:09 PM) Norv: No, I did it manually :)
(02:04:35 PM) Norv: That's a greenish color variation that was PRed for the themes repository
(02:05:19 PM) ***Norv is fast. O:-) Well, by mistake, I assure you.
(02:07:24 PM) Norv: engelnyst made a PR a while ago, though it seemed both unfinished and not get interest, dunno
(02:09:30 PM) Norv: Ohh theme selection is buggy.
(02:09:47 PM) Norv: That must be my doing... /checks

(02:45:29 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(02:45:29 PM) elk_core: [Elkarte] norv opened pull request #294: Theme select (master...theme_fix)  http://git.io/j65LMg
(02:45:29 PM) elk_core left the room.
Title: Re: IRC
Post by: TestMonkey on April 02, 2013, 07:57:58 pm
(04:23:03 PM) elk_themes: [themes] norv pushed 1 new commit to master: http://git.io/GH4vQQ
(04:23:03 PM) elk_themes: themes/master 9805fab Norv: Updates to the current version for Alien....

(07:18:11 PM) elk_themes: [themes] norv pushed 2 new commits to master: http://git.io/l8JTyg
(07:18:11 PM) elk_themes: themes/master 1c2c54e IchBin: ElkArte mobile theme...
(07:18:11 PM) elk_themes: themes/master 7a13ae0 Norv: Merge branch 'master' of github.com:elkarte/themes

(07:23:50 PM) elk_themes: [themes] norv pushed 1 new commit to master: http://git.io/ecbvCQ
(07:23:50 PM) elk_themes: themes/master 278fd2e Norv: Update to Elk information....

(07:50:43 PM) elk_core: [Elkarte] eurich opened pull request #295: Manage attachments refactoring (master...manage_attachments)  http://git.io/JU7TXw
Title: Re: IRC
Post by: TestMonkey on April 02, 2013, 11:58:19 pm
(04/03/2013 12:01:02 AM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(12:01:02 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/x8k4Yw
(12:01:02 AM) elk_core: Elkarte/master 510d4f0 Spuds: ! I don't see how it was working calling settings...
(12:01:02 AM) elk_core: Elkarte/master 87ff53b Norv: Merge pull request #296 from Spuds/bumpsalongtheway...
(12:01:02 AM) elk_core left the room.


(12:08:55 AM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(12:08:55 AM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/mvNvWQ
(12:08:55 AM) elk_core: Elkarte/master 8f17fc1 Thorsten Eurich: basic cleanup (unused globals, empty lines, missing global..)...
(12:08:55 AM) elk_core: Elkarte/master 157541f Thorsten Eurich: Move functions to ManageAttachments subs......
(12:08:55 AM) elk_core: Elkarte/master 5c209fa Thorsten Eurich: Split db queries to their own function....
Title: Re: IRC
Post by: TestMonkey on April 03, 2013, 12:13:25 pm
(04:15:17 AM) elk_core: [Elkarte] Spuds opened pull request #297: Some more minor cleanup before I forget (master...bumpsalongtheway)  http://git.io/2j6tJQ

(05:24:56 AM) groundup: test
(05:25:11 AM) groundup: webchat.freenode.net is awesome... except when it doesn't keep me connected
(05:25:19 AM) groundup: and when I have to do their stupid CAPTCHA

(05:27:16 AM) groundup: Norv, http://www.infoq.com/news/2013/04/software-design-21st-century
(05:38:32 AM) groundup: Norv: is this something you guys might be interested in: http://screencast.com/t/OZ7Mhk1LBQS
(05:38:42 AM) groundup: It is essentially just a "does this work" checklist

(11:14:01 AM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/KS8Ldg
(11:14:01 AM) elk_core: Elkarte/master eb2b8ce Spuds: ! couple of unused globals...
(11:14:01 AM) elk_core: Elkarte/master 61c07e7 Spuds: ! show the more button for the report to moderator action...
(11:14:01 AM) elk_core: Elkarte/master c5a2239 Spuds: ! while the key block is there, make sure its still 2x2 when they can't post and fred is not there...

(11:24:05 AM) Norv: groundup: what app is http://screencast.com/t/OZ7Mhk1LBQS ? And, have you used it, how do you feel it helps?
(11:25:48 AM) Norv: It looks pretty much as the suites made by sinan, apparently more managed.

(11:45:06 AM) Norv: Trekkie101: fixed. No, really, must be fixed. :D
(11:46:13 AM) Trekkie101: What have you fixed :P?
(11:47:05 AM) Norv: Select themes on site. It wasn't updated from git, please see if it works though.
(11:50:25 AM) Trekkie101: Works :)

(12:10:01 PM) elk_themes: [themes] norv pushed 2 new commits to master: http://git.io/PvBeeg
(12:10:01 PM) elk_themes: themes/master e1e90d7 Norv: Removed temporary placeholder....
(12:10:01 PM) elk_themes: themes/master 1d7afc9 Norv: Add Minimalist White theme....
Title: Re: IRC
Post by: TestMonkey on April 05, 2013, 03:53:08 am
(04:16:13 PM) emanuele: On the other hand...aren't we already late with our beta?
(04:16:15 PM) emanuele: :P
(04:16:57 PM) emanuele: wasn't it planned for end of March or something? O:-)
(04:18:16 PM) Norv: Yup. And I finally did (part one) of admin controllers EXACTLY on 31 March.
(04:18:34 PM) Norv: (I tried to merge it in March lol - no I'm joking :D)
(04:18:41 PM) emanuele: LOL
(04:18:48 PM) Norv: So it's April. Wha'? :P
(04:18:50 PM) emanuele: but the form thing?
(04:18:54 PM) emanuele: O:-)
(04:20:03 PM) emanuele: I mean is it set for 1.0?

(04:24:52 PM) Norv: Re: is it for 1.0: now that I got into it, I'd finish off several forms, and PR it. Actually "beta" doesn't depend on it, but the thing with 1.0 is that, at the level of design, I'd would really love it if it has the essential of the path we take, and the path for addons and themes.
(04:26:05 PM) emanuele: well, for beta at least have "the code" and one form... I think...no?
(04:26:12 PM) emanuele: (or "some code")
(04:27:37 PM) Norv: Well... it does end up this way, even if it doesnt need it... But lets see: one thing I would have liked to do, would be a quick chat on what we want for beta.

(04:28:07 PM) Norv: lets take it the other way around: what do we miss, to feel comfortable to release beta?
(04:28:41 PM) Norv: My answer: theme enough to know the look of Elk
(04:29:16 PM) emanuele: yeah, the look&feel is important
Title: Re: IRC
Post by: TestMonkey on April 05, 2013, 03:56:14 am
(04:58:39 PM) emanuele: oh, interesting bump: http://www.simplemachines.org/community/index.php?topic=483878.0
(04:59:15 PM) emanuele: what do you think?

(05:35:53 PM) Norv: Re:sqlite: (quick thought before seeing all software and licensing stuff here, I am at the middle of the thread lol oops): can we get people to commit in github open licensed proposals/works? And go from there. I would love to see nend taking care of sqlite, he seems to already do that.
Title: Re: IRC
Post by: TestMonkey on April 05, 2013, 04:28:21 am
(07:08:36 PM) emanuele: this morning I was thinking how to allow addons to extend the buttons in the messages (quote/edit/more/etc.)
(07:09:06 PM) emanuele: I tried something a while ago on SMF: https://github.com/emanuele45/playpen/tree/template_quickbuttons_strip
(07:09:39 PM) emanuele: but I was now thinking to do something more similar to the errors class and have a small class to handle that (or all) buttons too
(07:09:44 PM) emanuele: question is:
(07:10:14 PM) emanuele: the "move" and/or possible dropdown on any of the buttons is a source-thing or a theme-thing?
(07:10:28 PM) emanuele: I'd say ...depends... lol
(07:11:00 PM) emanuele: but I would avoid make things too complex...and for me is rather easy to complicate even the easiest task...
(07:11:16 PM) emanuele: so...any suggestion?
Title: Re: IRC
Post by: Arantor on April 05, 2013, 06:23:20 am
Just don't ask what we did in Wedge. That crap scares me these days for extending menus. It's very efficient and very compact but hell to figure out if you haven't seen it in a while.
Title: Re: IRC
Post by: TestMonkey on April 06, 2013, 11:29:39 am
(05:57:32 PM) groundup: In display.controller.php is https://gist.github.com/joshuaadickerson/5319926 that should probably be moved after everything else with two things - cache it & check if it is needed after all of the other posts are loaded. Chances are, it isn't.
(05:58:42 PM) groundup: The check for $modSettings['oldTopicDays'] should be done before all of that even
(07:03:38 PM) Norv: groundup: right, on oldTopicDays
(07:04:57 PM) Norv: Not sure about the first (don't have all the code in front of me). PRs are gratefully accepted. ;)
(07:06:07 PM) groundup: I don't have a Elkarte Git repo right now
(07:06:33 PM) groundup: I do have a copy of it downloaded which is how I was looking
(07:32:16 PM) Norv: Ah ok.
(07:37:25 PM) groundup: You know what is incredibly annoying about log_errors? It doesn't log the line of the error
(07:37:48 PM) groundup: and for whatever reason, it isn't logging to my normal php error log
(07:38:09 PM) groundup: (only parse errors are logging to there)
(07:39:36 PM) groundup: ah, there we go. My mistake. (playing with things)
(07:39:49 PM) groundup: still... that is very annoying when I do that :P ;)

(06:16:22 AM) groundup: Norv, is $languagedir supposed to be used as a variable?
(06:16:44 AM) groundup: In index.php it is the only one of those vars that is not unset
(12:28:55 PM) Norv: Yes, I think it's still used, or was. It's not supposed to, it's supposed to become replaced with the constant, and used even in places where before, /themes/default/languages was hardcoded. Will check the actual status
Title: Re: IRC
Post by: TestMonkey on April 19, 2013, 09:57:46 pm
(01:36:28 AM) emanuele: 78?
(01:36:34 AM) emanuele: arg...no
(01:37:04 AM) TehCraw: 78 what?
(01:38:04 AM) emanuele: ~((0040 + 0x20) + (0b111 << 1))
(01:38:17 AM) emanuele: looks more like a 49
(01:38:59 AM) TehCraw: Say, that familiar. :P
(01:39:28 AM) TehCraw: I don't remember what it is. LOL
(01:39:35 AM) TehCraw: Let me figure it out again.
(01:39:59 AM) emanuele: 42 would be better. :P
(01:40:26 AM) emanuele: darn, it's again a new day...
(01:43:41 AM) TehCraw: You were close to right the first time. It's -79
(01:43:48 AM) TehCraw: Because of the ~ operator.
(01:46:01 AM) emanuele: 0040 => 100000?
(01:46:15 AM) emanuele: 0x20 => 100000=
(01:46:34 AM) emanuele: 0b111 => 1110?
(01:46:44 AM) emanuele: scratch that last one
(01:46:56 AM) TehCraw: 0040 is octal 32, and 0x20 is hex 32
(01:48:04 AM) emanuele: and the last one?
(01:48:20 AM) TehCraw: trying to remember this stuff. It's been a while.
(01:49:38 AM) emanuele: take your time, I'm going bed. :P
(01:49:53 AM) emanuele left the room (quit: Remote host closed the connection).
(01:50:02 AM) TehCraw: Dang it, so close too
(01:51:26 AM) TehCraw: For my own memory refreshing, binary 111 is 7. Bitshifted once left it becomes 14.
(01:52:05 AM) TehCraw: So: ((32 + 32) + (14) = 78
(01:52:24 AM) TehCraw: Add the ~ before it all, and wham, -79
Title: Re: IRC
Post by: TestMonkey on April 19, 2013, 09:59:48 pm
(10:32:15 PM) emanuele: http://www.theregister.co.uk/2013/04/18/github_licensing_study/
(10:33:49 PM) emanuele: Mine are probably falling into the 85.1% because I don't have a readme or license in the top-level dir... :P
(10:39:54 PM) Norv: :D
(10:40:37 PM) Norv: Yep, I know it was a concern. Afaik OSI tried to convince github to do something, but failed at least atm.
(10:40:46 PM) emanuele: I still don't understand if at github you can host non-open source projects
(10:41:29 PM) emanuele: all the terms speak about "public", but I can't find any reference to the license...unless I'm completely blind
(10:42:06 PM) Norv: That's what I don't like. It's almost autocontradictory, it can lead people to use code from github freely (fork etc) and yet it has unclear licensing.
(10:42:41 PM) Norv: At least one kind of licenses are clearly possible (since github has no rules actually): non-commercial.
(10:43:30 PM) Norv: (they're non-OSI/free, but yeah you can fork/distribute/etc)
(10:45:41 PM) emanuele: but the funny part is that you can find projects with licenses that explicitly forbid redistribution hosted (publicly) at github
(10:45:50 PM) ***Norv uses the ban hammer, a quick swing.
(10:46:18 PM) Norv: That part is what me doesn't find funny. I don't know why exactly OSI failed yet... but it's not ok IMO.
(10:46:59 PM) ***Norv is more old fashioned and prefers clear open/free licensing.
(10:47:29 PM) Norv: Have you seen also Luis Villa's theory article?
(10:48:01 PM) Norv: POSS world: post-open-source-software world, heh.
(10:49:29 PM) Norv: The thing is, people don't read. (hah). You're giving them a project with all tools to fork/distribute in an environment inviting them to do it; and you license it to forbid it... smells bad.
(10:49:41 PM) emanuele: nope, I found that one by chance... lol (I didn't even realise it was from yesterday until I saw the link in the IRC window... lol)
(10:50:05 PM) emanuele: ROFL The fact that people don't read is nothing new! :D
(10:50:21 PM) Norv: http://tieguy.org/blog/2013/01/27/taking-post-open-source-seriously-as-a-statement-about-copyright-law/
Title: Re: IRC
Post by: TestMonkey on April 24, 2013, 04:40:59 pm
(10:10:28 PM) emanuele: upgrade question, I just wrote a comment like this:
(10:10:42 PM) emanuele:  Pick one of the new variables at random and check it: if missing it's SMF and we cannot rely on Settings
(10:11:27 PM) emanuele: In other words we cannot trust Sources for example
(10:11:36 PM) emanuele: is it an acceptable assumption?
(10:12:27 PM) emanuele: Or should we do some more checks to make sure users have moved what we have in sources to Sources?
(10:23:44 PM) groundup: More checking is better than making the user do it
(11:18:59 PM) Norv: >> (10:10:42 PM) emanuele:  Pick one of the new variables at random and check it: if missing it's SMF and we cannot rely on Settings
(11:18:59 PM) Norv: I think it's reasonable
(11:57:34 PM) emanuele: why the upgrade doesn't want to work with js disabled... :'(

(04/21/2013 12:07:28 AM) emanuele: That is funny I'd say
(12:07:36 AM) emanuele: http://www.simplemachines.org/community/index.php?topic=497135.0
(12:08:01 AM) emanuele: I tried the changes proposed and it doesn't work anyway
(12:08:13 AM) emanuele: trying to debug, it apparently fails on that query:
(12:08:19 AM) emanuele: INSERT IGNORE INTO smf_board_permissions (ID_GROUP, ID_BOARD, permission) VALUES (3, 0, 'moderate_board'), (2, 0, 'moderate_board')
(12:08:50 AM) emanuele: now, that query is there since 1.0 and it has never failed...as far as I know
(12:09:20 AM) emanuele: though, is not in the list of caught query errors here:
(12:09:22 AM) emanuele: $error_query = in_array(substr(trim($string), 0, 11), array('INSERT INTO', 'UPDATE IGNO', 'ALTER TABLE', 'DROP TABLE ', 'ALTER IGNOR'));
(12:10:10 AM) emanuele: It shouldn't make any difference because it's not a duplicate entry the error
(12:10:44 AM) emanuele: the column has been renamed to...
(12:14:08 AM) emanuele: could it be that at a certain point some default setting in mysql has changed and before case in table names was not important and now it is?
(12:15:14 AM) ***emanuele tries to find informations
(12:21:21 AM) emanuele: no, wait ID_BOARD has been removed!
(12:21:39 AM) emanuele: or better sort of renamed to id_profile
(12:22:44 AM) emanuele: how the heck this code has worked since now? ???
(12:32:15 AM) emanuele left the room (quit: Remote host closed the connection).
(01:53:58 AM) Norv: lol...
Title: Re: IRC
Post by: TestMonkey on April 24, 2013, 04:56:16 pm
(11:28:39 PM) groundup: There should be an IP table instead of storing IPs as characters. I think it would make storing and looking them up much faster.
(11:30:05 PM) groundup: id_ip INT, ip binary(16); then in all of the tables that have an IP, you'd have id_ip.
(11:31:01 PM) TehCraw: I like that. Seems like it would be a bit faster.

(05:23:56 AM) TehCraw: https://github.com/SimpleMachines/SMF2.1/issues/338
(05:41:57 AM) groundup: Let me know if my fix fixes it

(05:59:25 AM) groundup: Why doesn't $modSettings['avatar_default'] relate to a path instead of a boolean? $user_settings['avatar'] = 'default_avatar.png'; doesn't allow you to hook or change the default
(07:45:37 PM) Norv: groundup: Re: default avatar. Looks like you're right, though you can change the image. But please feel free to add a hook too, if you need it.
Title: Re: IRC
Post by: TestMonkey on April 24, 2013, 04:57:03 pm
(07:36:01 AM) groundup: Is there any documentation around on how to use GenericList.template.php?
(07:59:50 AM) groundup: Why does List.subs.php contain assert()?

(07:32:15 PM) Norv: groundup: take a look at a file like this: https://github.com/elkarte/Elkarte/blob/master/sources/controllers/Groups.controller.php . It's easy to use. I don't think (that I remember) that List is documented outside code.
(07:33:12 PM) emanuele: you mean createList?
(07:33:44 PM) Norv: yes
(07:33:46 PM) emanuele: http://wiki.simplemachines.org/smf/User:Emanuele/codedoc#createList
(07:33:59 PM) emanuele: not exactly documentation, but quite a bit of description
(07:34:13 PM) emanuele: should include everything available up to 2.1
(07:34:16 PM) Norv: Ohh thank you, how did I forget. I even stole it!
(07:34:41 PM) Norv: https://github.com/elkarte/Elkarte/wiki/Createlist
(07:34:46 PM) emanuele: You didn't write it, that's why you can forget it! :P
(07:34:50 PM) Norv: True!
(07:36:08 PM) emanuele: though I think I added a couple of other things in Elk...
(07:37:28 PM) Norv: Heh, it might be good to write them down... Just think of it as a note, not documentation O:-)
(07:39:44 PM) ***Norv doesn't hope that trick will work for them lazy coders. Ah well. It's always this way.

(11:45:29 PM) groundup: Thanks for that doc emanuele (and Norv heh). Though, I spent a bunch of time
reading the file last night to figure it out lol.
Title: Re: IRC
Post by: TestMonkey on April 24, 2013, 04:57:58 pm
(06:43:23 PM) Norv: oh yet another awesome refactoring from TE there!

(07:20:43 PM) ***Norv thinks ManageBadBehavior wants a GenericList
(07:23:59 PM) ***emanuele thinks Norv is suggesting someone that likes createList to have a look at some code
(07:24:13 PM) Norv: O:-)
(07:27:20 PM) ***Norv is innocent (except... usually :P) and, knows fans of createList which is awesome for any bit forward! *sagenods*

(08:04:44 PM) Dragooon_Mac: emanuele: Do you mind if I borrow your mobile device detect mod for my theme?
(08:04:59 PM) emanuele: Feel free!
(08:05:11 PM) Dragooon_Mac: The theme is paid and closed, so I just want to confirm
(08:06:37 PM) emanuele: yep, no problem (just pay attention because I think in the "in depth" detection there is something wrong...)
(08:07:02 PM) Dragooon_Mac: I'll push any improvements if they're good for all, of course. Thanks :)
(08:07:11 PM) emanuele: I didn't debug that part recently because not having a mobile-something is annoying to do... :P
Title: Re: IRC
Post by: TestMonkey on April 24, 2013, 05:08:04 pm
(11:50:49 PM) groundup: I am using a highly modified version of SMF/Elkarte (it is actually Elkarte at this point) for a site I am working on.
(11:51:42 PM) groundup: To make it familiar, I will just use the idea of topics and subjects. So the subject would be something like "Hello Compuart, glad to have you around" and I am looking for "hello compuart". How does it do phrase searching? How do I boost exact matches?
(11:52:22 PM) groundup: and how do I do 'hello' 'compuart' as different ones? The only way I've gotten it to work is with a wildcard between each space but what about other punctuation?
(11:54:37 PM) Compuart: I'm actually not that familiar with the full text search capabilities. We use it mostly for structured searches with huge amounts of properties and (single word) filters
(11:58:48 PM) groundup: How does it compare in speed with MySQL for facet searches?
(11:59:01 PM) groundup: Are you running it distributed?
(11:59:08 PM) Compuart: it's in a completely different league
(11:59:34 PM) groundup: You saying better or just different?
(11:59:40 PM) Compuart: yeah, it's just like Sphinx, a thousand times faster than MySQL could ever be with regards to these kinds of searches
(04/24/2013 12:00:06 AM) groundup: ah okay. Good thing I made that choice early on to use it. Now I just need to get this damn FT stuff working
(12:00:17 AM) Compuart: besides, it's specifically made to do facet search. It does it quite good
Title: Re: IRC
Post by: TestMonkey on April 24, 2013, 05:08:37 pm
(01:31:11 AM) emanuele: BTW without temporary tables on action=unread it seems really much faster the site now
(01:33:10 AM) emanuele: action=unread;all 2252nd page loads in ~1 sec. before it was...I don't think it loaded at all... lol
(01:33:30 AM) emanuele: (yeah, 67530 unread messages)
(01:33:42 AM) Norv: on which site, cats you were working on? it had a significant load
(01:33:52 AM) emanuele: yep
(01:34:41 AM) emanuele: butch2k suggested to disable the CREATE TEMPORARY TABLE that are used when the forum has more than 100k messages
(01:35:01 AM) emanuele: and now *seems* to load much, much faster
(01:36:25 AM) groundup: emanuele, did you just add a flag to disable it instead of hardcoding another number for that limit?
(01:36:54 AM) emanuele: I added "false && " in front of the conditions
(01:37:30 AM) emanuele: I think an option to turn them on/off may become useful
(01:37:38 AM) groundup: I am pretty sure it was Compuart that added that in there. Maybe he has some insight (or you could search) why it was limited like that. There was a reason why there are temporary tables.
(01:39:50 AM) emanuele: According to the comments is avoid locks, that's why I think it's not best to just remove them
(01:40:42 AM) groundup: Ah, lock contention is nothing with the use of InnoDB. If people still have those problems, use a better engine.
(01:42:56 AM) TimeVortex: emanuele: sounds like your database server needs tweaking, tbh.
(01:50:00 AM) emanuele: TimeVortex, it's not exactly my db. :P Wouldn't know what to tweak, the issue is that while people are coming, when about 300/400 hundred are on line at the same time, the creation of temporary tables starts to slowdown and with those hanging around, update log_topics slow downs as well and they start influence each other becoming slower and slower
(01:50:22 AM) emanuele: At least that is what you see from the queries
Title: Re: IRC
Post by: TestMonkey on April 25, 2013, 04:19:14 am
(01:18:27 AM) TehCraw: How goes the elkarte development world?
(01:19:09 AM) emanuele: pushing fixes, bugs, from time to time even something that actually works!
(01:20:40 AM) TehCraw: Always a plus when stuff actually works like it's supposed to. :P
(01:20:58 AM) emanuele: usually that is the most scary part...
(01:21:12 AM) emanuele: because it means something else is broken somewhere else and you don't know yet

(01:21:54 AM) ***TehCraw prefers OOP systems for that reason. Unit tests FTW.
(01:22:23 AM) emanuele: that kind of things are for lazy people that don't like the challenge... :P
(01:23:04 AM) TehCraw: Rewriting Elkarte/SMF to be object oriented would be THE challenge.
(01:23:50 AM) emanuele: well, a good part of the admin code is already OO
(01:24:19 AM) TehCraw: Really. I'll have to look at that. ;)
(01:24:43 AM) ***TehCraw goes for GitHub

(01:25:00 AM) emanuele: And Norv should be working on a kind of class to handle forms
(01:25:38 AM) TehCraw: On the request end, or the forms themselves?
(01:26:29 AM) emanuele: Something like settings are handled in admin *I think*
(01:27:02 AM) TehCraw: I see. Interesting.
(01:29:00 AM) TehCraw: I probably asked before, but what are the minimum PHP version requirements for Elkarte?
(01:30:14 AM) ***emanuele seems to remember 5.1
(01:31:26 AM) TehCraw: Sounds reasonable. Should the class methods have access definitions then (public, protected, private) if for no other reason than added clarity?
(01:33:07 AM) emanuele: yep, most of them should have it
(01:33:22 AM) emanuele: some are missing because are still WIP
(01:33:51 AM) TehCraw: That's fine. I was just wondering, cause I've only checked a couple of files so far.
(01:34:00 AM) emanuele: (or maybe because I wrote the code and forgot to add :P )
(01:34:05 AM) TehCraw: LOL
(01:34:22 AM) emanuele: but usually that applies more to documentation...
(01:34:31 AM) ***emanuele whistles innocently
(01:35:48 AM) TehCraw: Meh, I forget that sometimes too. :P
(01:36:00 AM) TehCraw: (or just don't feel like it)
(01:36:40 AM) ***emanuele always thinks "later", "later", then he pushes and says "...ooops too late"
Title: Re: IRC
Post by: TE on April 25, 2013, 06:53:18 am
(07:20:43 PM) ***Norv thinks ManageBadBehavior wants a GenericList
Just a quick note: Whoever picks this one, wait please.. I have an overhauled version in queue. (PR expected in a few hours) ManageBadBehavior  is currently broken, the Log doesn't work as expected.. I've fixed various bugs and moved some logic (redirects, session and token validation) back to the controller.
Title: Re: IRC
Post by: Spuds on April 25, 2013, 03:13:08 pm
(07:20:43 PM) ***Norv thinks ManageBadBehavior wants a GenericList
Just a quick note: Whoever picks this one, wait please.. I have an overhauled version in queue. (PR expected in a few hours) ManageBadBehavior  is currently broken, the Log doesn't work as expected.. I've fixed various bugs and moved some logic (redirects, session and token validation) back to the controller.
Just another example of my piss poor work :P
Title: Re: IRC
Post by: TestMonkey on May 05, 2013, 02:01:52 pm
(10:27:30 PM) Norv: $ ls -1 sources/admin/ | wc -l
(10:27:30 PM) Norv: 38
(10:27:30 PM) Norv: $ ls -1 sources/controllers/ | wc -l
(10:27:30 PM) Norv: 42
(10:31:04 PM) Norv: Why was I under the impression that the difference is much higher.
(10:32:07 PM) ***Norv ponders whether to pass to objectify the rest of controllers too, along with all the model-side moving out of wherever it still is.
(04/27/2013 12:48:28 AM) groundup: "pass to objectify"?
Title: Re: IRC
Post by: TestMonkey on May 05, 2013, 02:04:32 pm
Quote
(04/27/2013 12:48:28 AM) groundup: "pass to objectify"?

Sorry, lol... I meant, make the rest of controllers object oriented
Title: Re: IRC
Post by: TestMonkey on May 05, 2013, 02:05:44 pm
(12:26:57 PM) Trekkie101: Norv, We need to figure out how WordPress handles plugins
(12:27:24 PM) Trekkie101: Because it kicks the booty off us, simple install, plugins can even issue updates that you just click "update" on
(12:27:30 PM) Trekkie101: Core patches applied
(12:27:46 PM) Trekkie101: The works, its friggin' beautiful
(12:45:11 PM) groundup: Put files in directory. Find files when you click install. Register classes by reading the start of the name of the class. Extend base class.
(12:46:15 PM) groundup: Could be different but I think that is how they do it. It's why when you create an action that extends the controller, it needs to be in the form Action{ControllerName}Controller or something like that
(12:48:30 PM) groundup: Maybe an event listener in the autoloader? dunno
(10:53:07 PM) groundup: Trekkie101, I really like how easy it is as well :)
Title: Re: IRC
Post by: TestMonkey on May 05, 2013, 02:13:42 pm
(11:57:04 PM) emanuele: So, when are we going to release a beta?
(11:57:17 PM) emanuele: And don't tell me "when you have fixed all the bugs you wrote!" :P
(11:57:36 PM) ***emanuele didn't drink, but is probably drunk


(11:28:34 PM) groundup: Shouldn't preparseCode() take in to account what BBC you have enabled?
(11:29:34 PM) groundup: *preparsecode() (seems like it should have a _ or camelCase)
(11:30:36 PM) emanuele: I *think* preparsecode is to fix any kind of code and nesting and so on, just to be sure It Works(TM)
(11:32:00 PM) groundup: If I don't have any BBC enabled, it screws up all of the formatting. It also doesn't have any hooks in there for preparsing and 'un'-preparsing code
(11:32:43 PM) emanuele: Interesting...
(11:32:48 PM) emanuele: on any text?
(11:34:42 PM) groundup: Okay, mind you, I haven't tested it, but if you look at Post.subs.php it is pretty straight forward. If I have a post "This is the start of a SMF quote block:
[nobbc][quote]" it will remove that block.
(11:35:06 PM) groundup: Based on: // Trim off trailing quotes - these often happen by accident.
(11:36:29 PM) groundup: Lets say you disabled the
[code] tag. It will close any opened ones even if it is disabled.
(11:36:40 PM) groundup: Pretty much, it tries to close open BBC tags that are disabled.
(11:37:18 PM) groundup: On another note this line should have {} around the following foreach: if (preg_match_all('~(\[(/)*code(?:=[^\]]+)?\])~is', $message, $matches))
(11:39:32 PM) groundup: Hmm... you can't stop it from doing /me to [me] conversion. Admins can always add [html] in there or [html] gets removed if you aren't an admin even if it is disabled
(11:39:38 PM) emanuele: yeah, on that respect it is true: it will fix everything even if not necessary...

(11:40:13 PM) groundup: Can't disable [time] I guess?
(11:40:14 PM) emanuele: though...
(11:40:45 PM) emanuele: why not?
(11:41:15 PM) groundup: What I am thinking is that the tags should have a preparse function and an unpreparse method. If the tag isset() and isn't disabled, run the (un)preparse() method
(11:41:38 PM) groundup: $parts[$i] = preg_replace('~\[time(?:=(absolute))*\](.+?)\[/time\]~ie', '\'[time]\' . (is_numeric(\'$2\') || @strtotime(\'$2\') == 0 ? \'$2\' : strtotime(\'$2\') - (\'$1\' == \'absolute\' ? 0 : (($modSettings[\'time_offset\'] + $user_info[\'time_offset\']) * 3600))) . \'[/time]\'', $parts[$i]); <-- that line
(11:41:46 PM) emanuele: the big issue would arise the moment you disable a tag and then you enable it again after a while
(11:42:04 PM) emanuele: preparsecode is run only at post-time
(11:42:13 PM) groundup: Yeah, I thought about that. It should run the method when you enable/disable tags
(11:42:55 PM) emanuele: ...a lot of hassles...
(11:43:02 PM) groundup: That is obviously a lot of work for the database. Otherwise, it is a bug IMO. Might be a bug that won't be fixed for the benefit of the admin/developer heh
(11:44:44 PM) groundup: I think lines like this make it harder for the poster: $parts[$i] = preg_replace('~\[(black|blue|green|red|white)\]~', '[color=$1]', $parts[$i]);
(11:44:54 PM) groundup: We should just have as a BBC
(11:47:31 PM) emanuele: dunno...that means some useless repetition...
(11:47:47 PM) emanuele: parse_bbc is not for noobs anyway...
(11:49:50 PM) groundup: lol
(11:51:15 PM) groundup: I wonder what happens if you just return; early and don't do any preparsing.
(11:52:05 PM) groundup: The reason I am reporting this is because I am going to have a forum where I don't want any BBC
(11:53:03 PM) emanuele: make sense
Title: Re: IRC
Post by: TestMonkey on May 05, 2013, 02:17:49 pm
(05/03/2013 12:05:02 AM) groundup: 'SELECT approved' that query should just use getTopicInfo(). At some point getTopicInfo() should have caching on it and extraneous queries like that would be slow
(12:06:05 AM) emanuele: good catch, yes that should go there
(12:06:49 AM) emanuele: but there are many other now that I tried a search...
(12:06:57 AM) groundup: elseif ($posterOptions['id'] != $user_info['id']) the query following that should use getBasicMemberData()

(12:09:29 AM) groundup: Am I missing something or is createPost() doing everything backwards? Add the attachments, then create the message, add the attachments to the message, then create the topic, add the messages to the topic.

(12:10:23 AM) groundup: I need to do a test but I don't think you can do this without a trigger: // @todo Why not set id_msg_modified on the insert?
(12:10:48 AM) groundup: If you can in MySQL, might not be able to in SQLite or Postgres
(12:11:31 AM) emanuele: that comment is there since 2.0, so... O:-)
Title: Re: IRC
Post by: TestMonkey on May 05, 2013, 02:18:53 pm
(12:12:27 AM) groundup: This should be refactored to a new function in Boards.subs.php: // Increase the number of posts and topics on the board.
(12:13:15 AM) groundup: setBoardPosts($count, $approved = true)

(12:13:18 AM) emanuele: https://github.com/emanuele45/Dialogo/branches/updateAnything
(12:13:38 AM) groundup: What am I looking at?
(12:13:46 AM) emanuele: a mess! :P
(12:14:13 AM) groundup: Since this is part of what I need to do for my application, I might just refactor this
(12:15:20 AM) emanuele: I used as a template the updateMemberData to create several functions updateTopicData, updateBoardData, etc.
(12:16:15 AM) emanuele: https://github.com/emanuele45/Dialogo/commit/c19e40c8c657b34e618f79944809c548e0ccea84
(12:16:34 AM) emanuele: search
(12:16:35 AM) emanuele: https://github.com/emanuele45/Dialogo/commit/c19e40c8c657b34e618f79944809c548e0ccea84
(12:16:48 AM) emanuele:  // Increase the number of posts and topics on the board.
(12:16:52 AM) emanuele: and you'll find it
(12:17:56 AM) groundup: Very nice. PR :P
(12:17:58 AM) emanuele: it is one of my classic crazy refactoring lol
(12:18:24 AM) emanuele: it scared Norv away in a second! :P
(12:20:16 AM) groundup: I am not sure I like abstracting updateTable() that much, but it looks good

(12:21:39 AM) groundup: Maybe if you are going to abstract a table update, you should do it at the database abstraction layer
(12:24:16 AM) groundup: $smcFunc['db_update']($name, array $table, array $col_val = array($col => $val), $options) $options = array(where, limit, sort, limit);
(12:25:27 AM) Norv: Right, it is heading towards a DAL of sorts, and it's very nice
(12:25:29 AM) groundup: if is_array($table) && $cannot_do_multi_table_updates ? foreach ($table as $tbl) {call this function with a single table; return}
(12:25:45 AM) groundup: Same thing with deletes at that point
(12:26:37 AM) groundup: emanuele, I can't wait to grab the diff from that PR ;)
Title: Re: IRC
Post by: TestMonkey on May 08, 2013, 08:11:30 am
(11:48:19 PM) groundup: Norv, now that you have OOP controllers, how about a autoloader?
(11:53:42 PM) TimeVortex: __autoload ftw
(11:56:55 PM) groundup: If the actions are standardized in the controller class like BoardIndex_action, then it would be really simple for the dispatcher. The array would be simple $route => $controller; call $controller->{$route}_action

(08:47:26 AM) Norv: >> groundup: If the actions are standardized in the controller class like BoardIndex_action, then it would be really simple for the dispatcher. The array would be simple $route => $controller; call $controller->{$route}_action
(08:47:26 AM) Norv: Yes, this is the purpose. I wasn't in a hurry with it, but yes. Atm not many match the action though.

(05/08/2013 12:02:54 AM) groundup: Which do you think is a better interface for caching: getMulti(array $keys) with get(string $keys) or get(array|string $keys)?
(12:03:38 AM) groundup: With getMulti() get can have a callback method. With just get() we need another method for getWithCallback()
(12:04:02 AM) groundup: I think I will just mimic memcached

(12:27:48 AM) emanuele: Norv, if you pass by: http://www.simplemachines.org/community/index.php?topic=329171.msg3538605#msg3538605
(12:27:58 AM) emanuele: Sooner or later I'll post it at elk too
(12:28:00 AM) emanuele: ;)

(08:51:04 AM) Norv: *blinks and tries to read necroposts LOL*. Yes, inconsistent. Agree. I think.
Title: Re: IRC
Post by: TestMonkey on May 08, 2013, 08:12:30 am
(01:21:45 AM) groundup: https://github.com/norv/elkarte/commit/60a36152b1c47e632b97b75bb6ab2eb42009a456#L1R532 I am really interested to know if that is the most efficient method for that.
(01:46:43 AM) groundup: https://github.com/norv/elkarte/blob/7278645528d5d2c3a02d340a9e6375eff9d98e1f/sources/controllers/Topic.controller.php#L116 refactor that as this: require_once SUBSDIR . '/Topic.subs.php'; $topic_info = getTopicInfo($topic); $is_sticky = (bool) $topic_info['is_sticky'];
(01:53:39 AM) groundup: In Topic.subs.php there are a lot of functions with names like messageInfo() where there is no verb there.
(02:01:14 AM) groundup: https://github.com/norv/elkarte/blob/7278645528d5d2c3a02d340a9e6375eff9d98e1f/sources/controllers/Topic.controller.php#L50 another one... why not just get all of the info and extract what you need from that query. SELECT * FROM someTable WHERE id = $id; is a hell of a lot faster when you cache it (even with the query cache) than SELECT col1 FROM someTable WHERE id = $id; SELECT col2 FROM someTable WHERE id = $id; SELECT col3... you

(09:04:24 AM) Norv: >> why not just get all of the info [...]
(09:04:24 AM) Norv: Do it.
(09:05:42 AM) Norv: We have indeed queries simply moved in subs, when in reality they need consolidated, in parametrized functions, and add caching to them
Title: Re: IRC
Post by: TestMonkey on May 08, 2013, 08:13:17 am
(02:15:38 AM) groundup: https://gist.github.com/joshuaadickerson/5536962

(07:22:06 AM) groundup: https://gist.github.com/joshuaadickerson/5538182
(07:22:38 AM) groundup: I was thinking that would work as a cache interface that would cover everything. It isn't about getting the least common denominator. It is about getting the most features and faking it for those that can't.
(07:23:49 AM) groundup: Don't have callback support? That's fine, just check to see what it is and then run that callback. Don't have increment? do a get, then increment that value, and set it again. CAS is special and can't be faked, so don't try it. Lists like Redis? Easy, just make sure that it is an array
(07:24:53 AM) groundup: Want to use the database as a cache with a MEMORY table or just have a fast database? The $parameters make it possible to inject the correct values.

(09:02:57 AM) Norv: >> groundup: I was thinking that would work as a cache interface that would cover everything. [...]
(09:02:57 AM) Norv: Dunno... Do we really need to reinvent the wheel here? I would really love it if you would look at Stash, the developer who makes it is obsessed with performance, and as far as I can tell from reading and analyzing some of it (no benchmarking) it's very good.
Title: Re: IRC
Post by: TestMonkey on May 08, 2013, 12:50:35 pm
(09:41:13 AM) groundup: Norv, can you merge those PRs from you and em?
(09:41:48 AM) Norv: Dunno... Is mine tested? :D
(09:41:55 AM) Norv: O:-)
(09:42:17 AM) groundup: Obviously you didn't test it :P
(09:43:05 AM) Norv: Ema doesn't have a PR now, or?
(09:43:23 AM) groundup: I didn't mean for this commit to get in to that PR: https://github.com/joshuaadickerson/NotElkarte/commit/4c5416b545f2d2abd61990a58c582bf7e7773a64
(09:43:47 AM) groundup: https://github.com/elkarte/Elkarte/pull/206
(09:44:27 AM) groundup: The point of that commit was just a proof of concept.

(09:45:36 AM) groundup: This stash? https://github.com/tedivm/Stash
(09:47:25 AM) Norv: Yes, on Stash
(09:48:16 AM) groundup: Very limited on features
(09:48:42 AM) groundup: Not a lot of drivers either
(09:52:22 AM) groundup: Hmm... I am confused about the Sub drivers. Just realized that was there.
(10:28:23 AM) groundup: I am starting to prefer SELECT * as opposed to SELECT col, col, col
(10:29:09 AM) groundup: 1) it is a hell of a lot less to write 2) it is less network IO 3) it is less chances for the query cache to miss it
(10:29:53 AM) groundup: Disadvantage: you lose naming of columns (which you can still do) and the column order goes to the engine

(12:14:45 PM) groundup: No idea how but all of a sudden my files contain a bunch of crap like: "<<<<<<< HEAD" when I tried to merge that giant commit you just did

(12:20:07 PM) groundup: Any idea how to get rid of all of these "<<<<<<< HEAD" lines?
(12:20:43 PM) Norv: It's because of conflicts. I usually use Meld, it has an awesome 3-way merge view.
(12:21:12 PM) groundup: I apparently just corrupted it. Oh well, the only reason I started with it was because I wanted to get you to merge that PR ;)
(12:21:21 PM) Norv: My suggestion for your master though, is: make another branch with what you have now. To keep it all there. Then,
(12:21:56 PM) Norv: reset --hard your master, to some old commit (i.e. before my PR)
(12:22:06 PM) Norv: then pull master from elkarte repo again
(12:22:31 PM) groundup: ... when I wake up.
(12:22:45 PM) Norv: then, create a branch for _your_ PR (s). And when you're on the new branch, cherry-pick one by one the commits from the "backup branch".
(12:22:56 PM) Norv: Sure :D

(12:23:22 PM) groundup: btw, test those commits I made... I didn't :P
(12:23:27 PM) Norv: :D
(12:23:40 PM) Norv: I'll pick them, no worries.
(12:24:04 PM) groundup: No different from you ;) Post/Poll... That should be one of the first things you test
(12:24:18 PM) Norv:  /hides
(12:24:26 PM) Norv: It wasn't meant to be merged yet!
(12:24:30 PM) groundup: lol
(12:24:42 PM) groundup: but you put it as a PR anyway
(12:25:06 PM) Norv: Only for people to know what I'm playing with! :D
(12:25:19 PM) groundup: The only reason I grabbed the repo is for that one commit that I didn't mean to put in there. lol
(12:25:30 PM) groundup: The one that implements some caching
(12:25:45 PM) Norv: It's interesting but you're right, it should be separate
(12:25:49 PM) Norv: I'll take care of that
Title: Re: IRC
Post by: TestMonkey on May 08, 2013, 12:55:39 pm
(12:10:15 PM) Norv: Josh, please take a look at all comments on Lab's PR. Also there are a couple (rather big) commits not reviewed at all. I honestly don't have much time to take those meh stuffs. :(
(12:14:07 PM) groundup: Which ones?
(12:14:54 PM) Norv: Oldies, troglodite guy
(12:15:03 PM) groundup: 5:15AM. I need to go to sleep
(12:15:18 PM) groundup: I talked to him about some of them. Most of them are just pedantic BS from Arantor
(12:15:25 PM) groundup: RGB or HEX, who cares?
(12:16:06 PM) Norv: If he doesn't fix pedantic stuff, fine. But it *introduces* uselessly crap
(12:16:31 PM) groundup: He didn't put two line breaks after a declarative block, woopty doo. That can get fixed later
(12:16:51 PM) groundup: *conditional
(12:17:55 PM) groundup: He needs to learn to take criticism better, sure. Though, he did get lambasted over a few very minor issues. No bugs or major issues there
(12:18:00 PM) Norv: More variables in templates. Hex, it's used almost everywhere. People shouldn't keep switching when they work with the code. Fixed later?
(12:18:27 PM) groundup: Yeah, I talked to him about that. However, before it was a ternary operator. He didn't fix an issue, but he didn't make it worse
(12:18:30 PM) Norv: I don't care about persons. I care about the bs this starts to introduce.
(12:19:09 PM) groundup: I prefer hex, and suggested he change it, but if he doesn't, it won't make a difference.
(12:19:31 PM) groundup: I prefer using a standard.
Title: Re: IRC
Post by: Arantor on May 08, 2013, 04:41:22 pm
/me is not HappyTroglodyte and resents the implication.

I haven't even commented on SMF on Github in months and if I do, it's under my own name.
Title: Re: IRC
Post by: TestMonkey on May 09, 2013, 04:26:18 am
Oh, hey.
Don't take it badly. I have actually wondered if you were HT, too, to be honest. With no implication. Sorry about that.

Back to the content of the matter. I don't want to comment too much, nor can I spend much time on.

I will say this though.
For arguably the first time in SMF history, childish egotrips without backup have been the excuse for issues to enter the codebase.
Title: Re: IRC
Post by: emanuele on May 09, 2013, 09:29:49 am
No, never thought about you Arantor.
Title: Re: IRC
Post by: TestMonkey on May 10, 2013, 07:44:46 am
(07:26:11 PM) emanuele: Norv maybe you already figured it out:
(07:26:13 PM) emanuele: require_once(ADMINDIR . '/Modlog.php');
(07:26:20 PM) emanuele: require_once(SUBSDIR . '/Modlog.subs.php');
(07:26:31 PM) emanuele: in ModerationCenter.controller.php
(07:27:15 PM) ***Norv has lost count of what's where... What is the problem with it?
(07:28:26 PM) emanuele: the first should be replaced by the second :P
(07:28:32 PM) emanuele: it's the only one
(07:30:37 PM) emanuele: I forgot to commit that before you merged the branch, but since you said you were going to fix other things add that one too. ;)
(07:31:16 PM) Norv: Oh ok. I didn't merge your fixes... I think
(07:31:49 PM) ***emanuele is going mad...
(07:31:58 PM) emanuele: I thought I see a merge notice... lol
(07:34:24 PM) Norv: 'twas the cache thing!
(07:34:56 PM) Norv: but if you're happy with it now, we can merge up fixes too. They're great :D
(07:35:46 PM) emanuele: yeah, possible, though I saw the cache one... lol
(07:36:16 PM) emanuele: well, I pushed it
Title: Re: IRC
Post by: TestMonkey on May 10, 2013, 07:54:35 am
(07:54:21 PM) groundup: Feel free to reject that entire PR
(09:42:38 PM) Norv: groundup: I will pick useful stuff. You can fix your master by a reset or: https://gist.github.com/norv/5542609

(08:11:50 PM) emanuele: How do we fix the admin search?

(08:15:27 PM) groundup: In Load.php - https://gist.github.com/joshuaadickerson/5541980
(08:27:50 PM) groundup: Refresh and look at the comments
(08:33:56 PM) groundup: membergroupsById() in Membergroups.subs.php should be rewritten to use that
(09:14:31 PM) groundup: https://gist.github.com/joshuaadickerson/5542380
(09:33:42 PM) groundup: cache_getMembergroupList() in Membergroups.subs.php should be removed in favor of using this with some filtering.
(09:45:07 PM) groundup: That stuff that I just gist'd is done from a copy of Elkarte that is for a completely different project.

(05:14:17 AM) Norv: groundup: re: https://gist.github.com/joshuaadickerson/5541980 please feel free to PR the proposal.

(07:39:09 PM) groundup: Norv, that means I should test it and I should have a copy running. Too much work :P
(08:18:26 PM) groundup: Damn, I forgot to switch branches after I created it.

(08:44:02 PM) Norv: groundup: cool! As for branches. Make another branch from this; PR that branch; reset your master. Safer I'd think. Once you get used to git, there are about a dozen ways for these small thingies
(08:57:12 PM) Norv: As for 'too much work', lol to you. You have the opportunity to align your needs with improving Elk; make it suit you better. Yes, by doing the work. We're relaxed on procedures (well we dont have almost any lol), but don't take for granted untested PRs.
Title: Re: IRC
Post by: TestMonkey on May 10, 2013, 07:55:27 am
(09:47:02 PM) emanuele: quick question: cache_quick_get...is that so useful?
(09:47:58 PM) groundup: A cache function with a callback is good.
(09:48:45 PM) groundup: $function should be renamed to $callback and the documentation changed to reflect that so people understand it.

(09:51:07 PM) groundup: NetBeans is telling me that cache_getMembergroupList() is not used but I am using a highly modified version, can anyone check that?

(10:12:50 PM) Norv: cache_getMembergroupList() is used as callback to cache_quick_get

(09:51:08 PM) emanuele: I would also make $file optional
(09:51:48 PM) emanuele: boardindex.controller line 69

(09:51:57 PM) groundup: require_once(SOURCEDIR . '/' . $file); yeah, SOURCEDIR makes it so you can't include other files there too
(09:54:12 PM) emanuele: (you can always use some relative path... :P), but the main point is that if the function is in the same file is kind of useless to require_once it... (see calendar.subs.php for an example)

(10:55:35 PM) groundup: hmm... I should rewrite that
(10:56:59 PM) groundup: if (empty($message_info['approved']) || $message_info['id_member'] != $user_info['id']) return false; return true;
(11:09:16 PM) TimeVortex: Sounds like you can do even better.
(11:09:28 PM) TimeVortex: return !(empty($message_info['approved']) || $message_info['id_member'] != $user_info['id']);
(05/09/2013 12:28:53 AM) groundup: https://github.com/elkarte/Elkarte/pull/375#commitcomment-3172916 is what I suggested

(11:02:39 PM) groundup: emanuele, I think this is your doing. In Load.php, line 509, $topic = $msgOptions['id_topic']; $msgOptions is never set
(11:08:16 PM) emanuele: mmm...NFI...drop it I'd say...

(05:43:41 AM) groundup: Is there a PHP equivalent function to query_see_board?
(05:56:01 AM) groundup: I created one: https://gist.github.com/joshuaadickerson/5552134
Title: Re: IRC
Post by: TestMonkey on May 11, 2013, 04:36:08 pm
(11:57:04 PM) emanuele: So, when are we going to release a beta?

I think we could get on an IRC meeting, to figure that one out. We're a bit "late" comparing to intention, and I didn't push on it. (/hides)
I still think the intention was ok and we could try to also see where we stand.
Title: Re: IRC
Post by: TestMonkey on May 12, 2013, 07:25:02 am
(06:58:12 PM) groundup: For some reason the unused vars PR got some of the loadMemberGroups and getTopicInfo PR. I committed those before I even created that other branch.
(07:11:54 PM) groundup: Ugh, I wish I didn't screw up all of those branches. It is more work to make them right than it was to do them

(10:09:35 PM) groundup: http://www.infoq.com/articles/managing-technical-debt
(10:19:26 PM) ***emanuele usually changes that “if I touch that code everything will break” to: “if I touch code everything will break”

(10:38:11 PM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/a5f3768fcd264272d167338593433cc6e487089f#commitcomment-3189207 can someone take a look at that

(05:47:36 AM) groundup: If the controller doesn't have a way of passing and hold variables, what use is it? In fact, how is it even a controller? Currently, there is no method for holding data like the member groups other than with $context or similar global variables. When you implement a DIC, that's where it will be, but even then, it is the same thing as a global.
(08:37:44 AM) Norv: It passes to template through $context. It passes (hopefully) to .subs ("model-like") through parameters. It holds almost the entire execution, so what it knows will pass over. If it needs more, then where does it need it?

(03:18:05 PM) Norv: groundup: you're thinking at something like instance variables of use, in the controller?
(03:18:57 PM) Norv: for us atm, there is almost zero need, because a single method is executed for the entire execution flow (related to the content of the action).
(07:57:01 PM) groundup: I am thinking of times when the model needs things passed to it from the controller.
(07:57:06 PM) groundup: *models
(07:58:11 PM) groundup: For instance, members have member groups. The controller gets the members and groups and anything else that "links" to the members.
(08:01:18 PM) groundup: You need to implement a member and topic factory and then have classes for each. Then the member groups are stored in the member factory and its instantiation gets stored in the controller (the base controller, which gets extended by each controller)
Title: Re: IRC
Post by: TestMonkey on May 12, 2013, 07:26:08 am
(08:14:37 PM) emanuele: What do you prefer: several similar functions with slightly different behaviours of just one function slightly misused? O.-)
(08:15:03 PM) groundup: Depends
(08:15:05 PM) ***emanuele is lost in this dilemma...
(08:16:05 PM) emanuele: http://pastebin.com/PpFG3buH
(08:16:28 PM) emanuele: the two are basically the same (do not consider recycle for now) somehow
(08:17:05 PM) emanuele: the second could be replaced by array_keys(boardsPosts())
(08:17:51 PM) emanuele: but to be perfectly "nice" I would add yet another one
(08:18:02 PM) emanuele: (that at the moment I don't remember)
(08:18:12 PM) groundup: boardsPosts() doesn't really explain what it is trying to do ;)
(08:18:47 PM) emanuele: well...it grabs the posts of some boards... :P
(08:18:51 PM) groundup: You're just trying to get the number of posts per board? There aren't functions that do that aleady in say Boardindex.subs.php / Boards.subs.php?
(08:21:00 PM) emanuele: not of a bunch of boards (or categories)
(08:22:03 PM) groundup: This is where I have an issue with Norv and TE's idea. If something like this already exists, just add some kind of filtering. Use array_intersect_keys()
(08:22:55 PM) emanuele: mmm...but it doesn't exist :P
(08:23:33 PM) groundup: Oh, that's right, there is no getBoardInfo()
(08:24:31 PM) emanuele: but again it doesn't do what I need...
(08:25:20 PM) groundup: You just want the posts?
(08:25:25 PM) emanuele: it grabs info of info of 1 board and extend it to load the info of all seems a lot..
(08:27:57 PM) groundup: You should break getBoardIndex() down to smaller functions where that query is on its own. Change $user_info['is_guest'] to be a parameter; add filtering to be a parameter
(08:29:44 PM) groundup: Although boardPosts() and boardsByCategories() do exactly what you want, I would have another function that gets from the board table.
(08:30:37 PM) groundup: getBoards() or something like that. Then in boardPosts() and boardsByCategories() I would create the parameters, check to make sure that all of the conditions are met (return errors otherwise) and call getBoards()
(08:34:10 PM) emanuele: yeah, that's one of the possibilities I was thinking
(08:36:05 PM) emanuele: a common function that queries and several others that call that function with different intentions/meanings

(09:18:53 PM) groundup: emanuele, http://www.elkarte.net/index.php?topic=349.msg2250#msg2250
(09:20:43 PM) groundup: I was trying to find more links to support me: http://stackoverflow.com/questions/845895/putting-license-in-each-code-file

(12:57:35 AM) emanuele: https://github.com/emanuele45/Dialogo/blob/master/sources/controllers/MergeTopics.controller.php#L309
(12:57:42 AM) emanuele: Question:
(12:58:03 AM) emanuele: how the query at line 322 is useful?
(12:58:25 AM) emanuele: unless...
(12:58:53 AM) emanuele: nope...can't see when would trigger an error
(12:59:27 AM) emanuele: $boards already contains the two boards of the two topics
(12:59:44 AM) emanuele: and the merge_any permission is checked on that array
(01:01:08 AM) emanuele: arg...found it I think
(01:02:04 AM) emanuele: yeah okay some broken permissions

(01:07:38 AM) emanuele: Another question, that may have a bit more sense
(01:08:39 AM) emanuele: is there any reason that a query doesn't use COUNT when the only reason there is that query is to count the number of rows returned?

(08:19:43 AM) Norv: >> emanuele: is there any reason that a query doesn't use COUNT when the only reason there is that query is to count the number of rows returned?
(08:19:43 AM) Norv: Can't think of any
Title: Re: IRC
Post by: TestMonkey on May 14, 2013, 12:58:21 am
(02:54:38 PM) emanuele: I mentioned Norv twice but I didn't realise there was no Norv around... lol
(03:24:21 PM) Norv: lol, pastie please :)
(03:31:27 PM) emanuele: [13:29]   emanuele   Norv, I got lost in some refactoring while working on the ajaxify branch, it will take a moment and will contain some non-pertinent commits... but that's nothing new! lol
(03:53:24 PM) Norv: :D
(04:09:33 PM) emanuele: https://github.com/emanuele45/Dialogo/commit/1c707428b3ad43aeb94f038a13699e34d1947e74
(04:09:52 PM) ***emanuele feels is not 100% nice to see
(04:10:31 PM) emanuele: probably the function can split or simplified...
(04:11:03 PM) emanuele: and YAY for another commit that cuts 250 lines of code! :D :P
(04:40:48 PM) Norv: Oh it looks cool. As far as I can tell from a quick diff
(04:40:57 PM) Norv: canSeeBoards() doesn't exist, does it?
(04:41:26 PM) Norv: ... you're sure it doesn't cut too much lol
(04:41:28 PM) emanuele: yups...that's a left over... :P
(04:41:32 PM) Norv: action_markasread_api()
(04:42:17 PM) emanuele: darn cut&paste...

(04:43:47 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(04:43:48 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/BaE2EA
(04:43:48 PM) elk_core: Elkarte/master 48ba62d Joshua Dickerson: Add hooks for post.subs.php...
(04:43:48 PM) elk_core: Elkarte/master c665432 Joshua Dickerson: Add resizeBBCImages()...
(04:43:48 PM) elk_core: Elkarte/master 97698fc Norv: Pass the currently processed part in the hook....
(04:43:48 PM) elk_core left the room.

(04:44:07 PM) emanuele: oh, no, action_markasread_api() is correct
(04:44:18 PM) emanuele: action_index_api
(04:44:22 PM) Norv: you killed it? Oh
(04:44:43 PM) emanuele: I didn't do a complete refactor
(04:44:57 PM) ***Norv knows Emanuele likes killing things, so it's ready for surprises :D

(05:40:58 PM) emanuele: fixed canSeeBoards https://github.com/emanuele45/Dialogo/commit/ace9d5d1ecae5e0a9e2c38d8d99ec14a27c961dc
(05:41:57 PM) emanuele: And I also documented the functions I wrote before! :D
Title: Re: IRC
Post by: TestMonkey on May 14, 2013, 12:59:28 am
(07:29:36 PM) groundup: Does the version of PHP Elkarte is built for allow for lambda functions?
(07:35:42 PM) emanuele: http://www.php.net/manual/en/functions.anonymous.php
(07:35:50 PM) emanuele: apparently are php 5.3+, so no.
(07:36:06 PM) emanuele: at the moment it is 5.1 I think
(07:36:20 PM) emanuele: (maybe 5.2)

(07:37:08 PM) groundup: Damnit! I did it again, I created a bunch of changes on the wrong branch
(07:39:13 PM) groundup: Norv, I am trying to do this PR for Spuds' PBE so that he can grab this and then make a change to his
(07:39:43 PM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/550c1645f36e72480579e11989db3a2aded3050a an https://github.com/joshuaadickerson/NotElkarte/commit/c5a5215c5dfd21d7571c8462b8b3616d85a78c03

(07:53:56 PM) groundup: in Load.php -> // If we think we have mail to send, let's offer up some possibilities... robots get pain (Now with scheduled task support!)
(07:54:21 PM) groundup: That needs a better home. Just not sure where to put it. It needs to wait until after the theme is loaded, but it shouldn't be in there where the theme is loaded.

(07:56:23 PM) groundup: if (!empty($birthdayEmails)) <-- that never reaches true
(07:57:30 PM) groundup: https://github.com/elkarte/Elkarte/issues/396

(08:25:04 PM) Norv: groundup: why add those two commits to Spuds' PR?
(08:25:12 PM) Norv: They don't seem related

(08:36:22 PM) Norv: https://gist.github.com/norv/5564337
Title: Re: IRC
Post by: TestMonkey on May 14, 2013, 01:02:30 am
(08:52:33 PM) Norv: Last call, for database layer: keep compatibility with $smcFunc calls?  Including with the name. I already keep compat with an array... but rename it?
(08:53:32 PM) TehCraw: Die, smcFunc.
(09:37:47 PM) emanuele: No strong feelings...
(09:38:25 PM) emanuele: Just a bit annoying have to use an array for functions

(05/13/2013 12:38:53 AM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(12:38:53 AM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/GoA3yg
(12:38:54 AM) elk_core: Elkarte/master 669ea7a Jeremy D: Add Frame Security Options header...
(12:38:54 AM) elk_core: Elkarte/master 8ad8583 Jeremy D: obExit actually doesn't get called for ajax calls
(12:38:54 AM) elk_core: Elkarte/master a514c4c Norv: Add helptext....
(12:38:54 AM) elk_core left the room.

(03:04:32 AM) groundup: updateStats is a horribly non-individual-concern function. Nothing about it is shared by an of the other cases

(03:37:51 AM) groundup: Can the recycle board ever be 0? I would think not. So recycle_enable is moot

(09:01:27 AM) groundup: I definitely created and switched to a different branch before committing those. Then I did a PR and it all wound up in one big one.
(09:34:10 AM) groundup: Norv, https://github.com/joshuaadickerson/NotElkarte/commit/4a842b3554bf01b9ded421a759804d4828a95a2c

(12:01:46 PM) Norv: groundup: I think you had already those extra-commits on your master, that's why you ended up with the older ones in your branch.
(12:04:01 PM) Norv: Since you have all this in getAttachment now, I'd do: git checkout master; git pull -f elkarte_remote master
(12:05:06 PM) Norv: (you need to reset your master, and this is one way to do it)
(12:08:52 PM) Norv: Or: git checkout master; git reset --hard 7281526; git pull elkarte_remote master
(01:07:51 PM) Norv: When you're on a branch, you can always do: git log, and look at what's in there. i.e. quick-check that master is in sync. Atm, though, I think you need to make sure you reset your master, first of all.
Title: Re: IRC
Post by: TestMonkey on May 14, 2013, 01:03:23 am
(04:11:16 PM) emanuele: https://github.com/elkarte/Elkarte/blob/master/sources/controllers/Emailuser.controller.php#L303
(04:11:44 PM) emanuele: Is there any specific reason why $_REQUEST['msg'] is overwritten with the result of the query?
(04:32:56 PM) emanuele: lol I just realised that except the message id the other results of that query are not even used... :P

(05:16:39 PM) Norv: I think that query is intended to recheck the validity of the message, i.e. that it's indeed in the current topic. (it'd get nothing otherwise, with inner join). But the other data, mmm, I don't see the purpose
(05:24:03 PM) Norv: I see no meaning to override it. But this kind of override is done more times in the code. My best assumption is that it didn't hurt, and I'd say it's an exaggeration. Arguably, even the check isn't exactly necessary, since reporttm() doesn't make changes.

(05:33:16 PM) emanuele: Well, I already replaced it with a function and removed the overriding... O:-)
(05:36:37 PM) Norv1: thank you! :)
(05:37:26 PM) emanuele: You know I like drop things... O:-)

(07:18:51 PM) Trekkie101_Away: I seened a roadmap!!
(08:33:41 PM) Norv: Of course you haz.
Title: Re: IRC
Post by: TestMonkey on May 14, 2013, 01:05:02 am
(05/14/2013 12:03:53 AM) groundup: You know what the most annoying comments in the world are? Ones like this: // Now we get to work around a bug in PHP where it doesn't escape <br />s!
(12:04:38 AM) groundup: WTF is the bug? Give me a link! Maybe it is fixed. If we're including workarounds for something, include why we are working around it and what the workaround is meant to do
(12:11:06 AM) ***emanuele tends to agree

(12:13:43 AM) groundup: Netbeans is pissing me off. It doesn't want to switch branches or close. I guess I have too many branches for it now

(12:15:23 AM) ***groundup hates this - $_GET = htmlspecialchars__recursive($_GET);

(12:15:26 AM) emanuele: you probably have some uncommitted change

(12:15:35 AM) groundup: and this $_REQUEST = $_POST + $_GET;
(12:15:47 AM) emanuele: that conflicts with the other branch

(12:17:27 AM) groundup: Why get rid of magic quotes if you are just going to do it in the application? Or even worse is doing something crazy like htmlspecialchars() on every get variable

(12:18:13 AM) groundup: $_SERVER['BAN_CHECK_IP'] <-- stop touching my g'damn magic globals!
(12:18:17 AM) emanuele: because magic is bad in programming! :D
(12:19:19 AM) groundup: What the F is this about: $_SERVER['REMOTE_ADDR'] = preg_replace('~^::ffff:(\d+\.\d+\.\d+\.\d+)~', '\1', $_SERVER['REMOTE_ADDR']);
(12:19:42 AM) groundup: Ummm... what if I wanted to get exactly what the REMOTE_ADDR is?
(12:21:18 AM) groundup: cleanRequest() really needs to be broken down in to smaller functions. getBanIP() getUserIP()
(12:22:33 AM) groundup: I don't like it when applications don't listen. Die Netbeans, die!
(12:25:25 AM) ***emanuele points at core.inc.php (badbehaviour) line 84
(12:25:52 AM) emanuele: we all like to mess with our REMOTE_ADDR! :D
(12:30:46 AM) groundup: Terrible. Though, that is an excellent example of why not to mess with it. That extension is also editing it. It isn't relying on it to be unchanged, but it could be.
(12:32:19 AM) emanuele: at least it's consistent...somehow :P

(12:36:30 AM) groundup: I think I fixed a bug with SQLite, SET NAMES should be an error/warning
Title: Re: IRC
Post by: TestMonkey on May 15, 2013, 06:28:02 am
(03:54:54 PM) elk_core: [Elkarte] norv opened pull request #399: Database layer (master...database)  http://git.io/qSxsow
(08:17:16 PM) elk_core: [Elkarte] norv opened pull request #401: Html2 md (master...html2Md)  http://git.io/43ziCA

08:17:36 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(08:17:36 PM) elk_core: [Elkarte] norv pushed 19 new commits to master: http://git.io/VUoODw
(08:17:36 PM) elk_core: Elkarte/master 06637c2 Spuds: ! Testing class to replace markdownify...
(08:17:36 PM) elk_core: Elkarte/master bed56db Spuds: ! just extract the body text...
(08:17:37 PM) elk_core: Elkarte/master eb3a535 Spuds: ! Change the way lists are handled to ensure proper indentation when nested...
(08:17:37 PM) elk_core left the room.

(08:18:26 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(08:18:26 PM) elk_core: [Elkarte] norv pushed 111 new commits to master: http://git.io/JHvfIg
(08:18:26 PM) elk_core: Elkarte/master 732ed19 Spuds: ! Initial commit of EmailFormat.class.php used to reflow a message...
(08:18:26 PM) elk_core: Elkarte/master 3e295c3 Spuds: ! minor cleanup to the formatting class...
(08:18:26 PM) elk_core: Elkarte/master f45a25c Spuds: ! cleanup...
(08:18:26 PM) elk_core left the room.

(08:26:46 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(08:26:46 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/l4BerA
(08:26:46 PM) elk_core: Elkarte/master 1d37042 Joshua Dickerson: A couple of more queries removed...
(08:26:46 PM) elk_core: Elkarte/master fce2718 Norv: Fix the function call....
(08:26:46 PM) elk_core: Elkarte/master c0abe75 Norv: Reverse the previous change to associatedTopic() and update the function....
(08:26:46 PM) elk_core left the room.

(09:15:08 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(09:15:08 PM) elk_core: [Elkarte] norv opened pull request #402: Elkpr/397 (master...elkpr/397)  http://git.io/V4M5wg
(09:15:08 PM) elk_core left the room.

(09:18:33 PM) ***emanuele feels he needs to rebase some branches...
(09:27:59 PM) ***Norv doesn't want to think about such thingz... will probably try to finish a couple branches before... rebase those alone (to catch quick fixes and stuff in single commits for a change), and afterwards
(09:28:31 PM) Norv: Nah, half-joking. They aren't so bad, most is in new files.
(09:29:01 PM) emanuele: I know, I'm already scared by those that are coming :P
(09:29:30 PM) Norv: lol
Title: Re: IRC
Post by: TestMonkey on May 15, 2013, 06:31:32 am
(09:29:29 PM) groundup: Following the updateStats() changes getting merged, those functions should be moved to their respective Subs files. Also these functions should be moved to View.subs.php (or ViewHelpers.subs.php or TemplateHelpers.php or something like that): constructPageIndex(), comma_format(), standardTime(), relativeTime(), shorten_subject(), shorten_text(), forum_time(), parse_bbc(), parsesmileys(), highlight_php_code(), determineTopicClass(),
(09:30:05 PM) Norv: Agree on moving to Subs, Josh, sure thing. Perhaps I should do it now...
(09:31:06 PM) Norv: Ah wait, we're already in Subs itself lol.

(09:31:32 PM) groundup: In my last job we had this file called Common.php. It was a several MB PHP file with very little comments. Subs.php reminds me of that file.
(09:32:14 PM) Norv: lol
(09:32:38 PM) groundup: I couldn't even open it in my IDE because it would crash. I have a pretty beefy laptop with a good graphics card (1 GB) and 8 GB RAM.
(09:33:46 PM) emanuele: LOL
(09:34:00 PM) emanuele: at least half of Subs is parse_bbc! :P
(09:34:25 PM) groundup: We used CVS too. So, I would pull it down, find what I needed to in Notepad++, save, and commit with TortoiseCVS. Then when I needed to look for a function that I thought might be in it, I would have to search everything else and then that file separately.
Title: Re: IRC
Post by: TestMonkey on May 15, 2013, 06:32:23 am
(09:35:46 PM) groundup: parse_bbc() could be a lot nicer if it did the first part of checking if it even needs to parse any BBC. If it does, load a separate BBC.subs.php
(09:36:31 PM) groundup: Actually, I might just do that
(09:53:47 PM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/3db4c38325bb3f63e4698fa09f90aef0a50a7f24
(09:54:42 PM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/7c320341112b24542a771396f94ee250268ffb7f
(09:54:54 PM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/c08c0a25c0688291b16ee3a2a3f76df9da4068ac
(09:55:51 PM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/d34fc42828b082bbcc3d1fa6c30a7fc4bbd67178
(09:57:32 PM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/a0d88a67504eda02b8d183df051e08fe273a0ef4 & https://github.com/joshuaadickerson/NotElkarte/commit/0780a93b0b195d56fe1addcee1850fbfe1e5657d & https://github.com/joshuaadickerson/NotElkarte/commit/15b8e9e9517ef34d602a974ea5f8a71dd58ccfee
(10:00:30 PM) groundup: Norv, I realized that a second after I posted it - https://github.com/norv/elkarte/commit/a7e693b1dedff2d7b373e25b50bf6f6ad30fcbe0#commitcomment-3210980
(10:10:31 PM) Norv: groundup: check out https://github.com/Spuds/Elkarte/tree/parseBBC

(10:13:01 PM) ***Norv haz a feeling Josh isn't committing to the intended branch ... :)
(10:14:01 PM) groundup: At this point I am just committing a bunch of changes. Shouldn't really have too many conflicts thus far. I will worry about fixing the master later
(10:14:34 PM) Norv: I see your new branches continue to have extracommits. You should fix your master - ok.
(10:14:43 PM) groundup: That parseBBC branch is a lot less in Subs.php. Probably a good balance.
(10:15:15 PM) groundup: Still, I would move all of that to some kind of view helper file
(10:15:42 PM) Norv: Checkout Spuds branch, for probable updates to parseBBC, well actually a replacement all together
(10:15:55 PM) groundup: Yeah, I did. That's what I'm talking about now
(10:16:04 PM) Norv1: Ah ok

(10:21:06 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(10:21:06 PM) elk_core: [Elkarte] norv opened pull request #403: Josh attachments (master...josh_attachments)  http://git.io/_09HIg
(10:21:06 PM) elk_core left the room.

(10:26:31 PM) elk_tools: [tools] norv pushed 6 new commits to master: http://git.io/9YYCmw
(10:26:31 PM) elk_tools: tools/master b47e720 Norv: Rename to elk....
(10:26:31 PM) elk_tools: tools/master 5655d9a Norv: Name updates....
(10:26:31 PM) elk_tools: tools/master 6b52514 Norv: Starting-up updates of database cleanup script for elk....


(10:36:25 PM) elk_tools [~elk_tools@router1-ext.rs.github.com] entered the room.
(10:36:25 PM) elk_tools: [tools] norv opened pull request #8: Sqlite (master...sqlite)  http://git.io/nFYpvA
(10:36:25 PM) elk_tools left the room.

(11:28:59 PM) groundup: Norv, Decoda requires PHP 5.3. You should bump that minimum version ;)
(11:30:21 PM) TehCraw: 5.3 has more useful stuff in it anyway.
(11:30:28 PM) TehCraw: The json functions for example
(11:32:47 PM) groundup: Oh, wow. I thought it was PHP 5.2 that was required. PHP 5.1 is so damn old... wow
(11:33:30 PM) TehCraw: Sadly there are still some hosts that insist on sticking with the old version.
(11:33:40 PM) groundup: Who is still on 5.1?
(11:34:02 PM) TehCraw: *an old version. I don't know any that are on 5.1
(11:34:15 PM) TehCraw: Although I seem to recall having to talk to one last year about using PHP 4.
(11:34:41 PM) TehCraw: Tried to use an anonymous function and they wouldn't have any of it. :P
(11:35:26 PM) groundup: I think RHEL 5 repo started with 5.2.9. Doubt any Debian based hosts were using older versions.
(05/15/2013 12:02:50 AM) Norv: groundup: last I checked Spuds was using a previous version from Decoda
(12:12:06 AM) groundup: Too bad, that was a good reason to bump the minimum version ;)
Title: Re: IRC
Post by: TestMonkey on May 16, 2013, 12:42:02 pm
(09:06:10 AM) groundup: Why in the hell is a simple array of buttons cached but other things that actually take time to compute aren't? (see // All the buttons we can possible want and then some, try pulling the final list of buttons from cache first.)

(04:36:32 AM) groundup: The theme init function should have $theme_salt and $theme_version. So instead of ?aph21 being hardcoded in Load.php, it would be $settings['theme_salt']

(04:43:26 AM) groundup: Why did loadTemplate() get a $style_sheets param? I don't think I did that. There should be a separation of concerns there.
(04:47:08 AM) groundup: Things to be removed in LoadTemplate(): // For compatibility reasons, if this is the index template without new functions, include compatible stuff. // Hmmm... doesn't exist?!  I don't suppose the directory is wrong, is it? (check it on install, fatal error otherwise)
(05:03:36 AM) groundup: I bet every template needs an init function. It should contain addJavascriptVar() and most addInlineJavascript() calls
(05:05:00 AM) groundup: With the Combine class, there shouldn't be a reason why there shouldn't be a javascript txt file.
(06:09:18 AM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/cfcc9a13c21ca3d666208b29c68a8bc041672d53
Title: Re: IRC
Post by: TestMonkey on May 16, 2013, 09:03:42 pm
(09:20:20 PM) Norv1: emanuele: sorry for the admin search
(09:20:33 PM) Norv1: I forgot about it :'(
(09:21:54 PM) emanuele: no problem, I don't use it... :P
(09:22:08 PM) emanuele: searching the files is usually faster :P
(09:24:39 PM) emanuele: Oh I wanted to ask you something
(09:24:50 PM) emanuele: On the ajaxification of things
(09:25:41 PM) emanuele: I was looking to make messages approval/unapproval, and I realised there is an...unintended behaviour (mostly)
(09:26:16 PM) emanuele: I added the calls to the "_api" methods/functions both in dispatch and in createMenu (or callMenu don't remember)
(09:26:43 PM) emanuele: so, when both are involved the handling becomes a bit...strange
(09:27:36 PM) emanuele: because the menu has to be created anyway, but both "falls back" on the _api functions
(09:27:46 PM) emanuele: it doesn't seem right
(09:28:19 PM) emanuele: I mean I would expect just one path to the _api functions, not a double path almost parallel but partially overlapped
(09:31:38 PM) Norv1: I'm not sure I fully get it - but I recognize the problem - why is it needed in callMenu too (sorry I guess it's obvious to you, but me is trying to understand what we're dealing with here while doing too many thingz at a time)
(09:31:58 PM) Norv1: On another note, what do you think of TE's new template bits?
(09:33:22 PM) ***emanuele didn't check almost anything in the last few days... :-[
(09:33:29 PM) Norv1: I agree with expecting just one path to the _api functions. Maybe we need something, some tweak to the menu calls...
(09:33:47 PM) emanuele: example of approve/unapprove button:
(09:33:48 PM) emanuele: http://localhost/beta_21/index.php?action=moderate;area=postmod;sa=approve;topic=90.0;msg=169;
(09:33:58 PM) emanuele: it points to action=moderate
(09:34:03 PM) Norv1: yes
(09:34:21 PM) emanuele: and it has to process the entire moderation menu including the callMenu
(09:34:29 PM) emanuele: to approve/unapprove something
(09:36:40 PM) Norv1: Still brainfail. I'll need to see the code locally. But, does it block you?
(09:37:19 PM) emanuele: not really (/me is good at workaround things :P ), but it makes the code a bit ugly...
(09:37:33 PM) Norv1: I recognize the problem, but don't remember why I didn't solve it nicely, only worked around it at some point.
(09:37:35 PM) Norv1: LOL
(09:38:10 PM) Norv1: It's for the next round of dispatching updates then. Consider it booked. :D
(09:38:46 PM) emanuele: well, then I'll send a PR with what I've don so far on ajax-fy and I'll save everything else for the next round! :D
(09:39:05 PM) Norv1: That sounds just great!
Title: Re: IRC
Post by: TestMonkey on May 16, 2013, 09:04:29 pm
(09:39:26 PM) Norv: Oh, may I merge them db stuffs?
(09:39:49 PM) Norv: And, if you want a single round of db stuff (or a much bigger round) say so
(09:40:01 PM) emanuele: sooner or later it has to be merged... :P
(09:40:21 PM) Norv: because this PR only adds the layer, and it updates a number of functions, but *not* those widely used.
(09:40:36 PM) emanuele: oh that's cool
(09:40:54 PM) emanuele: (and that demonstrate I didn't read a single line of code and very few docs :P )
(09:41:00 PM) Norv: lol

(09:46:51 PM) ***TehCraw slaps emanuele with Martin Fowler
(09:48:17 PM) ***emanuele slaps TehCraw with Marvin
(09:48:39 PM) TehCraw: Do you guys know if it's actually necessary to put the license comment at the beginning of every file, or can I just use @license in my DocBlock and have a LICENSE.txt file in the root?
(09:49:03 PM) ***TehCraw doesn't like really long opening comments.
(09:50:52 PM) Norv: TehCraw: it's not necessary
(09:51:20 PM) TehCraw: Great. Thanks, Norv. :D
(09:51:30 PM) ***emanuele wants fully bloated headers!!!
(09:51:43 PM) Norv: MPL 1.1 headers ftw.
(09:52:35 PM) TehCraw: GPL headers are very long.
(09:54:28 PM) Norv: That too. :D
(09:55:38 PM) ***TehCraw likes MPL better now, thanks to some unnamed person suggesting I use it.
(09:56:09 PM) Norv: :)
(09:56:24 PM) ***Norv is a fan of MPL. *sagenods*
Title: Re: IRC
Post by: TestMonkey on May 16, 2013, 11:02:52 pm
(11:02:19 PM) groundup: Admin search should be done with a call to a method in each controller.
(11:04:27 PM) groundup: public function getAdminSearch() { return array(array(setting, controller, action)); }
(11:20:24 PM) Norv: It is done with a call to a method in each controller
(11:20:54 PM) groundup: Cool, I thought it was done with a central function

(11:46:09 PM) emanuele: what do you think about dropping the "simple" permissions view?
(11:46:39 PM) Norv: I'd like that
(11:46:57 PM) ***Norv is not a fan. I suppose you mean the view where only some are displayed
(11:47:18 PM) emanuele: TBH I don't even know the difference... lol
(11:47:53 PM) emanuele: I always switch to classic every time I install it...it's one of the first things I do :P
(11:48:48 PM) Norv: Same.
(11:49:01 PM) emanuele: That's something that was hanging around in my mind since a while, though it's Arantor's fault if I remembered it now O:-)
(11:49:57 PM) Norv: I think simple view had a few fans, but tbh I remember many weren't.

(11:50:17 PM) groundup: Is there a function that will tell if a list of topics has been seen? (SELECT * FROM log_topics WHERE id_topic IN($topics))
(11:51:48 PM) Norv: groundup: tbh I don't know lol. We have, so far, made them in no order, no intentions to cover something conceptual, only what has come up in practice.
(11:52:23 PM) groundup: I was just looking at the Markasread.controller
(11:52:24 PM) Norv: Which reminds me we probably should get to that too, at least: make sure that each 'entity' has a basic crud.
(11:53:50 PM) Norv: My suggestion is, if you don't find one suitable for you, just make one. If it will prove duplicate lol, then it will be pointed out during review, or we remove it later.
(11:54:32 PM) ***Norv hasn't really dealt with subs, iz still on controllers and stuff
(11:54:59 PM) groundup: Just looking for queries in controller
(11:56:18 PM) groundup: MessageIndex has a bunch
(11:56:37 PM) Norv: Kill.
Title: Re: IRC
Post by: TestMonkey on May 17, 2013, 12:29:02 am
(11:57:52 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(11:57:52 PM) elk_core: [Elkarte] eurich opened pull request #405: Minimalist theme (master...defaulttheme)  http://git.io/qjhgCg
(11:57:52 PM) elk_core left the room.

(05/17/2013 12:01:46 AM) groundup: Can't comment on the CSS because I don't read hex colors but nice template changes :)

(12:03:20 AM) emanuele: http://www.simplemachines.org/community/index.php?topic=503880.msg3545579#msg3545579
(12:08:36 AM) Norv1: Ohh.
(12:10:46 AM) ***emanuele is thinking too much in that period... :P
(12:10:48 AM) Norv1: Myep... Something as you say, yes. There was an older brainstorming on permissions UI somewhere, I inclined to something like that.
(12:11:13 AM) Norv1: Although one different page for deny won;t work I think
(12:11:18 AM) Norv1: you need to see it
(12:11:57 AM) Norv1: (unless you meant column?)

(12:14:05 AM) emanuele: I was thinking about two pages, but it may even be a "main switch": assign allow/assign deny
(12:14:23 AM) emanuele: and then clicking on the group show all of them or something like that
(12:14:33 AM) emanuele: (I mean allowed and denied)
(12:17:38 AM) Norv1: What I find interesting in particular is groups selectable on the left. It's unexpected in a way, I suppose, but it would be very handy I think. Compared to going back, selecting another group, blah (and forgetting what it was before - sometimes you want to compare mentally, i.e. to assign the same 3 stuffs or something.)

(12:16:41 AM) groundup: hmm... can someone look in to something for me? // If we want to know who participated in what then load this now. in search.controller.php
(12:16:55 AM) groundup: $participants is not used after that. Any idea what it should be?

(12:18:54 AM) emanuele: Nope, apparently is not used groundup
(12:19:15 AM) groundup: It was definitely used at some point. Not sure what for though.
(12:19:25 AM) emanuele: lol
(12:19:31 AM) emanuele: yes, I can imagine
(12:19:39 AM) ***emanuele goes dig SVN :P
(12:20:45 AM) emanuele: aha!
(12:20:48 AM) emanuele: It's a global
(12:21:12 AM) groundup: ugh... who the hell did that?
(12:21:25 AM) emanuele: always been
(12:21:51 AM) groundup: That makes tons of sense, right? no
(12:22:22 AM) emanuele: lol who knows...
(12:22:26 AM) groundup: Ugh, my master is still screwed up.

(12:22:31 AM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(12:22:31 AM) elk_core: [Elkarte] joshuaadickerson opened pull request #406: Topic participation (master...TopicParticipation)  http://git.io/ABOpYg
(12:22:31 AM) elk_core left the room.

(12:22:42 AM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/e1f0eb0c04e9638801038304557f2904c53f3bad
(12:23:03 AM) emanuele: it's like that since 1.1...
(12:25:03 AM) groundup: Did that PR for getTopics() or whatever the equivalent getTopicInfo but for multiple topics, ever get merged?
Title: Re: IRC
Post by: TestMonkey on May 17, 2013, 12:32:38 am
(12:30:16 AM) groundup: Norv, http://screencast.com/t/RWEwjzpT7 any reason for that rogue function?
(12:35:45 AM) Norv: Well. It's a sort of "prepareTopicContext" lol. The prepareXxxContext are functions that hang around controllers now...
(12:36:52 AM) Norv: Sending it to subs would not be that good, since it really does a lot with globals (i.e. $context) - it's a sort of controller helper function
(12:39:15 AM) groundup: It only "prepares" one variable but even still, why is it outside of the class?
(12:40:13 AM) groundup: and getTopic() is not at all telling of what it does and is very prone to be thought of as doing something else (like getTopicInfo())

(12:43:57 AM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(12:43:57 AM) elk_core: [Elkarte] emanuele45 opened pull request #407: Ajax something (master...ajax_something)  http://git.io/wTsnXw
(12:43:57 AM) elk_core left the room.

(12:44:51 AM) Norv: Agree, bad name. As for outside the class, well, thats a question. There are others, in user controllers, it's not a singular case
(12:47:49 AM) groundup: I have a solution... wait 1
(12:49:08 AM) Norv: Some will be moved, but probably not all. I think I'd prefer to have a common solution for the remaining, but I need to see better all cases. Or it might not be entirely possible, and let them be. (inside or outside) Some helper functions/methods.
(12:52:53 AM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/e081427ccd5d921b5138d8e7156343d8d12562a5 now you can get rid of that function ;)
(01:12:34 AM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/03df9499eed6fdf751b40dff66454a43564e1090 https://github.com/joshuaadickerson/NotElkarte/commit/41ea2fce047810ceccf446288e9c48dbcc90159e to complete the removal ;)
(01:13:13 AM) Norv: Ah, thank you! Will look! (need clear head and ain't got one of those)

(01:14:55 AM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(01:14:55 AM) elk_core: [Elkarte] norv pushed 32 new commits to master: http://git.io/FxSDbg
(01:14:55 AM) elk_core: Elkarte/master 813df3a Thorsten Eurich: initial commit for the white minimalistic theme (just the index.css for now).. credits go to emanuele45 :)...
(01:14:55 AM) elk_core: Elkarte/master 70c5fdd Thorsten Eurich: replaced the light blue with a light grey inside the admin section....
(01:14:55 AM) elk_core: Elkarte/master f33c014 Thorsten Eurich: added basic variant support, just testing features.....
(01:14:55 AM) elk_core left the room.

(01:15:24 AM) Norv: emanuele: oops the theme got some conflict with ajaxsomething
(01:16:56 AM) Norv: mmm obviously. But it's because everyone is after you.
(01:17:53 AM) ***emanuele was expecting something like that... :P
(01:20:05 AM) Norv: That everyone is after you? :-X
(01:20:45 AM) emanuele: that too... :O
Title: Re: IRC
Post by: TestMonkey on May 17, 2013, 12:38:58 am
(12:25:03 AM) groundup: Did that PR for getTopics() or whatever the equivalent getTopicInfo but for multiple topics, ever get merged?

Which one, this?
https://github.com/elkarte/Elkarte/pull/205
Title: Re: IRC
Post by: TestMonkey on May 17, 2013, 02:23:23 am
(02:14:43 AM) emanuele: arg right, json is 5.2...
(02:15:33 AM) groundup: load Compat.subs.php if PHP version < 5.3
(02:16:00 AM) groundup: That way you are coding for 5.3 but allow for 5.1
(02:17:39 AM) emanuele: meh...don't want to write a json_encode function... :P
(02:19:39 AM) groundup: You don't need to: http://us2.php.net/manual/en/function.json-encode.php#100835
(02:20:28 AM) groundup: https://github.com/joshuaadickerson/NotElkarte/commit/dbaeca1141b26f3e9388e7492f2a7ef7d7b1eace
(02:26:21 AM) emanuele: mmm...I don't like to rely too much on functions found "around on the internet" for default features...but maybe Norv thinks otherwise
(02:27:03 AM) groundup: It's the basis for open source development - you don't invent everything, you can use something from someone else

(02:29:50 AM) groundup: That sucks... my Netbeans project just got corrupted. Now I can't open it.
(02:30:12 AM) groundup: I was just about to add an About controller and move the coppa agreement, the registration agreement, credits, etc to that.
(02:36:52 AM) groundup: Then I was going to change the Dispatcher to send a DIC to the controllers.
(02:37:33 AM) groundup: So, in the future people will start to use it

(02:35:30 AM) Norv1: Bah.
(02:39:40 AM) Norv1: Agree Ema. And, dunno... Should we really want to add _more_ stuff like this, compatibility for newer PHP features. In a sense it's worse than not adding it at all for this version.
(02:40:01 AM) groundup: So you're not going to allow JSON?
(02:40:36 AM) groundup: You could just bump the minimum version to one that makes sense ;)
(02:43:46 AM) Norv1: I don't know, really. More arguments welcome. Yeah, but we're talking an almost new api (well otherwise underused), a new design/implementation for it, on ajax stuffs... that's already a nice thing
(02:43:21 AM) emanuele: well...TBH go 5.2 is a bit tempting... O:-) though is json *so* necessary in that world?
(02:43:40 AM) emanuele: genuine question
(02:43:50 AM) groundup: Is JSON necessary? Hmm... 2000 called, they want their XML back :P
(02:45:26 AM) Norv1: ema: yes. But I don't expect use of this api as json, as much as data of relevance, for some consumer
(02:47:31 AM) Norv1: Such as sending news. Topics by user. Data.
Title: Re: IRC
Post by: TestMonkey on May 17, 2013, 02:24:26 am
(02:47:10 AM) groundup: Here goes 1000 arguments for bumping the minimum versions in a breath: hosts are *vendors*, they do what *you* want, not the other way around; Elkarte is new software, you aren't going to be getting first time users that you need to worry about supporting; this is 2013, PHP 5.3 is over 5 years old; who do you care more about - people that want to use cool UI interactions or people that want to support software from a decade ago; develop for tomorrow, not for 10 years ago; At least 5.2.9.. geez

(02:49:10 AM) groundup: In Calendar.controller.php -> // There could be already a topic you are not allowed to modify that query produces two variables that aren't used. What were they for before?

(02:55:12 AM) Norv: >> who do you care more about - people that want to use cool UI interactions or people that want to support software from a decade ago
(02:55:12 AM) Norv: That's a question. My answer is the first. (within some limits). Ema?
(02:55:41 AM) emanuele: myself :P
(02:56:18 AM) ***emanuele is very, very selfish O:-)
(02:56:36 AM) Norv: lol
(02:59:18 AM) emanuele: well, it's true: I am an SMF user (1.1) and I was on php 5.1 until a year ago when I discovered 5.2 was available and now I'm on 5.3 (and I'm using one of the biggest Italian oversellers too :P )

(02:56:19 AM) Norv: >> Elkarte is new software, you aren't going to be getting first time users that you need to worry about supporting
(02:56:19 AM) Norv: *cough*. Nope. Elk supports SMF users to upgrade.
(02:58:26 AM) groundup: Although it is really just an upgrade, it is also a conversion
Title: Re: IRC
Post by: TestMonkey on May 17, 2013, 02:26:19 am
(02:59:58 AM) groundup: I really want to know what is up with this // There could be already a topic you are not allowed to modify
(03:00:04 AM) groundup: I feel like that there is a security issue somewhere in that
(03:00:51 AM) groundup: Hmm... it's that way in 2.1
(03:01:22 AM) emanuele: it's new from 2.1...
(03:01:27 AM) emanuele: dunno who touched that part
(03:02:08 AM) groundup: https://github.com/SimpleMachines/SMF2.1/commit/f430ae407218f54d80d32583e3ad04a5565afd3f
(03:02:51 AM) groundup: https://github.com/SimpleMachines/SMF2.1/commit/f430ae407218f54d80d32583e3ad04a5565afd3f
(03:02:56 AM) groundup: Woops
(03:04:09 AM) Norv: http://dev.simplemachines.org/mantis/view.php?id=4734
(03:04:41 AM) emanuele: http://www.simplemachines.org/community/index.php?topic=349676.msg3038934#msg3038934
(03:05:17 AM) ***emanuele feels something got lost somewhere...
(03:05:27 AM) groundup: So, Spuds committed your mistake :P
(03:05:34 AM) groundup: lmao
(03:05:43 AM) emanuele: nope, my code was right
(03:05:54 AM) groundup: Ah, I see it now
(03:06:00 AM) groundup: Do you want to fix it?
(03:08:10 AM) emanuele: it's probably one of the first bug fixes I proposed! :D
(03:08:58 AM) emanuele: I don't even remember any more which one was the better solution... lol
(03:13:10 AM) groundup: So... do you think that query should be there or no?
(03:13:19 AM) groundup: If it should, it should be replaced with getEventProperties()
(03:14:02 AM) emanuele: I should read my mind of 2 years ago...unlikely. The query is fine and fixes the issue apparently, so it could stay there

(03:14:11 AM) emanuele: YAY!
(03:14:21 AM) emanuele: Finished to change permissions, finally I can go bed!
(03:14:33 AM) emanuele left the room (quit: Remote host closed the connection).
Title: Re: IRC
Post by: TestMonkey on May 17, 2013, 02:47:42 am
(03:28:35 AM) groundup: Am I missing something big here: Calendar.controller.php -> // Make sure the user is allowed to edit this event.
(03:28:44 AM) groundup: The isAllowedTo() is done after everything else
(03:37:06 AM) Norv: Err. loadBoard() is used for its side-effect: that if the user doesnt see it, then it fills the globals with 0 and stuff like that, it wants to boot them out
Title: Re: IRC
Post by: TestMonkey on May 18, 2013, 01:58:03 am
(04:05:49 AM) groundup: Can we use the constructor in the controllers now?
(05:46:14 AM) groundup: Norv, my repo is still jacked up

(08:32:25 AM) groundup: split topics controller: return action_splitSelectTopics(); should be return $this->action_splitSelectTopics();

(02:13:16 PM) Norv1: groundup: I suspect the unfinished merge that was around, messed up. git checkout master; git pull -f elkarte master
(02:14:07 PM) Norv1: git checkout master; git reset --hard 7281526; git pull elkarte master
(02:14:25 PM) Norv1: The second is an alternative sequence.

(02:35:26 PM) Trekkie101_Away: New theme is looking snazzier

(02:37:53 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(02:37:53 PM) elk_core: [Elkarte] norv pushed 18 new commits to master: http://git.io/oCbuRA
(02:37:53 PM) elk_core: Elkarte/master 9fa3a78 emanuele: Testing suggestions on ajaxify things...
(02:37:53 PM) elk_core: Elkarte/master 180ec73 emanuele: Some more changes to properly handle the "api" requests...
(02:37:53 PM) elk_core: Elkarte/master a716a27 emanuele: And the javascript to handle the notification button...
(02:37:53 PM) elk_core left the room.

(02:44:28 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(02:44:28 PM) elk_core: [Elkarte] norv pushed 96 new commits to master: http://git.io/NPHSUw
(02:44:28 PM) elk_core: Elkarte/master f27d830 Norv: Add quick 'n dirty Util class, legacy string functions from $smcFunc....
(02:44:28 PM) elk_core: Elkarte/master 7e23d66 Norv: Quick ->elk_ replacement....
(02:44:28 PM) elk_core: Elkarte/master 0d2391f Norv: Refactor db layer. (add db classes, add init per type)...
(02:44:28 PM) elk_core left the room.

(02:58:10 PM) Norv1: Trekkie101_Away: and we haz Ema's ajaxified thingies now
(02:58:17 PM) Trekkie101_Away: :)

(03:44:39 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(03:44:39 PM) elk_core: [Elkarte] emanuele45 opened pull request #410: Templates (master...templates)  http://git.io/F4H13w
(03:44:39 PM) elk_core left the room.
Title: Re: IRC
Post by: TestMonkey on May 18, 2013, 01:58:30 am
(07:01:31 PM) emanuele: Norv!!!! Fatal error: Access type for interface method Database::last_error() must be omitted in /sources/database/Db.php on line 181
(07:01:34 PM) emanuele: :P
(07:03:17 PM) emanuele: abstract function last_error($connection = null);
(07:03:24 PM) emanuele: Should abstract be removed?
(07:04:21 PM) emanuele: also: Deprecated: Call-time pass-by-reference has been deprecated in /sources/database/Db-mysql.subs.php on line 27
(07:12:53 PM) Norv1: OY
(07:15:39 PM) Norv1: Fixed.
(07:23:16 PM) Norv1: (err, fixed directly without PR. I won't make it a habit, promise. :))
(07:41:25 PM) emanuele: The call-time pass-by-ref is still around... :P

(11:19:20 PM) Norv: groundup: fixed, thank you!
(11:20:06 PM) Norv: ema, tbh I thought it lower priority and didn't look at, sorry
(11:25:56 PM) emanuele: oh no problem! ;D

(05/18/2013 12:09:11 AM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(12:09:11 AM) elk_core: [Elkarte] norv opened pull request #411: Fixes (master...fixes)  http://git.io/5rGtOQ
(12:09:11 AM) elk_core left the room.

(11:59:03 PM) emanuele: When a Norv's commit message contains "very basic" be sure it's scary. :P
(12:11:27 AM) Norv: Ouch.
(12:11:54 AM) Norv: What did I do now?

(12:46:14 AM) ***emanuele is breaking templates! :D

(02:16:21 AM) groundup: I really don't want to test out https://github.com/joshuaadickerson/NotElkarte/tree/Denormalize-Attachments%26Events :(
(02:51:27 AM) Norv: I think serious pre-acceptance testing is really needed in that case. We don't get a prize for performance with untested risky changes to db structure.

(02:53:09 AM) Norv: >> groundup: Can we use the constructor in the controllers now?
(02:53:09 AM) Norv: Sure. I didn't see any need (that I remember), but we could anytime.
Title: Re: IRC
Post by: TestMonkey on May 19, 2013, 11:31:09 am
(10:25:10 PM) Norv: lol Ema. Thanks for the smf heads-up. But, will you do the same on Elk again? O:-) Or make a nice and cool page/block to pull them from github? :)
(10:28:08 PM) emanuele: http://www.elkarte.net/index.php?topic=362.0
(10:28:19 PM) emanuele: It's funnier do it by hands! :P
(10:28:31 PM) emanuele: And I can comment on things... lol
(10:29:20 PM) emanuele: SMF is just way easier to do, so I do it first.

(10:29:56 PM) emanuele: BTW there is something not working as expected again on the site I think...
(10:30:09 PM) emanuele: now I don't see the default avatars anymore

(10:55:08 PM) groundup: I need content for my about actions

(10:57:09 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(10:57:09 PM) elk_core: [Elkarte] joshuaadickerson opened pull request #419: Select messages (master...selectMessages)  http://git.io/b5HKng
(10:57:09 PM) elk_core left the room.

(05/19/2013 12:53:54 AM) ***groundup feels like standardizing names would help some.
(12:55:11 AM) groundup: createCategory(), createBoard(), registerMember(), createPost() -> createCategory(), createBoard(), createMember(), createMessage()
(12:55:28 AM) groundup: Or, add*()
(01:00:34 AM) Norv: Agree
(01:20:10 AM) Norv: Funny I was just writing something in the same direction.
(01:29:21 AM) emanuele: standardization is boring... :(
(01:29:28 AM) emanuele: :P

(09:19:56 AM) groundup: Norv, I kind of went on a rant before I read your post http://www.elkarte.net/index.php?topic=361.msg2371#msg2371
Title: Re: IRC
Post by: TestMonkey on May 19, 2013, 11:32:58 am
(11:23:04 AM) Norv: groundup: would you be interested to add a unit testing framework to Elk? Needs a small readme/how_to_setup for us, or a wiki page on it, and a few starting-up tests on whatever part of code, so that we can just take it as example.
(11:24:01 AM) groundup: Nope - that's what PHPUnit is for
(11:24:15 AM) groundup: Then there is the one by Fabien Pontencier.
(11:26:00 AM) Norv: Yes, to add PHPUnit if you prefer it. I was not suggesting to write a testing framework.
(11:26:35 AM) groundup: So, you're really asking me to write tests and some documentation on how to write tests? :P
(11:29:44 AM) groundup: Kind of hard to do currently. Most functions need to be broken down a lot more and most of them require way too many outside resources which make them nearly impossible to test the functionality
(11:30:46 AM) Norv: Adding unit testing per se requires: a PR with the addition, the configuration that works (extra-folder, config files), a post to announce it and encourage its use, a few start-up things for us to see: a few tests, an addition in the readme and/or wiki on the process.
(11:30:50 AM) groundup: I would start with permute(), comma_format(), shorten_text() etc
(11:31:07 AM) Norv: Agree, unfortunately. But we still have to start somewhere
(11:31:20 AM) Norv: and we will have Spuds parsebbc() I believe
(11:31:46 AM) groundup: I was just about to say that parse_bbc() would be great to test, but mocking it will be a huge pain in the booty
(11:32:13 AM) Norv: As for database data needed, that's why there are mockups. Probably we should add a few mockups if we can.
(11:32:36 AM) Norv: Well, keep it in mind
(11:32:43 AM) groundup: Adding tests for parse_bbc() in general will be a pain in the booty as there are so many permutations of tests
(11:33:26 AM) Norv: The refactoring we're doing is very risky by design. That's intended, but well. Sooner or later we'd better start doing it by the book. That is, with unit testing.
(11:33:45 AM) groundup: It's rewriting at this point
(11:33:48 AM) Norv: Yes.
(11:36:02 AM) groundup: I agree, testing should be there. Check /msg
Title: Re: IRC
Post by: TestMonkey on May 21, 2013, 01:05:51 am
(05:39:41 PM) elk_core: [Elkarte] norv opened pull request #420: Fix escape_ methods (master...fixes)  http://git.io/Jj2M4A
(05:58:31 PM) elk_core: [Elkarte] norv opened pull request #421: Removing CurveClassic from core. (master...classic)  http://git.io/V-R5dg
(06:40:17 PM) elk_core: [Elkarte] norv opened pull request #422: List (master...list)  http://git.io/O6d43g

(07:26:36 PM) Norv: Ema, if necessary, we could perhaps add a theme initialization function. Something guaranteed to be called by the core template engine before it starts outputting layers. Dunno, just a thought.
(07:27:34 PM) emanuele: isn't it template_init?
(07:28:49 PM) Norv1: I thought about that, perhaps that. I think it isn't called right before, but might work?
(07:31:55 PM) Norv1: I was thinking at something optional, like [theme_id]_layers($template) - if it exists, then it's called, with result layers.
(07:32:55 PM) ***Norv feels themes become hooked addons.
(07:40:05 PM) emanuele: not sure what it would do...
(07:46:21 PM) Norv: it would return the array for $context['template_layers']
(07:46:46 PM) Norv: That's over-complicating it, I guess, lol.
(07:51:44 PM) Norv: I think what Nao is saying is like 'sections'. The page split in sections, each with functions for before and after. Sections are 'building blocks'.
(08:05:22 PM) emanuele: yes...though I'm not sure why is the template to define the layers...or at least all of them
(08:06:22 PM) emanuele: wouldn't be something like: https://github.com/emanuele45/Dialogo/blob/theme_playing/sources/Load.php#L2656
(08:07:08 PM) emanuele: and https://github.com/emanuele45/Dialogo/blob/theme_playing/sources/Subs.php#L3033
(08:11:11 PM) Norv: Nice
(08:12:39 PM) emanuele: I think that is "mostly" what Nao and Arantor are describing, without the xml-like part
(08:12:47 PM) emanuele: well, sort of
(08:14:03 PM) emanuele: I think their situation is more: [before] BLOCK1 [after] [before] BLOCK2 [after] etc.
(08:14:33 PM) emanuele: that looks a bit overkill...but I may be wrong, that depends on many factors I think...
(08:15:49 PM) Norv: In any case, if an advanced layout so to speak, needs to change layers order or even drop one, my guess is it'd be easy to add a call to a function the theme can implement. If init is too early (not sure, but that's what I was suspecting), then from prepareContext()
(08:16:24 PM) Norv: Well... that's more like I thought layers would be used. O:-)
(09:01:36 PM) groundup: I was just thinking about this the other day (like yesterday or the day before)... it needs a constructor and then another one that goes right before it
(09:03:34 PM) groundup: There should be one function: loadView() which loads which theme to load. The theme should be a class which can be extended when you don't want to create all of your own templates.
(09:06:32 PM) groundup: abstract class Theme { public $context = array(), $settings, $options, $layers; }
(09:07:57 PM) groundup: $txt should not be part of the theme. The $txt dependency should be passed to the theme
(09:10:54 PM) groundup: All models should should return values. Those values should be passed to the view (in most cases) via the controller. Each action controller returns its results to the base controller (through the router/dispatcher)
(09:11:28 PM) Norv: Dunno. Ema, please feel free to disregard my suggestions or stuff on this, I don't have enough grasp on it, but the layers stuff really is better than our current engine.
(09:12:53 PM) groundup: loadView() (replaces the call to loadTheme() in index.php) figures out the output strategy and then loads the appropriate theme.
(09:15:29 PM) ***Norv is debugging the upgrade script and cannot really distribute attention lol sorry
(09:17:41 PM) Norv: ffs this should be the last time I do this.

(09:21:08 PM) elk_core: [Elkarte] norv opened pull request #423: Fixes (master...fixes)  http://git.io/anTpjQ
Title: Re: IRC
Post by: TestMonkey on May 21, 2013, 01:07:07 am
(09:27:15 PM) emanuele: > Norv   In any case, if an advanced layout so to speak, needs to change layers order or even drop one, my guess is it'd be easy to add a call to a function the theme can implement. If init is too early (not sure, but that's what I was suspecting), then from prepareContext()
(09:28:01 PM) emanuele: yeah, it may be useful to let the theme decide what to do, it's always a tiny line where it stops the realm of the "source" and where the one of the "theme"...lol
(09:30:23 PM) emanuele: The best example of this situation I can think of is the "message buttons" (i.e. quote/quick edit/more/etc.)
(09:32:57 PM) emanuele: buttons can be added from mods (in source), but it would be nice to let themers decide if they want to show everything or just something (for example because someone may want to split them up in two positions), then I thought that it may be interesting also give themes the option to support or not multiple levels (i.e. have more or not), but that has to be done for each button if we want to...
(09:32:59 PM) emanuele: ...keep the current configuration with "quote to new" as "child" of quote, etc...
(09:33:10 PM) emanuele: in other words it's a bit of a mess... lol
(09:33:19 PM) groundup: emanuele, I like your changes. One thing I don't like is that they are in the Subs file ;)
(09:33:43 PM) emanuele: which?
(09:33:59 PM) groundup: template layers
(09:35:18 PM) emanuele: well, at the moment I just split them up and left theme where they are without looking into where they should be (not that I know where they should logically be heh)
(09:36:20 PM) groundup: class Layers... Layers.subs.php
(09:36:44 PM) groundup: loadTheme() {require_once 'Layers.subs.php'; }

(10:58:22 PM) groundup: I was trying to figure out how to move the membergroups from the boards table. There is already a board_permissions table, why not just add can_see as a permission? At the same time, an easy optimization is to make the permission field a char(30)

(11:02:01 PM) groundup: Just realized a very big potential failure: id_group smallint(5) unsigned NOT NULL auto_increment
(11:03:08 PM) groundup: Since a lot of places rely on id_group being signed, making that an unsigned can cause a lot of issues if you get to >32k. Either make it signed or make everything use an unsigned integer. I prefer the later

(11:06:33 PM) Norv: Agree on location, it's for use... Could also be directly in /sources, as core class (like the combiner or browser detector are).
(11:30:31 PM) ***emanuele wants to rewrite from scratch the theme... ROFL
(11:37:23 PM) ***emanuele hates mediawiki
(11:58:50 PM) Norv: rewrite from scratch the theme? You mean, Elk's default theme?
Title: Re: IRC
Post by: TestMonkey on May 21, 2013, 01:10:00 am
(01:42:45 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/TlLGpg
(01:42:45 AM) elk_core: Elkarte/master 81009b7 Norv: Fix upgrade script after db layer updates....
(01:42:45 AM) elk_core: Elkarte/master a1ec80c Norv: Small fixes for upgrade script....
(01:42:45 AM) elk_core: Elkarte/master c1ba4c1 Norv: Merge pull request #423 from norv/fixes...

(01:47:31 AM) elk_core: [Elkarte] Spuds opened pull request #424: Change literal 'null' to null in setPermissionLevel function and call (master...literalNull)  http://git.io/puomuQ

(01:52:51 AM) elk_core: [Elkarte] joshuaadickerson opened pull request #425: Post (master...Post_new)  http://git.io/U7wlkQ

(01:57:35 AM) elk_core: [Elkarte] joshuaadickerson opened pull request #426: Attachment thumb (master...AttachmentThumb_new)  http://git.io/B6XhEw

(02:44:10 AM) groundup: $context = $user_info :P
(02:57:03 AM) Norv: :(
(03:00:36 AM) Norv: It really isn't. Info on the current user is more necessary (and unavoidable) even in subs, than the_story_about_universe_and_everything

(03:01:56 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/L-xxYw
(03:01:56 AM) elk_core: Elkarte/master 78f0b30 Spuds: ! Change literal 'null' to null...
(03:01:56 AM) elk_core: Elkarte/master ec902a0 Norv: Merge pull request #424 from Spuds/literalNull...

(03:02:28 AM) groundup: I changed it. It isn't in theory, but in practice it is the same. Right or wrong. I changed it because I agree with you.
(03:03:34 AM) groundup: I think it can be something useful and put in there, but for the limited use right now and the fact that it requires theme options, settings, and user info, it is probably more likely to be something for the view
Title: Re: IRC
Post by: TestMonkey on May 21, 2013, 01:11:11 am
(04:26:20 AM) elk_core: [Elkarte] joshuaadickerson opened pull request #427: Participation (master...Participation)  http://git.io/FAQHig

(06:35:26 AM) groundup: Ugh, trying to figure out which of these dozen get board functions will help me out. Looks like none of them can replace Post.subs.php -> // Load the actual board names

(06:56:38 AM) elk_core: [Elkarte] joshuaadickerson opened pull request #428: Notifications (master...Notifications)  http://git.io/W1-qwg

(12:04:26 PM) elk_core: [Elkarte] norv opened pull request #430: Cleanups (master...cleanups)  http://git.io/-9Xl3A
(12:05:02 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/lBb5Qw
(12:05:02 PM) elk_core: Elkarte/master ca15628 Norv: Missed pass-by-ref. Remove fix_prefix compatibility and use it through $db....
(12:05:02 PM) elk_core: Elkarte/master 6082392 Norv: Fix buggy use of globals....
(12:05:02 PM) elk_core: Elkarte/master a5f72c5 Norv: Update documentation for fix_prefix....

(06:50:49 PM) elk_core: [Elkarte] norv opened pull request #431: Querystring.php (master...querystring.php)  http://git.io/s1SM3Q

(08:06:30 PM) groundup: Norv, what do you think about moving those index.php calls (loadTheme, loadMember, etc) to Controller and then extending that from each controller. It gives the controllers a lot more control
(08:08:55 PM) Norv: Not sure (having just looked at them it feels like small changes to organize the code would be better.). Btw, groundup please check https://github.com/elkarte/Elkarte/pull/431
(08:09:18 PM) groundup: I did already
Title: Re: IRC
Post by: TestMonkey on May 21, 2013, 01:12:34 am
(08:57:57 PM) Norv: https://github.com/joshuaadickerson/NotElkarte/pull/1 O:-)
(09:58:57 PM) groundup: thanks
(09:59:39 PM) groundup: Now your turn to merge ;P

(10:01:00 PM) elk_core: [Elkarte] norv pushed 19 new commits to master: http://git.io/3GAUfw
(10:01:00 PM) elk_core: Elkarte/master 7e2ad64 Joshua Dickerson: Save a query for all guests on the post screen and that same saved query can also save a query in other occasions...
(10:01:00 PM) elk_core: Elkarte/master 2069340 Joshua Dickerson: add createPoll()...
(10:01:00 PM) elk_core: Elkarte/master d7f32c8 Joshua Dickerson: Calendar events have subs...

(08:12:22 PM) groundup: In index.php, // Seed the random generator.
(08:12:52 PM) groundup: That should be done on install. If it is blank after that, it should generate a warning
(10:00:27 PM) groundup: what do you think about the index.php thing? I want to remove it but I don't want to cause issues

(10:04:56 PM) Norv: I don't see how can it be moved, Josh, let it be executed at every request
(10:05:15 PM) groundup: I don't care that it is executed, I care that it is not there.
(10:05:31 PM) groundup: So, say you change the seed, you are changing "security" elements
(10:07:12 PM) groundup: If it is not there, it should trigger some kind of warning. That goes along with all of these pre-include checks. If the settings are wrong, trigger a warning. Better to have them checked by an administrator.
(10:10:15 PM) Norv: The point is, it should be executed each request, so that quite often it changes
(10:10:41 PM) Norv: I don't see how you'd do that if it's only executed once at install.
(10:11:33 PM) groundup: Hmm... don't see how I screwed that one up lol
(10:11:51 PM) groundup: I am just now drinking my first cup of coffee. Should have done that earlier.
(10:12:25 PM) Norv: LOL

(10:35:33 PM) Norv: groundup: you'll want to keep in mind to keep your master updated. git checkout master; git pull elkarte master. And, on branches, rebase (or merge) from master as often as possible. i.e.: git rebase master
Title: Re: IRC
Post by: TestMonkey on May 21, 2013, 01:13:52 am
(10:37:18 PM) Norv: emanuele: when do we do the next database layer update? Probably, next and last, or close to.
(10:37:46 PM) emanuele: when you want... what's left to do?
(10:38:00 PM) Norv: A miriad of search/replace
(10:39:16 PM) Norv: https://github.com/elkarte/Elkarte/wiki/Database-layer
(10:40:24 PM) groundup: Yay! A commit with every file changed ;)
(10:40:52 PM) Norv: All (hopefully) $smcFunc replaced. Quite so! Except them admin controllers, cuz they don't have queries!
(10:41:12 PM) Norv: Well most of them. /remembers my 'friend' Themes.
(10:41:59 PM) emanuele: lol
(10:42:12 PM) emanuele: I didn't realize this was still missing
(10:42:34 PM) emanuele: Search&Replace FTW!
(10:42:38 PM) Norv: 10% were done, 90% are left :D
(10:43:32 PM) emanuele: 4859 occurrences of $smcFunc
(10:43:37 PM) emanuele: mmm...lol
(10:44:46 PM) groundup: Well, hopefully you're doing it staged... replace all of the database calls, then all the util, then figure out where $smcFunc is still globalized and remove it
(10:45:13 PM) groundup: (that is how I was going to do it but I figured you were already started lol)
(10:46:56 PM) emanuele: Well, we could even work on that while doing other things
(10:47:16 PM) emanuele: not as clean...
(10:48:43 PM) Norv: groundup: sort of, remember though that we need to add to every call a retrieval of database()
(10:49:00 PM) Norv: so it's not blind search/replace unfortunately
(10:50:04 PM) Norv: The way I did so far (with rarely used functions) has been to pick one, replace all its occurences, and remove it from compatibility array.
(10:50:05 PM) emanuele: it can be a blind search and replace and then a huge hunt for the missing database() :P
(10:50:10 PM) Norv: hehe
(10:51:13 PM) Norv: btw, we could do database()->query('stuff'), but I didn't so far. As element of style I guess, and because many functions have more calls, I'd rather have a nice clear line initializing the thing...
(10:51:24 PM) Norv: Or so I thought so far, anyway.
(10:54:25 PM) Norv: groundup: feel free! I'm happy to split O:-) you can take db_num_rows, for example. One without many occurrences! :D
(10:55:14 PM) emanuele: s/^\tglobal(.*)(\$smcFunc)(.*);$/\t$1$2;\n\n$db = database();\n/
(10:55:35 PM) emanuele: then you hunt just the files with syntax errors :P
(10:55:42 PM) emanuele: lol
(10:57:01 PM) Norv: lol
(11:02:09 PM) ***emanuele tries
(11:31:27 PM) ***Norv starts db_insert_id, and gets sidetracked in many queries in repair boards
(11:43:27 PM) ***emanuele replaced everything, now testing
(11:45:18 PM) Norv: Oh lol cool!
(11:45:32 PM) ***Norv got bored of manual replacements :P
(11:55:18 PM) emanuele: A bit messy but seems to work... :P
(11:55:42 PM) Norv: Cool!
(11:56:17 PM) emanuele: Mostly...
(11:56:23 PM) emanuele:  :P

(11:57:37 PM) elk_core: [Elkarte] norv opened pull request #432: Database layer updates (2) (master...database2)  http://git.io/NnU-qw
(11:57:54 PM) Norv: I guess I shouldn't have sent my PR, but just FYI
Title: Re: IRC
Post by: TestMonkey on May 21, 2013, 01:20:16 am
(11:57:43 PM) emanuele: Norv: https://github.com/elkarte/Elkarte/blob/master/sources/database/DbTable-mysql.php#L395
(11:57:53 PM) emanuele: php tells me there is something wrong...
(11:59:33 PM) emanuele: Also in Db-sqlite-class.php function last_error is present twice

(12:03:32 AM) elk_core: [Elkarte] norv opened pull request #433: DbTable package log fix (master...fixes)  http://git.io/FvmvCw

(12:09:13 AM) Norv: Added!
(12:09:32 AM) Norv: Thank you!
(12:09:51 AM) Norv: Told you I can fight.
(12:10:51 AM) ***Norv is innocently waiting for more

(12:11:59 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/YBHxfA
(12:11:59 AM) elk_core: Elkarte/master 69a730d Norv: Fix leftover oops....
(12:11:59 AM) elk_core: Elkarte/master 44ec9b4 Norv: SQLite last_error() was duplicate. Thank you Ema!...

(12:12:02 AM) emanuele: Norv: did you kill $txtBirthdayEmails?
(12:14:19 AM) emanuele: also: return $$config_vars; in ManageServer
(12:15:13 AM) emanuele: $settings_not_writable in ManageLanguage
(12:15:40 AM) emanuele: and $context['invalid_badbehavior_httpbl_key'] in ManageSecurity
(12:15:51 AM) Norv: I think I didn't kill it birthdays...
(12:16:27 AM) emanuele: I tried an admin search and it gives an error on that variable...then probably is simply not loaded
(12:20:29 AM) Norv: I think things moved and it's not loaded when it should yes, will look at that too
(12:21:32 AM) emanuele: does ?action=moderate;area=groups;sa=requests work for you?
(12:21:57 AM) emanuele: I get Fatal error: Class 'controllers/Groups_Controller' not found in
(12:22:33 AM) emanuele: (sorry for the many errors, but I'm testing the replacements... O:-))
(12:23:25 AM) emanuele: also ?action=moderate;area=settings
(12:23:33 AM) emanuele: Fatal error: Call to undefined method Modlog_Controller::action_moderationSettings()
(12:23:48 AM) emanuele: Fatal error: Call to undefined method Modlog_Controller::action_modEndSession()
(12:24:40 AM) Norv: ManageServer, fixed. ManageLanguage fixed.
(12:27:56 AM) Norv: ManageSecurity fixed.
(12:28:26 AM) emanuele: Fatal error: Call to undefined function action_mailingsend()
(12:31:01 AM) Norv: Groups_Controller fixed.
(12:31:37 AM) Norv: I'll get you! :D
(12:37:20 AM) emanuele: ?action=admin;area=languages;sa=settings
(12:37:36 AM) Norv: action_moderationSettings() and action_modEndSession(), fixed!

(01:08:19 AM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(01:08:19 AM) elk_core: [Elkarte] norv opened pull request #434: More fixes, from Ema (master...fixes)  http://git.io/6JyIIw
(01:08:20 AM) elk_core left the room.

(01:21:45 AM) ***Norv is still on for moar! *takes coffee*
(01:27:18 AM) emanuele: I'm playing with NetBeans (useful for missing global) and it tells me: DbTable_MySQL is not abstract and does not override abstract method elk_db_table_structure(...)
(01:27:38 AM) emanuele: postgres and sqlite don't "extends DbTable"
(01:28:02 AM) Norv: oh ok thank you, fixing
(01:36:35 AM) Norv: Fixed!
(01:39:10 AM) Norv: Well until proven differently.
Title: Re: IRC
Post by: TestMonkey on May 21, 2013, 01:52:18 am
(12:56:38 AM) emanuele: what do you think about db_case_sensitive as a static something?
(01:01:56 AM) Norv: why?
(01:27:53 AM) Norv: I see db_case_sensitive is used as expected, in member names search stuffs... IMHO it's premature to worry about performance of indirections (if this is the concern)... although it's true that db has at least one more than it could (I think)
(01:32:48 AM) emanuele: not really performance, just I didn't like to have $db = database() just for the case sensitive check... :P
(01:35:31 AM) emanuele: lucky you, I have no idea what it means... lol
(01:40:33 AM) Norv: Yes, well, they aren't many... the case sensitive checks, and probably we have there some almost-duplicate queries too
(01:41:40 AM) Norv: Perhaps we can review things later, when we know what stays where much better than right now. And do something with the singular calls, dunno
(01:43:48 AM) emanuele: nothing urgent nor important. ;)

(02:00:56 AM) Norv1: Is anyone fond of upgrade scripts in .sql?
(02:02:52 AM) emanuele: arg...I forgot to touch install.php and upgrade.php... :'(

(02:04:09 AM) elk_core: [Elkarte] emanuele45 opened pull request #435: Database search and replace! (master...database_snr)  http://git.io/yA1eWA

(02:04:20 AM) Norv1: I mean, of upgrade scripts specific format, defining blocks, with raw sql and other stuff
(02:04:44 AM) Norv1: Oh wow thank you!
(02:05:08 AM) emanuele: It would be nice to have 1 script understood by all the DBs...
(02:05:46 AM) emanuele: what do you have in mind?
(02:17:44 AM) Norv1: I'd rewrite the sql-ish scripts to php. Simple good old php. All steps in order, execute the thing.
Title: Re: IRC
Post by: TestMonkey on May 21, 2013, 01:52:32 am
(02:18:36 AM) emanuele: https://github.com/elkarte/Elkarte/pull/435#issuecomment-18179923
(02:18:38 AM) emanuele: YAY!
(02:19:24 AM) ichbin: woah. Talk about a tedious task. lol
(02:20:42 AM) emanuele: http://pastebin.com/B0saZUz5
(02:20:45 AM) emanuele: O:-)
(02:20:47 AM) emanuele: and more
(02:22:10 AM) ichbin: lol emanuele=>ubergeek ;)
(02:22:38 AM) emanuele: And then NetBeans to help find missing globals, yes tedious and a total of 3 hours... :O
(02:23:00 AM) ***emanuele uses google and trial&error... O:-)

(02:26:30 AM) ichbin: Been getting all the elkarte git emails. You guys are very busy. lol How have you been?
(02:27:57 AM) emanuele: very busy with Elkarte LOL
(02:28:47 AM) ichbin: haha
(02:30:30 AM) Norv: emanuele: Thank you!! I'm going to merge it. No point in not doing it, haz to be done.
(02:30:45 AM) emanuele: ROFL
(02:30:52 AM) emanuele: let's break it!

(02:31:24 AM) elk_core: [Elkarte] norv pushed 17 new commits to master: http://git.io/52hJDA
(02:31:24 AM) elk_core: Elkarte/master b77f579 emanuele: WIP removing globals...
(02:31:24 AM) elk_core: Elkarte/master 4c10d87 emanuele: WIP removing globals...
(02:31:24 AM) elk_core: Elkarte/master ed96515 emanuele: $smcFunc['db_query'] => $db->query...

(02:32:19 AM) ichbin: lol you guys are on a roll.

(02:46:33 AM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/JqqWMQ
(02:46:34 AM) elk_core: Elkarte/master 7ed243a Norv: Fix oops on var access....
(02:46:34 AM) elk_core: Elkarte/master 46ad291 Norv: $settings_not_writable was not initialized. (thank you, Ema!)...
(02:46:34 AM) elk_core: Elkarte/master 9124219 Norv: A $context var wasn't initialized any longer where needed. (thank you Ema!)...
Title: Re: IRC
Post by: TestMonkey on May 21, 2013, 04:39:59 pm
(05:04:42 AM) elk_core: [Elkarte] norv opened pull request #436: A few more leftovers (master...fixes)  http://git.io/9cKX-A
(05:07:02 AM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/WN_YYg
(05:07:02 AM) elk_core: Elkarte/master 6a291c5 Norv: Missed object of action_mailingsend()...
(05:07:02 AM) elk_core: Elkarte/master f0031cf Norv: Missed objects in calls. Small leftover formatting issues....
(05:07:02 AM) elk_core: Elkarte/master d841e81 Norv: Formatting after automate changes :)...

(06:13:10 AM) elk_tools: [tools] norv opened pull request #9: Db updates (master...db_updates)  http://git.io/FjG0wQ
(06:55:50 AM) elk_tools: [tools] norv pushed 4 new commits to master: http://git.io/GzvpAg
(06:55:50 AM) elk_tools: tools/master 9d5f48e Norv: Updates to the db layer....
(06:55:50 AM) elk_tools: tools/master 611c97c Norv: Remove $smcFunc and other adaptations to db layer....
(06:55:50 AM) elk_tools: tools/master 6531e6c Norv: Add db_table()...

(06:57:20 AM) elk_core: [Elkarte] norv opened pull request #437: Db layer updates (3) (master...database3)  http://git.io/9tTEsg
(06:59:42 AM) elk_core: [Elkarte] norv pushed 9 new commits to master: http://git.io/W42yWg
(06:59:42 AM) elk_core: Elkarte/master 8efeb4e Norv: Update install script to db layer...
(06:59:42 AM) elk_core: Elkarte/master 3e5874f Norv: Update upgrade script to db layer...
(06:59:42 AM) elk_core: Elkarte/master f8fdd0b Norv: Use $this reference instead of another set of calls. Remove compatibility for several functions....

(07:01:17 AM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/Wx7GFg
(07:01:17 AM) elk_core: Elkarte/master befeb11 Spuds: ! updates for html5 compliance ... someone else can move this to css if desired....
(07:01:17 AM) elk_core: Elkarte/master 502e881 Spuds: ! menu speed tweak, plus delay was removed from superclick ...
(07:01:17 AM) elk_core: Elkarte/master 1ffcb22 Spuds:  ! Update superfish to 1.7.2...

(03:25:42 PM) Norv: Shouldn't we remove fonts_old?
(03:25:54 PM) emanuele: mmm...
(03:26:08 PM) ***emanuele thinks it would be a good idea...
(03:26:20 PM) Norv: And, morning Ema. Glad you're alive today. :)
(03:27:18 PM) emanuele: Yes!
(03:27:23 PM) ***emanuele too
(03:27:25 PM) emanuele: lol
(03:29:17 PM) emanuele: I still have to start apache and mysql, a bit scared to find everything broken... :P
(03:38:41 PM) Norv: lol
(03:42:34 PM) Norv: They're quite fine, in random manual testing. Oh, I made a bunch of automated changes to tools
(03:43:03 PM) ***Norv doesn't think a few scripts will work at all
(03:58:41 PM) emanuele: lol

(04:24:23 PM) elk_core: [Elkarte] norv opened pull request #438: A few hundred leftover newlines (master...database3)  http://git.io/fLdV2A

(05:18:31 PM) Norv: Looks like we have this too https://github.com/emanuele45/playpen/commit/679a769e7bd36f3daca8cec0f7e5b01ace405eeb
(05:21:40 PM) emanuele: really?
(05:21:46 PM) emanuele: It looks fine here...
(05:22:25 PM) emanuele: I cherry-picked but got an error and when I checked it was correct, I think Spuds or eurich fixed it
(05:24:17 PM) emanuele: https://github.com/emanuele45/Dialogo/commit/42bf39738353f13e341cf5144f3a358a56449483
(05:28:38 PM) Norv: who knows what I was looking at
(05:30:00 PM) emanuele: ROFL
Title: Re: IRC
Post by: TestMonkey on May 28, 2013, 12:35:18 pm
(05:47:47 PM) emanuele: https://github.com/emanuele45/playpen/compare/pm_report
(05:47:50 PM) emanuele: I think I didn't push that to Elk right?
(05:47:59 PM) emanuele: http://www.simplemachines.org/community/index.php?topic=497600.msg3491957#msg3491957
(05:48:23 PM) emanuele: is there any interest?
(05:49:53 PM) Norv: I can't find it in Elk (and I don't remember it)
(05:51:02 PM) Norv: I think it's a cool thing, to try to strenghten this

(05:56:43 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/mlc7aQ
(05:56:44 PM) elk_core: Elkarte/master 8d77db1 Norv: A few hundred leftover newlines. :)...
(05:56:44 PM) elk_core: Elkarte/master d9f6d2d Norv: Merge pull request #438 from norv/database3...

(06:14:38 PM) Norv: sm.org's team page layout is all broken on chromium
(06:18:15 PM) ***emanuele thinks is broken everywhere

(06:25:55 PM) emanuele: oohhh...so github relative time is done with javascript.
(06:41:36 PM) groundup: There is a jQ plugin to do relative time IIRC

(09:39:00 PM) elk_core: [Elkarte] eurich opened pull request #439: css framework (master...cssframework)  http://git.io/IoPvJA

(05/22/2013 12:52:56 AM) Norv: groundup, you may want to take a look at https://github.com/norv/elkarte/compare/elkpr;426
(12:53:37 AM) Norv: (I have rebased to the updated master, after db layer)

(02:37:20 AM) elk_themes: [themes] norv opened pull request #6: Update CurveClassic (master...master)  http://git.io/64MyVw
(02:38:25 AM) elk_themes: [themes] norv pushed 2 new commits to master: http://git.io/dotJBg
(02:38:26 AM) elk_themes: themes/master c590f91 Norv: Add licenses....
(02:38:26 AM) elk_themes: themes/master dec0636 Norv: Merge pull request #5 from norv/licenses...
Title: Re: IRC
Post by: TestMonkey on May 28, 2013, 12:36:40 pm
(02:40:35 AM) elk_themes: [themes] norv pushed 19 new commits to master: http://git.io/NvLG5Q
(02:40:35 AM) elk_themes: themes/master 7ad5b02 Spuds: ! one more area that needed it to be window.elkVersion...
(02:40:35 AM) elk_themes: themes/master a1b1cba Spuds: ! Update the templates to add the option...
(02:40:35 AM) elk_themes: themes/master c9d7bc5 Spuds: ! More things that html5 would not like, mostly width/height on images for this batch...

(02:42:00 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/H65KLw
(02:42:00 AM) elk_core: Elkarte/master 3356395 Norv: Removing CurveClassic from core....
(02:42:00 AM) elk_core: Elkarte/master 9351341 Norv: Merge pull request #421 from norv/classic...

(08:02:11 AM) elk_core: [Elkarte] norv opened pull request #440: Mixed fixes and refactoring (master...cleanups)  http://git.io/ClsWjw

(04:30:51 PM) elk_core: [Elkarte] norv opened pull request #441: Elkpr/426 (master...elkpr/426)  http://git.io/aCiuNQ

(06:58:26 PM) elk_core: [Elkarte] norv opened pull request #443: Bugs (master...bugs)  http://git.io/o6IMUA
(06:59:43 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/iSZrGA
(06:59:43 PM) elk_core: Elkarte/master 9b9f20f Norv: Fix dispatching to default action...
(06:59:43 PM) elk_core: Elkarte/master 0489833 Norv: db_case_sensitive() is a method. Maybe it should be an attribute.....
(06:59:43 PM) elk_core: Elkarte/master 51b7b92 Norv: Merge pull request #443 from norv/bugs...

(07:00:15 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/xpkaMw
(07:00:15 PM) elk_core: Elkarte/master ae7b25e Joshua Dickerson: Add updateAttachmentThumbnail()...
(07:00:15 PM) elk_core: Elkarte/master 94a3506 Joshua Dickerson: Use new $db...
(07:00:15 PM) elk_core: Elkarte/master d2fe602 Joshua Dickerson: Send the id_msg...

(08:39:42 PM) elk_core: [Elkarte] norv pushed 10 new commits to master: http://git.io/J0gvAw
(08:39:42 PM) elk_core: Elkarte/master 86d0062 Norv: Cleanup doc....
(08:39:42 PM) elk_core: Elkarte/master a6cd126 Norv: addMembersToGroups() was not checking protected groups....
(08:39:42 PM) elk_core: Elkarte/master 0a0fc83 Norv: Remove require_once for Logging.php, it's always loaded, even in SSI....

(08:49:20 PM) Trekkie101: How easy is it to include a build number :P?
(09:09:21 PM) Trekkie101: How easy is it to throw build numbers into elk?
(09:09:34 PM) Trekkie101: I cant ever tell what features are now on the site :P
(09:10:02 PM) Norv: Sorry, Trekkie, I meant to, but got into other things
(09:10:18 PM) Trekkie101: :P Just being a total pest

(09:12:40 PM) Norv: ...  https://github.com/elkarte/Elkarte/blob/master/sources/controllers/MessageIndex.controller.php#L39 increment num_posts if you're looking at the board through redirect?

(09:14:18 PM) elk_core: [Elkarte] eurich opened pull request #444: Theme bugs & tweaks (master...theme_bugs)  http://git.io/D7zMjg

(09:14:25 PM) ***Norv keeps finding weird things in the code. Trolling the code ftw, I guess
(09:17:08 PM) emanuele: Same thing, I suppose it's because the number of redirects is stored as num_posts...
(09:17:48 PM) Norv: :(
(09:18:53 PM) emanuele: yeah...I would expect num_views...at least
Title: Re: IRC
Post by: TestMonkey on May 28, 2013, 12:38:16 pm
(09:24:39 PM) Norv: >> (01:23:34 AM) ***emanuele needs recursive chmod and chown
(09:24:39 PM) Norv: Iz there: chmod -R /stuff. Or did you mean something else?
(09:24:54 PM) emanuele: python equivalent
(09:26:50 PM) Norv: Mmm dunno... Whatcha doing in python?
(09:26:53 PM) ***emanuele started looking at a script that downloads from github, extracts, installs and does some testing
(09:27:19 PM) Norv: Cool!
(09:27:32 PM) emanuele: but I know nothing of python except I hate it (but I'm using it because of mechanize
(09:28:21 PM) emanuele: at the moment the script downloads and extracts, now I have to ensure the files are properly chowned and chmodded
(09:31:49 PM) Norv: I'd just go through directories...

(09:28:28 PM) Norv: https://github.com/elkarte/Elkarte/pull/444
(09:29:13 PM) emanuele: interesting use of template_button_strip
(09:29:25 PM) emanuele: nevermind
(09:29:27 PM) emanuele: I'm drunk

(09:32:19 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/IhV-Jg
(09:32:20 PM) elk_core: Elkarte/master 2f74a9b Thorsten Eurich: missing variant images.....
(09:32:20 PM) elk_core: Elkarte/master 02aa7cd Thorsten Eurich: syntax error in index.css...
(09:32:20 PM) elk_core: Elkarte/master 509179a Thorsten Eurich: small tweaks, better smartphone and mobile support....
Title: Re: IRC
Post by: TestMonkey on May 28, 2013, 12:38:42 pm
(10:40:25 PM) groundup: What are your thoughts on using if (ini_get($env) === false) putenv($env . '=' . $setting) ; and then using ini_get for settings?
(10:40:54 PM) groundup: Wait, before you answer, not necessarily for Elkarte but for software in general
(10:41:31 PM) groundup: *ini_set() sorry
(10:43:28 PM) groundup: PRO: you can setup things in based on the environment
(10:58:09 PM) Norv: If I understand correctly, I think it ends up unmaintainable. Better off handling your settings per app.

(05/23/2013 12:02:30 AM) emanuele: https://gist.github.com/emanuele45/5630884
(12:02:54 AM) emanuele: At least it says: ELKARTE Installer :D
(12:04:54 AM) emanuele: Now the funny part begins
(12:10:27 AM) Norv: YAY!
(12:10:57 AM) Norv: Hey this looks like fun! :D
(12:16:10 AM) ***Norv goes back to breaking miscellaneous code. MessageIndex time...
(12:17:49 AM) ***Norv hurries cuz after automated testing I might not be so able to break things...
(12:26:27 AM) emanuele: meh... mechanize documentation is worse than SMF's one...
(12:55:24 AM) emanuele: fingers crossed...
(01:08:21 AM) emanuele: https://gist.github.com/emanuele45/5630884
(01:08:30 AM) emanuele: It installs Elkarte from github!! :D
(01:21:51 AM) emanuele: Norv while installing I always have problems with db_last_error.php that is not present...

(02:20:31 AM) elk_core: [Elkarte] norv opened pull request #445: Misc refactoring (master...cleanups)  http://git.io/CqlL0g

(02:34:13 AM) ***groundup beats Norv like a bad dog
(02:34:32 AM) groundup: (tried to come up with something much better and I am a HUGE animal lover)
(02:35:34 AM) groundup: My dogs were just going crazy for a minute
(02:35:41 AM) groundup: Anyway... the reason I am beating you..
(02:36:34 AM) groundup: I started to *remove* LIMIT 1 on PKs. It only adds an extra bit of parsing. Pretty much negligible but it's still there :P
(02:38:08 AM) groundup: https://github.com/norv/elkarte/commit/92ce1f69b4fd647ec9c9341d6a43047d88b7d492 combine with https://github.com/elkarte/Elkarte/pull/428
Title: Re: IRC
Post by: TestMonkey on May 28, 2013, 12:39:24 pm
(01:19:40 PM) elk_core: [Elkarte] norv pushed 21 new commits to master: http://git.io/wRzcjA
(01:19:40 PM) elk_core: Elkarte/master 04b2cca Norv: Switch permissions to be handled by the maintenance page....
(01:19:41 PM) elk_core: Elkarte/master 1db7a5f Norv: Pedantry....
(01:19:41 PM) elk_core: Elkarte/master 8d6c3ee Norv: Refactor action_credits, use Who.subs....

(03:34:02 PM) elk_core: [Elkarte] norv opened pull request #446: Cleanups (master...cleanups)  http://git.io/VH4KSQ

(03:47:41 PM) Norv: Thanks Ema!
(03:49:13 PM) Norv: I love it how refactoring even small things makes obvious some bug :D
(04:05:40 PM) Norv: https://github.com/elkarte/Elkarte/blob/master/sources/subs/Topic.subs.php#L984 $next ? <  *headscratch*
(04:27:33 PM) ***emanuele is innocent
(04:27:48 PM) emanuele: dunno...if it works is correct, why is correct...well...
(04:40:30 PM) Norv: I don't think it works :D but dunno what mess I did either...gotta check with less changes
(04:51:16 PM) emanuele: arg querystring is broken... lol
(04:53:18 PM) Norv: Now? Or with the PR? What is broken?
(04:53:27 PM) emanuele: the @todo
(04:54:07 PM) Norv: https://github.com/norv/elkarte/commit/8327e9382ff8c6b6c10e9fd4af50e86cda5c68f0#L0L435 ?
(04:54:12 PM) emanuele: BTW it works as in SMF the next/previous
(04:54:27 PM) emanuele: ah okay you fixed it!
(04:54:29 PM) emanuele: :P
(04:54:41 PM) emanuele: I still have to update master
(04:54:52 PM) Norv: Dun scare me with breaking QueryString lol.
(04:55:07 PM) emanuele: :D
(04:55:14 PM) emanuele: :P

(04:55:23 PM) elk_core: [Elkarte] norv pushed 22 new commits to master: http://git.io/R-SryQ
(04:55:23 PM) elk_core: Elkarte/master 069867f emanuele: $smcFunc['htmlspecialchars'] => Util::htmlspecialchars...
(04:55:23 PM) elk_core: Elkarte/master c2c10bf emanuele: $smcFunc['substr'] => Util::substr...
(04:55:23 PM) elk_core: Elkarte/master 8821f3a emanuele: $smcFunc['ucwords'] => Util::ucwords...

(05:05:28 PM) Norv: brb. btw Ema if you feel those templates PRs are ready grab them
(05:07:04 PM) emanuele: I think I'll merge the two first, rebase and then merge...
Title: Re: IRC
Post by: TestMonkey on May 28, 2013, 12:40:19 pm
(07:18:12 PM) emanuele: why every time I push something without test it is broken... lol
(07:18:54 PM) TehCraw: The question is why you push without testing? :P
(07:21:55 PM) emanuele: because testing is useless! :P
(07:22:24 PM) TehCraw: I can understand that it's no fun, but I wouldn't say useless. LOL
(07:23:38 PM) emanuele: Testing is fun! (if it is someone else that does it :P)
(07:25:04 PM) TehCraw: That's what QA is for.
(07:27:50 PM) ***emanuele prefers instruct a computer to do boring things... O:-)
(07:29:03 PM) TehCraw: Don't think you're ever going to be able to instruct a computer to test your code changes, beyond checking for errors. ;)
(07:30:21 PM) emanuele: that's already something :P
(07:30:37 PM) TehCraw: Can't argue with that.
(07:31:05 PM) Norv: Sure you can. Unit testing ftw.
(07:32:30 PM) TehCraw: Well sure, if you want to go the route of continuous integration, but I've never heard of people using unit testing on a functional paradigm.
(07:33:10 PM) TehCraw: I suppose it could be done though.
(07:34:14 PM) TehCraw: I sure as heck don't want to be the one to figure out how to test all of SMF's functions though. Especially the ones that are hundreds of lines long. :P
(07:35:19 PM) ***emanuele is fool enough O:-)
(07:37:02 PM) TehCraw: That would be a feat in itself. If you managed to test all of SMF's functions, you deserve and award for bravery and iron will.
(07:40:48 PM) Norv: Oh, for sure. But we have already - and are reworking this code. We'll get it in shape.
(07:41:53 PM) Norv: Actually parseBBC as long as it is, can be almost done (and has been). It's not that much lenght as it is about the darned side-effects introduced by all the tricks in the world
(07:42:30 PM) Norv: Feel free to take a look and propose further improvements! :) What would you like to see?
(07:44:38 PM) TehCraw: What I would like to see is an OOP base. I can see you're working on that already, so well done. :)
(07:45:24 PM) TehCraw: I thought smCore was a work of art before it died.
(07:47:51 PM) Norv: :)
(07:49:35 PM) TehCraw: Too bad fustrate left. He was good.
(07:49:43 PM) Norv: Nothing lives too long around sm.org. But anyway, if you want to improve this OOP base, feel free to. We don't want all thingies in the world, but the essentials are sort of there (and need help :) )
(07:50:57 PM) TehCraw: I've been pretty busy, but if I find some time, I'll send a few PRs.
(07:58:41 PM) Norv: Don't worry, just play around with it when you're in the mood to. If you have something you want to chip in, please feel free to.

(07:58:33 PM) emanuele: What do you think about splitting Profile.template.php in a couple or three files?...
(07:59:10 PM) ***Norv agrees without looking at the template (I think I remember thinking the same). Shouldn't it "follow" the controller?
(07:59:18 PM) Norv: And there are more of them
(07:59:54 PM) emanuele: think so, at the moment it's the biggest with about 3k lines and 122kb
(08:00:19 PM) emanuele: (almost twice PM template that is the second largest one)
(08:00:53 PM) Norv: LOL there are 6 controllers for profile stuff
(08:01:09 PM) Norv: O:-)
(08:01:16 PM) ***Norv thinks that was me
(08:01:28 PM) emanuele: ...
(08:02:10 PM) Norv: Per profile area

(08:57:25 PM) elk_core: [Elkarte] norv opened pull request #447: Bug fixes (master...cleanups)  http://git.io/siQ4wA
(08:58:20 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/tNJJCg
(08:58:20 PM) elk_core: Elkarte/master 442e7a5 Norv: Fix wrong variable...
(08:58:20 PM) elk_core: Elkarte/master fa920b3 Norv: Pedantry....
(08:58:20 PM) elk_core: Elkarte/master 1377f7b Norv: Fix installer after db layer changes....

(09:30:12 PM) elk_core: [Elkarte] emanuele45 opened pull request #448: Template layers (master...template_layers)  http://git.io/9Lk8-w

(09:40:04 PM) elk_core: [Elkarte] eurich opened pull request #449: Red variant (master...red_variant)  http://git.io/QbIbKg
Title: Re: IRC
Post by: TestMonkey on May 28, 2013, 12:41:19 pm
(01:53:36 AM) emanuele: Norv https://github.com/emanuele45/Dialogo/commit/2cb9209d4de1af044f0ee44b7a427ab48a441112

(09:12:02 AM) elk_core: [Elkarte] norv pushed 7 new commits to master: http://git.io/saVdcQ
(09:12:02 AM) elk_core: Elkarte/master 4114784 Thorsten Eurich: red variant initial commit....
(09:12:02 AM) elk_core: Elkarte/master cb7d7ab Thorsten Eurich: css tweaks.....
(09:12:02 AM) elk_core: Elkarte/master 69c07a6 Thorsten Eurich: Variant support for our advertising logo .....

(09:24:59 AM) elk_core: [Elkarte] norv pushed 22 new commits to master: http://git.io/aH8TaQ
(09:24:59 AM) elk_core: Elkarte/master fb1d18e emanuele: Using alias for messages table make the query more flexible...
(09:24:59 AM) elk_core: Elkarte/master 203bdd3 emanuele: Unused variable...
(09:24:59 AM) elk_core: Elkarte/master 773962a emanuele: Template layers may look good in a class with some priority parameter to better define the order...

(04:30:29 PM) emanuele: Norv, quick question when you have time: https://github.com/SimpleMachines/SMF2.1/blob/master/Sources/Post.php#L2103
(04:30:40 PM) emanuele: do you have any idea why 2 queries and not just one?
(04:31:42 PM) emanuele: (SMF code just because the two queries are on the same page, in Elk we refactored the two queries in two different functions)
(04:31:58 PM) emanuele: If we just grab group_name in the first query should be exactly the same... am I missing anything?
(04:34:33 PM) emanuele: Elk equivalent: https://github.com/elkarte/Elkarte/blob/master/sources/controllers/Announce.controller.php#L77
(04:34:49 PM) emanuele: getGroups and membergroupsById

(04:49:48 PM) elk_core: [Elkarte] emanuele45 opened pull request #450: Reorg function (master...reorg_function)  http://git.io/v3OR4A

(06:57:26 PM) Norv: emanuele, (on the run, sorry) One query seems better indeed. And, hah, getGroups() and membergroupsById() are... interesting. Looks like getGroups() is only used in Announce
(06:58:13 PM) Norv: Personally, I don't mind smaller functions for quick queries, with one-two fields. But this could be argued redundant too
(07:24:22 PM) emanuele: yep, getGroups seems to return a slightly different array (i.e. getGroups addes the regular members), but indeed it may be worth looking into merge the two
(07:25:31 PM) emanuele: On this kind of functions in general, I'm changing my mind every time I wrote one... lol
(07:27:53 PM) emanuele: In the last couple I used the approach to pass "keys" to define alternative query SELECT or WHERE instead of passing multiple arguments, so that the functions seem to be more flexible and reusable (like fetchBoardsInfo or retrieveMemberData), though I'm always unsure when it's the moment to stop... lol
(07:28:33 PM) Norv: lol yes. Well, by the rework we're doing, we're finding out (and stopping at) more uses, and thereby potential for a better solution. Which isn't always to generalize everything either.
(07:31:01 PM) Norv: Things could go towards too much, it's not reusable if modders won't remember/understand what are all parameters and not able to use it well

(07:36:57 PM) elk_core: [Elkarte] eurich opened pull request #451: Theme fixes (master...theme_fixes)  http://git.io/LLmW9w

(07:43:15 PM) emanuele: Well, at the moment I think more of make functions reusable inside the core. :P
(07:44:25 PM) emanuele: Less query FTW! O:-)
(07:45:06 PM) emanuele: 294 instances of $db->query left in /controllers/
(07:54:29 PM) emanuele: 293
Title: Re: IRC
Post by: TestMonkey on May 28, 2013, 12:42:01 pm
(07:56:48 PM) emanuele: https://github.com/emanuele45/Dialogo/blob/master/sources/controllers/Emailuser.controller.php#L436
(07:58:17 PM) emanuele: isn't the m.id_msg = {int:id_msg} enough?
(08:09:10 PM) Norv: Same as we had before, methinks. Extra check that the passed message is in the expected topic. It makes sense here (unlike reporttm()) because we'll act on it.

(08:14:51 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/5XGtSw
(08:14:51 PM) elk_core: Elkarte/master 5c9e15d Thorsten Eurich: let's welcome back the quick buttons.....
(08:14:51 PM) elk_core: Elkarte/master 18574e7 Thorsten Eurich: many, many display template fixes for mobile devices and tablets.....
(08:14:51 PM) elk_core: Elkarte/master 41ab55a Thorsten Eurich: leftover.....

(11:35:31 PM) emanuele: How bad practice is use functions as argument of foreach? O:-)

(08:47:03 AM) elk_net: [elkarte.net] norv pushed 6 new commits to master: http://git.io/h71ZQw
(08:47:03 AM) elk_net: elkarte.net/master 74d9e30 Norv: Update files...
(08:47:03 AM) elk_net: elkarte.net/master 51b33a2 Norv: Updates....
(08:47:03 AM) elk_net: elkarte.net/master 9dac682 Norv: Another update - current dev version....

(08:58:18 AM) elk_core: [Elkarte] norv opened pull request #453: This fixes an issue with $db_persist undefined on step 3 of installer. (master...picks)  http://git.io/yt4k3w
(08:59:00 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/Y3XakQ
(08:59:00 AM) elk_core: Elkarte/master 27cf9d9 Adam Tallon: This fixes an issue with $db_persist undefined on step 3 of installer....
(08:59:00 AM) elk_core: Elkarte/master bc3312e Norv: Merge pull request #453 from norv/picks...

(09:27:41 AM) elk_core: [Elkarte] norv opened pull request #454: CRLF -> LF (master...crlf)  http://git.io/RLP4Tg
Title: Re: IRC
Post by: TestMonkey on May 28, 2013, 12:42:26 pm
(12:09:00 PM) elk_core: [Elkarte] eurich opened pull request #455: Fixes for the red variant (master...fixes_red)  http://git.io/Cn_wMQ
(07:37:56 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/u-POng
(07:37:56 PM) elk_core: Elkarte/master 32b5d91 Thorsten Eurich: make it easier to use custom menu layouts for variants.....
(07:37:56 PM) elk_core: Elkarte/master 8aaf20a Thorsten Eurich: fixes the menu from the red variant...
(07:37:56 PM) elk_core: Elkarte/master b8c170d Norv: Merge pull request #455 from eurich/fixes_red...

(11:14:28 PM) elk_core: [Elkarte] norv opened pull request #456: Cleanups (master...cleanups)  http://git.io/7vvoJA
(11:16:56 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/U5YRTA
(11:16:56 PM) elk_core: Elkarte/master 04e5533 Joshua Dickerson: Commit refactoring of Recent controller using the topicsParticipation() function....
(11:16:56 PM) elk_core: Elkarte/master 91e69f6 Joshua Dickerson: Add topics participation to search controller as well....
(11:16:56 PM) elk_core: Elkarte/master c74bf03 Norv: Update subs functions for more consistency: messagesSince() and countMessagesSince()....

(10:04:54 AM) elk_core: [Elkarte] norv opened pull request #457: Error log fix (master...cleanups)  http://git.io/ibV4sw

(07:42:39 PM) elk_core: [Elkarte] eurich opened pull request #459: Html5 additions (master...html5_additions)  http://git.io/-9glDw
(10:32:27 PM) elk_core: [Elkarte] norv pushed 14 new commits to master: http://git.io/BwcpMQ
(10:32:28 PM) elk_core: Elkarte/master b24e2af Thorsten Eurich: some HTML5 additions for profile and registration...
(10:32:28 PM) elk_core: Elkarte/master 4ae9cd9 Thorsten Eurich: more  HTML5 additions (required attribute) for profile and registration...
(10:32:28 PM) elk_core: Elkarte/master 03971cd Thorsten Eurich: unused global....

(11:48:25 PM) elk_core: [Elkarte] eurich opened pull request #460: Members controller refactoring (master...members_overhaul)  http://git.io/4NE7BA

(03:55:39 PM) elk_core: [Elkarte] norv opened pull request #461: Add jquery_source to install and upgrade. (master...jquery)  http://git.io/M0m_eA
(03:56:40 PM) elk_core [~elk_core@router1-ext.rs.github.com] entered the room.
(03:56:41 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/fGxtFQ
(03:56:41 PM) elk_core: Elkarte/master b4268a6 Norv: Add jquery_source to install and upgrade....
(03:56:41 PM) elk_core: Elkarte/master 7531b66 Norv: Merge pull request #461 from norv/jquery...
(04:08:27 PM) elk_core: [Elkarte] norv pushed 1 new commit to master: http://git.io/06R_DA
(04:08:27 PM) elk_core: Elkarte/master 8d38ed1 Norv: Commit amend fail: add jquery to postgresql....
Title: Re: IRC
Post by: TestMonkey on May 28, 2013, 08:18:04 pm
(09:51:19 PM) elk_core: [Elkarte] norv opened pull request #462: Fixes up (master...fixes_up)  http://git.io/Oi7A6w
(09:57:36 PM) elk_core: Elkarte/master 6108fcd Norv: Missing global in auth....
(09:57:36 PM) elk_core: Elkarte/master 89fa45e Norv: Fix topic notification....
(09:57:36 PM) elk_core: Elkarte/master b7c18ce Norv: Merge pull request #462 from norv/fixes_up...

(10:22:26 PM) emanuele [~chatzilla] entered the room.
(10:25:27 PM) Norv: An emanuele!!
(10:25:30 PM) Norv: Just in time.
(10:26:09 PM) ***emanuele is looking around for who broke the site :P
(10:26:17 PM) Norv: Undefined index: page_index_template
(10:26:56 PM) Norv: I did! Fixing things... And there are several.
(10:27:08 PM) emanuele: lol
(10:27:14 PM) emanuele: we suck at testing!
(10:29:15 PM) emanuele: but locally works...apparently..

(11:06:26 PM) elk_core: [Elkarte] norv opened pull request #465: Fixes up (master...fixes_up)  http://git.io/8d3Q6Q
(11:09:03 PM) elk_core: Elkarte/master 7056e86 Norv: Missed guest links....
(11:09:03 PM) elk_core: Elkarte/master 785e6bc Norv: Pfft....
(11:09:03 PM) elk_core: Elkarte/master 7c31d0b Norv: Merge pull request #465 from norv/fixes_up...
Title: Re: IRC
Post by: TestMonkey on May 29, 2013, 10:45:52 pm
(11:12:07 PM) Norv: Ema, ideas on undefined $first_subject? For getFormMsgSubject()
(11:13:09 PM) emanuele: Are you using master?
(11:13:36 PM) Norv: yes
(11:15:03 PM) emanuele: mmm.... *headscratch* ...it doesn't make much sense, it has a default value...
(11:16:02 PM) Norv: it has a default value in the called function, but it's undefined in the caller
(11:17:27 PM) Norv: So it can be ignored? I did at some point on the site, but now I'm back to restoring hacks to fix the rest.
(11:17:43 PM) emanuele: ahhh...okay, that sounds more easy to debug! :P
(11:24:21 PM) ***emanuele guesses preview of new topics with an error
(11:24:43 PM) emanuele: ahh...directly new topics
(11:25:16 PM) emanuele: I don't like that much that function TBH...
(11:26:04 PM) emanuele: A quick fix would be to simply initialize empty $first_subject just before:
(11:26:08 PM) emanuele:   // Check if it's locked. It isn't locked if no topic is specified.
Title: Re: IRC
Post by: TestMonkey on May 29, 2013, 10:52:25 pm
(11:35:16 PM) elk_core: [Elkarte] eurich opened pull request #466: quick fix for the broken top bar  (master...theme_fixins)  http://git.io/vKClEQ
(11:38:52 PM) elk_core: Elkarte/master 615c8c9 Thorsten Eurich:  with "search_dropdown" enabled the top section bar was broken....

(11:50:32 PM) elk_core: [Elkarte] eurich opened pull request #467: fixes for MessageIndex.subs (master...messageIndex)  http://git.io/aRnLIQ
(11:52:22 PM) elk_core: Elkarte/master 3cbfca0 Thorsten Eurich: - $topics needs to be initialized (undefined index error when board is empty)...

(11:53:52 PM) elk_core: [Elkarte] norv opened pull request #468: Fix required files to SSI. (master...fixes_up)  http://git.io/gzlG-w
(11:54:52 PM) elk_core: Elkarte/master 4c9e5fc Norv: Fix required files to SSI....

(11:55:38 PM) Norv: TE_: I fixed your access, if you want to take a look
(11:59:57 PM) emanuele: Norv, if you start from the quick reply and click "preview" the body remains empty (I think it appears with errors too)
(05/28/2013 12:48:47 AM) Norv: ffs we should log more. And debug mode, log things.
(12:51:11 AM) Norv: I can replicate that locally, Ema. Trying to look at, but I still don't get the session issue. Is it possible a form doesn't send the field? Are layers correctly set up?
(12:53:11 AM) emanuele: the input tag is there just before </form>
(12:53:24 AM) emanuele: (I mean at elk.net)
(12:54:23 AM) emanuele: I can't replicate the session locally...
(12:54:38 AM) emanuele: is there anything in particular I should set up
(12:57:27 AM) Norv: No...
(12:57:53 AM) Norv: Bad moment for db structure backup to be broken too!
(12:58:20 AM) emanuele: xD
(12:59:59 AM) Norv: Ok, so from quick reply I can post, with the same sessionid. From modify/post, I can't. Does js mess with it... wait
(01:00:21 AM) emanuele: drafts?
(01:00:50 AM) emanuele: I can post! lol

(01:05:25 AM) elk_core: [Elkarte] norv opened pull request #469: Fix database backup. (master...fixes_up)  http://git.io/BOJGJQ
(01:05:50 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/IhqUag
(01:05:50 AM) elk_core: Elkarte/master daaacc1 Norv: Fix database backup....
Title: Re: IRC
Post by: TestMonkey on May 29, 2013, 10:55:10 pm
(01:01:20 AM) emanuele: but not modify: Wrong value type sent to the database. Integer expected. (current_topic)

(09:02:01 PM) elk_core: [Elkarte] norv opened pull request #470: Fix post edit issues (master...fixes_up)  http://git.io/Uecu0g
(09:09:03 PM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/_olRIQ
(09:09:03 PM) elk_core: Elkarte/master bbc8bea Norv: Post modify bug: wrong function used to get message data. (and a few other places)....
(09:09:03 PM) elk_core: Elkarte/master c2d5e4f Norv: Try to fix names for these functions... basicMessageInfo() (argh still bad)......
(09:36:55 PM) elk_core: Elkarte/master bcdef22 Norv: Dangling free_result() after the query was reworked....

(09:09:46 PM) Norv: Oy, Ema! You're still Teh winner! :D
(09:11:48 PM) Norv: Quickly: what does messageInfo(), getMessageInfo() and getExistingMessage() ? ROFL...
(09:34:00 PM) emanuele: ...mmm...ehm...NFI
(09:36:20 PM) Norv: https://github.com/norv/elkarte/commit/bbc8bea32d794e1ddbf43216ac32c05a955e77e7
(09:40:18 PM) emanuele: messageInfo seems just a simpler version of getMessageInfo...
(09:50:32 PM) Norv: https://github.com/elkarte/Elkarte/pull/470/files *headscratch*
(09:51:13 PM) Norv: Gief better idea...

(03:21:06 PM) elk_net: [elkarte.net] norv opened pull request #4: Sync (master...sync)  http://git.io/LHNNmQ
(03:58:28 PM) elk_net: [elkarte.net] norv pushed 3 new commits to master: http://git.io/rm4F1A
(03:58:28 PM) elk_net: elkarte.net/master ae51e03 Norv: Site sync. (version on-site)...
(03:58:28 PM) elk_net: elkarte.net/master 9e0aa06 Norv: Remove some debugging stuff. Update /install, for convenience of installation from the site repo....

(10:13:48 PM) elk_core: [Elkarte] eurich opened pull request #473: fixes (master...more_fixes)  http://git.io/hPhhOg
(10:37:54 PM) elk_core: Elkarte/master 0c99660 Thorsten Eurich: wrong global used .....
(10:37:54 PM) elk_core: Elkarte/master 148bb58 Thorsten Eurich: no need to initialize the db...
(10:37:54 PM) elk_core: Elkarte/master 0d14ef9 Thorsten Eurich: uneeded code.....
Title: Re: IRC
Post by: TestMonkey on May 29, 2013, 10:57:56 pm
(10:17:00 PM) emanuele: Norv there is still something broken somewhere...
(10:17:39 PM) emanuele: If I have new messages in bug reports, I see the board marked "not read", but when I enter the topic doesn't have the "new" icon

(10:18:13 PM) emanuele: also: http://www.elkarte.net/index.php?action=unread;board=1.0;children
(10:23:16 PM) emanuele: that last one is my fault again! :D
(10:24:05 PM) emanuele: require_once(SUBSDIR . '/Boards.subs.php');
(10:24:06 PM) emanuele: just before: addChildBoards($boards);
(10:24:08 PM) emanuele: in Recent.controller.php (sorry, I can't commit it at the moment... :-[
(10:32:10 PM) Norv: Fixed

(10:42:42 PM) Norv: http://www.elkarte.net/index.php?action=markasread;sa=all;xml;api this doesn't go to xml apparently...
(10:45:54 PM) emanuele: the xml part should be redundant, though guessing I'd say it's a syntax error somewhere...
(10:46:09 PM) emanuele: Warning</strong>: Invalid argument supplied for foreach() in
(10:46:17 PM) emanuele: themes/default/Xml.template.php
(10:46:49 PM) emanuele: 343
(10:47:19 PM) Norv: Yes, 'xml_data' is not xml
(10:49:16 PM) emanuele: ahhh...mmm...meh...
(10:50:10 PM) emanuele: initially I started thinking to allow multiple buttons in the xml
(10:50:36 PM) emanuele: but then at some point I did something different...dunno if theme-wise or what
(10:50:55 PM) emanuele: do you think make sense to allow return info related to multiple buttons at once?...
(10:51:02 PM) emanuele: I think easy is better for now
(10:51:33 PM) emanuele: change the template to:
(10:51:35 PM) emanuele: http://pastebin.com/04Ad7eu4
(10:52:07 PM) emanuele: and maybe change the <buttons> tag to <button>
Title: Re: IRC
Post by: TestMonkey on May 29, 2013, 11:01:36 pm
(10:54:47 PM) emanuele: Not sure how to deal with that: markBoardsRead is used in MessageIndex.controller but the function does more than is should, in particular it updates log_mark_read
(11:01:11 PM) Norv: and shouldn't it?
(11:02:09 PM) Norv: Actually, I've done this... umm, wait, is this creating a bug? (sorry, trying to do several things at the time)
(11:03:35 PM) emanuele: lol
(11:04:18 PM) emanuele: yes, it creates a bug
(11:04:41 PM) emanuele: when you enter a board the "new" tags disappear even if new topics are there
(11:05:05 PM) Norv: Umm, no, that's expected
(11:05:12 PM) emanuele: ?
(11:05:35 PM) emanuele: it's expected than when you visit ?board=1.0 all the "new" should *not* be there?
(11:05:46 PM) emanuele: that sounds strange to me...
(11:05:48 PM) Norv: No, the board itself
(11:05:59 PM) Norv: The topics are 'new' of course
(11:06:41 PM) emanuele: IFNULL(lt.id_msg, IFNULL(lmr.id_msg, -1)) + 1') . ' AS new_from
(11:07:17 PM) emanuele: if lt.id_msg is null then lmr.id_msg is used and if you update it to the latest message of the board...
(11:07:21 PM) emanuele: the new disappears
(11:10:21 PM) emanuele: (and lt.id_msg is null if the single topic has not been marked as read)
(11:15:30 PM) Norv: You're right... I think this is very broken
(11:17:06 PM) Norv: The thing is... What is it that you mean, when you 'mark board read'?
(11:19:21 PM) emanuele: mark the board read, not the topics in there. :P
(11:19:30 PM) emanuele: lol
(11:19:40 PM) emanuele: in fact it has two interpretations
(11:21:04 PM) emanuele: 1) mark all the topics in a certain board as read
(11:21:30 PM) Norv: I think... that at this time, the function is used with three kinds of expectations, that it updates log_boards, that it updates log_mark_read too (mark the entire board as read and dont bother me with it), and there's also that attempt to clear log_topics
(11:21:31 PM) emanuele: 2) remove the "unread" icon from the board
(11:21:35 PM) Norv: yes
(11:22:05 PM) Norv: That's the problem, and I'd say 3 - at least, it is used with all 3...
(11:22:53 PM) emanuele: well, then maybe three different functions are better in that case... O:-)
(11:23:06 PM) Norv: So if we use a single function for it, lets have markBoardsRead and markBoardsUnread separate, and with each have parameters or functions for those cases
(11:24:36 PM) Norv: like, markBoardRead($id_boards, $include_topics = false, $clear_topics_logs = false)
(11:37:39 PM) Norv: You fix this or I fix it, Ema?
(11:37:52 PM) Norv: MessageIndex and Display I think, were affected
(11:37:56 PM) Norv: (badly)
(11:38:01 PM) ***emanuele is destroying the template_layers class, if you want feel free to! :D
(11:38:06 PM) Norv: k

(11:52:03 PM) Norv: I need the fix for membergroups... the $id_group thing
(11:52:17 PM) emanuele: arg...
(11:52:24 PM) Norv: but I don't dare to merge your PR as it is!
(11:52:35 PM) emanuele: lol
(11:52:30 PM) emanuele: well, you can apply the quick fix in the branch

(12:05:50 AM) elk_core: [Elkarte] norv opened pull request #475: More from site errors. (master...fixes_up)  http://git.io/KTEg8A
(12:55:07 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/zHXOsQ
(12:55:07 AM) elk_core: Elkarte/master 0c4fb3a Norv: Variable was initialized on a conditional branch....
(12:55:07 AM) elk_core: Elkarte/master d02a9d8 emanuele45: Missing file for unread....

(12:32:53 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/scwkJw
(12:32:53 AM) elk_core: Elkarte/master 8d62de0 Norv: Back to LF. Add .gitattributes, to keep eol LF (this may need attention and tweaks)...
(12:32:53 AM) elk_core: Elkarte/master 3cba7e2 Norv: Remove extra .txt...
Title: Re: IRC
Post by: TestMonkey on May 29, 2013, 11:04:31 pm
(12:54:02 AM) elk_core: [Elkarte] norv pushed 57 new commits to master: http://git.io/pNOWOQ
(12:54:02 AM) elk_core: Elkarte/master dcac7a1 Spuds: ! likes permissions...
(12:54:02 AM) elk_core: Elkarte/master d02363e Spuds: ! likes language strings...
(12:54:02 AM) elk_core: Elkarte/master c3357da Spuds: ! likes ACP feature page...

(01:01:25 AM) emanuele: Is Earl still relevant for the avatars?

(01:36:29 AM) elk_core: [Elkarte] norv opened pull request #476: Remove old fonts. (master...old_fonts)  http://git.io/PguK7g

(02:29:28 AM) elk_core: [Elkarte] Spuds opened pull request #477: Yup, removing code ... Me ... really ! (master...LessCode)  http://git.io/JrQsFA
(12:14:39 PM) elk_core: Elkarte/master 4588131 Spuds: ! Its either markdownify or html2md ... right now its html2md...

(10:47:23 AM) groundup: ugh, uploading to AWS. It has got to be the slowest connection I've ever had while working on servers

(07:40:03 PM) elk_core: [Elkarte] eurich opened pull request #478: Code cleaning :) (master...code_cleaning)  http://git.io/pxqmFQ

(08:13:20 PM) elk_net: [elkarte.net] norv opened pull request #5: Quick fixes made on site. (master...fix)  http://git.io/zNVssA
(08:14:05 PM) elk_net: elkarte.net/master 575dca9 Norv: Fix wrong function used...
(08:14:05 PM) elk_net: elkarte.net/master 46a87ae Norv: Variable initialized in the wrong place...
(08:14:05 PM) elk_net: elkarte.net/master 143c799 Norv: Correct name of the db method....

(10:15:48 PM) elk_core: [Elkarte] norv pushed 21 new commits to master: http://git.io/tib3JQ
(10:15:48 PM) elk_core: Elkarte/master e589d2e Thorsten Eurich: var was unused in its scope....
(10:15:48 PM) elk_core: Elkarte/master 91a688d Thorsten Eurich: unused global...
(10:15:48 PM) elk_core: Elkarte/master 87b2cfc Thorsten Eurich: missing docs.....
Title: Re: IRC
Post by: TestMonkey on May 29, 2013, 11:13:35 pm
(05:35:45 PM) emanuele: https://github.com/SimpleMachines/SMF2.1/issues/379
(07:38:57 PM) Norv: Well, can you currently remove first post, and thereby make the second "first"?
(07:39:25 PM) Norv: (I remember we discussed this in the past, but don't remember the outcome lol)
(07:41:02 PM) emanuele: Yep, we discussed about delete the first message and the decision was not to allow it
(07:42:01 PM) Norv: So we took first message as "the topic" in a sense

(07:41:39 PM) Norv: just to note, > or those that are moderators that reply.
(07:41:39 PM) Norv: This quite makes sense to me... The rest seems overkill in more than one sense: I'm not against it, but we might need even more flexibility of code and UI than we have in Elk even. As for SMF2.1...

(07:44:08 PM) emanuele: Yep, though when you try to delete the first message you get the error: no you can't, use "remove topic"
(07:44:19 PM) emanuele: so in a way or another is a bit inconsistent...
(07:44:27 PM) emanuele: overkill is probably true too
(07:44:58 PM) Norv: Oh yes... why doesn't delete message redirect itself to topic removal anyway? (with the clear warning of course)
(07:45:28 PM) emanuele: fail safe?
(07:45:40 PM) Norv: Dunno, Ema, you seem to feel that more flexibility (and breaking limits) between posts and topics would be useful... Me doesn't quite know. When would it be useful? You can already split, then remove...
(07:46:09 PM) Norv: Well, then just hide it from the first post...
(07:46:28 PM) emanuele: Well, I'm not really concerned by delete at that point... :P
(07:48:21 PM) Norv: lol
(07:49:22 PM) Norv: you said it yourself, they're related in a way. If you unapprove first post only, and leave the rest visible, what you do is create a topic from the second...
(07:49:34 PM) ***Norv thinks it's a bigger code change than it may seem
(07:49:42 PM) emanuele: oh...nope
(07:49:48 PM) Norv: No?
(07:50:17 PM) emanuele: if a member post an unapproved topic only the first message is "unapproved", all the answers may or may not be approved
(07:50:42 PM) emanuele: when you unapprove a topic *all* the messages in the topic are marked unapproved
(07:51:13 PM) Norv: A normal user won't see any in both cases.
(07:51:48 PM) emanuele: true, but the OP can view the answer if they are not unapproved
(07:52:17 PM) Norv: Or they belong to moderators: this is probably the issue
(07:54:17 PM) Norv: It's not consistent, sure, that the poster no longer sees mods answers in the the second case. In the first case they would only see mods answers anyway.
(07:56:17 PM) emanuele: Obviously, since mods are anyway the only ones that should be able to post in an unapproved topic
(07:57:44 PM) emanuele: (and the OP)
(07:59:41 PM) Norv: IMO, it makes sense to behave the same way the first case does... That leaves unanswered the question on other posters and their posts (which may exist in the second case)
(08:01:36 PM) Norv: It'd be probably nice to allow the initial poster to see those too (since they did anyway at one point), I just dunno how relevant it is in practical terms.
(08:01:20 PM) emanuele: To have it consistent with the delete, we should have an useless button in the first message that tells "to unapprove do something else" and an "unapprove topic" button the unapprove only the topic (in {db_prefix}topics) and the first message (in {db_prefix}messages)
(08:01:39 PM) Norv: LOL
(08:01:44 PM) Norv: Noez
(08:02:14 PM) Norv: But they should see mods answers, both existing and newer...
(08:02:46 PM) emanuele: then it should do what I said above. ;)
(08:03:10 PM) emanuele: (i.e. it should set the topic as if it was started as unapproved)
(08:04:02 PM) Norv: If you do that, how will be the consequences on the *other* posters and their posts?
(08:04:21 PM) Norv: (Agree anyway)
(08:04:35 PM) emanuele: You mean in terms of post counts?
(08:04:48 PM) emanuele: Or what?
(08:05:25 PM) ***emanuele goes away for a while
(08:05:34 PM) Norv: No, as in: the poster sees them or not (I think it's yes), the other posters see their own messages or not, the other posters can modify/reply to their own messages
Title: Re: IRC
Post by: TestMonkey on May 30, 2013, 12:10:42 am
Just to note. (on the run, sorry, just pasting and re-reading the logs)

(11:12:07 PM) Norv: [...] For getFormMsgSubject()
(11:25:16 PM) emanuele: I don't like that much that function TBH...

Agree. Looks like this one does two things ($editing as param, and $_REQUEST['msg'] used... I'd use something like $id_msg to make the difference, in the vein of others... i.e. formSubject(..., $id_msg = null)

Also, it doesn't do it for other calls for some similar things, such as action_quotefast() (or, not sure, even action_jsmodify?).
And, it uses more of them superglobals.

Just to note, perhaps something to look at, next pass. Also I was doing a rework of action_quotefast() somewhere in a branch, will be back on it.
Title: Re: IRC
Post by: TestMonkey on May 31, 2013, 12:49:25 am
(06:01:14 AM) elk_core: [Elkarte] Spuds opened pull request #479: Minor fix to likes, topic_id is in the array, not a seperate var (master...lf)  http://git.io/tKKOsw
(09:24:35 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/uWEmxw
(09:24:35 AM) elk_core: Elkarte/master bce01e0 Spuds: ! Wrong variable used in the topic like...

(05:37:45 PM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/7jvwKQ
(05:37:46 PM) elk_core: Elkarte/master b101d6e Thorsten Eurich: basic cleaning / methods visibility...
(05:37:46 PM) elk_core: Elkarte/master 022af76 Thorsten Eurich: make sure we use an integer.....
(05:37:46 PM) elk_core: Elkarte/master 8793d66 Thorsten Eurich: moved db query to subs....

(06:49:39 PM) emanuele: The package manager is badly broken too!! :P
(06:56:40 PM) emanuele: Norv: DbTable-mysql.php, function __construct, $db_prefix is undefined, I suppose a global is enough, right?
(07:01:07 PM) Norv: yes
(07:01:15 PM) Norv: but I thought I fixed that...
(07:01:28 PM) ***Norv has lost count in which repo when
(07:02:20 PM) emanuele: lol
(07:03:20 PM) emanuele: there is also a require_once missing and another undefined index error in Packages.php
(07:03:24 PM) emanuele: I'll send a PR later

(07:16:54 PM) emanuele: smf_scripturl
(07:17:00 PM) ***emanuele whistles innocently
(07:17:32 PM) Norv: we haz yet a bunch of js to rename, huh?
(07:18:02 PM) emanuele: yups

(07:33:26 PM) ***emanuele doesn't understand what "stateObj" is in history.pushState...

(09:09:33 PM) elk_core: [Elkarte] eurich opened pull request #480: small fixes (master...theme_fixes)  http://git.io/09LgZQ
Title: Re: IRC
Post by: TestMonkey on May 31, 2013, 01:48:14 am
(09:32:11 PM) ***emanuele downloads WBB
(09:34:47 PM) ***emanuele tries to install WBB
(09:35:31 PM) ***emanuele got an Access forbidden on his own computer... lol
(09:35:48 PM) Norv: It could be interesting. I have countless databases of these proprietary-paid forums software, but never an install lol
(09:35:50 PM) Norv: LOL! They guessed ya! :P
(09:36:27 PM) emanuele: *headscratch*
(09:42:48 PM) emanuele: meh...it doesn't even create the database when installing...
(09:43:23 PM) Norv: Yah, seen that to others... requires you to have it already, right?
(09:43:34 PM) emanuele: yep
(09:43:53 PM) emanuele: 108 tables...not bad...
(09:45:04 PM) emanuele: is it trying to kill my hard-disk?...

(09:57:19 PM) emanuele: strike bbcode doesn't work in the wysiwyg editor (wbb)

(09:58:48 PM) Norv: bulk processing of threads and posts, interesting.

(10:02:15 PM) ***Norv doesn't get this... For a 'forum', I haz a tab for permissions, which says 'enter username or group'. Manually. Erm?
(10:02:32 PM) emanuele: yeah...I skipped that one... lol

(10:05:19 PM) emanuele: do you have any idea of how I'm supposed to reach the admin panel from the forum?
(10:05:34 PM) emanuele: found
(10:05:49 PM) Norv: Mmm... :D
(10:06:21 PM) emanuele: The location of the link doesn't sound logic to me... lol

(10:06:33 PM) Norv: It haz topic tags!
(10:06:39 PM) ***Norv wonders what it does with them
(10:06:58 PM) emanuele: (one of the most useless things in history? :P)
(10:07:20 PM) emanuele: Hey TehCraw you like tags don't you? :P
(10:07:45 PM) TehCraw: Don't even go there right now.
(10:07:53 PM) emanuele: lol
Title: Re: IRC
Post by: TestMonkey on May 31, 2013, 01:50:20 am
(10:11:16 PM) ***Norv wonders what means undone threads
(10:11:55 PM) emanuele: where?
(10:12:06 PM) emanuele: ahhh...
(10:12:08 PM) emanuele: no idea
(10:12:15 PM) emanuele: and how do you delete one?
(10:12:43 PM) emanuele: the reply is nice
(10:13:46 PM) emanuele: okay...so to delete a topic I have first to "mark" everything? ???
(10:14:11 PM) ***Norv haz no clue yet...
(10:14:21 PM) Norv: You're in an advanced stage! LOL
(10:14:45 PM) ***emanuele is just clicking around with the basic stuff
(10:14:47 PM) emanuele: lol
(10:15:41 PM) Norv: I have some errors, probably it affected some stuffs... mmm
(10:18:25 PM) ***emanuele wonders if there is a debug mode that shows queries...

(10:22:11 PM) Norv: > Find threads tagged with “info”
(10:22:19 PM) Norv: Cool

(10:23:25 PM) Norv: Profile 'wall'
(10:23:43 PM) ***Norv starts to understand why the ~120 db tables :P
(10:24:05 PM) emanuele: meh...why FB should rule the interwebz...

(10:25:02 PM) emanuele: found a debug mode, now I have to understand where it is used...

(10:27:42 PM) ***Norv doesnt get the UI... a tabbed 'dashboard' it keeps returning to

(10:28:08 PM) emanuele: Nice all the drag and drops, but how do you swap the order of two smiles on two different pages? :P
(10:28:22 PM) Norv: LOL!

(10:29:19 PM) Norv: Ah, small thing: I think, when you go to profile, you have three tabs, and first time you click on each they're js loaded
(10:29:58 PM) emanuele: yep
(10:30:01 PM) emanuele: they are
(10:30:13 PM) emanuele: like the menus at the top
(10:30:22 PM) emanuele: notifications, moderation and conversation
(10:30:40 PM) emanuele: when you click it loads something through ajax

(10:35:27 PM) Norv: sidebar... drag and drop boxes for it. Not bad as idea, although hmm, I enabled everything and I haz only 3 on dashboard and 1 on 'forum' ...

(10:37:08 PM) ***emanuele stops playing and goes push the template layers changes... O:-)

(10:38:45 PM) emanuele: where?
(10:38:48 PM) emanuele: the sidebar I mean
(10:44:07 PM) emanuele: You mean that page: http://img69.imageshack.us/img69/9393/screen97c.png ?
(10:48:04 PM) Norv: No, in system
(10:48:07 PM) Norv: acp/index.php/Option/54/
(10:48:31 PM) Norv: (you are under Community)
(10:50:10 PM) Norv: Lol... System > Options > Dashboard, on one hand.
(10:50:10 PM) Norv: Community > Dashboard > Configuration, on the other. *headscratch* (is the user supposed to just know the difference?)
(10:53:18 PM) emanuele: ...is there a difference?
(10:54:16 PM) Norv: ...
(10:54:19 PM) Norv: lol
(10:55:42 PM) Norv: (I probably miss how to configure those blocks or something)

(10:54:51 PM) Norv: Hey I am seeing this right! On the forum view, the title of the thread in the listing is linked to first unread!
Title: Re: IRC
Post by: TestMonkey on May 31, 2013, 01:52:53 am
(11:03:00 PM) elk_core: [Elkarte] emanuele45 opened pull request #481: Template layers v2 (master...template_layers_v2)  http://git.io/CNnDVA

(11:26:08 PM) emanuele: Norv, what do you think: http://pastebin.com/KgHdqjbC
(11:27:47 PM) emanuele: It's for https://github.com/elkarte/Elkarte/pull/450
(11:28:39 PM) ***Norv gets a bit dizzy from the infinite recursion :P
(11:29:18 PM) emanuele: there is a 1 letter difference! :D
(11:29:33 PM) Norv: LOL
(11:29:49 PM) Norv: I *think* I like it
(11:29:51 PM) Norv: :D
(11:29:55 PM) emanuele: lol
(11:30:06 PM) ***emanuele comes back when you are *sure* you like it :P
(11:30:11 PM) Norv: haha
(11:37:13 PM) Norv: Seriously, I think it's better than any other option
(11:37:45 PM) Norv: Implementations one near the other, you'd always know what you're dealing with
Title: Re: IRC
Post by: TestMonkey on May 31, 2013, 01:53:52 am
(11:49:24 PM) Norv: IMHO, 450 would be great if rebased: with the first few fixes squashed into the first commit, similar for the funny membergroupby, your friend
(11:50:36 PM) emanuele: :'(
(11:50:38 PM) emanuele: lol
(11:51:54 PM) emanuele: to do it now I'd have to save a branch, reset --hard to remove the merge, rebase, cherry-pick (rebase again to remove the other ooops) ... :'(
(11:52:26 PM) Norv: no cherry
(11:53:15 PM) Norv: I'd try this: another branch from it (for safety of experiment); then, rebase -i master
(11:53:36 PM) emanuele: but I already merged master...
(11:57:14 PM) ***Norv tries

(05/31/2013 12:00:12 AM) emanuele: Did you see the mod I wrote using the layers_v2 branch before elk.net disappeared?
(12:00:47 AM) emanuele: http://imageshack.us/a/img694/2870/screen97w.png
(12:00:51 AM) emanuele: http://imageshack.us/a/img825/7818/screen97h.png
(12:01:28 AM) Norv: Yes, it's very cool!
(12:02:15 AM) Norv: oh, elk must be back, looked like a fluke of slowness here...
(12:02:43 AM) emanuele: opendns is still not happy... :(

(12:03:22 AM) emanuele: BTW I think I'd prefer to test the layers branch just another time because I'm not 100% sure I tested the mod with the very final version...

(12:28:58 AM) Norv: Mmm, pekbac. It works as expected - it includes initially the rest of the merged commits (so twice) but they can be safely commented out.
(12:48:25 AM) elk_core: [Elkarte] norv opened pull request #482: reorg_function (Ema) (master...ema_r)  http://git.io/aiyoKw
(12:49:25 AM) elk_core: [Elkarte] norv pushed 13 new commits to master: http://git.io/3UAxkQ
(12:49:25 AM) elk_core: Elkarte/master 538a273 emanuele: Rework of retrieveMemberData, approveMembers and enforceReactivation to make them more flexible...
(12:49:25 AM) elk_core: Elkarte/master b77feba emanuele: No, this is correct like this, otherwise the last check is broken...
(12:49:25 AM) elk_core: Elkarte/master c51946c emanuele: Fixed topic announcement, added group_name to the query in getGroups and removed the redundant query in Announce_Controller->action_selectgroup...
Title: Re: IRC
Post by: TestMonkey on June 04, 2013, 05:27:58 pm
(04:35:29 AM) elk_core: [Elkarte] Spuds opened pull request #483: Update drafts JS to operate as a editor plugin (master...draftsJS)  http://git.io/EebHeQ

(08:19:16 PM) elk_core: [Elkarte] emanuele45 pushed 8 new commits to master: http://git.io/ruoJ7A
(08:19:16 PM) elk_core: Elkarte/master d9341af emanuele: Revisited the template layers class adding more flexibility and few new methods...
(08:19:16 PM) elk_core: Elkarte/master 92b17f3 emanuele: Small tweaks to the class to improve proprity handling (I hope) and some change on how the class is initialized in some of the files...
(08:19:16 PM) elk_core: Elkarte/master 7eda4da emanuele: Ooops...

(11:03:37 PM) elk_core: [Elkarte] eurich opened pull request #484: blame Ema :P (master...ssi_fixes)  http://git.io/7W0TRA
(11:09:27 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/uG1ipA
(11:09:27 PM) elk_core: Elkarte/master a6c3a98 notebook: blame Ema :P
(11:09:27 PM) elk_core: Elkarte/master f5e1404 Norv: Merge pull request #484 from eurich/ssi_fixes...

(11:58:34 PM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/vHlbHw
(11:58:34 PM) elk_core: Elkarte/master eb1c06e Thorsten Eurich: prevent undefined offset  error
(11:58:34 PM) elk_core: Elkarte/master c17e77b Thorsten Eurich: fixed pagelink styling in admin area
(11:58:34 PM) elk_core: Elkarte/master ecc10e7 Thorsten Eurich: use the new callback function
Title: Re: IRC
Post by: TestMonkey on June 04, 2013, 05:29:30 pm
(11:59:48 PM) Norv: Ema, just curious, have you tried Geany?
(11:59:55 PM) ***Norv #isatroll
(12:00:06 AM) emanuele: yep, don't like it...
(12:01:53 AM) Norv: :D Addicted.
(12:02:40 AM) emanuele: it has weird shortcuts (at least that not I'm used to the ones I use) and it has the "gnome" look&feel that I really dislike... :(
(12:05:00 AM) Norv: lol! Touche. After a long time of using it (occasionally), I just changed some of its shortcuts
(12:05:57 AM) Norv: I can't figure out how could I live without some *nod*
(12:06:05 AM) emanuele: lol
Title: Re: IRC
Post by: TestMonkey on June 04, 2013, 05:29:57 pm
(12:17:55 AM) elk_core: [Elkarte] eurich opened pull request #485: blue variant (master...blue_variant)  http://git.io/Kvo_6A
(12:52:35 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/JtdZow
(12:52:35 AM) elk_core: Elkarte/master 9c3d982 Thorsten Eurich: introducing the blue variant / get rid of SMF's light blue ......
(12:52:35 AM) elk_core: Elkarte/master 1686ef2 Norv: Merge pull request #485 from eurich/blue_variant...

(07:22:03 PM) elk_core: [Elkarte] eurich opened pull request #486: Cleaning controllers (master...various_fixes)  http://git.io/pdKDYA

(09:30:38 PM) elk_core: [Elkarte] eurich opened pull request #487: Templates & Javascript (master...templates)  http://git.io/DCZUJQ

(10:14:57 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/gtvJEA
(10:14:57 PM) elk_core: Elkarte/master d26759a Thorsten Eurich: unused globals.....
(10:14:57 PM) elk_core: Elkarte/master 75aad77 Thorsten Eurich: mostly unused globals and a typo in var name...
(10:14:57 PM) elk_core: Elkarte/master 4e9ebad Thorsten Eurich: cleaning the javascript files....

(11:49:59 PM) elk_core: [Elkarte] eurich opened pull request #488: security related fixes (master...fixes)  http://git.io/fSaErQ

(04:48:01 AM) Norv: (for the log)
(04:48:07 AM) Norv: http://www.simplemachines.org/community/index.php?topic=347688
Title: Re: IRC
Post by: TestMonkey on June 04, 2013, 05:30:21 pm
(08:20:17 PM) groundup: Hmm... a mongodb backed forum. That would be cool.
(08:20:23 PM) ***groundup is using mongo now
(08:25:55 PM) groundup: Maintenance should have its own controller and views. The idea was always that maintenance should be the most basic stuff to tell a user that the forum is in maintenance. However, loading two or three more files isn't a big deal and would allow a lot more functionality to it. Maybe even have another Settings.php file for maintenance
Title: Re: IRC
Post by: TestMonkey on June 04, 2013, 07:02:31 pm
(10:51:52 PM) emanuele: If I read MySQL documentation correctly, we should replace TYPE=HEAP with ENGINE=MEMORY am I right?
(10:56:31 PM) Norv: yes
(10:56:57 PM) Norv: Where do we have TYPE?

(11:24:49 PM) emanuele: Arg...message index doesn't have the pages at the end...
(11:25:13 PM) ***emanuele feels layers are broken somewhere...
(11:25:18 PM) ***emanuele whistles innocently
(11:25:21 PM) Norv: :D
(11:28:29 PM) Norv: http://imgs.xkcd.com/comics/ballmer_peak.png O:-)

(11:02:44 PM) Norv: lol... http://www.simplemachines.org/community/index.php?topic=342638.msg2340978#msg2340978
(11:07:31 PM) Norv: There's an interesting detail there, my gut tells me we want to fix the duplicate names. It has come up right at the first 'splits' TE made
(11:08:38 PM) emanuele: One of the things I would like to do is kill all the template_main
(11:08:58 PM) Norv: yes... We could do that easily, no?
(11:09:15 PM) Norv: I mean, it's just a matter of making sure to specify the subtemplate you want
(11:09:21 PM) emanuele: Yep, I think so.
(11:09:48 PM) ***emanuele was just too lazy and was working on other things... O:-)
(11:14:56 PM) ***Norv sagenods at the lazyness.

(10:50:17 PM) Norv: I'm to get home only tomorrow, and I spent time today re-reading older sm.org topics

(12:34:52 AM) ***emanuele has just finished an endless post (almost like Norv :P) and now goes bed happy
Title: Re: IRC
Post by: TestMonkey on June 04, 2013, 07:08:31 pm
(08:45:59 PM) groundup: Getting rid of all of the template_main() and replacing them with template_$template() would make the files reusable!
(08:48:23 PM) Norv: groundup: at the very least, it will allow these guys, Ema and TE, to split things some more, and perhaps include files for the most used subtemplates. (though I'm not sure how far can that go, including too many templates won't be cool either)
(09:02:02 PM) groundup: The theme should be able to include other template files. Kind of a huge limitation that it doesn't have that ability (since it would conflict)
(09:03:03 PM) groundup: For instance, sharing the post template would be awesome

(10:18:47 PM) emanuele: Make Post.template.php reusable it something I thought about
(10:19:19 PM) emanuele: I think it is already mostly re-usable, you just need to set some predefined indexes in $context
(10:19:33 PM) emanuele: (if that is what you mean ;))
Title: Re: IRC
Post by: TestMonkey on June 04, 2013, 07:12:06 pm
(11:27:24 PM) emanuele: Post.controller.php is still pretty broken... :-S
(11:57:16 PM) Norv: fix, file issues, please?
(12:03:31 AM) ***emanuele is trying, but the code is still a bit...not very linear I think...
(12:15:27 AM) Norv: that's the biggest problem :|
(12:24:25 AM) Norv: Could we split the paths in the code some more, i.e. either in the direction of some action_drafts_save(), action_postreply(), either in the direction of some more prepareCalendarEvent() or so
(12:24:46 AM) Norv: Any would help, because it disentangles the spaghetti. IMHO.
(12:26:00 AM) emanuele: I think the biggest issue are not the "other things", but the several paths the normal action_post and action_post2 have to follow
(12:26:24 AM) emanuele: normal post, quoted reply, preview from quick reply, post error, etc.
(12:26:32 AM) emanuele: including all the mixes
(12:26:36 AM) Norv: That sounds like the first direction...
(12:27:27 AM) Norv: If we start off, even with some duplicate code at the beginning, but all organized for *that* case, action_preview_quickreply() for example, we will still see more benefit...
(12:29:00 AM) Norv: I admit, last I checked and made changes, I was still doing the second (or even less, the move of queries kind-of-stuff)
(12:29:20 AM) Norv: but maybe it's time to take the bull by them horns thingies.
(12:30:30 AM) Norv: (or moose :P)
Title: Re: IRC
Post by: TestMonkey on June 08, 2013, 06:31:15 pm
(12:46:15 AM) ***emanuele tries "like": "sorry this feature is disabled"
(12:51:03 AM) Norv: Ah. Tis a core feature. But, I think that's a bug: shouldn't present 'like' if disabled, obviously.
(12:51:38 AM) emanuele: (or maybe my install is simply broken... O:-))

(01:59:18 AM) elk_core: [Elkarte] emanuele45 opened pull request #491: Few fixes (master...few_fixes)  http://git.io/CAs-fg

(06:57:00 AM) groundup: https://github.com/gnif/SMF2.1/commit/22dd5430dd7b2e8062bfb79c9faa5b7c122da697
(06:57:25 AM) groundup: Elk should do the same, but add methods for error and error number
Title: Re: IRC
Post by: TestMonkey on June 08, 2013, 06:31:32 pm
(01:58:59 PM) elk_core: [Elkarte] norv pushed 11 new commits to master: http://git.io/ts0gdw
(01:58:59 PM) elk_core: Elkarte/master 28d252e Spuds: ! Update/create draft autosaver as sceditor plugin...
(01:58:59 PM) elk_core: Elkarte/master b1a7877 Spuds: ! update / simplify existing draft.js to only support the non editor quick reply...
(01:58:59 PM) elk_core: Elkarte/master 7a13088 Spuds: ! update the functions to use the new plugin...

(01:59:24 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/lEHTwQ
(01:59:24 PM) elk_core: Elkarte/master 5696bc1 emanuele: Undefined variable $first_subject...
(01:59:24 PM) elk_core: Elkarte/master 0ee0eab emanuele: This seems useless......
(01:59:24 PM) elk_core: Elkarte/master 97945aa emanuele: On-the-fly change of css to hide/show (jQuery), should work, not tested...
Title: Re: IRC
Post by: TestMonkey on June 08, 2013, 06:31:57 pm
(06:22:10 PM) groundup: http://www.lornajane.net/posts/2013/php-version-adoption
(06:22:54 PM) groundup: http://w3techs.com/technologies/details/pl-php/5/all

(06:33:49 PM) elk_core: [Elkarte] eurich opened pull request #492: Green variant (master...green_variant)  http://git.io/I0uIfw
(08:32:48 PM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/Q_UPWg
(08:32:48 PM) elk_core: Elkarte/master cacf8f2 Thorsten Eurich: pagelinks style adjustments....
(08:32:49 PM) elk_core: Elkarte/master c6b2f54 Thorsten Eurich: initial commit green variant....
(08:32:49 PM) elk_core: Elkarte/master e4afd44 Thorsten Eurich: more adjustments, give themers some more ideas (webfont for title, moving unread links to a fixed top bar ...)...

(12:02:33 AM) elk_core: [Elkarte] engelnyst opened pull request #494: Code clean-up and refactor (master...fixes)  http://git.io/-ft-tw
(09:01:12 PM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/GD4sDg
(09:01:12 PM) elk_core: Elkarte/master d837292 enyst: Code doc, spelling....
(09:01:13 PM) elk_core: Elkarte/master 34f37d2 enyst: Emailpost controller as a class...
(09:01:13 PM) elk_core: Elkarte/master 6fa7648 enyst: Fix constructor call...
Title: Re: IRC
Post by: TestMonkey on June 08, 2013, 06:32:43 pm
(03:03:08 AM) elk_core: [Elkarte] norv opened pull request #497: Cherrypicks (master...cherrypicks)  http://git.io/0PAhrw
(05:20:09 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/2nTg5g
(05:20:09 PM) elk_core: Elkarte/master f1db8ac ziycon: Fix for quick reply off by default...
(05:20:09 PM) elk_core: Elkarte/master 7e1c9d8 ziycon: Fix for theme files not copied over...
(05:20:09 PM) elk_core: Elkarte/master b0a6549 Norv: Merge pull request #497 from norv/cherrypicks...

(03:06:02 AM) TehCraw: Oh man, I thought somebody said something.
(03:16:23 AM) Norv: lol. Code speaks :P
(03:17:59 AM) TehCraw: Only to people who understand.
(03:18:12 AM) TehCraw: You have to be one with the computer.
Title: Re: IRC
Post by: TestMonkey on June 08, 2013, 06:33:20 pm
(08:39:17 AM) elk_core: [Elkarte] eurich opened pull request #495: theme fixes (master...tfixes)  http://git.io/vlSOiA
(02:32:55 PM) elk_core: Elkarte/master f8de243 Thorsten Eurich: prevent jumping menu items...
(02:32:55 PM) elk_core: Elkarte/master 4806c43 Thorsten Eurich: missing semicolon (syntax error)...
(02:32:55 PM) elk_core: Elkarte/master 9fe344d Norv: Merge pull request #495 from eurich/tfixes...

(02:31:23 PM) elk_core: [Elkarte] emanuele45 opened pull request #498: What about hook the action? (master...hooks_again)  http://git.io/L6cYng
(08:21:21 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/iv2aHg
(08:21:22 PM) elk_core: Elkarte/master 485a96b emanuele: What about hook the action?...

(10:26:04 PM) elk_core: [Elkarte] eurich opened pull request #499: HTML5 additions (master...theme)  http://git.io/MjkbFA

(12:16:16 PM) TimeVortex: Speaking of databases...
(12:16:31 PM) TimeVortex: I noticed you guys are still using the mysql_* functions, as are SMF and Wedge
(12:16:42 PM) TimeVortex: Those functions will be deprecated from PHP 5.5+

(07:19:45 PM) emanuele: Performances question: how bad would be not to have the id_board column in {db_prefix}topics and have to LEFT JOIN another table instead?
(07:22:24 PM) emanuele: (not that I intend to do it for boards, but I'm using something similar for tags and I would understand how bad that approach could be)

(10:34:03 PM) emanuele: Norv, what's your opinion on things like this: http://pastebin.com/Jw1V2ttd
(10:34:12 PM) emanuele: (i.e. static)
Title: Re: IRC
Post by: TestMonkey on June 08, 2013, 06:34:04 pm
(10:07:37 PM) elk_core: [Elkarte] emanuele45 opened pull request #501: Broken query if using hooks (master...quick_fix)  http://git.io/qILIhg

(10:43:19 PM) emanuele: Norv: that's for you becaose I lost a bit track of where things have gone... lol
(10:43:29 PM) emanuele: Fatal error: Call to undefined function action_groupmembers() in /sources/subs/Action.class.php on line 96
(10:44:35 PM) emanuele: Never mind, I think I found it
(06/08/2013 12:30:02 AM) emanuele: It's unbelievable the amount of duplicated code in SMF... xD

(01:23:58 AM) elk_core: [Elkarte] emanuele45 pushed 6 new commits to master: http://git.io/qplh2g
(01:23:58 AM) elk_core: Elkarte/master f0d1f0f emanuele: Broken query if using hooks...
(01:23:58 AM) elk_core: Elkarte/master 2484dbe emanuele: Missing controller from subActions array in membergroups management...
(01:23:58 AM) elk_core: Elkarte/master c0e881a emanuele: Missing require_once...
Title: Re: IRC
Post by: TestMonkey on June 08, 2013, 06:34:21 pm
(12:41:41 AM) elk_core: [Elkarte] Spuds opened pull request #503: Replace shorten_subject (master...shorten)  http://git.io/9rf0jA

(01:18:28 AM) elk_core: [Elkarte] emanuele45 opened pull request #504: A function to render uniformly the "pagesection" (master...template_pagesection)  http://git.io/IHPKbA

(03:12:53 PM) Norv: emanuele: perhaps we can make a single patch with the merge conflicts in TE's various_fixes?
(03:13:16 PM) emanuele: What you mean a single patch?
(03:13:43 PM) Norv: a single commit, a patch/diff with the differences
(03:14:55 PM) emanuele: ahhh....I suppose it's possible, TBH I didn't dig it, I just saw it was not merging and though it was because of my PR, so I went and checked... lol
Title: Re: IRC
Post by: Arantor on June 08, 2013, 08:14:50 pm
https://github.com/gnif/SMF2.1/commit/22dd5430dd7b2e8062bfb79c9faa5b7c122da697

Apart from the horrible formatting, you mean?

EDIT: And a bug. (mysqli_num_fields doesn't exist)

(12:16:16 PM) TimeVortex: Speaking of databases...
(12:16:31 PM) TimeVortex: I noticed you guys are still using the mysql_* functions, as are SMF and Wedge
(12:16:42 PM) TimeVortex: Those functions will be deprecated from PHP 5.5+

Wedge is - but only because I haven't gotten around to changing it. Though now I hear it is being officially deprecated I will fix it.

The big thing I hate about switching to MySQLi is that either things needs to be rewritten for OOP, or they need to be modified because the parameter order for half the procedural functions is a bit different.

EDIT: And now it doesn't, it uses MySQLi.
Title: Re: IRC
Post by: TestMonkey on June 08, 2013, 09:06:19 pm
https://github.com/gnif/SMF2.1/commit/22dd5430dd7b2e8062bfb79c9faa5b7c122da697

Apart from the horrible formatting, you mean?

EDIT: And a bug. (mysqli_num_fields doesn't exist)

How so? http://php.net/manual/en/mysqli-result.field-count.php

TBH I'm glad to see an implementation on mysqli. It should be straightforward to adapt. We'll check out gnif's PR and adapt it.
Title: Re: IRC
Post by: Arantor on June 08, 2013, 09:15:32 pm
That's weird, when I searched the manual, it couldn't find mysqli_num_fields and pointed me instead to http://php.net/manual/en/mysqli.field-count.php

Also note that the usual search (php.net/mysqli-num-fields) certainly doesn't find it. And the man page for mysql_num_fields() does not mention it either but it does explicitly mention mysqli_field_count(). :/
Title: Re: IRC
Post by: TestMonkey on June 10, 2013, 09:37:25 pm
(10:11:28 PM) elk_core: [Elkarte] norv pushed 47 new commits to master: http://git.io/_nYmiQ
(10:11:28 PM) elk_core: Elkarte/master 546350c Thorsten Eurich: remove bold attribute from the active menu button...
(10:11:28 PM) elk_core: Elkarte/master 6ec4c02 Thorsten Eurich: blue variant: replaced the hover color for the sake of better readability...
(10:11:28 PM) elk_core: Elkarte/master 6cd5e88 Thorsten Eurich: cleaning subs.php, please check the todo remarks.....

(11:43:35 PM) elk_core: [Elkarte] norv pushed 11 new commits to master: http://git.io/WwqpPQ
(11:43:35 PM) elk_core: Elkarte/master 0b9d63e Thorsten Eurich: HTML5, use <abbr> instead of deprecated <acronym>...
(11:43:36 PM) elk_core: Elkarte/master 19c990d Thorsten Eurich: HTML5: bye bye teletubbies...
(11:43:36 PM) elk_core: Elkarte/master 3bb0284 Thorsten Eurich: HTML5: let's use the new  <header>, <nav> and <footer> tags....
Title: Re: IRC
Post by: TestMonkey on June 10, 2013, 09:37:44 pm
(11:52:13 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/mDdKAg
(11:52:14 PM) elk_core: Elkarte/master b98a5a5 emanuele: A function to render uniformly the "pagesection" (i.e. page_index + top/bottom buttons + other buttons) across all the templates...
(11:52:14 PM) elk_core: Elkarte/master 9d95946 Norv: Merge pull request #504 from emanuele45/template_pagesection...

(11:54:49 PM) elk_core: [Elkarte] norv pushed 10 new commits to master: http://git.io/-VriOA
(11:54:49 PM) elk_core: Elkarte/master 9c679f1 Spuds: ! remove shorten_subject and use the more general shorten_text in its place....
(11:54:49 PM) elk_core: Elkarte/master 844454c Spuds: ! add $modSettings 'subject_length' and 'draft_subject_length'...
(11:54:49 PM) elk_core: Elkarte/master b901daf Spuds: ! missed that one call, it should be done as cutword...

(11:59:25 PM) ***emanuele runs git pull elk master
(06/09/2013 12:08:46 AM) Norv: :D
(12:09:00 AM) Norv: I saved your commits!
(12:09:30 AM) emanuele: I saw, thanks!
(12:09:43 AM) emanuele: Though I discovered reflog O:-)
(12:09:55 AM) emanuele: That's a pretty cool thing *nods*
Title: Re: IRC
Post by: TestMonkey on June 10, 2013, 09:39:33 pm
(12:11:53 AM) emanuele: Now I have to find a way to make the darn buttons work the way I want (provided I find what way I want them to work) and I think I've done everything I wanted to do to the theme

(01:01:47 AM) emanuele: Norv: that's a good one for you! https://github.com/elkarte/Elkarte/commit/27853128ee2070ba975f2401495e3b324a0fcae6
(01:01:49 AM) emanuele: :P
(01:02:12 AM) ***emanuele wonders why the repo history has been cut when forked...
(01:02:48 AM) emanuele: for reference: https://github.com/SimpleMachines/SMF2.1/commit/43a7e709f2bd121993d5b941b3400cb48f809f87
(01:03:37 AM) emanuele: $birthdayEmails was correct as it was because the two cycles are/were (since I'm going to remove them) just for backward compatibility with 2.0
(01:04:14 AM) emanuele: I introduced $txtBirthdayEmails to have a different variable and be able to keep backward compatibility ;)
(01:09:19 AM) Norv: *headscratch*
(01:09:52 AM) elk_core: [Elkarte] emanuele45 opened pull request #505: Quick fix (master...quick_fix)  http://git.io/1RJL9w
(01:14:26 AM) Norv: Oops, sorry. Mindless c/p be damned.
(01:15:12 AM) emanuele: I don't believe you, you just think you can still win the competition! :P
(01:22:40 AM) Norv: :D
Title: Re: IRC
Post by: TestMonkey on June 10, 2013, 09:42:09 pm
(01:27:32 AM) ***emanuele hates the default avatars
(01:28:28 AM) emanuele: If there is no avatar you are forced to "read" (mostly) the nick, but with a default avatar I tend to look only at the avatar and all the people look the same... >_<

(01:51:59 AM) emanuele: Norv, https://gist.github.com/emanuele45/e95df396adbf7397722a ?

(03:47:18 AM) elk_core: [Elkarte] Spuds opened pull request #506: Mundane tweaks to the formatting (master...formatting)  http://git.io/G0Nr6A
(05:18:37 AM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/BU3iMg
(05:18:38 AM) elk_core: Elkarte/master a307b60 Spuds: ! spacing and formatting...
(05:18:38 AM) elk_core: Elkarte/master 9b8fd76 Spuds: ! spacing and formatting and a couple of excess globals removed...
(05:18:38 AM) elk_core: Elkarte/master 4e95595 Spuds: ! spacing and formatting...
Title: Re: IRC
Post by: TestMonkey on June 10, 2013, 09:42:55 pm
(06:03:19 AM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/64u-2w
(06:03:19 AM) elk_core: Elkarte/master 4792345 emanuele: Undefined variable in shorten_text...
(06:03:19 AM) elk_core: Elkarte/master f4d0de4 emanuele: Removed emails backward compatibility code (recently screwed up anyway)...
(06:03:19 AM) elk_core: Elkarte/master f008072 emanuele: Likes settings are needed for admin search to work...

(02:07:08 PM) elk_core: [Elkarte] emanuele45 opened pull request #507: Quick fix (master...quick_fix)  http://git.io/LJHP5g
(03:15:25 PM) elk_core: [Elkarte] emanuele45 pushed 3 new commits to master: http://git.io/cao2iA
(03:15:25 PM) elk_core: Elkarte/master 38be383 emanuele: Wrong logic in layers class...
(03:15:25 PM) elk_core: Elkarte/master 085de6c emanuele: Missing require_once...
(03:15:25 PM) elk_core: Elkarte/master 3c41ebe emanuele45: Merge pull request #507 from emanuele45/quick_fix...

(04:05:02 PM) elk_core: [Elkarte] Spuds opened pull request #508: Update JQ Plugins (master...jqPlugs)  http://git.io/seAyDw

(04:30:51 PM) elk_core: [Elkarte] emanuele45 opened pull request #509: An easier way to add maintenance tasks? (master...extend_maintenance)  http://git.io/M-Vttw

(04:42:36 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/xis2tw
(04:42:36 PM) elk_core: Elkarte/master 23d9047 Spuds: ! Our version of superfish 1.7.2 was missing an iOS update, this fixes that....
(04:42:36 PM) elk_core: Elkarte/master 15a5bdc Spuds: ! Update the editor and bbcode plugin to 1.4.3...
(04:42:36 PM) elk_core: Elkarte/master 0224ae3 Norv: Merge pull request #508 from Spuds/jqPlugs...
Title: Re: IRC
Post by: TestMonkey on June 10, 2013, 09:48:48 pm
(11:04:14 PM) Norv: http://www.simplemachines.org/community/index.php?topic=495881.msg3558277#msg3558277
(11:16:22 PM) ***emanuele is tempted to post the commit and say "cherry-pick it" :P
(11:16:40 PM) emanuele: But I'm too busy writing mods for Elk! O:-)
(11:22:36 PM) Norv: Cool stuff :)
(11:26:06 PM) emanuele: Yep, writing addons is becoming funny now! :D

(06:26:35 PM) elk_core: [Elkarte] emanuele45 opened pull request #510: Reworked a bit the css loading to fix Ant's report (master...loading_css)  http://git.io/I-ca8g
Title: Re: IRC
Post by: TestMonkey on June 12, 2013, 05:28:13 am
(06:26:35 PM) elk_core: [Elkarte] emanuele45 opened pull request #510: Reworked a bit the css loading to fix Ant's report (master...loading_css)  http://git.io/I-ca8g
(05:05:05 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/9wCIxQ
(05:05:05 AM) elk_core: Elkarte/master 99d2f6d emanuele: Reworked a bit the css loading to fix Ant's report http://www.elkarte.net/index.php?topic=412.0...

(01:26:56 AM) elk_core: [Elkarte] emanuele45 opened pull request #511: Quick fix (master...quick_fix)  http://git.io/tWyySA
(03:38:18 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/v4ZABQ
(03:38:18 AM) elk_core: Elkarte/master 7b9b1ed emanuele: Error changing saving theme settings if "allow member to select theme" was disabled...
(03:38:18 AM) elk_core: Elkarte/master 5fb5a5a emanuele: javascript values could even be zero! :P...

(05:06:23 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/d8a5fw
(05:06:23 AM) elk_core: Elkarte/master 083ad4c emanuele: An easier way to add maintenance tasks?...
(05:06:23 AM) elk_core: Elkarte/master cbc23d4 emanuele: Tries to use a fallback (plain function) if the activity method doesn't extis (i.e. activities added via hooks)...
Title: Re: IRC
Post by: TestMonkey on June 12, 2013, 05:30:31 am
(04:01:12 PM) emanuele: Norv: is theme and look&feel compatibility with SMF *so* important to us?

(06:00:21 PM) groundup: emanuele, what file is that display callback in? Just looking on Github
(06:04:17 PM) emanuele: Display.controller.php is where the query is run
(06:04:26 PM) emanuele: Display.template.php is where the callback is called

(07:56:49 PM) groundup: WTF is with this error message "Deleting just any posts in this board is not allowed."
(07:57:03 PM) groundup: It's confusing English

(05:38:11 AM) elk_core: [Elkarte] norv opened pull request #512: Picks (master...picks)  http://git.io/_df_Ew
(05:38:34 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/XZ8ooQ
(05:38:34 AM) elk_core: Elkarte/master aca3c90 Illori: Moderator Help Issue...
(05:38:34 AM) elk_core: Elkarte/master be4ccba Colin Schoen: Minor language corrections...
Title: Re: IRC
Post by: TestMonkey on June 12, 2013, 05:32:48 am
(04:01:12 PM) emanuele: Norv: is theme and look&feel compatibility with SMF *so* important to us?

Not if you feel differently. IMHO: experiment design.
Title: Re: IRC
Post by: TestMonkey on June 12, 2013, 10:35:11 pm
(09:53:31 PM) emanuele: mmm...
(09:54:04 PM) emanuele: Norv, what do you think about git submodules for addons and themes at github?
(09:54:41 PM) emanuele: I was testing it right now, though they remain basically independent...dunno if it is a nice effect or not
(09:55:03 PM) Norv: sure, we could do that
(09:55:58 PM) emanuele: In fact submodules are just a sort of placeholder if I understand correctly
(09:56:10 PM) emanuele: https://github.com/emanuele45/Elk_addons/tree/master/addons
(09:56:25 PM) emanuele: redirect in case of github

(10:03:27 PM) elk_core: [Elkarte] eurich opened pull request #515: Controllers refactoring (master...controllers)  http://git.io/dg0PEg

(11:22:32 PM) Norv: I think it's very nice, the best way to both keep them separate and referenced in a repo
Title: Re: IRC
Post by: TestMonkey on June 14, 2013, 03:57:26 am
(04:21:29 AM) ***Antechinus like moose
(04:22:43 AM) Antechinus: Btw looks decent in ie8 too
(04:22:45 AM) Antechinus: which is handy
(04:23:08 AM) Antechinus: theme I mean, not moose. Moose good in any browser :P
(04:23:31 AM) Norv: That moose is telling me "fat and stupid", I thought you were joking! I don't think I like it, as logo I mean. I hope Xar's gonna come up with something to take you :P
(04:23:40 AM) Norv: Ah cool
(04:24:07 AM) Antechinus: Hey but Bloc and I both like it
(04:24:13 AM) Antechinus: how often do Bloc and I agree?
(04:24:29 AM) Norv: Wow. Too good point. ROFL!!
(04:24:34 AM) Antechinus: Eliana thought cute and cuddly, not fat and stupid
(04:24:54 AM) Antechinus: which is sort of how I feel about it too
(04:24:59 AM) Antechinus: makes me smile
(04:25:13 AM) Antechinus: anyway not a huge deal
(04:25:40 AM) Norv: Well tbh I kinda don't hate as much after looking at it some more. But hey.
(04:26:15 AM) Antechinus: moose haz mind control
(04:26:20 AM) Antechinus: you will be assimilated :P
(04:26:20 AM) Norv: lol
Title: Re: IRC
Post by: TestMonkey on June 16, 2013, 08:43:31 am
(06/13/2013 12:42:34 AM) emanuele: darn...
(12:43:17 AM) emanuele: I started working on the autosuggest without putting the code in a git repo and now I don't want to add the autosuggest any more and I have to guess where things are... lol
(01:02:29 AM) emanuele: Norv: here it is where I used the new hooks I added the other day http://www.elkarte.net/index.php?topic=423.0
(01:02:31 AM) emanuele: :P
(01:15:45 AM) elk_addons [~elk_addon] entered the room.
(01:15:45 AM) elk_addons: [addons] emanuele45 opened pull request #1: Let's see how submodules work. (master...master)  http://git.io/RW3Y_A
(01:15:45 AM) elk_addons left the room.

(02:12:29 AM) elk_addons: [addons] norv pushed 4 new commits to master: http://git.io/6pNNuA
(02:12:29 AM) elk_addons: addons/master 9a08b84 emanuele: Added tabbed_cats as submodule...
(02:12:29 AM) elk_addons: addons/master a61198a emanuele: Added are_you_human as submodule...
(02:12:29 AM) elk_addons: addons/master 14919b9 emanuele: Added topic_tags as submodule...
Title: Re: IRC
Post by: TestMonkey on June 16, 2013, 10:37:05 am
(11:57:40 AM) elk_core: [Elkarte] norv pushed 15 new commits to master: http://git.io/WTSvVw
(11:57:40 AM) elk_core: Elkarte/master 535022f Thorsten Eurich: help controller: methods visibility...
(11:57:40 AM) elk_core: Elkarte/master 235e3dc Thorsten Eurich: passed get vars should be cleaned.....
(11:57:40 AM) elk_core: Elkarte/master 14385fa Thorsten Eurich: announce controller: methods visibility...

(10:05:37 PM) emanuele: Does anyone know of a reliable XML validator that takes in consideration also the XSD schema?

(04:35:36 AM) elk_core: [Elkarte] Spuds opened pull request #518: Use of validation class for review / feedback ... Do Not Merge (master...validate)  http://git.io/17keeQ

(03:31:06 PM) elk_core: [Elkarte] emanuele45 opened pull request #523: Fix the all button (and a query) (master...fix_all)  http://git.io/p7cLGw
(12:22:32 PM) elk_core: Elkarte/master cd3d1d0 emanuele: Broken query...
(12:22:32 PM) elk_core: Elkarte/master b26d29d emanuele: Moved the "all" link to constructPageIndex and styled the same as the other buttons...
(12:22:32 PM) elk_core: Elkarte/master 778f6a1 emanuele: Fixed (I think) news fader jumping when collapsed Fixes #522...

(06:36:43 PM) elk_core: [Elkarte] emanuele45 opened pull request #524: That should allow to obtain more meaningful error messages...I hope (master...error_backtrace)  http://git.io/wocFfw
(05:50:59 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/TBxBgQ
(05:50:59 AM) elk_core: Elkarte/master 0efdf89 emanuele: That should allow to obtain more meaningful error messages...I hope...
(05:50:59 AM) elk_core: Elkarte/master d3389b9 Norv: Merge pull request #524 from emanuele45/error_backtrace...
Title: Re: IRC
Post by: TestMonkey on June 16, 2013, 10:39:37 am
(05:06:25 AM) elk_core: [Elkarte] Spuds opened pull request #525: Latest theme updates from Ant (master...AntUpdates)  http://git.io/UwXc5w
(12:20:27 PM) elk_core: [Elkarte] norv pushed 13 new commits to master: http://git.io/aRbp0g
(12:20:27 PM) elk_core: Elkarte/master 7847f09 Antechinus: ! remove depreciated reset class from the templates...
(12:20:27 PM) elk_core: Elkarte/master fcbfd55 Antechinus: ! Minor class and layout changes to BoardIndex.template.php...
(12:20:27 PM) elk_core: Elkarte/master 59d1671 Antechinus: ! spacing/formatting...

(08:44:39 AM) elk_core: [Elkarte] norv opened pull request #527: Unit testing (master...unittest)  http://git.io/YC4jPg

(02:30:59 PM) elk_core: [Elkarte] Spuds opened pull request #528: ! Update images in white theme (master...AntUpdates)  http://git.io/UiVUTQ
(02:34:01 PM) elk_core: Elkarte/master 90ff501 Antechinus: ! Update images in white theme ... moose with gass...
(02:34:01 PM) elk_core: Elkarte/master fc20151 Norv: Merge pull request #528 from Spuds/AntUpdates...

(02:53:24 PM) elk_core: [Elkarte] Spuds opened pull request #529: ! Some updates to the calendar template and css (master...AntUpdates)  http://git.io/BCS3yw

(03:32:04 PM) elk_core: [Elkarte] emanuele45 opened pull request #530: Profile attachments (master...profile_attachments)  http://git.io/-rJaKg

(04:29:04 PM) elk_core: [Elkarte] eurich opened pull request #531: Refactoring display controller (master...refactoring_display)  http://git.io/r4WV9A
Title: Re: IRC
Post by: TestMonkey on June 16, 2013, 10:39:59 am
(05:04:57 PM) elk_core: [Elkarte] emanuele45 opened pull request #532: Error log was still showing the wrong file (obviously). Also added a fun... (master...really_fix_backtrace)  http://git.io/ylvj2w
(05:05:32 PM) ***emanuele turned on the IRC client just to see elk_core post something
(05:06:56 PM) elk_core [~elk_core] entered the room.
(05:06:56 PM) elk_core: [Elkarte] emanuele45 pushed 2 new commits to master: http://git.io/AxrtyQ
(05:06:56 PM) elk_core: Elkarte/master 23d8945 emanuele: Error log was still showing the wrong file (obviously). Also added a function to the template layers class to prevent sending out the lower layers in case of errors (should avoid quite a bit of errors in the log)...
(05:06:56 PM) elk_core: Elkarte/master b267d90 emanuele45: Merge pull request #532 from emanuele45/really_fix_backtrace...
(05:06:56 PM) elk_core left the room.
Title: Re: IRC
Post by: TestMonkey on June 16, 2013, 10:41:05 am
(05:09:07 PM) elk_core: [Elkarte] emanuele45 opened pull request #533: Some $smcFunc leftovers (master...fix_all)  http://git.io/Tos9hQ
(05:25:02 PM) emanuele: darn, it's still broken... :'(

(05:47:29 PM) elk_core: [Elkarte] eurich opened pull request #534: Fix for #520 (master...theme_fixes)  http://git.io/3y1QRQ

(06/16/2013 12:09:07 AM) ichbin: Any reason we can't just add another hook for people to override the front page?
(12:09:37 AM) ichbin: Dispatcher.class --- call_integration_hook('integrate_frontpage', array(&$default_action));
(12:21:11 AM) emanuele: well...technically...it's already there...
(12:21:19 AM) emanuele: now that I think about it
(12:21:36 AM) ichbin: apparently I haven't thought about it. lol How is it already there?
(12:23:04 AM) emanuele: ohh....no scratch that...
(12:23:17 AM) ***emanuele should be in the bed at that time
(12:23:19 AM) emanuele: lol
(12:23:57 AM) ichbin: haha, no problem. Glad I didn't miss anything obvious. :D
Title: Re: IRC
Post by: TestMonkey on June 16, 2013, 10:42:29 am
(01:19:02 AM) elk_core: [Elkarte] emanuele45 opened pull request #535: And yet another one... No, backtrace is not nice... :P (master...error_backtrace_again)  http://git.io/G_Yk2A
(03:53:52 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/wgJ4KA
(03:53:52 AM) elk_core: Elkarte/master 85ee266 emanuele: And yet another one... No, backtrace is not nice... :P...
(03:53:52 AM) elk_core: Elkarte/master f6965e6 Norv: Merge pull request #535 from emanuele45/error_backtrace_again...

(03:54:25 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/mZJ3Qg
(03:54:25 AM) elk_core: Elkarte/master 42e3333 emanuele: Some $smcFunc leftovers...
(03:54:25 AM) elk_core: Elkarte/master af5a4b0 Norv: Merge pull request #533 from emanuele45/fix_all...

(03:56:08 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/Srxhwg
(03:56:08 AM) elk_core: Elkarte/master 158c991 Thorsten Eurich: removed the last remain <ul class="reset" ... fixes #520...
(03:56:08 AM) elk_core: Elkarte/master a339ae3 Norv: Merge pull request #534 from eurich/theme_fixes...
Title: Re: IRC
Post by: TestMonkey on June 16, 2013, 11:00:04 am
(06:33:18 AM) Norv: > (12:09:37 AM) ichbin: Dispatcher.class --- call_integration_hook('integrate_frontpage', array(&$default_action));
(06:33:18 AM) Norv: I removed it during dispatcher coding, and I didn't add it back. Add it :)
(06:37:29 AM) Norv: It'll have a behavior which IMO is buggy: I think it'll call all hooks added by more than one addon, when only the last added will/should be executed. But that's on the todo list for hooks refactoring.
(06:40:22 AM) ichbin: Hiya Norv!
(06:40:48 AM) ichbin: Sorry was afk there for a minute. No problems. Didn't know you had added that at one point. But, I'll go ahead and add that in and send a PR.
(06:47:19 AM) Norv: Thank you! You need it for the homepage and tinyportal, I guess. :)
(06:49:10 AM) ichbin: Yep, have been pondering about coding some portal stuff for elkarte. Not sure if I want to start over though. lol
(06:54:45 AM) Norv: Afaik you wanted to revamp tinyportal code. Dunno, for what I saw it'd be much better anyway to revamp it on elk code. It should be far less work too
(07:04:09 AM) Norv: Making it *easy* for addons/themes is an essential goal, and we've been trying (specially for addons) to make the code seamless to add to
(07:07:06 AM) ichbin: Thank you. I wish I could spend more time helping and learning. It looks like my last commit did not have the sign-off in it. Did I mess that up?

(06:55:55 AM) elk_core: [Elkarte] IchBin opened pull request #537: Adding hook for mod to set its own front page. (master...master)  http://git.io/L9Prgg
(07:00:37 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/RAIO3w
(07:00:37 AM) elk_core: Elkarte/master ca9d04c ichbin: Adding hook option for a mod to set the default front page.

(07:20:03 AM) Norv: Indeed, it didn't
(07:20:31 AM) Norv: Not sure what you use as git client, just about every one of them should have a way to set sign-off

(07:34:02 AM) elk_core: [Elkarte] IchBin pushed 3 new commits to master: http://git.io/6tih0w
(07:34:02 AM) elk_core: Elkarte/master 8decff8 ichbin: Adding hook option for a mod to set the default front page....
(07:34:02 AM) elk_core: Elkarte/master 409330e ichbin: Merge branch 'master' of https://github.com/IchBin/Elkarte
(07:34:02 AM) elk_core: Elkarte/master e387df4 ichbin: Merge branch 'master' of https://github.com/elkarte/Elkarte

(07:36:00 AM) ichbin: hmm... not sure why it's not picking it up. I updated my commit in my repo. Have been using the Git Gui. Must not have selected the sign-off option. Hope I just didn't screw something up. It seemed to have merged nothing...
(07:38:33 AM) ichbin: Ah looks like my sign-off made it in. But there are a couple of merges that seemed to have done nothing. Sorry for any confusion....
(08:33:06 AM) Norv: Argh... wait

(08:44:03 AM) elk_core: [Elkarte] IchBin opened pull request #538: Small syntax fix (master...master)  http://git.io/OC0FxA

(08:45:04 AM) Norv: you really didn't need to try to fix this in elk master. Now the state of the history is worse IMO, because it has useless merges and repeated commits. But I won't reset it, it'd be yet worse lol

(08:46:13 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/Gn46QA
(08:46:13 AM) elk_core: Elkarte/master 4d8201f ichbin: Fixed some syntax with one too many parentheses....
(08:46:13 AM) elk_core: Elkarte/master e03fe11 Norv: Merge pull request #538 from IchBin/master...

(08:47:31 AM) Norv: My suggestion is to create new branches, for any issue you'd like to PR in. Never commit on your master branch, simply, will save a lot of headaches :)
(08:47:42 AM) ichbin: Sorry. When I was using the GUI and I amended my last commit, it automatically asked me to commit to elk master. I didn't know of any other way to fix it. Next time I'll ask for some help if I get something like that.
(08:48:29 AM) ichbin: ok, I'll just create a bugfixes branch and use that.
(08:48:53 AM) ichbin: oh hey, I already have one. I forgot it's been so long... lol
(08:56:00 AM) Norv: Yes, that's what it did. It was already pulled in elk master, that made it a problem. In elk master, we shouldn't amend commits (not even commit directly (only merge PRs)). Amending elk master means overwriting what is already published, its history, what we others may have already pulled in our repos, that's asking for a lot of trouble. :)
(08:56:58 AM) Norv: On our own branches, we do amending or forcing commits, but definitely not in elk master.
(08:57:42 AM) ichbin: So elk will never get the amended commit then?
(08:58:42 AM) ichbin: Seems you should want an amended commit, in particular for a sign-off.
(09:00:07 AM) Norv: Well now it did. It would've been better if we just let it be. No, the issue is, I should've noticed it's not signed-off and not merge it in the first place. After I merged it, it's better not amended (after all, it was a line of code).
(09:00:52 AM) ichbin: haha, true. Learned my lesson. I won't commit anymore in Elk.
(09:00:53 AM) ichbin: :P
(09:03:19 AM) Norv: I don't know if we will ever have a (seemingly) problem (i.e. a big commit not signed-off), you'd better slap me to pay more attention before merge! Hey, more eyes on PRs should catch it in just about all cases
(09:04:37 AM) Norv: Then again, lack of sign-off on commits from people I know they'd sign-off the *license* is not an "issue" at all. (only a procedure). The license is guaranteed either way.
(09:05:08 AM) Norv: Hehe!
(09:06:01 AM) Norv: (And I'd sign off it in a release. So there.)
(09:09:37 AM) ichbin: haha, good.
Title: Re: IRC
Post by: TestMonkey on June 17, 2013, 04:14:18 pm
(05:14:10 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/_UtBpg
(05:14:11 PM) elk_core: Elkarte/master 181bb89 Norv: Add SimpleTest unit test framework....
(05:14:11 PM) elk_core: Elkarte/master ea46150 Norv: Add tests, for each of the forum components....
(05:14:49 PM) emanuele: We have unit testing! :D
(05:14:59 PM) emanuele: And now we need someone to write tests! :P
(05:26:28 PM) ***Norv innocently volunteers emanuele. Hey, have you seen the web tester?
(05:28:23 PM) Norv: Nah. Everyone writes tests. As we can, anyway. The start may be slightly more difficult, given our codebase and all. *nods*
Title: Re: IRC
Post by: TestMonkey on June 17, 2013, 04:14:44 pm
(10:41:59 AM) elk_core: [Elkarte] norv opened pull request #542: escape_wildcard_string() fix wasn't committed. (master...db_fix)  http://git.io/AcwPPw
(10:47:31 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/VzOI1g
(10:47:31 AM) elk_core: Elkarte/master 1684a34 Norv: escape_wildcard_string() fix wasn't committed....

(01:01:40 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/6Hzn6w
(01:01:40 PM) elk_core: Elkarte/master 8f6e1e0 Antechinus: ! Some updates to the calendar template and css...
(01:01:40 PM) elk_core: Elkarte/master 8ea396b Antechinus: ! scope=col is needed, putting it back...
(01:01:40 PM) elk_core: Elkarte/master 8d27ea1 Norv: Merge pull request #529 from Spuds/AntUpdates...
Title: Re: IRC
Post by: TestMonkey on June 17, 2013, 04:15:15 pm
(01:20:30 PM) elk_net: [elkarte.net] norv opened pull request #7: Update to 2013-06-17 (master...update)  http://git.io/zbV7Cw
(01:20:58 PM) elk_net: [elkarte.net] norv pushed 3 new commits to master: http://git.io/_T_ymw
(01:20:58 PM) elk_net: elkarte.net/master 7ae77f4 Norv: Update (2013-06-17)...
(01:20:58 PM) elk_net: elkarte.net/master 45118f7 Norv: Fix for db method call....

(03:08:23 PM) elk_core: [Elkarte] norv opened pull request #544: Likes subs fix (master...like_db)  http://git.io/0GxhbQ
(03:08:54 PM) elk_core: Elkarte/master f09d02b Norv: Wrong column name in likes subs....

(03:10:03 PM) elk_core: [Elkarte] Spuds opened pull request #545: A few small issues fixed, see commits (master...fixins)  http://git.io/wauwtg

(03:45:44 PM) elk_core: [Elkarte] norv opened pull request #546: Microformats tweaks (master...microformats_tweaks)  http://git.io/zQftfw
(04:00:05 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/Yg8lcg
(04:00:05 PM) elk_core: Elkarte/master e52a2a4 Norv: Document webslices....
(04:00:05 PM) elk_core: Elkarte/master 06b003f Norv: Remove smf format of feed (it was rdf anyway)...
Title: Re: IRC
Post by: TestMonkey on June 17, 2013, 04:16:18 pm
(04:35:11 PM) Norv: emanuele ... how come this isn't merged...? https://github.com/elkarte/Elkarte/pull/530
(04:36:02 PM) ***Norv is growing old. Stupid question: have you made two on this issue, or am I crazy, because I thought I took it in...
(04:36:10 PM) emanuele: mmm
(04:36:15 PM) emanuele: good question...
(04:36:18 PM) Norv: lol
(04:36:27 PM) emanuele: I had a moment I found some duplicated commits here and there...
(04:37:36 PM) ***emanuele does a pull and checks
(04:37:56 PM) emanuele: nope, it's not there in the code
(04:38:29 PM) emanuele: BTW I didn't know the template_TEMPLATE_init functions! :D
(04:38:34 PM) elk_core [~elk_core] entered the room.
(04:38:34 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/TT48ug
(04:38:34 PM) elk_core: Elkarte/master 60f13c6 emanuele: Show links in the profile table show attachments - Thanks Ant for...
(04:38:34 PM) elk_core: Elkarte/master 72ec024 emanuele: Allow themes to load a certain number of attachments in the profile page...
(04:38:34 PM) elk_core: Elkarte/master 393df62 Norv: Merge pull request #530 from emanuele45/profile_attachments...
(04:38:34 PM) elk_core left the room.
(04:39:55 PM) Norv: Lets do it then... I had a couple problems lately with merges, to not overwrite stuff.

(04:51:04 PM) elk_core: [Elkarte] norv opened pull request #547: Small fixes (PR 545) (master...s_fixes)  http://git.io/ndOz9Q
(04:51:34 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/Og5oQw
(04:51:34 PM) elk_core: Elkarte/master cbee379 Spuds: ! This one is a class now, let the dispacher do its thing...
(04:51:34 PM) elk_core: Elkarte/master 49961ef Spuds: ! old check from before moving the query to subs...
(04:51:34 PM) elk_core: Elkarte/master 641134a Spuds: ! missed the _tolist pm pbe template...
Title: Re: IRC
Post by: TestMonkey on June 17, 2013, 04:47:31 pm
(05:45:13 PM) elk_net: [elkarte.net] norv opened pull request #8: A few more updates as made on site (master...more_updates)  http://git.io/4Vj6Pw
(05:45:41 PM) elk_net: [elkarte.net] norv pushed 3 new commits to master: http://git.io/iTA7wA
(05:45:41 PM) elk_net: elkarte.net/master ac734cf Norv: Logo, icons, and calendar updates on site....
(05:45:41 PM) elk_net: elkarte.net/master 268875e Norv: Add logo to _white and _green....
(05:45:41 PM) elk_net: elkarte.net/master 5896930 Norv: Merge pull request #8 from norv/more_updates...
Title: Re: IRC
Post by: TestMonkey on June 19, 2013, 11:17:40 am
(10:55:58 PM) emanuele: Norv there is still some issues with the "new" next to the topics
(10:58:18 PM) Norv: On site?
(11:20:52 PM) emanuele: yep
(11:21:36 PM) emanuele: I noticed the most recent topic I think
(06/18/2013 01:28:00 AM) ***emanuele can't see the "like" button...
(01:28:13 AM) ***emanuele thinks Norv doesn't want to allow me like things...

(05:19:07 PM) Trekkie101_Away: Hey Norv :D
(05:36:14 PM) Trekkie101: Is the calendar up for any sort of revamp, does anyone use it?
(05:37:45 PM) Norv: Internal revamp, yes (without much insistence). External - user visible features - no
(05:38:06 PM) Trekkie101: Might I suggest a tiny improvement?
(05:38:21 PM) Trekkie101: Ill even try and code it myself :P
(05:39:07 PM) Trekkie101: Turn on posting events by default to registered users, currently I think it's admins only
(05:39:25 PM) Norv: Really? Sure
(05:40:04 PM) Trekkie101: I just never see it being used
(05:40:10 PM) Trekkie101: Well, properly :P
(05:41:03 PM) Norv: Quite. Well, it can't become a must-do, imo, but like many others it's seeing work with the code to make it easier to change/add stuff by mods or us, in the future

(09:54:00 PM) elk_core: [Elkarte] emanuele45 opened pull request #549: Ajax improved (master...ajax_improved)  http://git.io/RQhkBw

(02:24:46 AM) elk_core: [Elkarte] emanuele45 opened pull request #553: Removed db backup (master...remove_db_backup)  http://git.io/qsMY8A

(10:28:40 AM) elk_core: [Elkarte] norv opened pull request #555: Language strings tweaks (master...various)  http://git.io/aCJY_w
(10:31:42 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/U9X-rw
(10:31:42 AM) elk_core: Elkarte/master 98394d9 Norv: Tweaked a couple of error messages....
(10:31:42 AM) elk_core: Elkarte/master 28704dc Norv: Language strings fixes. Theme uninstallation should speak...
Title: Re: IRC
Post by: TestMonkey on June 19, 2013, 11:17:54 am
(11:59:06 AM) elk_core: [Elkarte] emanuele45 opened pull request #556: Dir capitalization (master...dir_capitaliz)  http://git.io/Y9XmwA
(12:08:27 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/Mw6YxA
(12:08:27 PM) elk_core: Elkarte/master 2ac096d emanuele: Sources to sources...
(12:08:27 PM) elk_core: Elkarte/master 7300c46 emanuele: Packages to packages...

(12:06:59 PM) elk_core: [Elkarte] norv opened pull request #557: Refactoring display (TE) (master...te_refactoring_display2)  http://git.io/CmJ8PQ
(12:12:25 PM) elk_core: [Elkarte] norv pushed 17 new commits to master: http://git.io/N4lsZg
(12:12:25 PM) elk_core: Elkarte/master 8916c83 Thorsten Eurich: methods visibility...
(12:12:25 PM) elk_core: Elkarte/master 273f4d5 Thorsten Eurich: db query to subs...
(12:12:25 PM) elk_core: Elkarte/master ea25f51 Thorsten Eurich: again, db query to subs...
Title: Re: IRC
Post by: TestMonkey on June 20, 2013, 07:29:35 pm
(02:30:25 PM) ***Dragooon has never used kate
(02:31:19 PM) ***emanuele didn't know what to use the first time he used linux and now he is used to it...
(02:31:53 PM) Dragooon: I don't remember what I used to use when I was on Linux
(02:31:59 PM) Dragooon: I remember using Zend Studio for a while
(02:32:41 PM) emanuele: I don't like IDEs...it becomes too difficult to write bugs

(02:38:56 PM) Dragooon: What did I miss?
(02:39:20 PM) emanuele: That I like write bugz! :D
(02:39:27 PM) emanuele: :P
(03:05:47 PM) Dragooon_: You like bugs eh?
(03:05:56 PM) Dragooon_: You're like me. I write more bugs than features
(03:06:04 PM) Dragooon_: Just see Wedge's discussions for example :P
Title: Re: IRC
Post by: TestMonkey on June 20, 2013, 07:31:53 pm
(04:09:14 PM) elk_core: [Elkarte] Spuds opened pull request #558: Theme Updates II (master...AntUpdatesII)  http://git.io/GI_6uA

(04:16:48 PM) Norv: emanuele antispam questions mess things up :D
(04:17:15 PM) emanuele: I read TE's message, but I the site works for me...
(04:20:12 PM) Norv: I removed them from the site, lol oops.
(04:20:51 PM) Norv: you haz admin account
(04:21:15 PM) Norv: <-- busy breaking everything even with tests
(04:23:01 PM) emanuele: When did you remove them?
(04:23:20 PM) emanuele: ohhh... nevermind
(04:23:38 PM) ***emanuele tested it when he was still sleepy
Title: Re: IRC
Post by: TestMonkey on June 20, 2013, 07:37:19 pm
(03:13:47 PM) The topic for #elkarte is: This is ElkArte so very official channel. Please note: the channel is public and may be logged and archived publicly at any time.

(04:28:10 PM) Norv: Come on, Ema, please don't worry about bs. Or well, it's hard to ignore since you're in the middle of it, but seriously.
(04:30:59 PM) emanuele: the backup thing?
(04:31:02 PM) Norv: Yeah.
(04:31:34 PM) emanuele: ohh... it was asked so many times that I thought it was easier to just drop it, maybe it's better :P
(04:31:54 PM) emanuele: and since it was easy I sent it to Elk too just in case
(04:32:25 PM) emanuele: you were too shy to tell me it is useless O:-)
(04:34:15 PM) Norv: It does just what we settled for, iirc after a public thread. I've tested it back a while ago, and it was working with quite a big db. I think the warnings will be helpful, too. You don't get awards for this one ;)
Title: Re: IRC
Post by: TestMonkey on June 20, 2013, 07:38:07 pm
(05:41:25 PM) emanuele: So, I was thinking...
(05:41:29 PM) emanuele: (and that's bad)
(05:42:25 PM) emanuele: ...in most of the cases there is an error (for example with Tokens) Elk shows a nice "back" button with a js attached that moves the browser back of one page in the history
(05:43:02 PM) emanuele: now, with tokens that's completely useless and even counterproductive
(05:43:13 PM) Norv: Yes
(05:43:20 PM) emanuele: what could we do instead?
(05:43:52 PM) Norv: Nice button 'Re-try', which reloads the page?
(05:44:51 PM) Norv: It'd be the simplest thing
(05:44:52 PM) emanuele: Serving again the same page with the new values ready for a "save" seems a bit tricky (it may lead to situations where you are directed to the local forum from an external page and tricked to click the save and apply the new settings without thinking)
(05:45:04 PM) Norv: Hmm.
(05:45:27 PM) Norv: We have such cases (admin login)
(05:45:43 PM) emanuele: mmm...nope (at least not anymore)
(05:45:59 PM) emanuele: if the POSTed page comes from a different domain is stopped
(05:46:03 PM) Norv: No? I thought it saved after logging in
(05:46:04 PM) emanuele: by checkSession
(05:46:08 PM) Norv: Of course, of course
(05:46:37 PM) Norv: I meant, such cases where you save after admin was required to login, values ready in session
(05:47:16 PM) emanuele: I tried the adminLogin once, but after the issue with checkSession last year I removed the code because I was not entirely sure it was the proper way to go
(05:48:31 PM) Norv: Why don't we load the page, as it is, with values, and add an error box?
(05:48:49 PM) Norv: Instead of this page for error message alone with a 'back' button.
(05:49:11 PM) Norv: (just brainstorming; coffee coming up)
(05:49:14 PM) emanuele: with the current values stored in the database?
(05:49:31 PM) Norv: With the values the user was trying to save
(05:50:50 PM) Norv: I mean, why do we make an error page at all?
Title: Re: IRC
Post by: TestMonkey on June 20, 2013, 07:39:13 pm
(05:58:23 PM) Norv: argh personal messages and profile
(05:58:37 PM) ***Norv is trying to disentangle bits of code.
(05:58:52 PM) Norv: And they entangle my brainz instead. :P
(06:13:57 PM) Norv: > Sorry, we can't let you access this section. We can't even tell you if it exists. You're welcome to visit the main page and choose your way from there.
(06:13:57 PM) Norv: :D
(06:16:09 PM) emanuele: lol
(06:16:19 PM) emanuele: yes, the profile is a bit...complex lol
Title: Re: IRC
Post by: TestMonkey on June 20, 2013, 07:39:50 pm
(08:44:03 PM) emanuele: Merge doesn't work... xD
(08:55:21 PM) Norv: Just tested on local, it worked for me
(08:55:35 PM) Norv: what error
(08:57:31 PM) emanuele: it was on the site
(08:57:41 PM) emanuele: I merged via ID
(09:01:26 PM) emanuele: The board you specified doesn't exist
(09:02:40 PM) emanuele: mmm...someone may have fixed it in the meantime
(09:08:23 PM) emanuele: arg...regular members are missing from the board configuration page for me
(09:16:45 PM) emanuele: AHA!
(09:16:51 PM) emanuele: I can replicate it!
(09:17:03 PM) emanuele: global mod and more than one board

(09:18:28 PM) elk_core: [Elkarte] norv opened pull request #559: Misc refactoring (master...unittest)  http://git.io/q54UIA

(09:41:24 PM) Norv: yes I can replicate that.

(11:38:51 PM) elk_core: [Elkarte] emanuele45 opened pull request #560: Fix for topics merging (master...merge_fix)  http://git.io/BSNDzw

(12:13:37 AM) emanuele: Norv I can't reproduce the registration issue...
(12:24:35 AM) emanuele: unless...
(01:40:42 AM) Norv: "Works" for two registration questions. Seems to affect also sending a PM under default settings...
(01:42:58 AM) Norv: You're too fast for me...
(01:45:53 AM) emanuele: I think I found something
(01:46:23 AM) emanuele: it seems to be an issue with the session...
(01:46:38 AM) emanuele: or the "cache"...
(01:46:57 AM) emanuele: or a wrong >= that should be <=
(01:47:49 AM) emanuele: https://github.com/emanuele45/Dialogo/commit/e78f2e80394f0e47547101f57b55a810fcda3a5d
(02:13:34 AM) Norv: Fun typos!
(02:15:24 AM) Norv: You know, this class should be a good target for unit tests
Title: Re: IRC
Post by: TestMonkey on June 20, 2013, 07:40:17 pm
(05:04:22 AM) groundup: http://www.iheavy.com/2013/06/19/3-ways-to-optimize-for-paging-in-mysql/

(12:09:08 PM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/Me-4Ug
(12:09:08 PM) elk_core: Elkarte/master 32de438 Antechinus: ! Updates to Display.template.php, mainly aimed at improving the menu / list structures...
(12:09:08 PM) elk_core: Elkarte/master 342b092 Antechinus: ! Add class names for each level of menu...
(12:09:08 PM) elk_core: Elkarte/master 8ea562b Antechinus: ! Add in new class levels for list drops.  Remove extra divs...
Title: Re: IRC
Post by: TestMonkey on June 20, 2013, 07:41:16 pm
(06:01:44 PM) ***emanuele adds some hooks to the postmoderation functions (approvePosts and approveTopics)

(07:19:00 PM) Norv: emanuele: do we take topic merging then?
(07:20:56 PM) Norv: approveTopics runs away from you. :P https://github.com/norv/elkarte/commit/34029b43f7be06576985ef280fbe46f801832d86#L4R1864
(07:30:40 PM) emanuele: Did you already push the array_intersect thing?
(07:30:49 PM) emanuele: Darn...then I wait :P
(07:31:47 PM) emanuele: I saw a PR and merged it, but I didn't check exactly what was in there... O:-)
(07:40:20 PM) Norv: No, no array_intersect. It's somewhere in a branch...
(07:40:30 PM) Norv: Or you push first lol

(07:41:21 PM) elk_core: [Elkarte] norv pushed 7 new commits to master: http://git.io/XQtCSA
(07:41:21 PM) elk_core: Elkarte/master 8a81ad3 emanuele: Fix for topics merging...
(07:41:21 PM) elk_core: Elkarte/master d6af08c emanuele: Sneaking in the fix for guests and regular members not appearing in the edit board page...
(07:41:21 PM) elk_core: Elkarte/master e78f2e8 emanuele: Does this fix the issue with verification questions?...

(07:41:56 PM) Norv: Btw, https://github.com/norv/elkarte/commit/6d74702527e32e85e766d99b13f5d04dc8a52cdd . Thoughts?
(07:46:45 PM) emanuele: > (not for Demo/CVS versions!)
(07:46:48 PM) emanuele: lol
(07:46:59 PM) ***emanuele thinks that code hasn't changed for a while
(07:47:01 PM) emanuele: O:-)
(07:48:22 PM) emanuele: From the data I have in my head it seems that is more likely such kind of error is due to mod/addons/custom coding rather than an old database
(07:49:58 PM) Norv: yep
(07:50:30 PM) Norv: Shocked me too. I thought I knew this one :'( :-/
(07:51:36 PM) Norv: Anyway it's a bit disputable to have the db version (you'd rely on) in the db. In particular since upgrades rely on $forum_version and stuff. :\
(07:52:03 PM) Norv: (but it's correct too cuz it doesn't change any patch)
(07:53:05 PM) Norv: Anyway it's probably better if repair_settings or _settings scripts, would give that info too: hey the db version says this.
(08:01:39 PM) Norv: The real problem that this message would help with, is if you failed your previous upgrade, and you failed in such way that the version got set, but something else of the script (or patch) wasn't done. I can't think of relevant cases you wouldn't know about already, in which this would be true...
(08:02:40 PM) Norv: No wait, I mean the version wasn't set. Ah well. Patches where you didn't execute the script, but made manual changes.
(08:03:29 PM) emanuele: Then just give the information without giving suggestions:
(08:03:40 PM) emanuele: the database version is: 1.0
(08:17:36 PM) Norv: Done

(08:19:00 PM) Norv: I can merge that PR in, it's just that it has a number of (usually not big) refactorings with a slight potential to be of interest (and/or hiding some bug)
(08:19:31 PM) ***Norv is trying to convince meself to make -real- unit tests for some of them.
Title: Re: IRC
Post by: TestMonkey on June 20, 2013, 09:06:55 pm
09:25:57 PM) Norv: emanuele: it doesn't matter much on the refactoring PR, if it's in now or later, in a sense. (just I'd like to know if there are issues with it.) If there aren't, and it bothers you being in 'limbo', we can just merge it or just let it for much later.
(09:46:31 PM) emanuele: Norv which PR?
(09:47:10 PM) emanuele: I'm fine with merging it! :D
(09:47:39 PM) emanuele: (even though I don't know which one is it lol)
(09:54:03 PM) Norv: lol https://github.com/elkarte/Elkarte/pull/559 2700+ additions, 2400+ deletions, says github, but most are because of some wrapping into classes, and basic query->moved stuff.
(09:54:45 PM) emanuele: Ohhh....that's one of those "break everything apart" thing! :D
(09:54:49 PM) ***emanuele likes
(09:56:43 PM) elk_core [~elk_core] entered the room.
(09:56:43 PM) elk_core: [Elkarte] norv pushed 14 new commits to master: http://git.io/EQ1Kng
(09:56:43 PM) elk_core: Elkarte/master 2cc5e33 Norv: Update dispatcher actions for several action, sa....
(09:56:43 PM) elk_core: Elkarte/master 9b412a3 Norv: Update and fix dispatching for groups controller. Standardize its overall design (basic)....
(09:56:43 PM) elk_core: Elkarte/master 5465fad Norv: Add a couple unit tests for dispatching. (wip, in parallel with a review and fixes of...
(09:56:43 PM) elk_core left the room.
(09:57:11 PM) Norv: it's on the mild side! :D
(09:57:26 PM) Norv: ok, so now you haz approveTopics() in subs, not in controller
(09:59:22 PM) ***emanuele goes kill his repo
(09:59:57 PM) Norv: lol
Title: Re: IRC
Post by: TestMonkey on June 21, 2013, 09:18:47 am
(10:36:39 PM) Norv: Btw Ema, didn't you work on user tags somewhere? Sorry, I'm afraid that branch of yours slipped my mind. Should perhaps try to take in those too, and while it's not a hurry, I tend to think it's better earlier than later
(10:38:48 PM) emanuele: ohh...that one...I didn't touch it in a while, I suppose is quite outdated...but I read Spuds was working on something cool about tagging (a la github IIRC) so I didn't consider it a priority for that reason too
(10:39:37 PM) ***emanuele thinks the pagination of error log is broken
(10:39:58 PM) Norv: ah ok
(10:40:32 PM) emanuele: https://github.com/elkarte/Elkarte/pull/508
(10:40:59 PM) emanuele: >  I had those put in place for a super fancy @notify member pulldown in the editor (like in github), unfortunately I completely lost all that code in some repo snafu
(10:42:59 PM) Dragooon: Ohhhh @notify stuff!
(10:49:18 PM) Norv: because it makes a scroll?
(10:49:59 PM) Norv: notify is the cool, we'd like it for the public release
(10:52:14 PM) emanuele: What scroll Norv?
(10:52:26 PM) Norv: in the error log page
(10:53:16 PM) emanuele: nope, if you filter the results the number of pages is always the same
(10:55:14 PM) Norv: it makes a horizontal scrolling bar down the page, when URLs are too long (I suspect). Dunno, it doesn't look fine to me
(10:55:17 PM) Norv: ohh, right
Title: Re: IRC
Post by: Antechinus on June 21, 2013, 09:26:58 am
Ah. I know a fix for long url's. You can force them to break with a bit of CSS. :) Put it up as an issue on GitHub and blame me if it doesn't get fixed. :P
Title: Re: IRC
Post by: TestMonkey on June 21, 2013, 02:59:50 pm
Ah. I know a fix for long url's. You can force them to break with a bit of CSS. :) Put it up as an issue on GitHub and blame me if it doesn't get fixed. :P
https://github.com/elkarte/Elkarte/issues/567  O:-)
We'll look at pagination.
Title: Re: IRC
Post by: TestMonkey on June 21, 2013, 03:02:15 pm
(10:25:09 AM) groundup: I really wanted to like Symfony and Silex. I tried ZF and now I am working with Symfony/Silex. In the end they make everything so f*ing complicated. PHP is mostly a framework in itself
(11:04:03 AM) ***Norv thinks it's a good time for me to say 'told you so' but I won't do that. :D
(11:05:50 AM) Norv: PHP userland has thought it's cool to imitate Java and JavaBeans and stuff. Results: inappropriate for PHP language, over-bloated, and, if you ask me, boring.
Title: Re: IRC
Post by: TestMonkey on June 21, 2013, 03:03:21 pm
(11:18:52 AM) elk_core: [Elkarte] norv opened pull request #566: Small additions for testing (master...unittest)  http://git.io/qEImcw
(11:29:23 AM) elk_core: Elkarte/master fc4996f Norv: Added a test for poll creation. Fixed the default values in createPoll function because...
(11:29:23 AM) elk_core: Elkarte/master cc73809 Norv: Add tests for poll subs functions....
(11:29:23 AM) elk_core: Elkarte/master b1c4634 Norv: Disable testing by default (we're using db). Add documentation....

(11:27:13 AM) elk_core: [Elkarte] norv opened pull request #568: Picks (master...picks)  http://git.io/FtLOlA
(11:27:43 AM) elk_core: Elkarte/master 0f4b3e9 Michael Eshom: The 'disregarded' column wasn't set for existing entries, causing a DB error in some cases...
(11:27:43 AM) elk_core: Elkarte/master 03c823d Michael Eshom: In some cases, validation was done multiple times for the same token...

(11:30:42 AM) elk_core: [Elkarte] norv pushed 6 new commits to master: http://git.io/b9XiWg
(11:30:43 AM) elk_core: Elkarte/master 309a8a6 emanuele: Fixed disregard due to a wrong query...
(11:30:43 AM) elk_core: Elkarte/master 6a48e68 emanuele: Slight re-work of the _api method and small change to is_not_guest to better handle these methods (at least I hope)...
(11:30:43 AM) elk_core: Elkarte/master a01e306 emanuele: Now is AJAX and not SJAX + fixed some (several) errors...

(11:41:20 AM) elk_core: [Elkarte] norv opened pull request #569: Display controller. (master...display)  http://git.io/PBww6g
(11:42:26 AM) elk_core: Elkarte/master a635abd Norv: Bit of standarization, add action_index() to Display controller....
(11:42:26 AM) elk_core: Elkarte/master 4d29a16 Norv: Merge pull request #569 from norv/display...
Title: Re: IRC
Post by: TestMonkey on June 22, 2013, 03:08:45 am
(04:53:38 PM) emanuele: Anyone around that knows very well the permission system?
(04:54:54 PM) emanuele: I have in front of me a forum where all the post-based groups are set inherited from a normal membergroup
(04:55:31 PM) emanuele: now I wonder: is it normal that members that fall into the post-based group do *not* inherit any permission from the normal group?
(05:04:27 PM) Trekkie101: Does the post count group not change them from the normal?
(05:04:29 PM) Dragooon: Burn the permission system!
(05:05:52 PM) ***emanuele likes how that guy (Dragooon) thinks
(05:06:02 PM) Dragooon: Thank you! :P
(05:06:11 PM) emanuele: :P
(05:08:28 PM) emanuele: Trekkie101 dunno... well, testing a bit it seems that postcount-based groups do not inherit permissions from normal groups.

(05:38:21 PM) elk_core: [Elkarte] norv pushed 15 new commits to master: http://git.io/yb1MyA
(05:38:21 PM) elk_core: Elkarte/master 9dd00ae Norv: Security policy: reject magic_quotes configuration if enabled. Cleanup QueryString.php of magic quotes....
(05:38:21 PM) elk_core: Elkarte/master c485bee Norv: Move utility functions _recursive() to Util class. They aren't currently used, but potentially useful......
(05:38:21 PM) elk_core: Elkarte/master cf9adf6 Norv: htmlspecialchars() HTTP_USER_AGENT. (from Util.) This removes db entirely from QueryString.php.....

(06:14:02 PM) TimeVortex: postcount-based groups only have a subset of permissions anyway
(06:14:21 PM) TimeVortex: As they are intended to be used alongside regular groups
(06:14:38 PM) TimeVortex: I *think* they can't deny permissions either
(06:15:36 PM) ***emanuele is always confused by permissions... lol
Title: Re: IRC
Post by: TestMonkey on June 22, 2013, 03:11:36 am
(10:30:56 PM) Norv: emanuele: that's a really nice experiment!
(10:31:17 PM) Norv: Good to see lol. That this is what the monster does :P
(10:31:28 PM) emanuele: lol
(10:31:49 PM) emanuele: it's just about 800 lines of code...not so much for a function! :P
(10:32:25 PM) emanuele: Is somehow the direction that we should take?
(10:32:32 PM) Norv: action_post is about 900 lol
(10:32:42 PM) ***emanuele is scared by action_post
(10:32:46 PM) Norv: none compares to the upgrade script, I give ya that :D
(10:33:00 PM) emanuele: really, I have no idea where to start split out things... lol
(10:33:31 PM) Norv: I think so. There isn't really much else to do with display... It does indeed what you show, gathers things from everywhere lol
(10:34:18 PM) emanuele: There is just to find a solution for $attachments
(10:34:25 PM) ***emanuele whistles innocently
(10:34:27 PM) emanuele: :P
(10:34:38 PM) Norv: Eventually, I'd try moving the conditions (enabled/disabled, checks) up. For readability, and to not allow entry in the method if they're not fulfilled
(10:35:01 PM) Norv: oh, that global to 'prepare'?
(10:35:07 PM) emanuele: yep
(10:35:16 PM) emanuele: I was a bit unsure about where put checks
(10:35:30 PM) Norv: Clearly. I don't remember the details of it, but that needs a solution.
(10:35:44 PM) emanuele: there is time. ;)
(10:36:28 PM) Norv: Btw, something "similar" is how List can be split, I mean I can build things one by one
(10:36:57 PM) ***emanuele haz weird ideas about list...
(10:37:00 PM) Norv: (well it's not similar but you see what I mean). I wasn't very happy about it, but that's what it does...
(10:39:38 PM) Norv: For example https://github.com/emanuele45/Dialogo/blob/display_controller/sources/controllers/Display.controller.php#L543 , we enter prepareEvent() only to exit cuz ain't nothing for us.
(10:44:29 PM) Norv: Implement them lol.
Title: Re: IRC
Post by: TestMonkey on June 22, 2013, 03:12:16 am
(10:44:47 PM) ***Norv stares at the code and is surprised mod center works.
(10:44:56 PM) emanuele: ROFL

(10:49:43 PM) ***emanuele clicks "enable repository next"
(10:53:14 PM) Norv: Btw, https://github.com/norv/elkarte/commit/3f4348c4ff3af7db539a9d4c89ceb445be395ac8

(10:55:19 PM) Norv: Myeah... when you make a PR now, you *have* to see the comparison first. Which kills browsers. :P
(10:55:38 PM) emanuele: NO!!!!
(10:56:10 PM) Norv: Feedback to them ugly github!
Title: Re: IRC
Post by: Antechinus on June 22, 2013, 03:14:09 am
(10:44:47 PM) ***Norv stares at the code and is surprised mod center works.
I second Ema's ROFL.

/me has been feeling a bit like this with the markup and css......
Title: Re: IRC
Post by: TestMonkey on June 22, 2013, 03:20:57 am
(11:44:45 PM) ***Norv has fixed a bit in modcenter, and... ok it still works. Was thinking that now was a good time to bail on me. :P

(12:11:10 AM) Norv: [On SMFQuiz mod] This looks like a good test run for Elk. See how easy it'd be to write these features I'm seeing here and how it'll be like.
(12:13:21 AM) ***emanuele is now concentrated on #tags
(12:13:33 AM) emanuele: I had a couple of ideas, but I forgot them lol, after that if I can avoid feature cat and his blog, it may be a nice test
(12:15:47 AM) emanuele: Though for me it would require quite a bit of time due to my repulsion for javascript...
(12:18:25 AM) ***Dragooon loves JS
(12:18:46 AM) Dragooon: It's the absolute best tool to go into depression and die
(12:18:59 AM) emanuele: ROFL
(12:21:20 AM) Norv: Oh no, cat's blog is the coolest, and it haz no js!
(12:21:30 AM) emanuele: lol
(12:21:45 AM) Norv: O:-)
Title: Re: IRC
Post by: TestMonkey on June 22, 2013, 03:23:44 am
(12:26:24 AM) emanuele: Should does it make sense to "clean up" (whatever that means) the display_controller branch and submit it or better keep it as an experiment?
(12:33:36 AM) Dragooon: Yes
(12:33:53 AM) ***Dragooon doesn't know anything about it. But still..I think I should give some positive feedback
(12:35:51 AM) emanuele: lol
(12:36:37 AM) ***Dragooon should actually check out elk instead of annoying people here
(12:46:45 AM) Dragooon: Batman!
(12:47:05 AM) emanuele: NaNNaNNaNNaNNaNNaNNaN

(12:48:24 AM) emanuele: Norv: $settings['strict_doctype']
(12:48:28 AM) emanuele: can we kill it?
(12:48:36 AM) emanuele: O:-)
(12:48:40 AM) ***emanuele likes kill
Title: Re: IRC
Post by: TestMonkey on June 22, 2013, 03:24:38 am
> emanuele: Should does it make sense to "clean up" (whatever that means) the display_controller branch and submit it or better keep it as an experiment?
(01:06:35 AM) Norv: I think it's worth submitting Ema. Can't get much better (and if it can, it can from there), and it's more readable than those 800 lines
(01:07:38 AM) Norv: I doubt extensibility, but that's not a problem. At the end, what we probably want there, is mainly a hook to allow you to access $context before template, isn't it?

(01:09:05 AM) ***Norv haz just come back after another set of reworking modcenter... without testing yet. If it works this time too, I declare the award yours on place :P
(01:11:22 AM) Norv: Oh come on! It works. :D
(01:11:40 AM) ***Norv thinks that emanuele should go to sleep and not read the log.

(01:19:51 AM) emanuele: Depends...depends...
(01:22:37 AM) Norv: https://github.com/norv/elkarte/commit/de0ea90faa01036a3f7d4d73c1ff811984529dbc
Title: Re: IRC
Post by: TestMonkey on June 23, 2013, 07:55:27 pm
(04:17:18 PM) elk_core: [Elkarte] Spuds opened pull request #574: Theme Updates III (master...AIII)  http://git.io/quAptw

(04:29:49 PM) Dragooon: Elkarte has autoloading?
(04:53:00 PM) Norv: No. It implements a seamless loading of controllers with a certain naming pattern, but no autoloading.
(04:55:44 PM) Dragooon: Okay

(05:12:43 PM) elk_core: [Elkarte] emanuele45 opened pull request #575: Split controller (master...split_controller)  http://git.io/SkUSPA

(05:39:19 PM) elk_core: [Elkarte] norv opened pull request #576: Controllers (part ...) (master...controllers)  http://git.io/QTYR1g

(06:15:36 PM) elk_core: [Elkarte] emanuele45 opened pull request #577: Error pages (master...error_pages)  http://git.io/UWdpLw
(07:44:27 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/zfglKQ
(07:44:27 PM) elk_core: Elkarte/master f641cf0 emanuele: A couple of missing require in Draft controller......
(07:44:27 PM) elk_core: Elkarte/master 9b98d8d emanuele: Passed $filter to numErrors and restored correct pagination of filtered errors...
(07:44:27 PM) elk_core: Elkarte/master 0e0dfe7 Norv: Merge pull request #577 from emanuele45/error_pages...
Title: Re: IRC
Post by: TestMonkey on June 23, 2013, 07:56:18 pm
(06:39:04 PM) emanuele: The PM controller is scary too...
(06:51:45 PM) Dragooon: Anything PM is scary!

(07:13:28 PM) elk_core: [Elkarte] eurich opened pull request #578: Themes.php refactoring (master...manage_themes)  http://git.io/UXcv0g

(08:19:38 PM) Norv: just to note, your vision on PMs sounds very good to me. Once we redesign PMs implementation as we'd want, to add pages pulling PMs in different 'views' can easily be made by addons (or even us but *separately*! :D)
(08:21:01 PM) ***Norv has an obsession on separation of code.
(08:53:40 PM) ***emanuele was considering "separate" the PMs as well
Title: Re: IRC
Post by: TestMonkey on June 23, 2013, 07:56:47 pm
(01:31:06 AM) elk_core: [Elkarte] norv pushed 18 new commits to master: http://git.io/zfP_tg
(01:31:06 AM) elk_core: Elkarte/master ffa2412 Antechinus: ! remove plainbox from display template...
(01:31:06 AM) elk_core: Elkarte/master 12a5d91 Antechinus: ! updates to page index layout, top/bottom controls,...
(01:31:06 AM) elk_core: Elkarte/master 14bfd54 Antechinus: ! Remove simplebox class from markup...

(01:50:04 AM) elk_core: [Elkarte] norv pushed 19 new commits to master: http://git.io/g7xUnw
(01:50:04 AM) elk_core: Elkarte/master 54b97d1 Thorsten Eurich: cleaning from unused vars and $db init.....
(01:50:04 AM) elk_core: Elkarte/master f7800b6 Thorsten Eurich: methods visibility, forgot $db init....
(01:50:04 AM) elk_core: Elkarte/master d828f67 Thorsten Eurich: moved function get_file_listing() to subs....
Title: Re: IRC
Post by: TestMonkey on June 23, 2013, 07:57:25 pm
(02:11:05 AM) elk_core: [Elkarte] emanuele45 opened pull request #579: Random refactoring (master...random_refactoring)  http://git.io/fdkd3g

(02:21:08 AM) groundup: http://silex.sensiolabs.org/contributors <-- I like that
(02:27:29 AM) emanuele: Nice! :D

(04:08:25 PM) elk_core: [Elkarte] eurich opened pull request #580: Rebuilding the blue variant. (master...rebuild_old_variants)  http://git.io/iltWIA

(05:16:09 PM) elk_core: [Elkarte] eurich opened pull request #581: relative time fix (master...relative_time_fixes)  http://git.io/PSAt_g

(06:34:16 PM) ***emanuele is tempted to cleanup completely PM controller and start from scratch...
(06:39:29 PM) ***Norv removes PM controller.
(06:39:35 PM) Norv: Thy wish is my command :P
(06:54:59 PM) emanuele: darn...I squashed a commit that was just a WIP...
(07:05:16 PM) ***emanuele thinks Norv wants *a lot* of bugz in PMs
(07:08:59 PM) Norv: Nope, doesn't, lol
(07:09:28 PM) Norv: PMs are cool stuffs. Well visibly. :P
(07:10:23 PM) Norv: Well, seriously, isn't cleaning mercilessly (not wipe, but mercilessly modes, etc) going to make a change?
(07:11:57 PM) emanuele:  hope...though every once in a while I come back to the idea of a "radical" change in PMs (that I'm working on) and I start asking myself if it wouldn't be faster to just write it lol
(07:12:59 PM) emanuele: BTW: https://github.com/emanuele45/Dialogo/blob/master/sources/controllers/PersonalMessage.controller.php#L203
(07:13:07 PM) emanuele: Any idea what the 'view' is?
(07:13:21 PM) emanuele: It changes the view, but I'm not sure how
(07:13:34 PM) emanuele: ...and why it is there in the first place
(07:20:37 PM) Norv: https://github.com/emanuele45/Dialogo/blob/master/themes/default/PersonalMessage.template.php#L581
(07:23:53 PM) emanuele: ?
(07:24:17 PM) ***emanuele wants to use createList there one day or another
(07:33:06 PM) Norv: It sends view param, so apparently it changes the view (convo mode)... But I have no idea if it works. Must be very old code, I think
Title: Re: IRC
Post by: TestMonkey on June 23, 2013, 07:59:12 pm
(07:26:49 PM) elk_core: [Elkarte] AaronVanGeffen opened pull request #582: Title attributes in display template (master...master)  http://git.io/fo_CNg

(07:27:04 PM) ***TimeVortex is avoiding his studies for a bit
(07:27:27 PM) TimeVortex: Fixed a tidbit and sent in my first PR to you guys. :P Don't expect too much.
(07:27:46 PM) TimeVortex: I better not have broken anything in my PR. :P
(07:33:15 PM) Norv: Thank you TimeVortex! ;D

(07:34:55 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/z2mFJw
(07:34:55 PM) elk_core: Elkarte/master c0652ed Thorsten Eurich: relative time: grammar corrections for quotes...
(07:34:55 PM) elk_core: Elkarte/master 6171cd2 Norv: Merge pull request #581 from eurich/relative_time_fixes...

(07:38:26 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/fUurfQ
(07:38:26 PM) elk_core: Elkarte/master 7b2033a Aaron van Geffen: Removed superfluous title attribute for reply numbers;...
(07:38:26 PM) elk_core: Elkarte/master a586fd0 Norv: Merge pull request #582 from AaronVanGeffen/master...

(07:41:42 PM) groundup: Instead of <div class="windowbg2"> for posts change that to article. Instead of <a id="msg123"> change that to <article id="123"> add a class="unread" for unread posts
(07:42:00 PM) groundup: Just thought of that because of Aaron's PR
(07:45:41 PM) groundup: Use rel="author" for article authors
Title: Re: IRC
Post by: TestMonkey on June 23, 2013, 08:01:39 pm
(07:42:07 PM) Norv: emanuele: tbh I was thinking we (you, when you're in the mood for a forum post explaining stuff?) could organize a hunt for places for createList(). *sagenods*.
(07:42:30 PM) ***emanuele thinks there aren't many left... lol
(07:42:44 PM) Norv: I remember there was one in admin... and there's Packages
(07:43:31 PM) Norv: I suppose PackageServers too (off-hand speaking, didnt check)
(07:44:03 PM) emanuele: Packages already uses createList (it's overall a bit ugly but it works)
(07:44:14 PM) Norv: Ah ok. Sorry :D
(07:44:29 PM) emanuele: PackageServers...mmm...never looked at that...lol
(07:44:38 PM) emanuele: Do we "need" it?
(07:45:02 PM) emanuele: I always wondered if it really used

(07:45:29 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/JavZxQ
(07:45:29 PM) elk_core: Elkarte/master de417c5 Thorsten Eurich: welcome back, blue variant :P...
(07:45:29 PM) elk_core: Elkarte/master ca49fe0 Thorsten Eurich: blue variant: some adjustments, colors etc.....
(07:45:29 PM) elk_core: Elkarte/master 2318763 Thorsten Eurich: blue variant: more small improvements...
Title: Re: IRC
Post by: TestMonkey on June 23, 2013, 08:01:59 pm
(07:47:39 PM) Norv: IMO, PackageServers is definitely way underused, to what it should be. In my perspective, the proprietary 'centralization' to sm.org has a lot to do with the reasons. But yeah, UI improvements and real documentation on how to use it, should help
(07:51:48 PM) Norv: It's trivial to make a package server on your site. But, well, people make big mods for downloads instead. *headscratch*. Perhaps even an admin feature to enable or set your own package server may help? Or an editor interface (if entirely basic) for the xml file? Ok, maybe as features it's overkill (and a bit risky) but, some very visible way to do it.

(07:47:32 PM) TimeVortex: Norv: no probs! Glad to be of some help, even if only a little.
(07:49:04 PM) TimeVortex: Norv: I think the absolute timestamp should always be shown on hover, by the way, not just on topic display (e.g. also on the board and message index)
Title: Re: IRC
Post by: Antechinus on June 23, 2013, 11:08:14 pm
Dumping this, as have decided a new topic is better.
Title: Re: IRC
Post by: TestMonkey on June 24, 2013, 12:59:14 am
Dumping this, as have decided a new topic is better.
That's ok, but we have quote to new topic. It'd have linked it here. ;)

Instead, I'll just link it for people to know to refer to.

(07:41:42 PM) groundup: Instead of <div class="windowbg2"> for posts change that to article. Instead of <a id="msg123"> change that to <article id="123"> add a class="unread" for unread posts
(07:42:00 PM) groundup: Just thought of that because of Aaron's PR
(07:45:41 PM) groundup: Use rel="author" for article authors
Semantics, HTML5, and other gruesomeness. (http://www.elkarte.net/index.php?topic=464)
Title: Re: IRC
Post by: TestMonkey on June 24, 2013, 01:00:18 am
(06/24/2013 01:03:35 AM) ***Norv has just cleaned up MoveTopic controller of queries and brags about it :P
(01:04:58 AM) emanuele: Now do it with PersonalMessage! :P
(01:06:01 AM) Norv: But-but. Wouldn't want to spoil it for ya. ;D
(01:07:09 AM) emanuele: lol

(01:34:11 AM) Norv: What is the use of printpage? (serious question in a sense)
(01:35:28 AM) ***Norv has cleaned the last bit of the other action handlers of Topic controller, but action_printpage() still prevents it to be clean of them pesky queries.
(01:35:41 AM) ***emanuele has never used it
(01:36:13 AM) emanuele: though I remember someone asked even for a "print" version of the memberlist
(01:36:54 AM) Norv: Mmm. This print view... can't really be done with css stuffs alone, I'd think...
(01:37:32 AM) emanuele: I think it should be possible
(01:38:08 AM) emanuele: Probably the original idea was to create a simplified black&white version of the page with much less informations
(01:38:35 AM) Norv: Yes. Well you also have pagination to get rid of... and probably more I don't remember atm
(01:38:42 AM) emanuele: Also printpage (AFAIR) doesn't use the callback even though it prints *all* the messages in a topic
(01:38:48 AM) Norv: Yep
(01:39:40 AM) emanuele: But:
(01:40:04 AM) groundup: view all, print. Seems simple enough
(01:40:06 AM) emanuele: who is going to print "in one go" all the messages of a topic?
(01:42:51 AM) Norv: The smileys and stuff processing must not be done, too, for print view.
(01:43:27 AM) Norv: So you think normal pagination should be kept?
(01:45:30 AM) emanuele: Difficult to guess how people could use a feature when you have never used it (and AFAIR I never printed pages from the internet except a couple of maps from google)
(01:45:53 AM) ***Norv is confused, cause I don't see how it could be done instead. I blame 2 am, but, hrm.

(01:48:49 AM) emanuele: ROFL 1.3 GB of prettyURL cache!
(01:49:05 AM) emanuele: no, that's wrong, it can't be
Title: Re: IRC
Post by: TestMonkey on June 25, 2013, 01:14:13 pm
(12:13:34 AM) elk_core: [Elkarte] norv pushed 12 new commits to master: http://git.io/Q-5L5w
(12:13:35 AM) elk_core: Elkarte/master 62a1f70 Thorsten Eurich: unused code $ globals.....
(12:13:35 AM) elk_core: Elkarte/master 3e13d99 Thorsten Eurich: $db init wasn't needed...
(12:13:35 AM) elk_core: Elkarte/master 841a9d3 Thorsten Eurich: unused globals, blank line....

(04:44:05 AM) elk_core: [Elkarte] IchBin opened pull request #587: Clear error log buttons (master...bugfixes)  http://git.io/vI1S_w
(11:27:19 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/BA6zFQ
(11:27:19 AM) elk_core: Elkarte/master 05aff09 ichbin: I want buttons to remove log entries at the top too. :)...
(11:27:19 AM) elk_core: Elkarte/master f63e05b ichbin: I want buttons to remove log entries at the top too. :)...
(11:27:19 AM) elk_core: Elkarte/master 67a0ce9 Norv: Merge pull request #587 from IchBin/bugfixes...
Title: Re: IRC
Post by: TestMonkey on June 25, 2013, 01:15:07 pm
(11:33:23 AM) elk_core: [Elkarte] norv opened pull request #588: Picks (master...picks)  http://git.io/NKIUiw
(11:34:03 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/ZKZ5MA
(11:34:03 AM) elk_core: Elkarte/master 353f431 Antes: apostrophe causing error....
(11:34:03 AM) elk_core: Elkarte/master 65ab52e Norv: fix syntax potential issue....
(11:34:03 AM) elk_core: Elkarte/master c4aff1b Norv: Merge pull request #588 from norv/picks...

(12:27:10 PM) elk_core: [Elkarte] norv opened pull request #589: Ant themeupdates (master...ant_themeupdates)  http://git.io/NdrdYg
(01:30:46 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/b3DU4w
(01:30:46 PM) elk_core: Elkarte/master 80ec9ba Antechinus: All this bundle does is convert the remaining transitional doctypes to HTML5....
(01:30:46 PM) elk_core: Elkarte/master 077f74c Antechinus: Removes the last examples of .titlebg2 from Elk (Calendar.template.php and Search.template.php)...
(01:30:46 PM) elk_core: Elkarte/master dc8a7e1 Antechinus: Basic cleanup for help pop-up markup and CSS....
Title: Re: IRC
Post by: TestMonkey on June 25, 2013, 01:15:16 pm
(01:34:36 PM) elk_core: [Elkarte] norv opened pull request #590: Speaking of yelling. :) How about this? (master...elk_tweak)  http://git.io/UJ7HpA

(02:09:42 PM) elk_core: [Elkarte] norv opened pull request #591: CSS refactoring (resorting and indexing) (master...ant_themeupdates)  http://git.io/baHMCg
Title: Re: IRC
Post by: TestMonkey on June 25, 2013, 10:19:10 pm
(09:59:29 PM) Norv: emanuele: would you like us to integrate https://github.com/Oldiesmann/SMF21/commit/341c46d5457f5cf0cbb45d2801c06518609d3f01 ?
(09:59:51 PM) Norv: I see you made report_sent a layer
(10:00:50 PM) Norv: TBH, I was thinking (well, I have a branch somewhere) to remove send topic, and make it addon.
(10:03:35 PM) Norv: ... which is probably not a good idea.
(10:05:21 PM) emanuele: Why not?
(10:05:42 PM) emanuele: O:-)
(10:07:53 PM) Norv: Send topics - make available content - in different formats and through different applications, is imo a good idea. It's just that 'send topic to a friend' kinda strikes me as mostly... pffft. Not the way content is shared since ten years ago :P
(10:10:30 PM) Norv: Wants remove, lol?
(10:16:09 PM) emanuele: I've never used it and I...
(10:16:29 PM) ***emanuele does some checks here and there
(10:20:43 PM) emanuele: > Norv   I see you made report_sent a layer
(10:20:45 PM) emanuele: did I?
(10:20:56 PM) emanuele: ...ohhh I'm such a good guy... lol
(10:26:27 PM) Norv: I wonder if the UI is well chosen for it... because, ok, sure you 'send topic' in a topic, and yet it's a big button there, which doesn't seem to have much in common with others ('reply', 'add poll', 'mark unread')
(10:26:43 PM) Norv: well, and its friend 'print'
(10:26:52 PM) Norv: they both seem sort of ... different
(10:27:26 PM) ***Norv was tempted to say out of place, but it may be just me
(10:28:02 PM) Norv: lol, you're the layers master!
(10:28:53 PM) emanuele: Well, reading my messages you may have already noticed I'm not really enthusiast about the buttons in general...
(10:30:12 PM) Norv: lol I *was* thinking at that! /me was probably shamelessly hoping to get support for removing buttonz from the visible interface or make them smaller or something
Title: Re: IRC
Post by: TestMonkey on June 25, 2013, 10:22:01 pm
(10:30:08 PM) emanuele: BTW the "new" icon seems to be broken on the first access so it should be some check on the session...
(10:33:13 PM) Norv: ok... Are your PRs tested? O:-) At least Split controller
(10:34:52 PM) emanuele: I thought they were tested even when I sent them, so I'm not exactly reliable on that round... sorry
(10:35:26 PM) Norv: lol
(10:34:54 PM) Norv: On first access... to the board?
(10:37:00 PM) emanuele: It's strange: it seemed the first time you access a board for the first time on the session (and then the other boards were fine), but few minutes ago it didn't appear for two boards accessed during the same session...
(10:37:50 PM) emanuele: For example now I'm re-looking around and it marked as read everything...
(10:38:17 PM) emanuele: I had two topics unread in feature discussion and one in general discussion
(10:38:27 PM) emanuele: and all of them have been marked as read...
(10:38:41 PM) emanuele: usually is just the first topic of the first board I open...
(10:38:45 PM) emanuele: :-S

(10:39:07 PM) elk_core: [Elkarte] norv pushed 13 new commits to master: http://git.io/tbwJMQ
(10:39:07 PM) elk_core: Elkarte/master a83336f emanuele: Missing div that prevented change the page index when splitting ajaxively a topic...
(10:39:07 PM) elk_core: Elkarte/master 761239d emanuele: Even for xml actions we need index.template.php because in certain cases we need template_init......
(10:39:07 PM) elk_core: Elkarte/master 16f6315 emanuele: A $db not used...

(10:56:00 PM) Norv: emanuele: I'm sorry, too tired and without debugger atm to look into it now. I can make some consistency-related tweaks still (coffee is cold), but unread needs more attention than I can give it atm.
(10:56:57 PM) emanuele: Ohhh unread is another good one! :D
(10:57:45 PM) emanuele: This week I think I'm not going to do much, have to focus on RL for a tiny bit (...or at least try to lol)
(10:59:52 PM) Norv: Ok. This week I really really hope to finish the rest of significant-'must be done's, so you might find a different Elk when you look at it! :D
(11:00:18 PM) emanuele: A moose maybe? :P
(11:00:39 PM) Norv: lol hopefully not!!
(11:00:56 PM) ***Norv is not a fan of the moose.
(11:01:25 PM) emanuele: Maybe an Irish Elk? http://en.wikipedia.org/wiki/Irish_elk
(11:01:44 PM) emanuele: lol
(11:01:45 PM) Norv: LOL
(11:02:39 PM) emanuele: With those antlers it may even be a flying Elk! :D
(11:03:47 PM) Norv: Bah, *this* is beauty. You guys knows nothing. http://en.wikipedia.org/wiki/Elkhound
(11:05:29 PM) TimeVortex: Jon snuuuuh
(11:10:29 PM) Norv: :P
Title: Re: IRC
Post by: TestMonkey on June 26, 2013, 01:01:33 am
(06/26/2013 01:23:15 AM) Norv: emanuele: do you think it'd be possible to make an accessibleGroups() for the random_refactoring? I'm afraid my focus on this part and memory are poor, and if we merge it now, I'll forget and I'm not convinced of loadGroups()...
(01:25:06 AM) Norv: Eventually, lets have both, but use in PMs the simple function, accessibleGroups() (which doesn't forward, just does bluntly its stuff for now)
(01:35:34 AM) emanuele: I still have to understand what exactly that query was supposed to return, though I think I don't have any big preference for this specific case, I just have the feeling that in general we should decide one way and be consistent (and the one I think I'd like is: load data "by-permissions", but leave params around to override them "just in case"). TBH I don't remember in all the cases where...
(01:35:36 AM) emanuele: ...permissions were involved what we did, though I have the feeling every time I just forwarded somehow the permission via a parameter
(01:37:04 AM) Norv: ok
Title: Re: IRC
Post by: TestMonkey on June 26, 2013, 03:43:30 am
(03:48:36 AM) ichbin: You must be a night owl Norv. It has to be like 2am where you are or something.
(03:49:30 AM) Norv: Ohwell. Time is relative I hear.
(03:50:22 AM) Norv: ichbin: if you offer to assist Ant with his packs stands, it'll be very helpful in the time that follows
(03:51:00 AM) ichbin: packs stands? What is that?
(03:51:40 AM) Norv: * if your offer stands :D Sorry, it is indeed... some hour in them nights.
(03:52:34 AM) ichbin: lol, ah yes I see now what you are saying. I have not touched anything because it's been a little confusing to know if someone else has picked things up or not. And I'm not always around everyday to be able to get to them right away.
(03:57:12 AM) Norv: Whatever you want. I'm trying to say that we won't, Spuds and I: I'm sorry, I really can't deal with it too; and I'm afraid Ant's unwarranted comment somewhere hasn't been appropriate for the help he's been getting from Spuds. Ant isn't following normal process, and if we don't want to adapt more, well, then I'll find another way.
(04:15:38 AM) ichbin: Well if everyone can get on the same page that would be good. Maybe I'll see if I can start a topic and have Ant post his updates there. That way I will know which updates have been done. And if everyone will leave the topic alone, I can make sure I'm the only one doing them.
(04:31:03 AM) Norv: ichbin: http://www.elkarte.net/index.php?topic=468
(04:32:36 AM) Norv: lol
(04:37:58 AM) Norv: Thank you!
Title: Re: IRC
Post by: TestMonkey on June 27, 2013, 02:06:17 pm
(08:23:30 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/Ty0I-A
(08:23:30 AM) elk_core: Elkarte/master bc192c6 Antechinus: This is mainly just a resorting and indexing of CSS file content,...
(08:23:30 AM) elk_core: Elkarte/master e6a8bd9 Norv: Remove duplicate declarations....

(08:24:11 AM) elk_core: [Elkarte] norv pushed 35 new commits to master: http://git.io/WcWLJw
(08:24:11 AM) elk_core: Elkarte/master 2eb810f Norv: Add abstract base class Action_Controller....
(08:24:11 AM) elk_core: Elkarte/master 52c0728 Norv: Derive all admin controllers from Action_Controller....
(08:24:11 AM) elk_core: Elkarte/master 5c95d4b Norv: Make two dozen user/mod controllers extend Action_Controller....
Title: Re: IRC
Post by: TestMonkey on June 27, 2013, 02:06:38 pm
(09:14:16 PM) elk_core: [Elkarte] eurich opened pull request #593: Elk spelling (master...langfix)  http://git.io/r0Q1yQ

(10:02:20 PM) elk_tools: [tools] eurich opened pull request #10: populate.php shoud know about refactoring now :D (master...populate)  http://git.io/-abrzQ

(11:21:48 PM) ***Norv takes a look at ManageMembergroups in 2.1-dev and stretches. Wow we've gone a long way from those embedded tricks 'n queries 'n stuff.
(11:24:52 PM) Norv: 1221 lines of code - vs - 820, too. And 70+ in Elk are for settings (we have temporary extra-redundancy there, which is on my todo list).
Title: Re: IRC
Post by: TestMonkey on June 27, 2013, 02:07:09 pm
(03:45:00 AM) elk_core: [Elkarte] IchBin opened pull request #594: This one just gets rid of the superfluous divs in the quote tags. (master...bugfixes)  http://git.io/3jXADw
(04:38:31 AM) ichbin: How to remove last commit?
(04:38:38 AM) ichbin: in Git.
(04:53:07 AM) ichbin: git reset --hard it would seem. And then push --force to overwrite the commit if its been pushed.

(09:50:22 AM) Dragooon: OMG Elkarte went green!

(02:26:14 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/dGc6_A
(02:26:14 PM) elk_core: Elkarte/master 38b2e1c Thorsten Eurich: Elk isn't a registered trademark.. ...
(02:26:14 PM) elk_core: Elkarte/master 5f4519d Thorsten Eurich: ELKARTE to ElkArte fixes....

(02:52:09 PM) TimeVortex: Dragooon: very eco-friendly
(02:52:19 PM) Dragooon: lol

(02:56:05 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/Ph1elg
(02:56:05 PM) elk_core: Elkarte/master c8fe436 Norv: Speaking of yelling. :) How about this?...
Title: Re: IRC
Post by: TestMonkey on June 29, 2013, 10:45:54 pm
(05:02:31 AM) elk_core: [Elkarte] IchBin opened pull request #596: Basic Subs fixes (from http://www.elkarte.net/index.php?topic=475.0) (master...theme)  http://git.io/6kfctg

(06:46:05 AM) ichbin: It's Friday night, where are all the nerds who don't have a life like me? ;)

(03:06:41 PM) elk_core: [Elkarte] eurich opened pull request #598: Elk spelling (master...elk_spelling)  http://git.io/FjGPrw

(03:32:08 PM) elk_core: [Elkarte] norv pushed 1 new commit to master: http://git.io/6MTRig
(03:32:08 PM) elk_core: Elkarte/master 075c90c ichbin: Basic Subs fixes (from http://www.elkarte.net/index.php?topic=475.0)...

(03:38:44 PM) elk_core: [Elkarte] norv pushed 5 new commits to master: http://git.io/GUiRsg
(03:38:44 PM) elk_core: Elkarte/master a304dcf Thorsten Eurich: Elkarte to ElkArte...
(03:38:44 PM) elk_core: Elkarte/master df9d520 Thorsten Eurich: few more Elkarte to ElkArte replacements...
(03:38:44 PM) elk_core: Elkarte/master 7e21b4f Thorsten Eurich:  Elkarte to ElkArte replacements (docs)...
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:27:42 am
(10:52:37 AM) elk_core: [Elkarte] eurich opened pull request #600: Themes.php refactoring - part 2 (master...themes2)  http://git.io/SZUURQ

(11:21:45 AM) elk_core: [Elkarte] eurich opened pull request #602: missing constant ELKARTE to ELK changes.. (master...ELK_fixes)  http://git.io/W9-oCQ
(11:22:15 AM) elk_core: [Elkarte] eurich pushed 2 new commits to master: http://git.io/dWmosQ
(11:22:15 AM) elk_core: Elkarte/master 8ad882b Thorsten Eurich: missing constant ELKARTE to ELK changes.....

(04:27:07 AM) elk_core: [Elkarte] norv pushed 16 new commits to master: http://git.io/tD3mOQ
(04:27:07 AM) elk_core: Elkarte/master 7baaa94 Thorsten Eurich: moved db query to subs, re-use the existing function....
(04:27:07 AM) elk_core: Elkarte/master 1dff0d1 Thorsten Eurich: use existing function for redundant code....
(04:27:07 AM) elk_core: Elkarte/master e18edd1 Thorsten Eurich: moved db query to subs....

(10:06:55 PM) elk_core: [Elkarte] eurich opened pull request #603: Stats controller refactoring (master...stats_controller)  http://git.io/fCFIKg
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:30:23 am
(06:00:55 AM) elk_core: [Elkarte] IchBin opened pull request #609: Theme updates (master...theme)  http://git.io/5St7OA

(06:27:28 AM) ichbin: I feel Ant's pain with this Git BS. Just wanted to put that out there. :D
(06:31:20 AM) ichbin: Norv, if my latest PR is going to mess things up in Subs feel free to cancel the request. I'm not sure wtf is going on with git in Netbeans. It's horrible. Lacks a tone of implementation if you ask me. Either way, I'll keep my eye on the PR and comments.

(08:01:39 PM) elk_core: [Elkarte] emanuele45 opened pull request #610: News (master...news)  http://git.io/uoK5Yg
(08:03:30 PM) elk_core: [Elkarte] emanuele45 pushed 3 new commits to master: http://git.io/GUP67A
(08:03:30 PM) elk_core: Elkarte/master 73525d5 emanuele: list_getNews should be a function (and not a method) but since it just calls getNews...let's drop it...
(08:03:30 PM) elk_core: Elkarte/master 1b6f05c emanuele: Fixed news fader...
(08:03:30 PM) elk_core: Elkarte/master 647342c emanuele45: Merge pull request #610 from emanuele45/news...
(08:03:51 PM) emanuele: darn typo!
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:31:32 am
(09:32:51 PM) elk_core: [Elkarte] emanuele45 opened pull request #611: Smf remnants (master...smf_remnants)  http://git.io/FlVhIQ

(12:29:43 AM) emanuele: Hey!!
(12:29:51 AM) emanuele: It's sooooo calm here around...
(12:30:01 AM) emanuele: Everybody sleeping? :P
(01:20:26 AM) ***Norv is wandering cross the interwebz.
(01:24:46 AM) emanuele: Ohhh...so someone is actually around! :P
(01:35:39 AM) Norv: Is not. :)
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:33:01 am
(08:38:15 PM) elk_core: [Elkarte] eurich opened pull request #647: fixes for various bugs (master...spuds_reported_bugs)  http://git.io/HxRf9Q
(09:32:21 AM) elk_core: [Elkarte] eurich closed pull request #647: fixes for various bugs (master...spuds_reported_bugs)  http://git.io/HxRf9Q

(09:35:22 AM) elk_core: [Elkarte] eurich pushed 2 new commits to master: http://git.io/ILhrEA
(09:35:22 AM) elk_core: Elkarte/master 4505e51 Antechinus: Ugh. Old SMF 2.0.x markup. :P...
(09:35:22 AM) elk_core: Elkarte/master 98464cf Thorsten Eurich: Merge pull request #627 from eurich/chainsaw_massacre...
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:33:52 am
(09:18:33 PM) elk_core: [Elkarte] eurich opened pull request #649: Fixes (master...fixes2)  http://git.io/HBQDXA
(09:20:08 PM) elk_core: [Elkarte] eurich closed pull request #649: Fixes (master...fixes2)  http://git.io/HBQDXA

(10:52:33 PM) elk_core: [Elkarte] emanuele45 opened pull request #650: Fix for integration hooks page (master...admin_hooks)  http://git.io/CdjRxw

(12:10:37 AM) elk_core: [Elkarte] Spuds opened pull request #652: Draft Load Update (master...dt)  http://git.io/cqTH9A

(01:36:55 AM) groundup: It is awesome how much activity is happening but I need to change my damn notification settings now. I get way too many emails from Elkarte haha
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:39:05 am
(10:34:55 PM) elk_core: [Elkarte] engelnyst opened pull request #667: Add a ScheduledTasks.subs.php file for scheduled tasks (master...tasks)  http://git.io/B4OF2g

(10:57:43 PM) elk_core: [Elkarte] eurich synchronize pull request #657: Admin security enhancements (master...admin_security)  http://git.io/q1W3WA

(04:42:41 PM) elk_core: [Elkarte] emanuele45 synchronize pull request #648: Themes admin (master...themes_admin)  http://git.io/2s9xrg

(04:45:39 PM) elk_core: [Elkarte] emanuele45 synchronize pull request #650: Fix for integration hooks page (master...admin_hooks)  http://git.io/CdjRxw

(05:09:26 PM) elk_core: [Elkarte] Spuds opened pull request #669: Fix a couple of items in the package manager (master...pkg)  http://git.io/PLvYqw

(05:57:34 PM) elk_core: [Elkarte] emanuele45 synchronize pull request #623: Removed the "simple" permissions management page (master...remove_simple)  http://git.io/lSfAOw
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:39:27 am
(06:02:30 PM) 1JTAACKMY: [Elkarte] emanuele45 pushed 3 new commits to master: http://git.io/mGoLCA
(06:02:30 PM) 1JTAACKMY: Elkarte/master 70fce32 emanuele: Fix for integration hooks page...
(06:02:30 PM) 1JTAACKMY: Elkarte/master e90e14c emanuele: Typo - thanks Eurich...
(06:02:30 PM) 1JTAACKMY: Elkarte/master e3e87b5 emanuele45: Merge pull request #650 from emanuele45/admin_hooks...

(06:04:04 PM) emanuele: Hey Norv, do you have any idea why 1JTAACKMY and not elk_core? ???
(06:06:20 PM) Norv: No idea /surprised too :D
(06:07:59 PM) Norv: I'd be curious to see the next action
(06:09:49 PM) ***emanuele merges something random

(06:09:55 PM) elk_core [~elk_core] entered the room.
(06:09:55 PM) elk_core: [Elkarte] emanuele45 pushed 6 new commits to master: http://git.io/AJ5Dhg
(06:09:55 PM) elk_core: Elkarte/master 6e82412 Spuds: ! init the package array keys to null not '' so isset behaves as expected...
(06:09:55 PM) elk_core: Elkarte/master 1520701 Spuds: ! Well it does after that line, but lets change it back to be a comparison...
(06:09:55 PM) elk_core: Elkarte/master 3385f41 Spuds: ! No need to support old 2.0 rc1 or other old sins ... we need to make our own issues :P...
(06:09:55 PM) elk_core left the room.

(06:10:15 PM) emanuele: So, what did you do to break our 1JTAACKMY? :P
(06:10:19 PM) Norv: By chance (?) github just added synchronize events, I wonder if they're getting dizzy.
(06:10:36 PM) ***Norv is always innocent, no matter how much y'try.
(06:10:56 PM) emanuele: lol
(06:11:01 PM) emanuele: We know you are not. :P
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:39:45 am
(06:21:19 PM) elk_core: [Elkarte] engelnyst synchronize pull request #667: Add a ScheduledTasks.subs.php file for scheduled tasks (master...tasks)  http://git.io/B4OF2g

(06:30:51 PM) Norv: Oh, emanuele: when you're in the mood for installing an environment for testing, http://about.travis-ci.org/docs/user/languages/php/
(06:32:23 PM) Norv: Setup Elk, then run the tests (i.e. the all_tests.php we have), then shut it down. Travis is integrated with github, which makes it really nice, you'll see the results on every PR
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:40:21 am
(06:37:13 PM) ***emanuele hates those websites where everything moves around... lol
(06:37:55 PM) Norv: Told you. We don't need no movin' up-down arrows.
(06:38:57 PM) emanuele: My first mod will be: disable scrolling up/down :P

(08:53:06 PM) elk_core: [Elkarte] eurich merged pull request #667: Add a ScheduledTasks.subs.php file for scheduled tasks (master...tasks)  http://git.io/B4OF2g

(10:59:28 PM) elk_core: [Elkarte] emanuele45 opened pull request #671: Members search (master...members_search)  http://git.io/DU-SKQ

(11:19:02 PM) elk_core: [Elkarte] emanuele45 opened pull request #672: Message preview drop (master...message_preview_drop)  http://git.io/3vDPiw

(11:31:44 PM) elk_core: [Elkarte] Spuds opened pull request #673: Quick fix for Likes (master...lkfx)  http://git.io/ssj9ug

(11:33:44 PM) elk_core: [Elkarte] Spuds opened pull request #674: Ajax format update (master...script)  http://git.io/jLkx1w
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:40:39 am
(07/15/2013 12:54:40 AM) elk_core: [Elkarte] Spuds opened pull request #675: ! ELKARTE was changed to ELK ... (master...quicky)  http://git.io/7rcFiw
(01:14:43 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/C0jznA
(01:14:43 AM) elk_core: Elkarte/master c2428ca Spuds: ! ELKARTE was changed to ELK ......
(01:14:43 AM) elk_core: Elkarte/master b105841 Norv: Merge pull request #675 from Spuds/quicky...

(01:27:14 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/oehfhQ
(01:27:14 AM) elk_core: Elkarte/master 3203711 Spuds: ! update toggleButtonAJAX to use .done .fail as the old way has been depreciated....
(01:27:14 AM) elk_core: Elkarte/master 35303e2 Norv: Merge pull request #674 from Spuds/script...

(01:27:34 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/FS3Ozw
(01:27:34 AM) elk_core: Elkarte/master 6b98674 Spuds: ! couple of typos...
(01:27:34 AM) elk_core: Elkarte/master 0c62d51 Spuds: ! Need to make that a sloppy comparison string == int...
(01:27:34 AM) elk_core: Elkarte/master 608e3d1 Norv: Merge pull request #673 from Spuds/lkfx...
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 08:41:18 am
(04:46:37 AM) elk_core: [Elkarte] Spuds opened pull request #676: More likes fixins (master...lfix)  http://git.io/tCnoAA

(05:07:10 AM) elk_core: [Elkarte] norv opened pull request #677: Small cherrypicks (master...smallpicks)  http://git.io/ZGqNaQ
(08:52:19 AM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/G0lNtQ
(08:52:19 AM) elk_core: Elkarte/master 5808dda Michael Eshom: Remove integration hooks on upgrade...
(08:52:19 AM) elk_core: Elkarte/master 15bb2dc Michael Eshom: Some tasks weren't enabled by default...
(08:52:19 AM) elk_core: Elkarte/master ebaf398 ziycon: Separated out text strings for *_alert_none...
(08:52:19 AM) 21WAA63NS: [Elkarte] norv closed pull request #677: Small cherrypicks (master...smallpicks)  http://git.io/ZGqNaQ
Title: Re: IRC
Post by: Antechinus on July 15, 2013, 09:01:31 am
/me is putting arrows all over the place, to go up and down and sideways :P
Title: Re: IRC
Post by: emanuele on July 15, 2013, 09:44:44 am
The arrows are not bad (I have in mind something even more extensive for some custom theme), I just don't like the scrolling. ;)
Title: Re: IRC
Post by: Antechinus on July 15, 2013, 09:51:36 am
I've changed the arrows anyway, so hopefully they wont bug the people they bug as much, while still being useful for everyone else.

Oh and have made major coding breakthrough! Turns out all browsers we're worried about support UTF8 thingy #2620, so we can haz piratey me tags. :D
Title: Re: IRC
Post by: emanuele on July 15, 2013, 10:39:07 am
ROFL!
Title: Re: IRC
Post by: Antechinus on July 15, 2013, 10:48:27 am
 ;D Gotta do it.

Well anyway, am going to pull the me tag styling out of sources and just let people do it in the css. Since it's only for fun anyway, might as well let people play with it without hacking sources.
Title: Re: IRC
Post by: emanuele on July 15, 2013, 11:49:18 am
Makes sense I think. :)
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 10:59:45 pm
(12:22:59 PM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/6fU-gA
(12:22:59 PM) elk_core: Elkarte/master 7d4cb48 Thorsten Eurich: admin security: make the admin session lifetime configurable via admin interface. set the default lifetime to ten minutes for security reasons....
(12:22:59 PM) elk_core: Elkarte/master cb1b560 Thorsten Eurich: damn typos :)...
(12:22:59 PM) elk_core: Elkarte/master 81b9640 Thorsten Eurich: ups, debugging leftover :P...

(12:23:19 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/0_OrLQ
(12:23:19 PM) elk_core: Elkarte/master b95d891 Thorsten Eurich: no need for a blank line at end of the file...
(12:23:19 PM) elk_core: Elkarte/master 900c675 Thorsten Eurich:  we really don't need SMF 1.1 compability for mods anymore.....
(12:23:19 PM) elk_core: Elkarte/master 29b8d44 Thorsten Eurich: Let's finally bury the old SMF wysiwyg editor.
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 11:00:18 pm
SQlite 2.8

(09:04:22 PM) elk_tools: [tools] norv synchronize pull request #8: Sqlite (master...sqlite)  http://git.io/nFYpvA
(09:04:59 PM) elk_tools: [tools] norv pushed 5 new commits to master: http://git.io/3HKTjA
(09:04:59 PM) elk_tools: tools/master df21769 Norv: Add SQLite database files to extensions....
(09:04:59 PM) elk_tools: tools/master 4ae37b7 Norv: Add modifications....
(09:04:59 PM) elk_tools: tools/master 106a292 Norv: Update to last version....

(09:11:31 PM) elk_tools: [tools] norv opened pull request #11: Add install and upgrade scripts for sqlite. (master...sqlite)  http://git.io/YE9sew

(09:35:16 PM) elk_core: [Elkarte] norv opened pull request #678: Remove sqlite from core repository (master...sqlite)  http://git.io/sAMuIQ
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 11:01:23 pm
(11:03:34 PM) elk_core: [Elkarte] norv pushed 4 new commits to master: http://git.io/FHVcyw
(11:03:34 PM) elk_core: Elkarte/master 3133bde emanuele: Integrate members search in member list...
(11:03:34 PM) elk_core: Elkarte/master 8068ea2 emanuele: Some tweaks and removed the template_search...
(11:03:34 PM) elk_core: Elkarte/master c2e402d emanuele: Trying to find something nicer to output the memberlist page (related to a todo comment in the code about email_address)...

(11:11:11 PM) elk_core: [Elkarte] norv closed pull request #384: canSeeBoard() (master...QuerySeeBoard)  http://git.io/0_X_qg

(11:16:02 PM) elk_core: [Elkarte] norv closed pull request #382: Unused vars (master...UnusedVars)  http://git.io/UNhWjQ

(11:18:11 PM) elk_core: [Elkarte] norv closed pull request #648: Themes admin (master...themes_admin)  http://git.io/2s9xrg
Title: Re: IRC
Post by: TestMonkey on July 15, 2013, 11:02:00 pm
(11:20:41 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/1yVCPA
(11:20:41 PM) elk_core: Elkarte/master 217deaa Spuds: ! wrong mod setting used in the compare to allow liking posts (for below like post count threshold)...
(11:20:41 PM) elk_core: Elkarte/master e798208 Spuds: ! change variable name so its more descriptive e.g. I'm getting old...
(11:20:41 PM) elk_core: Elkarte/master 42e276f Norv: Merge pull request #676 from Spuds/lfix...

(11:24:08 PM) Norv: You folks are doing too many things. I can't keep up with you.
(11:24:52 PM) emanuele: It's just that you are too lazy! :P

(11:30:18 PM) elk_core: [Elkarte] norv opened pull request #680: Tweaks (master...smallpicks)  http://git.io/NnUVpw

(11:36:57 PM) ***Norv needs a :crying-cat-face: smiley.
(11:37:40 PM) Norv: How cool is that. Crying smileys. /trolls the channel.
(11:38:35 PM) emanuele: lol

(11:40:39 PM) Norv: We should tackle your PMs PR... I assume you'd like it done to move on with PMs
(11:42:35 PM) emanuele: Did I send a PM PR?
(11:42:36 PM) emanuele: ...
(11:44:56 PM) Norv: https://github.com/elkarte/Elkarte/pull/579 :)
(11:47:18 PM) Norv: It's doing very cool things. Better controller afterwards, and potentially nice utilities. I don't think the accessible groups issue is solved properly though, I'll see if I can checkout the branch again and look into it
(11:48:45 PM) emanuele: Ahhh.... *that* one! :D
(11:49:10 PM) emanuele: Yeah, it's on the todo list... xD
Title: Re: IRC
Post by: TestMonkey on July 17, 2013, 01:50:10 pm
(07/16/2013 01:10:39 AM) elk_core: [Elkarte] emanuele45 opened pull request #681: Send back to the referer? (master...admin_session)  http://git.io/eEMEfA

(05:25:55 PM) elk_core: [Elkarte] eurich opened pull request #683: printpage.template.php (master...restore_printpage)  http://git.io/QXRh3g

(06:09:47 PM) elk_tools: [tools] eurich opened pull request #12: legacy functions from SMF (master...legacy)  http://git.io/KTHhUQ

(08:27:30 PM) elk_core: [Elkarte] Spuds opened pull request #684: Quick Package Fix (master...pkg)  http://git.io/QfCLjg
(09:07:57 PM) elk_core: [Elkarte] eurich closed pull request #684: Quick Package Fix (master...pkg)  http://git.io/QfCLjg
Title: Re: IRC
Post by: TestMonkey on July 17, 2013, 01:52:25 pm
(09:42:46 PM) elk_core: [Elkarte] eurich opened pull request #685: just a quick fix (master...qfx)  http://git.io/LGhR1g
(02:00:41 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/Cd-RHQ
(02:00:41 AM) elk_core: Elkarte/master 40b39a6 Thorsten Eurich: wrong var was passed.....

(09:49:27 PM) elk_tools: [tools] eurich opened pull request #13: fixes for populate.php (master...populate_fix)  http://git.io/Yi-YaA
(07/17/2013 12:15:03 AM) elk_tools: [tools] norv merged pull request #13: fixes for populate.php (master...populate_fix)  http://git.io/Yi-YaA

(02:03:02 AM) elk_tools: [tools] norv pushed 2 new commits to master: http://git.io/smMG_g
(02:03:02 AM) elk_tools: tools/master fc74be8 Thorsten Eurich: added legacy bbc_to_html functions, formerly used by the old SMF wysiwyg editor.....
Title: Re: IRC
Post by: TestMonkey on July 17, 2013, 01:53:04 pm
(02:03:34 AM) elk_tools: [tools] norv merged pull request #11: Add install and upgrade scripts for sqlite. (master...sqlite)  http://git.io/YE9sew

(04:21:33 AM) elk_core: [Elkarte] engelnyst opened pull request #686: Errors (master...errors)  http://git.io/x3hGyQ

(08:07:07 AM) elk_core: [Elkarte] eurich merged pull request #683: printpage.template.php (master...restore_printpage)  http://git.io/QXRh3g

(10:03:43 AM) elk_core: [Elkarte] norv opened pull request #687: Actions standardization (admin) (master...actions)  http://git.io/XLvtig
(02:34:19 PM) elk_core: [Elkarte] norv synchronized pull request #687: Actions standardization (admin) (master...actions)  http://git.io/XLvtig
Title: Re: IRC
Post by: TestMonkey on July 20, 2013, 07:10:24 pm
Too much activity, I won't record it all, skipping more bits.

(02:04:40 PM) elk_core: [Elkarte] norv pushed 1 new commit to master: http://git.io/-SGOvg
(02:04:40 PM) elk_core: Elkarte/master 005fbc1 Norv: Restore (still) missed text strings from previous commits....

(07:15:25 PM) elk_core: Elkarte/master 8fb2f32 emanuele: Moved the PM settings to its own page, and added the possibility to edit the limit of PMs archieved per membergroup from that page. Re-worked also updateMembergroupProperties...
(08:17:09 PM) elk_core: [Elkarte] norv pushed 11 new commits to master: http://git.io/qDpKtg
(08:17:09 PM) elk_core: Elkarte/master f31ed2f emanuele: Used subs for PM controller (the function was there, refined a bit)...
(08:17:09 PM) elk_core: Elkarte/master 02c7c47 emanuele: A function to load membergroups details...I wonder why this function didn't exist yet...did I miss it?...
(08:17:09 PM) elk_core: Elkarte/master 17be51b emanuele: getMemberByName reused in PM controller and removed fatal error from the function...
Title: Re: IRC
Post by: TestMonkey on July 20, 2013, 07:13:24 pm
(07/20/2013 12:32:02 AM) elk_core: [Elkarte] emanuele45 opened pull request #695: Easier and centralised way to handle numbers next to menu items (master...fix_menu)  http://git.io/pzPkdA
(11:18:33 AM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/Isw6-w
(11:18:33 AM) elk_core: Elkarte/master b7262b7 emanuele: Easier and centralised way to handle numbers next to menu items...
(11:18:33 AM) elk_core: Elkarte/master 6f304c6 emanuele: Some bits of css lost around :P...

(08:02:18 AM) elk_core: [Elkarte] norv pushed 1 new commit to master: http://git.io/70DfdA
(08:02:18 AM) elk_core: Elkarte/master f87acbc Norv: Include the boards subs file....
Title: Re: IRC
Post by: TestMonkey on July 20, 2013, 07:14:18 pm
(03:23:37 PM) elk_core: [Elkarte] emanuele45 opened pull request #700: Fixed other undefined errors due to missing checks (master...fix_menu_2)  http://git.io/icDCtA
(05:20:23 PM) elk_core: [Elkarte] norv merged pull request #700: Fixed other undefined errors due to missing checks (master...fix_menu_2)  http://git.io/icDCtA

(04:05:16 PM) elk_core: [Elkarte] emanuele45 opened pull request #702: Fixes #615 and adds some classes to the <dd> in the post page (master...post_html5)  http://git.io/TTjiPw

(05:27:03 PM) Norv: > (09:17:32 PM) emanuele: The PR is just closed pending...your rebase Norv?
(05:27:03 PM) Norv: Just to note. I rebased two of them, and committed a couple of fixes directly in master. No biggies, but just to know if you're surprised. All are in.
Title: Re: IRC
Post by: TestMonkey on July 20, 2013, 07:16:45 pm
(05:28:05 PM) Norv: Woah. I just came back after an unexpected few-hours break, and my notifications screen is full. Oops, lol.
(05:39:40 PM) emanuele: LOL

(05:45:24 PM) elk_core: [Elkarte] AaronVanGeffen opened pull request #720: A bit more work on time stamps (master...master)  http://git.io/pDlyrA
(05:46:03 PM) TimeVortex: Hope you don't have too much trouble merging that.
(05:46:21 PM) TimeVortex: Just realised I hadn't pulled from the Elkarte repo before I started.
(05:46:40 PM) TimeVortex: I'm rusty :P

(05:57:18 PM) elk_core: [Elkarte] eurich opened pull request #721: fixes and cleaning (master...bugfix)  http://git.io/worlzA

(06:40:55 PM) Norv: Nah, no worries. It's a very straightforward rebase. PMs were turned upside down in the meantime :D
(06:44:17 PM) Norv: Thanks!

(06:53:56 PM) elk_core: [Elkarte] engelnyst opened pull request #722: Code clean (master...code_clean)  http://git.io/bWtX8w

(06:54:43 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/KworeA
(06:54:43 PM) elk_core: Elkarte/master a525efd Aaron van Geffen: Added missing global to make personal messages work again.
(06:54:43 PM) elk_core: Elkarte/master b97862d Aaron van Geffen: Harmonised timestamps throughout elkarte to use the html5 time tag for both relative and absolute time stamps....
Title: Re: IRC
Post by: TestMonkey on July 20, 2013, 07:19:16 pm
(06:58:29 PM) Norv: TimeVortex: oh, so you missed the new looks
(06:58:46 PM) Norv: Be kind. It's mostly 1-day old.
(07:02:55 PM) TimeVortex: Ah, yes, I mostly noticed the up/down-buttons just now. Let me merge from upstream...
(07:04:06 PM) Norv: Ahwell, I didn't realize I didn't sign it off when recommitting. TimeVortex: please do consider to sign-off your commits, as acknowledgement of the license under which you make them.
(07:04:24 PM) TimeVortex: Ah shoot, I completely forgot.
(07:04:42 PM) Norv: It's a linux-kernel kind of DCO. To be honest, it's almost meaningless normally. But we come from smf, where I needed it.
(07:04:54 PM) TimeVortex: I'll be sure to do so next time. Regular GPG signature will do, I presume?
(07:05:12 PM) Norv: Only -s tag will do.
Title: Re: IRC
Post by: TestMonkey on July 20, 2013, 07:24:40 pm
(07:06:59 PM) Norv: Please, say you hate the up/down thingies.
(07:07:13 PM) TimeVortex: Yes, I hated them to bits.
(07:07:23 PM) TimeVortex: Looks like they're gone since I merged upstream/master though!
(07:07:36 PM) TimeVortex: Oh, just moved to the right.
(07:08:18 PM) TimeVortex: Much less noticeable though. Certainly an improvement.

(07:08:34 PM) TimeVortex: I do think the "Sort by: Subject / Started by / Last post / Replies / Views / Likes" header on the messageindex is a bit too ... prominent though.
(07:08:55 PM) TimeVortex: Certainly now that they're not column headers anymore.
(07:09:21 PM) TimeVortex: Also double clicking to edit a topic title inline doesn't seem to be working anymore.
Title: Re: IRC
Post by: TestMonkey on July 20, 2013, 07:32:31 pm
(07:09:35 PM) emanuele: What about get rid of the login page too? O:-)
(07:09:49 PM) TimeVortex: Well, you'd still need it for kickGuest()
(07:10:19 PM) TimeVortex: I'm all for hiding the link to ?action=login though
(07:10:48 PM) TimeVortex: "My account" linking to PMs feels a bit weird atm.
(07:11:16 PM) TimeVortex: I suppose that'll relax if those areas (and menus) are merged? Not sure what the plan is.
(07:11:58 PM) TimeVortex: I look forward to seeing what you'll be doing :)
(07:12:53 PM) Norv: What did the login page do to you?
(07:13:28 PM) TimeVortex: It seems a bit superfluous, really. Bit of a relic.
(07:13:28 PM) emanuele: The less the pages the better! :P
(07:13:48 PM) emanuele: I would prefer something like members search is now
(07:13:56 PM) TimeVortex: Much like the "Your message has been posted. You are now redirected to ..." you still see in many forum software packages.
(07:15:06 PM) ***emanuele hates that kind of pages lol
(07:15:18 PM) Norv: I think on the UI, the plan has become to change everything at once: remove all kinds of old markup kept for compatibility and all, add html5 bits (nothing controversial) and in the meantime change the looks according to experience from past and mood for experimentation.
(07:16:16 PM) emanuele: Ohhh... and that reminds me I have to finish the send-topic ajax-like! :D
(07:18:44 PM) Norv: Mmm.. It should be easy for mods/addons to add their auth mechanism..
(07:19:29 PM) Norv: > TimeVortex: Much like the "Your message has been posted. You are now redirected to ..." you still see in many forum software packages.
(07:19:29 PM) Norv: ^^ That was a terrible thing to say lol
(07:19:55 PM) TimeVortex: Is it, really? :P
(07:20:07 PM) TimeVortex: I always despise those intermediate messages.
(07:20:10 PM) Norv: To compare poor ole' login with it!
(07:20:27 PM) TimeVortex: But there's a login form at the top these days!
(07:20:55 PM) TimeVortex: You should not need to see the login page, unless there's a good reason to.
(07:21:05 PM) Norv: Well it redirects you to the full page on error
(07:21:38 PM) TimeVortex: Fair enough, a user shouldn't go there voluntarily.
(07:21:51 PM) TimeVortex: It always gets such a prominent button on the main navigation bar.
(07:24:15 PM) emanuele: Well, if you remove that I would add a dropdown or some overlay to the login, no need to change page just for that...
(07:24:50 PM) Norv: Mmm. Well I'd remove the buttony and link... not the page
(07:25:26 PM) emanuele: lol
(07:25:31 PM) emanuele: yes, okay keep the page :P
(07:27:51 PM) Norv: Just to note, quick login is still an admin option.
(07:28:42 PM) emanuele: Why? :P
(07:28:59 PM) Norv: If there's no button to login page, we'd either remove it as option, or replace it with a button (rofl) when disabled.
(07:29:10 PM) Norv: Because you didn't remove the option! :D
Title: Re: IRC
Post by: TestMonkey on July 21, 2013, 11:57:51 am
(08:22:13 PM) elk_core: [Elkarte] Spuds opened pull request #724: Elk is a no rodent software (master...norodents)  http://git.io/zlzBcg

(09:49:43 PM) TimeVortex: Right, fellas
(09:49:52 PM) TimeVortex: There's one thing I don't quite understand
(09:50:13 PM) TimeVortex: Why are controllers/subs both orderer in their own directories *and* suffixed?
(09:50:19 PM) emanuele: lucky you it's just one...
(09:50:44 PM) emanuele: That's Norv fault! :P
(09:50:53 PM) TimeVortex: Is it?
(09:51:07 PM) ***TimeVortex goes to get his pitchfork

(09:53:36 PM) elk_core: [Elkarte] Spuds opened pull request #727: Likes Suggestion (master...lksg)  http://git.io/-aWbPQ

(10:16:44 PM) Norv: do you mean admin, TimeVortex (which is indeed kinda odd and it probably won't have any reasonable followup - except revert), or all /controllers ?
(10:17:36 PM) TimeVortex: Norv: indeed /controllers, /subs
(10:18:03 PM) Norv:  /subs also has .class.php
(10:18:16 PM) TimeVortex: Ah yes, it is mixed.
(10:18:24 PM) TimeVortex: But why the suffixes
(10:19:57 PM) TimeVortex: What's the rationale behind it?
(10:20:51 PM) Norv: We have the three layers: .template, .subs, .controller. To which you can count languages. templates are in /themes, and they are template.php. Subs were also suffixed, and I think keeping it is very easy to recognize.
(10:21:28 PM) Norv: Same goes for controllers. For addons, they'll likely be in the same directory, as long as they don't have many
(10:23:24 PM) Norv: I want them very easy to know where you are, what you are seeing, what you expect to see here. And the class names follow the file names (sort of). You couldn't have duplicates without controller suffix, when we [will] move on to make OOP other classes
(10:27:20 PM) Norv: They're like this: /controllers: Admin_Controller class, Admin.controller.php. Core (/sources): Dispatcher class, Dispatcher.class.php. /subs: Action class, Action.class.php; if procedural .subs.php. Templates: (same themes/default/) .template.php.
(10:28:49 PM) Norv: (oops, sorry, Admin wasn't a good example, any other will do)
(10:30:36 PM) Norv: There are no namespaces, and the names with _controller exclude duplicates. Also I think they look good.
(10:32:05 PM) Norv: Did the choice surprise you? I think it was obvious, coming from .template and -Subs and .[language].
(10:38:12 PM) Norv: As for directories, if we dont split them per pattern, I'm not sure how else. Because per component wasn't acceptable to people (they found extremely confusing and ugly); templates and languages are already this way and have to be; and they're too many to be kept together IMO. Again, for addons, it'd show what's supposed to be where.
(10:42:18 PM) Norv: (help them a bit do their own separation, or so I hope. Big addons [sub-sites] would have more of each, presumably similar sub-folders, and organizing them this way would IMHO help design them, and keep them easy to find/read)
(10:45:52 PM) TimeVortex: You're quite right, it does make them very easy to recognise, of course.
(10:46:39 PM) TimeVortex: It's just that it looks a bit... double, when you're in an editor that says "......./controllers/PersonalMessages.controller.php" at the bottom.
(10:47:08 PM) TimeVortex: But I guess most editors these days just show the file name in a tab at the top
(10:47:27 PM) ***TimeVortex still hinges on vim most of the time
(10:47:34 PM) TimeVortex: Flirting with SublimeText, though
(11:01:47 PM) ***Norv sighs. I guess someone needs this too. https://googledrive.com/host/0B6LMD0u8OhYYZEotN2QyR1hwR1k/vi-addict.html

(10:53:43 PM) ***Norv likes it when the Eclipse tree shows /controllers and the file name is .controller.php and the contents is doing the right thing. *nods*
(10:55:10 PM) Norv: Nah, tbh, I don't like it when looking at Recent.controller.php ............ :( The above was the goal.......
Title: Re: IRC
Post by: TestMonkey on July 21, 2013, 11:58:11 am
(07/21/2013 12:07:22 AM) elk_core: [Elkarte] emanuele45 opened pull request #728: Send ajax (master...send_ajax)  http://git.io/69xPjQ

(12:09:43 AM) groundup: My inbox was completely full of Elkarte Github notificatins. I had to stop watching it because of all the activity. That's a good thing :)
(12:10:57 AM) emanuele: Did you stop today?
(12:11:10 AM) emanuele: Because today Spuds was in a very good mood! xD
(12:11:12 AM) groundup: Yeah
(09:23:56 AM) Norv: groundup: you can choose in your notifications settings to not send email, only web updates.
Title: Re: IRC
Post by: TestMonkey on July 21, 2013, 11:58:55 am
(09:37:22 AM) elk_core: [Elkarte] eurich opened pull request #729: removed old variant, they are completely broken.. (master...old_variants)  http://git.io/34oaew

(09:54:25 AM) elk_core: [Elkarte] norv merged pull request #724: Elk is a no rodent software (master...norodents)  http://git.io/zlzBcg

(10:11:23 AM) elk_core: [Elkarte] eurich opened pull request #730: Guest can't "mark all messages as read", let's hide the button. (master...markread)  http://git.io/XRDQvA
(10:17:44 AM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/6WO9ww
(10:17:44 AM) elk_core: Elkarte/master 4a7b6e3 Thorsten Eurich: Guest can't "mark all messages as read", let's hide the button. Fixes #725...
Title: Re: IRC
Post by: TestMonkey on July 21, 2013, 11:59:39 am
(12:01:50 PM) Norv: > (07:10:48 PM) TimeVortex: "My account" linking to PMs feels a bit weird atm.
(12:01:50 PM) Norv: > (07:11:16 PM) TimeVortex: I suppose that'll relax if those areas (and menus) are merged? Not sure what the plan is.
(12:01:50 PM) Norv: Do you mean, "My Account" should either not link to PMs, either PMs area (pages) would share the same sidebar and all, become a single area with account stuff?
(12:03:41 PM) Norv: (I just realized that maybe that's what you meant. I had the same feeling on admin/mod.)
(12:36:13 PM) TimeVortex: That is what I meant, yeah.
(12:49:01 PM) Norv: Areas weren't meant to be merged, and I don't see how they could be, without becoming far too overloaded. I think what happened was that Ant killed a little too many buttons. Main 4 buttons leading to entire areas with subpages should probably be separated in the menu.
(12:50:09 PM) Norv: Even admin and mod... which overlap sometimes, on some subactions are very different. Mod center and admin center, still separate, makes sense IMHO.
(12:51:05 PM) Norv: YMMV... still, admin is full enough of stuffs lol.
Title: Re: IRC
Post by: TestMonkey on July 22, 2013, 03:22:04 pm
(10:59:15 PM) elk_core: [Elkarte] emanuele45 opened pull request #733: Maybe have the sort by things in a dropdown? (master...sort_drop)  http://git.io/TuHTng

(10:23:22 PM) ***emanuele goes search what standardTime contains... lol
(10:24:01 PM) emanuele: so just a call to standardTime, right?
(10:29:40 PM) TimeVortex: Well, for the relevant poster_time, yeah.

(11:12:47 PM) elk_core: [Elkarte] emanuele45 opened pull request #734: Quick-fix for an undefined index - Thanks Aaron (master...quick_fix)  http://git.io/gVO4AQ

(11:18:03 PM) TimeVortex: emanuele: isn't the first argument for standardTime a boolean?
(11:18:39 PM) TimeVortex: (I like how it sounds semi-sarcastic, btw. "Oh, we have an undefined index. Thanks, Aaron.")
(11:20:37 PM) emanuele: sorry, it didn't intend to be like that... :(
(11:23:39 PM) TimeVortex: emanuele: haha, no, really, I like how it's phrased

(11:22:41 PM) elk_core: [Elkarte] norv pushed 3 new commits to master: http://git.io/0lLXiQ
(11:22:41 PM) elk_core: Elkarte/master b5b2e58 Norv: Fix repair boards for polls missing topics....
(11:22:41 PM) elk_core: Elkarte/master 16b9000 Norv: Reports on boards permissions used the wrong conditions....
(11:22:41 PM) elk_core: Elkarte/master 271dc66 Norv: Use the db method on them smileys....

(11:23:03 PM) emanuele: At least my push -f arrived before Norv! :P
(11:23:19 PM) emanuele: Nope, the first is the time, then two booleans for today and something else...

(11:27:17 PM) elk_core: [Elkarte] norv pushed 2 new commits to master: http://git.io/OsFKug
(11:27:17 PM) elk_core: Elkarte/master 4fd4b3a emanuele: Quick-fix for an undefined index - Thanks Aaron for suggesting the fix...
Title: Re: IRC
Post by: TestMonkey on July 22, 2013, 03:22:28 pm

(11:52:34 PM) ***Norv is not a fan of smileys sets and message icons area.
(11:56:03 PM) emanuele: I'm not sure how many people actually use more than one (custom) smiley set
(07/22/2013 12:16:47 AM) Norv: For all I saw, I'm under the impression that few people are users, but those are real fans. :)

(12:18:27 AM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/GguE6w
(12:18:27 AM) elk_core: Elkarte/master 709d9cc Thorsten Eurich: function name was changed, let's use the new name....
(12:18:27 AM) elk_core: Elkarte/master 145ad2b Thorsten Eurich: blank line...
(12:18:27 AM) elk_core: Elkarte/master f0bd976 Thorsten Eurich: global wasn't used....

(02:14:14 PM) elk_core: [Elkarte] norv opened pull request #738: Tweaks and cleaning (master...qfix)  http://git.io/T37AqA
Title: Re: IRC
Post by: TestMonkey on July 22, 2013, 06:33:31 pm
(06:31:10 PM) elk_core: [Elkarte] emanuele45 opened pull request #740: A new class to handle "positioning" and its use in the poster area (master...expandable_profile)  http://git.io/t6RLyg

(06:45:12 PM) emanuele: Norv: have fun with my last PR! :P

(07:09:17 PM) elk_core: [Elkarte] norv synchronize pull request #738: Tweaks and cleaning (master...qfix)  http://git.io/T37AqA
(07:13:32 PM) elk_core: [Elkarte] norv synchronize pull request #738: Tweaks and cleaning (master...qfix)  http://git.io/T37AqA
(07:28:54 PM) ***emanuele feels the bot is going crazy...
(07:29:42 PM) Norv: Sorry! No, my bad. I am going crazy with Geany.
(07:30:07 PM) Norv: It keeps thinking it knows better, that we *have* to have an extra darned newline!
(07:30:14 PM) Norv: lol
Title: Re: IRC
Post by: TestMonkey on July 22, 2013, 08:16:36 pm
(07:56:46 PM) Norv: emanuele: oh. What do you have in mind, sections to add to the template?
(08:21:28 PM) emanuele: Not really, at the moment I'm trying to have a better control over few areas (including "button strips" and alike) and a (hopefully) better ways to extend those areas


(08:28:14 PM) Norv: Ehh. What can be in $user_profile which isn't linked to member_id?
(08:30:06 PM) emanuele: I'm totally confused by all these $user_{something} variables...
(08:30:22 PM) emanuele: Well... I'm more confused by their usage
(08:30:40 PM) emanuele: (i.e. when to use one and when to use another)
(08:31:12 PM) emanuele: $user_settings, $user_info, $user_profile, $memberContext
(08:32:08 PM) emanuele: http://www.elkarte.net/index.php?topic=459.0
(08:49:27 PM) Norv: yes. Inter's function way is a good idea... but I'm still wondering if we move that way, if it involves many changes with little benefit
(08:52:11 PM) Norv: The point is, if we try to centralize the information on user, and ask for it from everywhere else, we will be forced to also clean up the various user variables. If all or most the code uses functions, then those functions are a black box where we can make one or more classes with what we really need and dump the rest.
(09:03:32 PM) Norv: emanuele: Re: the topic. I suspect, for example, that password_salt is not in $user_info. And that's ok if we think that there's no need to carry it around, less error prone for one.
(09:04:11 PM) Norv: (I'm looking at ManageServer use of $user_settings)
(09:52:04 PM) Norv: Anyway, if the user isn't really created (or is being recreated), can't use $user_info. It isn't formed, or not reliable
Title: Re: IRC
Post by: TestMonkey on July 24, 2013, 11:41:06 pm
(12:01:38 AM) elk_core: [Elkarte] norv merged pull request #728: Send ajax (master...send_ajax)  http://git.io/69xPjQ

(07:48:35 PM) elk_core: [Elkarte] norv pushed 8 new commits to master: http://git.io/Z-euRw
(07:48:35 PM) elk_core: Elkarte/master e9e2aa9 Norv: Remove show_board_desc, it's default behavior to show descriptions....
(07:48:35 PM) elk_core: Elkarte/master 5b47e14 Norv: Remove option 'show_children'....
(07:48:35 PM) elk_core: Elkarte/master 976127b Norv: Cleanup conditions on display avatars....

(09:00:20 PM) elk_core: [Elkarte] norv merged pull request #688: This makes nicer the handling of layers in case of errors (master...fatal_errors)  http://git.io/lVPing
Title: Re: IRC
Post by: TestMonkey on July 24, 2013, 11:47:54 pm
(10:23:42 PM) elk_core: [Elkarte] norv merged pull request #694: Security checks (master...security_checks)  http://git.io/3zckQQ

(10:36:42 PM) Norv: Erm. Are you *sure* you want the BoardsManage-type of names, I mean reversed...? lol.
(10:37:10 PM) emanuele: As I said...who cares... :P
(10:39:14 PM) ***Norv is having second thoughts on the affected files and followup changes... Mkay I'm moving a bit more, but yeah, thinking to limit it at ManageBoards.controller
(07/24/2013 12:41:23 AM) Norv: Hmm. https://github.com/norv/elkarte/tree/rename_admin2/sources/admin
(12:44:01 AM) Norv: https://github.com/norv/elkarte/tree/rename_admin2/themes/default (a few Manage added)
Title: Re: IRC
Post by: TestMonkey on July 24, 2013, 11:48:07 pm
(10:40:30 PM) elk_core: [Elkarte] AaronVanGeffen opened pull request #745: The mysql_* functions are deprecated per PHP 5.5; let's switch to mysqli_*. Needs testing! (master...master)  http://git.io/XrYblA
(10:43:03 PM) TimeVortex: ^ I almost forgot to sign off, Norv. Almost!
(11:13:19 PM) Dragooon: I broke my mouse :'(
(07/25/2013 12:36:50 AM) Norv: TimeVortex: thank you! (mmm, double thanks, since it seems I forget too O:-))