ElkArte Community

Extending Elk => Localization => Topic started by: Jorin on July 10, 2014, 06:36:07 pm

Title: Transifex: uploaded files not actual?
Post by: Jorin on July 10, 2014, 06:36:07 pm
I translated a file locally on my computer and uploaded it to Transifex. But the file there online is not the one I uploaded - Online are for example 5 strings not translated, on my pc all strings are translated. It seems I'm to stupid for this stuff.  :-X :-[
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on July 10, 2014, 06:58:55 pm
I'm not a transifex expert as well.

Let's see: can you attach here the file you translated?

And did you upload the file to which one of the Germans? ("German" or "German Germany"?)

Also, I think "German Germany" is the "formal" German, trasnlated by forumsearch0r, while "German" is the one you were translating.
Title: Re: Transifex: uploaded files not actual?
Post by: Jorin on July 10, 2014, 10:01:58 pm
Here's a file with 5 lines untranslated online, but in this file all lines are translated.

Oh, really? I tried to upload my files to "german germany" because @TE changed them a few days ago and he said to me a while ago he will upload my whole package. Oops, I don't want to overwrite the files from forumsearch0r with my own.  :-[

Maybe better wait till TE has some time to help me with this? This gives me time to optimize the language files a litte bit more too.
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on July 10, 2014, 10:40:55 pm
Not a big problem, I'll re-upload the translation. ;)

The problem is that the "base" files you are using are not up-to-date.
For example, one of the strings that result untranslated from transifex is admin_main_welcome.
In your file the string is like this:
Code: [Select]
$txt['admin_main_welcome'] = '[...]Fällen dürfte bereits das <img src="' . $settings['images_url'] . '/helptopics.png" alt="%2$s" title="%3$s" /> Symbol weiterhelfen.';
This is the "old version", the problem with this string is that is it not "compatible" with transifex, and it was changed to something like:
Code: [Select]
You may also find answers to your questions or problems by clicking the <img src="%3$s/helptopics.png" alt="%2$s" title="%2$s" /> symbols for more information on the related functions.
So, even if you upload the file, transifex doesn't recognise it and fails.

And most likely all the other strings that result untranslated in transifex is because of that same problem.
If you want I can try to fix them for you, it's just a bit of an annoying work, that takes a while.
I'm not sure I can do it before the weekend though.
Title: Re: Transifex: uploaded files not actual?
Post by: Jorin on July 10, 2014, 10:54:11 pm
I don't get it. So the files I wish to upload mustn't be php files? 
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on July 10, 2014, 11:56:54 pm
You see the two strings I posted above?
They are different.
The problem is that one: the first is not understood by transifex, the second is.

In your file you have the first. ;)
Title: Re: Transifex: uploaded files not actual?
Post by: Jorin on July 11, 2014, 05:32:55 am
*lol* I know, Emanuele. I see the difference. What I don't understand is what the files I wish to upload must look like. Only the text part without:

$txt['admin_main_welcome'] = '

?
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on July 11, 2014, 09:02:39 am
No.
The problem is the "structure" of what is after.

Example:
Code: [Select]
$txt['a_string'] = 'something';
This is fine.

Code: [Select]
$txt['a_string'] = 'some' . 'thing';
This is *not* fine.
The string is interrupted by the thing ' . ' (single quote, dot, single quote) and transifex is not able to use it.
That is the only difference.

When your will have the strings with the "new" format, it will be recognised by transifex properly and the translation updated.

In the case I used as example the translation should become:
Code: [Select]
$txt['admin_main_welcome'] = '[...]Fällen dürfte bereits das <img src="%3$s/helptopics.png" alt="%2$s" title="%2$s" /> Symbol weiterhelfen.'; 
I remove part of the string to show exactly where the problem is. ;)
Title: Re: Transifex: uploaded files not actual?
Post by: Jorin on July 11, 2014, 09:05:32 am
Thanks a lot. Should I better correct all german language files this way? But I don't know the stuff like %2$s :-[
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on July 11, 2014, 09:09:19 am
You can check on transifex the untranslated strings, these should have some difference like that. Check the new string and adapt the translation accordingly, that should work. ;D
I re-uploaded the German (Germany) translation from forumsearch0r, I feel we should add some note or something to explain better the difference between the two. :)
Title: Re: Transifex: uploaded files not actual?
Post by: Jorin on July 11, 2014, 09:12:28 am
German (Jorinland)
de_DE.uft8.jorin

:D
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on July 11, 2014, 09:27:32 am
LOL
Title: Re: Transifex: uploaded files not actual?
Post by: forumsearch0r on July 15, 2014, 10:04:05 pm
Code: [Select]
$txt['credits_translators_message'] = 'Thank you for your efforts which make it possible for people all around the world to use ElkArte.  For a complete list please refer to the offical Transifex <a href="https://www.transifex.com/organization/elkarte/dashboard" target="_blank" class="new_win">list of contributors.</a>';

So we git contributors don't count anymore?
Title: Re: Transifex: uploaded files not actual?
Post by: phantom on July 15, 2014, 10:19:30 pm
There is another key for git contibutors
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on July 15, 2014, 10:25:05 pm
I guess that doesn't work also because is not accessible to non registered users.

heh...
Back to the manually edited variable?
Title: Re: Transifex: uploaded files not actual?
Post by: Spuds on July 15, 2014, 10:55:37 pm
Quote
I guess that doesn't work also because is not accessible to non registered users.
Yup, I mentioned that when I added the list to this sites front page ;)

I think at some point they (transifex) will have a "social" page that non-members can get to.  Till then we can either leave the link in place, manually add the list as created via the API on this sites home page, or add the link to the home page of the site in place of the transifex one.   I'm not really keen on the idea of manually adding names, the old SMF process of getting that sorted out is proof of that madness.

Quote
So we git contributors don't count anymore?
??? Its more likely that some folks will be listed in two places as the git contribution area is still in place.
Title: Re: Transifex: uploaded files not actual?
Post by: forumsearch0r on July 19, 2014, 04:32:24 pm
Back to the manually edited variable?

Seconded!
Title: Re: Transifex: uploaded files not actual?
Post by: Jorin on August 22, 2014, 05:32:16 pm
I need help - again!  :-[

I remember you changed a few weeks ago something in the english language files. I can't remember what. So, to check this with my local language files (I sure have to fix them too), where can I find the actual language files you changed?

Please, I can't work with Transifex. I have an account, yes, but I don't understand what to do there. There are two german language folders, and whenever I tried to upload a file there, it didn't work. Is there any chance to work with you guys on ElkArte and translate the files (and keep them updated) but not have to work with Transifex?  O:-)
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 22, 2014, 11:02:06 pm
Create a topic and attach the files you want to update.
I (or any other with enough karma) can upload them to the proper place.

The two German translations are the one you are working on ("German") and the one created by forumsearch0r ("German Germany").
Title: Re: Transifex: uploaded files not actual?
Post by: Jorin on August 23, 2014, 06:05:14 am
Thanks a lot, I will attach the package once it's 100% done.

Any hint on this?

I remember you changed a few weeks ago something in the english language files. I can't remember what. So, to check this with my local language files (I sure have to fix them too), where can I find the actual language files you changed?
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 23, 2014, 11:47:33 am
It really depends on "how many weeks"...

BTW, visiting:
https://www.transifex.com/projects/p/elkarte/translate/#de/$/26333401?translated=no
you can see all the strings that are not translated in Transifex.
If you want to see for each file what is "missing" you have two options at the moment: from transifex or from github.

From transifex:
* https://www.transifex.com/projects/p/elkarte/language/de/
* click on the file
* click on "Translate now"
* click on "untranslated"

From github:
* https://github.com/elkarte/Elkarte/commits/master/themes/default/languages/english
* for each "row" you can see the date when the change was applied
* if you click for example where it says "People can change the username... unfortunately" you can see the changes
* the lines in red are the ones "removed", the ones in green are those added[1]
Code: [Select]
Choose the name you want to login with.<br />This can\'t be changed later, but your display name can be.
has been removed the text
Code: [Select]
<br />This can\'t be changed later, but your display name can be.
,

hmm... I'm reading about github webhooks, I think we can setup a webhook that can post a message when a change to a language file is made. I have to investigate more.
Note that usually that simply means a word or something in the entire string has changed, the difference within a line is highlighted with a darker red and/or a darker green.
For example:
https://github.com/elkarte/Elkarte/commit/23e80c3d093c48c7fa54a0699c50f121ee538868
means that from the string:
Title: Re: Transifex: uploaded files not actual?
Post by: Jorin on August 23, 2014, 07:27:48 pm
It really depends on "how many weeks"...

BTW, visiting:
https://www.transifex.com/projects/p/elkarte/translate/#de/$/26333401?translated=no
you can see all the strings that are not translated in Transifex.

Okay, but I have the problem that I already translated a lot of the at Transifex untranslated stuff. I can't upload my files, so Transifex shows an old state. And this will be a problem in the future, because it seems I can't upload my files in the case of optimizing them or changing/update them after you did an update to the english ones.

What I need are all the changes in the strings in the language files you made after August 15th (that's the date the files have on my computer). Is there any way I can find or get them?
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 23, 2014, 08:10:11 pm
Can you open that topic and attach the files you have right now?
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 25, 2014, 12:19:01 am
I can't upload my files, so Transifex shows an old state. And this will be a problem in the future, because it seems I can't upload my files in the case of optimizing them or changing/update them after you did an update to the english ones.
You *can* upload the files, though it requires one more step: the name of the file that you upload must contain "english" and not "german". Yeah, oddity, but that's how transifex works and that's how the Elk language files are called.
It can be fixed on our side, though I'm not entirely convinced to have the names without the language inside.

Now the transifex translation is updated.
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 25, 2014, 12:41:20 am
Also, while uploading the files I noticed one was missing: MaillistTemplates.english.php
It's now in the repo.

@ahrasis @phantom @CrimeS maybe others, but I can't map the names at transifex with the names here.
Title: Re: Transifex: uploaded files not actual?
Post by: Jorin on August 25, 2014, 11:43:08 am
You *can* upload the files, though it requires one more step: the name of the file that you upload must contain "english" and not "german". Yeah, oddity, but that's how transifex works and that's how the Elk language files are called.
It can be fixed on our side, though I'm not entirely convinced to have the names without the language inside.

So you mean it's your idea we use index.english.php no matter what language is inside this file?  :o
Title: Re: Transifex: uploaded files not actual?
Post by: Jorin on August 25, 2014, 07:07:38 pm
Help! I translated the latest missing point in ManageSettings.english.php in the german language pack at Transifex. Now it says to me that all files are translated, but a lot of them are not proofed (or tested, don't know what it's called in english). @emanuele , if you uploaded all my files to this folder in Transifex, can you set all files (except Help.english.php) to 100% translated and 100% proofed? I don't know if and where I can do this.  :-[
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 25, 2014, 09:10:11 pm
Don't worry about the review, it's not something we need to care about unless we want.
For example I (personally) am using it for the Italian translation just to keep track of the strings that I were already imported and that I have checked.
But it's not important, once it is translated the files are updated accordingly and nothing else is needed.
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 25, 2014, 09:24:15 pm
You *can* upload the files, though it requires one more step: the name of the file that you upload must contain "english" and not "german".
Actually, I was plain wrong: it works even if the file has another name...
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 25, 2014, 09:26:15 pm
@Spuds question: the $txt['via'] should really be translated?
Could it be that if it is changed yahoo! and alike may not understand its meaning?
Title: Re: Transifex: uploaded files not actual?
Post by: Spuds on August 25, 2014, 11:36:56 pm
@Spuds question: the $txt['via'] should really be translated?
Could it be that if it is changed yahoo! and alike may not understand its meaning?
That is a good question, unfortunately I lack a good answer !   Given its a draft spec, at this point leaving it untranslated may be the best course of action.  We can add a comment in the language file of // don't translate this string

Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 26, 2014, 12:22:13 am
Then I think it's better to just remove the string from the language file, safer for everybody... provided the providers do not mess again with that stuff... lol
We can keep the $txt with a comment in the code.
Or keep it, and override it just after having loaded the file, but that looks a bit ugly. :-\
Title: Re: Transifex: uploaded files not actual?
Post by: ahrasis on August 27, 2014, 02:05:18 pm
No problem. Will look after that soon.
Title: Re: Transifex: uploaded files not actual?
Post by: Spuds on August 27, 2014, 10:57:25 pm
Then I think it's better to just remove the string from the language file, safer for everybody... provided the providers do not mess again with that stuff... lol
We can keep the $txt with a comment in the code.
Or keep it, and override it just after having loaded the file, but that looks a bit ugly. :-\
Lets leave it in the $txt strings for now, but "hard code" it in to sources with a comment.  That way should we learn more we will have the translations available.  Its real purpose is so that email programs don't learn a bogus address for a given name.
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 28, 2014, 12:08:17 am
Oook!
I'll add it to the next PR with the fix to the user title width/alignment.
Title: Re: Transifex: uploaded files not actual?
Post by: emanuele on August 28, 2014, 11:51:56 pm
And here it is: https://github.com/emanuele45/Dialogo/commit/b9eeda4d44c2eab8a33f25ee8d93984f0e5f40fb
Title: Re: Transifex: uploaded files not actual?
Post by: Spuds on August 29, 2014, 12:42:56 am
I feel thats the best thing for the time being, as we learn more / get a real spec we can update as required.