ElkArte Community

Elk Development => Theme development => Theme development archive => Topic started by: Joshua Dickerson on January 27, 2014, 02:56:26 pm

Title: No title on like button
Post by: Joshua Dickerson on January 27, 2014, 02:56:26 pm
Eh, why doesn't the like button have a title? That star isn't really intuitive. The title attribute is just "title" (empty).
Title: Re: No title on like button
Post by: Spuds on January 27, 2014, 08:34:39 pm
You mean the hover title?
Or the lack of "Like text" after the icon?

I don't recall all the thoughts on why the text after the button was removed, I think it was during one of our minimalist phases and several designs were tried.  And it could just be a mistake as well!

After a post is liked, it will show the Star icon and then X Likes as the text after the icon.  It will also, when you hover, show the names of who liked the post.  If you liked the post the little + on the icon becomes a - on the star icon as well. 

When there are no likes we could add in the text Like after it, as well as for the hover text.  I'll do whatever the likers want :D


Title: Re: No title on like button
Post by: emanuele on January 27, 2014, 10:40:10 pm
When there are no likes we could add in the text Like after it, as well as for the hover text.  I'll do whatever the likers want :D
Pay attention to what you write. :P
Well, for consistency I think it make sense to have the text in it... or remove it from everywhere, but I think this may be a bit confusing...
Title: Re: No title on like button
Post by: Joshua Dickerson on January 28, 2014, 12:18:58 am
I mean the title attribute. I don't care so much about the text in there so long as I can figure it out with a mouseover. Though, "Like" or something might be helpful to many people.
Title: Re: No title on like button
Post by: Joker™ on January 28, 2014, 02:11:25 am
Ummm, just dropping by, anyone in mood of ajaxifying the likes functionality?

/me Raises his hand
Title: Re: No title on like button
Post by: Spuds on January 28, 2014, 02:52:27 am
Woot  :D Please do!  it was on the todo list, but its a long list ! 

Some of the other buttons were converted over to ajax, I think they use the ;api option, @emanuele can give more details of how that works.
Title: Re: No title on like button
Post by: emanuele on January 28, 2014, 07:06:32 pm
At the moment I have mixed feeling about that api thing TBH...
I'm not sure if it is worth the hassle or not. :(
I thought it was, but then I realised it's also a "good" duplication of the xml stuff, I'm not sure I have the "whole" overview Norv had about it.
Title: Re: No title on like button
Post by: IchBin on January 28, 2014, 11:51:09 pm
Ummm, just dropping by, anyone in mood of ajaxifying the likes functionality?

/me Raises his hand

Yes, please do!! :D
Title: Re: No title on like button
Post by: Joker™ on February 03, 2014, 05:24:12 pm
Started working on likes (https://github.com/siddhartha-gupta/Elkarte/commits/likes) :D
Title: Re: No title on like button
Post by: Joker™ on February 15, 2014, 02:08:49 pm
Back :D

Lol, while converting the code I came across this text, and TBH it's one of the hilarious one I found so far

Quote
Liking your own posts ... its like laughing at your own jokes when there is no one else around  ... lol ... Wait did I just lol myself?

Tell me I can put this on facebook?
Title: Re: No title on like button
Post by: Joker™ on February 15, 2014, 06:11:10 pm
Another update on this

- In terms of liking/unliking posts in topic this complete
- JS simply makes a call to PHP and all text, like counts etc info is transferred via PHP, to make text stings editable
- Also made something which I've currently termed as floating error box. It is somewhat similar to other pane's I've created for few of my SMF mods, where user can hide the box by clicking anywhere or pressing the escape key.

For more info jump here (https://github.com/siddhartha-gupta/Elkarte/commits/likes).
Title: Re: No title on like button
Post by: [SiNaN] on March 04, 2014, 01:33:59 pm
An issue somewhat related to this; currently it's not easy to see the difference between liked posts and posts with no likes. I mean it looks the same as "xx Likes" (on another note, it might be better to have it all lowercase there) and "Like Post". I don't have any ideas as how it could be made any better but just saying.