Skip to main content ↑ ↓
Broken URL Started by meetdilip · · Read 12740 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Re: Broken links in email

Reply #17 –

Emails are sent in markdown.
According to the email specification:
ftp://ftp.rfc-editor.org/in-notes/rfc3986.txt
long URLs should be delimited by preference with angle brackets:
Code: [Select]
<ftp://ftp.rfc-editor.org/in-notes/rfc3986.txt>
the issue could be that email clients do not really understand markdown, especially for joining back pieces of URLs.

I wonder if at some point we could start sending (at least some) emails in html (with an option to have those in plain text :P), just because it would be easier to deal with and, even though I find them annoying, nowadays it is probably kind of expected to have fancy emails.
Bugs creator.
Features destroyer.
Template killer.

Re: Broken links in email

Reply #18 –

Quote   In practice, URIs are delimited in a variety of ways, but usually
   within double-quotes "http://example.com/", angle brackets
   <http://example.com/>, or just by using whitespace:

Re: Broken links in email

Reply #19 –

I accessed my email using browser.  I have seen some websites give password reset code and then the reset link below. People can either enter reset code or use reset link. In this case a reset code + password reset page link would be great ( in my opinion ).

Re: Broken links in email

Reply #20 –

hmm... Wait.

This kind of emails I think are not even processed in markdown, only body messages of the notification emails are.
This reminds me of some providers that "for fun" url_encode all the urls breaking them at will.

What provider are you using?
Bugs creator.
Features destroyer.
Template killer.

Re: Broken links in email

Reply #22 –

As I  said in the other topic I get broken links on Hotmail ONLY if the email is marked as spam
sorry for my bad english

Re: Broken links in email

Reply #23 –

And if you tell hotmail that is not spam, did the link get back together or does it remain broken?
Bugs creator.
Features destroyer.
Template killer.

Re: Broken links in email

Reply #24 –

Yes, once marked as clean the links are working
sorry for my bad english

Re: Broken links in email

Reply #25 –

As we discussed before it is a local provider called Rediffmail. The point is, emails ( especially password recovery ) are having broken links with more than one email providers. And it needs to be addressed.

Re: Broken links in email

Reply #26 –

Hmm... can we check if using & instead of ; as the delimiter works?

Re: Broken links in email

Reply #27 –

Quote from: meetdilip – As we discussed before it is a local provider called Rediffmail. The point is, emails ( especially password recovery ) are having broken links with more than one email providers. And it needs to be addressed.
As we discussed before, I can't test this provider because it asks a phone number, and I'm not going to put my phone on the internet (no, not even google has it), if you can point to an email provider with the same issue that doesn't ask for my phone number I can test, otherwise... thanks for volunteering in testing that one. ;D
Try with the following code, in Mail.subs.php, find:
Code: (find) [Select]
	foreach ($replacements as $f => $r)
	{
		$find[] = '{' . $f . '}';
		$replace[] = $r;
	}
and replace it with:
Code: [Select]
	foreach ($replacements as $f => $r)
	{
		$find[] = '{' . $f . '}';
		if (strpos($f, 'LINK') !== false || strpos($f, 'URL') !== false)
			$r = str_replace(';', '&', $r);
		$replace[] = $r;
	}
Let me know if it breaks again. ;)

Quote from: meetdilip – I have seen some websites give password reset code and then the reset link below. People can either enter reset code or use reset link. In this case a reset code + password reset page link would be great ( in my opinion ).
Most likely this would break the same way because the url would be:
Code: [Select]
http://www.elkarte.net/community/index.php?action=reminder;sa=setpassword;u=162
so (even though it should really be present) it would be useless.

Spoiler (click to show/hide)
Bugs creator.
Features destroyer.
Template killer.
 

Re: Broken URL

Reply #28 –

Will volunteer. A bit occupied with RL. :)