Re: Inconsistent Hook Names
Reply #1 –
Not really a bug, but consistency is good. In Post.subs.php createPost()
True, consistency is good.
integrate_create_post <= Just before a post is created
integrate_after_create_post <= Just after a post is created.
integrate_before_create_topic <= Equivalent to integrate_create_post, but this one gets a before
integrate_create_topic <= Equivalent to integrate_after_create_post, but looks like integrate_create_post
I'd say:
integrate_create_post => integrate_before_create_post
integrate_after_create_post => integrate_create_post
So that the scheme is the same?
There's also two integrate_modify which I believe are equivalent to integrate_create_post, so it's probably the topic ones that maybe should be renamed.
Yes and no.
integrate_before_create_topic and integrate_modify_topic could be the same (even though there are differences on the kind of data passed), while integrate_modify_post and integrate_create_post are slightly different even in the parameters passed (create has one more).
It may be worth harmonize the parameters order in all these hooks...?