Skip to main content
Topic: [Bug] Quoting to quick reply haz major bugz (Read 6820 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

[Bug] Quoting to quick reply haz major bugz

Just try quoting a post that contains other quotes. Gives a "message body empty" error. 

FF17, W7.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Bug] Quoting to quick reply haz major bugz

Reply #1
[quote author="Antechinus" date="1354758577" link=topic="12.msg31#msg31"]
Just try quoting a post that contains other quotes. Gives a "message body empty" error.

FF17, W7.[/quote]

Does it.
The best moment for testing your PR is right after you merge it. Can't miss with that one.


Re: [Bug] Quoting to quick reply haz major bugz

Reply #3
w/o the full editor test

ETA worked fine
some stuff going on with da full .... but it still worked OK?
Be safe, Be kind, Happy Programing


Re: [Bug] Quoting to quick reply haz major bugz

Reply #5
[quote author="Spuds" date="1354763372" link=topic="12.msg36#msg36"]
How about on by default?[/quote]qr -preview -post test  ... worked fine?  confused :P
Be safe, Be kind, Happy Programing

Re: [Bug] Quoting to quick reply haz major bugz

Reply #6
[quote author="Spuds" date="1354763247" link=topic="12.msg35#msg35"]
some stuff going on with da full .... but it still worked OK?[/quote]

Sorta... but:
  • You can't make embedded quotes
  • preview isn't working the first time you click 'preview': it displays nothing
  • [trivial"'The message has the following error or errors that must be corrected before continuing: Warning - while you were typing 2 new' - this message is too worrying for a poor update notice...

Okay the second two have nothing to do with this topic.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: [Bug] Quoting to quick reply haz major bugz

Reply #7
Save another draft... if you can.
Update: it replaces the old, when you keep writing. Okay, but then, the section 'Load drafts' ... wait.


On a different note,
Is it only me or the icons in quick reply (full editor) are far too big? Same for standard post page. (ignore if it's only me)
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: [Bug] Quoting to quick reply haz major bugz

Reply #8
[quote author="TestMonkey" date="1354762507" link=topic="12.msg32#msg32"]
Does it.[/quote]
Lesse if it does it again.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Bug] Quoting to quick reply haz major bugz

Reply #9
[quote author="Antechinus" date="1354772255" link=topic="12.msg45#msg45"]
Lesse if it does it again.[/quote]
Code: [Select]
	// Show information about events, birthdays, and holidays on the calendar.
if ($context['show_calendar'])
{
echo '
<li class="smalltext">';
[quote author="Antechinus" date="1354772255" link=topic="12.msg45#msg45"]
Lesse if it does it again.[/quote]
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Bug] Quoting to quick reply haz major bugz

Reply #10
Aha! Ok, reproduced it. Try quoting the post above this. The one with quote followed by code followed by quote. ;)

Oh and also note that the quoteheader links are broken. Formatting is up the poo and the link aint linked.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Bug] Quoting to quick reply haz major bugz

Reply #11
[quote author="TestMonkey" date="1354764527" link=topic="12.msg42#msg42"]On a different note,
Is it only me or the icons in quick reply (full editor) are far too big? Same for standard post page. (ignore if it's only me)[/quote]
It's only you. They're a pretty good size IMO. FFS, http://en.wikipedia.org/wiki/Fitts%27s_law

Quote
Fitts' law (often cited as Fitts's law) is a model of human movement primarily used in human–computer interaction and ergonomics that predicts that the time required to rapidly move to a target area is a function of the distance to the target and the size of the target. Fitts's law is used to model the act of pointing, either by physically touching an object with a hand or finger, or virtually, by pointing to an object on a computer monitor using a pointing device. It was proposed by Paul Fitts in 1954.

If, as generally claimed, the law does hold true for pointing with the mouse, some consequences for user interface design include:
  • Buttons and other GUI controls should be a reasonable size; it is relatively difficult to click on small ones.

 
The current icons and buttons should not be made any smaller. If any change was going to be made, I would make them bigger. In fact for general usability there is much to be said for padding out the smileys to match the size of the toolbar buttons. This can be done with a visible background, or just by adding css padding to the images themselves.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Bug] Quoting to quick reply haz major bugz

Reply #12
Code: [Select]
	// Show information about events, birthdays, and holidays on the calendar.
if ($context['show_calendar'])
{
echo '
<li class="smalltext">';
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: [Bug] Quoting to quick reply haz major bugz

Reply #13
Aha! Ok, reproduced it. Try quoting the post above this. The one with quote followed by code followed by quote. ;)

Oh and also note that the quoteheader links are broken. Formatting is up the poo and the link aint linked.
The quoteheaader link is a problem with sceditor. 

I've put a temp patch in place but the official fix from Sam will be a couple of days out.  Basically when you swapped in and out of source->wizzy->source the attributes would get wrapped in quotes.  So author=Antechinus  would become author="Antechinus" and so on with all the attributes.  Then parse_bbc would not know what to do cuz its parse_bbc you see.

I'll work on the preview not working first time next :)
Be safe, Be kind, Happy Programing

Re: [Bug] Quoting to quick reply haz major bugz

Reply #14
Thank you! :D

Surprise from 1.4.0 looks like  8)
The best moment for testing your PR is right after you merge it. Can't miss with that one.