Skip to main content
Topic: [ADDON][WIP] In Line Attachments (Read 21893 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: [ADDON][WIP] In Line Attachments

Reply #30
I know this addon is wip, but in the future would be nice to have responsive images inserted with  [attachimg=x]
Please remember about this, maybe is just a simple trick with css, but I don't know how to solve it
sorry for my bad english

Re: [ADDON][WIP] In Line Attachments

Reply #31
I posted the original in the wrong topic... sorry.


A similar approach to the one for normal images would be to edit ILA.subs.php this way:
Code: (find) [Select]
							<img src="' . $this->_attachment['href'] . ';image" alt="' . $uniqueID . '" title="' . $ila_title . '" id="thumb_' . $uniqueID . '" style="width:' . $this->_curr_tag['width'] . 'px;" />
</a>';
else
$inlinedtext = '<img src="' . $this->_attachment['href'] . ';image" alt="" title="' . $ila_title . '" id="thumb_' . $uniqueID . '" style="width:' . $this->_curr_tag['width'] . 'px;" />';
Code: (replace with) [Select]
							<img class="bbc_image resize" src="' . $this->_attachment['href'] . ';image" alt="' . $uniqueID . '" title="' . $ila_title . '" id="thumb_' . $uniqueID . '" />
</a>';
else
$inlinedtext = '<img class="bbc_image resize" src="' . $this->_attachment['href'] . ';image" alt="" title="' . $ila_title . '" id="thumb_' . $uniqueID . '" />';

TBH I'm not sure about the name of the classes amd I can't find a bbc image at the moment sorry.
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON][WIP] In Line Attachments

Reply #32
I tried but the imge goes out of the forum layout. That code ignore the width tag
ex:
Code: [Select]
[attachimg=1 width=800]
sorry for my bad english

Re: [ADDON][WIP] In Line Attachments

Reply #33
:-[

Looks like I have to better study the code... sorry.
Bugs creator.
Features destroyer.
Template killer.


Re: [ADDON][WIP] In Line Attachments

Reply #35
I'm having a little problem with this addon, yesterday I was watching my drafts and I sow 15 pages of drafts, I tried to go to next page of drafts but an error showed. In elkarte error log I see:
Code: [Select]
 Tipo di errore: Critico
Wrong value type sent to the database. Integer expected. (msg)
Function: _ila_get_topic  URL http://www.skodaclub.it/index.php?action=profile;area=showdrafts;u=1
File: /../../skodaclub.it/sources/subs/ILA.subs.php
Riga: 729
I tried to delete my drafts, but I was not able.

Now I cannot see my drafts, when I go in drafts I see Wrong value type sent to the database. Integer expected. (msg)
In error log I got the same error above. How could I solve this?
sorry for my bad english

Re: [ADDON][WIP] In Line Attachments

Reply #36
I'll take a look at this today ... sorry for the delay !
Be safe, Be kind, Happy Programing

Re: [ADDON][WIP] In Line Attachments

Reply #37
hi,
there is a problem
do not add adds new bbcodes

I tested  wamp server and active host
sorry for my bad english

Re: [ADDON][WIP] In Line Attachments

Reply #38
Another WIP addon,
Whats missing is the easy tag placement in the editor, so for now you have to add an attachment as normal, and then in the text, enter the ILA tag where you want the image to display. 

I'm not sure what direction I may take with the editor, so for now .....
sorry for my bad english

Re: [ADDON][WIP] In Line Attachments

Reply #39
Hi,

I'm sorry I got it wrong.

the fact that the example in the picture 

I would hope that in the new version :)

(sorry my english very bad)
sorry for my bad english

Re: [ADDON][WIP] In Line Attachments

Reply #40
Good suggestion ... was thinking along those lines as well. 
Be safe, Be kind, Happy Programing

Re: [ADDON][WIP] In Line Attachments

Reply #41
With @Spuds blessing I started looking at integrate this into 1.1 and the current step in terms of code is here: https://github.com/emanuele45/Dialogo/tree/ila
While attached to this topic an example of the current result. O:-)
Clicking the icon the tag is automagically inserted into the editor.

There are a couple of potential issues here and there (still), but hopefully before 1.1 final is released will be fixed! ;D

ETA: one of those issues is that I don't like the icon I picked. LOL
Any fontawesome suggestion would be awesome! :D
Bugs creator.
Features destroyer.
Template killer.

Re: [ADDON][WIP] In Line Attachments

Reply #42
That is a great news! I love the idea. Most forums have this into core, even Kunena ;)

If could be useful a screenshot from XF:
sorry for my bad english

Re: [ADDON][WIP] In Line Attachments

Reply #43
Looking good :D ...

RE the icon ... maybe the anchor or the file-image-o ?
Be safe, Be kind, Happy Programing

Re: [ADDON][WIP] In Line Attachments

Reply #44
For the moment I unified the "uploaded attachments" and the "newly uploaded" interfaces, so that now all are show the same way! Having just one interface it becomes easier to deal with changes. O:-)

Have a look at XF interface is handy for sure! :D
What I think we should do is (even though we are going a little OT but I hope Spuds will not kick us from the topic... O:-)):
1) drop the 100% progressbar, when the file is uploaded is a bit useless;
2) add the thumbnail;
3) I was using icons to avoid words for consistency (and because it's usually easier for translation, theming and coding :P), but maybe words are the best option?
Bugs creator.
Features destroyer.
Template killer.