[RC1] attach a file: "drop_area_fileselect

[RC1] attach a file: "drop_area_fileselect_text"? Started by Jorin · June 25, 2014, 01:07:18 pm · Read 3653 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

[RC1] attach a file: "drop_area_fileselect_text"?

June 25, 2014, 01:07:18 pm

I translated the string:

Code: [Select]

$txt['attach_drop_files'] = 'Dateien durch Drag&Drop hinzufügen oder <a class="drop_area_fileselect_text" href="#">hier klicken</a>';

...in post.english.php. Now we are experiencing some problems. It seems you are not using the text as a link? There seems to be an area in the right of the window to be clickable? Same problem here btw. You can see that the mouse cursor isn't changing if you move it over the text "selecting them". This behaviour confuses us, we don't know where to click exactly and some of us can't attach a file because they don't find the right spot to click.

Is this a bug?

Sorry for my bad english.

Re: [RC1] attach a file: "drop_area_fileselect_text"?

Reply #1 – June 25, 2014, 02:28:22 pm

I can see the cursor changing to pointer here...
It's done via css, did you update index.css as well?
Should be there since a while, anyway, fo you have:

Code: [Select]

.drop_area_fileselect {
    cursor: pointer;
    margin-left: -190px;
    opacity: 0.0001;
    position: absolute;
    width: 220px;
}

in index.css?

Re: [RC1] attach a file: "drop_area_fileselect_text"?

Reply #2 – June 25, 2014, 03:03:48 pm

Hm, I'm using chrome browser (version 35.0.1916.153 m) and Windows 7. Here's a video capture of the behaviour of elkarte.net on my computer. Keep eye on the mouse cursor please.

http://temp.joerghelfmann.de/attaching.avi

Re: [RC1] attach a file: "drop_area_fileselect_text"?

Reply #3 – June 25, 2014, 03:16:49 pm

It seems Chrome shows the cursor only on the padded area.
Try adding:

Code: [Select]

padding-left: 220px;

to the .drop_area_fileselect declaration in index.css, so that it looks like this:

Code: [Select]

.drop_area_fileselect {
	cursor: pointer;
	margin-left: -190px;
	opacity: 0.0001;
	position: absolute;
	width: 220px;
	padding-left: 220px;
}

Re: [RC1] attach a file: "drop_area_fileselect_text"?

Reply #4 – June 28, 2014, 09:03:48 am

I applied it:
https://github.com/emanuele45/Dialogo/commit/5a8faa7a4ccaba50d64755e1a3679de4e4c8dea2

Re: [RC1] attach a file: "drop_area_fileselect_text"?

Reply #5 – June 28, 2014, 09:30:41 pm

Seems to work for me in a quick test