attachmentz

Topic: attachmentz (Read 1737 times) previous topic - next topic

0 Members and 1 Guest are viewing this topic.

Follow-ups
- Re: attachmentz

attachmentz

December 07, 2012, 08:31:50 pm

Re: attachmentz

Reply #1 – December 08, 2012, 01:05:15 am

$:-\$ attach....

# enable extensive checks
# attach a file that will fail

=> error message (expected)
=> the post went through... (unexpected)

Re: attachmentz

Reply #2 – December 08, 2012, 01:07:45 am

without extensive checks.

Re: attachmentz

Reply #3 – December 09, 2012, 06:51:59 pm

Quote from: TestMonkey - December 08, 2012, 01:05:15 am

$:-\$ attach....

# enable extensive checks
# attach a file that will fail

=> error message (expected)
=> the post went through... (unexpected)

Yes ... interesting that ... the error page that shows up with continue / back on an attachment error is after the system has posted whatever it could ... continue and you are done, back and you are modifying an existing message.

So now with an attachment error you do not loose your post but something does not seem quite right ....

Re: attachmentz

Reply #4 – September 23, 2013, 10:01:22 pm

I think the reason is/was that the checks on the attachments are done *after* the message is saved.
Now the checks are all done before, but the errors are added after, so now I'm trying to fix the behaviour.

Re: attachmentz

Reply #5 – September 25, 2013, 10:02:09 pm

https://github.com/elkarte/Elkarte/pull/832

Re: attachmentz

Reply #6 – September 26, 2013, 12:23:23 am

Holy crap, look at all those PR's ... your a wildman ... and I like it !

Re: attachmentz

Reply #7 – September 26, 2013, 12:30:07 am

emanuele feels we need more tests... lol

...but then we should run them and fix the bugs...nahh let's go on like that for another wile.