Skip to main content ↑ ↓
Topic: attachmentz (Read 1910 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: attachmentz

Reply #1 –
:-\ attach....

# enable extensive checks
# attach a file that will fail

=> error message (expected)
=> the post went through... (unexpected)
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: attachmentz

Reply #2 –
without extensive checks.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: attachmentz

Reply #3 –
Quote from: TestMonkey  - 
:-\ attach....

# enable extensive checks
# attach a file that will fail

=> error message (expected)
=> the post went through... (unexpected)
Yes ... interesting that ... the error page that shows up with continue / back on an attachment error is after the system has posted whatever it could ... continue and you are done, back and you are modifying an existing message.

So now with an attachment error you do not loose your post but something does not seem quite right ....
Be safe, Be kind, Happy Programing

Re: attachmentz

Reply #4 –
I think the reason is/was that the checks on the attachments are done *after* the message is saved.
Now the checks are all done before, but the errors are added after, so now I'm trying to fix the behaviour.
Bugs creator.
Features destroyer.
Template killer.

Re: attachmentz

Reply #6 –
Holy crap, look at all those PR's ... your a wildman ... and I like it !
Be safe, Be kind, Happy Programing

Re: attachmentz

Reply #7 –
 emanuele feels we need more tests... lol

...but then we should run them and fix the bugs...nahh let's go on like that for another wile. :P
Bugs creator.
Features destroyer.
Template killer.