Skip to main content ↑ ↓
Preparing 1.0.3 release Started by emanuele · · Read 11739 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Preparing 1.0.3 release

Does any of you remember any change in the 1.0.3 code that admins should be reminded about or that requires admin actions?
Bugs creator.
Features destroyer.
Template killer.

Re: Preparing 1.0.3 release

Reply #1 –

Do new text strings count?

Re: Preparing 1.0.3 release

Reply #2 –

hmm... do we have new strings? I missed them... :-[

I was thinking about things like the avatars for 1.0.2, where admins were supposed to check the settings and fix anything not good for them.
Bugs creator.
Features destroyer.
Template killer.

Re: Preparing 1.0.3 release

Reply #3 –

Ah ... not that I can think of (wrt a settings change that the admin needs to know about)

Just a few text strings, nothing major.
$editortxt['Close'] = 'Close';
$txt['pm_approve_warning'] = 'Approve this personal message with CAUTION!
   The PM being replied to has been REMOVED.
   The system attempts to find others in that conversation but the results are not 100% accurate.
   If in doubt, its better to bounce!';
$txt['mentions_what'] = 'Message';
$txt['whoall_pm_byemail'] = 'Sending a personal message by email.';
$txt['mark_these_as_read'] = 'Mark THESE messages as read';

We should also update define('CACHE_STALE', '?102'); to 103 I believe, I think we had a couple of JS changes? (had to look, thats a yup :P)

Re: Preparing 1.0.3 release

Reply #4 –

Ouch!
Forgot about the stale... :-\
Bugs creator.
Features destroyer.
Template killer.

Re: Preparing 1.0.3 release

Reply #5 –

Updated the stale and I have the patch ready.
I just don't have a clean forum to test it. xD

Well, I attached it here, I'm not sure it even works, so test with care. ;)

ETA: removed the patch to avoid confusion.
Last Edit: March 13, 2015, 06:09:38 pm by emanuele
Bugs creator.
Features destroyer.
Template killer.

Re: Preparing 1.0.3 release

Reply #6 –

Couple of small bugs that need to be fixed, will update tomorrow ...

one simple on is the language edits need to point to /english/ in the .xml file.  One edit is missing but I think I forgot to update one area with the new langauge string :(

Also the unzipo and untgz files are placed in /sources/sources/subs instead of /sources/subs

Also seeing the following in a quick test
Undefined index: href
/public_html/forum/sources/Subs.php
Line: 2562
      
Undefined index: image
public_html/forum/sources/Subs.php
Line: 2563
Last Edit: March 12, 2015, 11:14:08 pm by Spuds

Re: Preparing 1.0.3 release

Reply #8 –

I won't be able to touch it until Sunday (if I will be able on Sunday).

New language strings may count in the sense of "hey admin there are new strings, if you have another language you should consider updating it[1]".
A short notice may be worth, to consider.
1 Provided language strings have been translated to the language, of course. And yes, that brings us back to the topic to inform people doing translations that I guess it was not updated. Honestly I lost track of strings on this round, so I have no idea.↵
Bugs creator.
Features destroyer.
Template killer.

Re: Preparing 1.0.3 release

Reply #9 –

Here is an updated package that fixes the install errors that I noted above.

However:
- It does not have the PR that I submitted to tweak a couple areas, that can wait to 1.0.4 as well
- It does not fix the undefined errors that I was getting as noted above, have not had time to look at that :(

Re: Preparing 1.0.3 release

Reply #10 –

 emanuele marks as unread
Bugs creator.
Features destroyer.
Template killer.

Re: Preparing 1.0.3 release

Reply #11 –

Found the undefined index issue.
In a couple of cases, determineAvatar returns an empty array, and this is the cause of the undefined index.

About the fix: one way to fix it would be to always return an array of data, but I feel in some cases the avatar index is checked as not empty, and returning something would break these checks.
So, for 1.0.3 I'd just add a pair of !empty to the new code in Subs.php.
Bugs creator.
Features destroyer.
Template killer.
 

Re: Preparing 1.0.3 release

Reply #12 –

!empty() it is then :D

Re: Preparing 1.0.3 release

Reply #13 –

:D

I'm finishing to add stuff to the xml.
I'll upload a new version before evening (CET).
Bugs creator.
Features destroyer.
Template killer.

Re: Preparing 1.0.3 release

Reply #14 –

Faster than expected.

Attached a new version of the patch. :D

I'll start committing this to the repo, so there is a starting point (and hopefully and ending one).

I moved the milestone at github to Thursday (the 19th), though, if there are no other issues it can be released.