Skip to main content
Topic: [Theme] Storm Cloud (Read 2633 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

Re: [Theme] Storm Cloud

Reply #15
It may be coming from theme.js .... if you are using Pale Moon it (when I did this at least) did not support css "cover" properly ... so I had to jack it up with some JS  :'(  O:-)
Squish squish. squish, squish, squish.
Find a bug,
Make a wish.

Re: [Theme] Storm Cloud

Reply #16
Ok. So why not just make the anchor roundy and give it hidden overflow? Then just set image width to 100px and height to auto. Should work.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Theme] Storm Cloud

Reply #17
Ooh dear. I made the mistake of looking at this one on an iPhone sized-screen. It gets more than a tad messy. Given that I never browse on mobile anyway, you may be reaching the limits of my enthusiasm for debugging there. If I'm going to have to put serious work in, I might as well roll my own themes.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Theme] Storm Cloud

Reply #18
Just making the anchor roundy and setting hidden overflow works. No need for object-fit or javascript. CSS just needs this:

Code: [Select]
.poster_avatar .linklevel1 {
overflow: hidden;
display: block;
height: 100px;
width: 100px;
margin: 0 auto;
border-radius: 50%;
}

With the template being:

Code: [Select]
							<li class="listlevel1 poster_avatar">
<a class="linklevel1" href="' . $scripturl . '?action=profile;u=' . $message['member']['id'] . '">
' . $message['member']['avatar']['image'] . '
</a>
</li>';

Also, syntax error here. You forgot the background-image lead in for the linear gradient, so that declaration gets dropped and in turn the one after it also gets dropped.

Code: [Select]
/* Hover effects for those buttons. */
.linklevel1.active:hover, .listlevel1:hover .linklevel1.active,
.linklevel1:hover .pm_indicator {
background: #DDE0E3; linear-gradient(to bottom, #DDE0E3, #EFF0F3);
box-shadow: 1px 1px 1px rgba(0, 0, 0, 0.3) inset;
color: #555;
}

Should be:

Code: [Select]
/* Hover effects for those buttons. */
.linklevel1.active:hover, .listlevel1:hover .linklevel1.active,
.linklevel1:hover .pm_indicator {
background: #DDE0E3;
background-image: linear-gradient(to bottom, #DDE0E3, #EFF0F3);
box-shadow: 1px 1px 1px rgba(0, 0, 0, 0.3) inset;
color: #555;
}
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Theme] Storm Cloud

Reply #19
Oh and I'm getting two undefined errors in the log.

Code: [Select]
Type of error: Undefined
8: Undefined index: image
http://127.0.0.1/Elk_latest/index.php?
File: K:/VertrigoServ/www/Elk_latest/themes/elk_theme_storm_cloud/GenericBoards.template.php (boardindex_outer_below sub template - eval?)
Line: 195

Type of error: Undefined
8: Undefined index: 0
http://127.0.0.1/Elk_latest/index.php?
File: K:/VertrigoServ/www/Elk_latest/themes/elk_theme_storm_cloud/GenericBoards.template.php (boardindex_outer_below sub template - eval?)
Line: 189

I haven't touched that template yet. Not me. Someone else dunnit.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Theme] Storm Cloud

Reply #20
Quote
Just making the anchor roundy and setting hidden overflow works. No need for object-fit or javascript. CSS just needs this:
I'll take a look at that ... for some reason I ended up using object fit but don't recall why, and then the JS was needed to cover  yet another Pale Moon issue.  

It may have been small or non square avatars that caused me to use object-ft, but I really don't recall anymore.

I'll check on the template error (you are using 1.0.7 yes?)

Squish squish. squish, squish, squish.
Find a bug,
Make a wish.

Re: [Theme] Storm Cloud

Reply #21
Yup, 1.07.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Theme] Storm Cloud

Reply #22
Yay! Another bug!  ;D

You've set the attachment blocks to a width of 24%. The problem is that it means clicking on the image thumbnail still leaves it as a maximum of 24% wide. IOW, about the same size as the thumbnail was anyway.

Haven't done a fix for this one yet, but it's not hard. While grumbling about this I checked the default theme too. That's had a change which borks the image scaling in attachments, so they now overflow the post div instead of fitting within it. Will also devise a fix for that, if I'm still feeling magnanimous.

 Antechinus will be starting to use grumpy emoticons soon. :P
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: [Theme] Storm Cloud

Reply #23
Yeah, I was going to mention this issue but figured you would enjoy finding it for yerself  O:-)

The quick fix is to use the fancybox addon, it works great with that markup, and I know in your loins you are a fan of lightbox's !

I think whats here is mostly the 1.1 markup which was done around the simple lightbox in place of the "expand in place and mess up the page layout" expand in place version we had in 1.0 ... which of course does no good since this is a 1.0 theme.  I'll take a shot at incorporating the changes you suggested in the other thread to fix this and allow the old expand in place js to work.
Squish squish. squish, squish, squish.
Find a bug,
Make a wish.

Re: [Theme] Storm Cloud

Reply #24
I love finding them if other people love fixing them. :D
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P