[1.0.5] theme bug with hamburger image?

[1.0.5] theme bug with hamburger image? Started by Jorin · November 16, 2015, 01:22:32 am · Read 9915 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

[1.0.5] theme bug with hamburger image?

November 16, 2015, 01:22:32 am

I installed 1.0.5 yesterday and today I find this. I am using a custom css file for my theme. I have this problem in both of my forums, and I'm browsing them with IE now. You can check here:

http://support.elkarte-hilfe.de/index.php/topic,2.0.html

It seems my custom css is missing something what's coming with 1.0.5? If so, maybe we have to find a way for future releases to prevent such problems when somebody is using a custom css file? If there is a way... $:-\$

Re: [1.0.5] theme bug with hamburger image?

Reply #1 – November 16, 2015, 08:40:38 am

The problem is you have to update the index.css of your theme with he few changes done to bring that little button there, so: first this and then this.

Odd Elk didn't try to install to the custom theme... or maybe the changes to custom themes have to be explicitly approved? I never tried, I should...

Re: [1.0.5] theme bug with hamburger image?

Reply #2 – November 16, 2015, 08:55:56 am

I had some error messages with the custom theme while the update proccess. As usual I ignored them. My own fault.

But I don't know why the package manager can't insert the new code into the custom css file.

I will try to fix it the next days. I am really busy this week. Thanks for pointing me in the right direction!

Re: [1.0.5] theme bug with hamburger image?

Reply #3 – November 16, 2015, 05:14:40 pm

I didn't use custom for a couple of reasons: 1) it may not be there, 2) it may already contain something that could override "core" declarations (even though that last one, for a new "feature" doesn't really make sense

Re: [1.0.5] theme bug with hamburger image?

Reply #4 – November 16, 2015, 07:18:25 pm

Quote from: Jorin – November 16, 2015, 08:55:56 amBut I don't know why the package manager can't insert the new code into the custom css file.

I remember it was pointing me to that with error, so I did it manually. But the Display.template.php fixes, I can't remember I was warned. Anyway, thanks for pointing that @emanuele .

Re: [1.0.5] theme bug with hamburger image?

Reply #5 – November 30, 2015, 10:38:18 am

Another problem with this: When I click on the button on my smartphone the button disappears and nothing else is happening.

Re: [1.0.5] theme bug with hamburger image?

Reply #6 – November 30, 2015, 12:03:03 pm

For me it works in all Themes.

http://elkarte.scaricare.de/index.php?action=forum

Re: [1.0.5] theme bug with hamburger image?

Reply #7 – November 30, 2015, 02:31:47 pm

it works because you are an admin or a moderator.

I just tryed on my forum with a normal account and I can confirm what Jorin said:

Quote from: Jorin – November 30, 2015, 10:38:18 amAnother problem with this: When I click on the button on my smartphone the button disappears and nothing else is happening.

Imo should be disabled for normal users

Re: [1.0.5] theme bug with hamburger image?

Reply #8 – November 30, 2015, 04:07:23 pm

Is this any different than what I reported before and is already being tracked?

http://www.elkarte.net/community/index.php?topic=2997.0

Re: [1.0.5] theme bug with hamburger image?

Reply #9 – December 01, 2015, 01:17:50 am

No, not different, it's the same. Sorry. I missed your topic.

Re: [1.0.5] theme bug with hamburger image?

Reply #10 – December 01, 2015, 04:29:03 am

Have you loaded a .css from Bootstrap?

Re: [1.0.5] theme bug with hamburger image?

Reply #11 – December 01, 2015, 06:02:58 am

As this is happening here, @emanuele should answer this.

Re: [1.0.5] theme bug with hamburger image?

Reply #12 – December 01, 2015, 06:48:13 am

You have on your board the same problem

Re: [1.0.5] theme bug with hamburger image?

Reply #13 – December 01, 2015, 07:06:39 am

I haven't made the changes @emanuele posted here till now:

Quote from: emanuele – November 16, 2015, 08:40:38 amThe problem is you have to update the index.css of your theme with he few changes done to bring that little button there, so: first this and then this.

Odd Elk didn't try to install to the custom theme... or maybe the changes to custom themes have to be explicitly approved? I never tried, I should...

The problem posted here:

Quote from: Jorin – November 30, 2015, 10:38:18 amAnother problem with this: When I click on the button on my smartphone the button disappears and nothing else is happening.

...is another one with the button. I think.

Re: [1.0.5] theme bug with hamburger image?

Reply #14 – December 01, 2015, 08:07:39 am

In my ElkArte demo board works the hamburger menu. That's why I do not understand it why it does not work here and in your board.