Skip to main content
Topic: ssi_boardNews(); doesn't show news title (Read 1522 times) previous topic - next topic
0 Members and 1 Guest are viewing this topic.

ssi_boardNews(); doesn't show news title

You can see it even here: http://www.elkarte.net/community/ssi_examples.php
Find ssi_boardNews and click on it - news title is missing, for this one I did not found solution yet.

I guess I will find more SSI bugs, because I'm makin homepage with it ::)

/edit:

Not sure if it's correct way to 'fix' this, but title is visible after this one edit in SSI.php:
Code: (Find) [Select]
$row['body'] = $row[$preview . '_body'];
Code: (Add after) [Select]
		$row['subject'] = $row[$preview . '_subject'];

Re: ssi_boardNews(); doesn't show news title

Reply #1
Yep, correct fix... thanks! ;D

 emanuele should pay more attention on refactoring and code replacement.
Bugs creator.
Features destroyer.
Template killer.


Re: ssi_boardNews(); doesn't show news title

Reply #3
It's not worth to open new topic, so here's another line that needs change in this function:

Now ssi_boardNews is using member name as author name. It should be display name, so:
Code: (Find) [Select]
$row['poster_name'] = $row[$preview . '_member_name'];
Code: (Replace with) [Select]
$row['poster_name'] = $row[$preview . '_display_name'];


Re: ssi_boardNews(); doesn't show news title

Reply #5
somehow 1.0.6 still has first bug (with wrong subject row), but now this:
Code: [Select]
$row['subject'] = $row[$preview . '_body'];
should be changed to:
Code: [Select]
$row['subject'] = $row[$preview . '_subject'];

I think that something went wrong here https://github.com/emanuele45/Dialogo/commit/437ed6a6fa08b7358706cf3615140f44bcea8799  ::)

Re: ssi_boardNews(); doesn't show news title

Reply #6
I reopened the bug.
Actually it was never fixed...
Bugs creator.
Features destroyer.
Template killer.

Re: ssi_boardNews(); doesn't show news title

Reply #7
@emanuele #MoveRequest until fully fixed?
~ SimplePortal Support Team ~

 

Re: ssi_boardNews(); doesn't show news title

Reply #8
No need, it's already tracked at github.
Bugs creator.
Features destroyer.
Template killer.