Skip to main content ↑ ↓
Site upgrading (or site breaking!) Started by TestMonkey · · Read 12949 times 0 Members and 3 Guests are viewing this topic. previous topic - next topic

Site upgrading (or site breaking!)

Sorry for posting on the run, just a heads-up for the moment: we had a quite eventful upgrade of the site a few hours ago - and we're still fixing one thing or another. The time taken with the site upgrade this time didn't go unpunished! Some of the most unusual breaks were due to either very silly bugs (argh, testing and reviews), or to caches.

Please report everything you still find (on github or here - I hope!), we'll be back on them silly bugs to squash them.

On another note, I've removed a few themes from the site. Apart from the default, I've left Minimalistic only at this time. Sorry if it's inconvenient, but they didn't seem very used anyway (older themes or basic color variations).
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: Site upgrading (or site breaking!)

Reply #1 –

Luckily Elk is back  :) Was probably a painful upgrade, couldn't help that much due to RL (10 years married today  :D ).. We should definitely spend more time on testing & reviewing..
Thorsten "TE" Eurich
------------------------

Re: Site upgrading (or site breaking!)

Reply #2 –

Nah, not painful, but it surely had surprises. For example email-related features, like sending notifications, weren't tested locally (may not be too easy to test manually either) and we cleaned up their code once errors appeared on the site.

One other example for us to note and address: post modify was broken because during reworking of the codebase, the wrong low-level function was used. This is an interesting aspect because the available functions themselves were confusing: there were three functions, we had messageInfo(), getMessageInfo() and getExistingMessage(), all retrieving post information, more or less! Now that was a bit of a surprise, and yet again not really surprising: because sometimes, we had indeed refactored the code in localized places, and put in that place a working .subs function for that need. Then, next time the same. And sometimes, when we wanted to expand its use, we have taken the first function which behaves close enough (again, normal). This approach is very good to change step by step, whenever it's actually needed and with what is the real need. (as opposed to something over-designed, which you ain't gonna need).

But then, this approach has to be combined with the next: we have to be flexible enough to quickly see and address consistency with what existed already. To further refactor them as necessary to serve system-wide needs. We can take a step back, look at what we have, and use the knowledge gained in the process to tweak them and make them reusable in an understandable way. The current way wasn't understandable. (hah!)

I think messages, topics, and boards, the core 'entities' of the system, are more likely than any, to have a larger set of functions around them. I added some fixes for those three at the moment, but this remains an open issue: all the data needed about posts is different and there are a lot of info needed. We can consolidate them better methinks. If we don't see yet how, perhaps after more uses we can revisit them.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: Site upgrading (or site breaking!)

Reply #3 –

Oh, and there's no 'new' icon to show when a thread has new posts...

Re: Site upgrading (or site breaking!)

Reply #4 –

Quote from: Arantor – Oh, and there's no 'new' icon to show when a thread has new posts...
I suspect I made an over-zealous commit at a point, that broke something about this stupidly. But, the current code on the site works for me... Where isn't there a 'new' icon? On message index it shows for me... In board index it's shown too. Will re-test and look again into it.
The best moment for testing your PR is right after you merge it. Can't miss with that one.
 

Re: Site upgrading (or site breaking!)

Reply #5 –

It's now showing but before I mentioned it, no thread had a 'new' icon in the message index at all, even if they had unread items.

Re: Site upgrading (or site breaking!)

Reply #6 –

No, you're right, that's what it did. It updated log_mark_read on simple view of message index. I intended to come back on read/unread, and I forgot, missing this, and it got in the dev version on site. (same for display, probably, in specific cases)
If this bit doesn't make me a serious contender for Ema's title, I don't know what does...

It's not fixed in the repo yet, I'll be on it asap though.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: Site upgrading (or site breaking!)

Reply #7 –

Hmm, looks like you have a bit of css missing after that sync. I know this effect. I'll find it. It's fine on my local, so it should be easy to find. :)

ETA: ooooo, now sumpin else funny. :D

I didn't realise you'd be trying to run the merged stuff with the old SMF theme live. That's going to cause problems.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Site upgrading (or site breaking!)

Reply #8 –

the blue theme seems broken at all, but the new default (variant=white) is broken, too... All menu buttons are white (and therefore hidden), except the active one ;)
Thorsten "TE" Eurich
------------------------

Re: Site upgrading (or site breaking!)

Reply #9 –

That's coz half the css is missing here. I can tell it is. :D It's totally stable on my local, running the same code I handed over the other day. So, something has gone wrong between then and now.

ETA: It looks like you're trying to run half the new code, and half the old 2.1 alpha theme.

ETA2: Looks like there might be markup problems too.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Site upgrading (or site breaking!)

Reply #10 –

Fixed a few missing stuffs! It should work now... Except it doesn't. This is the current git version. (today's)

_white works for you now?

Quote from: TE – the blue theme seems broken at all, but the new default (variant=white) is broken, too... All menu buttons are white (and therefore hidden), except the active one ;)
Weird. Their background is green, it applies index.css and not white...
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: Site upgrading (or site breaking!)

Reply #11 –

Yayyyyyyyyyyyyyyyyy! It's looking mostly right now. ;D

Will hunt around a bit and see if I can spot anything.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Site upgrading (or site breaking!)

Reply #12 –

As far as I can tell, it looks right for how far I've got (which wasn't all that far in the scheme of things).

I'll sync my local up with this build before I go further.

ETA: Oh and there's nothing in _white.css yet. It's still a placeholder (as per discussion yesterday).
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P

Re: Site upgrading (or site breaking!)

Reply #13 –

This green/grey combo is just lovely! I re-enabled variant selection, and white is default. But they seem completely messed up among each other. Testing the others.
The best moment for testing your PR is right after you merge it. Can't miss with that one.

Re: Site upgrading (or site breaking!)

Reply #14 –

Yeah I thought it was a nice combo. :) I find it very pleasant to work with.
Master of Expletives: Now with improved family f@&king friendliness! :D

Sources code: making easy front end changes difficult since 1873. :P