Skip to main content ↑ ↓
Newlines in signatures don't work Started by live627 · · Read 5661 times 0 Members and 1 Guest are viewing this topic. previous topic - next topic

Newlines in signatures don't work

Tried adding
Code: [Select]
test
to my sig after three newlines and it didn't update. The preview still works.
LiveGallery - Simple gallery addon for ElkArte

Re: Newlines in signatures don't work

Reply #1 –

The bug might be how the Maximum amount of lines setting is communicated to the user rather than a bug in the system itself.

Re: Newlines in signatures don't work

Reply #2 –

IIRC the preview should consider limitations as well (but I may wrong, of course).
That said, I don't remember what kind of limits we have here...
Bugs creator.
Features destroyer.
Template killer.

Re: Newlines in signatures don't work

Reply #3 –

By my tests, multiple new lines are trimmed down to one.

So I guess it is kind of intended.
That said, is this an acceptable behaviour?
Or it is better to let new lines be?
Bugs creator.
Features destroyer.
Template killer.

Re: Newlines in signatures don't work

Reply #4 –

Quote from: emanuele – IIRC the preview should consider limitations as well (but I may wrong, of course).
You're wrong. :P (It doesn't, at least not on this site.)

The problem is merely that the user doesn't know that the reason their signature is only displaying x lines is because it's trimmed down to x lines.

For a realtime JS thingy you'd need a simple line number thingy along these lines

Code: [Select]
function getLineNumber(element) {
  return element.val().split('\n').length;
}

and a simple onkeyup or something that checks whether that's smaller than or equal to the limit.

I mean that similar to how it says "Max characters: 300; characters remaining: 300"

Also you get an error from the server if you try to update your profile:
Quote The following errors occurred when trying to update your profile:

    Your signature cannot be greater than 300 characters

That doesn't happen for newlines.
 

Re: Newlines in signatures don't work

Reply #5 –

Good point. nods
Bugs creator.
Features destroyer.
Template killer.

Re: Newlines in signatures don't work

Reply #6 –

PR, BR, or FR

Re: Newlines in signatures don't work

Reply #7 –

QR
LiveGallery - Simple gallery addon for ElkArte